no problems :) this is just one of those.. "don't do that" things. :)

for evlog - it wouldnt be too happy jumping through another func to get time - it'd want it inlined... we can do this for ecore_time_get but it'd have to be done in a way where we can cut the overhead as much as possible for performance sensitive areas

hmmmm... this is super performance sensitive... it can't add overhead... so i'm not so sure...

hmm. that only will detect if the relative item is the end of a list - if its the middle of another list it won't find it. that's not a lot of detected problems given it'll totally not see the problem with all the others...

we could make a verify func you can call to see a list/inlist are sane but it will only tell you when you call it. it's a tool to help narrow down the problem...

how can you detect this when it happens (in a generic way) that is very low overhead?

only one small thing... :)

mostly solved with b158abfabba220201ddb573d75ba4a48b586f152 and 534457c51d0afc9a3a50a71bb0823e786f0b1bb8 but... this could be a bit cleaner i the code was just moved into gengrid/list?

we don't need an avif example.. or even a webp example. all we need is a simple "show any given image file" example. if the reason it "we need tests" then this is a problem a avif is optional thus it'll fail when not enabled. do not take the webp example as the right thing to do here... it's the wrong thing. it's just more pain to maintain specific src for specific image formats when 1 src can do all of them (just pass in path to file on cmdline).

as per reopen... :(

you're going to hate me... but this breaks layout in enlightenment's systray gadget (run steam, ms teams, riot app, discord, ... pick your systray/statusnotifier user of choice) or just use elementary_test and check the "systray item" test. without this change, icons appear. with it, they do not.

cool :)

You would just need to see the result and know to "reduce the alpha" because it's too dark etc. ... at least a developer who knows anything about graphics would try that at least to see what happens... designers see the feedback immediately - and can just adjust a slider or value if they use tools like enventor :) so you know by trying. soft shadow also doesn't scale with scaling as it has been drawn with N pixels outline.. there are other "bugs" that are just a result of history and that changing them breaks things. you need a new kind of shadow/outline mode to change this, so SOFT_SHADOW2 or SHADOW2 etc. ... and yhen these can be made to scale and calculate colors differently. :)

Also rsvg will do filters like blur etc. ... for rsvg to be removed evas's own svg rendering must support everything rsvg does. i don't think e support a lot of the more
"interesting" parts of svg. i'd want to see a test suite to show we do first that has a wide range of svg files produced by many sources (inkscape and other tools) so it handles even extended svg's properly and filters like blur and so on...

This has always been the case and so in theme or code you set alpha to a lower amount. all themes and designs have done this already. this would break all those themes and make their shadows or outline etc. essentially disappear. you can't change rendering like this. the place to deal with it always has been in the caller (this comes from edje originally with N objects and was moved into evas as part of its drawing cycle). so this just will break all of that visually for something that can be handled by just providing a lower opacity for soft shadows and glows in the first place.

ssorry - didnt mean to push yet. waiting on saver and endianess check

all looks good except for that one possible endianess issues.

aaah ok so now you're just taking the "don't bother making dnd work within ibox" right?

i cant dnd into ibox anymore from a window border icon.... no display that i can possibly drop here either...

hmm no - e is running. the backtrace says so. it's in its normal select loop... something else has caused rendering to stop. this doesn't say what though... you can just restart e (ctrl+alt+end) to get it going again as its happily listening to events.

looks ok to me :)

looking better indeed

sorry - this breaks tests and also breaks everything launcher in enlightenment too - like totally breaks the layout.

actually.. testing this...

do you think you could add your test app there to elementary_test as another test win/dialog?

fyi as i cant reproduce... i can work around it and reduce it by removing invalid handles when found:

I don't see this... open xfce terminal. Close it.. no complaints. The backtrace seems a little odd as e_livethumb_thumb_get() doesn't call any functions at all. e_client_focus_set_with_pointer() doesn't call e_exec_startup_id_pid_instance_find(). It looks ok for a bvit then, but then the backtrace goes odd again. e_exec_startup_id_pid_instance_find() walks the hash with a foreach using _e_exec_startup_id_pid_find to look at each entry aand it calls ecore_exe_pid_get() but it does not call e_error_message_show_internal()...

ok. find with _beginthreadex(). a windows thing that _xxx funcs are ok... :|

i have to say that i also am not a fan of this. it's controversial at best. i see the value but it also quickly becomes a "can of worms" you open up and then the mess is everywhere... if we were to build dependencies e should do it like we do static deps - we explicitly suck in code and explicitly compile it as part of our tree with explicitly chosen options etc. so we'd ne more like chromium/blink and such codebases then... we should do this very selectively only when there is a really good reason. right now i don't see one here... :(

as per inline comments

aaah warning fixes. ok.

oh no. the return at the top shouldnt be there... that was some debug that stayed in and wasn't caught... so no... leave it! :)

Actually, yes, it does get both.

hmm this is odd. what if you use import -window root out.png ? does it get both?

also solved now

do we really need 1.1.0? i have a debian installation my rockpro64 and it compiles and runs fine with 0.6.1. it can load webp images. no symbol errors, crashes or compile errors. i am thinking of dropping this down to 0.6.1 as at least empirically that is good enough (and it'd allow the CI build envs to re-enable webp again). upstream libwebp added WebPAnimDecoder in d39dc8f3cc07f0fffb73def2125ddcdf8073eafcwhich was back in september 2015. 0.6.1 came out nov 2017. so i think this is safe. possibly earlier versions might be fine too. 0.5.0 probably is the baseline for this actually (came out end of 2015 or so), but i can confirm 0.6.1 is seemingly fine. in fact i think i will drop it to 0.5.0 and then see if people complain because the anim api did come out in 0.5.0

BTW. cunning use of the new shot diagram tools! excellent to see! malloc should say something other than sample text though... so i see a bug in your screenshot. :)

also solved by b519c44c6716518f750984f7ff0540173fccbc00

looks harmless enough to me... but i won't commit/push this at this point. wait a bit.

yes.

invalid as not something to fix... its how its meant to work.

Even if I add and mount the disks in the fstab file, I cannot see the icon on the desktop or on the efm side panel. I have to open the directory I linked to. Eg /media/sda4

solved by e89822467210

oops mis-closed wrong task

i don't even think it's a wishlist. it just isn't useful. the filesystems are (or should be) mounted already,. if the user was a shortcut to them they can symlink one from their favorites dir or something.... but efm absolutely shouldn't show /boot or /boot/uefi or /home or /opt or whatever if they are different partitions mounted... the point is they are mounted so your fs looks like a seamless tree... :)

hmm so i tried to reproduce your issue. i get a dialog:

can we not cal it texture_cache? as this also applies to software also not long but int will do like the other caches. if people need > 2gb of cache for this... they have problems :) so maybe evas_font_data_cache_set/get(). ?

efm doesn't have to mount it... it should already be mounted by /etc/fstab if its a fixed partition. filemanagers do need to deal with mounting "dynamic stuff" like removable devices that come and go... :)

don't take this the wrong way, but i think 90% of the time you'r chasing the wrong thing. the compiler already does this. you need to find the cases where the compiler does NOT do something smart ... (and -O0 doesn't count! -O2/3 should be what you worry about). just trying to encourage you to focus on the valuable things. reviewing patches that actually make no difference (and possibly make it harder to read/follow/understand) is not useful for reviewers or for you in creating the patches :) focus on the value bits... if you want pointers into what could do with speedups that i am pretty sure are a win in almost all if not all cases on average, then let's have a chat :).

more important: at normal optimizations (-O2 is pretty normal for production builds or even -O3), does this actually remove a sqrt() function or is the compiler already detecting a sqrt with a constant and pre-calculating it? :) because... looking at the asm output of the compiler.. it figures out that its a constant... even at -O0. it still optimizes it to a constant. compare the asm output of:

just saying... -O0 is not a way to say "oh i've made it faster at O0". there is a line between more readable and faster code. your code changes here are NO faster as the default is -O1 anyway so the compiler converts these to constants at compile time UNLESS you use -O0 ... which is just invalid to consider a case to speed up.

efm is not meant to show "hard disk mount points". that is an explicit choice not to. it is only looking for devices tagged as removable devices by udisks. sometimes udisks says some partitions that are mounted are removable. i know i certainly don't test the non-udisks path as that's just not normal on arch.

looks like you found a logic hole... :) yay for too many options! :) btw - this happens even without switching desks.. i see my pointer jump to a spot with no window (but where one should be).

if you screenshot while the lid is closed and the mouse goes there - does the shot cover all screens? is one all black? or have content?

Ok, so, I should have "Suspend even if AC" when I am also using "suspend intelligently"

what is the name of the laptop screen output? like eDP0 or LVDS0 or something? in screen setup for your laptop lid screen is "laptop lid" checked? (it's not a setting you change - it's something e detects). you can just run xrandr on the cmdline to list output names like LVDS0/1/2, eDP0/2/3, DP0/1/2, HDMI-0, etc. etc.