Page MenuHomePhabricator

raster (Carsten Haitzler (Rasterman))Administrator
Keeper of the rabid stoat

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 27 2013, 4:24 PM (393 w, 1 d)
Roles
Administrator
Availability
Available

Behold... the rabid stoat! Prostrate yourselves before it before it is too late!

Recent Activity

Fri, Aug 7

raster closed D12095: evil: Remove OS version check.
Fri, Aug 7, 4:19 PM · efl
raster accepted D12095: evil: Remove OS version check.
Fri, Aug 7, 11:19 AM · efl

Tue, Aug 4

raster added a comment to T8770: Exception handling for invalid eina_inlist use cases.

no problems :) this is just one of those.. "don't do that" things. :)

Tue, Aug 4, 2:47 AM

Sun, Jul 26

raster added a comment to T8777: adding eina_time_get().

for evlog - it wouldnt be too happy jumping through another func to get time - it'd want it inlined... we can do this for ecore_time_get but it'd have to be done in a way where we can cut the overhead as much as possible for performance sensitive areas

Sun, Jul 26, 6:22 AM · efl
raster added a comment to T8777: adding eina_time_get().

hmmmm... this is super performance sensitive... it can't add overhead... so i'm not so sure...

Sun, Jul 26, 4:51 AM · efl

Fri, Jul 24

raster closed D11943: evas: font glyphs texture garbage collector.
Fri, Jul 24, 2:46 AM · efl
raster accepted D11943: evas: font glyphs texture garbage collector.
Fri, Jul 24, 2:42 AM · efl

Wed, Jul 22

raster added a comment to T8770: Exception handling for invalid eina_inlist use cases.

hmm. that only will detect if the relative item is the end of a list - if its the middle of another list it won't find it. that's not a lot of detected problems given it'll totally not see the problem with all the others...

Wed, Jul 22, 1:41 AM

Tue, Jul 21

raster added a comment to T8770: Exception handling for invalid eina_inlist use cases.

we could make a verify func you can call to see a list/inlist are sane but it will only tell you when you call it. it's a tool to help narrow down the problem...

Tue, Jul 21, 5:14 AM
raster added a comment to T8770: Exception handling for invalid eina_inlist use cases.

how can you detect this when it happens (in a generic way) that is very low overhead?

Tue, Jul 21, 5:12 AM
raster requested changes to D11943: evas: font glyphs texture garbage collector.

only one small thing... :)

Tue, Jul 21, 3:11 AM · efl
raster added a comment to T8748: Performance Issue in ELM_WIDGET_ITEM_STATIC_FOCUS_CLASS class.

mostly solved with b158abfabba220201ddb573d75ba4a48b586f152 and 534457c51d0afc9a3a50a71bb0823e786f0b1bb8 but... this could be a bit cleaner i the code was just moved into gengrid/list?

Tue, Jul 21, 1:26 AM

Mon, Jul 20

raster requested changes to D12061: Add avif elm example.

we don't need an avif example.. or even a webp example. all we need is a simple "show any given image file" example. if the reason it "we need tests" then this is a problem a avif is optional thus it'll fail when not enabled. do not take the webp example as the right thing to do here... it's the wrong thing. it's just more pain to maintain specific src for specific image formats when 1 src can do all of them (just pass in path to file on cmdline).

Mon, Jul 20, 2:58 AM · efl

Sun, Jul 19

raster closed D12058: Eina log: flush stderr on mintty-based terminals.
Sun, Jul 19, 10:28 AM · efl
raster accepted D12058: Eina log: flush stderr on mintty-based terminals.
Sun, Jul 19, 10:26 AM · efl

Fri, Jul 17

raster requested changes to D12055: edje: Avoid string duplication when possible..

as per reopen... :(

Fri, Jul 17, 2:40 AM · efl
raster reopened D12055: edje: Avoid string duplication when possible..

you're going to hate me... but this breaks layout in enlightenment's systray gadget (run steam, ms teams, riot app, discord, ... pick your systray/statusnotifier user of choice) or just use elementary_test and check the "systray item" test. without this change, icons appear. with it, they do not.

Fri, Jul 17, 2:37 AM · efl

Thu, Jul 16

raster added a comment to T8319: [EFL 1.22.3][E 0.23.1] Error loop in .xsession-errors when closing xfce4-terminal.

cool :)

Thu, Jul 16, 5:39 AM
raster closed D12055: edje: Avoid string duplication when possible..
Thu, Jul 16, 3:40 AM · efl
raster accepted D12055: edje: Avoid string duplication when possible..
Thu, Jul 16, 3:39 AM · efl
raster requested changes to D11943: evas: font glyphs texture garbage collector.
Thu, Jul 16, 3:30 AM · efl
raster closed D12054: edje_cc : resolve build warning.
Thu, Jul 16, 2:01 AM · efl
raster accepted D12054: edje_cc : resolve build warning.
Thu, Jul 16, 1:58 AM · efl
raster added a comment to D12053: evas: fix over repeated shadow color for soft shadow effect.

You would just need to see the result and know to "reduce the alpha" because it's too dark etc. ... at least a developer who knows anything about graphics would try that at least to see what happens... designers see the feedback immediately - and can just adjust a slider or value if they use tools like enventor :) so you know by trying. soft shadow also doesn't scale with scaling as it has been drawn with N pixels outline.. there are other "bugs" that are just a result of history and that changing them breaks things. you need a new kind of shadow/outline mode to change this, so SOFT_SHADOW2 or SHADOW2 etc. ... and yhen these can be made to scale and calculate colors differently. :)

Thu, Jul 16, 1:57 AM · efl

Wed, Jul 15

raster closed D12051: Evas: add avif evas loader and saver.
Wed, Jul 15, 11:17 AM · efl
raster accepted D12051: Evas: add avif evas loader and saver.
Wed, Jul 15, 11:16 AM · efl
raster requested changes to D6530: stop librsvg dependency..

Also rsvg will do filters like blur etc. ... for rsvg to be removed evas's own svg rendering must support everything rsvg does. i don't think e support a lot of the more
"interesting" parts of svg. i'd want to see a test suite to show we do first that has a wide range of svg files produced by many sources (inkscape and other tools) so it handles even extended svg's properly and filters like blur and so on...

Wed, Jul 15, 5:29 AM · efl
raster requested changes to D12053: evas: fix over repeated shadow color for soft shadow effect.

This has always been the case and so in theme or code you set alpha to a lower amount. all themes and designs have done this already. this would break all those themes and make their shadows or outline etc. essentially disappear. you can't change rendering like this. the place to deal with it always has been in the caller (this comes from edje originally with N objects and was moved into evas as part of its drawing cycle). so this just will break all of that visually for something that can be handled by just providing a lower opacity for soft shadows and glows in the first place.

Wed, Jul 15, 5:25 AM · efl

Tue, Jul 14

raster reopened D12051: Evas: add avif evas loader and saver.

ssorry - didnt mean to push yet. waiting on saver and endianess check

Tue, Jul 14, 2:55 AM · efl
raster closed D12052: docs: Correct the wrong API group name and typo in Evas, Eet, Eina, Eio and Elementary.
Tue, Jul 14, 2:11 AM · efl
raster closed D12051: Evas: add avif evas loader and saver.
Tue, Jul 14, 2:11 AM · efl
raster accepted D12052: docs: Correct the wrong API group name and typo in Evas, Eet, Eina, Eio and Elementary.
Tue, Jul 14, 2:09 AM · efl

Sun, Jul 12

raster closed D12050: ibox: dnd behaviour..
Sun, Jul 12, 1:58 AM · enlightenment-git
raster accepted D12050: ibox: dnd behaviour..
Sun, Jul 12, 1:57 AM · enlightenment-git

Jul 11 2020

raster requested changes to D12051: Evas: add avif evas loader and saver.

all looks good except for that one possible endianess issues.

Jul 11 2020, 3:45 AM · efl

Jul 9 2020

raster updated the task description for T6726: E/EFL Flat Theme.
Jul 9 2020, 5:08 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster added a comment to D12050: ibox: dnd behaviour..

aaah ok so now you're just taking the "don't bother making dnd work within ibox" right?

Jul 9 2020, 4:33 AM · enlightenment-git
raster closed D12049: docs: Correct the wrong API group name in Elementary and Change an invalid URL in Evas.
Jul 9 2020, 2:30 AM · efl
raster accepted D12049: docs: Correct the wrong API group name in Elementary and Change an invalid URL in Evas.
Jul 9 2020, 2:13 AM · efl

Jul 8 2020

raster requested changes to D12048: ibox: icon movement.

i cant dnd into ibox anymore from a window border icon.... no display that i can possibly drop here either...

Jul 8 2020, 9:01 AM · enlightenment-git

Jul 7 2020

raster added a comment to T8319: [EFL 1.22.3][E 0.23.1] Error loop in .xsession-errors when closing xfce4-terminal.

hmm no - e is running. the backtrace says so. it's in its normal select loop... something else has caused rendering to stop. this doesn't say what though... you can just restart e (ctrl+alt+end) to get it going again as its happily listening to events.

Jul 7 2020, 10:07 AM
raster closed D12046: ibox: Add Live Preview Optional View..
Jul 7 2020, 8:14 AM · enlightenment-git
raster accepted D12047: ibox: Preview Theme Code.

looks ok to me :)

Jul 7 2020, 7:42 AM · efl
raster added a comment to D12046: ibox: Add Live Preview Optional View..

looking better indeed

Jul 7 2020, 7:42 AM · enlightenment-git
raster closed D12039: Windows: remove Evil dependency, general cleanup for Windows.
Jul 7 2020, 6:24 AM
raster accepted D12039: Windows: remove Evil dependency, general cleanup for Windows.
Jul 7 2020, 5:45 AM
raster requested changes to D12045: edje: Avoid string duplication when possible..
Jul 7 2020, 4:44 AM · efl
raster reopened D12045: edje: Avoid string duplication when possible..

sorry - this breaks tests and also breaks everything launcher in enlightenment too - like totally breaks the layout.

Jul 7 2020, 4:44 AM · efl
raster closed D12045: edje: Avoid string duplication when possible..
Jul 7 2020, 3:26 AM · efl
raster accepted D12045: edje: Avoid string duplication when possible..
Jul 7 2020, 3:22 AM · efl
raster requested changes to D12046: ibox: Add Live Preview Optional View..
Jul 7 2020, 3:19 AM · enlightenment-git

Jul 6 2020

raster added inline comments to D11943: evas: font glyphs texture garbage collector.
Jul 6 2020, 7:05 AM · efl
raster requested changes to D12039: Windows: remove Evil dependency, general cleanup for Windows.

actually.. testing this...

Jul 6 2020, 6:52 AM
raster requested changes to D11943: evas: font glyphs texture garbage collector.
Jul 6 2020, 5:43 AM · efl
raster added a comment to D11943: evas: font glyphs texture garbage collector.

do you think you could add your test app there to elementary_test as another test win/dialog?

Jul 6 2020, 5:43 AM · efl
raster closed D11861: evas_text: lazy loading color glyph images in RAM.
Jul 6 2020, 5:04 AM · efl
raster accepted D11861: evas_text: lazy loading color glyph images in RAM.
Jul 6 2020, 5:00 AM · efl

Jul 3 2020

raster accepted D12039: Windows: remove Evil dependency, general cleanup for Windows.
Jul 3 2020, 4:25 AM

Jul 1 2020

raster added a comment to T8319: [EFL 1.22.3][E 0.23.1] Error loop in .xsession-errors when closing xfce4-terminal.

fyi as i cant reproduce... i can work around it and reduce it by removing invalid handles when found:

Jul 1 2020, 5:29 AM
raster added a comment to T8319: [EFL 1.22.3][E 0.23.1] Error loop in .xsession-errors when closing xfce4-terminal.

I don't see this... open xfce terminal. Close it.. no complaints. The backtrace seems a little odd as e_livethumb_thumb_get() doesn't call any functions at all. e_client_focus_set_with_pointer() doesn't call e_exec_startup_id_pid_instance_find(). It looks ok for a bvit then, but then the backtrace goes odd again. e_exec_startup_id_pid_instance_find() walks the hash with a foreach using _e_exec_startup_id_pid_find to look at each entry aand it calls ecore_exe_pid_get() but it does not call e_error_message_show_internal()...

Jul 1 2020, 5:26 AM

Jun 30 2020

raster added a comment to D12037: Implement eina_thread for native windows.

ok. find with _beginthreadex(). a windows thing that _xxx funcs are ok... :|

Jun 30 2020, 2:05 AM · efl
raster added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

i have to say that i also am not a fan of this. it's controversial at best. i see the value but it also quickly becomes a "can of worms" you open up and then the mess is everywhere... if we were to build dependencies e should do it like we do static deps - we explicitly suck in code and explicitly compile it as part of our tree with explicitly chosen options etc. so we'd ne more like chromium/blink and such codebases then... we should do this very selectively only when there is a really good reason. right now i don't see one here... :(

Jun 30 2020, 1:12 AM · efl
raster added a comment to D12037: Implement eina_thread for native windows.

as per inline comments

Jun 30 2020, 1:08 AM · efl

Jun 21 2020

raster updated the task description for T6726: E/EFL Flat Theme.
Jun 21 2020, 1:03 PM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project

Jun 20 2020

raster requested changes to D12015: Fix typos.
Jun 20 2020, 11:33 AM · efl
raster closed D11972: eina_unicode: have explicit type conversions.
Jun 20 2020, 3:43 AM · efl
raster accepted D11972: eina_unicode: have explicit type conversions.

aaah warning fixes. ok.

Jun 20 2020, 3:38 AM · efl

Jun 19 2020

raster updated the task description for T6726: E/EFL Flat Theme.
Jun 19 2020, 5:31 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project

Jun 18 2020

raster closed D11973: meson: add Solaris support.
Jun 18 2020, 6:37 AM · efl

Jun 17 2020

raster requested changes to D11981: evas_ gl_common: forgotten enable vertex_array_size_check.

oh no. the return at the top shouldnt be there... that was some debug that stayed in and wasn't caught... so no... leave it! :)

Jun 17 2020, 3:56 AM · efl
raster added a comment to T8729: Hotplug display issues - Enlightenment 0.24.0 .

Actually, yes, it does get both.

Jun 17 2020, 2:50 AM · enlightenment-git

Jun 14 2020

raster added a comment to T8729: Hotplug display issues - Enlightenment 0.24.0 .

hmm this is odd. what if you use import -window root out.png ? does it get both?

Jun 14 2020, 5:19 AM · enlightenment-git
raster closed T8752: Pager popup should use a swallow element if available as Resolved.

also solved now

Jun 14 2020, 5:14 AM · enlightenment-git
raster added a comment to D11926: webp: add version check in configuration time.

do we really need 1.1.0? i have a debian installation my rockpro64 and it compiles and runs fine with 0.6.1. it can load webp images. no symbol errors, crashes or compile errors. i am thinking of dropping this down to 0.6.1 as at least empirically that is good enough (and it'd allow the CI build envs to re-enable webp again). upstream libwebp added WebPAnimDecoder in d39dc8f3cc07f0fffb73def2125ddcdf8073eafcwhich was back in september 2015. 0.6.1 came out nov 2017. so i think this is safe. possibly earlier versions might be fine too. 0.5.0 probably is the baseline for this actually (came out end of 2015 or so), but i can confirm 0.6.1 is seemingly fine. in fact i think i will drop it to 0.5.0 and then see if people complain because the anim api did come out in 0.5.0

Jun 14 2020, 4:07 AM · efl

Jun 13 2020

raster added a comment to T8753: Wrong sizing of pager in shelf.

BTW. cunning use of the new shot diagram tools! excellent to see! malloc should say something other than sample text though... so i see a bug in your screenshot. :)

Jun 13 2020, 4:38 PM · Restricted Project
raster closed T8753: Wrong sizing of pager in shelf as Resolved.

also solved by b519c44c6716518f750984f7ff0540173fccbc00

Jun 13 2020, 4:37 PM · Restricted Project
raster added a commit to T8314: Pager gadget broken after to change the number of virtual desktops: rE653a456a0215: pager+thumb - speed up thumb generation and pager aspect.
Jun 13 2020, 8:23 AM · enlightenment-git
raster closed T8314: Pager gadget broken after to change the number of virtual desktops as Resolved by committing rEb519c44c6716: pager+thumb - speed up thumb generation and pager aspect.
Jun 13 2020, 8:22 AM · enlightenment-git
raster accepted D11973: meson: add Solaris support.

looks harmless enough to me... but i won't commit/push this at this point. wait a bit.

Jun 13 2020, 6:06 AM · efl

Jun 12 2020

raster added a comment to T8750: [Optimization] Replacement of x,y,w,h with Eina_Rect.

yes.

Jun 12 2020, 3:08 AM · efl
raster closed T7133: Hdd partitions are not shown in EFM as Invalid.

invalid as not something to fix... its how its meant to work.

Jun 12 2020, 3:08 AM · enlightenment-git, Restricted Project, efl: system integration

Jun 10 2020

raster added a comment to T7133: Hdd partitions are not shown in EFM.

Even if I add and mount the disks in the fstab file, I cannot see the icon on the desktop or on the efm side panel. I have to open the directory I linked to. Eg /media/sda4

Jun 10 2020, 2:09 AM · enlightenment-git, Restricted Project, efl: system integration

Jun 9 2020

raster closed T8746: Wrong desktop files makes E to crash as Resolved.

solved by e89822467210

Jun 9 2020, 6:26 PM · enlightenment-git
raster added a comment to T7133: Hdd partitions are not shown in EFM.

oops mis-closed wrong task

Jun 9 2020, 6:25 PM · enlightenment-git, Restricted Project, efl: system integration
raster reopened T7133: Hdd partitions are not shown in EFM as "Open".
Jun 9 2020, 6:25 PM · enlightenment-git, Restricted Project, efl: system integration
raster added a commit to T7133: Hdd partitions are not shown in EFM: rEa91ba4e1a8f1: exec - dont run null exec commands.
Jun 9 2020, 2:33 PM · enlightenment-git, Restricted Project, efl: system integration
raster closed T7133: Hdd partitions are not shown in EFM as Resolved by committing rEe89822467210: exec - dont run null exec commands.
Jun 9 2020, 2:32 PM · enlightenment-git, Restricted Project, efl: system integration
raster added a comment to T7133: Hdd partitions are not shown in EFM.

i don't even think it's a wishlist. it just isn't useful. the filesystems are (or should be) mounted already,. if the user was a shortcut to them they can symlink one from their favorites dir or something.... but efm absolutely shouldn't show /boot or /boot/uefi or /home or /opt or whatever if they are different partitions mounted... the point is they are mounted so your fs looks like a seamless tree... :)

Jun 9 2020, 2:07 PM · enlightenment-git, Restricted Project, efl: system integration
raster added a comment to T8746: Wrong desktop files makes E to crash.

hmm so i tried to reproduce your issue. i get a dialog:

Jun 9 2020, 8:27 AM · enlightenment-git
raster added a comment to T8737: Glyph cache garbage collector which collect during rendering.

can we not cal it texture_cache? as this also applies to software also not long but int will do like the other caches. if people need > 2gb of cache for this... they have problems :) so maybe evas_font_data_cache_set/get(). ?

Jun 9 2020, 3:18 AM · efl
raster added a comment to T7133: Hdd partitions are not shown in EFM.

efm doesn't have to mount it... it should already be mounted by /etc/fstab if its a fixed partition. filemanagers do need to deal with mounting "dynamic stuff" like removable devices that come and go... :)

Jun 9 2020, 3:04 AM · enlightenment-git, Restricted Project, efl: system integration
raster added a comment to D11949: efl_ui_textpath: mathmatical calculations.

don't take this the wrong way, but i think 90% of the time you'r chasing the wrong thing. the compiler already does this. you need to find the cases where the compiler does NOT do something smart ... (and -O0 doesn't count! -O2/3 should be what you worry about). just trying to encourage you to focus on the valuable things. reviewing patches that actually make no difference (and possibly make it harder to read/follow/understand) is not useful for reviewers or for you in creating the patches :) focus on the value bits... if you want pointers into what could do with speedups that i am pretty sure are a win in almost all if not all cases on average, then let's have a chat :).

Jun 9 2020, 3:02 AM · efl
raster requested changes to D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

more important: at normal optimizations (-O2 is pretty normal for production builds or even -O3), does this actually remove a sqrt() function or is the compiler already detecting a sqrt with a constant and pre-calculating it? :) because... looking at the asm output of the compiler.. it figures out that its a constant... even at -O0. it still optimizes it to a constant. compare the asm output of:

Jun 9 2020, 2:35 AM · efl
raster requested changes to D11947: efl: reduce PI calculations.

just saying... -O0 is not a way to say "oh i've made it faster at O0". there is a line between more readable and faster code. your code changes here are NO faster as the default is -O1 anyway so the compiler converts these to constants at compile time UNLESS you use -O0 ... which is just invalid to consider a case to speed up.

Jun 9 2020, 2:24 AM · efl

Jun 8 2020

raster added a comment to T7133: Hdd partitions are not shown in EFM.

efm is not meant to show "hard disk mount points". that is an explicit choice not to. it is only looking for devices tagged as removable devices by udisks. sometimes udisks says some partitions that are mounted are removable. i know i certainly don't test the non-udisks path as that's just not normal on arch.

Jun 8 2020, 7:26 AM · enlightenment-git, Restricted Project, efl: system integration
raster added a comment to T8744: windows appears as hidden when they should not.

looks like you found a logic hole... :) yay for too many options! :) btw - this happens even without switching desks.. i see my pointer jump to a spot with no window (but where one should be).

Jun 8 2020, 1:24 AM · enlightenment-git

Jun 7 2020

raster added a comment to T8729: Hotplug display issues - Enlightenment 0.24.0 .

if you screenshot while the lid is closed and the mouse goes there - does the shot cover all screens? is one all black? or have content?

Jun 7 2020, 1:09 PM · enlightenment-git

Jun 5 2020

raster accepted D11941: emotion: remove all left overs from removed backends.
Jun 5 2020, 3:45 AM · efl

Jun 2 2020

raster added a comment to T8729: Hotplug display issues - Enlightenment 0.24.0 .

Ok, so, I should have "Suspend even if AC" when I am also using "suspend intelligently"

Jun 2 2020, 3:19 PM · enlightenment-git

May 31 2020

raster added a comment to T8729: Hotplug display issues - Enlightenment 0.24.0 .

what is the name of the laptop screen output? like eDP0 or LVDS0 or something? in screen setup for your laptop lid screen is "laptop lid" checked? (it's not a setting you change - it's something e detects). you can just run xrandr on the cmdline to list output names like LVDS0/1/2, eDP0/2/3, DP0/1/2, HDMI-0, etc. etc.

May 31 2020, 4:36 AM · enlightenment-git