Page MenuHomePhabricator

segfaultxavi (Xavi Artigas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 3:04 AM (79 w, 3 d)
Availability
Available

Recent Activity

Thu, Apr 18

segfaultxavi added inline comments to D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..
Thu, Apr 18, 8:03 AM · efl
segfaultxavi closed D8635: docs: Clarify Efl.Content behavior.
Thu, Apr 18, 2:01 AM · efl

Wed, Apr 17

segfaultxavi added a comment to D8634: meson: unbreak cxx header installation.

I don't know what any of this does but css headers are installed in the proper place for me now.

Wed, Apr 17, 8:25 AM · efl
segfaultxavi requested review of D8635: docs: Clarify Efl.Content behavior.
Wed, Apr 17, 8:02 AM · efl
segfaultxavi added a comment to D8106: canvas map: introduce a new texture mapping for better quality..

@Hermet I just noticed this patch introduces warnings:

[354/2186] Compiling C object 'src/lib/evas_goal/c61fe7f@@evas@sha/.._evas_common_evas_map_image.c.o'.
In file included from ../src/lib/evas/common/evas_map_image.c:654:0:
../src/lib/evas/common/evas_map_image_internal_high.c: In function ‘_map_triangle_draw_linear.constprop’:
../src/lib/evas/common/evas_map_image_internal_high.c:460:101: warning: ‘c[3]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                   DATA32 tmp = (((int) c[0]) << 24) | (((int) c[1]) << 16) | (((int) c[2]) << 8) | ((int) c[3]);
                                                                                                    ~^~~~~~~~~~~
../src/lib/evas/common/evas_map_image_internal_high.c:460:80: warning: ‘c[2]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                   DATA32 tmp = (((int) c[0]) << 24) | (((int) c[1]) << 16) | (((int) c[2]) << 8) | ((int) c[3]);
                                                                               ~^~~~~~~~~~~
../src/lib/evas/common/evas_map_image_internal_high.c:460:57: warning: ‘c[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                   DATA32 tmp = (((int) c[0]) << 24) | (((int) c[1]) << 16) | (((int) c[2]) << 8) | ((int) c[3]);
                                                        ~^~~~~~~~~~~
../src/lib/evas/common/evas_map_image_internal_high.c:460:34: warning: ‘c[0]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
                   DATA32 tmp = (((int) c[0]) << 24) | (((int) c[1]) << 16) | (((int) c[2]) << 8) | ((int) c[3]);
                                 ~^~~~~~~~~~~
Wed, Apr 17, 7:45 AM · efl
segfaultxavi added a comment to D8631: ui.relative_layout: implement Efl.Container.

What do you mean?

Wed, Apr 17, 6:54 AM · efl
segfaultxavi accepted D8631: ui.relative_layout: implement Efl.Container.

Do we have testsuite for this?

Wed, Apr 17, 3:52 AM · efl
segfaultxavi accepted D8610: Change Way of searching for Escape strings/values.

I have got no further comments :)

Wed, Apr 17, 3:44 AM · efl
segfaultxavi added inline comments to D8610: Change Way of searching for Escape strings/values.
Wed, Apr 17, 3:14 AM · efl
segfaultxavi accepted D8568: ecore: move property string definition to shared headers for Efl.Composite_Model..

Yeah, much better now, sure.

Wed, Apr 17, 2:19 AM · efl
segfaultxavi triaged T7813: mono-docs: Better docs for Event wrappers as Normal priority.
Wed, Apr 17, 2:14 AM · efl: docs, efl: language bindings
segfaultxavi accepted D8622: csharp: Small style changes.

I see no problem with this and everything builds, including examples.

Wed, Apr 17, 2:06 AM · efl
segfaultxavi added a comment to D8610: Change Way of searching for Escape strings/values.

@segfaultxavi I already update them in Test Plan

Wed, Apr 17, 1:41 AM · efl
segfaultxavi added a comment to D8610: Change Way of searching for Escape strings/values.

Can you update the benchmark numbers with the latest approach?
Thanks for taking the time to fix all this!
(BTW, what happened with D8620 ? nobody can open that ticket.)

Wed, Apr 17, 1:29 AM · efl

Tue, Apr 16

segfaultxavi requested changes to D8610: Change Way of searching for Escape strings/values.

We have reached now a classical point. The new code is much better in the general case, but the old one is faster for the allegedly most common cases.
I don't think there's a good solution so maybe you can do a linear search on the short list of common escapes and then the binary search on the full list?

Tue, Apr 16, 10:42 AM · efl
segfaultxavi accepted D8614: csharp: klass style changes.

Docs look fine. They also render correctly, including links.

Tue, Apr 16, 10:28 AM · efl: language bindings
segfaultxavi added a comment to D8610: Change Way of searching for Escape strings/values.

Well, these numbers are definitely impressive. Thanks.

Tue, Apr 16, 7:28 AM · efl
segfaultxavi accepted D8612: csharp: Simple spacing rules changes.
Tue, Apr 16, 6:46 AM · efl
segfaultxavi added inline comments to D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 5:25 AM · efl
segfaultxavi added inline comments to D8616: evas_image: work file_set with NULL.
Tue, Apr 16, 3:29 AM · efl
segfaultxavi removed a parent revision for D8614: csharp: klass style changes: D6213: elm_colorselector: fix improperly named API theme parts.
Tue, Apr 16, 3:00 AM · efl: language bindings
segfaultxavi removed a child revision for D6213: elm_colorselector: fix improperly named API theme parts: D8614: csharp: klass style changes.
Tue, Apr 16, 3:00 AM · efl
segfaultxavi added a comment to D8613: csharp: Function coding style changes.

I was looking at the kind of warnings you are suppressing and I came across these docs:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1307.md

Tue, Apr 16, 2:58 AM · efl
segfaultxavi requested changes to D8613: csharp: Function coding style changes.
Tue, Apr 16, 2:57 AM · efl
segfaultxavi requested changes to D8612: csharp: Simple spacing rules changes.

Much nicer, but there is still some non-perfect whitespace:
If you search for ///< (without separating space) in klass.h and struct_definition.hh you can find many places.

Tue, Apr 16, 2:15 AM · efl
segfaultxavi added a comment to D8610: Change Way of searching for Escape strings/values.

Replacing a linear search with a binary search is indeed a good thing. However, since this is a performance improvement, you should provide performance NUMBERS (As you did before, create a test case with lots of text and escape sequences).

Tue, Apr 16, 1:46 AM · efl
segfaultxavi added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

I agree with the intention of this commit, which is putting together in the same class repeated parts from different classes.
However, I think we can go even further. Looking at the patch, it looks like the parts for Efl.Ui.List_Default_Item and Efl.Ui.Grid_Default_Item are identical. Could these parts be moved to Efl.Ui.Item, for example?

Tue, Apr 16, 12:48 AM · efl

Mon, Apr 15

segfaultxavi added a comment to D8609: csharp: Remove warning about clashing GetType() methods.

👍!

Mon, Apr 15, 11:25 PM · efl
segfaultxavi closed D8601: csharp: Make concrete classes internal..
Mon, Apr 15, 5:38 AM · efl
segfaultxavi closed T7801: mono-docs: Concrete classes do not need any kind of documentation as Resolved by committing rEFL332d6368cdf0: csharp: Make concrete classes internal..
Mon, Apr 15, 5:38 AM · efl: docs, efl: language bindings
segfaultxavi accepted D8601: csharp: Make concrete classes internal..
Mon, Apr 15, 5:38 AM · efl
segfaultxavi closed D8606: Unreachable code.
Mon, Apr 15, 4:55 AM · efl
segfaultxavi accepted D8606: Unreachable code.

Nice!

Mon, Apr 15, 4:48 AM · efl
segfaultxavi added a comment to T7808: Documentation of undefined group.

After playing a bit with grep I found:

  • 974 unique ingroups
  • 484 unique defgroups
  • 501 ingroups without matching defgroup (Full list here P284)
Mon, Apr 15, 4:46 AM · documentation
segfaultxavi requested changes to D8606: Unreachable code.

Actually, the j variable can be completely removed and replaced by w in line 34 (the only place where it is used).

Mon, Apr 15, 4:12 AM · efl
segfaultxavi closed D8605: gitignore: add elm_default_config.x.
Mon, Apr 15, 4:08 AM · efl
segfaultxavi accepted D8605: gitignore: add elm_default_config.x.
Mon, Apr 15, 4:07 AM · efl

Fri, Apr 12

segfaultxavi moved T7787: mono-docs: allow external examples embedded into the docs from In progress to Done on the efl: docs board.
Fri, Apr 12, 9:34 AM · efl: language bindings, efl: docs
segfaultxavi closed T7787: mono-docs: allow external examples embedded into the docs, a subtask of T6128: Generate C# reference API documentation, as Resolved.
Fri, Apr 12, 9:34 AM · efl: language bindings, efl: docs
segfaultxavi closed T7787: mono-docs: allow external examples embedded into the docs as Resolved.
Fri, Apr 12, 9:34 AM · efl: language bindings, efl: docs
segfaultxavi added a revision to T7787: mono-docs: allow external examples embedded into the docs: D8597: mono-docs: Allow derived classes to have external examples.
Fri, Apr 12, 9:33 AM · efl: language bindings, efl: docs
segfaultxavi added a task to D8597: mono-docs: Allow derived classes to have external examples: T7787: mono-docs: allow external examples embedded into the docs.
Fri, Apr 12, 9:33 AM · efl
segfaultxavi closed D8597: mono-docs: Allow derived classes to have external examples.
Fri, Apr 12, 9:13 AM · efl
segfaultxavi triaged T7801: mono-docs: Concrete classes do not need any kind of documentation as Normal priority.
Fri, Apr 12, 1:15 AM · efl: docs, efl: language bindings
segfaultxavi added a comment to D8597: mono-docs: Allow derived classes to have external examples.

I know the indentation is not correct (I'm mixing ( and {) but can we let it slip? otherwise the line will be very long and I do not think it helps readability in any way :)

Fri, Apr 12, 1:05 AM · efl
segfaultxavi updated the diff for D8597: mono-docs: Allow derived classes to have external examples.

Always set class name when creating class_context structs.
Use klass_full_concrete_or_interface_name to obtain class names.

Fri, Apr 12, 1:03 AM · efl
segfaultxavi closed D8283: ui.widget: fix theme_apply working in sub_object_add.

Fixed by D8599.

Fri, Apr 12, 12:18 AM · efl
segfaultxavi closed T7796: D8283 followup as Resolved.
Fri, Apr 12, 12:15 AM
segfaultxavi added a commit to T7796: D8283 followup: rEFL48c27364fce8: efl_ui_widget: avoid calling null parent.
Fri, Apr 12, 12:15 AM
segfaultxavi closed D8599: efl_ui_widget: avoid calling null parent.
Fri, Apr 12, 12:15 AM · efl
segfaultxavi accepted D8599: efl_ui_widget: avoid calling null parent.

Warnings are gone and the change makes sense.

Fri, Apr 12, 12:14 AM · efl
segfaultxavi removed a project from D8433: efl.pack_linear: Clarify behavior and docs: DO NOT MERGE.
Fri, Apr 12, 12:05 AM · efl
segfaultxavi added a comment to D8433: efl.pack_linear: Clarify behavior and docs.

Fixed!

Fri, Apr 12, 12:04 AM · efl
segfaultxavi updated the diff for D8433: efl.pack_linear: Clarify behavior and docs.

Fix copy&paste error.

Fri, Apr 12, 12:03 AM · efl

Thu, Apr 11

segfaultxavi added inline comments to D8433: efl.pack_linear: Clarify behavior and docs.
Thu, Apr 11, 11:08 PM · efl
segfaultxavi planned changes to D8597: mono-docs: Allow derived classes to have external examples.

But wouldn't it be easier to pass prop.klass/func.klass directly to generate_all_tag_examples than adding a new field to class_context?

That's the thing! When parsing Efl.Ui.Button.GetText(), func.klass is Efl.IText, this is, the class where this method is defined. This is the current behavior (before this patch).
But if I want to allow specific examples for every derived class I need the class currently being processed, and it seems it is not available when we are generating the documentation (or at least, I could not find it). @lauromoura
suggested adding a context tag.
Beside the derived class examples (Efl.Ui.Button) I also look at the base class (Efl.IText) in case there is an example there too.

Thu, Apr 11, 12:51 PM · efl
segfaultxavi added inline comments to D8597: mono-docs: Allow derived classes to have external examples.
Thu, Apr 11, 8:30 AM · efl
segfaultxavi updated the diff for D8597: mono-docs: Allow derived classes to have external examples.

Whitespaaaaaaaaace

Thu, Apr 11, 8:29 AM · efl
segfaultxavi updated the diff for D8597: mono-docs: Allow derived classes to have external examples.

Fix examples appearing twice when a method is NOT inherited.

Thu, Apr 11, 8:25 AM · efl
segfaultxavi requested review of D8597: mono-docs: Allow derived classes to have external examples.
Thu, Apr 11, 3:47 AM · efl
segfaultxavi added a comment to T7787: mono-docs: allow external examples embedded into the docs.

D8592 added support for external examples but I won't close this task until examples for derived classes can be provided (that is, Efl.Ui.Button.Text instead of only Efl.IText.Text). This is still work in progress.

Thu, Apr 11, 2:18 AM · efl: language bindings, efl: docs
segfaultxavi added a revision to T7787: mono-docs: allow external examples embedded into the docs: D8592: mono-docs: Allow embedding external examples.
Thu, Apr 11, 2:15 AM · efl: language bindings, efl: docs
segfaultxavi added a task to D8592: mono-docs: Allow embedding external examples: T7787: mono-docs: allow external examples embedded into the docs.
Thu, Apr 11, 2:15 AM · efl
segfaultxavi closed D8592: mono-docs: Allow embedding external examples.
Thu, Apr 11, 1:39 AM · efl
segfaultxavi closed D8587: efl-mono: Allow doc XML tags to be nested.
Thu, Apr 11, 1:37 AM · efl
segfaultxavi closed D8585: efl-mono: Allow generating doc refs for methods without class.
Thu, Apr 11, 1:37 AM · efl
segfaultxavi added inline comments to D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.
Thu, Apr 11, 1:20 AM · efl

Wed, Apr 10

segfaultxavi updated the diff for D8592: mono-docs: Allow embedding external examples.

Rebase after changes in parent commit

Wed, Apr 10, 1:18 PM · efl
segfaultxavi added a comment to D8587: efl-mono: Allow doc XML tags to be nested.

Ouch! Thanks!

Wed, Apr 10, 12:54 PM · efl
segfaultxavi updated the diff for D8587: efl-mono: Allow doc XML tags to be nested.

Add missing return statements

Wed, Apr 10, 12:54 PM · efl
segfaultxavi added a comment to D8592: mono-docs: Allow embedding external examples.

I wanted to use Text for demo, but it is a bad example because it is blacklisted (T7791 should take care of that).

Wed, Apr 10, 11:10 AM · efl
segfaultxavi updated the test plan for D8592: mono-docs: Allow embedding external examples.
Wed, Apr 10, 11:08 AM · efl
segfaultxavi requested review of D8592: mono-docs: Allow embedding external examples.
Wed, Apr 10, 11:05 AM · efl
segfaultxavi added a child revision for D8587: efl-mono: Allow doc XML tags to be nested: D8592: mono-docs: Allow embedding external examples.
Wed, Apr 10, 11:05 AM · efl
segfaultxavi added a comment to D8579: efl-mono: Make override of methods only for methods that are defined by the user.

I think this commit added a lot of warnings because the methods variable is not always needed:

public override System.Collections.Generic.List<Efl_Op_Description> GetEoOps(System.Type type)
{
    var descs = new System.Collections.Generic.List<Efl_Op_Description>();
    var methods = Efl.Eo.Globals.GetUserMethods(type);
    descs.AddRange(base.GetEoOps(type));
    return descs;
}
Wed, Apr 10, 7:23 AM · efl
segfaultxavi triaged T7794: efl-mono: Property wrapper docs are not properly indented as Normal priority.
Wed, Apr 10, 2:58 AM · efl: docs, efl: language bindings
segfaultxavi added a comment to D8587: efl-mono: Allow doc XML tags to be nested.

Thanks @lauromoura !

Wed, Apr 10, 1:54 AM · efl
segfaultxavi updated the diff for D8587: efl-mono: Allow doc XML tags to be nested.

Remove lots of unnecessary tabs.

Wed, Apr 10, 1:53 AM · efl

Tue, Apr 9

segfaultxavi requested review of D8587: efl-mono: Allow doc XML tags to be nested.
Tue, Apr 9, 10:39 AM · efl
segfaultxavi added a child revision for D8585: efl-mono: Allow generating doc refs for methods without class: D8587: efl-mono: Allow doc XML tags to be nested.
Tue, Apr 9, 10:38 AM · efl
segfaultxavi resigned from D8578: Freeing Global Memory list on destructor.

Thanks. Will let an expert review the code, though :)

Tue, Apr 9, 9:06 AM · efl
segfaultxavi added inline comments to D8585: efl-mono: Allow generating doc refs for methods without class.
Tue, Apr 9, 6:45 AM · efl
segfaultxavi updated the diff for D8585: efl-mono: Allow generating doc refs for methods without class.

Fix previous git mess

Tue, Apr 9, 6:42 AM · efl
segfaultxavi requested review of D8585: efl-mono: Allow generating doc refs for methods without class.
Tue, Apr 9, 6:37 AM · efl
segfaultxavi triaged T7792: efl-mono: testsuite fails when built in debug mode with meson as Normal priority.
Tue, Apr 9, 6:21 AM · Restricted Project, efl: language bindings
segfaultxavi triaged T7791: efl-mono: Rules to prevent methods called like classes need to take the I interface prefix into account as Normal priority.
Tue, Apr 9, 5:53 AM · efl: language bindings
segfaultxavi requested changes to D8578: Freeing Global Memory list on destructor.

Be careful, you merged two different things here!

Tue, Apr 9, 1:31 AM · efl

Mon, Apr 8

segfaultxavi moved T7787: mono-docs: allow external examples embedded into the docs from Backlog to In progress on the efl: docs board.
Mon, Apr 8, 7:55 AM · efl: language bindings, efl: docs
segfaultxavi triaged T7787: mono-docs: allow external examples embedded into the docs as High priority.
Mon, Apr 8, 7:55 AM · efl: language bindings, efl: docs
segfaultxavi closed D8577: configure: fix build error of efl_custom_exports_mono.c.
Mon, Apr 8, 7:30 AM · efl
segfaultxavi planned changes to D8496: docs: Fill-in parts docs for Efl.Ui.Grid_Default_Item.

OK, if there is a plan to update this widget then you can add the docs later.
I'll leave this task open so we do not forget :)

Mon, Apr 8, 12:49 AM · efl

Sun, Apr 7

segfaultxavi added inline comments to D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..
Sun, Apr 7, 1:29 AM · efl
segfaultxavi added inline comments to D8568: ecore: move property string definition to shared headers for Efl.Composite_Model..
Sun, Apr 7, 1:21 AM · efl

Fri, Apr 5

segfaultxavi added a comment to T7784: Efl.Pack / Efl.Pack_Linear usage.
Fri, Apr 5, 3:13 AM · efl: widgets
segfaultxavi added a comment to D8561: meson: add docs.

The changes to the doxyfile do not seem to affect make doc with autotools.

Fri, Apr 5, 2:39 AM · efl

Thu, Apr 4

segfaultxavi added a comment to T7702: Remove internally generated classes from EFL# doc.

Awesome, thanks, I updated the list in the task description. This task is almost done!

Thu, Apr 4, 10:15 AM · documentation, efl: language bindings
segfaultxavi updated the task description for T7702: Remove internally generated classes from EFL# doc.
Thu, Apr 4, 10:15 AM · documentation, efl: language bindings
segfaultxavi added a revision to T7702: Remove internally generated classes from EFL# doc: D8550: csharp: Make classes abstract and rework casting.
Thu, Apr 4, 7:59 AM · documentation, efl: language bindings
segfaultxavi added a task to D8550: csharp: Make classes abstract and rework casting: T7702: Remove internally generated classes from EFL# doc.
Thu, Apr 4, 7:59 AM · efl
segfaultxavi added a comment to T7743: C#: Hide NativeInherit classes from top level namespaces..

Right now these classes are hidden from DocFX via blacklist: 8fc4e948778f

Thu, Apr 4, 7:58 AM · documentation, efl: language bindings