Page MenuHomePhabricator

segfaultxavi (Xavi Artigas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 3:04 AM (61 w, 6 d)
Availability
Available

Recent Activity

Today

segfaultxavi added a comment to D7467: doc: Turn comments from EO to C# XML syntax.

Uploaded a new diff to take care of the possibly invalid Getter reference, and answered your inline comments.

Tue, Dec 18, 6:56 AM · efl
segfaultxavi updated the diff for D7467: doc: Turn comments from EO to C# XML syntax.

Proper handling of Setter and Getter methods.
Added some missing root namespace markers to eolian API calls,
for consistency.

Tue, Dec 18, 6:48 AM · efl
segfaultxavi placed T7476: efl: Rename duplicated event names up for grabs.
Tue, Dec 18, 4:39 AM · efl: language bindings
segfaultxavi moved T7476: efl: Rename duplicated event names from InProgress to TODO on the efl: language bindings board.
Tue, Dec 18, 4:38 AM · efl: language bindings
segfaultxavi closed D7473: silence most left over compiler warnings.
Tue, Dec 18, 4:08 AM · efl
segfaultxavi accepted D7473: silence most left over compiler warnings.

Remember to add reviewers to your patches. If you don't know who should review your patch, look here:
https://phab.enlightenment.org/w/maintainers_reviewers/

Tue, Dec 18, 4:00 AM · efl

Yesterday

segfaultxavi resigned from D7470: build: make bindings cross compileable.

Well, I have no means of testing it right now, and I cannot understand meson files so I'll leave the review to some other expert :)

Mon, Dec 17, 10:15 AM · efl
segfaultxavi added a comment to D7470: build: make bindings cross compileable.

What does cross-compilation mean in this case? Build for Windows from a Linux host?
How should I test this? Why does people never use the "Test plan" section? 😁

Mon, Dec 17, 9:05 AM · efl
segfaultxavi accepted D7441: eo: add the ability to get the size of object of a certain class..
Mon, Dec 17, 8:28 AM · efl
segfaultxavi added a comment to D7441: eo: add the ability to get the size of object of a certain class..

I don't have much idea on how to write a useful test at all here. The size can change with pretty much every release (it can go up and down). The only thing I could test is if it is > 0, would that be useful ?

Mon, Dec 17, 8:28 AM · efl
segfaultxavi added inline comments to D7446: efl: add facility to generate an event when an item is created by the factory..
Mon, Dec 17, 8:17 AM · efl
segfaultxavi updated the task description for T6129: Write tutorials, guides and examples in C#.
Mon, Dec 17, 8:09 AM · efl: language bindings, efl: docs
segfaultxavi added a comment to T7408: Fix consistency of the Interfaces Hierarchy.

To move forward we need the full list of names which are confusing, and then we can think about alternatives.
@Jaehyun_Cho, since you seem to be pushing this effort, do you mind preparing this list and writing it in this ticket?

Mon, Dec 17, 7:25 AM · Restricted Project, efl, Restricted Project
segfaultxavi moved T7241: Removing underline('_') in class name in C# bindings from TODO to Done on the efl: language bindings board.
Mon, Dec 17, 7:04 AM · efl: language bindings
segfaultxavi moved T7496: eolian_mono: Add support for C# style properties from InProgress to Done on the efl: language bindings board.
Mon, Dec 17, 7:04 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi added a comment to D5936: ctxpopup: prevent focus escape from ctxpopup..

There is a patch pending revision that I think fixes this same issue: T7432

Mon, Dec 17, 7:00 AM · efl
segfaultxavi moved T7505: efl-mono: Add <value> tags to Properties documentation from Backlog to TODO on the efl: language bindings board.
Mon, Dec 17, 6:33 AM · efl: language bindings, efl: docs
segfaultxavi triaged T7505: efl-mono: Add <value> tags to Properties documentation as High priority.
Mon, Dec 17, 6:31 AM · efl: language bindings, efl: docs
segfaultxavi added reviewers for D7467: doc: Turn comments from EO to C# XML syntax: lauromoura, vitor.sousa.
Mon, Dec 17, 6:14 AM · efl
segfaultxavi requested review of D7467: doc: Turn comments from EO to C# XML syntax.
Mon, Dec 17, 6:13 AM · efl
segfaultxavi added a revision to T7453: C# bindings: Convert Eo comment format into proper XML comment format: D7467: doc: Turn comments from EO to C# XML syntax.
Mon, Dec 17, 6:13 AM · efl: language bindings

Fri, Dec 14

segfaultxavi added a comment to D7446: efl: add facility to generate an event when an item is created by the factory..

Minor orthographic fixes. If you don't fix them now, I'll have to do it later :)

Fri, Dec 14, 7:03 AM · efl
segfaultxavi added a comment to D7447: elementary: make all view generate an event when the item is created..

Man, I have absolutely no idea what this patch does ("make all view use of it"???) and the commit has no description :(

Fri, Dec 14, 7:03 AM · efl
segfaultxavi renamed T7424: Add support for DocFx to generate the C# API docs from Study usage of DocFx to generate the C# API docs to Add support for DocFx to generate the C# API docs.
Fri, Dec 14, 2:22 AM · efl: language bindings, efl: docs

Sat, Dec 8

segfaultxavi requested changes to D7442: efl: add a factory Eina_Error..

This is public API. Where are the docs? What does this error mean? Who emits it? And the unit tests.
I see Model errors do not have all this, but we should start doing things correctly at some point... in this case it's not that much work :)

Sat, Dec 8, 1:17 AM · efl
segfaultxavi requested changes to D7441: eo: add the ability to get the size of object of a certain class..

Looks like this method accepts both a class and an object. This should be explained in the doc.

Sat, Dec 8, 12:47 AM · efl

Fri, Dec 7

segfaultxavi lowered the priority of T7329: Document the release process on the Enlightenment site from High to Wishlist.
Fri, Dec 7, 5:03 AM · efl: docs, efl: release team, efl (efl-1.22)
segfaultxavi lowered the priority of T7088: git-phab documentation needs improving from Showstopper Issues to Normal.
Fri, Dec 7, 5:03 AM · efl: docs
segfaultxavi placed T6394: Refactor Ecore.Exe to EFL.Exe up for grabs.
Fri, Dec 7, 4:57 AM · Restricted Project, efl: system integration
segfaultxavi closed D7423: eo: fix efl_future_then example..
Fri, Dec 7, 4:32 AM · efl
segfaultxavi accepted D7423: eo: fix efl_future_then example..
Fri, Dec 7, 4:30 AM · efl
segfaultxavi closed D7393: ecore: add a full test for efl_future_then and efl_future_chain..
Fri, Dec 7, 4:21 AM · efl
segfaultxavi accepted D7393: ecore: add a full test for efl_future_then and efl_future_chain..

Working here too.

Fri, Dec 7, 4:15 AM · efl
segfaultxavi closed D7392: ecore: fix typo in comments..
Fri, Dec 7, 3:56 AM · efl
segfaultxavi closed D7391: ecore: add efl_app_test to the meson build and run the test..
Fri, Dec 7, 3:53 AM · efl
segfaultxavi closed D7390: ecore: efl_app_suite doesn't need to depends on Efl_Net..
Fri, Dec 7, 3:45 AM · efl
segfaultxavi closed D7381: ecore: use efl_future_then to simplify the code logic and reduce potential bugs..
Fri, Dec 7, 3:42 AM · efl
segfaultxavi added a comment to D7381: ecore: use efl_future_then to simplify the code logic and reduce potential bugs..

Code DOES seem to be simpler and everything builds and checks as expected.

Fri, Dec 7, 3:40 AM · efl
segfaultxavi closed D7380: ecore: remove unecessary intermediate variable..
Fri, Dec 7, 3:28 AM · efl
segfaultxavi closed D7379: eo: make efl_future_then have a data pointer in addition of the object pointer..
Fri, Dec 7, 3:23 AM · efl
segfaultxavi accepted D7379: eo: make efl_future_then have a data pointer in addition of the object pointer..
Fri, Dec 7, 2:59 AM · efl
segfaultxavi closed D7332: elementary: make Efl.Ui.Factory.create asynchronous..
Fri, Dec 7, 2:47 AM · efl
segfaultxavi accepted D7332: elementary: make Efl.Ui.Factory.create asynchronous..

ninja and ninja test work again and the patch has been already approved. Landing.

Fri, Dec 7, 2:46 AM · efl
segfaultxavi added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

@woohyun I do not understand what do you mean. Right now, the constructors section is just a list of properties or methods which are already defined for that class.

Fri, Dec 7, 2:21 AM · Restricted Project

Thu, Dec 6

segfaultxavi moved T7496: eolian_mono: Add support for C# style properties from Backlog to TODO on the efl: language bindings board.
Thu, Dec 6, 7:02 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi triaged T7496: eolian_mono: Add support for C# style properties as High priority.
Thu, Dec 6, 7:02 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi updated subscribers of D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

Maybe @lauromoura can help with that error since he has been working on the C# bindings.

Thu, Dec 6, 6:13 AM · efl
segfaultxavi accepted D7238: Intruduce Efl.Ui.Panel (Create Efl Ui Widget from elm widget(elm_panel)).

I confirm it builds and the Panels in elementary_test work as expected. I cannot comment on the code, though.

Thu, Dec 6, 5:15 AM · efl
segfaultxavi added a comment to T6128: Generate C# reference API documentation.

DocFX seems to be working now (in a branch), but it is a heavy dependency and it takes ages to generate the docs.
In the long run, I think it would be nicer to have our own generator, but, for now, let's just lower the priority of it and use DocFX once it is finished.

Thu, Dec 6, 5:10 AM · efl: language bindings, efl: docs
segfaultxavi added a comment to D7379: eo: make efl_future_then have a data pointer in addition of the object pointer..

Oh, they are in D7393, now I see them. Still, I cannot test this patch because the one it depends on (D7332) is failing to compile.

Thu, Dec 6, 3:56 AM · efl
segfaultxavi requested changes to D7379: eo: make efl_future_then have a data pointer in addition of the object pointer..

@cedric What about those examples and tests?

Thu, Dec 6, 1:27 AM · efl
segfaultxavi added a comment to D7380: ecore: remove unecessary intermediate variable..

After a week being approved, I think you can legally land the patch yourself if the reviewer forgot.
Damn, one more week and you can legally marry the task and her parents cannot oppose :D

Thu, Dec 6, 1:11 AM · efl

Wed, Dec 5

segfaultxavi moved T6129: Write tutorials, guides and examples in C# from TODO to InProgress on the efl: language bindings board.
Wed, Dec 5, 11:43 AM · efl: language bindings, efl: docs
segfaultxavi moved T7424: Add support for DocFx to generate the C# API docs from TODO to InProgress on the efl: language bindings board.
Wed, Dec 5, 11:43 AM · efl: language bindings, efl: docs
segfaultxavi moved T7453: C# bindings: Convert Eo comment format into proper XML comment format from TODO to InProgress on the efl: language bindings board.
Wed, Dec 5, 11:43 AM · efl: language bindings
segfaultxavi moved T6128: Generate C# reference API documentation from TODO to InProgress on the efl: language bindings board.
Wed, Dec 5, 11:43 AM · efl: language bindings, efl: docs
segfaultxavi moved T7476: efl: Rename duplicated event names from TODO to InProgress on the efl: language bindings board.
Wed, Dec 5, 11:43 AM · efl: language bindings
segfaultxavi moved T7476: efl: Rename duplicated event names from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 11:25 AM · efl: language bindings
segfaultxavi edited projects for T7476: efl: Rename duplicated event names, added: efl: language bindings; removed efl.
Wed, Dec 5, 11:25 AM · efl: language bindings
segfaultxavi raised the priority of T6128: Generate C# reference API documentation from Normal to High.
Wed, Dec 5, 10:24 AM · efl: language bindings, efl: docs
segfaultxavi triaged T7240: Not allow multi class inheritance in eo as High priority.
Wed, Dec 5, 10:21 AM · efl: language bindings, Restricted Project
segfaultxavi triaged T7241: Removing underline('_') in class name in C# bindings as High priority.
Wed, Dec 5, 10:20 AM · efl: language bindings
segfaultxavi updated subscribers of T7241: Removing underline('_') in class name in C# bindings.

@lauromoura is this task still relevant with the new API?

Wed, Dec 5, 10:19 AM · efl: language bindings
segfaultxavi triaged T7487: efl-mono: Remove initializer methods and add constructor parameters as High priority.
Wed, Dec 5, 10:19 AM · efl: language bindings
segfaultxavi claimed T6128: Generate C# reference API documentation.

DocFX is progressing fine. I think it is the easiest route.

Wed, Dec 5, 10:17 AM · efl: language bindings, efl: docs
segfaultxavi moved T6128: Generate C# reference API documentation from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:16 AM · efl: language bindings, efl: docs
segfaultxavi moved T6129: Write tutorials, guides and examples in C# from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:16 AM · efl: language bindings, efl: docs
segfaultxavi moved T6131: Introduction on how to get started with EFL C# from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:16 AM · efl: language bindings, efl: docs
segfaultxavi moved T7108: C# bindings: eo-intro tutorial has an ERROR on shutdown from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:14 AM · efl: language bindings
segfaultxavi closed T7161: C# bindings: EFL classes cannot be inherited from as Invalid.

This has become obsolete with the latest API changes

Wed, Dec 5, 10:14 AM · efl (efl-1.22), efl: language bindings
segfaultxavi moved T7204: Discussion about C# binding syntax from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:10 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi moved T7240: Not allow multi class inheritance in eo from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:10 AM · efl: language bindings, Restricted Project
segfaultxavi moved T7241: Removing underline('_') in class name in C# bindings from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:10 AM · efl: language bindings
segfaultxavi moved T7364: efl-mono: Object gets deleted after a while even though it has an EFL parent from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:05 AM · efl: language bindings
segfaultxavi moved T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:05 AM · efl: language bindings, Restricted Project
segfaultxavi moved T7387: efl-mono: remove eina.Value.Flush() from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:04 AM · efl: language bindings
segfaultxavi moved T7388: efl-mono: Make eina.Value.Set return "this" from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:04 AM · efl: language bindings
segfaultxavi moved T7400: efl-mono: Add enumeration support for container eina values from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:04 AM · efl: language bindings
segfaultxavi moved T7401: efl-mono: Implement Remove() method in eina.List, eina.Array and eina.Value from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:04 AM · efl: language bindings
segfaultxavi moved T7402: efl-mono: Implement Insert() in eina.Value from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:03 AM · efl: language bindings
segfaultxavi moved T7403: efl-mono: Complete support of Hash values in eina.Value from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:03 AM · efl: language bindings
segfaultxavi moved T7418: efl-mono: Removing widgets leaves app in unstable state from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:03 AM · efl: language bindings
segfaultxavi moved T7424: Add support for DocFx to generate the C# API docs from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:03 AM · efl: language bindings, efl: docs
segfaultxavi moved T7431: Missing Eo constants in C# bindings from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:02 AM · efl: language bindings
segfaultxavi moved T7453: C# bindings: Convert Eo comment format into proper XML comment format from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:02 AM · efl: language bindings
segfaultxavi moved T7487: efl-mono: Remove initializer methods and add constructor parameters from Backlog to TODO on the efl: language bindings board.
Wed, Dec 5, 10:02 AM · efl: language bindings
segfaultxavi moved T5835: Cleanup EFL tutorials and programming guide from Backlog to In progress on the efl: docs board.
Wed, Dec 5, 9:39 AM · efl: docs, Restricted Project
segfaultxavi moved T6129: Write tutorials, guides and examples in C# from Backlog to In progress on the efl: docs board.
Wed, Dec 5, 9:39 AM · efl: language bindings, efl: docs
segfaultxavi moved T7424: Add support for DocFx to generate the C# API docs from Backlog to In progress on the efl: docs board.
Wed, Dec 5, 9:38 AM · efl: language bindings, efl: docs
segfaultxavi added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

I didn't phrase that correctly. I meant that with initialization lists you have the option to set these properties only once, instead of having to set them to "default" and then to something else. I didn't mean that they cannot be further modified.

Wed, Dec 5, 7:17 AM · Restricted Project
segfaultxavi added a comment to D7394: eolian_mono: Add support for C# style properties.

Curious, arc is still trying to apply D7389 even after you removed the comment from the summary.

Wed, Dec 5, 4:24 AM · efl: language bindings
segfaultxavi requested changes to D7394: eolian_mono: Add support for C# style properties.

Almost done, but not there yet :)
The value of the property is not being documented. You need to use the <value> tag after the <summary> tag:
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/xmldoc/value

/// <summary>The Name property represents the employee's name.</summary>
/// <value>The Name property gets/sets the value of the string field, _name.</value>
public string Name {
    get { return _name; }
    set { _name = value; }
}
Wed, Dec 5, 1:48 AM · efl: language bindings

Tue, Dec 4

segfaultxavi requested changes to D7394: eolian_mono: Add support for C# style properties.

On a second thought... properties should have documentation :)

Tue, Dec 4, 4:26 AM · efl: language bindings
segfaultxavi accepted D7394: eolian_mono: Add support for C# style properties.

Meanwhile, as the patch just adds new functionality, we could merge it, and once these three properties are dealt with a new commit would remove them from the blacklist and turn the Getters/Setters private.

Tue, Dec 4, 2:56 AM · efl: language bindings
segfaultxavi added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

@q66, Good point! So, if we want to be able to specify the constructor parameters order we need to put them in a constructor section rather than tagging the properties individually. Thanks. We will also need to have some clear rule regarding the order of the inherited constructor parameters (I think it suffices to say that "inherited params come before each class params").

Tue, Dec 4, 2:09 AM · Restricted Project
segfaultxavi closed D7406: examples: update gitignore.
Tue, Dec 4, 1:16 AM · efl
segfaultxavi accepted D7406: examples: update gitignore.

Thanks a lot! This was very annoying! :D

Tue, Dec 4, 1:15 AM · efl

Mon, Dec 3

segfaultxavi added a comment to D7394: eolian_mono: Add support for C# style properties.

Only renaming the interfaces won't be enough. As per IRC discussion, these three properties have conflicts: Efl.Ui.Text.Text, Efl.Input.Key.Key and Efl.Input.Hold.Hold. I guess the easiest solution is to just rename either the property or the type (whatever is easier) instead of trying to come up with a clever C# trick. I'm working on a proposal.

Mon, Dec 3, 10:04 AM · efl: language bindings
segfaultxavi accepted D7405: meson: use eolian_gen with -S.

I confirm this fixes my problems with installed eo files (In /usr/local/shared/eolian, for example).

Mon, Dec 3, 9:59 AM · efl
segfaultxavi added a comment to D7394: eolian_mono: Add support for C# style properties.

6ec6d93535ebda03e1a4fac28b13d81b9ec79ee7 fixed make check for me.

Mon, Dec 3, 3:13 AM · efl: language bindings