segfaultxavi (Xavi Artigas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 3:04 AM (44 w, 5 d)
Availability
Available

Recent Activity

Today

segfaultxavi added a comment to T7329: Document the release process on the Enlightenment site.

Are these tags automatically added by some phab rule, or is that something that the proposal creator has to handle?

Mon, Aug 20, 11:48 AM · efl: docs, efl: release team, efl (efl-1.22)
segfaultxavi updated subscribers of T7329: Document the release process on the Enlightenment site.

Initial draft here (not public yet):
https://www.enlightenment.org/playground/release-cycle.md

Mon, Aug 20, 9:24 AM · efl: docs, efl: release team, efl (efl-1.22)
segfaultxavi updated the task description for T6129: Convert tutorials, guides and examples to C#.
Mon, Aug 20, 5:00 AM · efl: language bindings, efl: docs
segfaultxavi triaged T7329: Document the release process on the Enlightenment site as High priority.
Mon, Aug 20, 4:59 AM · efl: docs, efl: release team, efl (efl-1.22)

Mon, Aug 13

segfaultxavi added a comment to T7283: Which feature proposals are you opposed to during the next development cycle?.

Also, maybe it's too late for asking this but, why is the polling in negative form (what features are you opposed to)?
I know very little about most of the features in the list, so I do not feel inclined to vote against somebody else's work :/

Mon, Aug 13, 7:08 AM · major change, efl: release team, efl (efl-1.22)
segfaultxavi added a comment to T7283: Which feature proposals are you opposed to during the next development cycle?.

Who is supposed to vote? In T7169 (bullet point 2) it is said that only core developers vote. Does that mean committers , probies, or who?

Mon, Aug 13, 5:55 AM · major change, efl: release team, efl (efl-1.22)

Sun, Aug 12

segfaultxavi raised the priority of T6131: Introduction on how to get started with EFL C# from Wishlist to TODO.
Sun, Aug 12, 3:53 AM · efl: language bindings, efl: docs
segfaultxavi raised the priority of T6130: Adapt tutorials, guides and examples to C# from Wishlist to TODO.
Sun, Aug 12, 3:52 AM · Restricted Project, efl: docs
segfaultxavi raised the priority of T6129: Convert tutorials, guides and examples to C# from Wishlist to TODO.
Sun, Aug 12, 3:52 AM · efl: language bindings, efl: docs
segfaultxavi added a project to T6127: Provide documentation for C#: major change.
Sun, Aug 12, 3:47 AM · Active Work Proposal, major change, efl (efl-1.22), efl: docs
segfaultxavi raised the priority of T6127: Provide documentation for C# from Wishlist to TODO.
Sun, Aug 12, 3:46 AM · Active Work Proposal, major change, efl (efl-1.22), efl: docs

Tue, Aug 7

segfaultxavi added inline comments to D6743: eina_vpath: introduce eina_vpath in style of snprintf.
Tue, Aug 7, 6:45 AM · efl (efl-1.22)

Sat, Jul 28

segfaultxavi added a comment to D6689: efl_selection: reintroduce missing ELM_CNP_EVENT_SELECTION_CHANGED symbol..

I know nothing at all about this problem but, if the missing symbol is to be exported (EAPI) shouldn't it be in some header file too?

Sat, Jul 28, 1:54 AM · efl

Thu, Jul 26

segfaultxavi added a comment to T6131: Introduction on how to get started with EFL C#.

The preliminary page that existed in /pages/develop/legacy/tutorial/start.txt has been moved to /develop/setup/csharp/start.md, adapted to MarkDown and renamed to Setting Up a C# Development Environment, as the C counterpart. It has also been added to the navigation bar on the right.

Thu, Jul 26, 2:26 AM · efl: language bindings, efl: docs
segfaultxavi accepted D6685: eina: Add doxygen in/out tags for hash.

I cannot land it, though.

Thu, Jul 26, 1:33 AM · efl
segfaultxavi accepted D6686: eina: Add doxygen in/out tags for inlist and iterator.

I cannot land it, though.

Thu, Jul 26, 1:28 AM · efl

Wed, Jul 25

segfaultxavi triaged T7209: Turn C# button example into a proper example as TODO priority.
Wed, Jul 25, 3:11 AM · efl: language bindings, documentation, examples
segfaultxavi updated the task description for T7180: Make eolian_gen warn about missing documentation.
Wed, Jul 25, 1:07 AM · Restricted Project, efl: docs, Restricted Project

Tue, Jul 24

segfaultxavi added a comment to T7182: split legacy examples into examples repo as submodule.

A few random considerations:

  • Added benefit of having all the examples in the same place. Right now, it is a bit confusing.
  • Examples in doxygen comments still would need to be managed.
  • Having to clone a second repo is more inconvenient than just make examples in the efl tree, plus, efl would need to be built and installed before building the examples.
Tue, Jul 24, 10:08 AM · Active Work Proposal, major change, efl (efl-1.22), Restricted Project, efl: docs
segfaultxavi added a comment to T7204: Discussion about C# binding syntax.

I am going to use this ticket as a base for the C# documentation. @felipealmeida could you edit the description to add an explanation of the three C# classes that can be built for each eo class? (Button, IButton and ButtonInherit).

Tue, Jul 24, 7:53 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi added a project to T7204: Discussion about C# binding syntax: efl: language bindings.
Tue, Jul 24, 7:36 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Mon, Jul 23

segfaultxavi closed T7181: Life tutorial C# cannot be paused / resumed as Invalid.

Aaaaaaaaand you are right @lauromoura, I did not port your fix correctly.
I will update my diff and close this ticket as invalid.

Mon, Jul 23, 7:22 AM · efl: language bindings, efl: docs, examples
segfaultxavi added a comment to T7181: Life tutorial C# cannot be paused / resumed.

I included your fix (passing win to the constructor of the timer object) to my diff already :)

Mon, Jul 23, 7:17 AM · efl: language bindings, efl: docs, examples
segfaultxavi triaged T7181: Life tutorial C# cannot be paused / resumed as Normal priority.
Mon, Jul 23, 3:00 AM · efl: language bindings, efl: docs, examples
segfaultxavi triaged T7180: Make eolian_gen warn about missing documentation as TODO priority.
Mon, Jul 23, 2:30 AM · Restricted Project, efl: docs, Restricted Project

Jul 19 2018

segfaultxavi added inline comments to D6631: efl: fix some warnings in examples.
Jul 19 2018, 3:40 PM · efl
segfaultxavi added a revision to T6718: clean up uninitialized variable warnings in examples compile: D6631: efl: fix some warnings in examples.
Jul 19 2018, 1:09 AM · efl: docs, Restricted Project
segfaultxavi added a comment to D6577: elm: bring back elm/uiclock.

Yes, I do not think elm/uiclock.edc is needed, as the legacy version is elm/clock and the new one is efl/uiclock. If we remove that file, that is one less file to maintain.

Jul 19 2018, 12:56 AM · efl

Jul 18 2018

segfaultxavi triaged T7166: "make doc" gets stuck because "shot" ELM_ENGINE is not working as High priority.
Jul 18 2018, 7:49 PM · efl: rendering

Jul 17 2018

segfaultxavi added a comment to T7161: C# bindings: EFL classes cannot be inherited from.

Oh, ok, it was a documentation problem then :)

Jul 17 2018, 8:56 PM · efl (efl-1.22), efl: language bindings
segfaultxavi created T7161: C# bindings: EFL classes cannot be inherited from.
Jul 17 2018, 7:50 PM · efl (efl-1.22), efl: language bindings

Jul 16 2018

segfaultxavi added a comment to D6598: efl_ui_calendar: Check for valid spin timer before setting interval.

Whatever you do, remember to do it to all other spinners, since they are all assuming that sd->spin_* will be available. ALSO, I would like to know why this particular spinner is NULL.

Jul 16 2018, 6:42 PM · efl

Jul 13 2018

segfaultxavi edited the content of Maintainers Reviewers.
Jul 13 2018, 2:03 PM · efl
segfaultxavi edited the content of Maintainers Reviewers.
Jul 13 2018, 2:02 PM · efl
segfaultxavi added a comment to D6577: elm: bring back elm/uiclock.

Have you tried the other patch (D6580)? It also fixes the problem with the datetime widget, but removes completely elm_ui_clock and efl_ui_clock_legacy and internally it only uses the new efl_ui_clock.

Jul 13 2018, 8:53 AM · efl

Jul 12 2018

segfaultxavi added a comment to D6577: elm: bring back elm/uiclock.

I provided another diff, D6580, which uses only the new efl_ui_clock and completely removes the legacy version efl_ui_clock_legacy.

Jul 12 2018, 10:39 AM · efl
segfaultxavi added a revision to T6928: Datetime test doesn't display the datetime widget: D6580: elm: Make elm_datetime use the new efl_ui_clock.
Jul 12 2018, 10:36 AM · efl (efl-1.21), efl: widgets
Herald added a reviewer for D6577: elm: bring back elm/uiclock: devilhorns.
Jul 12 2018, 5:01 AM · efl
segfaultxavi added a revision to T6928: Datetime test doesn't display the datetime widget: D6577: elm: bring back elm/uiclock.
Jul 12 2018, 5:01 AM · efl (efl-1.21), efl: widgets
segfaultxavi claimed T6928: Datetime test doesn't display the datetime widget.

I'm on it!

Jul 12 2018, 3:17 AM · efl (efl-1.21), efl: widgets

Jul 11 2018

segfaultxavi updated the summary of D6553: eo: Fix efl_new without initializing parameters.
Jul 11 2018, 1:50 AM · efl
segfaultxavi updated the summary of D6553: eo: Fix efl_new without initializing parameters.
Jul 11 2018, 1:46 AM · efl
segfaultxavi updated the diff for D6553: eo: Fix efl_new without initializing parameters.

Updated the commit message.

Jul 11 2018, 1:44 AM · efl
segfaultxavi resigned from D6552: elm_fileselector: move to focus compostition.

Sorry, I have no knowledge whatsoever of how focus works at this moment.

Jul 11 2018, 1:35 AM · efl

Jul 10 2018

Herald added a reviewer for D6561: ecore: fix order of signal fd shutdown: devilhorns.
Jul 10 2018, 10:39 AM · efl
segfaultxavi added a reviewer for D6553: eo: Fix efl_new without initializing parameters: herdsman.
Jul 10 2018, 5:30 AM · efl
Herald added a reviewer for D6553: eo: Fix efl_new without initializing parameters: devilhorns.
Jul 10 2018, 5:29 AM · efl
segfaultxavi added a comment to T7119: evas_object_hide not working in the PackageKit gadget (in a bryce popup).

I've added this to my personal list of documentation tasks. At some point I'll turn this list into proper Phab tickets.

Jul 10 2018, 1:15 AM · enlightenment-git, efl

Jul 9 2018

segfaultxavi added a comment to D6538: elementary: Avoid passing NULL in some win focus methods.

Thought I might comment a bit on the fix... using while instead of do...while makes sure that NULL obj is immediately discarded and NULL is returned. This seemed more efficient (and funnier, and more elegant) than adding an extra if (!obj) return NULL.

Jul 9 2018, 8:42 AM · efl
Herald added a reviewer for D6538: elementary: Avoid passing NULL in some win focus methods: devilhorns.
Jul 9 2018, 8:38 AM · efl
segfaultxavi added a revision to T7030: efl internals pass null objects to functions which should not be passed null: D6538: elementary: Avoid passing NULL in some win focus methods.
Jul 9 2018, 8:38 AM · efl: data types, Restricted Project, efl (efl-1.21)
segfaultxavi accepted D6532: elm_focus_legacy: check if top is really a window.

I cannot land it.

Jul 9 2018, 4:04 AM · efl
segfaultxavi abandoned D6326: edje: Demote 'No such part...' from WRN to DBG.
Jul 9 2018, 3:40 AM · efl
segfaultxavi accepted D6531: elm_focus_legacy: fix focus moving for legacy.

OK, this is very confusing to me, but I have no previous knowledge of Focus. Plus, the documentation for the Focus API is horrible. I approve this because it works, but I would wait for another reviewer before landing.

Jul 9 2018, 3:20 AM · efl
segfaultxavi accepted D6533: elm_focus_legacy: remove wrong EINA_UNUSED.

I cannot land it.

Jul 9 2018, 3:11 AM · efl
segfaultxavi added a comment to D6532: elm_focus_legacy: check if top is really a window.

The change seems sensible enough, but I do not know why top has to be a window. Can you add a bit more of context in the ticket so that people not familiar with the subject can do a better review?

Jul 9 2018, 3:02 AM · efl
segfaultxavi requested changes to D6531: elm_focus_legacy: fix focus moving for legacy.

Patch works as expected, but I have some comments.

Jul 9 2018, 2:54 AM · efl

Jul 6 2018

segfaultxavi added a comment to D6527: C# bindings: Make efl_loop_timer.eo available to bindings.

@vitor.sousa Yeah, I don't like having special cases either... what alternative do we have? I guess we would need to split all those files into Legacy and Public parts, if that is possible.

Jul 6 2018, 11:43 AM · efl
segfaultxavi updated the summary of D6527: C# bindings: Make efl_loop_timer.eo available to bindings.
Jul 6 2018, 11:42 AM · efl
segfaultxavi updated the diff for D6527: C# bindings: Make efl_loop_timer.eo available to bindings.

Fix spelling errors. Happy, @zmike?

Jul 6 2018, 11:40 AM · efl
segfaultxavi added a task to D6527: C# bindings: Make efl_loop_timer.eo available to bindings: T7114: efl_loop_timer.eo is not accesible to bindings.
Jul 6 2018, 9:35 AM · efl
segfaultxavi added a revision to T7114: efl_loop_timer.eo is not accesible to bindings: D6527: C# bindings: Make efl_loop_timer.eo available to bindings.
Jul 6 2018, 9:35 AM · efl: language bindings
Herald added a reviewer for D6527: C# bindings: Make efl_loop_timer.eo available to bindings: devilhorns.
Jul 6 2018, 8:57 AM · efl
segfaultxavi triaged T7114: efl_loop_timer.eo is not accesible to bindings as TODO priority.
Jul 6 2018, 1:43 AM · efl: language bindings
segfaultxavi closed T6966: fix part namespacing in default theme as Resolved.

Yep. I tried to close it yesterday but it wouldn't let me.

Jul 6 2018, 1:19 AM · efl (efl-1.21), efl: widgets

Jul 5 2018

segfaultxavi added a comment to T6911: interface widgets use non-namespaced edje part names.

Isn't this task related to T6966? Should this one be closed when the other one closes?

Jul 5 2018, 6:31 AM · efl (efl-1.21), efl: widgets, Restricted Project
segfaultxavi triaged T7112: C# bindings: List<T>.Reverse() should return the same list instead of void as Normal priority.
Jul 5 2018, 2:57 AM · efl: language bindings
segfaultxavi added a comment to T7111: Edje theme api.

This definitely makes sense to me. Would have simplified the recent fixing of missing namespaces in API part names.

Jul 5 2018, 1:29 AM · Restricted Project, efl: layout engine

Jul 4 2018

segfaultxavi added a comment to D6507: ecore: fix public/private class separation.

Yeah, it confused me too. That file was present twice.

Jul 4 2018, 11:01 AM · efl
segfaultxavi requested review of D6507: ecore: fix public/private class separation.
Jul 4 2018, 8:32 AM · efl
Herald added a reviewer for D6507: ecore: fix public/private class separation: devilhorns.
Jul 4 2018, 8:32 AM · efl
segfaultxavi triaged T7108: C# bindings: eo-intro tutorial has an ERROR on shutdown as TODO priority.
Jul 4 2018, 6:07 AM · efl: language bindings

Jul 3 2018

segfaultxavi added a comment to D6500: eina/debug: remove global lock for session list access.

@bu5hm4n You'll have to land this, I cannot.

Jul 3 2018, 3:21 AM · efl
segfaultxavi accepted D6500: eina/debug: remove global lock for session list access.
Jul 3 2018, 3:21 AM · efl
segfaultxavi added a comment to D6499: eina/debug: rework session thread destruction to avoid deadlock on shutdown.

@bu5hm4n You'll have to land this, I cannot.

Jul 3 2018, 3:10 AM · efl
segfaultxavi accepted D6499: eina/debug: rework session thread destruction to avoid deadlock on shutdown.

Works as expected, the deadlock at the end with 100% CPU spinning has disappeared. Who added a while(1) loop without at least a usleep(1) there???

Jul 3 2018, 3:09 AM · efl

Jul 2 2018

segfaultxavi closed D6498: elementary: fix buffer overflow in efl/calendar widget.
Jul 2 2018, 6:57 AM · efl
Herald added a reviewer for D6498: elementary: fix buffer overflow in efl/calendar widget: devilhorns.
Jul 2 2018, 6:45 AM · efl
segfaultxavi triaged T7104: docs: documentation tree contains duplicated files on Windows as Wishlist priority.
Jul 2 2018, 1:52 AM · efl: docs

Jun 29 2018

segfaultxavi closed T6965: uiclock theme parts are badly named, a subtask of T6966: fix part namespacing in default theme, as Resolved.
Jun 29 2018, 8:51 AM · efl (efl-1.21), efl: widgets
segfaultxavi closed T6965: uiclock theme parts are badly named as Resolved.
Jun 29 2018, 8:51 AM · efl (efl-1.21), efl: widgets
segfaultxavi updated the diff for D6452: default theme: fix part names in elm/clock.

Added compatibility code

Jun 29 2018, 8:48 AM · efl
segfaultxavi closed T6967: calendar theme parts are badly named as Resolved.
Jun 29 2018, 8:41 AM · efl (efl-1.21), efl: widgets
segfaultxavi closed T6967: calendar theme parts are badly named, a subtask of T6966: fix part namespacing in default theme, as Resolved.
Jun 29 2018, 8:41 AM · efl (efl-1.21), efl: widgets
segfaultxavi updated the diff for D6453: default theme: fix part names in elm/calendar.

Added compatibility code

Jun 29 2018, 8:18 AM · efl
segfaultxavi updated the diff for D6456: default theme: fix part names in elm/scrollable/panel.

Added compatibility code to try to use the old part name in case the new one is not found in the theme.

Jun 29 2018, 2:19 AM · efl

Jun 28 2018

segfaultxavi created T7092: default theme: review part names for new API widgets.
Jun 28 2018, 11:03 AM · Restricted Project, efl: widgets
segfaultxavi added a comment to D6453: default theme: fix part names in elm/calendar.

Those are the occurrences which this diff also changes... ¬_¬'

Jun 28 2018, 10:25 AM · efl
segfaultxavi added a comment to D6456: default theme: fix part names in elm/scrollable/panel.

That is exactly the one occurrence which this diff also changes... ¬_¬'

Jun 28 2018, 10:24 AM · efl
segfaultxavi added a comment to T7088: git-phab documentation needs improving.

@zmike can you explain why your modified git-phab script is needed?

Jun 28 2018, 8:55 AM · efl: docs
segfaultxavi added a comment to D6388: edje_cc: add 'skip_namespace_validation' keyword.

I'm not sure what the intended workflow is.

Jun 28 2018, 8:27 AM · efl
segfaultxavi claimed T7088: git-phab documentation needs improving.

Notes to self:

  • Rename page to Submission guide instead of Arcanist guide.
  • If you pull down a commit from phab, modify it, and then want to update the phab revision, you need to remove all the keywords added by phab in the commit log, e.g., Summary, Reviewers, ...
Jun 28 2018, 8:00 AM · efl: docs
segfaultxavi updated the diff for D6450: default theme: remove unused elm/uiclock.

Made the commit message clearer (hopefully).

Jun 28 2018, 3:49 AM · efl
segfaultxavi added a comment to T6460: Elm config scale not reported in efl_ui_scale_get.

To me, the initial comment from JPEG makes sense. You set an objects local scale factor with efi_ui_scale_set and you retrieve exactly the same thing with efi_ui_scale_get. To get the real (final, consolidated, accumulated, aggregated, effective, whatever you want to call it) scale that will be used to draw your object, I would use a different (read-only) API, like efi_ui_effective_scale_get.

Jun 28 2018, 3:31 AM · efl: widgets, Restricted Project
segfaultxavi added a comment to D6453: default theme: fix part names in elm/calendar.

I could not find the words ch_ or cit_ anywhere in E, Terminology, Rage, Ephoto, Edi, Eflete, Enventor, Clouseau or Evisum. Are you sure this needs compatibility code, @zmike ?

Jun 28 2018, 1:39 AM · efl
segfaultxavi added a comment to D6456: default theme: fix part names in elm/scrollable/panel.

I could not find the words panel_area or event_area anywhere in E, Terminology, Rage, Ephoto, Edi, Eflete, Enventor, Clouseau or Evisum. Are you sure this needs compatibility code, @zmike ?

Jun 28 2018, 1:31 AM · efl
segfaultxavi claimed T6130: Adapt tutorials, guides and examples to C#.
Jun 28 2018, 12:39 AM · Restricted Project, efl: docs

Jun 27 2018

Herald added a reviewer for D6463: default theme: fix part names in notification: devilhorns.
Jun 27 2018, 10:06 AM · efl
segfaultxavi added a child revision for D6462: default theme: fix part names in dialog: D6463: default theme: fix part names in notification.
Jun 27 2018, 10:06 AM · efl
segfaultxavi added a revision to T6966: fix part namespacing in default theme: D6463: default theme: fix part names in notification.
Jun 27 2018, 10:06 AM · efl (efl-1.21), efl: widgets