Page MenuHomePhabricator

segfaultxavi (Xavi Artigas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 3:04 AM (71 w, 3 d)
Availability
Available

Recent Activity

Today

segfaultxavi added a comment to D8000: eo: mark efl_object stable.

Can you add @since 1.22 at the same time that you remove the @beta from the class? (as suggested in T7704).

Sat, Feb 23, 9:05 AM · efl
segfaultxavi requested review of D8012: mono-docs: Use @since tags properly.
Sat, Feb 23, 8:59 AM · efl
segfaultxavi added a comment to T7704: verify @since tags for stabilized apis.

I suggest the same commit that removes the @beta tag adds @since 1.22 to the class docs.

Sat, Feb 23, 7:45 AM · efl (efl-1.22), efl: docs, efl: api

Yesterday

segfaultxavi closed D8003: examples: Fix cxx examples compilation..
Fri, Feb 22, 8:23 AM · efl
segfaultxavi accepted D8003: examples: Fix cxx examples compilation..
Fri, Feb 22, 7:56 AM · efl
segfaultxavi closed D7998: docs: Polish focus documentation..
Fri, Feb 22, 6:58 AM · efl
segfaultxavi updated the diff for D7998: docs: Polish focus documentation..

Rebased

Fri, Feb 22, 6:54 AM · efl
segfaultxavi accepted D7994: efl_ui_focus_object: rename API.

Macro doc_cop_approves:

Fri, Feb 22, 4:52 AM · efl
segfaultxavi added a comment to D7999: eolian: validate betaness.

I approve the docs 😁

Fri, Feb 22, 4:51 AM · efl
segfaultxavi added a comment to D7999: eolian: validate betaness.

Commit message:

Fri, Feb 22, 4:46 AM · efl
segfaultxavi assigned T7702: Remove internally generated classes from EFL# doc to lauromoura.

Yes, there are a lot of these. @lauromoura and @felipealmeida were already looking at making these classes private or internal so they don't show up in the docs, right?

Fri, Feb 22, 4:43 AM · documentation, efl: language bindings
segfaultxavi added a parent task for T7702: Remove internally generated classes from EFL# doc: T6128: Generate C# reference API documentation.
Fri, Feb 22, 4:41 AM · documentation, efl: language bindings
segfaultxavi added a subtask for T6128: Generate C# reference API documentation: T7702: Remove internally generated classes from EFL# doc.
Fri, Feb 22, 4:41 AM · efl: language bindings, efl: docs
segfaultxavi moved T7702: Remove internally generated classes from EFL# doc from Backlog to TODO on the efl: language bindings board.
Fri, Feb 22, 4:41 AM · documentation, efl: language bindings
segfaultxavi moved T7487: efl-mono: Remove initializer methods and add constructor parameters from InProgress to Done on the efl: language bindings board.
Fri, Feb 22, 4:39 AM · efl: language bindings
segfaultxavi moved T7364: efl-mono: Object gets deleted after a while even though it has an EFL parent from TODO to Done on the efl: language bindings board.
Fri, Feb 22, 4:39 AM · efl: language bindings
segfaultxavi moved T7108: C# bindings: eo-intro tutorial has an ERROR on shutdown from TODO to Done on the efl: language bindings board.
Fri, Feb 22, 4:38 AM · efl: language bindings
segfaultxavi moved T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract from TODO to Done on the efl: language bindings board.
Fri, Feb 22, 4:38 AM · efl: language bindings, Restricted Project
segfaultxavi moved T7505: efl-mono: Add <value> tags to Properties documentation from TODO to Done on the efl: language bindings board.
Fri, Feb 22, 4:38 AM · efl: language bindings, efl: docs
segfaultxavi moved T7619: C# Interface Concrete classes are generating methods as if they were static from TODO to Done on the efl: language bindings board.
Fri, Feb 22, 4:38 AM · efl: language bindings
segfaultxavi closed T7505: efl-mono: Add <value> tags to Properties documentation as Resolved.

Closed by a152ba6d5b7e

Fri, Feb 22, 4:38 AM · efl: language bindings, efl: docs
segfaultxavi closed T7505: efl-mono: Add <value> tags to Properties documentation, a subtask of T6128: Generate C# reference API documentation, as Resolved.
Fri, Feb 22, 4:38 AM · efl: language bindings, efl: docs
segfaultxavi added a comment to T7580: efl.ui.factory.

The docs are a bit weird to someone reading it the first time, but that does not block stabilization. @segfaultxavi what do you say ?

Fri, Feb 22, 4:33 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7701: Rename Efl.Ui.Stack.

I do not understand what is the problem. You want to rename Efl.Ui.Stack ? Why?

Fri, Feb 22, 4:27 AM · efl: api
segfaultxavi updated the diff for D7976: docs: Assorted fixes.

Remove efl_ui_focus_object.eo changes since they have been dealt with in anotyher patch.

Fri, Feb 22, 3:58 AM · efl
segfaultxavi requested review of D7998: docs: Polish focus documentation..
Fri, Feb 22, 3:48 AM · efl
segfaultxavi added a child revision for D7994: efl_ui_focus_object: rename API: D7998: docs: Polish focus documentation..
Fri, Feb 22, 3:48 AM · efl
segfaultxavi requested changes to D7994: efl_ui_focus_object: rename API.
Fri, Feb 22, 2:57 AM · efl
segfaultxavi accepted D7989: efl_ui_focus_object: rename events.
Fri, Feb 22, 2:50 AM · efl
segfaultxavi added a comment to D7989: efl_ui_focus_object: rename events.

Makes sense. Typo in commit message though: "match", not "math".

Fri, Feb 22, 2:50 AM · efl
segfaultxavi accepted D7993: efl_ui_focus_composition: remove unneeded API.

Seems simple enough, and everything seems to be working.

Fri, Feb 22, 2:45 AM · efl
segfaultxavi accepted D7992: efl_ui_focus_object: improve doc.
Fri, Feb 22, 2:14 AM · efl
segfaultxavi accepted D7991: efl_ui_focus_manager: improve docs.

Overall improvement, but will add another polish layer in another patch.

Fri, Feb 22, 2:07 AM · efl
segfaultxavi accepted D7990: efl_ui_focus_manager: rename focus,changed.

Makes sense (and builds).

Fri, Feb 22, 2:03 AM · efl

Thu, Feb 21

segfaultxavi accepted D7864: ecore: enforce proper lifecycle for all Efl.Composite_Model children..
Thu, Feb 21, 11:40 PM · efl
segfaultxavi requested changes to D7907: efl.content: add event for when content is changed containing content as data.

src/lib/elementary/efl_ui_pan.eo also defines the content,changed event, but with a different type. This produces a C# warning.
Both events have the same meaning, so the event in Efl.Ui.Pan could be removed and emit the event from Efl.Content (with attached Efl.gfx.Entity).

Thu, Feb 21, 1:21 PM · efl
segfaultxavi added a commit to T7561: efl.animator: rEFLaf7d1ef7eda6: interfaces: move animator,tick to efl.canvas.object and remove efl.animator.
Thu, Feb 21, 1:04 PM · efl: api, efl (efl-1.22)
segfaultxavi closed D7905: interfaces: move animator,tick to efl.canvas.object and remove efl.animator.
Thu, Feb 21, 1:04 PM · efl
segfaultxavi resigned from D7865: eio: enforce proper lifecycle for all Efl.Io_Model and fix discovered lifecycle bugs..

OK, this is far too complicated for my current knowledge. I humbly resign as a reviewer.

Thu, Feb 21, 12:37 PM · efl
segfaultxavi requested changes to D7864: ecore: enforce proper lifecycle for all Efl.Composite_Model children..

Can you please check all this alleged leaks and tell me if they are right or wrong?

Thu, Feb 21, 12:33 PM · efl
segfaultxavi accepted D7862: ecore: add infrastructure to make it easy to enforce Efl.Loop_Model children lifecycle..
Thu, Feb 21, 12:18 PM · efl
segfaultxavi closed D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.
Thu, Feb 21, 10:20 AM · efl
segfaultxavi updated the diff for D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.

Rebase

Thu, Feb 21, 10:19 AM · efl
segfaultxavi added a comment to T7558: efl.gfx.entity.

Doesn't the scale change the resulting size of the object? :/

Thu, Feb 21, 9:52 AM · efl: api, efl (efl-1.22)
segfaultxavi added a commit to T7563: efl.gfx.size_hint: rEFLe4b98a243b0b: api: efl.gfx.hints.change,size,hints -> efl.gfx.hints.hints,changed.
Thu, Feb 21, 9:47 AM · efl: api, efl (efl-1.22)
segfaultxavi closed D7978: api: efl.gfx.hints.change,size,hints -> efl.gfx.hints.hints,changed.
Thu, Feb 21, 9:47 AM · efl
segfaultxavi closed D7977: api: efl.gfx.size_hints -> efl.gfx.hints.
Thu, Feb 21, 9:46 AM · efl
segfaultxavi added a commit to T7563: efl.gfx.size_hint: rEFLf886941b1125: api: efl.gfx.size_hints -> efl.gfx.hints.
Thu, Feb 21, 9:46 AM · efl: api, efl (efl-1.22)
segfaultxavi closed D7968: efl.gfx.stack: restack -> stack,changed.
Thu, Feb 21, 9:46 AM · efl: api
segfaultxavi closed D7967: efl.screen: add screen_scale_factor property.
Thu, Feb 21, 9:46 AM · efl: api
segfaultxavi added a commit to T7560: efl.gfx.stack: rEFL94efabedf647: efl.gfx.stack: restack -> stack,changed.
Thu, Feb 21, 9:46 AM · efl: api, efl (efl-1.22)
segfaultxavi added a commit to T7590: efl.screen: rEFL606b0381c184: efl.screen: add screen_scale_factor property.
Thu, Feb 21, 9:46 AM · efl: api, efl (efl-1.22)
segfaultxavi closed D7966: efl.screen: add screen_size_in_mm property.
Thu, Feb 21, 9:46 AM · efl: api
segfaultxavi added a commit to T7590: efl.screen: rEFL56c279edf4d1: efl.screen: add screen_size_in_mm property.
Thu, Feb 21, 9:45 AM · efl: api, efl (efl-1.22)
segfaultxavi added a commit to T7590: efl.screen: rEFL831b746a9265: efl.screen: screen_size -> screen_size_in_pixels.
Thu, Feb 21, 9:45 AM · efl: api, efl (efl-1.22)
segfaultxavi closed D7965: efl.screen: screen_size -> screen_size_in_pixels.
Thu, Feb 21, 9:45 AM · efl: api
segfaultxavi added a comment to T7558: efl.gfx.entity.

+1 to position,changed and size,changed (which should have been moved and resized from the beginning).

Thu, Feb 21, 9:38 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7563: efl.gfx.size_hint.

We discussed the naming issue at length on IRC and I have no further concerns. This is good to go for me.

Thu, Feb 21, 9:34 AM · efl: api, efl (efl-1.22)
segfaultxavi accepted D7978: api: efl.gfx.hints.change,size,hints -> efl.gfx.hints.hints,changed.
Thu, Feb 21, 9:33 AM · efl
segfaultxavi accepted D7977: api: efl.gfx.size_hints -> efl.gfx.hints.

Macro doc_cop_approves:

Thu, Feb 21, 9:32 AM · efl
segfaultxavi accepted D7967: efl.screen: add screen_scale_factor property.
Thu, Feb 21, 9:19 AM · efl: api
segfaultxavi accepted D7966: efl.screen: add screen_size_in_mm property.
Thu, Feb 21, 9:18 AM · efl: api
segfaultxavi added a comment to D7982: efl_loop / efl_app: make efl_app / efl_loop abstract.

How about turning these classes into interfaces instead? That would make sense form the user's POV, and the actual implementation would be hidden.
(dunno how hard that would be to implement though)

Thu, Feb 21, 8:29 AM · efl
segfaultxavi accepted D7983: efl_loop_timer: resolve fixups of documentation.

Macro doc_cop_approves:

Thu, Feb 21, 8:23 AM · efl
segfaultxavi created Image Macro "doc_cop_approves".
Thu, Feb 21, 8:22 AM
segfaultxavi added a comment to D7982: efl_loop / efl_app: make efl_app / efl_loop abstract.

I understand the need for this safeguard, but making the classes abstract looks a bit hackish. Users can still inherit from these classes and instantiate that.
I don't know any other "simple" solution, so I am not rejecting this patch :)

Thu, Feb 21, 8:14 AM · efl
segfaultxavi requested changes to D7983: efl_loop_timer: resolve fixups of documentation.

Xavi is not happy. Just just had to copy&paste my comment into the Eo file...

Thu, Feb 21, 8:12 AM · efl
segfaultxavi added reviewers for D7978: api: efl.gfx.hints.change,size,hints -> efl.gfx.hints.hints,changed: segfaultxavi, cedric, bu5hm4n.
Thu, Feb 21, 7:48 AM · efl
segfaultxavi requested changes to D7966: efl.screen: add screen_size_in_mm property.
Thu, Feb 21, 7:44 AM · efl: api
segfaultxavi requested changes to D7967: efl.screen: add screen_scale_factor property.

Something went wrong. screen_scale_factor appears twice in the file now.

Thu, Feb 21, 7:43 AM · efl: api
segfaultxavi added reviewers for D7977: api: efl.gfx.size_hints -> efl.gfx.hints: segfaultxavi, cedric, bu5hm4n.

I think this is the first time we REDUCED the length of an API call.

Thu, Feb 21, 7:37 AM · efl
segfaultxavi added inline comments to D7983: efl_loop_timer: resolve fixups of documentation.
Thu, Feb 21, 7:30 AM · efl
segfaultxavi updated the diff for D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.

You are right @Jaehyun_Cho! Thanks!

Thu, Feb 21, 7:19 AM · efl
segfaultxavi closed D7971: tests: Include ecore test dir for generated eo.h.
Thu, Feb 21, 4:18 AM · efl
segfaultxavi accepted D7971: tests: Include ecore test dir for generated eo.h.

Does as advertised.

Thu, Feb 21, 4:17 AM · efl
segfaultxavi accepted D7967: efl.screen: add screen_scale_factor property.
Thu, Feb 21, 2:59 AM · efl: api
segfaultxavi added a comment to T7383: Efl.Config and Efl.Config_GLobal.

Initially @bu5hm4n stated that Efl.Config should contain all the API and Efl.Config_Global should just be a singleton implementing that API (nothing has been done in this regard yet).
Then @Jaehyun_Cho brought in the discussion from another thread (T7356):

  • The ELM config API has a thousand methods: elm_config_finger_size_get(), elm_config_scroll_thumbscroll_min_friction_set(), etc
  • This was replaced by a generic config API in the new API: Eina_Value *efl_config_get(const char *name) and efl_config_set(const char *name, const Eina_Value *value).
  • While the new API is more flexible, it has two drawbacks:
    • The user does not know which config values are available since they are strings which must be looked up in the docs (previously, the IDE could help you).
    • The user does not know the TYPE of the config values, they must be looked up in the docs (previously this was known).
Thu, Feb 21, 2:52 AM · efl (efl-1.22)
segfaultxavi requested review of D7976: docs: Assorted fixes.
Thu, Feb 21, 2:33 AM · efl
segfaultxavi added a comment to D7971: tests: Include ecore test dir for generated eo.h.

How do I do an off-tree build?

Thu, Feb 21, 2:25 AM · efl
segfaultxavi added a comment to D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.

This patch already takes into account @cedric's comments from the github repo.

Thu, Feb 21, 2:22 AM · efl
segfaultxavi added a task to D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping: T7564: efl.gfx.map.
Thu, Feb 21, 1:57 AM · efl
segfaultxavi added a revision to T7564: efl.gfx.map: D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.
Thu, Feb 21, 1:57 AM · efl: api, efl (efl-1.22)
segfaultxavi updated the diff for D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.

Minor whitespace formatting

Thu, Feb 21, 1:55 AM · efl
segfaultxavi requested review of D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.
Thu, Feb 21, 1:53 AM · efl

Tue, Feb 19

segfaultxavi added a comment to T7571: efl.ui.focus.object.
  • From the Focus tutorial: "There are 6 commands for Focus navigation: 4 *directional* (Up, Down, Left, Right) and 2 *ordinal* (Previous and Next).". I never liked the word "ordinal", and I am going to change it to "sequential". Therefore, I propose we change the method to sequence_setup or sequence_prepare. The docs should explain that this method is meant to configure the sequence of widgets you get when you navigate through "previous" and "next". The event then could b
  • prepare_logical_none_recursive should be prepare_logical_non_recursive (this is not critical as it is internal).
Tue, Feb 19, 7:40 AM · efl: api, efl (efl-1.22)

Fri, Feb 15

segfaultxavi accepted D7968: efl.gfx.stack: restack -> stack,changed.
Fri, Feb 15, 2:41 PM · efl: api
segfaultxavi accepted D7966: efl.screen: add screen_size_in_mm property.
Fri, Feb 15, 2:39 PM · efl: api
segfaultxavi accepted D7965: efl.screen: screen_size -> screen_size_in_pixels.
Fri, Feb 15, 2:38 PM · efl: api
segfaultxavi requested changes to D7967: efl.screen: add screen_scale_factor property.
Fri, Feb 15, 11:46 AM · efl: api
segfaultxavi requested changes to D7966: efl.screen: add screen_size_in_mm property.
Fri, Feb 15, 11:41 AM · efl: api
segfaultxavi accepted D7965: efl.screen: screen_size -> screen_size_in_pixels.
Fri, Feb 15, 11:38 AM · efl: api
segfaultxavi added a comment to D7934: Efl.Gfx.Stack: Rename raise and lower.

actually raise and lower mean to top and bottom commonly. xrwaisewindow and xlowerwindow certainly do. in Qt its raise() and lower() methods.

Well, raise() and lower() already proved to be confusing (since both @cedric and myself understood them incorrectly). The X API is famous for being laconic.

Fri, Feb 15, 9:29 AM · efl
segfaultxavi added a comment to D7934: Efl.Gfx.Stack: Rename raise and lower.

actually raise and lower mean to top and bottom commonly. xrwaisewindow and xlowerwindow certainly do. in Qt its raise() and lower() methods.

Well, raise() and lower() already proved to be confusing (since both @cedric and myself understood them incorrectly). The X API is famous for being laconic.

Fri, Feb 15, 9:24 AM · efl
segfaultxavi added a comment to T7562: efl.input.interface.

Oh, I thought to meant "conceptual" overlap, sorry.

Fri, Feb 15, 8:56 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7574: efl.ui.selection.

Looks like that, yeah.

Fri, Feb 15, 8:44 AM · efl: api, efl (efl-1.22)
segfaultxavi updated subscribers of T7563: efl.gfx.size_hint.

I do not like the name of this interface. First off, it not only contains size hints, also position (like hint_align). I'd prefer something like Efl.Gfx.Geometry_Hint.
Secondly, Size_Hint suggests that this is a hint, instead of an object accepting hints, but I cannot come up with a better name for that.

Fri, Feb 15, 8:39 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7555: efl.canvas.object.

I agree is_frame_object() seems internal, as its own docs say.

Fri, Feb 15, 7:56 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7562: efl.input.interface.

Where? I cannot find any overlap.

Fri, Feb 15, 7:41 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7672: efl.file_save.

I initially listed some concerns, which you addressed with specific proposals:

In T7672#130634, @zmike wrote:

To propose a more concrete change here:

  • move existing efl_file(_save) into efl_gfx (either directly or as efl.gfx.file)
  • keep simple efl.file mixin with only file property
    • remove key
  • keep simple efl.file_save interface
    • remove flags
  • create file_key property to go with the file api which has been moved to efl_gfx
  • create save_flags property to go with file api in efl_gfx

And we all agreed, so you are free to implement those.

Fri, Feb 15, 7:36 AM · efl: api, efl (efl-1.22)
segfaultxavi added a commit to T7584: efl.canvas.scene: rEFL4935202caab9: efl.canvas.scene: improve class docs.
Fri, Feb 15, 7:24 AM · efl: api, efl (efl-1.22)