Page MenuHomePhabricator

segfaultxavi (Xavi Artigas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 3:04 AM (87 w, 3 d)
Availability
Available

Recent Activity

Today

segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

@bu5hm4n I'm not arguing against using a Promise, I'm just trying to see if there are alternatives :)

Sat, Jun 15, 6:46 AM · efl

Yesterday

segfaultxavi added a comment to D9060: efl_ui_radio: cleanup API.

Good point! Agreed!

Fri, Jun 14, 11:03 AM · efl
segfaultxavi added a comment to T7898: efl.ui.format.

https://media.giphy.com/media/oOX5qIDkzDjeo/giphy.gif

Fri, Jun 14, 9:45 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7897: efl.ui.spin.

I've written my concerns in T7898.

Fri, Jun 14, 9:18 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

This class needs serious doc love. I do not understand how format_cb and format_string are supposed to interact. Also, Format_Func_Cb only has input parameters, no output, where is the formatted string supposed to be written?

Fri, Jun 14, 9:17 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7897: efl.ui.spin.

And I still don't know how would you implement the special values with a format string.

Fri, Jun 14, 8:25 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7900: efl.pack_table.

When you say "Let us cut it"... who exactly is us? 😁

Fri, Jun 14, 8:22 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added inline comments to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.
Fri, Jun 14, 8:20 AM · efl
segfaultxavi requested review of D9090: Efl.Ui.Slider: Rename event delay,changed to steady.
Fri, Jun 14, 7:59 AM · efl
segfaultxavi added a comment to T7847: efl.ui.clickable.

I like "primary" more than "any", yep.

Fri, Jun 14, 7:11 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi assigned T8012: Support default values @property's keys and method's params in eo to lauromoura.

So, if I understood correctly, when a parameter has a default value in an Eo file like this:

center @beta {
   params {
      @in h : bool(true);
      @in v : bool(true);
   }
Fri, Jun 14, 4:14 AM · efl: language bindings, Restricted Project
segfaultxavi added a reviewer for D9070: eo: add an API entry for custom instantiation of Eo objects for binding usage: q66.

Probably @q66 also wants to know about this.

Fri, Jun 14, 4:10 AM · efl
segfaultxavi triaged T8017: efl-mono: in-tree examples do not build anymore as Normal priority.
Fri, Jun 14, 2:59 AM · efl: language bindings
segfaultxavi added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

Thanks. And I see the Unified equivalent is Efl.Ui.Frame. I had never come across it.

Fri, Jun 14, 2:01 AM · efl
segfaultxavi added a comment to D8919: efl_ui_navigation_bar: migrate to active_view.

OK, in that case, I have no comments regarding documentation, nomenclature or functionality, since tests seem to work correctly.
I am not reviewing the code, though.

Fri, Jun 14, 1:04 AM · efl
segfaultxavi added a comment to T7893: efl.ui.slider.

So just steady? How about that?

Fri, Jun 14, 1:02 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D9060: efl_ui_radio: cleanup API.

Well, this is what you get when things are not clearly documented. We already agreed that properties in the constructors section can only be set during construction, however, we never specified if other properties can be set there.
In C# this is enforced (only constructor properties can be set during construction, simply because we removed initialization lists), but in C you can still do it.
There used to be a task for this (T7477), which didn't reach any conclusion.

Fri, Jun 14, 1:01 AM · efl

Thu, Jun 13

segfaultxavi added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

Yeah, creating logical groups of widgets might make sense, but I see no benefit right now for widgets other than Radio Buttons...

Thu, Jun 13, 9:31 AM · efl
segfaultxavi added a comment to T7893: efl.ui.slider.

I think stable conveys the exact meaning, but that might be my signal processing background.
stabilized instead of changed?
changed,steady?

Thu, Jun 13, 9:27 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

it does seem like there is more use case for this than just the radio widget...

Thu, Jun 13, 9:10 AM · efl
segfaultxavi added a comment to D8919: efl_ui_navigation_bar: migrate to active_view.

I get the same crash after applying D8920 :(

Thu, Jun 13, 9:04 AM · efl
segfaultxavi added a comment to T7964: Efl.Input.Key.

Sorry, I am not familiar with X11 so I do not see the difference between a key name and a raw key name... example?

Thu, Jun 13, 8:42 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to T7897: efl.ui.spin.

How would you implement the special values with a format string? The Efl.Ui.Format mixin is still beta and I do not understand how format_string and format_cb interact.

Thu, Jun 13, 8:17 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7893: efl.ui.slider.

I had to look at the code to understand what is delay,changed.
This is emitted 0.2s after the slider stops moving. Every time the slider moves, the timer is restarted.
There's no doc about this, but thanks to my background in GStreamer I know this is useful to delay any expensive action (like seeking on a media stream) until the user stops scrubbing the slider up and down.

Thu, Jun 13, 7:37 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7973: Efl.Input.Value.

I'm not sure. This is an enum of all possible data (capabilities, properties, features) that can be attached to any input event. This works for mice and fingers but also for joysticks, tablet orientation sensors and generic sliders. I do not think Pointer matches all these devices.

Thu, Jun 13, 7:24 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to T7853: efl.text_interactive.

Efl.Text_Cursor_Info works for me.

Thu, Jun 13, 7:12 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7863: efl.ui.direction.

YAS

Thu, Jun 13, 5:13 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7853: efl.text_interactive.

That would be consistent with other APIs, agreed.

Thu, Jun 13, 4:54 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7964: Efl.Input.Key.

I see nothing wrong, but I cannot be sure because the docs are absolutely horrible. What is the difference between key and key_name? What is this composition? I would love to see examples.

Thu, Jun 13, 4:49 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to D8919: efl_ui_navigation_bar: migrate to active_view.

Don't know if it's related, but when executing the Efl.Ui.Stack elm_test, if I press the Prev button right atfer starting the test, I get a crash with this message:

ERR<104521>:eina_safety ../src/lib/elementary/efl_ui_layout.c:958 _efl_ui_layout_base_efl_layout_signal_signal_emit() safety check failed: efl_invalidated_get(obj) is true
Thu, Jun 13, 4:41 AM · efl
segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

After talking with @bu5hm4n I now understand we cannot keep an extra ref to the view while animating, because the user can do all sorts of strange things with it.

Thu, Jun 13, 4:22 AM · efl
segfaultxavi added a comment to T7965: Efl.Input.Hold.

Does that mean that it should not be public API?

Thu, Jun 13, 3:35 AM · efl (efl-1.23), efl: api
segfaultxavi requested changes to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

With the latest diff the window now appears and I get no console errors, but I can check ALL radio buttons, and there's no way to uncheck them :/

Thu, Jun 13, 3:34 AM · efl
segfaultxavi added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

And all of the above comments by @bu5hm4n are already explained in the updated docs in D9061 😁

Thu, Jun 13, 3:30 AM · efl
segfaultxavi added a comment to T7873: efl.ui.image.

I am wondering if we could not get rid of Efl.Ui.Image_Error and just use Eina_Error.

+1

Thu, Jun 13, 3:22 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi requested changes to D8920: efl_ui_stack: remove!.

I also think adding push & pop to the container makes sense.
I do not like the names active_view_pack/unpack though. They can be confused with the normal pack/unpack from the Efl.Pack_Linear interface.
I think the names push & pop are perfectly understood by everybody, why not use active_view_push/pop? It's less confusing.

Thu, Jun 13, 3:18 AM · efl

Wed, Jun 12

segfaultxavi added a comment to T7873: efl.ui.image.

Sorry, but the concept of Total percentage confuses me. Isn't that always 100 by definition?

Wed, Jun 12, 1:05 PM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.
In D9058#166856, @zmike wrote:

On one hand, I like the idea of radio box, but on the other hand I feel like this opens up a can of worms. If we have radio box, shouldn't we also have a check box? What about a button box? Image box?

Wed, Jun 12, 11:33 AM · efl
segfaultxavi added a comment to T7900: efl.pack_table.

geometry reminds me of rectangles, squares or circles...
table_size is redundant anyway, since it has the same info as table_columns and table_rows. Maybe we can just remove it...

Wed, Jun 12, 11:31 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi requested changes to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

Only some comments regarding the efl_ui_radio_example_01 example.
Also, the example does not render correctly for me, the window has 0-size and shows this in the console:

ERR<77946>:eina_safety ../src/lib/elementary/efl_ui_radio_box.c:18 register_safe_in_group_begin() safety check failed: efl_isa(subobj, EFL_UI_RADIO_CLASS) is false

I think it worked correctly in the previous diff.

Wed, Jun 12, 4:35 AM · efl

Fri, May 31

segfaultxavi closed D9062: Remove unused Efl.Gfx.Path_Change_Event.
Fri, May 31, 8:41 AM · efl
segfaultxavi requested review of D9062: Remove unused Efl.Gfx.Path_Change_Event.
Fri, May 31, 8:12 AM · efl
segfaultxavi added a comment to T7900: efl.pack_table.

Yeah, I didn't update this description. Done now.

Fri, May 31, 6:32 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated the task description for T7900: efl.pack_table.
Fri, May 31, 6:32 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated the diff for D9061: Efl.Ui.Radio: Update docs.

Clarifications.

Fri, May 31, 4:18 AM · efl
segfaultxavi requested review of D9061: Efl.Ui.Radio: Update docs.
Fri, May 31, 3:56 AM · efl
segfaultxavi added a child revision for D9060: efl_ui_radio: cleanup API: D9061: Efl.Ui.Radio: Update docs.
Fri, May 31, 3:56 AM · efl
segfaultxavi added a revision to T7867: efl.ui.radio: D9061: Efl.Ui.Radio: Update docs.
Fri, May 31, 3:56 AM · efl: api, efl (efl-1.23), efl: language bindings

Thu, May 30

segfaultxavi closed D9057: efl_ui_active_view: reset count to -1 if no content is left.
Thu, May 30, 10:07 AM · efl
segfaultxavi accepted D9057: efl_ui_active_view: reset count to -1 if no content is left.

Fixes tests

Thu, May 30, 10:07 AM · efl
segfaultxavi closed T7989: Efl.Ui.Active_View: animation comes from wrong direction when current page is deleted as Resolved by committing rEFL2f28d0c593ee: efl_ui_active_view: update index accordingly.
Thu, May 30, 7:59 AM · efl: widgets, efl (efl-1.23)
segfaultxavi closed T7989: Efl.Ui.Active_View: animation comes from wrong direction when current page is deleted, a subtask of T7991: efl.ui.active_view.container, as Resolved.
Thu, May 30, 7:59 AM · efl (efl-1.23), efl: language bindings
segfaultxavi closed D9055: efl_ui_active_view: update index accordingly.
Thu, May 30, 7:59 AM · efl
segfaultxavi closed T7988: Efl.Ui.Active_View: double-click on elm_test "Set Active Index" button resets animation, a subtask of T7991: efl.ui.active_view.container, as Resolved.
Thu, May 30, 7:57 AM · efl (efl-1.23), efl: language bindings
segfaultxavi closed T7988: Efl.Ui.Active_View: double-click on elm_test "Set Active Index" button resets animation as Resolved by committing rEFL65deb248e384: efl_ui_active_view_manager_*: fix bugging animation.
Thu, May 30, 7:57 AM · efl (efl-1.23), efl: widgets
segfaultxavi closed D9056: efl_ui_active_view_manager_*: fix bugging animation.
Thu, May 30, 7:57 AM · efl
segfaultxavi accepted D9056: efl_ui_active_view_manager_*: fix bugging animation.
Thu, May 30, 7:56 AM · efl
segfaultxavi added a comment to T6716: allow enum/class/struct renaming.

I am wondering, how does this new @c_name tag relate to the already-existing c_prefix keyword?
Is it meant to replace it?
What happens if a class has both tags?

Thu, May 30, 7:51 AM · efl: language bindings, Restricted Project
segfaultxavi requested changes to D8887: evas: add 'clipper_is_static' property for canvas objects.
In D8887#166127, @zmike wrote:

I'm not so sure about dropping clipper from the name; this functionality only exists for objects which are clippers, so shouldn't the naming indicate this?

Thu, May 30, 7:44 AM · efl: rendering
segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

The Push and Pop behavior can be already implemented by setting the gravity property to index, setting the active_index to 0, and then doing "Push" with pack_begin and "Pop" with unpack_at(0) (all this is documented in the new docs).

Thu, May 30, 6:40 AM · efl
segfaultxavi requested changes to D9056: efl_ui_active_view_manager_*: fix bugging animation.

Fixes the reported issue but I'd like to have that small clarification...

Thu, May 30, 6:24 AM · efl
segfaultxavi accepted D9055: efl_ui_active_view: update index accordingly.

Fixes the Scroller problems. Stack still has issues but they seem to be already present before this patch so I'll open separate tickets.
Also, fix makes sense.

Thu, May 30, 6:20 AM · efl
segfaultxavi added a comment to D8887: evas: add 'clipper_is_static' property for canvas objects.

Thanks for the context!

Thu, May 30, 5:51 AM · efl: rendering
segfaultxavi updated the task description for T6129: Write tutorials, guides and examples in C#.
Thu, May 30, 3:40 AM · efl: language bindings, efl: docs
segfaultxavi triaged T7990: Efl.Ui.Active_View: new pages not always shown as Normal priority.
Thu, May 30, 3:09 AM · efl: widgets, efl (efl-1.23)
segfaultxavi triaged T7989: Efl.Ui.Active_View: animation comes from wrong direction when current page is deleted as Normal priority.
Thu, May 30, 2:57 AM · efl: widgets, efl (efl-1.23)
segfaultxavi closed D9044: Efl.Ui.Active_View: Update Docs.
Thu, May 30, 2:53 AM · efl
segfaultxavi triaged T7988: Efl.Ui.Active_View: double-click on elm_test "Set Active Index" button resets animation as Normal priority.
Thu, May 30, 2:40 AM · efl (efl-1.23), efl: widgets
segfaultxavi resigned from D9053: evas_object_textblock: add support for variation sequences.

@segfaultxavi are not these internal APIs ?

Thu, May 30, 1:50 AM · efl
segfaultxavi requested changes to D9053: evas_object_textblock: add support for variation sequences.

I am no expert in Unicode so I cannot comment on the code correctness. The end result looks like very good progress, though.

Thu, May 30, 1:40 AM · efl
segfaultxavi added a comment to D8887: evas: add 'clipper_is_static' property for canvas objects.

It is indeed confusing having vars named is_static_clip and clipper_is_static in two different structures (_Evas_Object_Protected_Data and _Evas_Object_Protected_State).

Thu, May 30, 1:19 AM · efl: rendering

Wed, May 29

segfaultxavi resigned from D8756: ecore: add simple test for property_string_add..

You are right, I misread the docs. No further comments, documentation-wise :)

Wed, May 29, 11:00 AM · efl
segfaultxavi requested review of D9044: Efl.Ui.Active_View: Update Docs.
Wed, May 29, 8:35 AM · efl
segfaultxavi added a child revision for D8784: efl_ui_active_view: introduce a experimental new widget: D9044: Efl.Ui.Active_View: Update Docs.
Wed, May 29, 8:35 AM · efl
segfaultxavi requested changes to D9034: efl_ui: rename list empty item to list placeholder item..

Please note that "placeholder", as a single word, is the most common spelling in English and therefore you should not separate it anywhere, including file names (place_holder, Place_Holder, PLACE_HOLDER).

Wed, May 29, 5:02 AM · efl

Tue, May 28

segfaultxavi resigned from D8784: efl_ui_active_view: introduce a experimental new widget.

I agree this patch must be unblocked. Don't forget to review the code, though!

Tue, May 28, 10:55 AM · efl
segfaultxavi resigned from D9018: efl_ui_check: make it undependend of nstate.

Since this is a temporary solution while radio buttons are being re-thought, there's not much point in reviewing these docs too much. They are fine with me now.

Tue, May 28, 4:07 AM · efl
segfaultxavi added a comment to D9017: efl_gesture: Delete prefix efl_canvas_gesture -> efl_gesture..

If this is independent from the canvas, what do you think of moving it to Efl.Input ?

Tue, May 28, 3:24 AM · efl
segfaultxavi added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

I have submitted patch D9031 that allows parts to have the same name as methods.
@SanghyeonLee You can now update this patch to use the simpler part names.

Tue, May 28, 1:16 AM · efl
segfaultxavi requested review of D9031: eolian: allow parts named like methods.
Tue, May 28, 1:13 AM · efl

Mon, May 27

segfaultxavi added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

I liked Pager from the beginning, but there's a widget already called like that. What would you call the current Pager widget?

Mon, May 27, 11:15 PM · efl
segfaultxavi added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

Currently the bindings add a Part suffix: a part named color generates a C# property named ColorPart.
This should only produce a conflict if you had a property named color_part, which would be very strange.
The same problem exists if you have a property named changed_evt for example...

Mon, May 27, 10:17 PM · efl
segfaultxavi added a comment to T7867: efl.ui.radio.

I like it. Simple case: you instantiate a radio box and add radio buttons. Complex case, you instantiate a radio logical_group and register radio buttons to it, remembering to also add the radio buttons to the ui wherever you want.

Mon, May 27, 8:09 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

I admit I share @cedric's concerns regarding the name View, because of the whole MVVM topic, and because we already have other "Views" in the tree (like Efl.Gfx.View).

Mon, May 27, 6:45 AM · efl
segfaultxavi requested changes to D8756: ecore: add simple test for property_string_add..

Hmmmm... in the docs we say that not_ready and on_error do not accept placeholder tags, but you are using them in the tests. Why?

Mon, May 27, 3:39 AM · efl
segfaultxavi resigned from D8755: ecore: add simple logic to generate synthetic string property assembling value of other properties..

I have no further concerns regarding the docs. Somebody with knowledge of these internals should review them, though.

Mon, May 27, 3:36 AM · efl
segfaultxavi added a comment to T7867: efl.ui.radio.

I like how this simplifies creating radio groups, since you now provide the Efl.Ui.Box automatically.

Mon, May 27, 3:30 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D8950: efl_ui_format: do not print errors on weird-but-valid cases.

Sorry, I still do not understand. The %% sequence will be detected by line 38 and won't make it to line 75 where the comment is. Any char after a % other than a second % or the format elements in the list IS an error and should be reported. What am I missing?

Mon, May 27, 2:10 AM · efl
segfaultxavi added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

the conflict is detected when validate the part name of class property hash.
I think this check is still valid thing, somehow, as property could use "part_" prefix though we have to avoid these prefix.
so instead of adding prefix in c# binding only,
what about adding prefix in eolian part->base.name directly, when it store the stringshare?

Mon, May 27, 1:58 AM · efl
segfaultxavi added a comment to D9018: efl_ui_check: make it undependend of nstate.

Also, I have serious troubles understanding this sentence :D

check can only display 2 states, and this widget will always only display three of them.

Mon, May 27, 1:46 AM · efl
segfaultxavi requested changes to D9018: efl_ui_check: make it undependend of nstate.
Mon, May 27, 1:45 AM · efl
segfaultxavi added a comment to D9027: autotools: REMOVAL!.

Mon, May 27, 1:14 AM · DO NOT MERGE, efl
segfaultxavi closed T7925: enum Efl.Flip as Resolved.

Yeah, this disappeared with D8912.

Mon, May 27, 1:03 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi closed T7925: enum Efl.Flip, a subtask of T7878: efl.orientation, as Resolved.
Mon, May 27, 1:03 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi requested changes to D9017: efl_gesture: Delete prefix efl_canvas_gesture -> efl_gesture..

@CHAN Why do you think Efl.Canvas.Gesture does not need the Canvas prefix? Gestures seem related to the Canvas to me.

Mon, May 27, 1:00 AM · efl

Fri, May 24

segfaultxavi requested changes to D8784: efl_ui_active_view: introduce a experimental new widget.

Fails to build for me because of implicit declaration of function ‘ck_assert_double_eq’ (Old version of libcheck, as usual).

Fri, May 24, 4:46 AM · efl
segfaultxavi requested changes to D8950: efl_ui_format: do not print errors on weird-but-valid cases.

I do not understand what are you trying to fix here. Can you give an example of a "weird but valid" format string which should not be an error?
some string (maybe more string%) DOES look like an error to me: if the purpose was to have an actual % at the end, it should be doubled.

Fri, May 24, 1:35 AM · efl
segfaultxavi accepted D8949: efl_canvas_layout: permit part_type_get on invalid parts.

Agreed.

Fri, May 24, 12:00 AM · efl

Thu, May 23

segfaultxavi accepted D8947: ecore/timer: fix handling of timer freeze during construction.
Thu, May 23, 12:54 PM · efl
segfaultxavi requested review of D8946: Rename Efl.Ui.Direction -> Efl.Ui.Layout_Orientation.
Thu, May 23, 10:51 AM · efl