- User Since
- Oct 11 2017, 3:04 AM (31 w, 5 d)
Fri, May 18
Rebased to master after removing callback,add and del events.
This makes the C# tests pass again after I removed the callback,add and callback,del events.
Thu, May 17
So, to make sure I understood everything. The Evas_Vg API should be available to everyone, without defining any special symbol, but it is currently behind EFL_BETA_API_SUPPORT. This is wrong and must be fixed.
Wed, May 16
Trying to fix weird patch screwup
Changed uint8 to ubyte as per comment.
Tue, May 15
Well, if my reviewers are busy and want me to land this, just shout here 😃
Sorry, I am unfamiliar with the procedure. Now that the review has been accepted, who is responsible for landing it on master?
Mon, May 14
Fri, May 11
OK, I need to get up to speed on a lot of things then.
Still don't understand the problem, though. Is it just a matter of documenting these methods correctly? Should we go through every API entry point and make sure the docs have the right tags? What are the available tags?
I... understand you want me to do it? 😃
I need to understand how those tags work then. How is an API marked as not public, or not stable, or whatever?
They were workarounds that will now be generated by this commit.
I am not familiar enough with the C# generator to make detailed comments, so they will be generic.
Thu, May 10
Mon, May 7
In case you are wondering what difference does it make to the tutorials, here's the updated Introduction to EO:
And this is the current one:
Fri, May 4
As a first step to detect all eo files which are currently not advertising the type of the event info, I propose Eolian makes specifying the event type mandatory. Events which really do not send any info can use void as the type.
In this way, all type-less events will be highlighted as errors by Eolian and must be fixed.
Wed, May 2
Be careful with namespace and symbol clashes. This currently breaks the bindings, and in the future Eolian will reject such symbols.
Tue, May 1
Fri, Apr 27
The issue is still present, but I've provided another fix, pending review.
Thu, Apr 26
Wed, Apr 25
@Jaehyun_Cho I think the problem is in the C# bindings generator:
Tue, Apr 24
OK, all Efl.Text-related commits have been squashed together to avoid noise (that was in my TODO too).
I also squashed some other commit pairs (Efl.Gfx turned into Efl.Gfx.Object first and into Efl.Gfx.Entity afterwards. Similar thing for Efl.Image.Load -> Efl.Loadable_Image -> Efl.Image_Load_Controller).
I also added fixes for the new code that is being added every day, insisting in creating new name conflicts!
Mon, Apr 23
Apr 19 2018
OK, since a better solution does not seem to crop up, I removed the "Container" suffix from Efl.Text and flattened the whole hierarchy.
Apr 17 2018
Good! I will implement these renames.
No new information. You suggested that we should just flatten, and I agree that it is the simplest solution, and it will work everywhere. I have implemented that in almost every case.
However, if we apply that unconditionally, we will be losing the opportunity to create a sensible hierarchy, which is handy for languages supporting namespaces. Hence, my effort to preserve a bit of hierarchy where I thought it made sense.
Allow me to explain my reasons for these changes, so we all have more background.
Apr 13 2018
Yep! Definitely. I like that.
Well, I've been doing my global checks with a shameful bash script so far, so the independent Eolian Static Analyzer would work for me. It would need to be incorporated into the build system, though, or people will just not use it.
As a side note, while I was working on this, two new clashes were introduced (and fixed). This will continue until Eolian errors out upon detecting a symbol clash. Has this work started, @q66? Is there anything I can do to help?
OK, I have renamed the clashing symbols in all the efl_*.eo files (and one elm_*.eo file).
Apr 12 2018
This is breaking make check for me because I do not have ENABLE_TIMING_INFO #defined.
@conr2d, is there a way for me to test your Vala bindings? I am already talking with @DaveMDS and @felipealmeida regarding the Python and C++ bindings, but I still don't have a mechanism to check if all these symbol renames are actually solving anything.
Apr 10 2018
Flattening the hierarchy works for me. Additionally, it is really the simplest of all options, since replacing a . with a _ only affects the eo files, not the C.
Apr 9 2018
(TL;DR section below)
Apr 7 2018
Being the last one to join this project I have no strong opinion either way.
I just wanted to remark that renaming Efl.Text to Efl.Text.Text_Iface changed the C API from efl_text_get () to efl_text_text_iface_text_get ().
Maybe some clever translation rules beyond the deduplication can be implemented.
Of course, being very strict when naming the classes will help these rules :)
Apr 6 2018
I was waiting for the others to comment first, but...
Apr 5 2018
Commit 568fc2ab304146c3f83cb9c6dc3dd4992f9daa82 has just fixed the same thing, although it does not update .gitignore.
Apr 4 2018
Apr 2 2018
Mar 30 2018
Jan 5 2018
Jan 4 2018
Jan 3 2018
Dec 21 2017
Dec 20 2017
Dec 19 2017
Dec 18 2017
Dec 14 2017
Dec 13 2017
Dec 12 2017
Dec 7 2017
Dec 6 2017
Dec 5 2017
Dec 4 2017
Dec 1 2017
Nov 29 2017
Good to know! Will add it to the programming and porting guides. Thanks!
Work started here: https://www.enlightenment.org/develop/guides/c/porting-guide