Page MenuHomePhabricator

segfaultxavi (Xavi Artigas)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 3:04 AM (52 w, 6 d)
Availability
Available

Recent Activity

Today

segfaultxavi triaged T7428: make check fails to build the CXX suite when both CXX and C# bindings are enabled as TODO priority.
Tue, Oct 16, 4:15 AM · Restricted Project, efl: language bindings
segfaultxavi closed D7164: eina_cxx: use efl_new instead of efl_add.
Tue, Oct 16, 4:08 AM · efl
segfaultxavi closed D7163: eolian_cxx: PACKAGE_DATA_DIR is completly wrong here.
Tue, Oct 16, 3:51 AM · efl
segfaultxavi accepted D7163: eolian_cxx: PACKAGE_DATA_DIR is completly wrong here.

I confirm nothing breaks with this change (testsuite still passing) and the change makes sense.

Tue, Oct 16, 3:51 AM · efl
segfaultxavi accepted D7164: eina_cxx: use efl_new instead of efl_add.

I confirm this patch removes a million errors from the console due to that NULL object. This did not affect the outcome of the test, though. This is indeed a weird test.

Tue, Oct 16, 3:47 AM · efl

Yesterday

segfaultxavi added a comment to D7158: eolian: Support generate legacy group names for enum, brief, etc.

@jsuya Remember that there is also the option to modify the manual group names. Some of them are inconsistent (do not have the _Group suffix, for example) so do not try to fix all legacy @ingroup tags from eolian. In some cases it might be easier to change the existing manual group names.

Mon, Oct 15, 3:08 AM · efl
segfaultxavi requested changes to D7115: ecore_evas: add braces to avoid compiler warning which is empty body in an if statement.

I agree with @Hermet, macros like this are very dangerous. It is better to simply define it as:

# define EINA_MAIN_LOOP_CHECK_RETURN_VAL(val) while(0) {}
Mon, Oct 15, 1:06 AM · efl

Tue, Oct 9

segfaultxavi closed D7148: eolian: use the legacy_prefix to generate the legacy doxygen group names.
Tue, Oct 9, 6:29 AM · efl
segfaultxavi added a comment to D7148: eolian: use the legacy_prefix to generate the legacy doxygen group names.

There is another issue. Look at the generated API docs:

void * 	ecore_timer_del (Ecore_Timer *timer);
void 	ecore_timer_interval_set (Efl_Loop_Timer *obj, double in);

The type of the parameter is different depending on whether the method comes from EO or has been manually defined.
It does not matter because they are both typedef'd to Eo, but it is very ugly.
I think it can be fixed using the same trick as with the @ingroups (using the legacy_prefix to generate the types too).

Tue, Oct 9, 3:22 AM · efl
segfaultxavi added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

To evaluate Option 2b, please check if D7148 fixes some of the missing methods in the documentation. If we apply that patch, manually fixing the rest of the inconsistent doxygen group names should be easier.

Tue, Oct 9, 3:20 AM · efl
segfaultxavi requested review of D7148: eolian: use the legacy_prefix to generate the legacy doxygen group names.
Tue, Oct 9, 3:14 AM · efl
segfaultxavi added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

@jsuya what do you think of the analysis above? Should we start implementing Option 2b or do you foresee any problem with it?

Tue, Oct 9, 1:58 AM · efl

Mon, Oct 8

segfaultxavi added a comment to T7425: MinSizeHint not taken into account until window is resized.

Maybe related to T6295?

Mon, Oct 8, 3:46 AM · efl: layout engine
segfaultxavi created T7425: MinSizeHint not taken into account until window is resized.
Mon, Oct 8, 3:43 AM · efl: layout engine

Fri, Oct 5

segfaultxavi added a comment to T7424: Study usage of DocFx to generate the C# API docs.

Installation on Linux is trivial, just download docfx.zip, unzip wherever you want (I used ~/docfx/) and add this little script somewhere in your path:

#!/bin/bash
mono ~/docfx/docfx.exe $@
Fri, Oct 5, 4:29 AM · efl: language bindings, efl: docs
segfaultxavi triaged T7424: Study usage of DocFx to generate the C# API docs as Normal priority.
Fri, Oct 5, 4:08 AM · efl: language bindings, efl: docs
segfaultxavi updated the task description for T7423: docs: Fix remaining Doxygen warnings.
Fri, Oct 5, 4:02 AM · efl: docs, Restricted Project
segfaultxavi triaged T7423: docs: Fix remaining Doxygen warnings as Normal priority.
Fri, Oct 5, 4:01 AM · efl: docs, Restricted Project
segfaultxavi closed T6130: Adapt tutorials, guides and examples to C#, a subtask of T6129: Convert tutorials, guides and examples to C#, as Resolved.
Fri, Oct 5, 3:29 AM · efl: language bindings, efl: docs
segfaultxavi closed T6130: Adapt tutorials, guides and examples to C# as Resolved.

All existing C example tutorials, guides and applications have been converted to C#. The addition of new examples will be tracked from the parent task.

Fri, Oct 5, 3:29 AM · Restricted Project, efl: docs
segfaultxavi added a comment to T6131: Introduction on how to get started with EFL C#.

Almost done! But still open because this could be made much nicer:

Fri, Oct 5, 3:26 AM · efl: language bindings, efl: docs
segfaultxavi added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

Hi @jsuya, please let me check that I understood the problem correctly:

Fri, Oct 5, 2:42 AM · efl

Thu, Oct 4

segfaultxavi closed D7134: efl-csharp: Fixing C# examples.
Thu, Oct 4, 10:16 AM · efl
segfaultxavi accepted D7134: efl-csharp: Fixing C# examples.
Thu, Oct 4, 10:14 AM · efl
This is a test notification, sent at Thu, Oct 4, 4:05 PM.
Thu, Oct 4, 7:05 AM
This is a test notification, sent at Thu, Oct 4, 4:03 PM.
Thu, Oct 4, 7:03 AM
segfaultxavi added a comment to T7356: EO: Support elm_config APIs.

On a second thought... won't the enum be enough? The string can be autogenerated from the enum key quite easily:

Thu, Oct 4, 6:44 AM · efl, Restricted Project
segfaultxavi added a comment to D7134: efl-csharp: Fixing C# examples.

I confirm this fixes the examples for me. Just remove that comment.

Thu, Oct 4, 1:21 AM · efl
segfaultxavi closed D7135: csharp: Temporarily disable missing docs warning.
Thu, Oct 4, 1:09 AM · efl
segfaultxavi added a comment to D7135: csharp: Temporarily disable missing docs warning.

Still some missing XML docs warning in the non-autogenerated files, though.

Thu, Oct 4, 1:08 AM · efl
segfaultxavi accepted D7135: csharp: Temporarily disable missing docs warning.

I agree these warnings are extremely noisy. I fear after silencing them we forget about this problem, but it is being tracked already in T7180.

Thu, Oct 4, 12:57 AM · efl
segfaultxavi added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

D7138 adds a new check for mangled docs, that is OK, but this commit still does TWO different things, which is not OK.
However, I understand in this code the parsing of the tags and the check for mangled docs was done simultaneously, so it is not easy to separate.

Thu, Oct 4, 12:35 AM · efl

Wed, Oct 3

segfaultxavi added inline comments to D7134: efl-csharp: Fixing C# examples.
Wed, Oct 3, 10:23 PM · efl
segfaultxavi added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I have been talking with @bu5hm4n for a long time this morning and I learnt a lot about how is EO supposed to work.

Wed, Oct 3, 4:26 AM · efl: language bindings, Restricted Project

Tue, Oct 2

segfaultxavi added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

Title was OK (except the typo). I just wanted to make sure I understood.

Tue, Oct 2, 1:34 AM · efl
segfaultxavi added a comment to D7119: evas filter: remove critical messages from Evas Filter.

This is very weird. So Evas buffers can have a parent, or not, depending on the backend? This looks like a very convoluted design. I would review carefully that this is indeed the case before committing, otherwise this patch can hide a serious design problem.

Tue, Oct 2, 1:16 AM · efl
segfaultxavi added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

It is unclear to me what this commit does. By reading the code, it looks like you are introducing a new keyword to Eolian named @ingroup. Is that true? Please make it clearer, because there is confusion with the Doxygen ingroup.

Tue, Oct 2, 1:10 AM · efl

Mon, Oct 1

segfaultxavi updated the task description for T7364: efl-mono: Object gets deleted after a while even though it has an EFL parent.
Mon, Oct 1, 6:54 AM · efl: language bindings

Fri, Sep 28

segfaultxavi added a comment to T7417: elm: EFL_UI_TEXT_EVENT_CHANGED for the BACKSPACE key emitted too early.

Posible duplicate of T6978?

Fri, Sep 28, 9:46 AM · efl: widgets
segfaultxavi updated the task description for T7418: efl-mono: Removing widgets leaves app in unstable state.
Fri, Sep 28, 9:33 AM · efl: language bindings
segfaultxavi added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I'm not sure removing Mixin from inheritance tree helps in anyway.

Let's say we create class A (everything in Eolian) and it inherits from Mixin M and regular class B.

Now, Mixin M inherits from regular class C too. If we remove Mixin, we still need to inherit
form both B and C in A, which is still a multi-inheritance problem.

Regards,

Fri, Sep 28, 4:40 AM · efl: language bindings, Restricted Project
segfaultxavi added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I just put together a small lua script that produces a diagram of the inheritance tree of any class: P236

Fri, Sep 28, 4:17 AM · efl: language bindings, Restricted Project

Thu, Sep 27

segfaultxavi updated the task description for T7418: efl-mono: Removing widgets leaves app in unstable state.
Thu, Sep 27, 8:00 AM · efl: language bindings
segfaultxavi triaged T7418: efl-mono: Removing widgets leaves app in unstable state as Normal priority.
Thu, Sep 27, 7:57 AM · efl: language bindings
segfaultxavi triaged T7417: elm: EFL_UI_TEXT_EVENT_CHANGED for the BACKSPACE key emitted too early as Normal priority.
Thu, Sep 27, 4:32 AM · efl: widgets
segfaultxavi added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

@Jaehyun_Cho OK, now I understand. I thought you were talking about the user's perspective but you have been talking about the C# bindings implementation all the time. Thanks for clearing up the misunderstanding.

Thu, Sep 27, 2:34 AM · efl: language bindings, Restricted Project
segfaultxavi closed D7117: ecore_con: Add docs for ecore_con legacy functions.
Thu, Sep 27, 2:30 AM · efl
segfaultxavi accepted D7117: ecore_con: Add docs for ecore_con legacy functions.
Thu, Sep 27, 2:30 AM · efl
segfaultxavi closed D7118: ecore_timer: Add docs for ecore_timer legacy functions.
Thu, Sep 27, 2:14 AM · efl
segfaultxavi accepted D7118: ecore_timer: Add docs for ecore_timer legacy functions.
Thu, Sep 27, 2:12 AM · efl

Wed, Sep 26

segfaultxavi added a comment to D7113: efl_ui_list: fix wrong variable usage.
Wed, Sep 26, 10:31 PM · efl
segfaultxavi added a comment to D7114: elm_interface_scrollable: fix using wrong variable..

Please put more information on your commit messages. The fix is obvious, but does this fix any known bug? Was there any observable problem before the fix?

Wed, Sep 26, 10:30 PM · efl
segfaultxavi added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

Sorry, but I still don't understand why a C# user would want to call to/from C, or inherit from a mixin.

Wed, Sep 26, 7:59 AM · efl: language bindings, Restricted Project
segfaultxavi added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

Sure, sure, I understand that.

Wed, Sep 26, 6:00 AM · efl: language bindings, Restricted Project
segfaultxavi added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I do not understand why do you want to call C functions from C#. That is the bindings job and Felipe will take care of it, right? Your C# app or your C# widgets should only use C# methods. What am I missing?

Wed, Sep 26, 2:05 AM · efl: language bindings, Restricted Project
segfaultxavi added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I think what @felipealmeida is suggesting is to remove the mixin classes completely from the C# bindings. Nothing would change in C land.

Wed, Sep 26, 12:48 AM · efl: language bindings, Restricted Project
segfaultxavi closed D7071: docs: Fix Efl.Ui.Focus.Object.Focus() docs.
Wed, Sep 26, 12:22 AM · efl

Tue, Sep 25

segfaultxavi added a reviewer for D7071: docs: Fix Efl.Ui.Focus.Object.Focus() docs: bryceharrington.
Tue, Sep 25, 7:31 AM · efl
segfaultxavi added a comment to D7106: efl-csharp: Fix event struct marshalling..

Fixes my problems with the Text Editor example app.

Tue, Sep 25, 7:28 AM · efl
segfaultxavi added a comment to T7334: Create C# syntax to allow using registering and emiting events defined in other classes.

Will this solve the current problem where equally-named events in different parts of the hierarchy hide each other?

Tue, Sep 25, 1:44 AM · efl (efl-1.22)

Thu, Sep 20

segfaultxavi updated the task description for T6129: Convert tutorials, guides and examples to C#.
Thu, Sep 20, 8:10 AM · efl: language bindings, efl: docs

Wed, Sep 19

segfaultxavi updated the task description for T6129: Convert tutorials, guides and examples to C#.
Wed, Sep 19, 4:08 AM · efl: language bindings, efl: docs
segfaultxavi requested review of D7071: docs: Fix Efl.Ui.Focus.Object.Focus() docs.
Wed, Sep 19, 3:21 AM · efl
segfaultxavi added a comment to D7013: evas vg: changed "vg object" to "vg".

I agree there is no consistency, and this is bad.
When the previous big rename was done (T6847) the goal was just to fix the object/namespace collisions so work on bindings could continue.
We knew then that the hierarchy after the rename was inconsistent and would need to be fixed later on.

Wed, Sep 19, 1:29 AM · efl
segfaultxavi triaged T7408: Fix consistency of the Interfaces Hierarchy as TODO priority.
Wed, Sep 19, 1:27 AM · Restricted Project, efl, Restricted Project
segfaultxavi closed T6847: Fix class and namespace name collisions as Resolved.
Wed, Sep 19, 1:16 AM · efl: language bindings, Restricted Project
segfaultxavi closed T6847: Fix class and namespace name collisions, a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Wed, Sep 19, 1:16 AM · Restricted Project, efl, Restricted Project
segfaultxavi renamed T6847: Fix class and namespace name collisions from Rationalize class and namespace names to Fix class and namespace name collisions.
Wed, Sep 19, 1:15 AM · efl: language bindings, Restricted Project
segfaultxavi accepted D7058: eina: Grammar improvements.
Wed, Sep 19, 12:59 AM · efl

Tue, Sep 18

segfaultxavi triaged T7407: efl-mono: Crash on focus callback when quitting focus example as TODO priority.
Tue, Sep 18, 2:28 AM · Restricted Project, efl: language bindings
segfaultxavi updated the task description for T6129: Convert tutorials, guides and examples to C#.
Tue, Sep 18, 12:52 AM · efl: language bindings, efl: docs
segfaultxavi added a comment to D7013: evas vg: changed "vg object" to "vg".

efl_canvas_animation_alpha.eo efl_canvas_animation_group_parallel.eo efl_canvas_animation_rotate.eo
efl_canvas_animation.eo efl_canvas_animation_group_sequential.eo efl_canvas_animation_scale.eo
efl_canvas_animation_group.eo efl_canvas_animation_player.eo efl_canvas_animation_translate.eo

efl_canvas_animation ?
class Efl.Canvas.Animation (Efl.Object, Efl.Playable)

Tue, Sep 18, 12:28 AM · efl

Mon, Sep 17

segfaultxavi updated the task description for T6129: Convert tutorials, guides and examples to C#.
Mon, Sep 17, 7:28 AM · efl: language bindings, efl: docs
segfaultxavi added a comment to D7012: here comes meson.

It is worth saying, though, that with autotools my default install dir was /usr/local/lib and now it changed to /usr/local/lib/x86_64-linux-gnu, so I ended up with a dual installation and a very confused pkg-config.

Mon, Sep 17, 7:24 AM · efl
segfaultxavi added a comment to D7012: here comes meson.

I verified it configures (after I installed libxkb-dev, libinput-dev and libgbm-dev and used -Davahi=false) and it builds blazingly fast (albeit with many warnings, log here: P234).
It ninja installed in mere seconds.
I then randomly checked some elementary_tests and everything worked fine (just the regular hundreds of console warnings).

Mon, Sep 17, 4:27 AM · efl
segfaultxavi updated the task description for T6129: Convert tutorials, guides and examples to C#.
Mon, Sep 17, 3:21 AM · efl: language bindings, efl: docs
segfaultxavi triaged T7403: efl-mono: Complete support of Hash values in eina.Value as TODO priority.
Mon, Sep 17, 3:04 AM · efl: language bindings
segfaultxavi triaged T7402: efl-mono: Implement Insert() in eina.Value as Wishlist priority.
Mon, Sep 17, 2:49 AM · efl: language bindings
segfaultxavi triaged T7401: efl-mono: Implement Remove() method in eina.List, eina.Array and eina.Value as Wishlist priority.
Mon, Sep 17, 2:47 AM · efl: language bindings
segfaultxavi triaged T7400: efl-mono: Add enumeration support for container eina values as Wishlist priority.
Mon, Sep 17, 2:35 AM · efl: language bindings
segfaultxavi added a comment to D7013: evas vg: changed "vg object" to "vg".

If you say so, guess efl_canvas_animation have same problem in binding.

Mon, Sep 17, 1:21 AM · efl
segfaultxavi triaged T7399: eolian: Add @ctor_param hint to constructors section as TODO priority.
Mon, Sep 17, 1:00 AM · efl: language bindings

Sep 13 2018

segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

OK, we were saying the same thing then 😄
The idea is that all widgets inheriting from Efl.Ui.Widget will have the extra style constructor parameter.

Sep 13 2018, 12:46 AM · efl
segfaultxavi added a comment to T7204: Discussion about C# binding syntax.

Nice to see that this is progressing! Good work!

Sep 13 2018, 12:34 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi added a comment to D7013: evas vg: changed "vg object" to "vg".

I would abandon it, yes, but I was waiting to see if @Hermet agrees with my review.

Sep 13 2018, 12:20 AM · efl
segfaultxavi updated subscribers of T7356: EO: Support elm_config APIs.

@q66 what do you think of @felipealmeida's proposal in the comment above?

Sep 13 2018, 12:18 AM · efl, Restricted Project

Sep 12 2018

segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

@lauromoura @felipealmeida:
Yes, @ctor_param would be a hint. C can ignore it. C# can use it to add extra constructor parameters.
I don't think the current docs are using the constructors {} information at all. At least I cannot see it:
https://www.enlightenment.org/develop/api/efl/model/container/item is generated from:

class Efl.Model_Container_Item (Efl.Object, Efl.Model) {
   methods {
      define { ... }
   }
   constructors {
       .define;
   }
}
Sep 12 2018, 3:40 AM · efl

Sep 11 2018

segfaultxavi added a comment to T6988: Study viability of removing EO files for legacy API.

I'd like to unearth this thread because the topic is important. We where discussing the possibility of completely removing EO files for legacy classes. It looks to me like everybody is in favor of making this move, but then the thread died when we discussed what would happen when new features needed to be added to legacy, because there is no beautiful way of doing that: A lot of EO boilerplate has to be done by hand.

Sep 11 2018, 8:06 AM · efl: language bindings
segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

How does the documentation use the constructors {} section?

Sep 11 2018, 7:08 AM · efl
segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

So your suggestion is exactly what I want! And it perfectly fulfills my purpose! :)

Sep 11 2018, 3:19 AM · efl
segfaultxavi triaged T7388: efl-mono: Make eina.Value.Set return "this" as TODO priority.
Sep 11 2018, 2:58 AM · efl: language bindings
segfaultxavi triaged T7387: efl-mono: remove eina.Value.Flush() as TODO priority.
Sep 11 2018, 2:49 AM · efl: language bindings
segfaultxavi accepted D7017: efl-csharp: Add copy constructor for eina.Value..

This is handy to have, and allows copying eina.Values by doing

var new_val = new eina.Value(old_val);
Sep 11 2018, 2:40 AM · efl
segfaultxavi updated subscribers of T7383: Efl.Config and Efl.Config_GLobal.

What I had in mind (An enum in C (or a list of #defines), and a list of static const strings in C#) would not provide type information. The SetConfig() method would be generic, as it is now:

public class efl.Config {
  static const string EFL_CONFIG_KEY_FINGER_SIZE = "finger_size";
  bool SetConfig(System.String name, eina.Value value);
}
Sep 11 2018, 2:20 AM · efl (efl-1.22)

Sep 10 2018

segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

There's an option we have been discussing on IRC. Currently the EO format has a constructors { } section which is unused, and it is not clear what its purpose is.

Sep 10 2018, 8:54 AM · efl
segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

Well, I feel strongly opposed to give the style such importance when we already have a mechanism to configure widgets. I think this is a slippery slope and we will end up wanting to add more and more parameters to the constructors...

Sep 10 2018, 6:33 AM · efl
segfaultxavi updated subscribers of T7375: Support widget styles in C# bindings.

I agree the initialization method is very EFL-specific and a bit weird. Maybe the C# bindings can translate that into something else more C#-friendly.

Sep 10 2018, 4:42 AM · efl
segfaultxavi added a comment to T7383: Efl.Config and Efl.Config_GLobal.

Also, as discussed in T7356 (in this comment), it would be nice to have a list of valid config keys:

Sep 10 2018, 4:27 AM · efl (efl-1.22)
segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

Consequently, I think that if a style always exists in theme because it is publicly supported, then the style can be explicitly defined in the class as well.

Sep 10 2018, 3:24 AM · efl
segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

OK, I have done some research. There cannot be a hardcoded list of available styles, because that depends on the theme. Each .edc file can define any number of styles and EFL does not guarantee that any style will exists in ALL themes, except default.

Sep 10 2018, 2:22 AM · efl