Page MenuHomePhabricator

segfaultxavi (Xavi Artigas)Administrator
Research

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 3:04 AM (97 w, 11 h)
Roles
Administrator
Availability
Available

Recent Activity

Yesterday

segfaultxavi added a comment to D9577: eolian-mono: Add support for multi-value properties with tuples.

Cool, everything looks fine on the docfx side. Thanks for the screenshots, I'm away from my work computer :)

Tue, Aug 20, 2:58 PM · efl
segfaultxavi added a comment to D9577: eolian-mono: Add support for multi-value properties with tuples.

I didn't know tuples existed in C# so I cannot comment much.
However, anything to make usage of EFL under C# more natural sounds like a good idea to me. Multivalued eo properties did not generate C# properties before, so I see no harm in this patch.

Tue, Aug 20, 2:24 AM · efl

Mon, Aug 19

segfaultxavi added a comment to D9612: efl_ui_scrollbar_direction: replace with efl_ui_layout_orientation.
In D9612#178401, @zmike wrote:

This seems like a good patch; my only issue is that conceptually "orientation" and "direction" are different. Do we care about this?

Mon, Aug 19, 8:09 AM · efl

Sun, Aug 18

segfaultxavi added a comment to D9569: efl_canvas_text: rename to efl_canvas_text_canvas.

As @raster points out, it is the job of eolian_gen to take care of any language-specific quirks. For example, for C# we could add a C prefix to all classes just like we add I to interfaces (and Evt to events).
We initially played with upper-case for classes and lower-case for properties, and things like this, but it wasn't natural for C# (and impossible for Python on Windows).
At some point we started renaming classes and properties instead of letting each language eolian_gen handle language-specific problems (and I think T6847 was the initial culprit).

Sun, Aug 18, 2:03 PM · efl

Sat, Aug 17

segfaultxavi added a comment to D9582: efl_ui_default_item: remove item parts.

Ah, ok, copies of each other. I thought they had copies in Layout. Thx!

Sat, Aug 17, 1:58 AM · efl
segfaultxavi added a comment to D9604: efl: use a @static function so that binding can pick it up..

Docs are a bit convoluted, but I won't block this patch because of it. Most efl docs need a rewrite.

Sat, Aug 17, 1:41 AM · efl
segfaultxavi added a comment to D9601: efl_ui/list_view: prefer use of Efl unified API..

Commit message says nothing about efl_ui_list 😡

Sat, Aug 17, 1:15 AM · efl
segfaultxavi added a comment to D9582: efl_ui_default_item: remove item parts.

Just for my personal understanding, what is going on here?
I see that 3 item parts are being mapped onto 2 layout parts. Isn't there an overlap?

Sat, Aug 17, 12:46 AM · efl

Fri, Aug 16

segfaultxavi requested changes to D9586: efl_ui_position_manager: pass on information about group ids.

Enums need a doc for themselves, besides the doc for each individual value. Same thing for the structs. Why isn't this triggering build breaks???
Also, please always add a period at the end of sentences. Sometimes doc generators merge multiple sentences and they make no sense of there is no punctuation. I think I have not seen any period in efl_ui_position_manager_entity.eo...

Fri, Aug 16, 10:04 AM · efl
segfaultxavi added a comment to T8097: efl_ui_spin_button.

Ok ok :)

Fri, Aug 16, 12:24 AM · efl: api, efl (efl-1.23), efl: language bindings

Thu, Aug 15

segfaultxavi added a comment to T8097: efl_ui_spin_button.

My last comment! EnableDirectTextInput?

Thu, Aug 15, 11:48 PM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T8097: efl_ui_spin_button.

hmmmm... I don't like any of them, I am a horrible person :)

  • EditableText looks like this property should be text, not a boolean
  • TextEditable sounds weird in English
  • TextIsEditable sounds best to me, but we have nothing like this in the current API
  • Editable sounds like the opposite of Enabled
Thu, Aug 15, 9:35 AM · efl: api, efl (efl-1.23), efl: language bindings

Wed, Aug 14

segfaultxavi added a comment to D9569: efl_canvas_text: rename to efl_canvas_text_canvas.

I'll leave the technical details to the c# people, but I think it is a bit late in the day to change the c# bindings syntax now. Not impossible, though.
All name clashes were already solved a long time ago by renaming properties named like classes. Only these three remained (Key, Hold and Text) because they were in a blacklist in the c# generator and I forgot about them.

Wed, Aug 14, 11:22 PM · efl
segfaultxavi added a comment to D9569: efl_canvas_text: rename to efl_canvas_text_canvas.

Hmmmm... not that exotic, in those languages, a method named like the class is reserved for the constructor of the class, isn't it?

Wed, Aug 14, 10:24 PM · efl
segfaultxavi added a comment to D9569: efl_canvas_text: rename to efl_canvas_text_canvas.

They clash because c# will create a property named Text inside a class named Text, which is forbidden.

Wed, Aug 14, 2:52 PM · efl
segfaultxavi added a comment to T8097: efl_ui_spin_button.

I'm OK with wraparound but I really think editable_text is better than text_editable (adjective before noun).
Another option is text_is_editable.

Wed, Aug 14, 1:00 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi accepted D9551: efl/hint: add doc note about max size hint.

Macro doc_cop_approves:

Wed, Aug 14, 12:15 AM · efl
segfaultxavi accepted D9553: efl/hints: add restricted and combined max size hints.

Macro doc_cop_approves:

Wed, Aug 14, 12:11 AM · efl

Tue, Aug 13

segfaultxavi added a comment to D9552: efl_ui/win: add doc note that this class does not obey size hints.

Any chance we can explain why this is so? Do we have at least an excuse?

Tue, Aug 13, 12:12 AM · efl
segfaultxavi requested changes to D9553: efl/hints: add restricted and combined max size hints.

Current c# generator ignore setter and getter docs when there's also a property doc. I would move or remove the setter and getter docs.

Tue, Aug 13, 12:12 AM · efl

Mon, Aug 12

segfaultxavi requested changes to D9551: efl/hint: add doc note about max size hint.

What are the (user) hints?
Maybe using links like @.hint_size_min helps understanding this class a bit.
There's a tutorial planned for this.

Mon, Aug 12, 11:58 PM · efl
segfaultxavi added a comment to D9543: edje/style: Remove redundant style tags from style text..

someone please update this cryptic comment
/* Add font name last to save evas from multiple loads */
how this is going to help saving multiple load.

Mon, Aug 12, 1:03 AM · efl

Fri, Aug 9

segfaultxavi added a comment to D9530: edje: fix warning for returning wrong type..

What?! Those two types exist??? /o\

Fri, Aug 9, 1:36 AM · efl
segfaultxavi added inline comments to D9527: elementary: add support for widget part property bind..
Fri, Aug 9, 1:33 AM · efl

Wed, Aug 7

segfaultxavi added a comment to T8105: Eolian inheritance warnings.

It might be worth printing a warning, in case the multiple inheritance was unintentional...

Wed, Aug 7, 5:14 AM · Restricted Project
segfaultxavi added a comment to T8107: Inheritance information in the header documentation.

Where do you mean? The .eo.h files? I think the DocFX pages do have that info. The C reference pages were generated 2 years ago and are a bit forgotten...

Wed, Aug 7, 5:11 AM · Restricted Project
segfaultxavi added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

Sorry, I don't understand what you mean :/

Wed, Aug 7, 1:16 AM · efl: api, efl (efl-1.23), efl: language bindings

Tue, Aug 6

segfaultxavi added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

This selectes whether the scrollbar appears at the bottom or at the side of the scroller, but also whether the scrollbar is horizontal or vertical, no? I think it is very related to orientation.
Now that D9299 has landed the idea from T7924#137454 (above) can be implemented, I think.

Tue, Aug 6, 7:45 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi accepted D9487: docs: Improve Efl.Input.Key docs.

Thx!

Tue, Aug 6, 1:19 AM · efl

Mon, Aug 5

segfaultxavi resigned from D9491: evas_convert: implement convert to binary image (1bpp).

OK, I should not be doing reviews while on holidays :)

Mon, Aug 5, 12:28 PM · efl
segfaultxavi added a comment to D9491: evas_convert: implement convert to binary image (1bpp).

@segfaultxavi Why do you think r * 76 causes overflow ?

Mon, Aug 5, 12:17 PM · efl
segfaultxavi accepted D9483: efl_input_key: replace key property name with key_sym.

Thanks!

Mon, Aug 5, 12:13 AM · efl
segfaultxavi requested changes to D9491: evas_convert: implement convert to binary image (1bpp).

r * 76 causes overflow.
Test case is very poor, and it should be a unit case, testing far more cases. Ideally a whole ramp.
EINA_UNUSED vars are actually used.

Mon, Aug 5, 12:10 AM · efl

Sat, Aug 3

segfaultxavi accepted D9475: efl_ui_spin: move the step implementation to spin_button.

Nice!

Sat, Aug 3, 11:21 AM · efl

Fri, Aug 2

segfaultxavi added a comment to T7873: efl.ui.image.
  • scalable: hmmm.. there's a weird relationship there, since the docs say if $false, the internal image is not scaled up no matter what the scale type is.. So these two booleans seem to go further than the scale_type in Efl.Gfx.Image. Not sure if the implementation supports it, though.
  • align: yeah, Efl.Gfx.Arrangement controls the alignment of the content inside the container so it fits nicely here. It also has a padding property that wouldn't be used.
  • drop: it should go away, sure. We already have @beta events, but I am not sure how the mono docs react to them.
Fri, Aug 2, 9:55 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D9487: docs: Improve Efl.Input.Key docs.

Sure, yeah, feel free to commandeer :)

Fri, Aug 2, 9:42 AM · efl
segfaultxavi added a comment to D9483: efl_input_key: replace key property name with key_sym.

key_sym, for consistency.

Fri, Aug 2, 8:02 AM · efl
segfaultxavi added a comment to T7976: Efl.Input.Clickable_Clicked.

Strictly speaking.... yeah, I guess so /o\

Fri, Aug 2, 7:59 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D9486: efl_ui_action_connector: rename clickable_util to action_connector.

But there's bind_to_theme and bind_to_object methods. What would you do with the object ones?

Fri, Aug 2, 6:53 AM · efl
segfaultxavi added a comment to D9487: docs: Improve Efl.Input.Key docs.

This patch will need rebasing if we decide a new name for input_key in D9483.
Feel free to commandeer this patch, rebase and land it, since I might not be available in the following weeks.

Fri, Aug 2, 3:28 AM · efl
segfaultxavi requested review of D9487: docs: Improve Efl.Input.Key docs.
Fri, Aug 2, 3:24 AM · efl
segfaultxavi added a child revision for D9483: efl_input_key: replace key property name with key_sym: D9487: docs: Improve Efl.Input.Key docs.
Fri, Aug 2, 3:24 AM · efl
segfaultxavi closed D9485: efl_input_clickable: increase the time interval for repeated counter.
Fri, Aug 2, 1:50 AM · efl
segfaultxavi added a comment to D9485: efl_input_clickable: increase the time interval for repeated counter.

Nice :)

Fri, Aug 2, 1:39 AM · efl
segfaultxavi accepted D9484: efl_input_hold: replace hold property name with input_hold.

I see no problem here (besides the class being already stable).

Fri, Aug 2, 1:38 AM · efl
segfaultxavi requested changes to D9483: efl_input_key: replace key property name with key_sym.

We did not discuss which name to use to replace key. For consistency, if we use the input_ prefix for this property, we should use it for all other properties in this class. This solution would not change the C API and therefore would not break compatibility, as @YOhoho pointed out.

Fri, Aug 2, 1:36 AM · efl
segfaultxavi added a comment to T7893: efl.ui.slider.

How would we do that? We make this release without user,changed events and add them afterwards? I'm OK with this but are these events required by any app right now?

Fri, Aug 2, 12:54 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7976: Efl.Input.Clickable_Clicked.

Explaining things is my job! :D

Fri, Aug 2, 12:18 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi accepted D9485: efl_input_clickable: increase the time interval for repeated counter.

Makes sense. Is there any information in the commit that introduced de 0.1s for the first time about why they choose such a low value?

Fri, Aug 2, 12:17 AM · efl

Thu, Aug 1

segfaultxavi closed D9481: csharp: Avoid generating empty <value> tags Depends on D9478.
Thu, Aug 1, 12:40 PM · efl
segfaultxavi closed D9482: csharp: Add a documentation_string generator.
Thu, Aug 1, 12:40 PM · efl
segfaultxavi closed D9478: mono-docs: Add misc struct docs.
Thu, Aug 1, 12:40 PM · efl
segfaultxavi accepted D9482: csharp: Add a documentation_string generator.

Works as expected.

Thu, Aug 1, 12:27 PM · efl
segfaultxavi accepted D9481: csharp: Avoid generating empty <value> tags Depends on D9478.
Thu, Aug 1, 12:26 PM · efl
segfaultxavi requested review of D9478: mono-docs: Add misc struct docs.

Works well after the next two patches :P

Thu, Aug 1, 12:16 PM · efl
segfaultxavi planned changes to D9478: mono-docs: Add misc struct docs.
Thu, Aug 1, 8:12 AM · efl
segfaultxavi accepted D9473: efl_ui_spin_button: stop calling only the parent.

Curious. Why was that there in the first place?
Now I realize that the spin_button elm_test has never worked as intended :/

Thu, Aug 1, 7:23 AM · efl
segfaultxavi requested changes to D9475: efl_ui_spin: move the step implementation to spin_button.

Actually, this break the Efl.Ui.Spin elm_test, because it is calling efl_ui_range_step_get and _set on the spin in multiple places.

Thu, Aug 1, 7:21 AM · efl
segfaultxavi accepted D9475: efl_ui_spin: move the step implementation to spin_button.

Maketh sense, buildeth and paseth tests.

Thu, Aug 1, 7:15 AM · efl
segfaultxavi accepted D9474: efl_ui_spin_button: fix initial displaying of formatting string.

Aaahhhhhhh COOOOL, you used my new method! :D

Thu, Aug 1, 7:05 AM · efl
segfaultxavi added a comment to T7976: Efl.Input.Clickable_Clicked.

DOUBLE_CLICK_TIME is the time required for two consecutive clicks to be considered together.
After the second click, you have 0.1s to click again and get a triple click.
After the third click, you have 0.1s again to click a forth time, etc.

Thu, Aug 1, 6:58 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi requested review of D9478: mono-docs: Add misc struct docs.
Thu, Aug 1, 6:43 AM · efl
segfaultxavi added a comment to T7976: Efl.Input.Clickable_Clicked.

Is there a use case that developers use the value "repeated"?

There are some apps which use triple-clicking (like selecting a word with double-click, and a whole paragraph with triple-click).

Thu, Aug 1, 3:10 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T8100: widget style property.

I don't know yet how styles work, so here's my less than two-cents worth:

  • It seems obvious that the user should be able to change a widget's style. No? Or is that meant to be changed through other APIs, like set_layout_direction()?
  • style_set is meant to be called inside the constructor. How's the spinner cxx example supposed to work?
  • All C# widgets can change style at construction time through a constructor parameter. Does something similar exist for cxx?
  • As I recall, styles are free-form strings, defined by themes, widgets, extensions and whatnot. How are we gonna document that? Do we need a runtime tool that lists available styles?
Thu, Aug 1, 2:40 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to T7831: Improve image support in MVVM.

vpaths looks like a very convenient thing to have. We should also be consistent, so if we allow them in some APIs, we should allow them everywhere. This seems to be already the case, as @bu5hm4n said, right?

Thu, Aug 1, 2:23 AM · efl (efl-1.23), efl: mvvm, efl: data types

Wed, Jul 31

segfaultxavi accepted D9458: efl_ui_range_interactive: add a new event.

👍

Wed, Jul 31, 11:04 AM · efl
segfaultxavi added a comment to D9460: efl_ui_spec: add a test suite for the steady event.

Reason for this is that Spin is not interactive, even if it implements the interface for it. Maybe something we should resolve in future.

Wed, Jul 31, 9:46 AM · efl
segfaultxavi requested changes to D9458: efl_ui_range_interactive: add a new event.
Wed, Jul 31, 9:45 AM · efl
segfaultxavi accepted D9459: efl_ui_spin_button: use the newly emitted event from range_interactive.
Wed, Jul 31, 9:41 AM · efl
segfaultxavi accepted D9461: efl_ui_spin_button: rename circulate to wraparound.

The EO docs could use some love...

Wed, Jul 31, 9:37 AM · efl
segfaultxavi added a comment to T8093: Name conflict between class and property.

Other Issue :
For most systems TextEdit or TextBox/block are inherited from TextView (or have same functionality)

What is the issue?

Wed, Jul 31, 9:35 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7893: efl.ui.slider.

hmmm... in the radio case, which widget would perform this centralization? and which ones are emitting the selected and unselected events?

Wed, Jul 31, 8:12 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T8093: Name conflict between class and property.

Names containing the word View should be reserved for MVVM widgets. Otherwise it's going to be very confusing.
Other than that, I have no strong opinion. There cannot be name conflicts between Legacy and Unified APIs since they are in different namespaces.

Wed, Jul 31, 8:04 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T8097: efl_ui_spin_button.

We have all worked way too much on this widget now and we are all sick of it.
However...

Wed, Jul 31, 7:52 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7894: efl.ui.range_interactive.

I think steady only makes sense for user-generated movements.

Wed, Jul 31, 7:48 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated the task description for T7717: docs todo.
Wed, Jul 31, 7:46 AM · efl (efl-1.23), efl: docs, efl: api
segfaultxavi added a comment to T7895: efl.ui.range_display.

Yeah, I think so too.

Wed, Jul 31, 5:00 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated subscribers of T8093: Name conflict between class and property.

Thanks for a very detailed report!

Wed, Jul 31, 4:54 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated the task description for T7897: efl.ui.spin.
Wed, Jul 31, 4:00 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a commit to T7897: efl.ui.spin: rEFL359a118cdaa9: Efl.Ui.Spin: Remove mouse wheel interaction.
Wed, Jul 31, 3:44 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi closed D9453: Efl.Ui.Spin: Remove mouse wheel interaction.
Wed, Jul 31, 3:44 AM · efl
segfaultxavi requested review of D9453: Efl.Ui.Spin: Remove mouse wheel interaction.
Wed, Jul 31, 3:36 AM · efl
segfaultxavi added a revision to T7897: efl.ui.spin: D9453: Efl.Ui.Spin: Remove mouse wheel interaction.
Wed, Jul 31, 3:36 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi closed D8863: efl_pan: improve docs.
Wed, Jul 31, 1:50 AM · efl
segfaultxavi updated the diff for D8863: efl_pan: improve docs.

Fix meaning of min and max positions.

Wed, Jul 31, 1:28 AM · efl
segfaultxavi added a commit to T7895: efl.ui.range_display: rEFL14ff01060154: efl_ui_spec: add test suite for range_display events.
Wed, Jul 31, 1:24 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi closed D9372: efl_ui_*: add the new events to the widgets.
Wed, Jul 31, 1:19 AM · efl
segfaultxavi closed D9373: efl_ui_spec: add test suite for range_display events.
Wed, Jul 31, 1:19 AM · efl
segfaultxavi added a commit to T7895: efl.ui.range_display: rEFL8f7fa82244dd: efl_ui_*: add the new events to the widgets.
Wed, Jul 31, 1:19 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a commit to T7895: efl.ui.range_display: rEFLc0082b1c71ed: efl_ui_range_display: move events from spin.
Wed, Jul 31, 1:19 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a commit to T7897: efl.ui.spin: rEFLc0082b1c71ed: efl_ui_range_display: move events from spin.
Wed, Jul 31, 1:19 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi closed D9371: efl_ui_range_display: move events from spin.
Wed, Jul 31, 1:19 AM · efl
segfaultxavi accepted D9371: efl_ui_range_display: move events from spin.

Everything fine now!

Wed, Jul 31, 1:17 AM · efl

Tue, Jul 30

segfaultxavi added inline comments to D9437: efl_ui/layout_base: add "finger_size_multiplier" property.
Tue, Jul 30, 6:22 AM · efl: widgets
segfaultxavi resigned from D9434: efl_ui: change calls to elm_layout_sizing_eval to efl_canvas_group_change.

OK, I'm sold (you could have written that in the commit message to begin with). I won't be able to do a proper technical review, though.

Tue, Jul 30, 6:19 AM · efl: widgets
segfaultxavi requested changes to D9445: efl_ui_position_manager: move from accessor to function callback.
Tue, Jul 30, 4:27 AM · efl
segfaultxavi abandoned D9374: mono-docs: Expose @owned in C# documentation.
Tue, Jul 30, 4:14 AM · efl
segfaultxavi updated the diff for D8863: efl_pan: improve docs.

Second round!

Tue, Jul 30, 4:13 AM · efl
segfaultxavi commandeered D8863: efl_pan: improve docs.
Tue, Jul 30, 3:17 AM · efl
segfaultxavi added a comment to D8887: evas: add 'has_fixed_size' property for canvas objects.

ping?

Tue, Jul 30, 3:05 AM · efl: rendering