Page MenuHomePhabricator

shilpasingh (Shilpa Singh)
Engineer at Samsung

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 24 2013, 11:05 PM (329 w, 1 d)
Availability
Available

Email: shilpa.singh@samsung.com shilpasingh.o@gmail.com

Recent Activity

Apr 29 2019

shilpasingh closed D8686: elm_scroller: make loop_set/get as generic API.
Apr 29 2019, 12:11 AM · efl

Apr 28 2019

shilpasingh added a comment to D8686: elm_scroller: make loop_set/get as generic API.

I am wondering a bit about this revision. This is a legacy API, shouldn't something like this be used in the new scroller class ? Otherwise this feature will be gone and or unable to be used on new widgets.

Additionally, the definition of the actual header API is missing.

we already have a legacy API elm_scroller_loop_set but this API has not been implemented in a generic manner, that means I cannot call elm_scroller_loop_set on widgets like genlist, toolbar etc.
this change will make sure elm_scroller_loop_set becomes a generic API.
This API will work like policy_set, page_size_set, bounce_set APIs, these are not yet added as part of efl_ui_scroller.c

Legacy API itself is enhanced to be generic currently, in future when all the above legacy APIs are ported, then loop_set/get also will get ported but as a generic API
now calling elm_scroller_loop_set on say genlist will cause crash. Looping mechanism can be widget specific, every scrollable widget might implement its own looping mechanism like genlist then
a call elm_scroller_loop_set(genlist, ...); should work successfully.

Apr 28 2019, 11:51 PM · efl

Apr 25 2019

shilpasingh updated subscribers of D8686: elm_scroller: make loop_set/get as generic API.
Apr 25 2019, 5:59 AM · efl
shilpasingh added a comment to D8686: elm_scroller: make loop_set/get as generic API.

I am wondering a bit about this revision. This is a legacy API, shouldn't something like this be used in the new scroller class ? Otherwise this feature will be gone and or unable to be used on new widgets.

Additionally, the definition of the actual header API is missing.

Apr 25 2019, 5:57 AM · efl

Apr 23 2019

shilpasingh added reviewers for D8686: elm_scroller: make loop_set/get as generic API: zmike, eagleeye.
Apr 23 2019, 4:41 AM · efl
shilpasingh updated the diff for D8686: elm_scroller: make loop_set/get as generic API.

updated reviewer

Apr 23 2019, 4:39 AM · efl
shilpasingh requested review of D8686: elm_scroller: make loop_set/get as generic API.
Apr 23 2019, 4:32 AM · efl

Mar 25 2019

shilpasingh closed D8427: efl_access: add test cases for reading_info_type_set/get API.
Mar 25 2019, 2:42 AM · efl

Mar 24 2019

shilpasingh added a comment to D8427: efl_access: add test cases for reading_info_type_set/get API.

Uhhm, this is the same test just twice under a different function name... Is this a cnp error ?

Mar 24 2019, 11:55 PM · efl

Mar 21 2019

shilpasingh added a comment to D8427: efl_access: add test cases for reading_info_type_set/get API.

This test case patch will be updated based on status of
https://phab.enlightenment.org/D8435

Mar 21 2019, 4:42 AM · efl
shilpasingh updated the diff for D8435: efl_access: if 0 is set as reading_info_type, remove existing reading_info.

updated based on review comments

Mar 21 2019, 4:39 AM · efl
shilpasingh added a comment to D8427: efl_access: add test cases for reading_info_type_set/get API.

This test case patch will be updated based on status of
https://phab.enlightenment.org/D8435

Mar 21 2019, 1:44 AM · efl
shilpasingh requested review of D8435: efl_access: if 0 is set as reading_info_type, remove existing reading_info.
Mar 21 2019, 1:42 AM · efl

Mar 20 2019

shilpasingh added a comment to D8427: efl_access: add test cases for reading_info_type_set/get API.
In D8427#152237, @jsuya wrote:

HI, I recommend testing the initial value(maybe 0) in _type_set test , or change tests _type_set and _type_get to _type_set_get.

Mar 20 2019, 11:21 PM · efl
shilpasingh updated the diff for D8427: efl_access: add test cases for reading_info_type_set/get API.

Made changes in test cases, but retaining two different test cases for two different APIs
to maintain uniformity with other test cases

Mar 20 2019, 11:16 PM · efl
shilpasingh updated the diff for D8427: efl_access: add test cases for reading_info_type_set/get API.

formatting fixes

Mar 20 2019, 8:16 AM · efl
shilpasingh requested review of D8427: efl_access: add test cases for reading_info_type_set/get API.
Mar 20 2019, 8:10 AM · efl
shilpasingh accepted D8421: elm_gesture_layer: Use flag returned by gesture callbacks.
Mar 20 2019, 7:30 AM · efl
shilpasingh closed D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.
Mar 20 2019, 7:29 AM · efl
shilpasingh updated the diff for D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

warning fixes

Mar 20 2019, 7:16 AM · efl
shilpasingh updated the summary of D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.
Mar 20 2019, 4:05 AM · efl
shilpasingh added a comment to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

@shilpasingh is it not possible to add test case to efl/src/tests/elementary/efl_ui_test_atspi.c ?

Mar 20 2019, 4:01 AM · efl
shilpasingh added a comment to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

I would like to merge this soon. The test case could be added by separated patch set (@bu5hm4n)

Don't get me wrong, but history has proven that this does not happen in a lot of cases, i would like to have that in one patch.

I would be indeed happy just with a little testcase that adds a attribute removes a non-existing key and then removes the key that is added, and then checks the count. Nothing big, but something which can be ran automatically, so some refactoring or so do *not* breakthis accidently :)

Mar 20 2019, 4:00 AM · efl
shilpasingh updated the diff for D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

Added test cases for all access attribute APIs

Mar 20 2019, 3:58 AM · efl
shilpasingh added a comment to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

@bu5hm4n
Please refer below patches, this API is continuation to existing access APIs
https://phab.enlightenment.org/D5524
https://phab.enlightenment.org/D5510

Mar 20 2019, 12:21 AM · efl
shilpasingh updated the diff for D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

Added check for attr_list

Mar 20 2019, 12:05 AM · efl

Mar 18 2019

shilpasingh requested review of D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.
Mar 18 2019, 8:04 AM · efl

Nov 27 2017

shilpasingh accepted D5544: elm_entry : Added access action interface in entry..
Nov 27 2017, 7:27 AM

Nov 22 2017

shilpasingh created D5524: efl_access: Add reading_info_type set/get APIs.
Nov 22 2017, 6:19 AM

Nov 21 2017

shilpasingh updated the test plan for D5510: efl_access: Add attribute_append, attributes_clear APIs.
Nov 21 2017, 7:33 AM
shilpasingh accepted D5515: elm_genlist: Add signals to communicate drag start and stop to atspi client..
Nov 21 2017, 7:29 AM
shilpasingh added a reviewer for D5510: efl_access: Add attribute_append, attributes_clear APIs: lukasz.stanislawski.
Nov 21 2017, 1:38 AM
shilpasingh created D5510: efl_access: Add attribute_append, attributes_clear APIs.
Nov 21 2017, 1:28 AM

Nov 20 2017

shilpasingh added a comment to D5470: elm_entry: if cnp mode is PLAINTEXT, & do not get pasted.
Nov 20 2017, 6:03 AM · efl
shilpasingh updated the diff for D5470: elm_entry: if cnp mode is PLAINTEXT, & do not get pasted.

updated efl_ui_text.c

Nov 20 2017, 5:50 AM · efl

Nov 16 2017

shilpasingh added a comment to D5486: elm_index: Index item role modify.

Could not find any test case for index role check hence no changes in test cases

Nov 16 2017, 3:06 AM
shilpasingh created D5486: elm_index: Index item role modify.
Nov 16 2017, 3:05 AM
shilpasingh closed D5485: elm_index: Send selected signal to atspi client.
Nov 16 2017, 1:20 AM

Nov 15 2017

shilpasingh created D5485: elm_index: Send selected signal to atspi client.
Nov 15 2017, 11:03 PM

Nov 14 2017

shilpasingh accepted D5474: CtxPopup: Add implementation for getting focused item.
Nov 14 2017, 6:37 AM
shilpasingh updated the diff for D5469: efl_ui_win.c: send bounds changed signal on window rotation.

Fixed review comments, added x,y information as well.

Nov 14 2017, 5:23 AM
shilpasingh created D5470: elm_entry: if cnp mode is PLAINTEXT, & do not get pasted.
Nov 14 2017, 1:54 AM · efl
shilpasingh updated the diff for D5469: efl_ui_win.c: send bounds changed signal on window rotation.
  • removed EINA_UNUSED
Nov 14 2017, 1:18 AM
shilpasingh created D5469: efl_ui_win.c: send bounds changed signal on window rotation.
Nov 14 2017, 12:19 AM

Nov 13 2017

shilpasingh updated the test plan for D5466: elc_popup.c: name_get interface added to support default label feature.
Nov 13 2017, 7:26 AM
shilpasingh created D5466: elc_popup.c: name_get interface added to support default label feature.
Nov 13 2017, 7:10 AM
shilpasingh created D5463: elc_naviframe.c: Append title, subtitle while reading title and subtitle in naviframe..
Nov 13 2017, 3:19 AM

Sep 1 2017

shilpasingh accepted D5153: elm_spinner: Text button and entry both gets hidden when navigated through arrow keys..
Sep 1 2017, 3:55 AM · efl

Jul 24 2017

shilpasingh added a comment to D5035: evas: add a missing description for a newly added parameter.

Please add documentation for below function as well in evas_object_textblock.c
static int
_layout_text_cutoff_get(Ctxt *c, Evas_Object_Textblock_Format *fmt,

const Evas_Object_Textblock_Text_Item *ti, int width_offset)
Jul 24 2017, 11:01 PM

Jun 15 2017

shilpasingh added a comment to D4925: elc_multibuttonentry: Role of MBE item, MBE updated, and state_set_get API added..
In D4925#83533, @jpeg wrote:

I'll assume this atspi role change was intended. But next time please make sure make check still works!

Jun 15 2017, 11:28 PM

Jun 13 2017

shilpasingh created D4960: elm_radio, elc_multibuttonentry, elm_colorselector: "checked" signal sent.
Jun 13 2017, 7:56 AM

Jun 5 2017

shilpasingh retitled D4925: elc_multibuttonentry: Role of MBE item, MBE updated, and state_set_get API added. from elc_multibuttonentry: Improve ATSPI support to elc_multibuttonentry: Role of MBE item, MBE updated, and state_set_get API added..
Jun 5 2017, 12:21 AM

Jun 2 2017

shilpasingh created D4934: elm_colorselector: Improve ATSPI support.
Jun 2 2017, 7:13 AM

May 30 2017

shilpasingh created D4925: elc_multibuttonentry: Role of MBE item, MBE updated, and state_set_get API added..
May 30 2017, 8:12 AM

May 29 2017

shilpasingh added a reviewer for D4916: elm_config: Password mode change should reflect on already running applications.: thiepha.
May 29 2017, 11:13 PM

May 26 2017

shilpasingh created D4916: elm_config: Password mode change should reflect on already running applications..
May 26 2017, 7:02 AM

May 12 2017

shilpasingh closed D4862: elm_entry: Cursor disappears on calling select function in an empty entry. by committing rEFL442ab2bc6741: elm_entry: Cursor disappears on calling select function in an empty entry. (authored by shilpasingh).
May 12 2017, 12:33 AM

May 9 2017

shilpasingh created D4862: elm_entry: Cursor disappears on calling select function in an empty entry..
May 9 2017, 8:48 AM
shilpasingh accepted D4847: eina_str: fix for escapable charachters not getting escaped if it comes after '\t' or '\n'.

Also fixes Invalid read

16673== Invalid read of size 1

16673== at 0x4E723C7: eina_str_escape (in /usr/local/efl-dev/lib/libeina.

so.1.19.99)

16673== by 0x400EC9: main (in /home/prasoon.16/op_source/efl/src/examples

/eina/eina_str_01)

16673== Address 0x5db52e4 is 0 bytes after a block of size 4 alloc'd

16673== at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-

amd64-linux.so)

16673== by 0x400EAF: main (in /home/prasoon.16/op_source/efl/src/examples

/eina/eina_str_01)

16673

May 9 2017, 7:41 AM

Dec 13 2016

shilpasingh updated the diff for D4483: elc_naviframe: Delete naviframe items in LIFO manner on widget deletion..

if sd->stack is NULL, do not deref sd->stack

Dec 13 2016, 3:31 AM
shilpasingh added reviewers for D4483: elc_naviframe: Delete naviframe items in LIFO manner on widget deletion.: Jaehyun_Cho, Jaehyun.
Dec 13 2016, 1:04 AM
shilpasingh retitled D4483: elc_naviframe: Delete naviframe items in LIFO manner on widget deletion. from to elc_naviframe: Delete naviframe items in LIFO manner on widget deletion..
Dec 13 2016, 1:03 AM

Nov 21 2016

shilpasingh added a comment to D4414: elm_colorselector: Palette Box made center aligned.

I agree with your point.. but should we have an API? how about we add a data item in edc? because this is more of a UI dependent issue rather than functionality.. Just asking your opinion

Nov 21 2016, 12:30 AM · efl

Nov 18 2016

shilpasingh added a comment to D4414: elm_colorselector: Palette Box made center aligned.

For Tizen platform we need palette to be center aligned, but it was left aligned in opensource.
We need to take a call how the UI should be in opensource and based on that take this change.

Nov 18 2016, 1:20 AM · efl
shilpasingh retitled D4414: elm_colorselector: Palette Box made center aligned from elm_colorselector: Palette not center aligned issue fix to elm_colorselector: Palette Box made center aligned.
Nov 18 2016, 1:19 AM · efl
shilpasingh updated subscribers of D4414: elm_colorselector: Palette Box made center aligned.
Nov 18 2016, 1:05 AM · efl
shilpasingh retitled D4414: elm_colorselector: Palette Box made center aligned from to elm_colorselector: Palette not center aligned issue fix.
Nov 18 2016, 1:04 AM · efl

Oct 16 2016

shilpasingh retitled D4352: elm_atspi_bridge: visible data changed signal not sent issue fix. from to elm_atspi_bridge: visible data changed signal not sent issue fix..
Oct 16 2016, 10:30 PM

Sep 26 2016

shilpasingh retitled D4318: elm_atspi_bridge: Active descendant changed signal not sent issue fix. from [ATSPI]: Active descendant changed signal not sent issue fix. to elm_atspi_bridge: Active descendant changed signal not sent issue fix..
Sep 26 2016, 3:40 AM
shilpasingh updated the diff for D4318: elm_atspi_bridge: Active descendant changed signal not sent issue fix..

-updated

Sep 26 2016, 3:39 AM
shilpasingh retitled D4318: elm_atspi_bridge: Active descendant changed signal not sent issue fix. from to [ATSPI]: Active descendant changed signal not sent issue fix..
Sep 26 2016, 3:29 AM

Sep 1 2016

shilpasingh added a comment to D3511: Evas_textblock: Add evas_textblock_cursor_is_inside_word_get API.

ping?

Sep 1 2016, 7:06 AM · efl

Jul 12 2016

shilpasingh added a comment to D3511: Evas_textblock: Add evas_textblock_cursor_is_inside_word_get API.
In D3511#69139, @raster wrote:

sorry shilpa! this one seems to have languished. i think it's time to push it along again. @tasn - yes name will have to change and interfaces api makes all of this be different now. i can see this as convenient.

Jul 12 2016, 8:49 PM · efl

Jul 10 2016

shilpasingh updated subscribers of D4145: Accessibility: Read pre-edit text..
Jul 10 2016, 8:57 PM

Jul 7 2016

shilpasingh updated subscribers of D4145: Accessibility: Read pre-edit text..
Jul 7 2016, 7:05 AM
shilpasingh retitled D4145: Accessibility: Read pre-edit text. from [Accessibility]: Read pre-edit text. to Accessibility: Read pre-edit text..
Jul 7 2016, 7:05 AM
shilpasingh retitled D4145: Accessibility: Read pre-edit text. from to [Accessibility]: Read pre-edit text..
Jul 7 2016, 7:03 AM

Jun 26 2016

shilpasingh added reviewers for D4100: elm_atspi_bridge: Add bounds-changed signal sending code.: cedric, lukasz.stanislawski, kimcinoo.
Jun 26 2016, 11:34 PM
shilpasingh updated the test plan for D4100: elm_atspi_bridge: Add bounds-changed signal sending code..
Jun 26 2016, 11:08 PM
shilpasingh retitled D4100: elm_atspi_bridge: Add bounds-changed signal sending code. from to elm_atspi_bridge: Add bounds-changed signal sending code..
Jun 26 2016, 11:05 PM

Jun 2 2016

shilpasingh updated D3999: elc_multibuttonentry: added definition for elm_multibuttonentry_item_selected_get API.
Jun 2 2016, 2:17 AM
shilpasingh updated D3997: elm_colorselector: colornames updated with spaces..
Jun 2 2016, 2:17 AM
shilpasingh updated subscribers of D3999: elc_multibuttonentry: added definition for elm_multibuttonentry_item_selected_get API.
Jun 2 2016, 12:41 AM
shilpasingh added a reviewer for D3999: elc_multibuttonentry: added definition for elm_multibuttonentry_item_selected_get API: cedric.
Jun 2 2016, 12:40 AM
shilpasingh updated the diff for D3999: elc_multibuttonentry: added definition for elm_multibuttonentry_item_selected_get API.

unneceesary code removed.

Jun 2 2016, 12:36 AM

Jun 1 2016

shilpasingh retitled D3999: elc_multibuttonentry: added definition for elm_multibuttonentry_item_selected_get API from to elc_multibuttonentry: added definition for elm_multibuttonentry_item_selected_get API.
Jun 1 2016, 8:34 AM
shilpasingh updated subscribers of D3997: elm_colorselector: colornames updated with spaces..
Jun 1 2016, 2:08 AM
shilpasingh retitled D3997: elm_colorselector: colornames updated with spaces. from to elm_colorselector: colornames updated with spaces..
Jun 1 2016, 2:07 AM
shilpasingh added inline comments to D3987: elm_colorselector: Use layout instead of edje object for components..
Jun 1 2016, 12:54 AM
shilpasingh updated the diff for D3987: elm_colorselector: Use layout instead of edje object for components..

removed colornames update

Jun 1 2016, 12:54 AM

May 30 2016

shilpasingh updated D3987: elm_colorselector: Use layout instead of edje object for components..
May 30 2016, 11:38 PM

May 26 2016

shilpasingh added a reviewer for D3987: elm_colorselector: Use layout instead of edje object for components.: Hermet.
May 26 2016, 8:02 AM
shilpasingh added a reviewer for D3987: elm_colorselector: Use layout instead of edje object for components.: cedric.
May 26 2016, 7:18 AM
shilpasingh updated the diff for D3987: elm_colorselector: Use layout instead of edje object for components..

Added spaces in color names for clarity while being read by any TTS engine

May 26 2016, 7:15 AM
shilpasingh retitled D3987: elm_colorselector: Use layout instead of edje object for components. from to elm_colorselector: Use layout instead of edje object for components..
May 26 2016, 3:14 AM

Feb 24 2016

shilpasingh requested review of D3720: elm_spinner: Add label format validator.

tested for other possible error conditions only and not all warnings as those warnings are ignored by printf and rest of the valid format is set.

Feb 24 2016, 6:53 AM
shilpasingh updated the diff for D3720: elm_spinner: Add label format validator.

Fixed comments, consider possible flags, multiple occurance of '.' and other error conditions only.

Feb 24 2016, 6:50 AM
shilpasingh added a comment to D3720: elm_spinner: Add label format validator.
In D3720#60769, @jpeg wrote:

How does this relate to D3664 ? I see a validation there too?

Feb 24 2016, 2:28 AM

Feb 22 2016

shilpasingh added a comment to D3720: elm_spinner: Add label format validator.

@cedric, this commit has not been landed yet. If any issue please let me know

Feb 22 2016, 10:02 PM

Feb 20 2016

shilpasingh closed T3121: elm_spinner_label_format_set crash for some entries as Resolved.

Differential D3668 and improved D3720 fixes this issue.

Feb 20 2016, 9:02 AM · Restricted Project