Page MenuHomePhabricator

singh.amitesh (Amitesh Singh)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 20 2013, 1:44 AM (304 w, 4 d)
Availability
Available

Recent Activity

Aug 20 2018

singh.amitesh added a commit to T6514: fix eolian function redefine errors: Unknown Object (Diffusion Commit).
Aug 20 2018, 1:01 PM · Restricted Project, efl
singh.amitesh added a commit to T6204: format function cb overhaul : Unknown Object (Diffusion Commit).
Aug 20 2018, 1:01 PM · Restricted Project, efl
singh.amitesh added a commit to T6204: format function cb overhaul : Unknown Object (Diffusion Commit).
Aug 20 2018, 1:00 PM · Restricted Project, efl
singh.amitesh added a commit to T5323: Refactor elm_button: Unknown Object (Diffusion Commit).
Aug 20 2018, 12:59 PM · Restricted Project, efl

Jul 25 2018

singh.amitesh abandoned D4536: ecore_wayland_input : updating global x y coordinates when enter using pointer.
Jul 25 2018, 12:41 AM · efl
singh.amitesh commandeered D4536: ecore_wayland_input : updating global x y coordinates when enter using pointer.
Jul 25 2018, 12:41 AM · efl

Mar 7 2018

singh.amitesh closed T6594: terminology loses focus in case of pasting text via Paste button from control. as Resolved.

This patch does fix this issue. 253680f754f1165ff8b6397d378ecba4af8acc50 -> efl patch.

Mar 7 2018, 2:34 AM · Terminology
singh.amitesh added a comment to T6594: terminology loses focus in case of pasting text via Paste button from control..

I shall try fixing this based on @raster's hints.

Mar 7 2018, 2:08 AM · Terminology
singh.amitesh added a comment to D5765: PROTOTYPE: Efl.Ui.Widget: implement Efl.Gfx.Color_Class.

I have added following patches into master branch.

Mar 7 2018, 1:35 AM · efl

Feb 20 2018

singh.amitesh added a comment to T6673: Need to check commit " b1ee35e elm: do not call "changed" callback when setting style".

This is fixed now. we can close it.

Feb 20 2018, 8:34 PM

Feb 18 2018

singh.amitesh reopened T6594: terminology loses focus in case of pasting text via Paste button from control. as "Open".
Feb 18 2018, 10:49 PM · Terminology
singh.amitesh added a comment to T6594: terminology loses focus in case of pasting text via Paste button from control..

rebuilt efl/e and i could reproduce this.

Feb 18 2018, 10:48 PM · Terminology
singh.amitesh added a comment to T6594: terminology loses focus in case of pasting text via Paste button from control..

i am rebuilding efl/e to verify this.

Feb 18 2018, 10:42 PM · Terminology
singh.amitesh added a comment to T6594: terminology loses focus in case of pasting text via Paste button from control..

Thanks for the fix.

Feb 18 2018, 10:35 PM · Terminology

Jan 29 2018

singh.amitesh closed T6639: elm_check triggers "changed" signal twice on click, a subtask of T6637: Gadget Bar Wizard option "automatically size based an contents" not working, as Resolved.
Jan 29 2018, 5:55 AM · enlightenment-git
singh.amitesh closed T6639: elm_check triggers "changed" signal twice on click as Resolved by committing rEFL596c88f8992d: Efl.Ui.Check: fix changed callback is called twice.
Jan 29 2018, 5:55 AM · regression, efl
singh.amitesh closed D5768: Efl.Ui.Check: fix changed callback is called twice.
Jan 29 2018, 5:55 AM
singh.amitesh accepted D5768: Efl.Ui.Check: fix changed callback is called twice.
Jan 29 2018, 3:00 AM
singh.amitesh reassigned T6639: elm_check triggers "changed" signal twice on click from jpeg to taxi2se.
Jan 29 2018, 2:39 AM · regression, efl

Jan 16 2018

singh.amitesh added a comment to T6591: ^c on terminology does not work anymore in case of typo in command.

it works now magically. don't know how and why...
so we can close it.

Jan 16 2018, 11:00 PM · Terminology

Jan 10 2018

singh.amitesh added a comment to T6591: ^c on terminology does not work anymore in case of typo in command.

i have upgraded arch again and i still have this issue. i wonder what went wrong.
will try to find root cause and report here.

Jan 10 2018, 7:08 PM · Terminology

Jan 9 2018

singh.amitesh created T6594: terminology loses focus in case of pasting text via Paste button from control..
Jan 9 2018, 9:55 PM · Terminology

Jan 8 2018

singh.amitesh added a comment to T6591: ^c on terminology does not work anymore in case of typo in command.

just type anything on terminal and then ^c. it does not do anything. ideally it should cancel out the command.

Jan 8 2018, 5:27 PM · Terminology
singh.amitesh created T6591: ^c on terminology does not work anymore in case of typo in command.
Jan 8 2018, 5:22 PM · Terminology

Dec 14 2017

singh.amitesh added a comment to T6514: fix eolian function redefine errors.

refer ad28bdfb5a464895a1a0ce3e909a

Dec 14 2017, 1:17 AM · Restricted Project, efl

Dec 13 2017

singh.amitesh added a commit to T6514: fix eolian function redefine errors: rEFL3726af831350: efl.image.load: fix eolian redefine warnings for load_error{}.
Dec 13 2017, 9:17 PM · Restricted Project, efl
singh.amitesh added a comment to T6514: fix eolian function redefine errors.

We won't fix legacy code warnings. e.g. elm_interface_scrollable.eo

Dec 13 2017, 7:01 PM · Restricted Project, efl
singh.amitesh created T6514: fix eolian function redefine errors.
Dec 13 2017, 6:59 PM · Restricted Project, efl

Dec 12 2017

singh.amitesh closed T6500: EFL: latest breaks E build as Resolved by committing rE4d340f211471: Revert "re-enable building against latest efl git".
Dec 12 2017, 8:45 PM · enlightenment-git

Dec 7 2017

singh.amitesh created T6490: interface_scroller: fix the redefined warnings in eo .
Dec 7 2017, 11:49 PM

Dec 1 2017

singh.amitesh updated the task description for T6459: Efl.Ui.Calander crashes on focus movement.
Dec 1 2017, 8:23 AM
singh.amitesh created T6459: Efl.Ui.Calander crashes on focus movement.
Dec 1 2017, 8:22 AM

Nov 22 2017

singh.amitesh requested changes to D5424: efl_ui_spin, efl_ui_spin_button: Add new spin, spin_button widgets..
Nov 22 2017, 8:38 PM

Nov 21 2017

singh.amitesh added inline comments to D5510: efl_access: Add attribute_append, attributes_clear APIs.
Nov 21 2017, 8:52 PM

Nov 16 2017

singh.amitesh added a commit to T6376: Cleanup indicator APIs in slider.: rEFL19e70a8e1f30: Efl.Ui.Slider: replace default with on_drag in visible_mode enum..
Nov 16 2017, 9:42 PM · Restricted Project, efl
singh.amitesh added a commit to T6376: Cleanup indicator APIs in slider.: rEFL651d9e94a0a7: Efl.Ui.Slider: add visible_mode() as an indicator part API.
Nov 16 2017, 9:42 PM · Restricted Project, efl
singh.amitesh added a commit to T6376: Cleanup indicator APIs in slider.: rEFL77164413cd85: Efl.Ui.Slider: make indicator_show_on_focus/indicator_show() legacy APIs.
Nov 16 2017, 9:42 PM · Restricted Project, efl
singh.amitesh added a commit to T6376: Cleanup indicator APIs in slider.: rEFL67996afbf66d: Efl.Ui.Slider: make indicator_visible_mode() legacy APIs.
Nov 16 2017, 9:42 PM · Restricted Project, efl

Nov 15 2017

singh.amitesh added a comment to T5361: Cleanup elm_slider.eo.
In T5361#104728, @jpeg wrote:

Looks like the answer is to have a single enum for EO API, which is slightly different from the legacy:

  • default
  • always
  • none
  • on_focus
  • on_drag (new in eo as it's "default" in legacy) Bbut default here should mean "whatever is in elm_config".
Nov 15 2017, 5:26 PM · Restricted Project, efl
singh.amitesh created T6376: Cleanup indicator APIs in slider..
Nov 15 2017, 5:25 PM · Restricted Project, efl

Nov 12 2017

singh.amitesh added a comment to T5361: Cleanup elm_slider.eo.

We can close this now.

Nov 12 2017, 11:04 PM · Restricted Project, efl

Oct 30 2017

singh.amitesh added a commit to T6204: format function cb overhaul : rEFL04fe5e10a299: eina: eina_value - Add "struct tm" support.
Oct 30 2017, 12:08 AM · Restricted Project, efl

Oct 29 2017

singh.amitesh added a comment to T6282: Sticky windows are moved around sometimes.

@Martin-Furter Are you using git-master? or the latest released E?

Oct 29 2017, 7:43 PM · Restricted Project
singh.amitesh reassigned T6282: Sticky windows are moved around sometimes from singh.amitesh to raster.
Oct 29 2017, 7:05 AM · Restricted Project

Oct 26 2017

singh.amitesh added a commit to T6204: format function cb overhaul : rEFLde74fd11ba1b: Efl.Ui.Mbe: implement format_cb.set().
Oct 26 2017, 5:12 AM · Restricted Project, efl
singh.amitesh added a commit to T6204: format function cb overhaul : rEFL3092c0fdeaad: Efl.Ui.Progressbar: implement format_cb.set.
Oct 26 2017, 5:12 AM · Restricted Project, efl
singh.amitesh added a commit to T6204: format function cb overhaul : rEFL5298cb59d2dc: Efl.Ui.Format: implement generic format_string function.
Oct 26 2017, 5:12 AM · Restricted Project, efl

Oct 25 2017

singh.amitesh added a commit to T6204: format function cb overhaul : rEFL8661fe234c7e: Efl.Ui.Slider: implement format_cb for units.
Oct 25 2017, 12:19 AM · Restricted Project, efl

Oct 16 2017

singh.amitesh added a commit to T6204: format function cb overhaul : rEFL0088143ccbe7: efl intf: Add format interface.
Oct 16 2017, 5:29 AM · Restricted Project, efl

Oct 13 2017

singh.amitesh updated the task description for T6204: format function cb overhaul .
Oct 13 2017, 2:23 AM · Restricted Project, efl
singh.amitesh added a commit to T6204: format function cb overhaul : rEFL2cf24eb30428: eina: strbuf - Add strftime related functions.
Oct 13 2017, 12:04 AM · Restricted Project, efl

Oct 12 2017

singh.amitesh updated the task description for T6204: format function cb overhaul .
Oct 12 2017, 7:33 PM · Restricted Project, efl
singh.amitesh updated the task description for T6204: format function cb overhaul .
Oct 12 2017, 7:32 PM · Restricted Project, efl
singh.amitesh updated the task description for T6204: format function cb overhaul .
Oct 12 2017, 7:19 PM · Restricted Project, efl
singh.amitesh updated the task description for T6204: format function cb overhaul .
Oct 12 2017, 7:18 PM · Restricted Project, efl
singh.amitesh updated the task description for T6204: format function cb overhaul .
Oct 12 2017, 7:16 PM · Restricted Project, efl
singh.amitesh updated the task description for T6204: format function cb overhaul .
Oct 12 2017, 7:08 PM · Restricted Project, efl
singh.amitesh created T6204: format function cb overhaul .
Oct 12 2017, 7:07 PM · Restricted Project, efl

Oct 11 2017

singh.amitesh claimed T5494: EO: elm policy API.
Oct 11 2017, 11:54 PM · efl (efl-1.22), efl: widgets

Sep 25 2017

singh.amitesh added a comment to T5361: Cleanup elm_slider.eo.
In T5361#98753, @jpeg wrote:

No it's not completed.

type slider_func_type: __undefined_type; [[Elementary slider function type]]
type slider_freefunc_type: __undefined_type; [[Elementary slider free function type]]

And it's used in:

@property indicator_format_function {
   set {
      [[Set the format function pointer for the indicator label
 
        Set the callback function to format the indicator string.
      ]]
   }
   values {
      func: slider_func_type @nullable; [[The indicator format function.]]
      free_func: slider_freefunc_type @nullable; [[The freeing function for the format string.]]
   }
}

Are you sure the indicator APIs are specific to the slider and only the slider? They don't apply to progressbar or anything else???

Sep 25 2017, 2:06 AM · Restricted Project, efl

Sep 19 2017

singh.amitesh added a comment to T5359: Refactor elm_panes.
In T5359#98754, @jpeg wrote:

I think it's in pretty good shape now, indeed. A few comments though:

  1. Event names: ` events { press; Called when panes got pressed unpress; Called when panes are no longer pressed } `
Sep 19 2017, 1:47 AM · Restricted Project, efl
singh.amitesh renamed T6045: auto hide / show of a half pane when dragged forcefully from Feature Request in panes to auto hide / show of a half pane when dragged forcefully.
Sep 19 2017, 1:31 AM · efl: widgets, Restricted Project
singh.amitesh created T6045: auto hide / show of a half pane when dragged forcefully.
Sep 19 2017, 1:30 AM · efl: widgets, Restricted Project
singh.amitesh added a comment to D5198: interval slider: Check for null ptr deref.
In D5198#88113, @jpeg wrote:

We can mark these CIDs as false alarm.

We should use efl_data_scope_get here as Coverity has already guessed that we don't do NULL checks on it. If we stay consistent, Coverity will be more useful.

Sep 19 2017, 1:22 AM

Sep 17 2017

singh.amitesh added a comment to D5198: interval slider: Check for null ptr deref.

I have discussed with @jpeg. efl_data_scope_get/safe_get() will always return not-null value if obj is valid.
In case of obj is invalid, the eo will do the check for us before this function gets called and warn the user.
So basically we don't need this check.
We can mark these CIDs as false alarm.

Sep 17 2017, 6:33 PM
singh.amitesh added inline comments to D5198: interval slider: Check for null ptr deref.
Sep 17 2017, 6:28 PM
singh.amitesh requested changes to D5198: interval slider: Check for null ptr deref.
Sep 17 2017, 6:18 PM
singh.amitesh added inline comments to D5198: interval slider: Check for null ptr deref.
Sep 17 2017, 6:17 PM

Sep 14 2017

singh.amitesh added a comment to T5359: Refactor elm_panes.

can we close this? i think its completed.

Sep 14 2017, 1:06 AM · Restricted Project, efl
singh.amitesh added a comment to T5361: Cleanup elm_slider.eo.

can we close this? i think its completed.

Sep 14 2017, 1:06 AM · Restricted Project, efl

Sep 13 2017

singh.amitesh added a comment to T6008: Efl.Ui.Clock: value_max/min uses keys for a wrong reason.

No worries, i pushed it.

Sep 13 2017, 4:40 AM · efl
singh.amitesh closed T6008: Efl.Ui.Clock: value_max/min uses keys for a wrong reason as Resolved by committing rEFL3984148b8e54: efl.ui.clock: correct value_set/get & value_min/max APIs signature..
Sep 13 2017, 4:40 AM · efl
singh.amitesh added a comment to T6008: Efl.Ui.Clock: value_max/min uses keys for a wrong reason.

Hey Jack,

Sep 13 2017, 4:32 AM · efl

Sep 12 2017

singh.amitesh added a comment to T5361: Cleanup elm_slider.eo.

new interval slider widget is added. It is a slider with two indicators. Legacy range would work on base slider as usual.

Sep 12 2017, 2:39 AM · Restricted Project, efl

Sep 6 2017

singh.amitesh reassigned T5900: Refactor spinner widget from singh.amitesh to CHAN.
Sep 6 2017, 7:29 PM · Restricted Project, efl

Sep 5 2017

singh.amitesh added a commit to T5966: eina_mempool_from invalid memory read.: rEFL373e6a09183b: eina: fix compilation after b0rking in c9a0237770a7fb.
Sep 5 2017, 12:23 AM · efl

Aug 31 2017

singh.amitesh added a commit to T5900: Refactor spinner widget: rEFL9836116cab93: elm: rename elm spinner to Efl.Ui.Spinner.
Aug 31 2017, 10:15 PM · Restricted Project, efl
singh.amitesh added a comment to T5900: Refactor spinner widget.
In T5900#96788, @jpeg wrote:
  1. Move "range_interval" to a subclass of slider. It's confusing with other widgets (single value slider, progressbar or spinner).
Aug 31 2017, 6:16 PM · Restricted Project, efl

Aug 17 2017

singh.amitesh created T5900: Refactor spinner widget.
Aug 17 2017, 5:19 AM · Restricted Project, efl
singh.amitesh reopened T5900: Refactor spinner widget, a subtask of T5301: Make EFL easier to use by improving its interface, as Open.
Aug 17 2017, 5:18 AM · Restricted Project, efl, Restricted Project

Aug 16 2017

singh.amitesh added a comment to T5359: Refactor elm_panes.

It would be nice to have following feature in panes which @jpeg has already suggested before.
Please have a look at below video.

Aug 16 2017, 5:43 PM · Restricted Project, efl

Aug 13 2017

singh.amitesh created T5879: panes theme needs to be according to its contents not side bar..
Aug 13 2017, 6:11 PM · Restricted Project, efl
singh.amitesh reopened T5879: panes theme needs to be according to its contents not side bar., a subtask of T5359: Refactor elm_panes, as Open.
Aug 13 2017, 6:11 PM · Restricted Project, efl
singh.amitesh added a comment to T5359: Refactor elm_panes.

Panes theme needs to be changed.
Currently panes direction is in reference to the side bar orientation. I think it should be
according to the layout of its contents (first and second). We should fork out a task for theme.

Aug 13 2017, 6:05 PM · Restricted Project, efl

Aug 10 2017

singh.amitesh added a comment to T5359: Refactor elm_panes.

I am summerizing the work done on panes widget.

  1. ranmed to Efl.Ui.Panes 40945d985967e58d6e6c00ecfd6292a8d67b83b5
  2. add first and second as content aliases 46d4df4962a723f12723a901b0d2ae2966ebb7ad
  3. allow panes to respect the min size of its content 0ca98280d4b041e277d071ecfbcbc77db2eaa7cd
  4. implement allow_user_size_hints on parts aaaf1a282a82f2f10b01f561ea210d5643707a1a
  5. rename left/right_size_set to split_ratio & implements min_split_ratio on parts. 599bb616ec501bacd5af8cae3c9e5226509b3303
  6. don't use edje restrict cal to calculate min size 521e2ab83ce0949de8101602d3596f30b7650bcb
Aug 10 2017, 7:14 PM · Restricted Project, efl
singh.amitesh added a commit to T5359: Refactor elm_panes: rEFLc7acb8c01c28: Efl.Ui.Panes: use internal func to detect legacy usage.
Aug 10 2017, 12:31 AM · Restricted Project, efl
singh.amitesh added a commit to T5870: eoapi: Clean up orientation vs. ui direction: rEFL9abd6445667a: Efl.Ui.Panes: switch to Efl.Ui.Dir (EO).
Aug 10 2017, 12:00 AM · Restricted Project, efl

Aug 4 2017

singh.amitesh closed T5560: implement Efl.Player in Edje as Resolved by committing rEFL0e7a316a7a05: edje: implement edje.player interface functions.
Aug 4 2017, 12:27 AM · Restricted Project, efl
singh.amitesh closed T5560: implement Efl.Player in Edje, a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Aug 4 2017, 12:26 AM · Restricted Project, efl, Restricted Project

Aug 2 2017

singh.amitesh added a comment to T5560: implement Efl.Player in Edje.

@jpeg patch is ready! working and tested. :)

Aug 2 2017, 3:36 AM · Restricted Project, efl

Aug 1 2017

singh.amitesh added a comment to T5560: implement Efl.Player in Edje.

@jpeg the edje eo apis transition_duration_factor etcs would be legacy apis?

Aug 1 2017, 6:19 PM · Restricted Project, efl

Jul 30 2017

singh.amitesh added a comment to T5359: Refactor elm_panes.

APIs content_left_size and content_right_size should be renamed to more meaningful.

Jul 30 2017, 11:36 PM · Restricted Project, efl

Jul 27 2017

singh.amitesh claimed T5359: Refactor elm_panes.
Jul 27 2017, 4:20 AM · Restricted Project, efl

Jul 24 2017

singh.amitesh added a comment to T5757: focus bug if enable/disable button .

well, it does not happen anymore. it may be fixed in your one of the patches related to supressing the error logs related to elm.box.

Jul 24 2017, 7:33 PM · efl

Jul 19 2017

singh.amitesh added a project to T5757: focus bug if enable/disable button : efl.
Jul 19 2017, 6:30 PM · efl
singh.amitesh added a comment to T5757: focus bug if enable/disable button .

i got these warnings everywhere

Jul 19 2017, 6:29 PM · efl
singh.amitesh updated the task description for T5757: focus bug if enable/disable button .
Jul 19 2017, 5:56 PM · efl
singh.amitesh created T5757: focus bug if enable/disable button .
Jul 19 2017, 5:55 PM · efl

Jul 17 2017

singh.amitesh raised the priority of T5753: focus is allowed on disabled widgets from High to Showstopper Issues.
Jul 17 2017, 7:13 PM · efl
singh.amitesh created T5753: focus is allowed on disabled widgets.
Jul 17 2017, 7:04 PM · efl