Page MenuHomePhabricator

smohanty (Subhransu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 22 2013, 8:52 PM (281 w, 6 d)
Availability
Available

Recent Activity

Mar 26 2019

smohanty added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

The Structure looks ok as most of the changes are in the recognizer. this patch is good to go.

Mar 26 2019, 10:26 PM · DO NOT MERGE, efl

Aug 8 2018

smohanty updated the task description for T7260: Porting Pixman Neon backend to EFL..
Aug 8 2018, 12:28 AM
smohanty updated subscribers of T7260: Porting Pixman Neon backend to EFL..
Aug 8 2018, 12:23 AM
smohanty created T7260: Porting Pixman Neon backend to EFL..
Aug 8 2018, 12:21 AM

May 3 2018

smohanty updated the diff for D6052: edje: return proper value from the function..

updated

May 3 2018, 10:31 PM · efl
smohanty added reviewers for D6052: edje: return proper value from the function.: id213sin, myoungwoon.
May 3 2018, 9:20 PM · efl

Apr 3 2018

smohanty added a comment to T5320: Create Gesture Framework in Elementary.

@woohyun , @cedric
We still have some open points
2.How to implement the double tap and triple tap gesture with the current gesture framework ? (As with the current implementation recognizer uses the event from mouse down to mouse up to decide the gesture but in double tap case it has to alive for 2 consecutive touch sequence).

Apr 3 2018, 3:25 AM · efl: widgets, Restricted Project

Feb 27 2018

smohanty added reviewers for D5828: eina/bezier: use FLT_EQ marcro for float equal comparison.: SanghyeonLee, jpeg, cedric.
Feb 27 2018, 10:08 PM

Feb 18 2018

smohanty added a comment to D4933: elementary: Added the activate feature.

@id213sin , Could you provide your feedback on this patch as well.

Feb 18 2018, 8:15 PM · efl
smohanty added a reviewer for D4933: elementary: Added the activate feature: id213sin.
Feb 18 2018, 8:14 PM · efl
smohanty added a comment to D4933: elementary: Added the activate feature.

@bu5hm4n , could you please look at it again.

Feb 18 2018, 8:04 PM · efl
smohanty updated the diff for D4933: elementary: Added the activate feature.

updated

Feb 18 2018, 8:02 PM · efl
smohanty updated the diff for D4933: elementary: Added the activate feature.

updated review comment.

Feb 18 2018, 6:37 PM · efl

Feb 13 2018

smohanty added reviewers for D5803: evas/vg: reset the path data in destructor.: jpeg, SanghyeonLee.
Feb 13 2018, 1:36 AM

Feb 7 2018

smohanty added inline comments to D5795: ector: Updated the ector_buffer_pixels_set() api with stride info.
Feb 7 2018, 9:26 PM
smohanty updated the diff for D5795: ector: Updated the ector_buffer_pixels_set() api with stride info.

updated review comment

Feb 7 2018, 9:25 PM
smohanty added reviewers for D5795: ector: Updated the ector_buffer_pixels_set() api with stride info: jypark, jpeg.
Feb 7 2018, 12:06 AM

Jan 7 2018

smohanty added inline comments to D5724: evas/vg: Use always blending op while drawing the vector..
Jan 7 2018, 9:51 PM
smohanty added a comment to D5724: evas/vg: Use always blending op while drawing the vector..
In D5724#97991, @jpeg wrote:

See inline comment: is render_op still useful? can it ever be COPY? in which situations?

Jan 7 2018, 9:50 PM
smohanty added a reviewer for D5724: evas/vg: Use always blending op while drawing the vector.: jpeg.
Jan 7 2018, 6:43 PM
smohanty created D5724: evas/vg: Use always blending op while drawing the vector..
Jan 7 2018, 6:43 PM

Nov 30 2017

smohanty added a comment to D4933: elementary: Added the activate feature.

How does a widget bahave now if you click into it? Is it also activated then ?

Nov 30 2017, 12:11 AM · efl

Nov 9 2017

smohanty updated the diff for D5386: Redesign gl backend for vector.
  • ector/gl: update the change in ector gl header.
  • ector/gl: cleanup the ector gl backend
Nov 9 2017, 9:25 PM · efl
smohanty updated the diff for D5386: Redesign gl backend for vector.
  • ector/gl: added missing gl apis and few custom apis.
  • ector/gl: added new gl engine for ector
  • ector/gl: use new gl engine for the ector gl backend ector.
  • ector/gl: update the change in ector gl header.
  • ector/gl: cleanup the ector gl backend
Nov 9 2017, 9:08 PM · efl
smohanty updated the diff for D5386: Redesign gl backend for vector.
  • ector/gl: added missing gl apis and few custom apis.
  • ector/gl: added new gl engine for ector
  • ector/gl: use new gl engine for the ector gl backend ector.
  • ector/gl: update the change in ector gl header.
Nov 9 2017, 6:53 PM · efl
smohanty abandoned D5397: set of commit Preping for gl backend.

All the commits are landed in the master hence closing the revision.

Nov 9 2017, 6:51 PM
smohanty updated the diff for D5397: set of commit Preping for gl backend.
  • triangulator:Added stroke_set api to the triangulator_stroker.
  • ector: move gradient generation api to draw library for reuse.
  • evas/common: added a generic cache in evas common.
  • evas/vg: added support for engine surface cache.
  • evas/engine: added new engine api for ector
  • evas/vg: refactor ector engine api and backend .
  • evas/vg: use surface cache for efl vg canvas
Nov 9 2017, 12:55 AM

Nov 7 2017

smohanty abandoned D4377: Refactoring the vg parsing and saving implementation..

All the patch are landed in master hence abandoning the review.

Nov 7 2017, 8:59 PM
smohanty added reviewers for D5440: evas/vg: changed the efl_vg_dup api signature.: jpeg, cedric.
Nov 7 2017, 8:51 PM
smohanty created D5440: evas/vg: changed the efl_vg_dup api signature..
Nov 7 2017, 8:49 PM
smohanty updated the diff for D5397: set of commit Preping for gl backend.
  • triangulator:Added stroke_set api to the triangulator_stroker.
  • ector: move gradient generation api to draw library for reuse.
  • evas/engine: Added a generic cache for caching engine surfaces.
  • evas/engine: added new engine api for ector
Nov 7 2017, 7:37 PM
smohanty added a comment to T6324: Refactoring the Ector Backend.

The Tree is in the sense of grouping of drawable item not same as the widget tree so that the renderer can use fast path for drawing those.

Nov 7 2017, 4:36 PM · efl: rendering
smohanty added a comment to T6324: Refactoring the Ector Backend.

Have a look at this then we can discuss
http://doc.qt.io/qt-5/qtquick-visualcanvas-scenegraph-renderer.html

Nov 7 2017, 4:34 PM · efl: rendering
smohanty added a comment to T6324: Refactoring the Ector Backend.
  1. I think it is best for the future and force us to have some clean API (instead of how evas backend did turn).

I agree with the class hierarchy we need to keep it in that way. but am thinking the ector object are kind of low level object which need not be a eo object.
we can write the class hierarchy in C or it will be awesome if you guys allow the ector library can have c++ class :).

Nov 7 2017, 5:11 AM · efl: rendering
smohanty claimed T6324: Refactoring the Ector Backend.
Nov 7 2017, 4:47 AM · efl: rendering
smohanty added a comment to T6311: Adding SVG animation support in Ector.

I think using the animation framework for svg animation will be a overkill . because theoretically every shape node of the vg tree could have a animation which will result into a animation tree.
I was thinking of simple solution of 1 animation which goes through the animation node tree and calculates the final value which will update the corresponding vg node. each animation node will keep its duration, repeat and property value , and gets the input as time_elapsed from the main animation object and decide if it needs to update the property of the corresponding shape object or not.
What your opinion about it ?

Nov 7 2017, 4:45 AM · efl: rendering
smohanty added a comment to T6308: Add support for path clipping in Ector.

Well its a subset of the mask but the implementation will be totally different when you take the end to end pipeline (from svg parsing to final draw.)

Nov 7 2017, 4:39 AM · efl: rendering
smohanty added a comment to T6309: Add support for masking in Ector.

Well we need the image but its not a must . we know how to draw the vg tree in a buffer . so we can use temporary buffer to draw the mask tree and then use that as mask to draw the sub tree that is masked.

Nov 7 2017, 4:34 AM · efl: rendering

Nov 6 2017

smohanty updated the diff for D5397: set of commit Preping for gl backend.
  • triangulator:Added stroke_set api to the triangulator_stroker.
  • ector: move gradient generation api to draw library for reuse.
  • evas/engine: Added a generic cache for caching engine surfaces.
  • evas/engine: added new engine api for ector
Nov 6 2017, 9:31 PM

Nov 5 2017

smohanty added a comment to D5419: Remove evas internal dependency from the evas_font module.

@raster My bad .. have updated the commit to fix the same.

Nov 5 2017, 11:08 PM
smohanty updated the diff for D5419: Remove evas internal dependency from the evas_font module.
  • evas/font: remove font_dir related function from evas_common_private header
  • evas/font: remove evas internal dependancy from evas_font_ot
Nov 5 2017, 11:03 PM
smohanty added a comment to D4933: elementary: Added the activate feature.

@bu5hm4n could you please review it .

Nov 5 2017, 9:17 PM · efl
smohanty updated the task description for T6310: Add Text drawing support in Ector.
Nov 5 2017, 9:14 PM · efl: rendering
smohanty updated the task description for T6311: Adding SVG animation support in Ector.
Nov 5 2017, 9:12 PM · efl: rendering
smohanty updated the task description for T6309: Add support for masking in Ector.
Nov 5 2017, 9:11 PM · efl: rendering
smohanty updated the task description for T6308: Add support for path clipping in Ector.
Nov 5 2017, 9:09 PM · efl: rendering
smohanty updated the task description for T6324: Refactoring the Ector Backend.
Nov 5 2017, 9:07 PM · efl: rendering
Herald assigned T6324: Refactoring the Ector Backend to zmike.
Nov 5 2017, 9:06 PM · efl: rendering
smohanty added a comment to D5419: Remove evas internal dependency from the evas_font module.
In D5419#92410, @raster wrote:

did you actually compile this?:

In file included from ../src/lib/evas/common/evas_text_utils.h:19:0,
                 from ../src/lib/evas/common/evas_font.h:54,
                 from lib/evas/canvas/evas_font_dir.c:16:
../src/lib/evas/common/evas_font_ot.h:20:4: error: unknown type name ‘Evas_Coord’
    Evas_Coord x_offset;
    ^~~~~~~~~~
../src/lib/evas/common/evas_font_ot.h:21:4: error: unknown type name ‘Evas_Coord’
    Evas_Coord y_offset;
    ^~~~~~~~~~
Nov 5 2017, 7:27 PM
smohanty updated the diff for D5419: Remove evas internal dependency from the evas_font module.
  • evas/font: remove evas internal dependancy from evas_font_query
  • evas/font: move glyph draw implementation to evas_font_draw
  • evas/font: remove evas internal dependancy from evas_font_compress
  • evas/font: remove evas internal dependancy from evas_font_main
  • evas/font: add a new log domain for evas_font
  • evas/font: remove evas internal dependancy from evas_font_ot
  • evas/font: remove font_dir related function from evas_common_private header
Nov 5 2017, 7:22 PM

Nov 2 2017

smohanty created T6311: Adding SVG animation support in Ector.
Nov 2 2017, 7:29 PM · efl: rendering
smohanty created T6310: Add Text drawing support in Ector.
Nov 2 2017, 7:15 PM · efl: rendering
smohanty claimed T6309: Add support for masking in Ector.
Nov 2 2017, 7:04 PM · efl: rendering
Herald assigned T6309: Add support for masking in Ector to zmike.
Nov 2 2017, 7:04 PM · efl: rendering
smohanty created T6308: Add support for path clipping in Ector.
Nov 2 2017, 6:56 PM · efl: rendering

Nov 1 2017

smohanty updated the diff for D5419: Remove evas internal dependency from the evas_font module.
  • evas/font: remove evas internal dependancy from evas_font_query
  • evas/font: move glyph draw implementation to evas_font_draw
  • evas/font: remove evas internal dependancy from evas_font_compress
  • evas/font: remove evas internal dependancy from evas_font_main
  • evas/font: remove evas internal dependancy from evas_font_ot
  • evas/font: remove font_dir related function from evas_common_private header
Nov 1 2017, 4:53 AM
smohanty updated the diff for D5419: Remove evas internal dependency from the evas_font module.
  • evas/font: move glyph draw implementation to evas_font_draw
  • evas/font: remove evas internal dependancy from evas_font_compress
Nov 1 2017, 4:22 AM
smohanty updated the diff for D5419: Remove evas internal dependency from the evas_font module.
  • evas/font: remove evas internal dependancy from evas_font_query
Nov 1 2017, 3:59 AM
smohanty updated the diff for D5419: Remove evas internal dependency from the evas_font module.

added a new commit to fix coding style in evas_font_dir

Nov 1 2017, 3:31 AM
smohanty added a comment to D5419: Remove evas internal dependency from the evas_font module.

My editor is set to auto remove the trailing space so just ignore those lines :)

Nov 1 2017, 1:44 AM
smohanty added a comment to D5402: Remove evas internal dependency from the evas_font module.

created a new review id
https://phab.enlightenment.org/D5419

Nov 1 2017, 1:43 AM
smohanty added reviewers for D5419: Remove evas internal dependency from the evas_font module: jpeg, raster, herdsman, cedric, id213sin.
Nov 1 2017, 1:38 AM
smohanty created D5419: Remove evas internal dependency from the evas_font module.
Nov 1 2017, 1:37 AM
smohanty abandoned D5402: Remove evas internal dependency from the evas_font module.
Nov 1 2017, 1:28 AM
smohanty added a comment to D5402: Remove evas internal dependency from the evas_font module.

Will delete this patch and create a new one because of the edje_cc code and i have no idea how to remove it :)
so will let you know the new review id.

Nov 1 2017, 1:27 AM

Oct 31 2017

smohanty updated the diff for D4933: elementary: Added the activate feature.

added new active property and did rebase.

Oct 31 2017, 9:22 PM · efl

Oct 30 2017

smohanty updated the diff for D5402: Remove evas internal dependency from the evas_font module.

rebase

Oct 30 2017, 2:14 AM
smohanty updated the diff for D5402: Remove evas internal dependency from the evas_font module.
  • evas/common: move font related structure to evas_font file.
  • evas/font: remove unnecessary include from evas_font_private.h.
Oct 30 2017, 2:12 AM
smohanty updated the summary of D5402: Remove evas internal dependency from the evas_font module.
Oct 30 2017, 2:07 AM
smohanty updated the summary of D5402: Remove evas internal dependency from the evas_font module.
Oct 30 2017, 2:05 AM
smohanty retitled D5402: Remove evas internal dependency from the evas_font module from evas: remove unnecessery includes. to Remove evas internal dependency from the evas_font module .
Oct 30 2017, 2:02 AM
smohanty updated the diff for D5402: Remove evas internal dependency from the evas_font module.

updated

Oct 30 2017, 12:36 AM
smohanty added a reviewer for D5402: Remove evas internal dependency from the evas_font module: herdsman.
Oct 30 2017, 12:16 AM
smohanty added a reviewer for D5402: Remove evas internal dependency from the evas_font module: raster.
Oct 30 2017, 12:11 AM
smohanty created D5402: Remove evas internal dependency from the evas_font module.
Oct 30 2017, 12:09 AM

Oct 27 2017

smohanty added a comment to D5397: set of commit Preping for gl backend.

private branch is devs/subhransu/evas_vg

Oct 27 2017, 3:59 AM
smohanty updated the summary of D5397: set of commit Preping for gl backend.
Oct 27 2017, 1:02 AM
smohanty created D5397: set of commit Preping for gl backend.
Oct 27 2017, 1:01 AM

Oct 26 2017

smohanty updated the diff for D4377: Refactoring the vg parsing and saving implementation..

split the vg caching commit to smaller ones

Oct 26 2017, 6:17 PM

Oct 25 2017

smohanty updated the diff for D5386: Redesign gl backend for vector.

added missing changes

Oct 25 2017, 8:48 PM · efl
smohanty added a comment to D5386: Redesign gl backend for vector.

Please check the branch dev/subhransu/glvg for the commits

Oct 25 2017, 8:02 PM · efl
smohanty updated the summary of D5386: Redesign gl backend for vector.
Oct 25 2017, 8:00 PM · efl
smohanty created D5386: Redesign gl backend for vector.
Oct 25 2017, 7:56 PM · efl
smohanty added a comment to D4377: Refactoring the vg parsing and saving implementation..

@cedric , @jpeg I have updated this by removing the merphing api and most of the review comments except in the svg loader which i will do in a separate patch.
Could you check once more and let me know your feedback.

Oct 25 2017, 6:24 PM
smohanty updated the diff for D4377: Refactoring the vg parsing and saving implementation..

updated review comment

Oct 25 2017, 6:21 PM
smohanty added inline comments to D4377: Refactoring the vg parsing and saving implementation..
Oct 25 2017, 6:04 PM
smohanty updated the diff for D4377: Refactoring the vg parsing and saving implementation..

updated review comments

Oct 25 2017, 5:55 PM
smohanty updated the diff for D4377: Refactoring the vg parsing and saving implementation..
Oct 25 2017, 5:24 PM
smohanty added inline comments to D5358: evas/vg: Added align , viewbox and fill_mode property to the vg canvas.
Oct 25 2017, 4:04 AM
smohanty updated the diff for D5358: evas/vg: Added align , viewbox and fill_mode property to the vg canvas.

updated review comment

Oct 25 2017, 4:04 AM

Oct 24 2017

smohanty updated the diff for D5358: evas/vg: Added align , viewbox and fill_mode property to the vg canvas.

updated the implementation

Oct 24 2017, 6:44 PM
smohanty updated the diff for D5358: evas/vg: Added align , viewbox and fill_mode property to the vg canvas.

removed fill and view class as well as eo prefix

Oct 24 2017, 3:00 AM
smohanty updated the diff for D5358: evas/vg: Added align , viewbox and fill_mode property to the vg canvas.

updated all review comment.

Oct 24 2017, 12:24 AM

Oct 23 2017

smohanty added a reviewer for D5358: evas/vg: Added align , viewbox and fill_mode property to the vg canvas: cedric.
Oct 23 2017, 11:57 PM
smohanty created D5358: evas/vg: Added align , viewbox and fill_mode property to the vg canvas.
Oct 23 2017, 11:56 PM
smohanty updated the diff for D5357: evas/vg: renamed the evas_vg class to efl_canvas_vg.

renamed the internal functions.

Oct 23 2017, 11:11 PM
smohanty created D5357: evas/vg: renamed the evas_vg class to efl_canvas_vg.
Oct 23 2017, 11:01 PM
smohanty updated the diff for D5347: evas/vg: Added set function for root_node property..

force a redraw when new root node is set.

Oct 23 2017, 3:37 AM
smohanty added a reviewer for D5347: evas/vg: Added set function for root_node property.: cedric.
Oct 23 2017, 3:33 AM
smohanty updated the diff for D5347: evas/vg: Added set function for root_node property..

Removed the evas_vg_root_node class. Now the root node is evas_vg_container and the life cycle is managed by th vg canvas class

Oct 23 2017, 3:33 AM