Page MenuHomePhabricator

smohanty (Subhransu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 22 2013, 8:52 PM (311 w, 1 d)
Availability
Available

Recent Activity

Nov 5 2019

smohanty added inline comments to D10598: edje: implement text_class override at object level.
Nov 5 2019, 4:33 PM · efl

Oct 7 2019

smohanty added a comment to T8302: Memory allocation issue in Evas_Object_Image due to Eina_Cow.

The change to be opaque should really happen once. Only if you switch back and forth for each frame will you continuously allocate memory. Basically you fallback to the case where you do not have any cow.

As I am running an animation (using lottie to render to the buffer ) so each frame I update the buffer (part of evas_image) with below Apis.

Oct 7 2019, 5:53 PM

Oct 3 2019

smohanty added a comment to T8302: Memory allocation issue in Evas_Object_Image due to Eina_Cow.

@cedric ,
Regarding my use case , I am updating image data in every frame by calling evas_object_image_data_get() and evas_object_image_data_set() api . I don't know how Image object can figure out if the content is opaque or not if user has set some pixel data (as it will be expensive to go through each pixel to figure it out) . So maybe we can modify the is_opaque() to return false when user has set some pixel data.

Oct 3 2019, 6:28 PM

Oct 1 2019

smohanty updated subscribers of T8302: Memory allocation issue in Evas_Object_Image due to Eina_Cow.

@cedric ,
What do you think ?

Oct 1 2019, 9:46 PM
smohanty created T8302: Memory allocation issue in Evas_Object_Image due to Eina_Cow.
Oct 1 2019, 9:43 PM

Sep 4 2019

smohanty added a comment to T8195: Memory Issue in edje_cache_emp_alloc() api..

Thanks for the detailed explanation after reading it got little bit more understanding of the current issue with edje memory consumption issue.

Sep 4 2019, 12:45 AM

Sep 1 2019

smohanty updated subscribers of T8195: Memory Issue in edje_cache_emp_alloc() api..

If you guys knows the history of this code, please let me know your opinion.

Sep 1 2019, 10:15 PM
smohanty created T8195: Memory Issue in edje_cache_emp_alloc() api..
Sep 1 2019, 10:12 PM

Aug 31 2019

smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..

hey @smohanty - keep things from getting personal. we DO have guidelines on how to behave: https://www.enlightenment.org/contact . You're not joking here and it's definitely crossing a line.

Aug 31 2019, 5:35 AM · efl

Aug 30 2019

smohanty requested review of D9739: eo/vtable: Fix issue with vtable creation of class..
Aug 30 2019, 5:19 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..
In D9739#182086, @tasn wrote:

What am I seeing in these logs? How were they collected?

Taken a Snapshot of Vtable array (after flattening of function array. ) by just printing the content of chain array (0 - not filled , 1 means filled)
Before Patch and after patch the slots that are filled are same. attached the log

Aug 30 2019, 5:19 PM · efl
smohanty added a comment to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
static inline void
_vtable_chain_merge(Dich_Chain1 *dst, const Dich_Chain1 *src)
{
   size_t j;
   const op_type_funcs *sf = src->chain2->funcs;
   op_type_funcs *df = dst->chain2->funcs;
Aug 30 2019, 5:50 AM · efl
smohanty requested review of D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..

Note for future review comment.

Aug 30 2019, 5:29 AM · efl
smohanty added inline comments to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 30 2019, 2:26 AM · efl
smohanty added a comment to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
In D9794#182033, @tasn wrote:

I don't get this change. Readability is subjective and this doesn't read any more readable to me, and it's 20 lines longer (not that it's the only parameter, but still).
It's also hard to follow when you changed a few unrelated things in one commit (or is it just phab being bad?).

Aug 30 2019, 2:16 AM · efl
smohanty added inline comments to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 30 2019, 2:16 AM · efl
smohanty added inline comments to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 30 2019, 1:57 AM · efl

Aug 29 2019

smohanty added reviewers for D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability.: Hermet, raster, cedric, tasn.
Aug 29 2019, 7:16 PM · efl
smohanty requested review of D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 29 2019, 7:15 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..

Test Done :

 efl eo test suite passed.
elementary_test example works.
Aug 29 2019, 6:11 PM · efl
smohanty updated the diff for D9739: eo/vtable: Fix issue with vtable creation of class..

updated the patch so that it will be a better match to the mental model.

Aug 29 2019, 6:05 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..
In D9739#181840, @tasn wrote:

Could you please fix the formatting in your comment? I'm not sure what you're trying to say there because of the wrong quote and etc. Regarding the MRO: I know it's not the actual MRO, delete the I from there then, it's still the same.

Aug 29 2019, 5:30 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..

Rest of the topic will discuss later.

Aug 29 2019, 7:11 AM · efl
smohanty added inline comments to D9769: evas_textblock_edje: replace fixed size array in reparse.
Aug 29 2019, 5:47 AM · efl
smohanty added reviewers for D9777: edje/style: append file prefix to textblock_style api that affects on file level: Hermet, ali.alzyod, zmike.
Aug 29 2019, 5:44 AM · efl
smohanty added a comment to D9781: eina_test: resolve build warning.

@ali.alzyod ,
I don't have access to submit the patch so you have to submit it.

Aug 29 2019, 5:42 AM · efl
smohanty accepted D9781: eina_test: resolve build warning.
Aug 29 2019, 5:42 AM · efl
smohanty added reviewers for D9784: edje/optimization: refactor edje_color_class_set() api.: Hermet, ali.alzyod, zmike.
Aug 29 2019, 3:49 AM · efl
smohanty requested review of D9784: edje/optimization: refactor edje_color_class_set() api..
Aug 29 2019, 3:48 AM · efl
smohanty accepted D9769: evas_textblock_edje: replace fixed size array in reparse.
Aug 29 2019, 2:31 AM · efl

Aug 28 2019

smohanty accepted D9770: evas_textblock: allocator use same heap if it is large enough.
Aug 28 2019, 9:28 PM · efl
smohanty added inline comments to D9770: evas_textblock: allocator use same heap if it is large enough.
Aug 28 2019, 9:28 PM · efl
smohanty updated the summary of D9777: edje/style: append file prefix to textblock_style api that affects on file level.
Aug 28 2019, 8:50 PM · efl
smohanty requested review of D9777: edje/style: append file prefix to textblock_style api that affects on file level.
Aug 28 2019, 8:49 PM · efl
smohanty added a child revision for D9776: edje/style/optimization: Enable lazy computaion of styles.: D9777: edje/style: append file prefix to textblock_style api that affects on file level.
Aug 28 2019, 8:49 PM · efl
smohanty added inline comments to D9776: edje/style/optimization: Enable lazy computaion of styles..
Aug 28 2019, 8:32 PM · efl
smohanty updated the diff for D9776: edje/style/optimization: Enable lazy computaion of styles..

updated review comment

Aug 28 2019, 8:31 PM · efl
smohanty added reviewers for D9776: edje/style/optimization: Enable lazy computaion of styles.: Hermet, ali.alzyod, kimcinoo, woohyun.
Aug 28 2019, 7:39 PM · efl
smohanty requested review of D9776: edje/style/optimization: Enable lazy computaion of styles..
Aug 28 2019, 7:38 PM · efl
smohanty added a reviewer for D9774: edje/textblock: Added edje_textblock_style_get() api.: kimcinoo.
Aug 28 2019, 6:09 PM · efl
smohanty added reviewers for D9774: edje/textblock: Added edje_textblock_style_get() api.: Hermet, ali.alzyod, woohyun.
Aug 28 2019, 6:07 PM · efl
smohanty requested review of D9774: edje/textblock: Added edje_textblock_style_get() api..
Aug 28 2019, 6:05 PM · efl
smohanty added inline comments to D9769: evas_textblock_edje: replace fixed size array in reparse.
Aug 28 2019, 12:32 PM · efl
smohanty requested changes to D9769: evas_textblock_edje: replace fixed size array in reparse.
Aug 28 2019, 12:31 PM · efl
smohanty requested changes to D9770: evas_textblock: allocator use same heap if it is large enough.

I think you are optimising wrong place . Please put some log and run elementary_test and first see how many heap allocation is happening and whats the average size of those strings , then you will get a better understanding about the nature of the problem and how to fix it.

Aug 28 2019, 12:27 PM · efl
smohanty added inline comments to D9770: evas_textblock: allocator use same heap if it is large enough.
Aug 28 2019, 12:25 PM · efl
smohanty added inline comments to D9769: evas_textblock_edje: replace fixed size array in reparse.
Aug 28 2019, 5:51 AM · efl
smohanty requested changes to D9769: evas_textblock_edje: replace fixed size array in reparse.
Aug 28 2019, 5:51 AM · efl

Aug 27 2019

smohanty added reviewers for D9764: edje: refactor _edje_object_file_set_internal() part 2.: Hermet, zmike.
Aug 27 2019, 11:58 PM · efl
smohanty requested review of D9764: edje: refactor _edje_object_file_set_internal() part 2..
Aug 27 2019, 11:57 PM · efl
smohanty added reviewers for D9763: edje/style: remove dead code.: Hermet, ali.alzyod.
Aug 27 2019, 9:57 PM · efl
smohanty requested review of D9763: edje/style: remove dead code..
Aug 27 2019, 9:57 PM · efl
smohanty requested review of D9761: edje: refactor _edje_object_file_set_internal() function.
Aug 27 2019, 6:52 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..

Regarding the Interface order , Issue is not with the Interface as they don't have any implementation , so they will correctly get filled during the function_set() time (if the slot is empty the table will get created)

Aug 27 2019, 5:23 AM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..
In D9739#181101, @tasn wrote:

Thanks for updating the diff, though as I described above, the whole change is probably problematic and I don't see how you can fix it without completely changing the approach.

Aug 27 2019, 5:14 AM · efl
smohanty added inline comments to D9753: edje/load: pass Edje_File instead of Edje to _edje_extract_mo_files().
Aug 27 2019, 5:02 AM · efl
smohanty added inline comments to D9753: edje/load: pass Edje_File instead of Edje to _edje_extract_mo_files().
Aug 27 2019, 3:47 AM · efl
smohanty added reviewers for D9753: edje/load: pass Edje_File instead of Edje to _edje_extract_mo_files(): Hermet, zmike, raster, cedric.
Aug 27 2019, 3:27 AM · efl
smohanty requested review of D9753: edje/load: pass Edje_File instead of Edje to _edje_extract_mo_files().
Aug 27 2019, 3:26 AM · efl
smohanty updated the diff for D9739: eo/vtable: Fix issue with vtable creation of class..

added back the comment.

Aug 27 2019, 2:36 AM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..

The mro for B is B, I and then A. So with your code it'll just skip I's vtable (which is all the slots empty other than slot[2]), and will make the vtable look like:

slot[0] = _A_isa
slot[1] = _A_func
slot[2] = NULL
slot[3] = _B_isa

See the problem I was talking about?

Aug 27 2019, 1:36 AM · efl
smohanty updated the diff for D9739: eo/vtable: Fix issue with vtable creation of class..

updated review comment.

Aug 27 2019, 1:25 AM · efl

Aug 26 2019

smohanty updated subscribers of T8170: Memory leak in efl_ui_focus_manager..
Aug 26 2019, 9:20 PM
smohanty added a comment to T8170: Memory leak in efl_ui_focus_manager..

@bu5hm4n ,

Did you get any chance to look at this issue ?
Aug 26 2019, 9:19 PM
smohanty updated the task description for T8181: Memory Issue with Eo Legacy Widget Implementation..
Aug 26 2019, 8:29 PM
smohanty created T8181: Memory Issue with Eo Legacy Widget Implementation..
Aug 26 2019, 8:28 PM
smohanty added reviewers for D9745: edje/optimization: replace eina_list with eina_array.: Hermet, zmike, cedric, raster.
Aug 26 2019, 5:51 PM · efl
smohanty requested review of D9745: edje/optimization: replace eina_list with eina_array..
Aug 26 2019, 5:50 PM · efl
smohanty added a comment to D9719: edje/text_class: Add test case for text_class feature.

but my test app shows font size 10 for both l1 and l2 .. I think that itself is a problem.

on trial and error, I notice override text_class (even on object level) will effect all objects that uses same style.
So l1 and l2 will be 10 (last override value)

This example shows what I am talking about
https://github.com/Ali-Alzyoud/override-text_class

Aug 26 2019, 5:35 PM · efl
smohanty updated the diff for D9739: eo/vtable: Fix issue with vtable creation of class..

updated review comment.

Aug 26 2019, 5:32 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..
In D9739#180896, @tasn wrote:

Regardless of that, even if the behaviour wasn't wrong, this change could probably be done by replacing line 843 with for ( ; *mro_itr && (*mro_itr == klass->parent) ; mro_itr++) ; instead all of the added code. Then line 846 will still do the correct thing because it'll skip either ourselves or parent.

Aug 26 2019, 4:03 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..
In D9739#180896, @tasn wrote:

I unfortunately don't remember the exact details of the implementation, but if memory serves, this doesn't actually do a copy, but rather just increase the refcount. Actually, I just checked and it's indeed the case. So if for some reason it's not doing refcounting correctly, that should be fixed. Though the behaviour proposed by this change is wrong.

Regardless of that, even if the behaviour wasn't wrong, this change could probably be done by replacing line 843 with for ( ; *mro_itr && (*mro_itr == klass->parent) ; mro_itr++) ; instead all of the added code. Then line 846 will still do the correct thing because it'll skip either ourselves or parent.

Though as I said, this change is wrong. Just read through _vtable_copy_all and you can see that it's wrong.

Aug 26 2019, 3:51 PM · efl
smohanty updated the diff for D9734: eina/array: added eina_array_find() api to eina_array..

updated docs wording from Xavi Artigas.

Aug 26 2019, 3:09 AM · efl
smohanty added reviewers for D9739: eo/vtable: Fix issue with vtable creation of class.: Hermet, cedric, raster.
Aug 26 2019, 3:03 AM · efl
smohanty requested review of D9739: eo/vtable: Fix issue with vtable creation of class..
Aug 26 2019, 3:02 AM · efl
smohanty updated the diff for D9734: eina/array: added eina_array_find() api to eina_array..

updated review comment

Aug 26 2019, 2:24 AM · efl
smohanty added a comment to D9719: edje/text_class: Add test case for text_class feature.

Let concentrate on below snippet.

Aug 26 2019, 2:18 AM · efl

Aug 25 2019

smohanty added a comment to D9719: edje/text_class: Add test case for text_class feature.

@smohanty
I am referring to EDC file you are using, to test text_class, can you share it ?

it seems you can not override text_class for text_block unless you added the text_class inside the style used in EDC file.

Aug 25 2019, 10:21 PM · efl
smohanty added inline comments to D9715: edje/cache: Refactor _edje_cache_file_coll_open().
Aug 25 2019, 6:18 PM · efl
smohanty updated the diff for D9715: edje/cache: Refactor _edje_cache_file_coll_open().

updated review comment.

Aug 25 2019, 6:14 PM · efl
smohanty added a comment to D9719: edje/text_class: Add test case for text_class feature.

@smohanty ,

Can you try to add text_class into style, instead of add description in text section ?

style 
      { 
         name: "tb_style";
         base: "font=sans font_size=30 color=#FF0 text_class=custom_text_class";
      }
Aug 25 2019, 6:05 PM · efl
smohanty added a comment to D9719: edje/text_class: Add test case for text_class feature.
In D9719#180355, @zmike wrote:

@smohanty Are you doing anything after those calls? You might accidentally be triggering an edje recalc that reapplies the default class.

Aug 25 2019, 6:02 PM · efl
smohanty added inline comments to D9641: edje/style: optimize style_update function..
Aug 25 2019, 6:00 PM · efl
smohanty added reviewers for D9734: eina/array: added eina_array_find() api to eina_array.: zmike, Hermet, cedric.
Aug 25 2019, 5:34 PM · efl
smohanty requested review of D9734: eina/array: added eina_array_find() api to eina_array..
Aug 25 2019, 5:34 PM · efl

Aug 23 2019

smohanty added a comment to D9715: edje/cache: Refactor _edje_cache_file_coll_open().
In D9715#180358, @zmike wrote:

I think the list -> array should be broken out into a separate patch (using git-phab). Also some other minor nits. Seems fine otherwise though.

Aug 23 2019, 8:05 AM · efl
smohanty added inline comments to D9715: edje/cache: Refactor _edje_cache_file_coll_open().
Aug 23 2019, 8:01 AM · efl

Aug 22 2019

smohanty added a comment to D9719: edje/text_class: Add test case for text_class feature.

@ali.alzyod
I am trying to add a test case to test the below code in edje , but don't know which api to call to test it.

Aug 22 2019, 11:30 PM · efl
smohanty added reviewers for D9719: edje/text_class: Add test case for text_class feature: ali.alzyod, Hermet, cedric.
Aug 22 2019, 11:26 PM · efl
smohanty requested review of D9719: edje/text_class: Add test case for text_class feature.
Aug 22 2019, 11:25 PM · efl
smohanty added reviewers for D9716: ecore_con/memleak: due to checking refcount using postfix decrement operator: Hermet, raster, cedric.
Aug 22 2019, 6:37 PM · efl
smohanty requested review of D9716: ecore_con/memleak: due to checking refcount using postfix decrement operator.
Aug 22 2019, 6:37 PM · efl
smohanty updated the diff for D9715: edje/cache: Refactor _edje_cache_file_coll_open().

edje/optimization: replace eina_list with eina_array.

Aug 22 2019, 5:37 PM · efl
smohanty updated the diff for D9715: edje/cache: Refactor _edje_cache_file_coll_open().

unused var removed.

Aug 22 2019, 5:28 PM · efl
smohanty added reviewers for D9715: edje/cache: Refactor _edje_cache_file_coll_open(): Hermet, raster, cedric.
Aug 22 2019, 5:10 PM · efl
smohanty requested review of D9715: edje/cache: Refactor _edje_cache_file_coll_open().
Aug 22 2019, 5:08 PM · efl

Aug 21 2019

smohanty added a comment to D9700: elm/config: avoid unnecessary elm cache flush.

Looks like this is a copy paste error by looking at the position of _elm_recache() function in all 3 places.

Aug 21 2019, 11:39 PM · efl
smohanty added reviewers for D9700: elm/config: avoid unnecessary elm cache flush: Hermet, raster, cedric.
Aug 21 2019, 11:35 PM · efl
smohanty requested review of D9700: elm/config: avoid unnecessary elm cache flush.
Aug 21 2019, 11:34 PM · efl
smohanty renamed T8170: Memory leak in efl_ui_focus_manager. from valgraind shows memory leak in efl_ui_focus_manager to Memory leak in efl_ui_focus_manager..
Aug 21 2019, 9:30 PM