Page MenuHomePhabricator

smohanty (Subhransu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 22 2013, 8:52 PM (352 w, 5 d)
Availability
Available

Recent Activity

Aug 4 2020

smohanty closed T8748: Performance Issue in ELM_WIDGET_ITEM_STATIC_FOCUS_CLASS class as Resolved.

Patch from Raster fixed the performance issue. hence closing.

Aug 4 2020, 6:42 PM

Jun 16 2020

smohanty closed D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..
Jun 16 2020, 11:57 PM · efl
smohanty closed D11985: elementary/perf:remove unnecessary elm_widget_is() check.
Jun 16 2020, 11:57 PM · efl
smohanty added a comment to D11985: elementary/perf:remove unnecessary elm_widget_is() check.

Thank you. I checked upstream that we do not assigned parent_obj *ever* by hand. And we don't. Can you ensure the same in tizen ?

Jun 16 2020, 11:52 PM · efl
smohanty updated the summary of D11985: elementary/perf:remove unnecessary elm_widget_is() check.
Jun 16 2020, 11:37 PM · efl
smohanty updated the diff for D11985: elementary/perf:remove unnecessary elm_widget_is() check.

updated review comment.

Jun 16 2020, 11:36 PM · efl
smohanty added a comment to D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

have also updated this patch for last review comment. please check if this is what you intended.

Jun 16 2020, 11:30 PM · efl
smohanty added inline comments to D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..
Jun 16 2020, 11:29 PM · efl
smohanty updated the diff for D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

updated review comment

Jun 16 2020, 11:28 PM · efl
smohanty updated the diff for D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

updated review comment.

Jun 16 2020, 11:22 PM · efl
smohanty added inline comments to D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..
Jun 16 2020, 11:15 PM · efl
smohanty added reviewers for D11985: elementary/perf:remove unnecessary elm_widget_is() check: Hermet, id213sin, CHAN.
Jun 16 2020, 10:49 PM · efl
smohanty requested review of D11985: elementary/perf:remove unnecessary elm_widget_is() check.
Jun 16 2020, 10:48 PM · efl
smohanty added reviewers for D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls.: Hermet, id213sin.
Jun 16 2020, 10:29 PM · efl
smohanty requested review of D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..
Jun 16 2020, 10:28 PM · efl

Jun 8 2020

smohanty added a comment to T8742: Memory leak in evas_object_textblock_style_set().

thanks

Jun 8 2020, 10:42 PM
smohanty awarded D11944: elementary_test: remove leaked style a Like token.
Jun 8 2020, 10:42 PM · efl
smohanty created T8748: Performance Issue in ELM_WIDGET_ITEM_STATIC_FOCUS_CLASS class.
Jun 8 2020, 6:41 PM
smohanty added a comment to D11945: evas_common_font: release reallocated glyphs bitmaps data.

Thanks for the patch . Yup this fix the the leak.

Jun 8 2020, 6:10 PM · efl
smohanty updated subscribers of T8742: Memory leak in evas_object_textblock_style_set().

@ali ,
I didn't know evas_object_textblock_style_set() only keeps the reference to the raw pointer.

Jun 8 2020, 6:02 PM

Jun 7 2020

smohanty updated subscribers of T8742: Memory leak in evas_object_textblock_style_set().
Jun 7 2020, 8:57 PM
smohanty updated subscribers of T8743: Memory leak in evas_common_font_int_cache_glyph_render.
Jun 7 2020, 8:57 PM
smohanty created T8743: Memory leak in evas_common_font_int_cache_glyph_render.
Jun 7 2020, 8:57 PM
smohanty created T8742: Memory leak in evas_object_textblock_style_set().
Jun 7 2020, 8:40 PM

Jun 4 2020

smohanty updated the diff for D11930: gengrid: Fix memory leak.

updated

Jun 4 2020, 12:33 AM · efl
smohanty added a reviewer for D11930: gengrid: Fix memory leak: SanghyeonLee.
Jun 4 2020, 12:26 AM · efl
smohanty requested review of D11930: gengrid: Fix memory leak.
Jun 4 2020, 12:25 AM · efl

Jun 3 2020

smohanty added reviewers for D11928: elementary/example: Fix memory leak in gengrid test: Hermet, SanghyeonLee.
Jun 3 2020, 7:21 PM · efl
smohanty requested review of D11928: elementary/example: Fix memory leak in gengrid test.
Jun 3 2020, 7:20 PM · efl
smohanty added reviewers for D11927: ecore_ipc: Fix memory leak: Hermet, raster, bu5hm4n.
Jun 3 2020, 7:01 PM · efl
smohanty requested review of D11927: ecore_ipc: Fix memory leak.
Jun 3 2020, 7:00 PM · efl

Jun 2 2020

smohanty added a reviewer for D11915: evas/engine: Fix memory leak in generic cache.: Hermet.
Jun 2 2020, 8:46 PM · efl
smohanty requested review of D11915: evas/engine: Fix memory leak in generic cache..
Jun 2 2020, 8:45 PM · efl
smohanty added a reviewer for D11914: ecore: Fix Asan stack overflow warning: Hermet.

Logs:

Jun 2 2020, 7:10 PM · efl
smohanty requested review of D11914: ecore: Fix Asan stack overflow warning.
Jun 2 2020, 7:09 PM · efl
smohanty changed the visibility for D11910: elementary_test: Added --autoclose option to elementary_test.
Jun 2 2020, 1:47 AM · efl

Jun 1 2020

smohanty closed D11888: eo: Fix memory leak in efl_key_wref_set() api..
Jun 1 2020, 11:08 PM · efl
smohanty changed the visibility for D11910: elementary_test: Added --autoclose option to elementary_test.
Jun 1 2020, 9:31 PM · efl
smohanty updated the diff for D11910: elementary_test: Added --autoclose option to elementary_test.

updated

Jun 1 2020, 7:29 PM · efl
smohanty added a reviewer for D11910: elementary_test: Added --autoclose option to elementary_test: Hermet.
Jun 1 2020, 7:23 PM · efl
smohanty requested review of D11910: elementary_test: Added --autoclose option to elementary_test.
Jun 1 2020, 7:22 PM · efl
smohanty added a reviewer for D11909: elementary: Fix memory leak in elm_list: Hermet.
Jun 1 2020, 12:03 AM · efl
smohanty requested review of D11909: elementary: Fix memory leak in elm_list.
Jun 1 2020, 12:02 AM · efl

May 31 2020

smohanty updated the diff for D11908: svg/loader: Fix memory leak.

properly deallocate the custom command node.

May 31 2020, 11:39 PM · efl
smohanty updated the diff for D11908: svg/loader: Fix memory leak.

fixed one more leak

May 31 2020, 9:59 PM · efl
smohanty added a reviewer for D11908: svg/loader: Fix memory leak: Hermet.
May 31 2020, 9:50 PM · efl
smohanty requested review of D11908: svg/loader: Fix memory leak.
May 31 2020, 9:49 PM · efl

May 28 2020

smohanty added a reviewer for D11905: elementary/example: Fix memory leak in test_genlist example: SanghyeonLee.

the item class is not freed for some test cases . added elm_genlist_item_class_free() for those cases . and incase if we are keeping a ref then unref in the clear_cb().

May 28 2020, 10:19 PM · efl
smohanty requested review of D11905: elementary/example: Fix memory leak in test_genlist example.
May 28 2020, 10:15 PM · efl
smohanty added a comment to D11888: eo: Fix memory leak in efl_key_wref_set() api..

@raster ,
Could you please review this when you have time . I don't know if this is the correct fix but the memory leak shows up in address sanitizer.

May 28 2020, 8:02 PM · efl
smohanty added a reviewer for D11882: elm_gen****: free item_content map: Hermet.
May 28 2020, 7:57 PM · efl

May 27 2020

smohanty added reviewers for D11888: eo: Fix memory leak in efl_key_wref_set() api.: Hermet, raster.

in _eo_key_generic_direct_del() we remove the node from the ext->generic_data . Because of call_free is false we never call _eo_generic_data_node_free() on the node hence the leak.

May 27 2020, 12:43 AM · efl
smohanty requested review of D11888: eo: Fix memory leak in efl_key_wref_set() api..
May 27 2020, 12:40 AM · efl

May 26 2020

smohanty added reviewers for D11887: edje: fix memory leak by freeing the limits pointer.: Jaehyun_Cho, Hermet.
May 26 2020, 10:52 PM · efl
smohanty requested review of D11887: edje: fix memory leak by freeing the limits pointer..
May 26 2020, 10:50 PM · efl

May 25 2020

smohanty added reviewers for D11879: edje: Fix memory leak by freeing the filter data.: Hermet, CHAN.
May 25 2020, 9:51 PM · efl
smohanty requested review of D11879: edje: Fix memory leak by freeing the filter data..
May 25 2020, 9:50 PM · efl
smohanty reassigned T8732: Memory Leak in efl_ui_focus_parent_provider_gen_content_item_map_set() api. from marcelhollerbach to bu5hm4n.
May 25 2020, 6:16 PM

May 24 2020

smohanty assigned T8732: Memory Leak in efl_ui_focus_parent_provider_gen_content_item_map_set() api. to marcelhollerbach.
May 24 2020, 7:39 PM
smohanty created T8732: Memory Leak in efl_ui_focus_parent_provider_gen_content_item_map_set() api..
May 24 2020, 7:38 PM

May 20 2020

smohanty added a comment to D11137: meson: Changed meson build to support address sanitizer build.

From my side I am waiting for feedback from @smohanty

As written before I am fine with the approach as is. If we go the route of disable all leak checks or only suppress the known ones I have no strong opinion.

May 20 2020, 2:36 AM · efl

May 7 2020

smohanty changed the visibility for D11784: evas/optimization: avoid injecting destroyed objects back into evas..
May 7 2020, 6:32 PM · efl
smohanty added a comment to D11784: evas/optimization: avoid injecting destroyed objects back into evas..

Ummm... the object could be in the scene graph for a render cycle, never be shown or rendered and it'll then hang around in the scene graph just like before until some render cycles flush it out, because it will then be flagged as being in the graph and behave just like before.

May 7 2020, 1:22 AM · efl

May 6 2020

smohanty added a reviewer for D11784: evas/optimization: avoid injecting destroyed objects back into evas.: CHAN.
May 6 2020, 10:34 PM · efl
smohanty added reviewers for D11784: evas/optimization: avoid injecting destroyed objects back into evas.: Hermet, raster.
May 6 2020, 10:32 PM · efl
smohanty requested review of D11784: evas/optimization: avoid injecting destroyed objects back into evas..
May 6 2020, 10:32 PM · efl

Apr 27 2020

smohanty added a reviewer for D11761: evas: changed hash to array for avoiding memory allocation.: Hermet.
Apr 27 2020, 10:05 PM · efl
smohanty requested review of D11761: evas: changed hash to array for avoiding memory allocation..
Apr 27 2020, 10:05 PM · efl

Mar 12 2020

smohanty added a comment to D11488: edje: Fix regression in edje textblock style handling..

and with this patch same use case it takes around 80ms mostly due to the Hash Search of Efl_Provider which is same for both cases. ( anyway hash iterator is another story )

Mar 12 2020, 9:50 PM · efl
smohanty added a comment to D11488: edje: Fix regression in edje textblock style handling..

Would you mind adding tests that ensure the behavior that is needed ? otherwise this will break again at some point i guess :/

Mar 12 2020, 8:32 PM · efl
smohanty added a comment to D11488: edje: Fix regression in edje textblock style handling..

@smohanty @woohyun
Is the purpose of this patch speed ? or is there another issue?

Mar 12 2020, 3:23 AM · efl

Mar 11 2020

smohanty added reviewers for D11488: edje: Fix regression in edje textblock style handling.: woohyun, a.srour, bowonryu, CHAN.
Mar 11 2020, 6:58 PM · efl
smohanty requested review of D11488: edje: Fix regression in edje textblock style handling..
Mar 11 2020, 6:56 PM · efl

Feb 24 2020

smohanty added a comment to D11401: edje/style: Fix a problem where embedded font does not load in edj.

indeed solves the issue.

Feb 24 2020, 2:34 AM · efl

Jan 20 2020

smohanty added reviewers for D11137: meson: Changed meson build to support address sanitizer build: Hermet, cedric.
Jan 20 2020, 6:07 PM · efl
smohanty requested review of D11137: meson: Changed meson build to support address sanitizer build.
Jan 20 2020, 6:06 PM · efl

Nov 5 2019

smohanty added inline comments to D10598: edje: implement text_class override at object level.
Nov 5 2019, 4:33 PM · efl

Oct 7 2019

smohanty added a comment to T8302: Memory allocation issue in Evas_Object_Image due to Eina_Cow.

The change to be opaque should really happen once. Only if you switch back and forth for each frame will you continuously allocate memory. Basically you fallback to the case where you do not have any cow.

As I am running an animation (using lottie to render to the buffer ) so each frame I update the buffer (part of evas_image) with below Apis.

Oct 7 2019, 5:53 PM

Oct 3 2019

smohanty added a comment to T8302: Memory allocation issue in Evas_Object_Image due to Eina_Cow.

@cedric ,
Regarding my use case , I am updating image data in every frame by calling evas_object_image_data_get() and evas_object_image_data_set() api . I don't know how Image object can figure out if the content is opaque or not if user has set some pixel data (as it will be expensive to go through each pixel to figure it out) . So maybe we can modify the is_opaque() to return false when user has set some pixel data.

Oct 3 2019, 6:28 PM

Oct 1 2019

smohanty updated subscribers of T8302: Memory allocation issue in Evas_Object_Image due to Eina_Cow.

@cedric ,
What do you think ?

Oct 1 2019, 9:46 PM
smohanty created T8302: Memory allocation issue in Evas_Object_Image due to Eina_Cow.
Oct 1 2019, 9:43 PM

Sep 4 2019

smohanty added a comment to T8195: Memory Issue in edje_cache_emp_alloc() api..

Thanks for the detailed explanation after reading it got little bit more understanding of the current issue with edje memory consumption issue.

Sep 4 2019, 12:45 AM

Sep 1 2019

smohanty updated subscribers of T8195: Memory Issue in edje_cache_emp_alloc() api..

If you guys knows the history of this code, please let me know your opinion.

Sep 1 2019, 10:15 PM
smohanty created T8195: Memory Issue in edje_cache_emp_alloc() api..
Sep 1 2019, 10:12 PM

Aug 31 2019

smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..

hey @smohanty - keep things from getting personal. we DO have guidelines on how to behave: https://www.enlightenment.org/contact . You're not joking here and it's definitely crossing a line.

Aug 31 2019, 5:35 AM · efl

Aug 30 2019

smohanty requested review of D9739: eo/vtable: Fix issue with vtable creation of class..
Aug 30 2019, 5:19 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..
In D9739#182086, @tasn wrote:

What am I seeing in these logs? How were they collected?

Taken a Snapshot of Vtable array (after flattening of function array. ) by just printing the content of chain array (0 - not filled , 1 means filled)
Before Patch and after patch the slots that are filled are same. attached the log

Aug 30 2019, 5:19 PM · efl
smohanty added a comment to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
static inline void
_vtable_chain_merge(Dich_Chain1 *dst, const Dich_Chain1 *src)
{
   size_t j;
   const op_type_funcs *sf = src->chain2->funcs;
   op_type_funcs *df = dst->chain2->funcs;
Aug 30 2019, 5:50 AM · efl
smohanty requested review of D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..

Note for future review comment.

Aug 30 2019, 5:29 AM · efl
smohanty added inline comments to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 30 2019, 2:26 AM · efl
smohanty added a comment to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
In D9794#182033, @tasn wrote:

I don't get this change. Readability is subjective and this doesn't read any more readable to me, and it's 20 lines longer (not that it's the only parameter, but still).
It's also hard to follow when you changed a few unrelated things in one commit (or is it just phab being bad?).

Aug 30 2019, 2:16 AM · efl
smohanty added inline comments to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 30 2019, 2:16 AM · efl
smohanty added inline comments to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 30 2019, 1:57 AM · efl

Aug 29 2019

smohanty added reviewers for D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability.: Hermet, raster, cedric, tasn.
Aug 29 2019, 7:16 PM · efl
smohanty requested review of D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 29 2019, 7:15 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..

Test Done :

 efl eo test suite passed.
elementary_test example works.
Aug 29 2019, 6:11 PM · efl
smohanty updated the diff for D9739: eo/vtable: Fix issue with vtable creation of class..

updated the patch so that it will be a better match to the mental model.

Aug 29 2019, 6:05 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..
In D9739#181840, @tasn wrote:

Could you please fix the formatting in your comment? I'm not sure what you're trying to say there because of the wrong quote and etc. Regarding the MRO: I know it's not the actual MRO, delete the I from there then, it's still the same.

Aug 29 2019, 5:30 PM · efl
smohanty added a comment to D9739: eo/vtable: Fix issue with vtable creation of class..

Rest of the topic will discuss later.

Aug 29 2019, 7:11 AM · efl
smohanty added inline comments to D9769: evas_textblock_edje: replace fixed size array in reparse.
Aug 29 2019, 5:47 AM · efl