The Structure looks ok as most of the changes are in the recognizer. this patch is good to go.

updated

@woohyun , @cedric
We still have some open points
2.How to implement the double tap and triple tap gesture with the current gesture framework ? (As with the current implementation recognizer uses the event from mouse down to mouse up to decide the gesture but in double tap case it has to alive for 2 consecutive touch sequence).

@id213sin , Could you provide your feedback on this patch as well.

@bu5hm4n , could you please look at it again.

updated

updated review comment.

updated review comment

In D5724#97991, @jpeg wrote:

See inline comment: is render_op still useful? can it ever be COPY? in which situations?

In D4933#94270, @bu5hm4n wrote:

How does a widget bahave now if you click into it? Is it also activated then ?

• ector/gl: update the change in ector gl header.
• ector/gl: cleanup the ector gl backend

• ector/gl: added missing gl apis and few custom apis.
• ector/gl: added new gl engine for ector
• ector/gl: use new gl engine for the ector gl backend ector.
• ector/gl: update the change in ector gl header.
• ector/gl: cleanup the ector gl backend

• ector/gl: added missing gl apis and few custom apis.
• ector/gl: added new gl engine for ector
• ector/gl: use new gl engine for the ector gl backend ector.
• ector/gl: update the change in ector gl header.

All the commits are landed in the master hence closing the revision.

• triangulator:Added stroke_set api to the triangulator_stroker.
• ector: move gradient generation api to draw library for reuse.
• evas/common: added a generic cache in evas common.
• evas/vg: added support for engine surface cache.
• evas/engine: added new engine api for ector
• evas/vg: refactor ector engine api and backend .
• evas/vg: use surface cache for efl vg canvas

All the patch are landed in master hence abandoning the review.

• triangulator:Added stroke_set api to the triangulator_stroker.
• ector: move gradient generation api to draw library for reuse.
• evas/engine: Added a generic cache for caching engine surfaces.
• evas/engine: added new engine api for ector

The Tree is in the sense of grouping of drawable item not same as the widget tree so that the renderer can use fast path for drawing those.

Have a look at this then we can discuss
http://doc.qt.io/qt-5/qtquick-visualcanvas-scenegraph-renderer.html

In T6324#104064, @cedric wrote:

1. I think it is best for the future and force us to have some clean API (instead of how evas backend did turn).

I agree with the class hierarchy we need to keep it in that way. but am thinking the ector object are kind of low level object which need not be a eo object.
we can write the class hierarchy in C or it will be awesome if you guys allow the ector library can have c++ class :).

I think using the animation framework for svg animation will be a overkill . because theoretically every shape node of the vg tree could have a animation which will result into a animation tree.
I was thinking of simple solution of 1 animation which goes through the animation node tree and calculates the final value which will update the corresponding vg node. each animation node will keep its duration, repeat and property value , and gets the input as time_elapsed from the main animation object and decide if it needs to update the property of the corresponding shape object or not.
What your opinion about it ?

Well its a subset of the mask but the implementation will be totally different when you take the end to end pipeline (from svg parsing to final draw.)

Well we need the image but its not a must . we know how to draw the vg tree in a buffer . so we can use temporary buffer to draw the mask tree and then use that as mask to draw the sub tree that is masked.

• triangulator:Added stroke_set api to the triangulator_stroker.
• ector: move gradient generation api to draw library for reuse.
• evas/engine: Added a generic cache for caching engine surfaces.
• evas/engine: added new engine api for ector

@raster My bad .. have updated the commit to fix the same.

• evas/font: remove font_dir related function from evas_common_private header
• evas/font: remove evas internal dependancy from evas_font_ot

@bu5hm4n could you please review it .

In D5419#92410, @raster wrote:

did you actually compile this?:

In file included from ../src/lib/evas/common/evas_text_utils.h:19:0,
                 from ../src/lib/evas/common/evas_font.h:54,
                 from lib/evas/canvas/evas_font_dir.c:16:
../src/lib/evas/common/evas_font_ot.h:20:4: error: unknown type name ‘Evas_Coord’
    Evas_Coord x_offset;
    ^~~~~~~~~~
../src/lib/evas/common/evas_font_ot.h:21:4: error: unknown type name ‘Evas_Coord’
    Evas_Coord y_offset;
    ^~~~~~~~~~

• evas/font: remove evas internal dependancy from evas_font_query
• evas/font: move glyph draw implementation to evas_font_draw
• evas/font: remove evas internal dependancy from evas_font_compress
• evas/font: remove evas internal dependancy from evas_font_main
• evas/font: add a new log domain for evas_font
• evas/font: remove evas internal dependancy from evas_font_ot
• evas/font: remove font_dir related function from evas_common_private header

• evas/font: remove evas internal dependancy from evas_font_query
• evas/font: move glyph draw implementation to evas_font_draw
• evas/font: remove evas internal dependancy from evas_font_compress
• evas/font: remove evas internal dependancy from evas_font_main
• evas/font: remove evas internal dependancy from evas_font_ot
• evas/font: remove font_dir related function from evas_common_private header

• evas/font: move glyph draw implementation to evas_font_draw
• evas/font: remove evas internal dependancy from evas_font_compress

• evas/font: remove evas internal dependancy from evas_font_query

added a new commit to fix coding style in evas_font_dir

My editor is set to auto remove the trailing space so just ignore those lines :)

created a new review id
https://phab.enlightenment.org/D5419

Will delete this patch and create a new one because of the edje_cc code and i have no idea how to remove it :)
so will let you know the new review id.

added new active property and did rebase.

rebase

• evas/common: move font related structure to evas_font file.
• evas/font: remove unnecessary include from evas_font_private.h.

updated

private branch is devs/subhransu/evas_vg

split the vg caching commit to smaller ones

added missing changes

Please check the branch dev/subhransu/glvg for the commits

@cedric , @jpeg I have updated this by removing the merphing api and most of the review comments except in the svg loader which i will do in a separate patch.
Could you check once more and let me know your feedback.

updated review comment

updated review comments

updated review comment

updated the implementation

removed fill and view class as well as eo prefix

updated all review comment.

renamed the internal functions.

force a redraw when new root node is set.

Removed the evas_vg_root_node class. Now the root node is evas_vg_container and the life cycle is managed by th vg canvas class