- User Since
- Jan 28 2013, 1:14 AM (295 w, 17 h)
Fri, Sep 14
Taking over as I hand edited the patch and pushed
@herdsman this patch is being blocked by your reviews for several months now.
Wed, Sep 5
Mon, Sep 3
Mon, Aug 27
Aug 24 2018
I think @xavi would have liked your explanatio in the commit message (as an updated patch) itself and not only here in the review system.
I am not a fan of keeping the code with an ifdef 0 around. We have way to much of this in efl which stays for years.
Aug 22 2018
Aug 21 2018
Fix wrong resource suffix
With the release done I am open for more experimental work like having heuristics when to build distcheck :-)
This seems to be now part of D6664. In that case we should abandon this one.
I tried again and still no chance to get it applied here.
Aug 20 2018
The origin of the hang in this comes from commit 93228108efaf6097ac680664bdb9158b5cf57499. Bisecting to it took me long enough.
I digged into this. The missing file error has actually nothing to do with the hang you are seeing. That hang comes from a not finishing operation in the shot engine we use for generating the screenshots for the documentation.
I edited the title to reflect that the doc build is broken and not the normal EFL build.
Aug 17 2018
The latest review comment from Andrew seems to be taken care of and the simplified patch still fixes the issue.
Even if Andrew did not give his final ack I am making a call here and pull this in before I do the release. Worst case we need to follow up and backport for a point release.
Aug 16 2018
@indefini could you give the patch from netstar a try and confirm if it fixed the issue for you?
As I commented in D6664 I think we should not do this kind of heuristics when to run distcheck just before a release. Giving up some build time on CI until the release is out is fine. We can re-visited once that is done.