♟ stefan_schmidt

@JackDanielZ I would see that this get worked on over the next weeks. If you have any other plans (or work in progress changes) please let us know.
@vtorri I had to do some compile fixes to get it working with mingw see D11121, I have not done any runtime testing though

In D11040#209689, @a.srour wrote:

Thank you for not respecting my extra time fixing critical bugs to improve EFL, let's leave the showstopper issue unfixed!

In D11040#209673, @a.srour wrote:

In D11040#209667, @segfaultxavi wrote:

In D11040#209642, @a.srour wrote:

GOLDEN**

Your comment does not help the project in any way.
Please bear in mind that very few of us are native English speakers and we all have to make an effort to understand each other.
Typos in code or documentation should be mercilessly pointed out and corrected. There's no point in bringing up typos in phabricator discussions, though. We're all bound to make them!

Thanks for your comment!
But this patch fixes a critical bug, but we are requested to make changes on test cases (That is passed)! this will delay the patch for unimportant matters; since the test cases are passed and shows if the behavior is wrong or not!

Hope we focus on what is important and for less important matters we should help each other, not trying to find each other's mistakes! together we win

hope you understand my point, Thanks 🙂

Did more testing and the error did not show up again. Seems it was one of the elementary test suite failures we are seeing from time to time and unrelated to the codecov change.
Ready for review.

Feedback on inline loop variables

No semicolon after }

Fixed but Phab did not allow me to update this differential. Seems the change was to different to track it for the tool.
Uploaded as https://phab.enlightenment.org/D10934 again

@ProhtMeyhet thanks for pointing this out! This should actually be fixed the other way around. I did not realise below screen_name was used twice instead of user_name which should be used.
Will fix tomorrow.

Well, it was surely something that was fixable as it is gone now. I suspect one of the leak fixes from @bu5hm4n that got merged recently fixed this.

@maxerba if there are reason that some translations are not listed here feel free to let me know.

I need to put this on hold. I see some odd behaviours in other jobs from time to time. Need to investigate.

Place depratced tags correctly

stefan_schmidt (Stefan Schmidt)Administrator
Minion

Projects

Calendar

Today

Tomorrow

Wednesday

User Details

Recent Activity
View All

Fri, Jan 17

Tue, Jan 14

Fri, Jan 10

Wed, Jan 8

Tue, Dec 31

Mon, Dec 30

Tue, Dec 24

Dec 20 2019

Dec 18 2019

Dec 17 2019

Dec 16 2019

Dec 13 2019

Dec 12 2019

Dec 11 2019

Dec 10 2019

Dec 9 2019

stefan_schmidt (Stefan Schmidt)AdministratorMinion