Page MenuHomePhabricator

stefan_schmidt (Stefan Schmidt)Administrator
Minion

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 28 2013, 1:14 AM (399 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Mon, Sep 21

stefan_schmidt closed D12155: elm_config: don't prepend /tmp/ to file name, eina_file_mkstemp() already takes care of this.
Mon, Sep 21, 2:34 AM · efl
stefan_schmidt accepted D12155: elm_config: don't prepend /tmp/ to file name, eina_file_mkstemp() already takes care of this.
Mon, Sep 21, 2:26 AM · efl

Thu, Sep 17

stefan_schmidt added a comment to D12143: call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0.

@bu5hm4n When I wrote raw diff what I really mean is the file diff plus metatdata like author, commit subject and message, date, etc

Thu, Sep 17, 2:18 AM · efl
stefan_schmidt added a comment to D12143: call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0.

@n3rdopolis Still the same problem. If you can'Ät use git phab or arc please upload the raw git format-patch elsewhere and post the link here.

Thu, Sep 17, 2:01 AM · efl

Wed, Sep 16

stefan_schmidt added a comment to D12143: call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0.

@devilhorns I see.
@n3rdopolis did you upload the patch by pasting in a raw git diff? Or did your use the git phab or arc tools? We have seen this exact problem with the later variant.
If you can't switch to git phab or arc I would suggest that you send a link to the full git format-patch output so we can apply that one.

Wed, Sep 16, 11:11 AM · efl
stefan_schmidt updated subscribers of D12143: call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0.

@devilhorns, @raster you want this in before the final release?

Wed, Sep 16, 5:43 AM · efl
stefan_schmidt closed D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node.
Wed, Sep 16, 5:41 AM · efl
stefan_schmidt closed T8809: evas_object_textblock / elm_entry - line merge up junk characters. as Resolved.
Wed, Sep 16, 5:41 AM · efl
stefan_schmidt accepted D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node.
Wed, Sep 16, 5:40 AM · efl

Thu, Sep 10

stefan_schmidt closed D12134: docs: Correct the mismatched group name in Evas..
Thu, Sep 10, 12:22 AM · efl
stefan_schmidt accepted D12134: docs: Correct the mismatched group name in Evas..
Thu, Sep 10, 12:21 AM · efl

Wed, Sep 9

stefan_schmidt added a reviewer for D12132: eo: fix gdb install dir: bu5hm4n.
Wed, Sep 9, 11:59 PM · efl

Thu, Sep 3

stefan_schmidt closed D12128: docs: Add the missing API page name to elementary and evas.
Thu, Sep 3, 2:18 AM · efl
stefan_schmidt accepted D12128: docs: Add the missing API page name to elementary and evas.
Thu, Sep 3, 2:17 AM · efl

Wed, Sep 2

stefan_schmidt closed D12125: eina file test: check rmdir result. Fix CID 1432267.
Wed, Sep 2, 1:44 AM · efl
stefan_schmidt accepted D12125: eina file test: check rmdir result. Fix CID 1432267.
Wed, Sep 2, 1:44 AM · efl
stefan_schmidt added a comment to D12125: eina file test: check rmdir result. Fix CID 1432267.

The comment suggest that its for a clean up case. So maybe we do not have them around to be cleaned up and thus fail.

Wed, Sep 2, 12:41 AM · efl
stefan_schmidt added a comment to D12125: eina file test: check rmdir result. Fix CID 1432267.

In a normal ninja test run on my local machine:

Wed, Sep 2, 12:38 AM · efl

Tue, Sep 1

stefan_schmidt requested changes to D12125: eina file test: check rmdir result. Fix CID 1432267.

With the variable name fixed the tests still fail for me

Tue, Sep 1, 3:23 AM · efl
stefan_schmidt closed D12123: eeze_mount binary: more secure check extension ('.iso' and not 'iso').
Tue, Sep 1, 12:37 AM · efl
stefan_schmidt closed D12122: ecore_file_can_exec: fix .bat case.
Tue, Sep 1, 12:37 AM · efl
stefan_schmidt accepted D12123: eeze_mount binary: more secure check extension ('.iso' and not 'iso').
Tue, Sep 1, 12:35 AM · efl
stefan_schmidt accepted D12122: ecore_file_can_exec: fix .bat case.
Tue, Sep 1, 12:35 AM · efl

Mon, Aug 31

stefan_schmidt closed D12112: Ecore: more precise implementation of ecore_time_get on Windows.
Mon, Aug 31, 5:25 AM · efl
stefan_schmidt closed D12111: Evil: add gettimeofday().
Mon, Aug 31, 5:25 AM · efl
stefan_schmidt accepted D12111: Evil: add gettimeofday().
Mon, Aug 31, 5:23 AM · efl
stefan_schmidt accepted D12112: Ecore: more precise implementation of ecore_time_get on Windows.
Mon, Aug 31, 5:23 AM · efl
stefan_schmidt added a comment to D12080: fix warning in elm test slider (maybe uninitialized).

Already fixed in master

Mon, Aug 31, 5:16 AM · efl
stefan_schmidt closed D12118: ecore-file: fix ecore_file_can_exec() on Windows.
Mon, Aug 31, 5:09 AM · efl
stefan_schmidt accepted D12118: ecore-file: fix ecore_file_can_exec() on Windows.
Mon, Aug 31, 5:08 AM · efl
stefan_schmidt added inline comments to D12118: ecore-file: fix ecore_file_can_exec() on Windows.
Mon, Aug 31, 3:57 AM · efl
stefan_schmidt closed D12115: eina: Replace remove with rmdir and delete tmpstr.
Mon, Aug 31, 2:17 AM · efl
stefan_schmidt closed D12121: elm_theme: more secure check extension as '.edj' and not 'edj'.
Mon, Aug 31, 2:17 AM · efl
stefan_schmidt accepted D12115: eina: Replace remove with rmdir and delete tmpstr.
Mon, Aug 31, 2:16 AM · efl
stefan_schmidt accepted D12121: elm_theme: more secure check extension as '.edj' and not 'edj'.
Mon, Aug 31, 2:14 AM · efl
stefan_schmidt added a comment to T8751: Coverity issues in CXX bindings, examples and eolian_cxx.

Now would be a good time, as we are in stabilization for 1.25

Mon, Aug 31, 12:16 AM

Aug 20 2020

stefan_schmidt requested changes to D12105: eolian_gen: Add support to response files..

While the tests build error is gone the different signedness warnings are still there

Aug 20 2020, 3:12 AM · efl
stefan_schmidt added a comment to D12107: ecore_exe_posix: add timeout exception to avoid deadlock..

@eagleeye please give code from raster a try. He will land it shortly and we would like confirmation from your side that the issue is really fixed with it. You stated that you can reproduce this in automated testing. We would like to get that confirmed for the release. Thanks

Aug 20 2020, 12:50 AM · efl
stefan_schmidt closed D12023: eina_test_lock.c: Implement clock_gettime for Windows.
Aug 20 2020, 12:37 AM · efl
stefan_schmidt closed D12062: eina: Close file in unlink test.
Aug 20 2020, 12:37 AM · efl
stefan_schmidt accepted D12023: eina_test_lock.c: Implement clock_gettime for Windows.
Aug 20 2020, 12:36 AM · efl
stefan_schmidt accepted D12062: eina: Close file in unlink test.
Aug 20 2020, 12:35 AM · efl
stefan_schmidt added a comment to D12105: eolian_gen: Add support to response files..

Its even more than that. When running the test suite I get the following:

Aug 20 2020, 12:31 AM · efl

Aug 19 2020

stefan_schmidt requested changes to D12105: eolian_gen: Add support to response files..
Aug 19 2020, 10:51 PM · efl
stefan_schmidt added a comment to D12105: eolian_gen: Add support to response files..

Applies now, but shows errors when building:

[1/3252] Compiling C object 'src/bin/eolian/70b716a@@eolian_gen@exe/main.c.o'
../src/bin/eolian/main.c: In function ‘_read_options_from_response_file’:
../src/bin/eolian/main.c:524:22: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  524 |    for (int i = 0; i < file_length; ++i)
      |                      ^
../src/bin/eolian/main.c:543:22: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  543 |    for (int i = 0; i < file_length; ++i)
      |                      ^
../src/bin/eolian/main.c:548:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  548 |              while (i < file_length && contents[i] == '\0')
      |                       ^
../src/bin/eolian/main.c:553:20: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  553 |              if (i >= file_length)
      |                    ^~
Aug 19 2020, 10:50 PM · efl
stefan_schmidt closed D12108: eet test: use eina_file_mkstemp, fix include for vc++.
Aug 19 2020, 7:01 AM · efl
stefan_schmidt closed D12103: eet: Fix 'No OPENSSL_Applink' error message..
Aug 19 2020, 7:01 AM · efl
stefan_schmidt added a comment to D12105: eolian_gen: Add support to response files..

This does not apply to latest HEAD anymore, please rebase.

Aug 19 2020, 7:00 AM · efl
stefan_schmidt accepted D12108: eet test: use eina_file_mkstemp, fix include for vc++.
Aug 19 2020, 6:59 AM · efl
stefan_schmidt accepted D12103: eet: Fix 'No OPENSSL_Applink' error message..
Aug 19 2020, 6:59 AM · efl

Aug 17 2020

stefan_schmidt closed D12075: docs: Correct the wrong API group name in elm_win and elm_glview.
Aug 17 2020, 1:32 AM · efl
stefan_schmidt accepted D12075: docs: Correct the wrong API group name in elm_win and elm_glview.
Aug 17 2020, 1:22 AM · efl
stefan_schmidt closed D12106: eina: Use INVALID_FILE_ATTRIBUTES instead of magic number.
Aug 17 2020, 12:59 AM · efl
stefan_schmidt added a reviewer for D12105: eolian_gen: Add support to response files.: q66.
Aug 17 2020, 12:51 AM · efl
stefan_schmidt accepted D12106: eina: Use INVALID_FILE_ATTRIBUTES instead of magic number.
Aug 17 2020, 12:50 AM · efl

Jul 31 2020

stefan_schmidt added inline comments to D12075: docs: Correct the wrong API group name in elm_win and elm_glview.
Jul 31 2020, 1:27 AM · efl
stefan_schmidt closed D12077: ecore_ipc: remove duplicated condition.
Jul 31 2020, 1:15 AM · efl
stefan_schmidt added a comment to D12077: ecore_ipc: remove duplicated condition.

In addition to the duplicated check free() can handle NULL pointers without problem. No need to check for them.

Jul 31 2020, 1:14 AM · efl
stefan_schmidt accepted D12077: ecore_ipc: remove duplicated condition.
Jul 31 2020, 1:13 AM · efl

Jul 29 2020

stefan_schmidt added inline comments to D12072: efl_ui_focus_manager: reduce the amount of relying on events.
Jul 29 2020, 11:57 PM · efl
stefan_schmidt accepted D12062: eina: Close file in unlink test.

For me, on Linux, this does not fail either. Patch looks sane. @vtorri could you give it another try?

Jul 29 2020, 7:26 AM · efl
stefan_schmidt added inline comments to D12072: efl_ui_focus_manager: reduce the amount of relying on events.
Jul 29 2020, 7:19 AM · efl
stefan_schmidt closed D12071: evas_textblock : return correct value for gfx_filter_get.
Jul 29 2020, 12:53 AM · efl
stefan_schmidt closed D12070: evas_textblock : Remove unneeded code.
Jul 29 2020, 12:52 AM · efl
stefan_schmidt closed D12064: evil: Remove unnecessary delay for evil startup.
Jul 29 2020, 12:52 AM · efl
stefan_schmidt added a comment to D12018: Fix typos - (Part #4).

If you want this to land you would need to rebase. It does not apply.

Jul 29 2020, 12:50 AM · efl
stefan_schmidt accepted D12071: evas_textblock : return correct value for gfx_filter_get.
Jul 29 2020, 12:49 AM · efl
stefan_schmidt added a comment to D12064: evil: Remove unnecessary delay for evil startup.

I am landing this, but you should look into fixing your git commit author

Jul 29 2020, 12:48 AM · efl
stefan_schmidt accepted D12064: evil: Remove unnecessary delay for evil startup.
Jul 29 2020, 12:45 AM · efl
stefan_schmidt accepted D12070: evas_textblock : Remove unneeded code.
Jul 29 2020, 12:45 AM · efl

Jul 28 2020

stefan_schmidt closed D12069: tests: fix eio tests.
Jul 28 2020, 1:06 AM · efl
stefan_schmidt accepted D12069: tests: fix eio tests.

Ah, so that was breaking the release builds :-) Thanks

Jul 28 2020, 1:05 AM · efl
stefan_schmidt added a comment to T8751: Coverity issues in CXX bindings, examples and eolian_cxx.

The remaining 30 cxx related Coverity issues are now making up 30% of the open Coverity we still have. It would be great if you could find some timeslots to look at a few of these.

Jul 28 2020, 12:07 AM

Jul 27 2020

stefan_schmidt closed D12066: evas: remove unused define.
Jul 27 2020, 7:30 AM · efl
stefan_schmidt accepted D12066: evas: remove unused define.
Jul 27 2020, 7:29 AM · efl
stefan_schmidt closed D12065: elementry_test: fix allocation size.
Jul 27 2020, 5:38 AM · efl
stefan_schmidt accepted D12065: elementry_test: fix allocation size.
Jul 27 2020, 5:33 AM · efl
stefan_schmidt added a comment to D12066: evas: remove unused define.

Your commit message is really sparse.

Jul 27 2020, 5:28 AM · efl
stefan_schmidt closed D12068: ci: do not build tests on ci.
Jul 27 2020, 5:26 AM · efl
stefan_schmidt closed D12067: build: warn of faulty check version.
Jul 27 2020, 5:26 AM · efl
stefan_schmidt accepted D12068: ci: do not build tests on ci.
Jul 27 2020, 5:24 AM · efl
stefan_schmidt accepted D12067: build: warn of faulty check version.
Jul 27 2020, 5:24 AM · efl

Jul 17 2020

stefan_schmidt accepted D12057: efl: make all _class_get() functions const.

I think its fine to have all the mechanical changes in the patch here as well. It only took me 5 minutes to review even with this size.

Jul 17 2020, 6:02 AM · efl

Jul 6 2020

stefan_schmidt closed D12042: benchmark: eina: remove outdated ecore_hash.
Jul 6 2020, 8:15 AM · efl
stefan_schmidt added reviewers for D12042: benchmark: eina: remove outdated ecore_hash: bu5hm4n, raster.

We talked about this before. Finally came around to remove it.

Jul 6 2020, 6:54 AM · efl
stefan_schmidt requested review of D12042: benchmark: eina: remove outdated ecore_hash.
Jul 6 2020, 6:51 AM · efl
stefan_schmidt closed D12036: docs: Correct the wrong group name in Edje and Elementary.
Jul 6 2020, 1:55 AM · efl
stefan_schmidt closed D12022: windows: Fix path for file sanitization.
Jul 6 2020, 1:55 AM · efl
stefan_schmidt closed D12017: Fix typos - (Part #3).
Jul 6 2020, 1:53 AM · efl
stefan_schmidt closed D12016: Fix typos - (Part #2).
Jul 6 2020, 1:53 AM · efl
stefan_schmidt accepted D12036: docs: Correct the wrong group name in Edje and Elementary.
Jul 6 2020, 1:52 AM · efl
stefan_schmidt accepted D12022: windows: Fix path for file sanitization.
Jul 6 2020, 1:49 AM · efl
stefan_schmidt accepted D12018: Fix typos - (Part #4).

I am fine with the patch now. Before it can land it needs a rebase though. Does not apply here.

Jul 6 2020, 1:47 AM · efl
stefan_schmidt accepted D12016: Fix typos - (Part #2).
Jul 6 2020, 1:41 AM · efl

Jun 26 2020

stefan_schmidt closed D12033: Native Windows: Eina: Resolve bad comparison while using windows strerror_s.
Jun 26 2020, 8:18 AM · efl
stefan_schmidt accepted D12033: Native Windows: Eina: Resolve bad comparison while using windows strerror_s.
Jun 26 2020, 8:16 AM · efl
stefan_schmidt closed D12031: Windows: fix eina_file_map_new().
Jun 26 2020, 6:42 AM · efl
stefan_schmidt accepted D12031: Windows: fix eina_file_map_new().

Limited review as I have no clue on the windows system side. :-)

Jun 26 2020, 6:40 AM · efl
stefan_schmidt closed D12021: Fix eina file thread test on Windows.
Jun 26 2020, 6:39 AM · efl
stefan_schmidt accepted D12021: Fix eina file thread test on Windows.
Jun 26 2020, 6:36 AM · efl