Page MenuHomePhabricator

stefan_schmidt (Stefan Schmidt)Administrator
Minion

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 28 2013, 1:14 AM (388 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Mon, Jul 6

stefan_schmidt closed D12042: benchmark: eina: remove outdated ecore_hash.
Mon, Jul 6, 8:15 AM · efl
stefan_schmidt added reviewers for D12042: benchmark: eina: remove outdated ecore_hash: bu5hm4n, raster.

We talked about this before. Finally came around to remove it.

Mon, Jul 6, 6:54 AM · efl
stefan_schmidt requested review of D12042: benchmark: eina: remove outdated ecore_hash.
Mon, Jul 6, 6:51 AM · efl
stefan_schmidt closed D12036: docs: Correct the wrong group name in Edje and Elementary.
Mon, Jul 6, 1:55 AM · efl
stefan_schmidt closed D12022: windows: Fix path for file sanitization.
Mon, Jul 6, 1:55 AM · efl
stefan_schmidt closed D12017: Fix typos - (Part #3).
Mon, Jul 6, 1:53 AM · efl
stefan_schmidt closed D12016: Fix typos - (Part #2).
Mon, Jul 6, 1:53 AM · efl
stefan_schmidt accepted D12036: docs: Correct the wrong group name in Edje and Elementary.
Mon, Jul 6, 1:52 AM · efl
stefan_schmidt accepted D12022: windows: Fix path for file sanitization.
Mon, Jul 6, 1:49 AM · efl
stefan_schmidt accepted D12018: Fix typos - (Part #4).

I am fine with the patch now. Before it can land it needs a rebase though. Does not apply here.

Mon, Jul 6, 1:47 AM · efl
stefan_schmidt accepted D12016: Fix typos - (Part #2).
Mon, Jul 6, 1:41 AM · efl

Fri, Jun 26

stefan_schmidt closed D12033: Native Windows: Eina: Resolve bad comparison while using windows strerror_s.
Fri, Jun 26, 8:18 AM · efl
stefan_schmidt accepted D12033: Native Windows: Eina: Resolve bad comparison while using windows strerror_s.
Fri, Jun 26, 8:16 AM · efl
stefan_schmidt closed D12031: Windows: fix eina_file_map_new().
Fri, Jun 26, 6:42 AM · efl
stefan_schmidt accepted D12031: Windows: fix eina_file_map_new().

Limited review as I have no clue on the windows system side. :-)

Fri, Jun 26, 6:40 AM · efl
stefan_schmidt closed D12021: Fix eina file thread test on Windows.
Fri, Jun 26, 6:39 AM · efl
stefan_schmidt accepted D12021: Fix eina file thread test on Windows.
Fri, Jun 26, 6:36 AM · efl

Thu, Jun 25

stefan_schmidt closed D12029: docs: Fix typo in elm_config API reference.
Thu, Jun 25, 12:16 AM · efl
stefan_schmidt accepted D12029: docs: Fix typo in elm_config API reference.
Thu, Jun 25, 12:11 AM · efl
stefan_schmidt closed D11997: eina_array: micro optimize eina_array_push.
Thu, Jun 25, 12:04 AM · efl
stefan_schmidt closed D12019: Fix typos - (Part #5).
Thu, Jun 25, 12:03 AM · efl
stefan_schmidt closed D12015: Fix typos.
Thu, Jun 25, 12:03 AM · efl

Wed, Jun 24

stefan_schmidt accepted D11997: eina_array: micro optimize eina_array_push.
Wed, Jun 24, 2:51 AM · efl
stefan_schmidt added inline comments to D12024: windows: Fix file mapping.
Wed, Jun 24, 2:39 AM · efl
stefan_schmidt added inline comments to D12021: Fix eina file thread test on Windows.
Wed, Jun 24, 2:37 AM · efl
stefan_schmidt added a comment to D12017: Fix typos - (Part #3).

This does not apply without D12016. Wait until that one lands.

Wed, Jun 24, 2:23 AM · efl
stefan_schmidt requested changes to D12018: Fix typos - (Part #4).
Wed, Jun 24, 2:21 AM · efl
stefan_schmidt accepted D12019: Fix typos - (Part #5).
Wed, Jun 24, 2:15 AM · efl
stefan_schmidt accepted D12017: Fix typos - (Part #3).
Wed, Jun 24, 2:13 AM · efl
stefan_schmidt accepted D12015: Fix typos.

Function name changes removed and onyl changes in comments and docs. Looks good now.

Wed, Jun 24, 2:12 AM · efl
stefan_schmidt requested changes to D12016: Fix typos - (Part #2).

For all the a vs. an changes I would like a second opinion. Not a native speaker here, and thus I have my own troubles with it :-)

Wed, Jun 24, 2:12 AM · efl

Tue, Jun 23

stefan_schmidt closed D11970: efl_check.h: Replace stack allocated array by heap allocated.
Tue, Jun 23, 8:22 AM · efl
stefan_schmidt accepted D11970: efl_check.h: Replace stack allocated array by heap allocated.
Tue, Jun 23, 8:20 AM · efl
stefan_schmidt closed D11971: eina_test_file.c: Do not test errno if the function doesn't fail.
Tue, Jun 23, 5:03 AM · efl
stefan_schmidt accepted D11971: eina_test_file.c: Do not test errno if the function doesn't fail.
Tue, Jun 23, 5:03 AM · efl
stefan_schmidt closed D12006: Get rid of trailing whitespaces (14 / 14).
Tue, Jun 23, 2:18 AM · efl
stefan_schmidt closed D12012: Get rid of trailing whitespaces (13 / 14).
Tue, Jun 23, 2:18 AM · efl
stefan_schmidt closed D12011: Get rid of trailing whitespaces (12 / 14).
Tue, Jun 23, 2:16 AM · efl
stefan_schmidt closed D12010: Get rid of trailing whitespaces (11 / 14).
Tue, Jun 23, 2:16 AM · efl
stefan_schmidt closed D12009: Get rid of trailing whitespaces (10 / 14).
Tue, Jun 23, 2:16 AM · efl
stefan_schmidt closed D12007: Get rid of trailing whitespaces (8 / 14).
Tue, Jun 23, 2:14 AM · efl
stefan_schmidt closed D12008: Get rid of trailing whitespaces (9 / 14).
Tue, Jun 23, 2:14 AM · efl
stefan_schmidt closed D12005: Get rid of trailing whitespaces (7 / 14).
Tue, Jun 23, 2:13 AM · efl
stefan_schmidt closed D12004: Get rid of trailing whitespaces (6 / 14).
Tue, Jun 23, 2:13 AM · efl
stefan_schmidt closed D12003: Get rid of trailing whitespaces (5 / 14).
Tue, Jun 23, 2:12 AM · efl
stefan_schmidt closed D12002: Get rid of trailing whitespaces (4 / 14).
Tue, Jun 23, 2:11 AM · efl
stefan_schmidt closed D12001: Get rid of trailing whitespaces (3 / 14).
Tue, Jun 23, 2:10 AM · efl
stefan_schmidt closed D12000: Get rid of trailing whitespaces (2 / 14).
Tue, Jun 23, 2:10 AM · efl
stefan_schmidt closed D11999: Get rid of trailing whitespace (1 / 14).
Tue, Jun 23, 2:10 AM · efl
stefan_schmidt accepted D12006: Get rid of trailing whitespaces (14 / 14).
Tue, Jun 23, 2:09 AM · efl
stefan_schmidt accepted D12012: Get rid of trailing whitespaces (13 / 14).
Tue, Jun 23, 2:08 AM · efl
stefan_schmidt accepted D12011: Get rid of trailing whitespaces (12 / 14).
Tue, Jun 23, 2:00 AM · efl
stefan_schmidt accepted D12002: Get rid of trailing whitespaces (4 / 14).
Tue, Jun 23, 1:49 AM · efl
stefan_schmidt accepted D12010: Get rid of trailing whitespaces (11 / 14).
Tue, Jun 23, 1:36 AM · efl
stefan_schmidt accepted D12009: Get rid of trailing whitespaces (10 / 14).
Tue, Jun 23, 1:35 AM · efl
stefan_schmidt accepted D12008: Get rid of trailing whitespaces (9 / 14).
Tue, Jun 23, 1:35 AM · efl
stefan_schmidt accepted D12007: Get rid of trailing whitespaces (8 / 14).
Tue, Jun 23, 1:34 AM · efl
stefan_schmidt accepted D12005: Get rid of trailing whitespaces (7 / 14).
Tue, Jun 23, 1:33 AM · efl
stefan_schmidt accepted D12004: Get rid of trailing whitespaces (6 / 14).
Tue, Jun 23, 1:33 AM · efl
stefan_schmidt accepted D12003: Get rid of trailing whitespaces (5 / 14).
Tue, Jun 23, 1:32 AM · efl
stefan_schmidt accepted D12000: Get rid of trailing whitespaces (2 / 14).
Tue, Jun 23, 1:28 AM · efl
stefan_schmidt accepted D12001: Get rid of trailing whitespaces (3 / 14).
Tue, Jun 23, 1:28 AM · efl
stefan_schmidt accepted D11999: Get rid of trailing whitespace (1 / 14).
Tue, Jun 23, 1:26 AM · efl
stefan_schmidt added a comment to D11999: Get rid of trailing whitespace (1 / 14).

@elyes please ignore the tabs for now.

Tue, Jun 23, 1:25 AM · efl

Thu, Jun 18

stefan_schmidt closed D11983: Fix ENOMEM message on Windows and solaris.
Thu, Jun 18, 4:45 AM · efl
stefan_schmidt accepted D11983: Fix ENOMEM message on Windows and solaris.

Not the biggest fan of platform ifdef's sprinkled in code, but given its a test case for eina_error I am ok with it.

Thu, Jun 18, 4:42 AM · efl

Wed, Jun 17

stefan_schmidt closed D11956: benchmarks: eina: make sure we do not divide by zero.
Wed, Jun 17, 5:06 AM · efl
stefan_schmidt added a comment to D11956: benchmarks: eina: make sure we do not divide by zero.

We should, agreed. I started to look into it, but ecore_hash is quite entangled with ecore_strings and other parts of the eina_bechmak that it needs some time to pull it apart.
I will land this patch first and add looking into eina_benchmark on my list.

Wed, Jun 17, 5:04 AM · efl
stefan_schmidt closed D11963: tests: eio: make sure we check return value.
Wed, Jun 17, 4:37 AM · efl
stefan_schmidt abandoned D11981: evas_ gl_common: forgotten enable vertex_array_size_check.

Already done

Wed, Jun 17, 4:28 AM · efl
stefan_schmidt updated the diff for D11981: evas_ gl_common: forgotten enable vertex_array_size_check.

Switch patch to enable the check

Wed, Jun 17, 4:27 AM · efl
stefan_schmidt updated the diff for D11981: evas_ gl_common: forgotten enable vertex_array_size_check.

completely remove fucntion

Wed, Jun 17, 1:54 AM · efl
stefan_schmidt added a comment to D11981: evas_ gl_common: forgotten enable vertex_array_size_check.

I am updating this patch to completely remove the unused function

Wed, Jun 17, 1:53 AM · efl

Tue, Jun 16

stefan_schmidt closed D11980: modules: eina: chained_pool: check for NULL before passing it to deref.
Tue, Jun 16, 8:11 AM · efl
stefan_schmidt accepted D11973: meson: add Solaris support.
Tue, Jun 16, 2:57 AM · efl
stefan_schmidt added a comment to D11973: meson: add Solaris support.

It did not break anything for my local Linux build. CI had nothign to complain either: https://travis-ci.org/github/Enlightenment/efl/builds/698853314

Tue, Jun 16, 2:55 AM · efl
stefan_schmidt added a reviewer for D11981: evas_ gl_common: forgotten enable vertex_array_size_check: raster.
Tue, Jun 16, 2:26 AM · efl
stefan_schmidt requested review of D11981: evas_ gl_common: forgotten enable vertex_array_size_check.
Tue, Jun 16, 2:25 AM · efl
stefan_schmidt added a child revision for D11980: modules: eina: chained_pool: check for NULL before passing it to deref: D11981: evas_ gl_common: forgotten enable vertex_array_size_check.
Tue, Jun 16, 2:25 AM · efl
stefan_schmidt requested review of D11980: modules: eina: chained_pool: check for NULL before passing it to deref.
Tue, Jun 16, 2:24 AM · efl

Mon, Jun 15

stefan_schmidt added a commit to T8713: EFL VNC Server patch to build on FreeBSD: rEFLc23befc36dc4: modules: vnc: allow building for FreeBSD with a different header path.
Mon, Jun 15, 6:53 AM · E on FreeBSD, efl
stefan_schmidt added a commit to T8732: Memory Leak in efl_ui_focus_parent_provider_gen_content_item_map_set() api.: rEFLa111e9702cfb: elm_gen****: free item_content map.
Mon, Jun 15, 6:52 AM
stefan_schmidt closed D11978: tests: edje: check result of evas_engine_info_set().
Mon, Jun 15, 6:07 AM · efl
stefan_schmidt closed D11976: modules: gl_x11: ensure we check the result of evas_eglMakeCurrent().
Mon, Jun 15, 6:06 AM · efl
stefan_schmidt requested review of D11978: tests: edje: check result of evas_engine_info_set().
Mon, Jun 15, 4:22 AM · efl
stefan_schmidt planned changes to D11964: tests: eolian: check retrun of remove() call.

Please hold on for this one. I see some troubles in my testing now.

Mon, Jun 15, 4:17 AM · efl
stefan_schmidt added a reviewer for D11956: benchmarks: eina: make sure we do not divide by zero: bu5hm4n.
Mon, Jun 15, 3:58 AM · efl
stefan_schmidt added reviewers for D11964: tests: eolian: check retrun of remove() call: q66, bu5hm4n.
Mon, Jun 15, 3:58 AM · efl
stefan_schmidt added a reviewer for D11963: tests: eio: make sure we check return value: bu5hm4n.
Mon, Jun 15, 3:58 AM · efl
stefan_schmidt added reviewers for D11976: modules: gl_x11: ensure we check the result of evas_eglMakeCurrent(): raster, Hermet, devilhorns.
Mon, Jun 15, 3:57 AM · efl
stefan_schmidt requested review of D11976: modules: gl_x11: ensure we check the result of evas_eglMakeCurrent().
Mon, Jun 15, 3:56 AM · efl
stefan_schmidt added a child revision for D11964: tests: eolian: check retrun of remove() call: D11976: modules: gl_x11: ensure we check the result of evas_eglMakeCurrent().
Mon, Jun 15, 3:56 AM · efl
stefan_schmidt requested changes to D11970: efl_check.h: Replace stack allocated array by heap allocated.

Gettign of a tons of errors with this patch and cxx bindings enabled. One example (there are more):

Mon, Jun 15, 12:52 AM · efl

Fri, Jun 12

stefan_schmidt closed T8713: EFL VNC Server patch to build on FreeBSD as Resolved by committing rEFL192165600791: modules: vnc: allow building for FreeBSD with a different header path.
Fri, Jun 12, 5:49 AM · E on FreeBSD, efl
stefan_schmidt added a comment to T8713: EFL VNC Server patch to build on FreeBSD.

My bad would be here: https://git.enlightenment.org/core/efl.git/commit/?h=devs/stefan/freebsd-fix&id=1921656007914b2bcd0a0d81615225c79aae30df

Fri, Jun 12, 4:42 AM · E on FreeBSD, efl
stefan_schmidt added a comment to T8713: EFL VNC Server patch to build on FreeBSD.

@cederom if you want proper credit for this patch I would need a git format patch.

Fri, Jun 12, 2:34 AM · E on FreeBSD, efl
stefan_schmidt added a comment to T8721: Additional link option needed.

backport done

Fri, Jun 12, 2:33 AM · efl, E on FreeBSD

Thu, Jun 11

stefan_schmidt closed D11968: tests: elm: check return of efl_config_bool_set.
Thu, Jun 11, 7:31 AM · efl
stefan_schmidt requested review of D11968: tests: elm: check return of efl_config_bool_set.
Thu, Jun 11, 4:39 AM · efl
stefan_schmidt added a child revision for D11964: tests: eolian: check retrun of remove() call: D11968: tests: elm: check return of efl_config_bool_set.
Thu, Jun 11, 4:39 AM · efl