- User Since
- Jan 28 2013, 1:14 AM (388 w, 4 d)
Mon, Jul 6
We talked about this before. Finally came around to remove it.
I am fine with the patch now. Before it can land it needs a rebase though. Does not apply here.
Fri, Jun 26
Limited review as I have no clue on the windows system side. :-)
Thu, Jun 25
Wed, Jun 24
This does not apply without D12016. Wait until that one lands.
Function name changes removed and onyl changes in comments and docs. Looks good now.
For all the a vs. an changes I would like a second opinion. Not a native speaker here, and thus I have my own troubles with it :-)
Tue, Jun 23
@elyes please ignore the tabs for now.
Thu, Jun 18
Not the biggest fan of platform ifdef's sprinkled in code, but given its a test case for eina_error I am ok with it.
Wed, Jun 17
We should, agreed. I started to look into it, but ecore_hash is quite entangled with ecore_strings and other parts of the eina_bechmak that it needs some time to pull it apart.
I will land this patch first and add looking into eina_benchmark on my list.
Switch patch to enable the check
completely remove fucntion
I am updating this patch to completely remove the unused function
Tue, Jun 16
It did not break anything for my local Linux build. CI had nothign to complain either: https://travis-ci.org/github/Enlightenment/efl/builds/698853314
Mon, Jun 15
Please hold on for this one. I see some troubles in my testing now.
Gettign of a tons of errors with this patch and cxx bindings enabled. One example (there are more):
Fri, Jun 12
@cederom if you want proper credit for this patch I would need a git format patch.