- User Since
- Jan 28 2013, 1:14 AM (312 w, 1 d)
Wed, Jan 16
Something seems wrong here. When I build and install efl I have the exactness binaries around but they fail to execute:
exactness: error while loading shared libraries: libexactness.so.1: cannot open shared object file: No such file or directory
Please merge into D7590 to make it a buildable patch. The integration into nin ja test can come as separate commit.
A commit that adds over 7000 lines of code should have more than a three work commit message. :-)
Please write why it is moved into the efl tree, also a short description of it for people who have not heard of it and also the revision you based this on from the exactness repo would be good for tracking.
The changes itself are getting my full ACK. I verified that the cxx reorder warnings are gone with it. Thanks.
Once split into two these patches can go in.
I would prefer to have this patch split into two. One for the cxx fix and one for the mono ones.
While this might sound like nitpicking I think these are really different things getting fixed and the subject line of the commit made me think this is only about cxx.
Thu, Jan 10
Wed, Jan 9
I understand the problematic of having the test suite run in the all options enabled build.
Agreed that we need to have a build back with the default options which will also run the test suite.
Mon, Jan 7
I agree with Xavi that we should add something to the comment when this number can be updated. Or do you consider this upper limit fixed without any exceptions?
Dec 19 2018
Dec 17 2018
Dec 7 2018
Looks good now
Fix commit message
Dec 6 2018
I am missing context for what these should be used. In the CI system? For users to ease bootstrap?
Nov 30 2018
It does build fine for EFL (there is a current patch in master which broke macos and windows, thus the revert in this branch. But this is being worked out in master and unrelated).
Nov 28 2018
Nov 27 2018
Nov 23 2018
Nov 22 2018
SanghyeonLee is on vacation right now and this build fix should go in. Its easy enough. I will push it without review in this case.
Nov 21 2018
Thanks for updating the commit message as well.
A rebased patch with a more detailed commits message and the sdl fix merged in can be found here D7320
I think this needs to be combined with the actual merge of misc and wayland to avoid any build failures.
I brought up another patch based on yours D7320
Nov 20 2018
Nov 19 2018
Nov 16 2018
The .travis.yml parts needs a rebase after the cron job addings. Sorry.
This patch can be dropped. The travis cron job solution was done in D7293 and has been landed.
Example build from a normal push: https://travis-ci.org/Enlightenment/efl/builds/455965436
Example build from a cron trigger: https://travis-ci.org/Enlightenment/efl/builds/456000398
Nov 14 2018
Again, to short of a commit message for such a huge commit.
Again, very short commit message. It only describes what the commit does (which I can also see from the code) but it completely ignores why this would be needed.
Please be more expressive in your commit messages.
I am happy to have them moved to Travis cron jobs. But they should only get removed once the cron jobs are up and running, not before.