Page MenuHomePhabricator

stefan_schmidt (Stefan Schmidt)Administrator
Minion

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 28 2013, 1:14 AM (374 w, 5 d)
Roles
Administrator
Availability
Available

Recent Activity

Yesterday

stefan_schmidt closed D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used.
Fri, Apr 3, 1:37 AM · efl
stefan_schmidt accepted D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used.

This looks like a good start.

Fri, Apr 3, 1:22 AM · efl
stefan_schmidt accepted D11629: tests/elm: add helper macros for asserting size and position of objects.
Fri, Apr 3, 1:17 AM · efl
stefan_schmidt accepted D11630: tests/elm: add wrapper for forcing manual render in tests.
Fri, Apr 3, 1:15 AM · efl
stefan_schmidt closed D11564: free memory in clipboard notify event and fix clipboard clear event.
Fri, Apr 3, 1:03 AM · efl
stefan_schmidt added a comment to D11368: emile: fix a potentional resource leaking..

@bu5hm4n, @ProhtMeyhet are you happy with the rebased version now?

Fri, Apr 3, 12:36 AM · efl
stefan_schmidt accepted D11632: tests/hover: add behavior tests for elm_hover.
Fri, Apr 3, 12:34 AM · efl
stefan_schmidt accepted D11631: tests/layout: add explicit test for freeze and thaw no-op correctness.
Fri, Apr 3, 12:31 AM · efl

Thu, Apr 2

stefan_schmidt accepted D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 4:00 AM · efl
stefan_schmidt closed D11636: ci: travis: switch exactness testing to normal test file.
Thu, Apr 2, 3:53 AM · efl
stefan_schmidt requested changes to D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 3:38 AM · efl
stefan_schmidt added a comment to D11637: exactness docs: Add docs, fix docs, remove docs.

Thanks for taking the time and making this usable! :-)

Thu, Apr 2, 3:38 AM · efl

Wed, Apr 1

stefan_schmidt added a reviewer for D11636: ci: travis: switch exactness testing to normal test file: bu5hm4n.
Wed, Apr 1, 6:34 AM · efl
stefan_schmidt requested review of D11636: ci: travis: switch exactness testing to normal test file.
Wed, Apr 1, 6:33 AM · efl

Tue, Mar 31

stefan_schmidt closed D11627: exactness: error when _src_unit is NULL.
Tue, Mar 31, 6:02 AM · efl
stefan_schmidt closed D11624: exactness: equip with ERR and CRIT.
Tue, Mar 31, 6:02 AM · efl
stefan_schmidt closed D11618: exactness: correctly call mkdir.
Tue, Mar 31, 6:01 AM · efl
stefan_schmidt closed D11617: exactness: do not efl_del the evas.
Tue, Mar 31, 6:01 AM · efl
stefan_schmidt closed D11616: exactness_play: introduce runner script.
Tue, Mar 31, 6:01 AM · efl
stefan_schmidt closed D11614: exactness_player: refactor main method.
Tue, Mar 31, 5:59 AM · efl
stefan_schmidt closed D11615: exactness_play: transform to LD_PRELOAD library.
Tue, Mar 31, 5:59 AM · efl
stefan_schmidt closed D11613: exactness: remove code for compiling.
Tue, Mar 31, 5:59 AM · efl
stefan_schmidt closed D11611: exactness_record: introduce runner script.
Tue, Mar 31, 5:58 AM · efl
stefan_schmidt closed D11610: exactness_recorder: move to preload.
Tue, Mar 31, 5:58 AM · efl
stefan_schmidt closed D11623: exactness_recorder: refactor main method.
Tue, Mar 31, 5:58 AM · efl
stefan_schmidt accepted D11627: exactness: error when _src_unit is NULL.
Tue, Mar 31, 5:48 AM · efl
stefan_schmidt accepted D11624: exactness: equip with ERR and CRIT.
Tue, Mar 31, 5:45 AM · efl
stefan_schmidt accepted D11623: exactness_recorder: refactor main method.
Tue, Mar 31, 5:44 AM · efl
stefan_schmidt accepted D11620: Replace strncmp code.

Let's take this patch as one cleanup and if we want to tackle the other patterns we can do as follow up patches.

Tue, Mar 31, 5:41 AM · efl
stefan_schmidt accepted D11616: exactness_play: introduce runner script.
Tue, Mar 31, 5:39 AM · efl
stefan_schmidt accepted D11615: exactness_play: transform to LD_PRELOAD library.
Tue, Mar 31, 5:35 AM · efl
stefan_schmidt accepted D11614: exactness_player: refactor main method.
Tue, Mar 31, 5:33 AM · efl
stefan_schmidt accepted D11610: exactness_recorder: move to preload.
Tue, Mar 31, 5:28 AM · efl

Mon, Mar 30

stefan_schmidt accepted D11618: exactness: correctly call mkdir.

Man, this sneaked in. Glad you found it.

Mon, Mar 30, 5:33 AM · efl
stefan_schmidt accepted D11617: exactness: do not efl_del the evas.
Mon, Mar 30, 5:07 AM · efl
stefan_schmidt added a comment to D11610: exactness_recorder: move to preload.

git phab as trouble applying this. Could you rebase?

Mon, Mar 30, 5:06 AM · efl
stefan_schmidt accepted D11613: exactness: remove code for compiling.
Mon, Mar 30, 5:05 AM · efl
stefan_schmidt closed D11609: exactness_recorder: cleanup code a bit.
Mon, Mar 30, 4:58 AM · efl

Fri, Mar 27

stefan_schmidt closed D11608: ci: enable ecore_con IPv6 tests.
Fri, Mar 27, 7:46 AM · efl
stefan_schmidt closed T8033: exactness as Resolved.

We have a basic exactness running in CI production for a while now.

Fri, Mar 27, 7:27 AM
stefan_schmidt added a comment to D11610: exactness_recorder: move to preload.

the loop exists you mean, right? Might be an idea. I have none in my head right now. Was mostly curious if you had one.

Fri, Mar 27, 7:08 AM · efl
stefan_schmidt added a comment to D11601: ci: travis: enable s390x build on daily cron.

For the record: I added a missing if: type = cron here before landing this

Fri, Mar 27, 7:07 AM · efl
stefan_schmidt closed D11586: travis: enable more archs during cron build.
Fri, Mar 27, 7:06 AM · efl
stefan_schmidt closed D11601: ci: travis: enable s390x build on daily cron.
Fri, Mar 27, 7:06 AM · efl
stefan_schmidt closed D11585: ci: install needed packages for ppc64le builds.
Fri, Mar 27, 7:06 AM · efl
stefan_schmidt accepted D11611: exactness_record: introduce runner script.

Glad that we can leave all the argument, env and file handling to python for this. :-)

Fri, Mar 27, 6:16 AM · efl
stefan_schmidt added inline comments to D11610: exactness_recorder: move to preload.
Fri, Mar 27, 6:16 AM · efl
stefan_schmidt added a comment to D11601: ci: travis: enable s390x build on daily cron.

ping review

Fri, Mar 27, 5:47 AM · efl
stefan_schmidt added a comment to D11586: travis: enable more archs during cron build.

ping review

Fri, Mar 27, 5:47 AM · efl
stefan_schmidt added a comment to D11585: ci: install needed packages for ppc64le builds.

ping review

Fri, Mar 27, 5:46 AM · efl
stefan_schmidt closed T8638: Resource leaks and unitialized variables in text interface support of atspi bridge as Resolved.
Fri, Mar 27, 5:24 AM
stefan_schmidt added a comment to T8638: Resource leaks and unitialized variables in text interface support of atspi bridge.

Fixed with D11607 and D11612

Fri, Mar 27, 5:24 AM
stefan_schmidt accepted D11609: exactness_recorder: cleanup code a bit.
Fri, Mar 27, 5:18 AM · efl
stefan_schmidt closed D11612: elm_atspi_bridge: fix bugs reported by coverity.
Fri, Mar 27, 5:18 AM · efl
stefan_schmidt closed D11607: elm_atspi_bridge: fix bugs reported by coverity Make sure we free allocated resources in the error path. Prevent usage of uninitilized value..
Fri, Mar 27, 5:17 AM · efl
stefan_schmidt accepted D11607: elm_atspi_bridge: fix bugs reported by coverity Make sure we free allocated resources in the error path. Prevent usage of uninitilized value..

Thanks for the updates!

Fri, Mar 27, 5:16 AM · efl
stefan_schmidt accepted D11612: elm_atspi_bridge: fix bugs reported by coverity.
Fri, Mar 27, 5:15 AM · efl
stefan_schmidt added a comment to D11607: elm_atspi_bridge: fix bugs reported by coverity Make sure we free allocated resources in the error path. Prevent usage of uninitilized value..

Ah, now I understand what these sel1 and sel2 changes are doing in here. They are for the uninitialized variable reports.

Fri, Mar 27, 3:27 AM · efl
stefan_schmidt added reviewers for D11608: ci: enable ecore_con IPv6 tests: zmike, bu5hm4n.
Fri, Mar 27, 2:54 AM · efl
stefan_schmidt requested review of D11608: ci: enable ecore_con IPv6 tests.
Fri, Mar 27, 2:54 AM · efl
stefan_schmidt added inline comments to D11607: elm_atspi_bridge: fix bugs reported by coverity Make sure we free allocated resources in the error path. Prevent usage of uninitilized value..
Fri, Mar 27, 2:39 AM · efl
stefan_schmidt added a comment to D11607: elm_atspi_bridge: fix bugs reported by coverity Make sure we free allocated resources in the error path. Prevent usage of uninitilized value..

For the commit message we prefer subject line prefixes. Given this is a hugfe project it helps to understand where it applies to.
For Coverity fixes it is also good style to give the IDs in the commit message so people can refer to them later on. e.g.

Fri, Mar 27, 2:28 AM · efl
stefan_schmidt requested changes to D11607: elm_atspi_bridge: fix bugs reported by coverity Make sure we free allocated resources in the error path. Prevent usage of uninitilized value..
Fri, Mar 27, 2:28 AM · efl

Thu, Mar 26

stefan_schmidt accepted D11593: eo: use eina_prefetch.
Thu, Mar 26, 10:14 AM · efl
stefan_schmidt triaged T8638: Resource leaks and unitialized variables in text interface support of atspi bridge as High priority.
Thu, Mar 26, 5:52 AM
stefan_schmidt added inline comments to D11603: eina: prefetch for _eo_obj_pointer_get.
Thu, Mar 26, 5:31 AM · efl
stefan_schmidt accepted D11591: eo: there is no reason to equip for calls to classes.

I have not much confidence in myself when it comes to eo. The re-flow of the code without is_obj looks correct to me, though.

Thu, Mar 26, 5:29 AM · efl
stefan_schmidt added a comment to D11593: eo: use eina_prefetch.

Hmm, again wondering how you measure this.

Thu, Mar 26, 5:18 AM · efl
stefan_schmidt added a comment to D11592: eo: move all call assignment.

This looks fine to me, but I wonder how are you measuring the cache hits and misses?

Thu, Mar 26, 5:17 AM · efl

Wed, Mar 25

stefan_schmidt added a comment to D11566: eo: do not allocate too much memory.

Duplicate from something we already landed?

Wed, Mar 25, 12:36 PM · efl
stefan_schmidt added a comment to D11568: eo: do not null out the vtable chain of your own classes.

Duplicate from something we already landed?

Wed, Mar 25, 12:36 PM · efl
stefan_schmidt added a comment to D11569: eo: do not NULL out the object itself.

Duplicate from something we already landed?

Wed, Mar 25, 12:36 PM · efl
stefan_schmidt added a comment to D11570: eo: do no allocate a 0 sized segment.

Duplicate from something we already landed?

Wed, Mar 25, 12:35 PM · efl
stefan_schmidt added reviewers for D11601: ci: travis: enable s390x build on daily cron: zmike, bu5hm4n.
Wed, Mar 25, 12:34 PM · efl
stefan_schmidt added reviewers for D11586: travis: enable more archs during cron build: zmike, bu5hm4n.
Wed, Mar 25, 12:34 PM · efl
stefan_schmidt added reviewers for D11585: ci: install needed packages for ppc64le builds: zmike, bu5hm4n.
Wed, Mar 25, 12:33 PM · efl
stefan_schmidt accepted D11600: exactness: handbuild a new argv array instead of reassemling the new one.

Thanks!

Wed, Mar 25, 9:59 AM · efl
stefan_schmidt added a comment to D11600: exactness: handbuild a new argv array instead of reassemling the new one.

Passing CI testing: https://travis-ci.org/github/Enlightenment/efl/jobs/666869511

Wed, Mar 25, 9:58 AM · efl
stefan_schmidt added a comment to D11601: ci: travis: enable s390x build on daily cron.

https://travis-ci.org/github/Enlightenment/efl/builds/666839615

Wed, Mar 25, 9:54 AM · efl
stefan_schmidt requested review of D11601: ci: travis: enable s390x build on daily cron.
Wed, Mar 25, 9:53 AM · efl
stefan_schmidt added a child revision for D11586: travis: enable more archs during cron build: D11601: ci: travis: enable s390x build on daily cron.
Wed, Mar 25, 9:52 AM · efl
stefan_schmidt requested changes to D11600: exactness: handbuild a new argv array instead of reassemling the new one.

We have a very similar construct in player.c line 1086ff it would be good to rool the change for it in here as well.

Wed, Mar 25, 8:08 AM · efl
stefan_schmidt added a comment to D11586: travis: enable more archs during cron build.

For ppc64le its working fine with these two patches: https://travis-ci.org/github/Enlightenment/efl/builds/666437724

Wed, Mar 25, 6:31 AM · efl

Tue, Mar 24

stefan_schmidt requested review of D11586: travis: enable more archs during cron build.
Tue, Mar 24, 11:30 AM · efl
stefan_schmidt added a child revision for D11585: ci: install needed packages for ppc64le builds: D11586: travis: enable more archs during cron build.
Tue, Mar 24, 11:29 AM · efl
stefan_schmidt requested review of D11585: ci: install needed packages for ppc64le builds.
Tue, Mar 24, 11:29 AM · efl
stefan_schmidt accepted D11577: eo: only really copy when there is content.
Tue, Mar 24, 9:53 AM · efl
stefan_schmidt accepted D11576: eo: correctly flag allocated memory.
Tue, Mar 24, 9:52 AM · efl
stefan_schmidt accepted D11575: eo: do no allocate a 0 sized segment.
Tue, Mar 24, 9:51 AM · efl
stefan_schmidt accepted D11573: eo: do not null out the vtable chain of your own classes.
Tue, Mar 24, 9:50 AM · efl
stefan_schmidt accepted D11574: eo: do not NULL out the object itself.
Tue, Mar 24, 9:48 AM · efl
stefan_schmidt accepted D11571: eo: do not allocate too much memory.
Tue, Mar 24, 9:46 AM · efl
stefan_schmidt accepted D11572: edje_cc: free ecore_evas.
Tue, Mar 24, 9:43 AM · efl
stefan_schmidt accepted D11580: eo: free vtable when erroring out.
Tue, Mar 24, 9:39 AM · efl
stefan_schmidt accepted D11579: eo: do not check this here.
Tue, Mar 24, 9:36 AM · efl
stefan_schmidt accepted D11578: eo: fix wrong formatting.
Tue, Mar 24, 9:36 AM · efl
stefan_schmidt closed D11558: exactness: switch from homegrown debug printf to eina_log.
Tue, Mar 24, 4:24 AM · efl
stefan_schmidt closed D11545: exactness: remove exactness library and move code into binary folder.
Tue, Mar 24, 4:24 AM · efl

Mon, Mar 23

stefan_schmidt requested review of D11558: exactness: switch from homegrown debug printf to eina_log.
Mon, Mar 23, 9:48 AM · efl
stefan_schmidt added a child revision for D11545: exactness: remove exactness library and move code into binary folder: D11558: exactness: switch from homegrown debug printf to eina_log.
Mon, Mar 23, 9:48 AM · efl