Page MenuHomePhabricator

subodh6129 (Subodh Kumar)
Subodh

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 18 2014, 4:50 AM (274 w, 1 d)
Availability
Available

Recent Activity

Jul 23 2019

subodh6129 added a comment to D9378: [elm] Add missing sizing eval hook at check.

Actually I followed the old convention, its been little while since I had not contributed.

Jul 23 2019, 2:23 AM · efl
subodh6129 closed D9378: [elm] Add missing sizing eval hook at check.
Jul 23 2019, 1:07 AM · efl
subodh6129 updated the diff for D9378: [elm] Add missing sizing eval hook at check.
  • Revert "[elm] Add missing sizing eval hook at radio"
Jul 23 2019, 12:33 AM · efl
subodh6129 added a comment to D9378: [elm] Add missing sizing eval hook at check.

Can you remove it again from radio then ? (63275dfef864282170e0c30d765eddf3ee41cd27)

It seems unnecessary to have it in both.

Jul 23 2019, 12:23 AM · efl
subodh6129 requested review of D9378: [elm] Add missing sizing eval hook at check.
Jul 23 2019, 12:18 AM · efl

Jul 19 2019

subodh6129 added reviewers for D9356: [elm] Add missing sizing eval hook at radio: Hermet, bu5hm4n, cedric, zmike.
Jul 19 2019, 12:49 AM · efl
subodh6129 requested review of D9356: [elm] Add missing sizing eval hook at radio.
Jul 19 2019, 12:48 AM · efl

Jul 15 2019

subodh6129 abandoned D5721: elementary: Fix textblock empty check logic.
Jul 15 2019, 3:11 AM · efl

Jul 12 2019

subodh6129 updated the diff for D9115: [edje] Add support for map zoom to use other part center..
  • example edc added to build list
Jul 12 2019, 6:24 AM · efl
subodh6129 updated the diff for D9115: [edje] Add support for map zoom to use other part center..

example updated

Jul 12 2019, 2:20 AM · efl

Jun 19 2019

subodh6129 updated the summary of D9115: [edje] Add support for map zoom to use other part center..
Jun 19 2019, 9:44 PM · efl
subodh6129 updated the diff for D9115: [edje] Add support for map zoom to use other part center..

Fix typo

Jun 19 2019, 9:40 PM · efl
subodh6129 added a reviewer for D9115: [edje] Add support for map zoom to use other part center.: cedric.
Jun 19 2019, 5:40 AM · efl
subodh6129 requested review of D9115: [edje] Add support for map zoom to use other part center..
Jun 19 2019, 5:39 AM · efl

Jun 18 2019

subodh6129 added a comment to D9053: evas_object_textblock: add support for variation sequences.

@ali.alzyod
Small query here,
why do you need separate caching logic for variation sequence? Can't it be accommodated in the current logic?

-because variation sequences can vary from ( 0xFE00-0xFE0F , 0xE0100-0xE01EF, 0x180B-0x180D), So I think create hashing tables for these values for each character (or characters that could have variation sequences) will consume more memory, and logic will become more complicated where one Unicode value could have many variation sequences.

-So I thought of binary search as good solution where we will keep old logic as it is, and if character has variation sequence it will be added to variation sequence sorted list, and accessing will be fast specially list will be small for each unicode value.

Jun 18 2019, 5:40 AM · efl

Jun 17 2019

subodh6129 added a comment to D9053: evas_object_textblock: add support for variation sequences.

@ali.alzyod
Small query here,
why do you need separate caching logic for variation sequence? Can't it be accommodated in the current logic?

Jun 17 2019, 11:50 PM · efl
subodh6129 updated subscribers of D9053: evas_object_textblock: add support for variation sequences.

@herdsman are you there?

Jun 17 2019, 9:43 PM · efl

Jul 17 2018

subodh6129 added inline comments to D5721: elementary: Fix textblock empty check logic.
Jul 17 2018, 10:09 PM · efl
subodh6129 updated the summary of D5721: elementary: Fix textblock empty check logic.
Jul 17 2018, 10:07 PM · efl

Jun 7 2018

subodh6129 added a comment to D6045: edje: Remove hack code.

Well I tested this in Tizen platform and so far there is no issue reported, if you have any abnormal behavior after applying this patch,
Please let me know. Also I am curious about the FIXME comment.

Jun 7 2018, 3:53 AM · efl

Jun 1 2018

subodh6129 added a comment to T3670: Migrating to a new focus system.

please close if its done

Jun 1 2018, 5:27 AM · santa, efl: widgets, efl: input
subodh6129 added a comment to T2696: Inconsistent ellipsis behavior between evas text and evas textblock.

?

Jun 1 2018, 5:18 AM · efl: layout engine, efl: rendering
subodh6129 closed T2992: Bug: Evas text truncated for certain language as Resolved.
Jun 1 2018, 5:18 AM · efl
subodh6129 closed T3015: Genlist with entry is broken as Wontfix.
Jun 1 2018, 5:18 AM · efl: widgets
subodh6129 closed T3191: Cursor over widget item broken as Invalid.
Jun 1 2018, 5:17 AM · efl
subodh6129 closed T4748: Feature request in texblock as Wontfix.

There is way to do that in textblock.

Jun 1 2018, 5:15 AM · efl
subodh6129 closed T5518: Evas textblock markup set/get bug as Resolved.
Jun 1 2018, 5:14 AM · efl
subodh6129 abandoned D3661: Elm entry: Add selection handler bypassing feature..
Jun 1 2018, 5:11 AM · Restricted Project

May 27 2018

subodh6129 closed T5562: elementary: Naviframe mirror bug as Resolved.
May 27 2018, 10:52 PM · efl
subodh6129 closed T5562: elementary: Naviframe mirror bug, a subtask of T6926: Legacy Breaks That Need to Be Fixed for Release, as Resolved.
May 27 2018, 10:52 PM · efl (efl-1.21), regression

May 15 2018

subodh6129 updated subscribers of D6164: edje: Fix to support translation for textblock part.
May 15 2018, 6:26 AM · efl

May 10 2018

subodh6129 added a comment to D6045: edje: Remove hack code.

You can see if we use fit option in textblock part, after whole calculation of edje part objects
we do a special calculation for textblock if it has fit option enabled. This will indeed calculate the textblock size again.
Please check the functions

_edje_part_recalc and _edje_textblock_recalc_apply.
May 10 2018, 6:36 AM · efl

May 7 2018

subodh6129 updated subscribers of D6045: edje: Remove hack code.
May 7 2018, 6:11 AM · efl
subodh6129 added a comment to D6045: edje: Remove hack code.

It will improve performance of fit calculation and moreover
textblock calculation is being done twice.

May 7 2018, 5:27 AM · efl
subodh6129 requested review of D6045: edje: Remove hack code.

Steps to check:

  1. Apply the attach patch
  2. Remove function
_edje_textblock_recalc_apply
  1. Launch elementary_text
  2. Search for genlist->Genlist Group
  3. Resize the window to accommodate whole group index text. (Make it bigger)
  4. Click button "Bring top 477"
  5. Resize the window to so that fit can be applied (make it smaller)
  6. Click on "Show 0" button

Check this image{F3048970}

May 7 2018, 1:38 AM · efl

May 2 2018

subodh6129 updated the summary of D6045: edje: Remove hack code.
May 2 2018, 11:18 PM · efl
subodh6129 abandoned D3631: Entry: Add link pressed tag in entry style.
May 2 2018, 10:14 PM · Restricted Project
subodh6129 abandoned D3561: Elm: Add undo redo class for editable widget..
May 2 2018, 10:13 PM

Apr 10 2018

subodh6129 updated subscribers of D5909: edje: Dont append font source if fonts are not embedded in edje.
Apr 10 2018, 2:58 AM

Apr 9 2018

subodh6129 updated the summary of D5909: edje: Dont append font source if fonts are not embedded in edje.
Apr 9 2018, 11:16 PM

Jan 4 2018

subodh6129 added reviewers for D5721: elementary: Fix textblock empty check logic: id213sin, herdsman.
Jan 4 2018, 5:13 AM · efl
subodh6129 created D5721: elementary: Fix textblock empty check logic.
Jan 4 2018, 5:12 AM · efl

Oct 26 2017

subodh6129 abandoned D5326: [evas] Make precedence of the operator clear..
Oct 26 2017, 5:28 AM

Oct 16 2017

subodh6129 abandoned D5284: [efl] Fix double assigngment..

Removed duplicate patch

Oct 16 2017, 4:35 AM
subodh6129 abandoned D5325: evas: Avoid variable assignment after return..

Useless

Oct 16 2017, 4:32 AM
subodh6129 abandoned D5282: [edje_entry] Fix some code smells..
Oct 16 2017, 4:31 AM
subodh6129 retitled D5283: [ecore] Fix assigned value is never used. from [efl] Fix some code smells. to [ecore] Fix assigned value is never used..
Oct 16 2017, 12:54 AM
subodh6129 updated the diff for D5283: [ecore] Fix assigned value is never used..

Splitted

Oct 16 2017, 12:53 AM
subodh6129 created D5326: [evas] Make precedence of the operator clear..
Oct 16 2017, 12:07 AM
subodh6129 created D5325: evas: Avoid variable assignment after return..
Oct 16 2017, 12:02 AM

Oct 15 2017

subodh6129 retitled D5284: [efl] Fix double assigngment. from [efl] Fix some code smells. to [efl] Fix double assigngment..
Oct 15 2017, 11:58 PM
subodh6129 updated the diff for D5284: [efl] Fix double assigngment..

Spilitted

Oct 15 2017, 11:57 PM
subodh6129 added a comment to D5282: [edje_entry] Fix some code smells..

When we run some static analysis tools, they think after return no statements execute which is true but in this case this is just to avoid compiler warning for unused variable. So I made this patch, although not really required.
One more opinion of yours will let this fly off.

Oct 15 2017, 11:24 PM

Oct 13 2017

subodh6129 closed D5274: [eina] Comparing unsigned integer with less than zero..
Oct 13 2017, 1:05 PM

Oct 10 2017

subodh6129 created D5284: [efl] Fix double assigngment..
Oct 10 2017, 3:51 AM
subodh6129 updated the diff for D5283: [ecore] Fix assigned value is never used..

Fixed more issue.

Oct 10 2017, 2:12 AM
subodh6129 updated the summary of D5283: [ecore] Fix assigned value is never used..
Oct 10 2017, 2:10 AM
subodh6129 updated the summary of D5283: [ecore] Fix assigned value is never used..
Oct 10 2017, 2:10 AM
subodh6129 created D5283: [ecore] Fix assigned value is never used..
Oct 10 2017, 2:10 AM
subodh6129 created D5282: [edje_entry] Fix some code smells..
Oct 10 2017, 1:39 AM

Oct 9 2017

subodh6129 added a comment to D5275: [edje_edit] Duplicate assignment to variable..

Even if the value of

attr_orig_amount
``` and

attr_size_amount

are changed, I am not sure how these will affect the value of

attr_amount

Oct 9 2017, 11:39 PM
subodh6129 closed D5272: [evas] There is no effect of variable assignment while clean up..
Oct 9 2017, 5:21 PM
subodh6129 closed D5271: [ephysic] Comparing with same statement..
Oct 9 2017, 5:21 PM
subodh6129 closed D5270: [emile] Comparing less than zero with unsigned interger..
Oct 9 2017, 5:21 PM
subodh6129 closed D5268: [eina_example] Same expression on both statement..
Oct 9 2017, 5:21 PM
subodh6129 closed D5269: [eina_file] Comparing less than zero with unsigned long int.
Oct 9 2017, 5:21 PM
subodh6129 created D5275: [edje_edit] Duplicate assignment to variable..
Oct 9 2017, 6:45 AM
subodh6129 updated subscribers of D5274: [eina] Comparing unsigned integer with less than zero..
Oct 9 2017, 6:02 AM
subodh6129 created D5274: [eina] Comparing unsigned integer with less than zero..
Oct 9 2017, 6:01 AM

Oct 8 2017

subodh6129 added reviewers for D5272: [evas] There is no effect of variable assignment while clean up.: raster, cedric.
Oct 8 2017, 9:20 PM
subodh6129 created D5272: [evas] There is no effect of variable assignment while clean up..
Oct 8 2017, 9:20 PM
subodh6129 added a reviewer for D5271: [ephysic] Comparing with same statement.: cedric.
Oct 8 2017, 9:04 PM
subodh6129 created D5271: [ephysic] Comparing with same statement..
Oct 8 2017, 9:03 PM
subodh6129 added a reviewer for D5270: [emile] Comparing less than zero with unsigned interger.: cedric.
Oct 8 2017, 8:57 PM
subodh6129 created D5270: [emile] Comparing less than zero with unsigned interger..
Oct 8 2017, 8:57 PM
subodh6129 created D5269: [eina_file] Comparing less than zero with unsigned long int.
Oct 8 2017, 8:48 PM
subodh6129 updated the diff for D5268: [eina_example] Same expression on both statement..

Update accordingly

Oct 8 2017, 8:24 PM

Oct 6 2017

subodh6129 created D5268: [eina_example] Same expression on both statement..
Oct 6 2017, 4:25 AM
subodh6129 retitled D5265: [atspi] Passing NULL to variadic funtion can be undefined. from [atspi] Passing NULL to vriadic funtion can be undefined. to [atspi] Passing NULL to variadic funtion can be undefined..
Oct 6 2017, 12:23 AM

Oct 5 2017

subodh6129 added a reviewer for D5265: [atspi] Passing NULL to variadic funtion can be undefined.: lukasz.stanislawski.
Oct 5 2017, 11:28 PM
subodh6129 created D5265: [atspi] Passing NULL to variadic funtion can be undefined..
Oct 5 2017, 11:27 PM
subodh6129 updated the summary of D5264: [eet] Wrong comparision to less than zero with unsigned integer..
Oct 5 2017, 11:06 PM
subodh6129 created D5264: [eet] Wrong comparision to less than zero with unsigned integer..
Oct 5 2017, 11:05 PM
subodh6129 created D5263: [evas_image] There is no effect of variable assignment outside the function..
Oct 5 2017, 10:23 PM
subodh6129 added a reviewer for D5262: [efreet] unsigned int cannot be compared to less than zero.: raster.
Oct 5 2017, 9:44 PM
subodh6129 created D5262: [efreet] unsigned int cannot be compared to less than zero..
Oct 5 2017, 9:43 PM

Jun 8 2017

subodh6129 created T5562: elementary: Naviframe mirror bug.
Jun 8 2017, 5:17 AM · efl

May 23 2017

subodh6129 created T5518: Evas textblock markup set/get bug.
May 23 2017, 3:23 AM · efl

Oct 20 2016

subodh6129 created T4748: Feature request in texblock.
Oct 20 2016, 3:34 AM · efl
subodh6129 accepted D4321: edje: pass whole text to IMF in case of selection.

Will discuss with keyboard team and if required I will put it as product mobile only code

Oct 20 2016, 2:57 AM

Jul 14 2016

subodh6129 updated subscribers of D3561: Elm: Add undo redo class for editable widget..
Jul 14 2016, 6:51 AM
subodh6129 updated subscribers of D3631: Entry: Add link pressed tag in entry style.
Jul 14 2016, 6:50 AM · Restricted Project

May 11 2016

subodh6129 created T3627: Bug:Entry not selecting single RTL character.
May 11 2016, 7:22 AM · efl

May 9 2016

subodh6129 added a comment to D3661: Elm entry: Add selection handler bypassing feature..

Sorry for late reply.
The better way is to keep the selection handlers' shape when they are bypassed. For example, in normal case the shape would be like this d"""""""""b, and when selection handlers are bypassed it becomes b""""""""d. And we reverse handlers to make them as normal when mouse up is happened (become d''''''''''''b again).

May 9 2016, 10:04 PM · Restricted Project
subodh6129 added a comment to D3543: Edje entry: Do not update anchors outside viewport..

@herdsman
ping?

May 9 2016, 10:00 PM · efl

Feb 20 2016

subodh6129 added a comment to T3069: Bug: Edc with textblock inside scroller not resizing properly..

ping???????
ping???????

Feb 20 2016, 1:11 AM · efl
subodh6129 assigned T3121: elm_spinner_label_format_set crash for some entries to shilpasingh.
Feb 20 2016, 1:08 AM · Restricted Project
subodh6129 added a comment to T3121: elm_spinner_label_format_set crash for some entries.

@axiles
Thanks for reporting :)
Edit:
@shilpasingh
Could you please check if the commit D3720 fixes this or not? Hope it fixes.

Feb 20 2016, 1:07 AM · Restricted Project

Feb 19 2016

subodh6129 added a reviewer for D3719: Elm entry: No use of top object if not editable.: cedric.
Feb 19 2016, 5:08 AM
subodh6129 retitled D3719: Elm entry: No use of top object if not editable. from to Elm entry: No use of top object if not editable..
Feb 19 2016, 5:07 AM