Page MenuHomePhabricator

tasn (Tom Hacohen)Administrator
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 23 2013, 8:14 AM (307 w, 6 d)
Roles
Administrator
Availability
Available

Recent Activity

May 9 2017

tasn added a comment to T5411: Extending Ecrire.

Sorry for not replying earlier, I completely missed this one, as I'm not very active on phab.

May 9 2017, 2:40 AM · Restricted Project

Dec 8 2016

tasn edited the content of Hosting / SSH.
Dec 8 2016, 6:29 AM

Nov 16 2016

tasn added a comment to V27: Where should we hold the Enlightenment Developer Days 2017?.

Just a couple of thoughts:
We already did Edinburgh and Paris recently.
Edinburgh and London are fairly expensive (even with the recent currency devaluation).

Nov 16 2016, 12:44 AM

Oct 19 2016

tasn closed T4740: evas objects leaking in some cases as Resolved by committing rEFL5a659fafd22d: Eo: Fix reference leak when failing to resolve function..
Oct 19 2016, 8:33 AM · enlightenment-git, efl

Sep 30 2016

tasn edited the content of Promise.
Sep 30 2016, 9:56 AM
tasn edited the content of Eolian.
Sep 30 2016, 7:06 AM

Sep 29 2016

tasn edited the content of Promise.
Sep 29 2016, 10:13 AM
tasn edited the content of Promise.
Sep 29 2016, 9:51 AM
tasn edited the content of Promise.
Sep 29 2016, 1:20 AM

Sep 28 2016

tasn edited the content of Promise.
Sep 28 2016, 10:22 AM
tasn edited the content of Promise.
Sep 28 2016, 10:17 AM
tasn edited the content of Promise.
Sep 28 2016, 10:16 AM
tasn edited the content of Promise.
Sep 28 2016, 9:08 AM
tasn edited the content of Promise.
Sep 28 2016, 7:34 AM
tasn edited the content of Promise.
Sep 28 2016, 7:27 AM
tasn edited the content of Promise.
Sep 28 2016, 7:26 AM
tasn created Promise.
Sep 28 2016, 7:19 AM

Sep 19 2016

tasn accepted D4298: eo: fix callback cmp.

Nice catch. :)

Sep 19 2016, 3:34 AM

Sep 12 2016

tasn added a comment to T4227: EFL memory usage - dirty pages from SO files.

There have been a few fixes, we are now at:
00007f661ecea000 116K r---- libelementary.so.1.18.99
00007f661ed07000 32K rw--- libelementary.so.1.18.99

Sep 12 2016, 1:11 AM · Restricted Project

Sep 9 2016

tasn added a comment to T4418: eo incorrectly missing methods present in interface hierarchy.

This should be OK now. Is it?

Sep 9 2016, 1:49 AM · efl

Sep 2 2016

tasn added a comment to T4385: Font weight styles don't affect a output of string when there aren't font faces according to the styles. .

Yes, I think we should go with the second option. Option 1 feels wrong. It's not the poor app's fault that the system is broken. We need to help it.

Sep 2 2016, 7:34 AM · efl: rendering
tasn added a comment to T4418: eo incorrectly missing methods present in interface hierarchy.

Thanks, your second (redacted) log and analysis is very helpful. I'll only be able to take a look next week (hopefully), but this would really help, and more so, it's probably very simple to fix.

Sep 2 2016, 7:33 AM · efl

Aug 23 2016

tasn added a comment to T4385: Font weight styles don't affect a output of string when there aren't font faces according to the styles. .

On the phone/desktop you don't see terminal output when you run an application, you will never see this error as a user of an application. Furthermore, in some cases it can't be done at all (font embedded in the theme, or a specific file). There is no nice graceful way of printing an error from our side. Applications could potentially check and report the lack of fonts, but that's out of scope for us as the GUI toolkit. If you want absolute correct results as an app, deal with it an error, otherwise, we owe it to applications to do the right thing. There is no spec anywhere saying that fonts should come with bold variants, so "runtime embolden" should be considered as a reasonable alternative. More so, it actually is. I doubt fonts will be too screwed.

Aug 23 2016, 3:19 AM · efl: rendering
tasn added a comment to T4385: Font weight styles don't affect a output of string when there aren't font faces according to the styles. .

Yes, using a good font that was designed this way is best. However, such a font is not always available so we try to do our best in accommodating the programmer's request, so we make fonts bold on runtime. It's a fallback to a missing font.

Aug 23 2016, 1:05 AM · efl: rendering

Aug 22 2016

tasn added a comment to T4385: Font weight styles don't affect a output of string when there aren't font faces according to the styles. .

Unless I'm misunderstanding something (or just don't remember the code correctly), I don't see how this has anything to do with fontconfig.

Aug 22 2016, 8:47 AM · efl: rendering
tasn added a comment to T4385: Font weight styles don't affect a output of string when there aren't font faces according to the styles. .

@herdsman, I think you misunderstood the ticket. He's talking about runtime embolden in freetype when the system can't find a bold variant of the chosen font.

Aug 22 2016, 7:23 AM · efl: rendering

Aug 17 2016

tasn added a comment to T4227: EFL memory usage - dirty pages from SO files.

So... More info.

Aug 17 2016, 5:13 AM · Restricted Project
tasn added a comment to T4227: EFL memory usage - dirty pages from SO files.

You misunderstood me, the "not the end of the world" was referring to putting RO data in executable pages. The memory issue is real, and I'm still looking into it. I solved a minor case. Working on the rest.

Aug 17 2016, 4:44 AM · Restricted Project
tasn added a comment to T4227: EFL memory usage - dirty pages from SO files.

OK, after giving it a second look, it seems that it just maps the global consts into the "rx" section, so if it's a global and constant page it would be there. I thought it would separate to non-executable pages, but I guess it's fine to put it in an executable page. So not the end of the world.

Aug 17 2016, 3:34 AM · Restricted Project
tasn added a comment to T4227: EFL memory usage - dirty pages from SO files.

I looked into it a bit. I managed to make some progress, but not a lot.
I managed to reduce a page for each library by removing some static variables in class creation. Just because it's only a page (and to be honest, the amount of memory these variables should take) I don't think that's the culprit. However, after looking a bit more into it, I saw something very suspicious. According to pmap on libefl:

Aug 17 2016, 3:10 AM · Restricted Project
tasn added a comment to T4227: EFL memory usage - dirty pages from SO files.

Oh, I didn't see you said it was private pages (though now I remember we actually talked about it a while back). Hm... OK, I will have to check. Annoying that there's no compiler option/tool to easily see what is mapped to private pages. Maybe I will have to write one. :|

Aug 17 2016, 1:26 AM · Restricted Project

Aug 16 2016

tasn added a comment to T4227: EFL memory usage - dirty pages from SO files.

I just fixed heap usage a bit, but I wonder what this is and where it's coming from.
I still haven't dug deep, been dealing with other more urgent matters. Will hopefully manage to find the issue soon.

Aug 16 2016, 8:41 AM · Restricted Project

Jul 15 2016

tasn edited the content of Git Practices.
Jul 15 2016, 6:48 AM

Jun 20 2016

tasn abandoned D3456: elm_widget: update eo parent when widget parent is changed.

Closed.

Jun 20 2016, 2:44 AM
tasn commandeered D3456: elm_widget: update eo parent when widget parent is changed.

No reply for a while, let's consider this close.

Jun 20 2016, 2:43 AM

May 20 2016

tasn edited the content of Eolian.
May 20 2016, 6:22 AM

May 17 2016

tasn edited the content of Eolian.
May 17 2016, 7:38 AM
tasn edited the content of Eolian.
May 17 2016, 5:46 AM

May 12 2016

tasn edited the content of Git Practices.
May 12 2016, 9:21 AM
tasn edited the content of Eolian.
May 12 2016, 8:13 AM

May 6 2016

tasn added a comment to T3293: Eolian is confused when we don't use base.

@q66, it's already fixed.

May 6 2016, 3:43 AM · efl

May 3 2016

tasn edited the content of Eo.
May 3 2016, 9:07 AM

Apr 28 2016

tasn added a comment to D3909: eo: replace loop_get with interface_get.

"class" is actually a good enough key I guess, because you want the returned type to be of a certain class and for this purpose it shouldn't pose a problem to only have one of each class.

Apr 28 2016, 7:03 AM
tasn accepted D3909: eo: replace loop_get with interface_get.

I like it much better than loop get, that's for sure so it can already go in, but I have a few concerns still.

Apr 28 2016, 5:56 AM

Apr 26 2016

tasn edited the content of Eolian.
Apr 26 2016, 3:14 AM

Apr 18 2016

tasn edited the content of Efl.Canvas.Text (Textblock 2).
Apr 18 2016, 6:28 AM

Apr 14 2016

tasn added a comment to D3863: Evas textblock: fix wrong hyphenation issues with non UTF8 encoded dictionary.

You don't want to convert on your own. Nevermind then. This sucks though.

Apr 14 2016, 2:35 AM · efl

Apr 13 2016

tasn added a comment to T3340: Add Textblock2 object.

I'd much rather you made it a wiki page and made it more descriptive. This is very hard to work with. I have many comments and this feels incomplete. I commented a bit on IRC.

Apr 13 2016, 8:12 AM · efl: widgets, efl: layout engine

Apr 8 2016

tasn closed D3864: Evas: Add evas_language_reinit() API by committing rEFLf4f9753c201c: Evas: Add API to reinit the language and use it in elementary. (authored by id213sin).
Apr 8 2016, 3:26 AM
tasn accepted D3864: Evas: Add evas_language_reinit() API.

Looks good. I just needed to slightly change the documentation of evas_language_reinit(), please take a look at what I did.
I also slightly changed the commit message.

Apr 8 2016, 3:26 AM
tasn added a comment to D3863: Evas textblock: fix wrong hyphenation issues with non UTF8 encoded dictionary.

I'm a bit surprised and sad to see that non-utf8 is actually legal. :( I'd say we should probably just restrict ourselves to utf-8 and open a ticket with upstream. This is quite ridiculous.

Apr 8 2016, 3:07 AM · efl

Apr 7 2016

tasn added a comment to T3423: the EFL do not compile on Windows (master).

vpath: please open a new patch and assign to @raster. This has nothing to do with this issue.

Apr 7 2016, 8:35 AM · efl

Apr 6 2016

tasn reassigned T3423: the EFL do not compile on Windows (master) from raster to jpeg.

I suspect it's another issue with the weak API change. That is, @jpeg's fault. :)

Apr 6 2016, 6:18 AM · efl
tasn added a comment to T3419: Move git.enlightenment.org/core/elementary.git to git.enlightenment.org/legacy/elementary.git.

It was not moved on purpose in order to not break people relying on the git repository for creating packages from commits and tags.

Apr 6 2016, 6:15 AM · Restricted Project

Mar 31 2016

tasn added a comment to T3399: [evas_textblock] Markup translation from <br/> to <ps/>.

This is weird. Could you please provide a test case?

Mar 31 2016, 3:04 AM · efl: widgets

Mar 24 2016

tasn added a commit to T3208: Removing layout keeps 'Apply' button disabled in Keyboard Settings: rEFL23ac20bfce3f: Widgets: remove duplicate declaration of language,changed signal..
Mar 24 2016, 3:13 PM · enlightenment-git, enlightenment20
tasn added a commit to T3208: Removing layout keeps 'Apply' button disabled in Keyboard Settings: rEFL5affad30b4ee: Widgets: remove duplicate declaration of access,changed signal..
Mar 24 2016, 3:13 PM · enlightenment-git, enlightenment20

Mar 11 2016

tasn edited the content of Eo.
Mar 11 2016, 5:38 AM
tasn edited the content of Eo.
Mar 11 2016, 5:14 AM

Mar 8 2016

tasn added a comment to T3248: elementary: improving performance and useability text widgets.

Happy my patches helped. :) It was a stupid regression that shouldn't have been there in the first place...

Mar 8 2016, 7:25 AM · efl: widgets
tasn reopened T3117: Terminology's default font configuration is not quite reasonable as "Open".

I guess you also probably wanted to reopen this.

Mar 8 2016, 7:19 AM · efl, Terminology
tasn added a comment to T3117: Terminology's default font configuration is not quite reasonable.

@raster, I didn't even look at the screenie, just assumed that was the case. :)

Mar 8 2016, 7:18 AM · efl, Terminology

Mar 7 2016

tasn added a comment to T3117: Terminology's default font configuration is not quite reasonable.

@raster, I think we need to optimise for the default case. I know you like having nexus there by default, but maybe we should use a bigger font? Or a bigger version of nexus? You use inhumanly small font sizes on your desktop, you are definitely not the yardstick...

Mar 7 2016, 5:02 AM · efl, Terminology

Mar 4 2016

tasn added a comment to T3248: elementary: improving performance and useability text widgets.

@raster already covered most of it. Label is going to be a thin wrapper around entry with a few different defaults. Performance won't be a problem anymore thanks to eo_add, and everything will be covered with rainbows.

Mar 4 2016, 4:46 AM · efl: widgets

Mar 3 2016

tasn raised the priority of T3241: eolian generates wrong function name in case of @empty implementation in derived class. from Trivial to High.

@q66, this needs fixing.

Mar 3 2016, 7:46 AM · Restricted Project

Mar 2 2016

tasn added a comment to D3747: radio: inherit from elm check.

You can't really have a "changed" interface, because the changed should/would have different event info depending on what has changed. This is an example of a took generic naming that won't work any more. We would need to rename it to "state,changed" or whatever.

Mar 2 2016, 6:24 AM

Feb 29 2016

tasn edited the content of Eo.
Feb 29 2016, 7:25 AM
tasn created Eo.
Feb 29 2016, 6:58 AM
tasn added a comment to D3456: elm_widget: update eo parent when widget parent is changed.

I came up with a solution for the multiple parents while I was in HQ. I discussed it a bit and people seem happy. I'm going to work on Eo4 (more about that soon) in the next few days, but once that's done, I'll tackle the multiple parents thing to be clear and consistent.

Feb 29 2016, 5:59 AM

Feb 22 2016

tasn added a comment to T3195: Scaling Dialog.

Terminology issue is now fixed.

Feb 22 2016, 5:46 PM · enlightenment-git

Feb 19 2016

tasn added a comment to T3195: Scaling Dialog.

I'm not sure what I'm seeing, but per my message to the ML, I found rELM79b6edd1a6ad763258337b7aac5bd7799411bb44 to be buggy and screw up my terminology. Maybe it's related?

Feb 19 2016, 12:55 PM · enlightenment-git

Feb 18 2016

tasn added a comment to D3456: elm_widget: update eo parent when widget parent is changed.

Anddddd one last comment. Sorry for the storm.

Feb 18 2016, 9:10 AM
tasn added a comment to D3456: elm_widget: update eo parent when widget parent is changed.

@JackDanielZ did it in rELMf7086fac95cb557f65a68c34639666397fd6d7d6
I think by accident, but you can never be sure with that menace of a guy. ;P

Feb 18 2016, 9:02 AM
tasn added a comment to D3456: elm_widget: update eo parent when widget parent is changed.

Looks fine, I only have one query. Is parent_obj set by any other means (I think it is)? If so, we should update the eo parent there too.

Feb 18 2016, 9:01 AM
tasn accepted D3693: edje_external: check icon param after other param is set in entry.

This is correct.

Feb 18 2016, 8:10 AM
tasn added a comment to D3688: Evas textblock: Apply scale factor to <linesize>, <linegap> formats.

Looks fine with me. @herdsman, is this ready to go in?

Feb 18 2016, 7:57 AM
tasn added a comment to T3156: Crash in function evas_object_clip_changes_clean while aging test..

Btw, just to clarify something that is kinda related to my original objection to data_ref: using and storing the data directly is a bad idea. We use it internally for optimisations, but it's generally not recommended otherwise, so if your code is using it. Stop.

Feb 18 2016, 7:56 AM · efl
tasn updated subscribers of T3156: Crash in function evas_object_clip_changes_clean while aging test..

Just to update this. As @jpeg checked and found out, data ref doesn't actually ref the object. @cedric wrote it, and didn't do it. I guess it's just there for debug (that's awfully confusing)?

Feb 18 2016, 7:48 AM · efl
tasn added a comment to T3195: Scaling Dialog.

I'm way more comfortable with blaming @cedric than blaming me.

Feb 18 2016, 7:03 AM · enlightenment-git
tasn added a comment to D3707: Evas font: add comparison for fallbacks in evas_font_desc_cmp().

I'm talking about font_callbacks in font_desc, which is what this patch is about, it's following the previous patch, no?

Feb 18 2016, 6:23 AM · efl

Feb 17 2016

tasn added a comment to T2992: Bug: Evas text truncated for certain language.

I know we deal with bearing, and I know some have negative bearing. I was just saying your example was unfair.

Feb 17 2016, 5:32 AM · efl
tasn added a comment to D3707: Evas font: add comparison for fallbacks in evas_font_desc_cmp().

I'm starting to think me letting the patch introducing fallbacks in was a mistake. :|

Feb 17 2016, 4:43 AM · efl
tasn edited the content of Eolian.
Feb 17 2016, 2:28 AM
tasn closed D3704: Evas font: allow ":fallbacks" keyword when Evas parses font keyword by committing rEFLd9b93542cf36: Evas font: allow ":fallbacks" keyword when Evas parses font keyword (authored by id213sin).
Feb 17 2016, 1:25 AM
tasn accepted D3704: Evas font: allow ":fallbacks" keyword when Evas parses font keyword.

I'm letting it in for consistency (and Edje fonts), though you probably want to set the fontconfig font fallbacks in your (tizen) case, and not use this api.

Feb 17 2016, 1:25 AM

Feb 16 2016

tasn added a comment to D3688: Evas textblock: Apply scale factor to <linesize>, <linegap> formats.

Sweet. I know @herdsman had a few minor comments, I wonder why he hasn't posted them yet. Will chase him now.

Feb 16 2016, 5:19 AM
tasn closed D3654: tests: Major code cleanup by committing rEFL66b60da444ad: Test rework (authored by vtorri).
Feb 16 2016, 5:11 AM · efl
tasn added a comment to D3654: tests: Major code cleanup.

This is too big to review here, so we are reviewing externally. Keeping this open for tracking.

Feb 16 2016, 4:47 AM · efl
tasn accepted D3688: Evas textblock: Apply scale factor to <linesize>, <linegap> formats.

Looks good to me. If everything compiles without warnings and tests fail before this and pass now, I'm happy.

Feb 16 2016, 3:20 AM
tasn added a comment to D3654: tests: Major code cleanup.

I agree, and since the new phab update, I can see the change is already split to commits like I asked!

Feb 16 2016, 2:29 AM · efl
tasn requested changes to D3691: Evas TextBlock: scale linesize with current scale..

Many comments to _ami_ on irc.

Feb 16 2016, 12:45 AM

Feb 15 2016

tasn added a comment to T2992: Bug: Evas text truncated for certain language.

@raster, your example from above is not 100% correct, you made it sound as if it was:
(underscore indicates the spacing)
"Hello"
vs.
"Hello_"

Feb 15 2016, 2:51 AM · efl
tasn closed D3445: Evas text: set NULL free'd pointers in evas_object_text_free() by committing rEFLb85ae776335e: Evas text: set NULL free'd pointers in evas_object_text_free() (authored by id213sin).
Feb 15 2016, 2:44 AM

Feb 12 2016

tasn edited the content of Eolian.
Feb 12 2016, 6:12 AM
tasn closed D3674: Evas textblock: Fix _dict_hyphen_load could return an uninitialized pointer by committing rEFL0186f87c4905: Evas textblock: Fix _dict_hyphen_load could return an uninitialized pointer (authored by id213sin).
Feb 12 2016, 1:47 AM

Feb 11 2016

tasn closed D3673: Evas font: Use proper enum value for extrabold by committing rEFLb4f254e1a37d: Evas font: Use proper enum value for extrabold (authored by id213sin).
Feb 11 2016, 2:18 AM

Feb 10 2016

tasn added a comment to D3654: tests: Major code cleanup.

I'll keep it open for now, and maybe i'll get to fixing it up myself. As it is, it can't go in. Commit message is not conforming to our guidelines, and it'll be too hard to review for others reviewing, or for me.

Feb 10 2016, 3:54 AM · efl
tasn added a comment to D3661: Elm entry: Add selection handler bypassing feature..

There is a much easier solution to this problem (that also has the benefit of a better ux), which is what is done on Android. Don't let them swap places, just block it, so back to my example, if you try dragging @ all the way to the right (or bottom for that matter), it becomes:

Feb 10 2016, 2:33 AM · Restricted Project
tasn added a comment to D3590: edje_text: Mirror support for RTL direction..

The big question and reason why we didn't do it still remains. This isn't done on textblock, should it be done only here?

Feb 10 2016, 2:28 AM

Feb 9 2016

tasn edited the content of Documentation System.
Feb 9 2016, 7:03 AM