Page MenuHomePhabricator

taxi2se (SungTaek Hong)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 20 2015, 10:34 PM (203 w, 2 d)
Availability
Available

Recent Activity

May 2 2018

taxi2se abandoned D5777: TEMP: Efl.Ui.Nstate: radio and check inherit Nstate properly.

no longer active

May 2 2018, 5:40 PM · efl
taxi2se abandoned D5765: PROTOTYPE: Efl.Ui.Widget: implement Efl.Gfx.Color_Class.

no longer active

May 2 2018, 5:39 PM · efl

Feb 14 2018

taxi2se closed D5798: efl.ui.layout: change signal name for icon/text.
Feb 14 2018, 12:47 PM

Feb 7 2018

taxi2se closed D5797: efl_part: use efl_ui_widget's default_part_get.
Feb 7 2018, 10:15 PM
taxi2se updated the diff for D5797: efl_part: use efl_ui_widget's default_part_get.

remove redundant line

Feb 7 2018, 9:42 PM

Feb 5 2018

taxi2se added a comment to D5782: elementary: fix legacy widget type name for backward compat.

Until efl-1.18, eolian replaces namespace separator '.' to '_'.
So the classname would be like

Feb 5 2018, 11:29 PM

Jan 31 2018

taxi2se updated the diff for D5777: TEMP: Efl.Ui.Nstate: radio and check inherit Nstate properly.

remove redundant accessibility code

Jan 31 2018, 5:21 AM · efl

Jan 30 2018

taxi2se closed D5766: edje_object: fix typo in EAPI edje_object_color_class_description_get.
Jan 30 2018, 12:01 AM
taxi2se closed D5741: elm_test: add elementary_test for Efl.Ui.Button.
Jan 30 2018, 12:01 AM
taxi2se closed D5742: Efl.Ui.Image: remove previous image when NULL is set.
Jan 30 2018, 12:01 AM

Jan 29 2018

taxi2se added a comment to T6639: elm_check triggers "changed" signal twice on click.

Update D5768 as a fix.

Jan 29 2018, 2:48 AM · regression, efl
taxi2se added a revision to T6639: elm_check triggers "changed" signal twice on click: D5768: Efl.Ui.Check: fix changed callback is called twice.
Jan 29 2018, 2:48 AM · regression, efl

Jan 28 2018

taxi2se added a reviewer for D5767: elm_index: fix documentation of wrong param name: Jaehyun_Cho.
Jan 28 2018, 11:47 PM
taxi2se retitled D5766: edje_object: fix typo in EAPI edje_object_color_class_description_get from edje_object: fix typo in EAPI to edje_object: fix typo in EAPI edje_object_color_class_description_get.
Jan 28 2018, 10:25 PM
taxi2se retitled D5766: edje_object: fix typo in EAPI edje_object_color_class_description_get from edje_object: fix typo in EOLIAN legacy API to edje_object: fix typo in EAPI.
Jan 28 2018, 10:24 PM

Jan 26 2018

taxi2se updated the diff for D5742: Efl.Ui.Image: remove previous image when NULL is set.

remove redundant NULL check

Jan 26 2018, 12:11 AM

Jan 25 2018

taxi2se updated the summary of D5765: PROTOTYPE: Efl.Ui.Widget: implement Efl.Gfx.Color_Class.
Jan 25 2018, 11:44 PM · efl
taxi2se requested review of D5741: elm_test: add elementary_test for Efl.Ui.Button.
Jan 25 2018, 6:01 AM
taxi2se requested review of D5742: Efl.Ui.Image: remove previous image when NULL is set.
Jan 25 2018, 6:00 AM

Jan 24 2018

taxi2se closed D5760: eolian_gen: remove reference to elm_entry because it is not installed.
Jan 24 2018, 1:57 AM
taxi2se closed D5748: efl_ui_legacy: add new interface to indicate legacy widget.
Jan 24 2018, 1:57 AM

Jan 23 2018

taxi2se added a comment to D5748: efl_ui_legacy: add new interface to indicate legacy widget.

I think this is ready. I tested on elementary_test, and make check.

Jan 23 2018, 10:32 PM
taxi2se added reviewers for D5748: efl_ui_legacy: add new interface to indicate legacy widget: jpeg, cedric, Jaehyun_Cho.
Jan 23 2018, 10:10 PM
taxi2se updated the diff for D5748: efl_ui_legacy: add new interface to indicate legacy widget.

apply Legacy interface to more legacy widgets.

Jan 23 2018, 10:09 PM
taxi2se added a comment to D5748: efl_ui_legacy: add new interface to indicate legacy widget.

Some more Eo should be added, I will update this soon.

Jan 23 2018, 7:53 PM

Jan 19 2018

taxi2se requested review of D5748: efl_ui_legacy: add new interface to indicate legacy widget.
Jan 19 2018, 2:54 AM

Jan 16 2018

taxi2se closed D5739: elm_tooltip: set theme group to NULL.
Jan 16 2018, 8:59 PM
taxi2se closed D5725: elm_datetime: use legacy elm_button.
Jan 16 2018, 8:59 PM
taxi2se closed D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.
Jan 16 2018, 5:08 AM

Jan 15 2018

taxi2se added a comment to T6579: THEMES USAGE IS BROKEN.

D5725, D5739
D5739 is for elm_tooltip, which fixes case that new EO widgets use tooltip by elm_object_tooltip_set()
But I am not sure whether new EO widget should fully support for legacy APIs. (Tooltip does not have EO apis)
Also, I am not sure this is the case that @zmike mentioned.

Jan 15 2018, 10:38 PM · efl
taxi2se added a comment to T6579: THEMES USAGE IS BROKEN.

I tried to apply new group name policy only to new widgets which has a prefix "efl_ui_".
That is why I left elm_entry and elm_tooltip because I thought they are legacy_only widgets.
Tooltip should be fixed because it may have a parent which is not legacy_only, which is the case I passed over.
And I don't think elm_entry should be changed because it will remain legacy_only.
I will patch tooltip soon.
Please give me any comment that if there are more that I must consider.

Jan 15 2018, 9:02 PM · efl

Jan 14 2018

taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.

rebase

Jan 14 2018, 8:06 PM

Jan 8 2018

taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.

efl_animation: add ref to anim in player when anim is set

Jan 8 2018, 3:38 AM

Jan 7 2018

taxi2se created D5725: elm_datetime: use legacy elm_button.
Jan 7 2018, 11:42 PM
taxi2se added a comment to T6579: THEMES USAGE IS BROKEN.

Can you tell me which legacy widget is broken?

Jan 7 2018, 8:15 PM · efl

Dec 28 2017

taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.
  • replace resume/pause to Efl.Player.play_get/set
  • rebase
  • remove unnecessary internal flags
Dec 28 2017, 10:51 PM
taxi2se added a comment to D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.

Please check
devs/taxi2se/efl_playable
branch. It will be rebased daily.
and you can check with git history.

Dec 28 2017, 2:01 AM
taxi2se retitled D5662: efl_playable: split Efl.Player interface to Efl.Playable interface from PROTOTYPE:efl_playable: split Efl.Player interface to Efl.Playable interface to efl_playable: split Efl.Player interface to Efl.Playable interface.
Dec 28 2017, 1:58 AM
taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.

Rebase and refine commit msgs.

  • efl_playable: add Efl.Playable interface.
  • efl_animation: implements Efl.Player and Efl.Playable interfaces.
  • efl_animation: secure final_state for group animation
  • efl_animation_player: move target_set from Efl.Animation
Dec 28 2017, 1:54 AM

Dec 27 2017

taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.
  • fix show/hide logic for event animation
  • efl_animation: fix pause/resume error
  • efl_animation_player: move target_set from Efl.Animation
  • efl_animation: secure final_state for group animation
Dec 27 2017, 11:46 PM
taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.
  • efl_animation_player: move target_set from Efl.Animation
Dec 27 2017, 2:22 AM

Dec 26 2017

taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.
  • fix show/hide logic for event animation
  • efl_animation: fix pause/resume error
Dec 26 2017, 9:10 PM

Dec 20 2017

taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.

make anim_player as singleton object. remove animation dependency to prev_progress

Dec 20 2017, 7:26 AM

Dec 19 2017

taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.

do not reset current map during play.

Dec 19 2017, 6:28 AM

Dec 18 2017

taxi2se closed D5645: efl_ui_image: apply load_size when API is called.
Dec 18 2017, 4:05 AM
taxi2se closed D5616: efl_ui_bg: add Efl.Ui.Bg interface.
Dec 18 2017, 4:05 AM

Dec 17 2017

taxi2se updated the diff for D5616: efl_ui_bg: add Efl.Ui.Bg interface.

Rebase

Dec 17 2017, 7:12 PM

Dec 15 2017

taxi2se updated the diff for D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.

rename efl_animation_object to efl_animation_player

Dec 15 2017, 12:33 AM

Dec 14 2017

taxi2se created D5662: efl_playable: split Efl.Player interface to Efl.Playable interface.
Dec 14 2017, 8:14 AM

Dec 12 2017

taxi2se updated the summary of D5616: efl_ui_bg: add Efl.Ui.Bg interface.
Dec 12 2017, 10:02 PM
taxi2se updated the diff for D5616: efl_ui_bg: add Efl.Ui.Bg interface.

Fix wrong CLASS_NAME

Dec 12 2017, 10:01 PM
taxi2se added a comment to D5616: efl_ui_bg: add Efl.Ui.Bg interface.

_elm_widget_efl_canvas_group_group_member_add calls efl_gfx_color_get(bg)
in efl_object_constructor()
Since I moved construction code to constructor() from group_add()
rect is not created by the time.

Dec 12 2017, 9:59 PM
taxi2se updated the diff for D5616: efl_ui_bg: add Efl.Ui.Bg interface.

remove unnecessary override, remove _eo.h header

Dec 12 2017, 9:54 PM
taxi2se updated the diff for D5616: efl_ui_bg: add Efl.Ui.Bg interface.

call super color_set when rect is not added.

Dec 12 2017, 8:52 PM
taxi2se created D5645: efl_ui_image: apply load_size when API is called.
Dec 12 2017, 2:13 AM

Dec 11 2017

taxi2se updated the diff for D5616: efl_ui_bg: add Efl.Ui.Bg interface.

fix color_get during construction

Dec 11 2017, 10:03 PM
taxi2se updated the diff for D5616: efl_ui_bg: add Efl.Ui.Bg interface.

change super to Efl.Interface

Dec 11 2017, 9:24 PM
taxi2se updated the diff for D5616: efl_ui_bg: add Efl.Ui.Bg interface.

rename Efl.Ui.Bg_obj -> Efl.Ui.Bg_widget

Dec 11 2017, 4:07 AM
taxi2se created D5640: efl_ui_popup_scroll: remove build warnings.
Dec 11 2017, 12:02 AM

Dec 8 2017

taxi2se closed D5592: efl_ui_spin: apply new theme set policy.
Dec 8 2017, 2:02 AM
taxi2se closed D5615: multibuttonentry: Add theme for legacy multibuttonentry..
Dec 8 2017, 2:02 AM
taxi2se closed D5629: efl_ui_clock: remove warning.
Dec 8 2017, 2:02 AM
taxi2se closed D5564: elm_entry: remove warning during construct.
Dec 8 2017, 2:02 AM
taxi2se closed D5601: efl_ui_text: apply new theme logic and use constructor/destructor.
Dec 8 2017, 2:02 AM
taxi2se closed D5606: efl_ui_clock: Apply lazy edc..
Dec 8 2017, 2:02 AM
taxi2se closed D5607: efl_ui_multibuttonentry: Apply lazy edc, code clean up..
Dec 8 2017, 2:02 AM
taxi2se closed D5578: efl_ui_calendar: apply new theme policy.
Dec 8 2017, 2:02 AM
taxi2se closed D5577: efl_ui_popup_alert: refactor popup_alert_part.
Dec 8 2017, 2:01 AM
taxi2se closed D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.
Dec 8 2017, 2:01 AM
taxi2se closed D5548: elm_code_widget: change efl_add to legacy_add.
Dec 8 2017, 2:01 AM
taxi2se closed D5473: efl_ui_widget: add new property/method for new group name.
Dec 8 2017, 2:01 AM

Dec 7 2017

taxi2se created D5629: efl_ui_clock: remove warning.
Dec 7 2017, 9:51 PM
taxi2se updated the diff for D5616: efl_ui_bg: add Efl.Ui.Bg interface.

remove commented line

Dec 7 2017, 1:43 AM

Dec 6 2017

taxi2se created D5616: efl_ui_bg: add Efl.Ui.Bg interface.
Dec 6 2017, 11:10 PM

Dec 5 2017

taxi2se retitled D5564: elm_entry: remove warning during construct from efl_ui_text: remove warning for text and elm_entry to elm_entry: remove warning during construct.
Dec 5 2017, 3:16 AM
taxi2se updated the diff for D5564: elm_entry: remove warning during construct.

remove efl_ui_text

Dec 5 2017, 3:16 AM
taxi2se updated the diff for D5592: efl_ui_spin: apply new theme set policy.

Remove efl_gfx_visible_set() since components are in swallow.

Dec 5 2017, 2:38 AM

Dec 4 2017

taxi2se created D5592: efl_ui_spin: apply new theme set policy.
Dec 4 2017, 10:38 PM
taxi2se added a comment to D5578: efl_ui_calendar: apply new theme policy.

pushed to FEATURE branch. This is not in master YET.

Dec 4 2017, 7:07 PM
taxi2se closed D5578: efl_ui_calendar: apply new theme policy.
Dec 4 2017, 7:06 PM
taxi2se updated the diff for D5577: efl_ui_popup_alert: refactor popup_alert_part.

fix mistakes

Dec 4 2017, 4:26 AM

Dec 3 2017

taxi2se updated the diff for D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.

Remove empty space.

Dec 3 2017, 9:48 PM

Nov 30 2017

taxi2se created D5577: efl_ui_popup_alert: refactor popup_alert_part.
Nov 30 2017, 8:55 PM
taxi2se retitled D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL from elm: introduce ELM_PART_PARTIAL_OVERRIDE to elm: introduce ELM_PART_OVERRIDE_PARTIAL.
Nov 30 2017, 8:06 PM
taxi2se updated the diff for D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.

Remove unused internal func

Nov 30 2017, 7:58 PM
taxi2se updated the diff for D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.

Rebase

Nov 30 2017, 6:49 PM
taxi2se added a comment to D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.

ELM_PART_OVERRIDE_ONLY_ALIASES should be removed because no more widget is using it,
but I will remove the macro after D5556 is merged to avoid merge conflict

Nov 30 2017, 12:44 AM
taxi2se created D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.
Nov 30 2017, 12:41 AM

Nov 29 2017

taxi2se abandoned D5565: efl_part: _elm_part_alias_find finds real alias name.

I am working on ELM_PART_OVERRIDE macro and it will replace this commit.
So abandon this diff.

Nov 29 2017, 10:57 PM
taxi2se created D5565: efl_part: _elm_part_alias_find finds real alias name.
Nov 29 2017, 9:18 PM
taxi2se created D5564: elm_entry: remove warning during construct.
Nov 29 2017, 8:41 PM

Nov 28 2017

taxi2se updated the diff for D5556: efl_ui_popup: remove unnecessary overides.

Remove refactoring part.

Nov 28 2017, 11:53 PM
taxi2se created D5556: efl_ui_popup: remove unnecessary overides.
Nov 28 2017, 11:05 PM
taxi2se closed D5548: elm_code_widget: change efl_add to legacy_add.
Nov 28 2017, 7:14 PM
taxi2se closed D5473: efl_ui_widget: add new property/method for new group name.
Nov 28 2017, 7:14 PM
taxi2se updated the diff for D5473: efl_ui_widget: add new property/method for new group name.

rebase, fix elm_code_widget failure.

Nov 28 2017, 4:02 AM
taxi2se created D5548: elm_code_widget: change efl_add to legacy_add.
Nov 28 2017, 3:54 AM

Nov 27 2017

taxi2se closed D5542: elc_combobox: use elm_legacy_add for internal component.
Nov 27 2017, 6:49 PM
taxi2se updated the diff for D5542: elc_combobox: use elm_legacy_add for internal component.

set visibility to EINA_FALSE for internal hover

Nov 27 2017, 4:05 AM
taxi2se created D5542: elc_combobox: use elm_legacy_add for internal component.
Nov 27 2017, 1:53 AM