Page MenuHomePhabricator

vitor.sousa (Vitor Sousa da Silva)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2014, 7:11 AM (264 w, 1 d)
Availability
Available

Recent Activity

Tue, Apr 16

vitor.sousa accepted D8614: csharp: klass style changes.
Tue, Apr 16, 8:09 AM · efl: language bindings
vitor.sousa accepted D8612: csharp: Simple spacing rules changes.
Tue, Apr 16, 8:03 AM · efl

Mon, Apr 15

vitor.sousa closed T7805: error when installing c++ header as Resolved by committing rEFLcacbd9e58d52: cxx: Fix eldbus meta include name.
Mon, Apr 15, 3:20 PM · Restricted Project
vitor.sousa closed D8611: cxx: Fix eldbus meta include name.
Mon, Apr 15, 3:20 PM · efl
vitor.sousa added a comment to D8609: csharp: Remove warning about clashing GetType() methods.

Since @segfaultxavi is the one that suggested this rule.
I'm confident he is OK with this push :D

Mon, Apr 15, 12:33 PM · efl
vitor.sousa closed T7727: C#: Clash with System.Object methods as Resolved by committing rEFL9e29b69c2a0c: csharp: Remove warning about clashing GetType() methods.
Mon, Apr 15, 12:32 PM
vitor.sousa closed D8609: csharp: Remove warning about clashing GetType() methods.
Mon, Apr 15, 12:32 PM · efl
vitor.sousa accepted D8609: csharp: Remove warning about clashing GetType() methods.
Mon, Apr 15, 12:28 PM · efl
vitor.sousa closed D8608: csharp: Remove unused variable `methods` warning..
Mon, Apr 15, 11:55 AM · efl
vitor.sousa accepted D8608: csharp: Remove unused variable `methods` warning..
Mon, Apr 15, 11:54 AM · efl
vitor.sousa closed D8607: csharp: Rename MarshalTest to MarshalEo.
Mon, Apr 15, 11:36 AM · efl
vitor.sousa accepted D8607: csharp: Rename MarshalTest to MarshalEo.

Niiiiiiice!

Mon, Apr 15, 11:35 AM · efl
vitor.sousa closed D8593: csharp: Fix free_cb calling under dotnet..
Mon, Apr 15, 11:24 AM · efl
vitor.sousa accepted D8593: csharp: Fix free_cb calling under dotnet..
Mon, Apr 15, 10:45 AM · efl

Fri, Apr 12

vitor.sousa added a comment to T7800: C#: Attach wrapper lifetime to the Eo instance.

This will require some changes in the way that our wrappers handle their lifetime.
In case a Dispose happens on an object and it still has references in C, it will need to resurrect itself if it holds any registered delegates or if its C# state is important.

Fri, Apr 12, 3:32 PM · efl: language bindings
vitor.sousa accepted D8601: csharp: Make concrete classes internal..
Fri, Apr 12, 12:04 PM · efl
vitor.sousa claimed T7800: C#: Attach wrapper lifetime to the Eo instance.
Fri, Apr 12, 9:07 AM · efl: language bindings
vitor.sousa accepted D8597: mono-docs: Allow derived classes to have external examples.

Awesome

Fri, Apr 12, 8:51 AM · efl

Thu, Apr 11

vitor.sousa added a comment to D8597: mono-docs: Allow derived classes to have external examples.

But wouldn't it be easier to pass prop.klass/func.klass directly to generate_all_tag_examples than adding a new field to class_context?

That's the thing! When parsing Efl.Ui.Button.GetText(), func.klass is Efl.IText, this is, the class where this method is defined. This is the current behavior (before this patch).

Thu, Apr 11, 1:04 PM · efl
vitor.sousa requested changes to D8593: csharp: Fix free_cb calling under dotnet..

Very nice.
Some comments:

Thu, Apr 11, 12:38 PM · efl
vitor.sousa added inline comments to D8593: csharp: Fix free_cb calling under dotnet..
Thu, Apr 11, 12:38 PM · efl
vitor.sousa added a comment to D8597: mono-docs: Allow derived classes to have external examples.

I tested it, everything seems to be correct now.
But wouldn't it be easier to pass prop.klass/func.klass directly to generate_all_tag_examples than adding a new field to class_context?

Thu, Apr 11, 12:09 PM · efl
vitor.sousa requested changes to D8597: mono-docs: Allow derived classes to have external examples.
Thu, Apr 11, 8:24 AM · efl
vitor.sousa added inline comments to D8597: mono-docs: Allow derived classes to have external examples.
Thu, Apr 11, 8:19 AM · efl

Wed, Apr 10

vitor.sousa added inline comments to D8575: efl-mono: Fix example for new Application API for C#.
Wed, Apr 10, 4:22 PM · efl
vitor.sousa requested changes to D8575: efl-mono: Fix example for new Application API for C#.
Wed, Apr 10, 4:18 PM · efl
vitor.sousa accepted D8585: efl-mono: Allow generating doc refs for methods without class.

Everything looks fine IMHO.

Wed, Apr 10, 1:52 PM · efl
vitor.sousa added inline comments to D8585: efl-mono: Allow generating doc refs for methods without class.
Wed, Apr 10, 1:49 PM · efl
vitor.sousa accepted D8587: efl-mono: Allow doc XML tags to be nested.
Wed, Apr 10, 1:43 PM · efl
vitor.sousa added a comment to D8587: efl-mono: Allow doc XML tags to be nested.

Everything seems OK to me now.

Wed, Apr 10, 1:43 PM · efl
vitor.sousa accepted D8592: mono-docs: Allow embedding external examples.

Awesome.

Wed, Apr 10, 1:41 PM · efl
vitor.sousa requested changes to D8587: efl-mono: Allow doc XML tags to be nested.

Very good. Just a note:

Wed, Apr 10, 12:12 PM · efl
vitor.sousa closed D8588: csharp: Fix GetUserMethods and NativeClass.
Wed, Apr 10, 11:12 AM · efl
vitor.sousa accepted D8588: csharp: Fix GetUserMethods and NativeClass.
Wed, Apr 10, 11:12 AM · efl

Tue, Apr 9

vitor.sousa closed T7783: improve CI usage, a subtask of T7780: remove autotools, as Resolved.
Tue, Apr 9, 2:40 PM · Restricted Project, efl: meson
vitor.sousa closed T7783: improve CI usage as Resolved by committing rEFL0afd19ba62f3: efl-mono: Add test and fix problem with private dynamic types passed as….
Tue, Apr 9, 2:40 PM · Restricted Project, efl: meson
vitor.sousa closed D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.
Tue, Apr 9, 2:40 PM · efl
vitor.sousa accepted D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.
Tue, Apr 9, 2:35 PM · efl
vitor.sousa closed D8580: csharp: Add some null checks..
Tue, Apr 9, 12:27 PM · efl
vitor.sousa accepted D8580: csharp: Add some null checks..
Tue, Apr 9, 12:25 PM · efl

Fri, Apr 5

vitor.sousa closed D8564: efl-csharp: fix crash when events trigger after C# object `Dispose`.
Fri, Apr 5, 4:00 PM · efl
vitor.sousa closed D8431: efl-csharp: fix resource deallocation causing errors everywhere.
Fri, Apr 5, 3:58 PM · DO NOT MERGE, efl: language bindings
vitor.sousa closed T7757: C#: Remove static_cast method as Resolved by committing rEFL1e22db115004: csharp: Make classes abstract and rework casting.
Fri, Apr 5, 3:57 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
vitor.sousa closed T7757: C#: Remove static_cast method, a subtask of T7752: C#: Get rid of all lower-cased methods, as Resolved.
Fri, Apr 5, 3:57 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
vitor.sousa closed T7778: C#: Make abstract Eo classes C# abstracts, a subtask of T7204: Discussion about C# binding syntax, as Resolved.
Fri, Apr 5, 3:57 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
vitor.sousa closed T7778: C#: Make abstract Eo classes C# abstracts as Resolved by committing rEFL1e22db115004: csharp: Make classes abstract and rework casting.
Fri, Apr 5, 3:57 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
vitor.sousa closed D8550: csharp: Make classes abstract and rework casting.
Fri, Apr 5, 3:57 PM · efl
vitor.sousa updated the diff for D8564: efl-csharp: fix crash when events trigger after C# object `Dispose`.

rework some useless code comments

Fri, Apr 5, 3:49 PM · efl
vitor.sousa accepted D8550: csharp: Make classes abstract and rework casting.
Fri, Apr 5, 3:42 PM · efl
vitor.sousa requested review of D8564: efl-csharp: fix crash when events trigger after C# object `Dispose`.
Fri, Apr 5, 3:42 PM · efl
vitor.sousa added a child revision for D8431: efl-csharp: fix resource deallocation causing errors everywhere: D8564: efl-csharp: fix crash when events trigger after C# object `Dispose`.
Fri, Apr 5, 3:41 PM · DO NOT MERGE, efl: language bindings
vitor.sousa updated the diff for D8431: efl-csharp: fix resource deallocation causing errors everywhere.

fix previous update submitting to much code

Fri, Apr 5, 3:37 PM · DO NOT MERGE, efl: language bindings
vitor.sousa added a parent revision for D8431: efl-csharp: fix resource deallocation causing errors everywhere: D8550: csharp: Make classes abstract and rework casting.
Fri, Apr 5, 3:30 PM · DO NOT MERGE, efl: language bindings
vitor.sousa added a child revision for D8550: csharp: Make classes abstract and rework casting: D8431: efl-csharp: fix resource deallocation causing errors everywhere.
Fri, Apr 5, 3:30 PM · efl
vitor.sousa updated the diff for D8431: efl-csharp: fix resource deallocation causing errors everywhere.

rebase and adds D8550 as a dependency

Fri, Apr 5, 3:29 PM · DO NOT MERGE, efl: language bindings

Thu, Apr 4

vitor.sousa accepted D8550: csharp: Make classes abstract and rework casting.

Amazing

Thu, Apr 4, 1:31 PM · efl
vitor.sousa requested changes to D8550: csharp: Make classes abstract and rework casting.

Awesome.
Just a comment:

Thu, Apr 4, 12:54 PM · efl

Mon, Apr 1

vitor.sousa accepted D8485: mono: fix space and brace warnings of StyleCop.

Great

Mon, Apr 1, 11:23 AM · efl

Thu, Mar 28

vitor.sousa accepted D8499: csharp: Raise exception when Array is null..

gud

Thu, Mar 28, 10:54 AM · efl
vitor.sousa added a comment to D8485: mono: fix space and brace warnings of StyleCop.

I prefer no namespace indentation in any language whatsoever.
I really hope that no C# style analysis tool enforces it.

Thu, Mar 28, 8:39 AM · efl

Tue, Mar 26

vitor.sousa closed D8470: eolian_csharp: hide struct native representation inside the managed struct.
Tue, Mar 26, 12:45 PM · efl
vitor.sousa closed D8469: eolian_csharp: make struct generator use indentation level from context.
Tue, Mar 26, 12:45 PM · efl
vitor.sousa closed D8468: eolian_csharp: add indentation context.
Tue, Mar 26, 12:45 PM · efl
vitor.sousa closed D8467: eolian_cxx: rework context code, also more flexible scope indentation generator.
Tue, Mar 26, 12:45 PM · efl
vitor.sousa updated the diff for D8470: eolian_csharp: hide struct native representation inside the managed struct.

Rebase

Tue, Mar 26, 12:32 PM · efl
vitor.sousa updated the diff for D8469: eolian_csharp: make struct generator use indentation level from context.

@lauromoura 's fix and rebase

Tue, Mar 26, 12:31 PM · efl
vitor.sousa updated the diff for D8468: eolian_csharp: add indentation context.

Rebase

Tue, Mar 26, 12:30 PM · efl
vitor.sousa updated the diff for D8467: eolian_cxx: rework context code, also more flexible scope indentation generator.

Rebase

Tue, Mar 26, 12:28 PM · efl
vitor.sousa closed D8441: efl-csharp: Remove spaces from type strings in generator..
Tue, Mar 26, 10:48 AM · efl
vitor.sousa accepted D8441: efl-csharp: Remove spaces from type strings in generator..
Tue, Mar 26, 10:41 AM · efl
vitor.sousa added a comment to D8470: eolian_csharp: hide struct native representation inside the managed struct.

Sadly, it is not =/
We need access to those structs in any object that uses them.

Tue, Mar 26, 10:39 AM · efl
vitor.sousa requested changes to D8441: efl-csharp: Remove spaces from type strings in generator..
Tue, Mar 26, 10:15 AM · efl

Mon, Mar 25

vitor.sousa added reviewers for D8468: eolian_csharp: add indentation context: felipealmeida, lauromoura.
Mon, Mar 25, 2:40 PM · efl
vitor.sousa requested review of D8470: eolian_csharp: hide struct native representation inside the managed struct.
Mon, Mar 25, 2:38 PM · efl
vitor.sousa added a child revision for D8469: eolian_csharp: make struct generator use indentation level from context: D8470: eolian_csharp: hide struct native representation inside the managed struct.
Mon, Mar 25, 2:37 PM · efl
vitor.sousa requested review of D8469: eolian_csharp: make struct generator use indentation level from context.
Mon, Mar 25, 2:36 PM · efl
vitor.sousa added a child revision for D8468: eolian_csharp: add indentation context: D8469: eolian_csharp: make struct generator use indentation level from context.
Mon, Mar 25, 2:36 PM · efl
vitor.sousa requested review of D8468: eolian_csharp: add indentation context.
Mon, Mar 25, 2:35 PM · efl
vitor.sousa added a child revision for D8467: eolian_cxx: rework context code, also more flexible scope indentation generator: D8468: eolian_csharp: add indentation context.
Mon, Mar 25, 2:35 PM · efl
vitor.sousa requested review of D8467: eolian_cxx: rework context code, also more flexible scope indentation generator.
Mon, Mar 25, 2:33 PM · efl
vitor.sousa abandoned D8466: eolian_cxx: rework context code, also more flexible scope indentation generator.
Mon, Mar 25, 2:26 PM · efl
vitor.sousa updated the diff for D8466: eolian_cxx: rework context code, also more flexible scope indentation generator.
  • eolian_csharp: add indentation context
Mon, Mar 25, 2:24 PM · efl
vitor.sousa requested review of D8466: eolian_cxx: rework context code, also more flexible scope indentation generator.
Mon, Mar 25, 2:22 PM · efl

Thu, Mar 21

vitor.sousa closed T7751: C#: Add back the I prefix to interfaces as Resolved by committing rEFL0881d1524b6d: efl-csharp: Add back I prefix for interfaces..
Thu, Mar 21, 10:48 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
vitor.sousa closed T7751: C#: Add back the I prefix to interfaces, a subtask of T7204: Discussion about C# binding syntax, as Resolved.
Thu, Mar 21, 10:48 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
vitor.sousa closed D8397: efl-csharp: Add back I prefix for interfaces..
Thu, Mar 21, 10:48 AM · efl
vitor.sousa accepted D8397: efl-csharp: Add back I prefix for interfaces..

Great

Thu, Mar 21, 10:48 AM · efl

Wed, Mar 20

vitor.sousa requested changes to D8397: efl-csharp: Add back I prefix for interfaces..

Needs rebasing. test_conflicting_events doesn't exist on master anymore and creates a conflict.

Wed, Mar 20, 3:18 PM · efl
vitor.sousa added a comment to D8431: efl-csharp: fix resource deallocation causing errors everywhere.

@cedric I solved the concurrency problem using ecore_main_loop_thread_safe_call_async.
Eo error logs disappeared, but now the test prints a big list like this at the end of execution:

EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980

Could you give it a look and check whether I am using it incorrectly or it is a problem with eina_thread?

Wed, Mar 20, 12:38 PM · DO NOT MERGE, efl: language bindings
vitor.sousa edited projects for D8431: efl-csharp: fix resource deallocation causing errors everywhere, added: efl: language bindings, DO NOT MERGE; removed efl.
Wed, Mar 20, 12:29 PM · DO NOT MERGE, efl: language bindings
vitor.sousa requested review of D8431: efl-csharp: fix resource deallocation causing errors everywhere.
Wed, Mar 20, 12:28 PM · DO NOT MERGE, efl: language bindings

Mar 15 2019

vitor.sousa accepted D8368: cshar: Remove unused variables..
Mar 15 2019, 7:46 AM · efl
vitor.sousa closed D8360: csharp: Support Efl.Class for interfaces.
Mar 15 2019, 7:38 AM · efl
vitor.sousa accepted D8360: csharp: Support Efl.Class for interfaces.
Mar 15 2019, 7:37 AM · efl
vitor.sousa added inline comments to D8360: csharp: Support Efl.Class for interfaces.
Mar 15 2019, 7:07 AM · efl
vitor.sousa added inline comments to D8360: csharp: Support Efl.Class for interfaces.
Mar 15 2019, 6:56 AM · efl

Mar 14 2019

vitor.sousa accepted D8330: csharp: Remove uneeded legacy event declaration..

Pretty please with a cherry on top!

Mar 14 2019, 8:18 AM · efl

Mar 11 2019

vitor.sousa closed T7735: efl-mono: Event names with underscores look weird from C# as Resolved by committing rEFL305749f049ce: csharp: Fix event names with underscore..
Mar 11 2019, 3:28 PM · efl (efl-1.22), efl: language bindings
vitor.sousa closed D8301: csharp: Fix event names with underscore..
Mar 11 2019, 3:28 PM · efl
vitor.sousa accepted D8301: csharp: Fix event names with underscore..
Mar 11 2019, 3:21 PM · efl