Page MenuHomePhabricator

vitor.sousa (Vitor Sousa da Silva)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 25 2014, 7:11 AM (246 w, 4 d)
Availability
Available

Recent Activity

Yesterday

vitor.sousa closed D7460: efl-mono: Fix call of virtual methods after new API.
Fri, Dec 14, 2:48 PM · efl
vitor.sousa accepted D7460: efl-mono: Fix call of virtual methods after new API.
Fri, Dec 14, 2:47 PM · efl
vitor.sousa removed a parent revision for D7460: efl-mono: Fix call of virtual methods after new API: D7459: eolian-cxx: Add parent/extensions information to klass_def.
Fri, Dec 14, 1:52 PM · efl
vitor.sousa removed a child revision for D7459: eolian-cxx: Add parent/extensions information to klass_def: D7460: efl-mono: Fix call of virtual methods after new API.
Fri, Dec 14, 1:52 PM · efl
vitor.sousa updated the summary of D7460: efl-mono: Fix call of virtual methods after new API.
Fri, Dec 14, 1:51 PM · efl
vitor.sousa closed D7459: eolian-cxx: Add parent/extensions information to klass_def.
Fri, Dec 14, 1:45 PM · efl
vitor.sousa accepted D7459: eolian-cxx: Add parent/extensions information to klass_def.
Fri, Dec 14, 1:45 PM · efl
vitor.sousa updated the diff for D7459: eolian-cxx: Add parent/extensions information to klass_def.

Fixed compilation with autotools

Fri, Dec 14, 1:38 PM · efl
vitor.sousa closed D7394: eolian_mono: Add support for C# style properties.
Fri, Dec 14, 12:31 PM · efl: language bindings
vitor.sousa accepted D7394: eolian_mono: Add support for C# style properties.

Well, since there is a agreement about the <value> tag now, I think I can proceed and land this commit.

Fri, Dec 14, 12:14 PM · efl: language bindings

Thu, Dec 6

vitor.sousa accepted D7380: ecore: remove unecessary intermediate variable..
Thu, Dec 6, 5:20 AM · efl

Wed, Dec 5

vitor.sousa added a reviewer for D7421: Add missing dependencies and an observation about poppler: raster.
Wed, Dec 5, 8:06 AM · documentation
vitor.sousa added a project to D7421: Add missing dependencies and an observation about poppler: documentation.
Wed, Dec 5, 8:02 AM · documentation
vitor.sousa requested review of D7421: Add missing dependencies and an observation about poppler.
Wed, Dec 5, 7:58 AM · documentation
vitor.sousa closed D7247: ecore: fix composite models in order to properly model Ui.View selection.
Wed, Dec 5, 4:44 AM · efl
vitor.sousa added a comment to D7394: eolian_mono: Add support for C# style properties.

OK, edit Related Revision.
Apparently arc is no longer trying to apply D7389.

Wed, Dec 5, 4:42 AM · efl: language bindings
vitor.sousa removed a child revision for D7389: eolian-cxx: Add property_def: D7394: eolian_mono: Add support for C# style properties.
Wed, Dec 5, 4:34 AM · efl
vitor.sousa removed a parent revision for D7394: eolian_mono: Add support for C# style properties: D7389: eolian-cxx: Add property_def.
Wed, Dec 5, 4:34 AM · efl: language bindings
vitor.sousa added a comment to D7394: eolian_mono: Add support for C# style properties.

Ouch! That sucks.
I am using --skip-dependencies for now.
I will look further on removing this on longer needed dependency.

Wed, Dec 5, 4:33 AM · efl: language bindings
vitor.sousa updated the summary of D7394: eolian_mono: Add support for C# style properties.
Wed, Dec 5, 4:19 AM · efl: language bindings

Tue, Dec 4

vitor.sousa added a comment to D7394: eolian_mono: Add support for C# style properties.

Seems fine now and works OK in my computer.
Anyway, I will wait for @segfaultxavi approval before landing this.

Tue, Dec 4, 11:07 AM · efl: language bindings
vitor.sousa removed a project from D7394: eolian_mono: Add support for C# style properties: DO NOT MERGE.
Tue, Dec 4, 10:58 AM · efl: language bindings
vitor.sousa accepted D7394: eolian_mono: Add support for C# style properties.
Tue, Dec 4, 10:42 AM · efl: language bindings
vitor.sousa closed D7414: eolian_cxx: Add documentation field to property_def.
Tue, Dec 4, 10:21 AM · efl
vitor.sousa accepted D7414: eolian_cxx: Add documentation field to property_def.
Tue, Dec 4, 10:20 AM · efl

Fri, Nov 30

vitor.sousa closed D7389: eolian-cxx: Add property_def.
Fri, Nov 30, 2:08 PM · efl
vitor.sousa accepted D7389: eolian-cxx: Add property_def.
Fri, Nov 30, 1:22 PM · efl
vitor.sousa added inline comments to D7389: eolian-cxx: Add property_def.
Fri, Nov 30, 10:37 AM · efl
vitor.sousa requested changes to D7389: eolian-cxx: Add property_def.

Very nice.
I have just some comments about indentation and names:

Fri, Nov 30, 10:33 AM · efl
vitor.sousa accepted D7342: ecore_con: simplify code by using helper that create future directly..
Fri, Nov 30, 6:28 AM · Restricted Project, efl
vitor.sousa accepted D7341: ecore: simplify code by using helper that build future directly..
Fri, Nov 30, 6:27 AM · Restricted Project, efl
vitor.sousa accepted D7340: eldbus: simplify code by using helper that create future directly..
Fri, Nov 30, 6:26 AM · Restricted Project, efl
vitor.sousa accepted D7339: eio: simplify code by using helper that generate future directly..
Fri, Nov 30, 6:25 AM · Restricted Project, efl
vitor.sousa accepted D7338: eio: we do not need to actually loop explicitely for the loop here..
Fri, Nov 30, 6:25 AM · Restricted Project, efl

Thu, Nov 29

vitor.sousa closed D7262: csharp: Change to new class API..
Thu, Nov 29, 3:30 PM · efl
vitor.sousa closed T7336: Ecore csharp examples are not part of the build as Resolved by committing rEFL3623753c1d6b: csharp: Change to new class API..
Thu, Nov 29, 3:30 PM
vitor.sousa closed T7451: efl-mono: Only expose API methods relevant to the user, a subtask of T6128: Generate C# reference API documentation, as Resolved.
Thu, Nov 29, 3:30 PM · efl: language bindings, efl: docs
vitor.sousa closed T7451: efl-mono: Only expose API methods relevant to the user as Resolved by committing rEFL3623753c1d6b: csharp: Change to new class API..
Thu, Nov 29, 3:30 PM · efl: language bindings, efl: docs
vitor.sousa added a comment to D7247: ecore: fix composite models in order to properly model Ui.View selection.

I think a branch is better. I pushed it on: devs/vitorsousa/model_composite

Thu, Nov 29, 3:17 PM · efl
vitor.sousa accepted D7262: csharp: Change to new class API..
Thu, Nov 29, 2:58 PM · efl
vitor.sousa added inline comments to D7247: ecore: fix composite models in order to properly model Ui.View selection.
Thu, Nov 29, 2:55 PM · efl
vitor.sousa updated the diff for D7247: ecore: fix composite models in order to properly model Ui.View selection.

update coding style

Thu, Nov 29, 2:45 PM · efl
vitor.sousa updated the diff for D7247: ecore: fix composite models in order to properly model Ui.View selection.

It was calling the wrong function for events. Quick fix.

Thu, Nov 29, 11:06 AM · efl
vitor.sousa added a comment to D7247: ecore: fix composite models in order to properly model Ui.View selection.

@cedric , let me know what you think about the EFL_MODEL_COMPOSITE_PROPERTIES macros, and if you have any suggestion about how to improve it.

Thu, Nov 29, 11:00 AM · efl
vitor.sousa updated the diff for D7247: ecore: fix composite models in order to properly model Ui.View selection.

Update for the better defined API returning Iterators.

Thu, Nov 29, 10:53 AM · efl
vitor.sousa accepted D7332: elementary: make Efl.Ui.Factory.create asynchronous..
Thu, Nov 29, 7:40 AM · efl

Tue, Nov 27

vitor.sousa added inline comments to D7262: csharp: Change to new class API..
Tue, Nov 27, 9:22 AM · efl
vitor.sousa added inline comments to D7262: csharp: Change to new class API..
Tue, Nov 27, 8:33 AM · efl

Fri, Nov 23

vitor.sousa accepted D7336: elementary: simplify code by using proper helper..
Fri, Nov 23, 11:31 AM · Restricted Project, efl
vitor.sousa accepted D7335: eldbus: simplify code by using proper helper..
Fri, Nov 23, 11:30 AM · Restricted Project, efl
vitor.sousa accepted D7334: eio: simplify code by using proper helper..
Fri, Nov 23, 11:29 AM · Restricted Project, efl
vitor.sousa accepted D7333: ecore_con: simplify code by using proper helper..
Fri, Nov 23, 11:29 AM · Restricted Project, efl
vitor.sousa accepted D7327: eo: rename efl_future_Eina_FutureXXX_then in efl_future_then as this has been available for some time..
Fri, Nov 23, 11:16 AM · Restricted Project, efl
vitor.sousa accepted D7326: eldbus: switch Eldbus.Model to inherit from Efl.Model_Loop..
Fri, Nov 23, 11:11 AM · Restricted Project, efl
vitor.sousa accepted D7325: eio: switch Eio.Model to inherit from Efl.Model_Loop..
Fri, Nov 23, 11:10 AM · Restricted Project, efl
vitor.sousa accepted D7324: ecore: switch all Efl.Model to inherit first from Efl.Model_Loop..
Fri, Nov 23, 11:10 AM · Restricted Project, efl
vitor.sousa accepted D7323: ecore,efl: add Efl.Model.property_get helper which will suceed once when a property finally has a value..
Fri, Nov 23, 11:09 AM · Restricted Project, efl
vitor.sousa added inline comments to D7323: ecore,efl: add Efl.Model.property_get helper which will suceed once when a property finally has a value..
Fri, Nov 23, 9:33 AM · Restricted Project, efl
vitor.sousa added a comment to D7323: ecore,efl: add Efl.Model.property_get helper which will suceed once when a property finally has a value..

Do we still need to update autofoo?
These new files are listed in meson only.

Fri, Nov 23, 9:22 AM · Restricted Project, efl
vitor.sousa accepted D7322: eio: use the right type of Eina_Value to report error..
Fri, Nov 23, 8:41 AM · Restricted Project, efl
vitor.sousa accepted D7289: efl: make Efl.Model.properties_get return an Iterator<string>..
Fri, Nov 23, 8:29 AM · efl
vitor.sousa updated the diff for D7289: efl: make Efl.Model.properties_get return an Iterator<string>..

With only the correct commit now, I hope.

Fri, Nov 23, 8:25 AM · efl
vitor.sousa requested changes to D7289: efl: make Efl.Model.properties_get return an Iterator<string>..

Oops! It uploaded all the commits. My bad. I am going to fix that.

Fri, Nov 23, 8:21 AM · efl
vitor.sousa accepted D7289: efl: make Efl.Model.properties_get return an Iterator<string>..

I think it is way better now with iterators.
Very nice.

Fri, Nov 23, 8:19 AM · efl
vitor.sousa updated the diff for D7289: efl: make Efl.Model.properties_get return an Iterator<string>..

A missing & in sscanf was making eldbus tests to fail.
It is all fine now.

Fri, Nov 23, 8:16 AM · efl

Thu, Nov 22

vitor.sousa accepted D7286: eina: add eina_multi_iterator_new..

I'm specially in love with this one.
Very handy =)

Thu, Nov 22, 9:39 AM · efl
vitor.sousa accepted D7287: eina: add tests for eina_multiple_iterator_new..
Thu, Nov 22, 9:35 AM · efl
vitor.sousa accepted D7285: eina: add test for Eina_Iterator over pure C array..
Thu, Nov 22, 9:21 AM · efl
vitor.sousa accepted D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..

Nice :-)

Thu, Nov 22, 9:20 AM · efl

Mon, Nov 19

vitor.sousa added a comment to D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..

Pointer arithmetic seems OK, just missing the * step from D7286.
And I think this will be the last comment:

Mon, Nov 19, 11:51 AM · efl
vitor.sousa added a comment to D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..

Another comment. I think part of this commit was left in D7286.
Also, pointer arithmetic seems a bit strange to me in this. I'm still checking it.

Mon, Nov 19, 11:11 AM · efl
vitor.sousa requested changes to D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..

I am strongly in favor of this addition.

Mon, Nov 19, 10:37 AM · efl

Nov 12 2018

vitor.sousa closed D7256: eo: fix and rework efl_replace().
Nov 12 2018, 12:20 PM · efl

Nov 9 2018

vitor.sousa requested review of D7256: eo: fix and rework efl_replace().
Nov 9 2018, 2:53 PM · efl

Nov 8 2018

vitor.sousa requested review of D7247: ecore: fix composite models in order to properly model Ui.View selection.
Nov 8 2018, 5:55 AM · efl

Oct 16 2018

vitor.sousa closed D7166: eina_cxx: Fix eina::value copy constructor..
Oct 16 2018, 2:47 PM · efl
vitor.sousa accepted D7166: eina_cxx: Fix eina::value copy constructor..
Oct 16 2018, 2:38 PM · efl

Oct 4 2018

vitor.sousa closed D7136: csharp: Fix missing override keyword.
Oct 4 2018, 10:24 AM · efl
vitor.sousa accepted D7136: csharp: Fix missing override keyword.
Oct 4 2018, 10:21 AM · efl

Sep 26 2018

vitor.sousa closed D7106: efl-csharp: Fix event struct marshalling..
Sep 26 2018, 8:16 AM · efl

Sep 25 2018

vitor.sousa accepted D7106: efl-csharp: Fix event struct marshalling..
Sep 25 2018, 8:08 AM · efl

Sep 18 2018

vitor.sousa added a comment to T7407: efl-mono: Crash on focus callback when quitting focus example.

For me both C and C# versions are segfaulting when the Quit button is pressed.
But I also get

ERR<28729>:mono /home/vitorsousa/ework/efl/src/lib/elementary/efl_ui_button.eo.cs:2741 on_Efl_Ui_Focus_Object_FocusChangedEvt_NativeCallback() System.NullReferenceException: Object reference not set to an instance of an object
  at efl.ui.Button.On_Efl_Ui_Focus_Object_FocusChangedEvt (efl.ui.focus.Object+FocusChangedEvt_Args e) [0x00000] in <3bc2f8761b2a46b4b805d22f6618107e>:0 
  at efl.ui.Button.on_Efl_Ui_Focus_Object_FocusChangedEvt_NativeCallback (System.IntPtr data, efl.Event& evt) [0x0001c] in <3bc2f8761b2a46b4b805d22f6618107e>:0

just before the crash (in C# only).

Sep 18 2018, 11:27 AM · Restricted Project, efl: language bindings

Sep 11 2018

vitor.sousa closed D7017: efl-csharp: Add copy constructor for eina.Value..
Sep 11 2018, 7:41 AM · efl
vitor.sousa accepted D7017: efl-csharp: Add copy constructor for eina.Value..
Sep 11 2018, 7:29 AM · efl

Sep 6 2018

vitor.sousa closed T7112: C# bindings: List<T>.Reverse() should return the same list instead of void as Resolved by committing rEFL40d03dbef8a0: efl-mono: Make eina_list return the list.
Sep 6 2018, 8:20 AM · efl: language bindings
vitor.sousa closed D6995: efl-mono: Make eina_list return the list.
Sep 6 2018, 8:20 AM · efl
vitor.sousa accepted D6995: efl-mono: Make eina_list return the list.

Nice =)

Sep 6 2018, 8:20 AM · efl

Sep 5 2018

vitor.sousa closed D6981: efl-csharp: Fix event callback removal..
Sep 5 2018, 10:47 AM · efl: language bindings
vitor.sousa accepted D6981: efl-csharp: Fix event callback removal..
Sep 5 2018, 10:43 AM · efl: language bindings
vitor.sousa closed D6956: efl-csharp: Make sure efl_finalize overrides are callable.
Sep 5 2018, 10:19 AM · efl
vitor.sousa added a comment to D6956: efl-csharp: Make sure efl_finalize overrides are callable.

Hello @Jaehyun_Cho.
It's, working for me. But I heard that it was not working on dotnet for you, so I was waiting another review on it.
But since it seems to be fine and that the dotnet problem needs further and separated investigation, I am going to submit it right away.

Sep 5 2018, 10:02 AM · efl

Sep 3 2018

vitor.sousa closed T7359: efl-mono: Accessing the Global Config crashes on exit as Resolved by committing rEFL840613235de6: efl-csharp: Use value_new/free for wrapped values.
Sep 3 2018, 1:39 PM · efl: language bindings
vitor.sousa closed D6958: efl-csharp: Use value_new/free for wrapped values.
Sep 3 2018, 1:39 PM · efl
vitor.sousa accepted D6956: efl-csharp: Make sure efl_finalize overrides are callable.
Sep 3 2018, 12:46 PM · efl
vitor.sousa accepted D6958: efl-csharp: Use value_new/free for wrapped values.
Sep 3 2018, 11:19 AM · efl

Aug 24 2018

vitor.sousa closed D6905: efl-mono: properly close XML comment.
Aug 24 2018, 10:10 AM · efl
vitor.sousa accepted D6905: efl-mono: properly close XML comment.

I've just made a small change on the commit title. C# bindings: doesn't seem to look like the start of most efl commit messages.
The C# binding has been commonly referenced as efl-mono.
I will land the commit if @segfaultxavi is OK with the change.

Aug 24 2018, 8:24 AM · efl
vitor.sousa retitled D6905: efl-mono: properly close XML comment from C# bindings: properly close XML comment to efl-mono: properly close XML comment.
Aug 24 2018, 8:09 AM · efl
vitor.sousa closed T7346: C# bindings: event handler cannot be added in constructor as Resolved by committing rEFLa9efc388858b: csharp: Fix event registration in constructor..
Aug 24 2018, 7:34 AM · efl: language bindings
vitor.sousa closed D6908: csharp: Fix event registration in constructor..
Aug 24 2018, 7:34 AM · efl