more precisely, it's the file selector which is crashing (and crashed my Windows...)

@netstar even lines 1244 to 1246 of the patch ? (nullification of fields of edata->clipboard)

see D12166

see P339 for a back trace

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

needs review

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

see D12165

i think i'll be able to test your patch this week-end

does it hurt to apply this patch ? It's now clean and show others how it has to be done

why was checkme deleted ?

do you plan to write a saver too ?

remove the 2 first changes

already in git

just for your information, 4.3 is out (topic mentions 4.2)

test_dirname, not dirname

already in master

add comments decribing the parsing of a PE file

there is also

add .bat files support

SHGetFileInfo() look at the file extension only. Parse file to see if it is an executable or not instead

But test will need changes anyway, right?

i renamed a .exe into a .isexe and SHGetFileInfo() fails, so it's really the extension which matters here

another solution : consider only PE binaries and parse the file (i've alredy done that), and check if it's a binary or not

In D12118#231689, @jptiz wrote:

In D12118#231687, @vtorri wrote:

also see https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfoa

the 'return value' section.

I test only if the result is 0 or not.

Ooooh right. So in that case, it would be necessary to split Hi and Lo bits and compare them separately?

also see https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfoa

strange because i've tested on a .bat explicitely. Here the problem is a .sh which is not supported outside a unix shell

define HAVE_GETTIMEOFDAY if not defined
some formatting in evil_dlfcn.h too

yes please

see D12112

looks good to me

@stefan_schmidt it's ok for me

emile has also openssl code. Can you look at it too please ?

add close() to comment

and for solaris (openindiana + illumos) ? i've added @alarcher as reviewer

maybe use readdir_r()