Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (353 w, 5 d)
Availability
Available

Recent Activity

Today

vtorri accepted D10788: elocation: remove beta library.
Mon, Dec 9, 6:22 AM · efl

Thu, Dec 5

vtorri added a comment to D10788: elocation: remove beta library.

i think that there is one occurence here : doc/elementary_examples_cxx.dox: * @ref location_cxx_example_01

Thu, Dec 5, 9:36 PM · efl

Wed, Nov 27

vtorri requested review of D10753: ecore_win32: fix compose event field.
Wed, Nov 27, 9:05 PM · efl
vtorri added inline comments to D10748: ector_software_rasterizer: use dynamic array by span size..
Wed, Nov 27, 4:57 AM · efl

Wed, Nov 20

vtorri added a comment to T8484: warnings in Eet.

@ProhtMeyhet if there is no such warning on linux, then we can close the task

Wed, Nov 20, 9:37 AM · Restricted Project
vtorri added a comment to T8484: warnings in Eet.

gcc for Windows, version 9.2.0. I guess that it does not detect that it is defined there :

Wed, Nov 20, 4:40 AM · Restricted Project
vtorri added a comment to D10699: tooling: add configuration file for lgtm.com service.

btw, in code there are also TODO and XXX comments...

Wed, Nov 20, 1:45 AM · efl
vtorri created T8484: warnings in Eet.
Wed, Nov 20, 1:39 AM · Restricted Project
vtorri edited the content of Windows.
Wed, Nov 20, 12:20 AM · efl

Tue, Nov 19

vtorri added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

"Lastly, you've suggested to use cos rather than cosf before at D10467, jsuya agreed this patch as you can see his comment above. and I agree also."

Tue, Nov 19, 11:21 PM · efl
vtorri added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

is this accuracy really needed ?

Tue, Nov 19, 3:46 AM · efl

Sat, Nov 16

vtorri added a comment to D10299: c: possiblility of buffer overflow with strncat..

to mimic Shakespeare:

Sat, Nov 16, 5:33 AM · efl

Fri, Nov 15

vtorri added a comment to D10299: c: possiblility of buffer overflow with strncat..

so, what is the status of this diff ?

Fri, Nov 15, 11:51 PM · efl

Thu, Nov 14

vtorri accepted D10676: efreet: fix typo.
Thu, Nov 14, 9:40 PM · efl

Nov 5 2019

vtorri added inline comments to D10265: c/c++: Removing low priorities warnings..
Nov 5 2019, 8:31 PM · efl

Oct 31 2019

vtorri added a comment to T8360: Error building EFL applications on FreeBSD with default settings.

install_dir option

Oct 31 2019, 4:35 AM · E on FreeBSD

Oct 28 2019

vtorri added a comment to D10467: Eina_Matrix : Use math header for cosf and sinf of rotate function..

btw cosf returns a float, not a double

Oct 28 2019, 11:29 PM · efl

Oct 11 2019

vtorri closed T8334: efreet-mime.pc not correctly generated as Invalid.
Oct 11 2019, 12:18 PM · Restricted Project

Oct 10 2019

vtorri updated subscribers of T8334: efreet-mime.pc not correctly generated.
Oct 10 2019, 9:33 PM · Restricted Project
vtorri triaged T8334: efreet-mime.pc not correctly generated as High priority.
Oct 10 2019, 9:31 PM · Restricted Project

Oct 9 2019

vtorri added a comment to T8310: pthread not found in applications using thread.

we can also increase _XOPEN_SOURCE to 700 (http://man7.org/linux/man-pages/man7/feature_test_macros.7.html)

Oct 9 2019, 8:04 PM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

otoh : https://lists.gnu.org/archive/html/autoconf/2010-08/msg00045.html it seems that we should not use __USE_UNIX98

Oct 9 2019, 8:00 PM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

@raster btw, eina_inline_posix_lock.x does:

Oct 9 2019, 7:46 PM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

@raster i've asked the user to export it to CPPFLAGS and issue vanished of course. I will provide a diff

Oct 9 2019, 7:39 AM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

@bu5hm4n i would say in eina as a user should not do extra work. Eina is using some features, it should enable them, imho.

Oct 9 2019, 5:58 AM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

it is garded. adding -D_POSIX_C_SOURCE=200809L in eina.pc (in CFlags) should be sufficient

Oct 9 2019, 3:26 AM · efl: data types

Oct 8 2019

vtorri requested changes to D10299: c: possiblility of buffer overflow with strncat..

strlcat does not exist on Windows

Oct 8 2019, 2:32 AM · efl

Oct 7 2019

vtorri triaged T8310: pthread not found in applications using thread as Normal priority.
Oct 7 2019, 2:21 AM · efl: data types
vtorri accepted D10270: evil: bring back doxygen intro page for evil library.
Oct 7 2019, 2:03 AM · efl
vtorri accepted D10294: evil: remove stray x character from docs section.
Oct 7 2019, 2:02 AM · efl
vtorri accepted D10295: evil: make it clear in the docs that this library is private to efl.
Oct 7 2019, 2:01 AM · efl

Oct 5 2019

vtorri requested review of D10290: efl_app and efl_exe: support get and set priority of a process on Windows.
Oct 5 2019, 5:25 AM · efl

Oct 4 2019

vtorri added a comment to D10270: evil: bring back doxygen intro page for evil library.

option b) is fine for me

Oct 4 2019, 4:51 AM · efl

Oct 3 2019

vtorri added reviewers for D10279: fix compilation on Windows: stephenmhouston, zmike.

Note that elementary makes ephoto unresponsive. Certainly a problem on Windows. I have plenty of this message:

Oct 3 2019, 6:40 AM
vtorri requested review of D10279: fix compilation on Windows.
Oct 3 2019, 6:37 AM
vtorri added a comment to D6530: stop librsvg dependency..

we have plenty of dependencies, so if we can remove some, that would simplify everybody's life

Oct 3 2019, 5:33 AM · efl

Oct 2 2019

vtorri added a comment to D6530: stop librsvg dependency..

shouldn't this be abandoned and rewritten for meson build system ?

Oct 2 2019, 12:05 PM · efl
vtorri added a comment to D10270: evil: bring back doxygen intro page for evil library.

should we add @private to the doc of the functions ?

Oct 2 2019, 9:29 AM · efl

Sep 30 2019

vtorri added a comment to V46: Will you attend the Enlightenment Developer Days 2019?.

plane reserved

Sep 30 2019, 2:19 PM

Sep 23 2019

vtorri added a reviewer for D10077: eina_array: do not mix declaration and definition: stefan_schmidt.
Sep 23 2019, 7:01 AM · efl
vtorri requested review of D10077: eina_array: do not mix declaration and definition.
Sep 23 2019, 7:00 AM · efl

Sep 16 2019

vtorri added a comment to T7797: problem with EAPI on Windows (again).

no, EFL_BUILD is set in config.h, which is also used by binaries. see toplevel meson.build

Sep 16 2019, 8:50 AM · Restricted Project
vtorri accepted D9962: eina: fix spelling in new eina_file_statgen API.
Sep 16 2019, 2:53 AM · efl
vtorri added a comment to D9962: eina: fix spelling in new eina_file_statgen API.

maybe this should have been detected with a unit test too, no ?

Sep 16 2019, 1:10 AM · efl

Sep 13 2019

vtorri accepted D9914: tests/edje: handle file modifications properly on windows.
Sep 13 2019, 11:12 AM · Restricted Project
vtorri added a comment to D9914: tests/edje: handle file modifications properly on windows.

i can't try the test, but i tried the code on a file, and it works with the change mentioned above

Sep 13 2019, 1:18 AM · Restricted Project
vtorri requested changes to D9914: tests/edje: handle file modifications properly on windows.
Sep 13 2019, 1:18 AM · Restricted Project
vtorri added inline comments to D9914: tests/edje: handle file modifications properly on windows.
Sep 13 2019, 12:48 AM · Restricted Project

Sep 12 2019

vtorri added a comment to D9927: meson.build: allow to disable tiff evas loader.

i should add a typedef in evil_private.h then. ssize_t does not exist on Windows but SSIZE_T does

Sep 12 2019, 1:59 PM · efl
vtorri added a comment to D9927: meson.build: allow to disable tiff evas loader.

why is there a diff for benchmark ?

Sep 12 2019, 1:43 PM · efl
vtorri closed T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used as Resolved.
Sep 12 2019, 12:04 PM · efl (efl-1.23), Restricted Project
vtorri updated the diff for D9926: efl_app_test_promise: fix warning (no returned value).

unmark err as unused

Sep 12 2019, 10:01 AM · efl
vtorri requested review of D9926: efl_app_test_promise: fix warning (no returned value).
Sep 12 2019, 10:01 AM · efl
vtorri requested review of D9925: eio: fix warning.
Sep 12 2019, 9:52 AM · efl

Sep 11 2019

vtorri added inline comments to D9914: tests/edje: handle file modifications properly on windows.
Sep 11 2019, 12:32 PM · Restricted Project
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

see D9913

Sep 11 2019, 12:12 PM · efl (efl-1.23), Restricted Project
vtorri requested review of D9913: Evil: fix mmap() and define HAVE_MMAP.
Sep 11 2019, 12:11 PM · efl
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

mprotect is in evil now. i have to define HAVE_MMAP in evil_mman.h to check if there is no problem. I'll do that today

Sep 11 2019, 3:16 AM · efl (efl-1.23), Restricted Project

Sep 5 2019

vtorri added a reviewer for D9848: evil: add newline at end of meson.build: bu5hm4n.
Sep 5 2019, 4:52 AM · efl
vtorri requested review of D9848: evil: add newline at end of meson.build.
Sep 5 2019, 4:51 AM · efl
vtorri closed D9847: Evil: remove installation of header and pc files, remove from git Evil.h.
Sep 5 2019, 4:21 AM · efl
vtorri added a reviewer for D9847: Evil: remove installation of header and pc files, remove from git Evil.h: stefan_schmidt.
Sep 5 2019, 2:22 AM · efl
vtorri requested review of D9847: Evil: remove installation of header and pc files, remove from git Evil.h.
Sep 5 2019, 2:21 AM · efl

Sep 4 2019

vtorri added a reviewer for D9839: Efreet_Uri: fix URI decoding when a Windows path (letter followed by :) is passed to efreet_uri_decode(): stefan_schmidt.
Sep 4 2019, 11:17 AM · efl
vtorri updated subscribers of D9839: Efreet_Uri: fix URI decoding when a Windows path (letter followed by :) is passed to efreet_uri_decode().

@stefan_schmidt is this a blocker for 1.23 ?

Sep 4 2019, 11:16 AM · efl
vtorri requested review of D9839: Efreet_Uri: fix URI decoding when a Windows path (letter followed by :) is passed to efreet_uri_decode().
Sep 4 2019, 10:57 AM · efl
vtorri requested review of D9837: fix parsing module path on Windows.
Sep 4 2019, 8:36 AM · efl
vtorri requested review of D9834: use eina_strndup() instead of the GNU extension strndup(). Fix also a warning with CreateFile().
Sep 4 2019, 12:00 AM

Sep 3 2019

vtorri added a comment to D8543: eina: check bswap* in byteswap.h only if it exists, otherwise check if gcc builtin bswap* exists.

actually, i've just checked : eina_config.h is generated independantly of eina_config.h.in

Sep 3 2019, 12:29 PM · efl
vtorri added a comment to D9817: freetype: Prevent lose of data when fixed point divide calculation..

I just want to mention that long is a 32 bits type on Windows 64 bits, so you must pay attention at what is done on this platform when using long

Sep 3 2019, 4:29 AM · efl

Aug 31 2019

vtorri added a reviewer for D9810: Use S_ISLNK macro only if it is defined: stephenmhouston.
Aug 31 2019, 8:06 AM
vtorri requested review of D9810: Use S_ISLNK macro only if it is defined.
Aug 31 2019, 8:05 AM
vtorri added a reviewer for D9809: thumbnailer : use cross-platform eina_htonl() instead of htonl(): stephenmhouston.
Aug 31 2019, 7:57 AM
vtorri requested review of D9809: thumbnailer : use cross-platform eina_htonl() instead of htonl().
Aug 31 2019, 7:56 AM
vtorri added a comment to D8543: eina: check bswap* in byteswap.h only if it exists, otherwise check if gcc builtin bswap* exists.

after checking, eina_config.h has no EINA_HAS_BUILTIN macro (at least on Windows) with latest git of today(august 31st 2019) with gcc as compiler. Is it normal ?

Aug 31 2019, 7:47 AM · efl
vtorri added a reviewer for D9808: evil will be soon private to the EFL, and _WIN32 is always defined by Windows compilers: stephenmhouston.
Aug 31 2019, 7:29 AM
vtorri requested review of D9808: evil will be soon private to the EFL, and _WIN32 is always defined by Windows compilers.
Aug 31 2019, 7:29 AM

Aug 26 2019

vtorri added a comment to D9736: meson : enable mono build option by default.
Aug 26 2019, 12:31 AM · efl

Aug 23 2019

vtorri edited the content of Windows.
Aug 23 2019, 4:06 AM · efl
vtorri edited the content of Windows.
Aug 23 2019, 3:59 AM · efl

Aug 21 2019

vtorri closed T8147: remove build of upower ecore module on Windows as Resolved.
Aug 21 2019, 10:20 PM · Restricted Project

Aug 20 2019

vtorri requested review of D9658: Ecore : does not build linux-only ecore modules on Windows.
Aug 20 2019, 10:43 PM · efl

Aug 19 2019

vtorri closed T8104: macros used to detect mmap functions as Resolved.
Aug 19 2019, 11:36 AM · Restricted Project

Aug 18 2019

vtorri added a comment to T8104: macros used to detect mmap functions.

diff to review : #9542

Aug 18 2019, 9:26 PM · Restricted Project
vtorri updated the diff for D9542: make mman.h private.

include mman.h in raw generic module

Aug 18 2019, 12:55 PM · efl
vtorri added a comment to D9542: make mman.h private.

I don't understand. It's like the other EFL header inclusions which are not part of the lib. Look at all the Eina.h inclusions for examples

Aug 18 2019, 11:19 AM · efl
vtorri triaged T8147: remove build of upower ecore module on Windows as Normal priority.
Aug 18 2019, 11:01 AM · Restricted Project

Aug 10 2019

vtorri updated the summary of D9542: make mman.h private.
Aug 10 2019, 8:49 PM · efl
vtorri requested review of D9542: make mman.h private.
Aug 10 2019, 8:46 PM · efl

Aug 8 2019

vtorri added a comment to T8104: macros used to detect mmap functions.

i plan to remove sys/mman.h from evil and just a private evil_mman.h (included by evil_private.h)

Aug 8 2019, 3:13 AM · Restricted Project

Aug 6 2019

vtorri added a comment to T8104: macros used to detect mmap functions.

there is no mman.h on Windows, only in Evil. It's currently exported. I want to make it private in Evil (creates an evil_mman.h, included in evil_private.h), then :

Aug 6 2019, 3:07 AM · Restricted Project
vtorri closed D9494: remove useless definition of the macro HAVE_MMAN_H.
Aug 6 2019, 1:01 AM · efl

Aug 5 2019

vtorri added a comment to T8104: macros used to detect mmap functions.

also, there are a lot of files that include sys/mman.h without guarding it with HAVE_SYS_MMAN_H. They must be guarded, right ?

Aug 5 2019, 7:01 AM · Restricted Project
vtorri added a comment to T8104: macros used to detect mmap functions.

@raster D9493
@bu5hm4n D9494

Aug 5 2019, 4:32 AM · Restricted Project
vtorri requested review of D9494: remove useless definition of the macro HAVE_MMAN_H.
Aug 5 2019, 4:27 AM · efl

Aug 4 2019

vtorri requested review of D9493: evil: add mprotect() and fix a bit mmap(). Elm_test is working.
Aug 4 2019, 11:18 PM · efl
vtorri added a comment to T8104: macros used to detect mmap functions.

@raster yes, they are functionnaly equivalent. i've already implemented it on my computer. I'll provide a diff soon for it

Aug 4 2019, 9:04 PM · Restricted Project
vtorri added a comment to T8104: macros used to detect mmap functions.

@bu5hm4n you added the definition of HAVE_MMAN_H : https://git.enlightenment.org/core/efl.git/commit/header_checks/meson.build?id=46d464e5bfc10398461a33a2256c1c58d509dd1a

Aug 4 2019, 8:15 AM · Restricted Project
vtorri added a comment to T8104: macros used to detect mmap functions.

@raster VirtualProtect can be used. Also, mprotect exists in FreeBSD since BSD 4.4 [1](quite old), and is in POSIX 2001 [2] and solaris

Aug 4 2019, 6:56 AM · Restricted Project

Aug 3 2019

vtorri triaged T8104: macros used to detect mmap functions as High priority.
Aug 3 2019, 6:27 AM · Restricted Project