Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (338 w, 3 d)
Availability
Available

Recent Activity

Yesterday

vtorri edited the content of Windows.
Fri, Aug 23, 4:06 AM · efl
vtorri edited the content of Windows.
Fri, Aug 23, 3:59 AM · efl

Wed, Aug 21

vtorri closed T8147: remove build of upower ecore module on Windows as Resolved.
Wed, Aug 21, 10:20 PM · Restricted Project

Tue, Aug 20

vtorri requested review of D9658: Ecore : does not build linux-only ecore modules on Windows.
Tue, Aug 20, 10:43 PM · efl

Mon, Aug 19

vtorri closed T8104: macros used to detect mmap functions as Resolved.
Mon, Aug 19, 11:36 AM · Restricted Project

Sun, Aug 18

vtorri added a comment to T8104: macros used to detect mmap functions.

diff to review : #9542

Sun, Aug 18, 9:26 PM · Restricted Project
vtorri updated the diff for D9542: make mman.h private.

include mman.h in raw generic module

Sun, Aug 18, 12:55 PM · efl
vtorri added a comment to D9542: make mman.h private.

I don't understand. It's like the other EFL header inclusions which are not part of the lib. Look at all the Eina.h inclusions for examples

Sun, Aug 18, 11:19 AM · efl
vtorri triaged T8147: remove build of upower ecore module on Windows as Normal priority.
Sun, Aug 18, 11:01 AM · Restricted Project

Sat, Aug 10

vtorri updated the summary of D9542: make mman.h private.
Sat, Aug 10, 8:49 PM · efl
vtorri requested review of D9542: make mman.h private.
Sat, Aug 10, 8:46 PM · efl

Thu, Aug 8

vtorri added a comment to T8104: macros used to detect mmap functions.

i plan to remove sys/mman.h from evil and just a private evil_mman.h (included by evil_private.h)

Thu, Aug 8, 3:13 AM · Restricted Project

Tue, Aug 6

vtorri added a comment to T8104: macros used to detect mmap functions.

there is no mman.h on Windows, only in Evil. It's currently exported. I want to make it private in Evil (creates an evil_mman.h, included in evil_private.h), then :

Tue, Aug 6, 3:07 AM · Restricted Project
vtorri closed D9494: remove useless definition of the macro HAVE_MMAN_H.
Tue, Aug 6, 1:01 AM · efl

Mon, Aug 5

vtorri added a comment to T8104: macros used to detect mmap functions.

also, there are a lot of files that include sys/mman.h without guarding it with HAVE_SYS_MMAN_H. They must be guarded, right ?

Mon, Aug 5, 7:01 AM · Restricted Project
vtorri added a comment to T8104: macros used to detect mmap functions.

@raster D9493
@bu5hm4n D9494

Mon, Aug 5, 4:32 AM · Restricted Project
vtorri requested review of D9494: remove useless definition of the macro HAVE_MMAN_H.
Mon, Aug 5, 4:27 AM · efl

Sun, Aug 4

vtorri requested review of D9493: evil: add mprotect() and fix a bit mmap(). Elm_test is working.
Sun, Aug 4, 11:18 PM · efl
vtorri added a comment to T8104: macros used to detect mmap functions.

@raster yes, they are functionnaly equivalent. i've already implemented it on my computer. I'll provide a diff soon for it

Sun, Aug 4, 9:04 PM · Restricted Project
vtorri added a comment to T8104: macros used to detect mmap functions.

@bu5hm4n you added the definition of HAVE_MMAN_H : https://git.enlightenment.org/core/efl.git/commit/header_checks/meson.build?id=46d464e5bfc10398461a33a2256c1c58d509dd1a

Sun, Aug 4, 8:15 AM · Restricted Project
vtorri added a comment to T8104: macros used to detect mmap functions.

@raster VirtualProtect can be used. Also, mprotect exists in FreeBSD since BSD 4.4 [1](quite old), and is in POSIX 2001 [2] and solaris

Sun, Aug 4, 6:56 AM · Restricted Project

Sat, Aug 3

vtorri triaged T8104: macros used to detect mmap functions as High priority.
Sat, Aug 3, 6:27 AM · Restricted Project

Thu, Aug 1

vtorri added a comment to D9470: examples: cast to uintptr_t instead of long.

i do get warnings on 64 bits, that's why i've spotted them

Thu, Aug 1, 3:54 AM · efl

Wed, Jul 31

vtorri requested review of D9470: examples: cast to uintptr_t instead of long.
Wed, Jul 31, 11:44 PM · efl

Sun, Jul 28

vtorri closed T8062: eina_inline_lock_posix.x : execinfo.h not found on Windows as Resolved.

fixed by D9392

Sun, Jul 28, 2:17 AM · Restricted Project

Sat, Jul 27

vtorri added a comment to D9420: Evil: remove pwd code in Evil and fix compilation failures after the removal.

i'll be away from the computer with the changes until end of august. If changes are requested, apply the patch and do the modifications after, thanks

Sat, Jul 27, 10:36 PM · efl
vtorri added a comment to D9392: Eina: define EINA_HAVE_DEBUG_THREADS only if backtrace() in execinfo.h is available.

i'll be away from the computer with the changes until end of august. If changes are requested, apply the patch and do the modifications after, thanks

Sat, Jul 27, 10:34 PM · efl
vtorri added a comment to D9393: Eio: enable eio_file_chown if chown is available on the platform.

i'll be away from the computer with the changes until en of august. If changes are requested, apply the patch and do the modifications after, thanks

Sat, Jul 27, 10:34 PM · efl
vtorri requested review of D9420: Evil: remove pwd code in Evil and fix compilation failures after the removal.
Sat, Jul 27, 12:01 AM · efl

Jul 25 2019

vtorri updated the diff for D9393: Eio: enable eio_file_chown if chown is available on the platform.

use error_cb to report error

Jul 25 2019, 12:20 PM · efl
vtorri added a comment to D9393: Eio: enable eio_file_chown if chown is available on the platform.

which error should I use ? 0 ?

Jul 25 2019, 10:41 AM · efl
vtorri added a comment to D9393: Eio: enable eio_file_chown if chown is available on the platform.

you mean calling :

Jul 25 2019, 10:10 AM · efl
vtorri added a child revision for D9393: Eio: enable eio_file_chown if chown is available on the platform: D9392: Eina: define EINA_HAVE_DEBUG_THREADS only if backtrace() in execinfo.h is available.
Jul 25 2019, 9:42 AM · efl
vtorri added a parent revision for D9392: Eina: define EINA_HAVE_DEBUG_THREADS only if backtrace() in execinfo.h is available: D9393: Eio: enable eio_file_chown if chown is available on the platform.
Jul 25 2019, 9:42 AM · efl
vtorri added a comment to D9393: Eio: enable eio_file_chown if chown is available on the platform.

verify that config.h has HAVE_CHOWN and HAVE_GETPWENT in config.h on linux

Jul 25 2019, 7:39 AM · efl
vtorri requested review of D9393: Eio: enable eio_file_chown if chown is available on the platform.
Jul 25 2019, 7:38 AM · efl
vtorri added a comment to D9392: Eina: define EINA_HAVE_DEBUG_THREADS only if backtrace() in execinfo.h is available.

fix T8062

Jul 25 2019, 6:57 AM · efl
vtorri requested review of D9392: Eina: define EINA_HAVE_DEBUG_THREADS only if backtrace() in execinfo.h is available.
Jul 25 2019, 6:56 AM · efl

Jul 24 2019

vtorri added a comment to D9383: README & INSTALL : add md extension.

are they really in md format ?

Jul 24 2019, 1:54 AM · efl

Jul 23 2019

vtorri added a comment to T8062: eina_inline_lock_posix.x : execinfo.h not found on Windows.

this patch disable debugging threads on windows and the compilation passes eina (until the next error in eldbus...)

Jul 23 2019, 12:54 PM · Restricted Project
vtorri added a comment to T8062: eina_inline_lock_posix.x : execinfo.h not found on Windows.

or maybe define EINA_HAVE_DEBUG_THREADS if backtrace in execinfo.h exists :

Jul 23 2019, 12:47 PM · Restricted Project
vtorri added a comment to T8062: eina_inline_lock_posix.x : execinfo.h not found on Windows.

maybe we can at least guard this with HAVE_EXECINFO_H ?

Jul 23 2019, 4:47 AM · Restricted Project
vtorri added a comment to T8062: eina_inline_lock_posix.x : execinfo.h not found on Windows.

yes, but there are other problems that appear later. All the eina_debut stuff actually. @raster told me that anyway it's not working anymore. I'll let him explain better than me

Jul 23 2019, 4:46 AM · Restricted Project
vtorri added a comment to T8062: eina_inline_lock_posix.x : execinfo.h not found on Windows.

something like that :

Jul 23 2019, 1:17 AM · Restricted Project

Jul 22 2019

vtorri added a comment to T8062: eina_inline_lock_posix.x : execinfo.h not found on Windows.

note that backtrace() can be replaced on Windows with CaptureStackBackTrace, see :

Jul 22 2019, 10:16 PM · Restricted Project
vtorri triaged T8062: eina_inline_lock_posix.x : execinfo.h not found on Windows as Showstopper Issues priority.
Jul 22 2019, 10:58 AM · Restricted Project

Jul 18 2019

vtorri added a comment to D9352: meson build: update evas search for harfbuzz.

what about line 151 which already adds harfbuzz as dep ?

Jul 18 2019, 2:05 AM · efl
vtorri closed D9339: Eina vpath: remove support of ~username vpath on Windows.
Jul 18 2019, 12:36 AM · efl

Jul 17 2019

vtorri added a comment to D9339: Eina vpath: remove support of ~username vpath on Windows.

a test in header_check/meson.build should be added then of course

Jul 17 2019, 9:09 PM · efl
vtorri added a comment to D9339: Eina vpath: remove support of ~username vpath on Windows.

HAVE_GETPWENT is wrong, btw, no ? it should be HAVE_GETPWNAM

Jul 17 2019, 9:07 PM · efl
vtorri updated the diff for D9339: Eina vpath: remove support of ~username vpath on Windows.

use HAVE_GETPWENT to know if user fetching is available directly in vpath_resolve

Jul 17 2019, 9:05 PM · efl
vtorri added a comment to D9339: Eina vpath: remove support of ~username vpath on Windows.

why doing all the tests and calling a function for nothing ? If you want me to add a more explicit error message, like ERR("Windows platform does not support ~username vpath"); no problem,

Jul 17 2019, 10:16 AM · efl
vtorri added a comment to D9339: Eina vpath: remove support of ~username vpath on Windows.

@bu5hm4n where ? there is just a call to ERR() and it returns 0. You want me to add a call to ERR() ?

Jul 17 2019, 10:05 AM · efl
vtorri requested review of D9339: Eina vpath: remove support of ~username vpath on Windows.
Jul 17 2019, 9:51 AM · efl

Jul 16 2019

vtorri updated the summary of D9326: Evil: remove getpwuid() from Evil..
Jul 16 2019, 1:13 AM · efl
vtorri requested review of D9326: Evil: remove getpwuid() from Evil..
Jul 16 2019, 1:12 AM · efl

Jul 12 2019

vtorri added a comment to D9302: README: update COMPILING AND INSTALLING section.

make doc too ?

Jul 12 2019, 9:09 AM · efl

Jul 11 2019

vtorri updated subscribers of D9284: draw static lib: use sse3 instructions set even on Windows.

@bu5hm4n no, it's you who added this test : https://git.enlightenment.org/core/efl.git/commit/src/static_libs/draw/meson.build?id=500a36ba3d3d00ed292ed3e85bb9ac40a55bd2a9

Jul 11 2019, 10:13 AM · efl
vtorri added a reviewer for D9284: draw static lib: use sse3 instructions set even on Windows: bu5hm4n.
Jul 11 2019, 7:26 AM · efl
vtorri requested review of D9284: draw static lib: use sse3 instructions set even on Windows.
Jul 11 2019, 7:24 AM · efl

Jun 28 2019

vtorri added a comment to D7590: Exactness: code importation.

i'll will try to test on Windows next week

Jun 28 2019, 10:17 AM · efl

Jun 27 2019

vtorri accepted D9192: meson: add some config definitions.

lgtm

Jun 27 2019, 2:02 AM · efl

Jun 25 2019

vtorri requested changes to D9179: build: Add a option to generate debuginfo.

Im' against that. CFLAGS exists for such purpose

Jun 25 2019, 11:48 PM · efl
vtorri added a comment to D9153: evas_common_format_color_parse: support color names.

bsearch exists on windows : https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/bsearch?view=vs-2019

Jun 25 2019, 9:22 AM · efl
vtorri added a comment to D7590: Exactness: code importation.

when you have time, can you check, please ?

Jun 25 2019, 6:30 AM · efl
vtorri added a comment to D9155: evas_common: use memcpy to copy pixel buffer.

can you please modify it so that evas_common_copy_pixels_c() is inlined and see if there are perf improvements ?

Jun 25 2019, 4:26 AM · efl

Jun 24 2019

vtorri accepted D9153: evas_common_format_color_parse: support color names.
Jun 24 2019, 11:59 PM · efl
vtorri requested changes to D7590: Exactness: code importation.

is it working on Windows ?

Jun 24 2019, 10:49 AM · efl
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

that's what is done in configure.ac. I first trust what is in it.

Jun 24 2019, 7:45 AM · Restricted Project
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

do a git grep EINA_DEBUG_MALLOC

Jun 24 2019, 7:22 AM · Restricted Project
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

in src/lib/eina/meson.build, instead of

Jun 24 2019, 7:02 AM · Restricted Project

Jun 23 2019

vtorri triaged T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used as High priority.
Jun 23 2019, 7:41 AM · Restricted Project
vtorri created T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.
Jun 23 2019, 7:40 AM · Restricted Project

Jun 22 2019

vtorri added a comment to D9140: Eina: more macros and Types.

should EAPI_INTERNAL EAPI really be part of the API ?

Jun 22 2019, 3:36 AM · efl
vtorri added a comment to D9155: evas_common: use memcpy to copy pixel buffer.

what about making this function inline ?

Jun 22 2019, 3:34 AM · efl
vtorri added inline comments to D9153: evas_common_format_color_parse: support color names.
Jun 22 2019, 3:25 AM · efl

Jun 21 2019

vtorri requested review of D9154: remove last bits of Evil.h in tests and use evil_private.h instead.
Jun 21 2019, 11:20 PM · efl
vtorri added inline comments to D9153: evas_common_format_color_parse: support color names.
Jun 21 2019, 8:27 PM · efl
vtorri requested changes to D9153: evas_common_format_color_parse: support color names.
Jun 21 2019, 8:23 PM · efl
vtorri edited the content of Windows.
Jun 21 2019, 7:34 AM · efl
vtorri edited the content of Windows.
Jun 21 2019, 12:14 AM · efl

Jun 20 2019

vtorri requested review of D9129: tests: fix warnings and undef ref on Windows (using meson :-) ).
Jun 20 2019, 1:02 AM · efl

Jun 19 2019

vtorri added a member for reviewers: vtorri.
Jun 19 2019, 6:20 AM

Jun 17 2019

vtorri added a comment to T7986: define HAVE_REALPATH on Windows with meson.

cf D9107

Jun 17 2019, 10:17 PM · Restricted Project
vtorri requested review of D9107: define HAVE_REALPATH in evil_stdlib.h.
Jun 17 2019, 10:17 PM · efl
vtorri updated the summary of D9106: Ecore net dialer Windows example: fix undeclared symbols.
Jun 17 2019, 5:47 AM · efl

Jun 16 2019

vtorri added a comment to D9027: autotools: REMOVAL!.

i wasn't aware of this diff :-)

Jun 16 2019, 10:44 PM · efl
vtorri requested review of D9106: Ecore net dialer Windows example: fix undeclared symbols.
Jun 16 2019, 9:15 PM · efl

Jun 1 2019

vtorri edited the content of Windows.
Jun 1 2019, 3:58 AM · efl

May 28 2019

vtorri closed T7985: Windows: ejde_cc can not create edj files anymore as Resolved.
May 28 2019, 9:33 AM · Restricted Project
vtorri closed T7985: Windows: ejde_cc can not create edj files anymore, a subtask of T7780: remove autotools, as Resolved.
May 28 2019, 9:33 AM · Restricted Project, efl: meson
vtorri added a comment to D9030: Evil: fix infinite loop with setlocale.

the problem is not EAPI, the problem is evil_locale.c which includes evil_private.h wich includes evil_macro_wrapper.h which defines setlocale() from evil_setlocale, setlocale being used in evil_locale.c

May 28 2019, 7:45 AM · efl
vtorri closed T7812: meson build system should manage c++ header files as Invalid.
May 28 2019, 6:01 AM · Restricted Project, efl: meson
vtorri closed T7812: meson build system should manage c++ header files, a subtask of T7780: remove autotools, as Invalid.
May 28 2019, 6:01 AM · Restricted Project, efl: meson
vtorri added a comment to D9030: Evil: fix infinite loop with setlocale.

i don't want to add another header file just for evil_locale.c

May 28 2019, 6:00 AM · efl
vtorri added a comment to T7797: problem with EAPI on Windows (again).

for each binary, EFL_BUILD must not be set. For each library, EFL_BUILD must be set. We must be sure that this is correctly done with meson. As I have said, it's a reminder for meson (see last line of my original message)

May 28 2019, 3:00 AM · efl: api
vtorri added a comment to T7985: Windows: ejde_cc can not create edj files anymore.

with autotools (me), edje_cc at least displays help
with meson , zmike told me that edje_cc displays nothing

May 28 2019, 2:43 AM · Restricted Project
vtorri added a parent task for T7986: define HAVE_REALPATH on Windows with meson: T7782: verify config.h equivalence.
May 28 2019, 2:08 AM · Restricted Project
vtorri added a subtask for T7782: verify config.h equivalence: T7986: define HAVE_REALPATH on Windows with meson.
May 28 2019, 2:08 AM · Restricted Project, efl: meson
vtorri created T7986: define HAVE_REALPATH on Windows with meson.
May 28 2019, 2:08 AM · Restricted Project