Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (329 w, 6 d)
Availability
Available

Recent Activity

Yesterday

vtorri accepted D9153: evas_common_format_color_parse: support color names.
Mon, Jun 24, 11:59 PM · efl
vtorri requested changes to D7590: Exactness: code importation.

is it working on Windows ?

Mon, Jun 24, 10:49 AM · efl
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

that's what is done in configure.ac. I first trust what is in it.

Mon, Jun 24, 7:45 AM · Restricted Project
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

do a git grep EINA_DEBUG_MALLOC

Mon, Jun 24, 7:22 AM · Restricted Project
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

in src/lib/eina/meson.build, instead of

Mon, Jun 24, 7:02 AM · Restricted Project

Sun, Jun 23

vtorri triaged T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used as High priority.
Sun, Jun 23, 7:41 AM · Restricted Project
vtorri created T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.
Sun, Jun 23, 7:40 AM · Restricted Project

Sat, Jun 22

vtorri added a comment to D9140: Eina: more macros and Types.

should EAPI_INTERNAL EAPI really be part of the API ?

Sat, Jun 22, 3:36 AM · efl
vtorri added a comment to D9155: evas_common: use memcpy to copy pixel buffer.

what about making this function inline ?

Sat, Jun 22, 3:34 AM · efl
vtorri added inline comments to D9153: evas_common_format_color_parse: support color names.
Sat, Jun 22, 3:25 AM · efl

Fri, Jun 21

vtorri requested review of D9154: remove last bits of Evil.h in tests and use evil_private.h instead.
Fri, Jun 21, 11:20 PM · efl
vtorri added inline comments to D9153: evas_common_format_color_parse: support color names.
Fri, Jun 21, 8:27 PM · efl
vtorri requested changes to D9153: evas_common_format_color_parse: support color names.
Fri, Jun 21, 8:23 PM · efl
vtorri edited the content of Windows.
Fri, Jun 21, 7:34 AM · efl
vtorri edited the content of Windows.
Fri, Jun 21, 12:14 AM · efl

Thu, Jun 20

vtorri requested review of D9129: tests: fix warnings and undef ref on Windows (using meson :-) ).
Thu, Jun 20, 1:02 AM · efl

Wed, Jun 19

vtorri added a member for reviewers: vtorri.
Wed, Jun 19, 6:20 AM

Mon, Jun 17

vtorri added a comment to T7986: define HAVE_REALPATH on Windows with meson.

cf D9107

Mon, Jun 17, 10:17 PM · Restricted Project
vtorri requested review of D9107: define HAVE_REALPATH in evil_stdlib.h.
Mon, Jun 17, 10:17 PM · efl
vtorri updated the summary of D9106: Ecore net dialer Windows example: fix undeclared symbols.
Mon, Jun 17, 5:47 AM · efl

Sun, Jun 16

vtorri added a comment to D9027: autotools: REMOVAL!.

i wasn't aware of this diff :-)

Sun, Jun 16, 10:44 PM · efl
vtorri requested review of D9106: Ecore net dialer Windows example: fix undeclared symbols.
Sun, Jun 16, 9:15 PM · efl

Sat, Jun 1

vtorri edited the content of Windows.
Sat, Jun 1, 3:58 AM · efl

Tue, May 28

vtorri closed T7985: Windows: ejde_cc can not create edj files anymore as Resolved.
Tue, May 28, 9:33 AM · Restricted Project
vtorri closed T7985: Windows: ejde_cc can not create edj files anymore, a subtask of T7780: remove autotools, as Resolved.
Tue, May 28, 9:33 AM · Restricted Project, efl: meson
vtorri added a comment to D9030: Evil: fix infinite loop with setlocale.

the problem is not EAPI, the problem is evil_locale.c which includes evil_private.h wich includes evil_macro_wrapper.h which defines setlocale() from evil_setlocale, setlocale being used in evil_locale.c

Tue, May 28, 7:45 AM · efl
vtorri closed T7812: meson build system should manage c++ header files as Invalid.
Tue, May 28, 6:01 AM · Restricted Project, efl: meson
vtorri closed T7812: meson build system should manage c++ header files, a subtask of T7780: remove autotools, as Invalid.
Tue, May 28, 6:01 AM · Restricted Project, efl: meson
vtorri added a comment to D9030: Evil: fix infinite loop with setlocale.

i don't want to add another header file just for evil_locale.c

Tue, May 28, 6:00 AM · efl
vtorri added a comment to T7797: problem with EAPI on Windows (again).

for each binary, EFL_BUILD must not be set. For each library, EFL_BUILD must be set. We must be sure that this is correctly done with meson. As I have said, it's a reminder for meson (see last line of my original message)

Tue, May 28, 3:00 AM · efl: api
vtorri added a comment to T7985: Windows: ejde_cc can not create edj files anymore.

with autotools (me), edje_cc at least displays help
with meson , zmike told me that edje_cc displays nothing

Tue, May 28, 2:43 AM · Restricted Project
vtorri added a parent task for T7986: define HAVE_REALPATH on Windows with meson: T7782: verify config.h equivalence.
Tue, May 28, 2:08 AM · Restricted Project
vtorri added a subtask for T7782: verify config.h equivalence: T7986: define HAVE_REALPATH on Windows with meson.
Tue, May 28, 2:08 AM · Restricted Project, efl: meson
vtorri created T7986: define HAVE_REALPATH on Windows with meson.
Tue, May 28, 2:08 AM · Restricted Project
vtorri added a comment to T7782: verify config.h equivalence.

i've not completely checked the Windows part yet

Tue, May 28, 2:06 AM · Restricted Project, efl: meson

Mon, May 27

vtorri added a task to D9030: Evil: fix infinite loop with setlocale: T7985: Windows: ejde_cc can not create edj files anymore.
Mon, May 27, 3:57 AM · efl
vtorri added a revision to T7985: Windows: ejde_cc can not create edj files anymore: D9030: Evil: fix infinite loop with setlocale.
Mon, May 27, 3:57 AM · Restricted Project
vtorri requested review of D9030: Evil: fix infinite loop with setlocale.
Mon, May 27, 2:08 AM · efl

May 26 2019

vtorri added a parent task for T7985: Windows: ejde_cc can not create edj files anymore: T7780: remove autotools.
May 26 2019, 2:44 AM · Restricted Project
vtorri added a subtask for T7780: remove autotools: T7985: Windows: ejde_cc can not create edj files anymore.
May 26 2019, 2:44 AM · Restricted Project, efl: meson
vtorri triaged T7985: Windows: ejde_cc can not create edj files anymore as Showstopper Issues priority.
May 26 2019, 2:43 AM · Restricted Project

May 25 2019

vtorri requested review of D9025: ecore_evas win32: fix warning reported by clang.
May 25 2019, 11:10 PM · efl
vtorri added a reviewer for D9024: Evas gesture: do not use abs when dealing with double, use fabs instead: Jaehyun.
May 25 2019, 10:55 PM · efl
vtorri requested review of D9024: Evas gesture: do not use abs when dealing with double, use fabs instead.
May 25 2019, 10:51 PM · efl
vtorri edited the content of Windows.
May 25 2019, 12:03 PM · efl

May 23 2019

vtorri accepted D8945: efl/gesture: include .h file in private header, not .c file.
May 23 2019, 10:54 AM · Restricted Project
vtorri added a comment to T7983: update lz4 static lib.

latest release is 1.9.1, released in april 2019

May 23 2019, 5:08 AM · Restricted Project
vtorri created T7983: update lz4 static lib.
May 23 2019, 5:05 AM · Restricted Project

May 22 2019

vtorri requested review of D8939: Emotion gst1 module: fix "empty if statement" warning.
May 22 2019, 9:39 PM · efl
vtorri requested review of D8938: Emotion gst1 module: remove whitespaces.
May 22 2019, 9:22 PM · efl

May 21 2019

vtorri requested review of D8933: include evil_private.h in last files, and disable symbolic links on Windows in a couple of files.
May 21 2019, 1:06 PM · efl
vtorri requested review of D8931: Eio: avoid symbolic link on Windows.
May 21 2019, 10:32 AM · efl

May 20 2019

vtorri requested review of D8925: remove Evil.h when not necessary, include evil_private.h when necessary.
May 20 2019, 5:55 AM · efl
vtorri added a comment to T7960: recent addition of gestures breaks linking on Windows.

not sure, but in efl_canvas_gesture_private.h, there is the inclusion of a source file :

May 20 2019, 4:47 AM · regression, Restricted Project
vtorri triaged T7977: elm_main is dlopen-ing eldbus for UNix but not mac or Windows as High priority.
May 20 2019, 12:48 AM · efl

May 19 2019

vtorri requested review of D8921: Evas: remove Evil.h when not needed and use evil_private when needed.
May 19 2019, 8:40 AM · efl

May 17 2019

vtorri added a comment to T7782: verify config.h equivalence.

there is no EINA_HAVE_BSWAP* defines on windows in eina_config.h

May 17 2019, 11:51 PM · Restricted Project, efl: meson
vtorri requested review of D8917: bin/ecore_evas: remove useless inclusion of Evil.h.
May 17 2019, 11:01 AM · efl
vtorri requested review of D8911: bin/eet and ecore_con: remove Evil.h when not necessary and include evil_private.h when necessary.
May 17 2019, 4:31 AM · efl

May 16 2019

vtorri requested review of D8909: Eet: remove useless inclusion of Evil.h.
May 16 2019, 10:17 PM · efl
vtorri requested review of D8908: bin/efl and ecore: include evil_private.h when appropriate.
May 16 2019, 3:08 PM · efl
vtorri requested review of D8905: Eo: replace Evil.h with evil_private.h.
May 16 2019, 5:28 AM · efl
vtorri requested review of D8904: Evil: remove fall through warning.
May 16 2019, 5:10 AM · efl
vtorri requested review of D8903: Eina: replace Evil.h with evil_private.h and remove Evil.h when not necessary.
May 16 2019, 5:05 AM · efl

May 15 2019

vtorri accepted D8671: Revert "remove vpath test for user dir the test was broken and fixing is insane".

ok, though there is a getpwuid in Evil
anyway, this code will not be compiled on Windows, so fine for me

May 15 2019, 6:45 AM · efl
vtorri added a comment to D8671: Revert "remove vpath test for user dir the test was broken and fixing is insane".

getuid does not exist on Windows, so i guess that you should add another guard

May 15 2019, 6:20 AM · efl

May 14 2019

vtorri triaged T7960: recent addition of gestures breaks linking on Windows as Showstopper Issues priority.
May 14 2019, 6:23 AM · regression, Restricted Project
vtorri updated the summary of D8893: Evil: move the inclusion of all headers in evil_private.h.
May 14 2019, 5:38 AM · efl
vtorri requested review of D8893: Evil: move the inclusion of all headers in evil_private.h.
May 14 2019, 5:36 AM · efl
vtorri abandoned D8891: Evil: remove usage of EVIL_UNUSED and just cast to (void).
May 14 2019, 3:10 AM · efl
vtorri added a comment to D8891: Evil: remove usage of EVIL_UNUSED and just cast to (void).

it's just for 3 files... I remove 7 lines and add 4, so less code :-)

May 14 2019, 2:57 AM · efl
vtorri updated the summary of D8891: Evil: remove usage of EVIL_UNUSED and just cast to (void).
May 14 2019, 1:46 AM · efl
vtorri requested review of D8891: Evil: remove usage of EVIL_UNUSED and just cast to (void).
May 14 2019, 1:43 AM · efl

May 13 2019

vtorri triaged T7958: don't use long in eina value tests as they are 32 bits types on Windows as High priority.
May 13 2019, 12:18 PM · efl

May 12 2019

vtorri closed D8866: eina vpath: fix warning on Windows, as well as the public path.
May 12 2019, 2:58 AM · efl
vtorri added a comment to D8866: eina vpath: fix warning on Windows, as well as the public path.

i'll try

May 12 2019, 2:42 AM · efl
vtorri added a comment to D8866: eina vpath: fix warning on Windows, as well as the public path.

lib/eina/eina_vpath_xdg.c: In function 'eina_xdg_env_init':
lib/eina/eina_vpath_xdg.c:46:4: warning: reading through null pointer (argument 5) [-Wformat=]

ENV_SET("CommonProgramFiles", NULL, pub);
^~~~~~~

lib/eina/eina_vpath_xdg.c:49:4: warning: reading through null pointer (argument 5) [-Wformat=]

ENV_SET("LOCALAPPDATA", NULL, data);
^~~~~~~

lib/eina/eina_vpath_xdg.c:51:4: warning: reading through null pointer (argument 5) [-Wformat=]

ENV_SET("APPDATA", NULL, config);
^~~~~~~

lib/eina/eina_vpath_xdg.c:52:4: warning: reading through null pointer (argument 5) [-Wformat=]

ENV_SET("LOCALAPPDATA", NULL, cache);
^~~~~~~
May 12 2019, 12:58 AM · efl

May 9 2019

vtorri requested review of D8874: elementary genlist: fix potential uninitialized variable..
May 9 2019, 9:27 PM · efl
vtorri requested review of D8870: Ecore_Exe: fix warning on Windows.
May 9 2019, 1:55 AM · efl
vtorri closed T7734: windows : could not open src\lib\ecore\efl_loop_timer.eo.legacy.h.eo.legacy.h as Invalid.

i can't reproduce, closing

May 9 2019, 1:40 AM · efl (efl-1.23), Restricted Project

May 8 2019

vtorri requested review of D8866: eina vpath: fix warning on Windows, as well as the public path.
May 8 2019, 1:28 PM · efl
vtorri requested review of D8865: Evil: fix warning on 64 bits.
May 8 2019, 9:13 AM · efl
vtorri closed T7907: about localtime_r (unix and windows) as Resolved.
May 8 2019, 8:53 AM · Restricted Project
vtorri added a comment to D8854: Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined.

it seems that Marcel has fixed the problem, right ?

May 8 2019, 8:40 AM · efl
vtorri requested review of D8858: Evil: remove wrapper around getcwd().
May 8 2019, 5:30 AM · efl

May 7 2019

vtorri accepted D8095: Add json-c dependency.

meson is done so I accept, but i've not tested the module

May 7 2019, 9:48 PM
vtorri added a task to D8854: Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined: T7907: about localtime_r (unix and windows).
May 7 2019, 12:49 PM · efl
vtorri added a revision to T7907: about localtime_r (unix and windows): D8854: Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined.
May 7 2019, 12:49 PM · Restricted Project
vtorri added a comment to T7907: about localtime_r (unix and windows).

see D8854

May 7 2019, 12:48 PM · Restricted Project
vtorri requested review of D8854: Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined.
May 7 2019, 12:47 PM · efl
vtorri added a comment to T7907: about localtime_r (unix and windows).

@bu5hm4n so

May 7 2019, 3:00 AM · Restricted Project

May 6 2019

vtorri updated the summary of D8842: eina_file: speed up listing of directories on Windows.
May 6 2019, 1:45 PM · efl
vtorri requested review of D8842: eina_file: speed up listing of directories on Windows.
May 6 2019, 1:37 PM · efl
vtorri added a comment to D8727: eina: explicitly include Evil.h in eina_inline_slice.x.

rejecting or not, my comment clear enough and you should have closed it yourself

May 6 2019, 9:18 AM · Restricted Project
vtorri closed T7749: windows build with meson : define HAVE_DLADDR as Wontfix.
May 6 2019, 9:14 AM · Restricted Project
vtorri added a comment to D8727: eina: explicitly include Evil.h in eina_inline_slice.x.

i've said that this should be dropped. you don't care about my comments ?

May 6 2019, 9:12 AM · Restricted Project
vtorri triaged T7911: "conflicting paths" error messages of eolian (on Windows) as High priority.
May 6 2019, 12:21 AM · Restricted Project
vtorri added inline comments to D8734: meson: enable and fix build of ddrag+gdi engines for evas.
May 6 2019, 12:09 AM · Restricted Project

May 5 2019

vtorri added a comment to T7907: about localtime_r (unix and windows).

to make it short, i would like to pass -D_POSIX_C_SOURCE to cflags for the whole project. If you think it's too much, we can pass -D_POSIX_C_SOURCE only for windows.

May 5 2019, 2:50 AM · Restricted Project

May 4 2019

vtorri added a comment to T7907: about localtime_r (unix and windows).

Note that solaris man page also mentions that one should define _POSIX_C_SOURCE for re-entrant functions

May 4 2019, 3:41 AM · Restricted Project