is it working on Windows ?

that's what is done in configure.ac. I first trust what is in it.

do a git grep EINA_DEBUG_MALLOC

in src/lib/eina/meson.build, instead of

should EAPI_INTERNAL EAPI really be part of the API ?

what about making this function inline ?

cf D9107

i wasn't aware of this diff :-)

the problem is not EAPI, the problem is evil_locale.c which includes evil_private.h wich includes evil_macro_wrapper.h which defines setlocale() from evil_setlocale, setlocale being used in evil_locale.c

i don't want to add another header file just for evil_locale.c

for each binary, EFL_BUILD must not be set. For each library, EFL_BUILD must be set. We must be sure that this is correctly done with meson. As I have said, it's a reminder for meson (see last line of my original message)

with autotools (me), edje_cc at least displays help
with meson , zmike told me that edje_cc displays nothing

i've not completely checked the Windows part yet

latest release is 1.9.1, released in april 2019

not sure, but in efl_canvas_gesture_private.h, there is the inclusion of a source file :

there is no EINA_HAVE_BSWAP* defines on windows in eina_config.h

ok, though there is a getpwuid in Evil
anyway, this code will not be compiled on Windows, so fine for me

getuid does not exist on Windows, so i guess that you should add another guard

it's just for 3 files... I remove 7 lines and add 4, so less code :-)

i'll try

lib/eina/eina_vpath_xdg.c: In function 'eina_xdg_env_init':
lib/eina/eina_vpath_xdg.c:46:4: warning: reading through null pointer (argument 5) [-Wformat=]

ENV_SET("CommonProgramFiles", NULL, pub);
^~~~~~~

lib/eina/eina_vpath_xdg.c:49:4: warning: reading through null pointer (argument 5) [-Wformat=]

ENV_SET("LOCALAPPDATA", NULL, data);
^~~~~~~

lib/eina/eina_vpath_xdg.c:51:4: warning: reading through null pointer (argument 5) [-Wformat=]

ENV_SET("APPDATA", NULL, config);
^~~~~~~

lib/eina/eina_vpath_xdg.c:52:4: warning: reading through null pointer (argument 5) [-Wformat=]

ENV_SET("LOCALAPPDATA", NULL, cache);
^~~~~~~

i can't reproduce, closing

it seems that Marcel has fixed the problem, right ?

meson is done so I accept, but i've not tested the module

see D8854

@bu5hm4n so

rejecting or not, my comment clear enough and you should have closed it yourself

i've said that this should be dropped. you don't care about my comments ?

to make it short, i would like to pass -D_POSIX_C_SOURCE to cflags for the whole project. If you think it's too much, we can pass -D_POSIX_C_SOURCE only for windows.

Note that solaris man page also mentions that one should define _POSIX_C_SOURCE for re-entrant functions