Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (370 w, 1 d)
Availability
Available

Recent Activity

Mon, Mar 30

vtorri added a comment to D11620: Replace strncmp code.

your sed can also catch those of this form

Mon, Mar 30, 7:27 AM · efl
vtorri added a comment to D11620: Replace strncmp code.

there are plenty of other places where strncmp() is used in lib/ Why only thoses ?

Mon, Mar 30, 6:54 AM · efl
vtorri abandoned D8543: eina: check bswap* in byteswap.h only if it exists, otherwise check if gcc builtin bswap* exists.
Mon, Mar 30, 6:21 AM · efl
vtorri added a comment to T7221: efl_selection_manager: implement full clipboard support.

i guess this one should be closed, no ?

Mon, Mar 30, 2:04 AM · efl (efl-1.24), Active Work Proposal, efl: widgets, Restricted Project

Tue, Mar 24

vtorri updated the diff for D11565: fix segfault when there is no text in clipboard.
  • fix leak
Tue, Mar 24, 7:50 AM · efl
vtorri added a comment to D11565: fix segfault when there is no text in clipboard.

in wayland too i think

Tue, Mar 24, 7:43 AM · efl
vtorri added a comment to D11565: fix segfault when there is no text in clipboard.

also there too, then :
https://git.enlightenment.org/core/efl.git/tree/src/modules/ecore_evas/engines/cocoa/ecore_evas_cocoa.c#n521

Tue, Mar 24, 7:40 AM · efl
vtorri added a comment to D11564: free memory in clipboard notify event and fix clipboard clear event.

i know but there are plenty of locations in efl source where there is such check, so i considered it's a convention in efl source

Tue, Mar 24, 7:28 AM · efl
vtorri requested review of D11565: fix segfault when there is no text in clipboard.
Tue, Mar 24, 7:13 AM · efl
vtorri requested review of D11564: free memory in clipboard notify event and fix clipboard clear event.
Tue, Mar 24, 7:05 AM · efl

Thu, Mar 12

vtorri updated the diff for D11439: port cnp on Windows.
  • remove debug
  • add test on size and fix double free
  • use eina_str_has_prefix() only once
  • According to GlobalLock() documentation, GlobalUnlock() must be called on a successful GlobalLock() call
  • fix logic
  • free memory in clipboard notify event and fix clipboard clear event
  • fix segfault when there is no text in clipboard
Thu, Mar 12, 3:20 AM · efl

Mon, Mar 9

vtorri added inline comments to D11439: port cnp on Windows.
Mon, Mar 9, 8:30 AM · efl
vtorri added a project to T8624: EDJE_CC error: Restricted Project.
Mon, Mar 9, 6:50 AM · Restricted Project

Fri, Mar 6

vtorri added a comment to D11451: efl/exe: add 'pid' property.

C code for me is good. I can't comment about eo part though

Fri, Mar 6, 11:13 AM · efl
vtorri added a comment to D11457: exactness: hamonize use of PATH_MAX as maximal path length allowed.

note that MAX_PATH exists on Windows and it's value is 256

Fri, Mar 6, 5:28 AM · efl
vtorri added inline comments to D11451: efl/exe: add 'pid' property.
Fri, Mar 6, 5:25 AM · efl
vtorri added inline comments to D11451: efl/exe: add 'pid' property.
Fri, Mar 6, 4:38 AM · efl
vtorri added inline comments to D11451: efl/exe: add 'pid' property.
Fri, Mar 6, 4:34 AM · efl
vtorri added inline comments to D11451: efl/exe: add 'pid' property.
Fri, Mar 6, 4:27 AM · efl

Thu, Mar 5

vtorri added inline comments to D11451: efl/exe: add 'pid' property.
Thu, Mar 5, 12:11 PM · efl
vtorri added inline comments to D11439: port cnp on Windows.
Thu, Mar 5, 5:12 AM · efl
vtorri updated the diff for D11439: port cnp on Windows.
  • fix logic
Thu, Mar 5, 3:29 AM · efl

Wed, Mar 4

vtorri updated the diff for D11439: port cnp on Windows.
  • According to GlobalLock() documentation, GlobalUnlock() must be called on a successful GlobalLock() call
Wed, Mar 4, 7:07 AM · efl
vtorri added inline comments to D11439: port cnp on Windows.
Wed, Mar 4, 2:49 AM · efl
vtorri updated the diff for D11439: port cnp on Windows.
  • use eina_str_has_prefix() only once
Wed, Mar 4, 2:37 AM · efl
vtorri updated the diff for D11439: port cnp on Windows.
  • add test on size and fix double free
Wed, Mar 4, 2:12 AM · efl

Tue, Mar 3

vtorri added inline comments to D11439: port cnp on Windows.
Tue, Mar 3, 9:54 AM · efl

Mar 2 2020

vtorri updated the diff for D11439: port cnp on Windows.
  • remove debug
Mar 2 2020, 8:41 AM · efl
vtorri requested review of D11439: port cnp on Windows.
Mar 2 2020, 8:38 AM · efl

Feb 25 2020

vtorri requested review of D11415: Ecore_Win32: free 'compose' field when needed, fix memory leak.
Feb 25 2020, 6:46 AM · efl
vtorri requested review of D11406: Evil: add evil_utf8_to_utf16() API ; use evil_utf16_to_utf8() in Ecore_Win32.
Feb 25 2020, 4:30 AM · efl

Feb 24 2020

vtorri added inline comments to D11192: ecore_evas: Introduce cnp / dnd API for ecore evas.
Feb 24 2020, 7:49 AM · efl
vtorri requested changes to D11192: ecore_evas: Introduce cnp / dnd API for ecore evas.
Feb 24 2020, 5:36 AM · efl
vtorri requested changes to D11195: ecore_evas: introduce initial selection & dnd support for x..
Feb 24 2020, 4:45 AM · efl
vtorri added inline comments to D11192: ecore_evas: Introduce cnp / dnd API for ecore evas.
Feb 24 2020, 4:23 AM · efl

Feb 10 2020

vtorri added inline comments to D11305: exactness_player: make use of PATH_MAX define instead of posix variant.
Feb 10 2020, 3:29 AM · efl
vtorri added a comment to T8613: Compilaton Error.

@ali.alzyod try this :

Feb 10 2020, 3:07 AM · efl
vtorri added a comment to T8613: Compilaton Error.

it's unix, not windows. I also know unix prog... :-)

Feb 10 2020, 2:17 AM · efl
vtorri added a comment to T8613: Compilaton Error.

as discussed in IRC either :

Feb 10 2020, 1:42 AM · efl

Feb 6 2020

vtorri added inline comments to D11289: exactness: fix init/shutdown handling of efl components in various binaries.
Feb 6 2020, 4:25 AM · efl

Feb 5 2020

vtorri added a comment to D11289: exactness: fix init/shutdown handling of efl components in various binaries.

evas_init() calls eet_init() line 145 of evas_main.c

Feb 5 2020, 9:51 AM · efl
vtorri added a comment to D7590: Exactness: code importation.

i can inject a dll or exe in a process and call the functions in this dll/exe (a bit like PRELOAD). not sure if it can helps

Feb 5 2020, 2:52 AM · efl

Feb 4 2020

vtorri closed T7746: Windows build with meson : allow cross compilation when we compile on Windows as Wontfix.
Feb 4 2020, 5:10 AM · Restricted Project

Jan 25 2020

vtorri added a comment to D7426: build: add a setup script, that recomments the best options for platform.

on Windows, here is my script :

Jan 25 2020, 1:17 PM · efl

Jan 24 2020

vtorri added a comment to T8565: Windows: undefined references for some evas loaders and savers.

exactly. it was too odd. was it meson ? ninja ? some EAPI (or other similar macro) stuff ?

Jan 24 2020, 2:52 AM · Restricted Project

Jan 23 2020

vtorri closed T8565: Windows: undefined references for some evas loaders and savers as Invalid.

solved (though i still don't understand why it failed) : i unset PKG_CONFIG_PATH and it compiled flawlessly with my script. no problem with latest meson too

Jan 23 2020, 10:49 PM · Restricted Project
vtorri added a comment to T8565: Windows: undefined references for some evas loaders and savers.

below are the shots of dependency walker for libevas-1.dll and libecore-1.dll

Jan 23 2020, 11:24 AM · Restricted Project
vtorri added a comment to T8565: Windows: undefined references for some evas loaders and savers.

i used dependency walker which is a tool that parses the PE files (file format used for the DLL) and it reports something very strange : only 2 symbols are exported : fribidi_unicode_version and fribidi_version_info !?!?!? I don't understand, all the evas symbols should be here. There is no problem for other generated dll (ecore, eina, evil, etc...).

Jan 23 2020, 10:59 AM · Restricted Project

Jan 20 2020

vtorri added a comment to D11133: eina: add new range Data type.

and include the .x file in the .h file

Jan 20 2020, 10:25 AM · efl

Jan 17 2020

vtorri added a comment to D11121: exactness: fix mingw build.

imho, making exactness working on Windows is a big task. What is done here is making it compile. Just looking at the diff above, I see "/tmp/etc..." which is not an existing dir on Windows

Jan 17 2020, 5:55 AM · efl

Jan 15 2020

vtorri added a comment to T8565: Windows: undefined references for some evas loaders and savers.

maybe i have found the problem

Jan 15 2020, 10:08 PM · Restricted Project

Jan 13 2020

vtorri triaged T8565: Windows: undefined references for some evas loaders and savers as Showstopper Issues priority.
Jan 13 2020, 9:34 PM · Restricted Project

Dec 9 2019

vtorri accepted D10788: elocation: remove beta library.
Dec 9 2019, 6:22 AM · efl

Dec 5 2019

vtorri added a comment to D10788: elocation: remove beta library.

i think that there is one occurence here : doc/elementary_examples_cxx.dox: * @ref location_cxx_example_01

Dec 5 2019, 9:36 PM · efl

Nov 27 2019

vtorri requested review of D10753: ecore_win32: fix compose event field.
Nov 27 2019, 9:05 PM · efl
vtorri added inline comments to D10748: ector_software_rasterizer: use dynamic array by span size..
Nov 27 2019, 4:57 AM · efl

Nov 20 2019

vtorri added a comment to T8484: warnings in Eet.

@ProhtMeyhet if there is no such warning on linux, then we can close the task

Nov 20 2019, 9:37 AM · Restricted Project
vtorri added a comment to T8484: warnings in Eet.

gcc for Windows, version 9.2.0. I guess that it does not detect that it is defined there :

Nov 20 2019, 4:40 AM · Restricted Project
vtorri added a comment to D10699: tooling: add configuration file for lgtm.com service.

btw, in code there are also TODO and XXX comments...

Nov 20 2019, 1:45 AM · efl
vtorri created T8484: warnings in Eet.
Nov 20 2019, 1:39 AM · Restricted Project
vtorri edited the content of Windows.
Nov 20 2019, 12:20 AM · efl

Nov 19 2019

vtorri added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

"Lastly, you've suggested to use cos rather than cosf before at D10467, jsuya agreed this patch as you can see his comment above. and I agree also."

Nov 19 2019, 11:21 PM · efl
vtorri added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

is this accuracy really needed ?

Nov 19 2019, 3:46 AM · efl

Nov 16 2019

vtorri added a comment to D10299: c: possiblility of buffer overflow with strncat..

to mimic Shakespeare:

Nov 16 2019, 5:33 AM · efl

Nov 15 2019

vtorri added a comment to D10299: c: possiblility of buffer overflow with strncat..

so, what is the status of this diff ?

Nov 15 2019, 11:51 PM · efl

Nov 14 2019

vtorri accepted D10676: efreet: fix typo.
Nov 14 2019, 9:40 PM · efl

Nov 5 2019

vtorri added inline comments to D10265: c/c++: Removing low priorities warnings..
Nov 5 2019, 8:31 PM · efl

Oct 31 2019

vtorri added a comment to T8360: Error building EFL applications on FreeBSD with default settings.

install_dir option

Oct 31 2019, 4:35 AM · E on FreeBSD

Oct 28 2019

vtorri added a comment to D10467: Eina_Matrix : Use math header for cosf and sinf of rotate function..

btw cosf returns a float, not a double

Oct 28 2019, 11:29 PM · efl

Oct 11 2019

vtorri closed T8334: efreet-mime.pc not correctly generated as Invalid.
Oct 11 2019, 12:18 PM · Restricted Project

Oct 10 2019

vtorri updated subscribers of T8334: efreet-mime.pc not correctly generated.
Oct 10 2019, 9:33 PM · Restricted Project
vtorri triaged T8334: efreet-mime.pc not correctly generated as High priority.
Oct 10 2019, 9:31 PM · Restricted Project

Oct 9 2019

vtorri added a comment to T8310: pthread not found in applications using thread.

we can also increase _XOPEN_SOURCE to 700 (http://man7.org/linux/man-pages/man7/feature_test_macros.7.html)

Oct 9 2019, 8:04 PM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

otoh : https://lists.gnu.org/archive/html/autoconf/2010-08/msg00045.html it seems that we should not use __USE_UNIX98

Oct 9 2019, 8:00 PM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

@raster btw, eina_inline_posix_lock.x does:

Oct 9 2019, 7:46 PM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

@raster i've asked the user to export it to CPPFLAGS and issue vanished of course. I will provide a diff

Oct 9 2019, 7:39 AM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

@bu5hm4n i would say in eina as a user should not do extra work. Eina is using some features, it should enable them, imho.

Oct 9 2019, 5:58 AM · efl: data types
vtorri added a comment to T8310: pthread not found in applications using thread.

it is garded. adding -D_POSIX_C_SOURCE=200809L in eina.pc (in CFlags) should be sufficient

Oct 9 2019, 3:26 AM · efl: data types

Oct 8 2019

vtorri requested changes to D10299: c: possiblility of buffer overflow with strncat..

strlcat does not exist on Windows

Oct 8 2019, 2:32 AM · efl

Oct 7 2019

vtorri triaged T8310: pthread not found in applications using thread as Normal priority.
Oct 7 2019, 2:21 AM · efl: data types
vtorri accepted D10270: evil: bring back doxygen intro page for evil library.
Oct 7 2019, 2:03 AM · efl
vtorri accepted D10294: evil: remove stray x character from docs section.
Oct 7 2019, 2:02 AM · efl
vtorri accepted D10295: evil: make it clear in the docs that this library is private to efl.
Oct 7 2019, 2:01 AM · efl

Oct 5 2019

vtorri requested review of D10290: efl_app and efl_exe: support get and set priority of a process on Windows.
Oct 5 2019, 5:25 AM · efl

Oct 4 2019

vtorri added a comment to D10270: evil: bring back doxygen intro page for evil library.

option b) is fine for me

Oct 4 2019, 4:51 AM · efl

Oct 3 2019

vtorri added reviewers for D10279: fix compilation on Windows: stephenmhouston, zmike.

Note that elementary makes ephoto unresponsive. Certainly a problem on Windows. I have plenty of this message:

Oct 3 2019, 6:40 AM
vtorri requested review of D10279: fix compilation on Windows.
Oct 3 2019, 6:37 AM
vtorri added a comment to D6530: stop librsvg dependency..

we have plenty of dependencies, so if we can remove some, that would simplify everybody's life

Oct 3 2019, 5:33 AM · efl

Oct 2 2019

vtorri added a comment to D6530: stop librsvg dependency..

shouldn't this be abandoned and rewritten for meson build system ?

Oct 2 2019, 12:05 PM · efl
vtorri added a comment to D10270: evil: bring back doxygen intro page for evil library.

should we add @private to the doc of the functions ?

Oct 2 2019, 9:29 AM · efl

Sep 30 2019

vtorri added a comment to V46: Will you attend the Enlightenment Developer Days 2019?.

plane reserved

Sep 30 2019, 2:19 PM

Sep 23 2019

vtorri added a reviewer for D10077: eina_array: do not mix declaration and definition: stefan_schmidt.
Sep 23 2019, 7:01 AM · efl
vtorri requested review of D10077: eina_array: do not mix declaration and definition.
Sep 23 2019, 7:00 AM · efl

Sep 16 2019

vtorri added a comment to T7797: problem with EAPI on Windows (again).

no, EFL_BUILD is set in config.h, which is also used by binaries. see toplevel meson.build

Sep 16 2019, 8:50 AM · Restricted Project
vtorri accepted D9962: eina: fix spelling in new eina_file_statgen API.
Sep 16 2019, 2:53 AM · efl
vtorri added a comment to D9962: eina: fix spelling in new eina_file_statgen API.

maybe this should have been detected with a unit test too, no ?

Sep 16 2019, 1:10 AM · efl

Sep 13 2019

vtorri accepted D9914: tests/edje: handle file modifications properly on windows.
Sep 13 2019, 11:12 AM · Restricted Project
vtorri added a comment to D9914: tests/edje: handle file modifications properly on windows.

i can't try the test, but i tried the code on a file, and it works with the change mentioned above

Sep 13 2019, 1:18 AM · Restricted Project
vtorri requested changes to D9914: tests/edje: handle file modifications properly on windows.
Sep 13 2019, 1:18 AM · Restricted Project
vtorri added inline comments to D9914: tests/edje: handle file modifications properly on windows.
Sep 13 2019, 12:48 AM · Restricted Project