Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (302 w, 3 d)
Availability
Available

Recent Activity

Fri, Dec 7

vtorri added a comment to D7428: autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale().

someting like that :

Fri, Dec 7, 5:49 AM · efl
vtorri reopened D7428: autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale().

we need to think of better ways

Fri, Dec 7, 5:35 AM · efl
vtorri reopened D7378: ci: mingw: enable various build options with dependencies now satisfied.

harfbuzz too

Fri, Dec 7, 5:33 AM · efl
vtorri added a comment to D7378: ci: mingw: enable various build options with dependencies now satisfied.

libwebp must be added

Fri, Dec 7, 3:52 AM · efl
vtorri added a comment to D7428: autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale().

btw why linking in evil ?? the symbols are in eina...

Fri, Dec 7, 3:50 AM · efl
vtorri added a comment to D7428: autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale().

msvcr100.a is provided by mingw64, but are we sure that the DLL is installed ? If not, the application will fail with function not defined. That can be a problem

Fri, Dec 7, 3:47 AM · efl

Thu, Dec 6

vtorri added a comment to T7497: _create_locale and _free_locale undefined on Windows.

you reverted the revert so you knew what you were doing.
otherwise, don't revert

Thu, Dec 6, 2:14 PM · Restricted Project
vtorri updated the task description for T7497: _create_locale and _free_locale undefined on Windows.
Thu, Dec 6, 1:26 PM · Restricted Project
vtorri triaged T7497: _create_locale and _free_locale undefined on Windows as Showstopper Issues priority.
Thu, Dec 6, 1:20 PM · Restricted Project

Thu, Nov 29

vtorri edited the content of Windows.
Thu, Nov 29, 1:56 PM
vtorri added a comment to D7378: ci: mingw: enable various build options with dependencies now satisfied.

Stefan helped me to fix issues with ewpi and ewpi compiles finely on fedora. So for me no problem on the ewpi side

Thu, Nov 29, 2:20 AM · efl

Tue, Nov 27

vtorri edited the content of Windows.
Tue, Nov 27, 7:47 AM

Sun, Nov 25

vtorri edited the content of Windows.
Sun, Nov 25, 5:37 AM

Fri, Nov 16

vtorri edited the content of Windows.
Fri, Nov 16, 12:51 PM

Nov 12 2018

vtorri edited the content of Windows.
Nov 12 2018, 12:29 PM
vtorri edited the content of Windows.
Nov 12 2018, 12:20 PM
vtorri edited the content of Windows.
Nov 12 2018, 11:53 AM

Sep 10 2018

vtorri accepted D6644: eina: add locale-independent eina_convert_strtod_c function.
Sep 10 2018, 9:16 PM · efl

Aug 23 2018

vtorri added a comment to D6869: eina: find a real path of dynamic library.

i don't understand why using a function (using it only once) with a #ifdef instead of using the #ifdef directly...

Aug 23 2018, 10:19 PM · efl

Aug 16 2018

vtorri accepted D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.
Aug 16 2018, 9:33 PM · efl

Aug 15 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

i can't test anything until september, just look at code
i will abandon it and open another one, then, but in september

Aug 15 2018, 6:51 AM · efl

Aug 14 2018

vtorri added a comment to D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.

man strncpy says

Aug 14 2018, 9:43 AM · efl
vtorri added a comment to D6681: build: fix evas static build of gl engines.

there is no gl engines on Windows, so...

Aug 14 2018, 8:38 AM · Restricted Project
vtorri added a comment to D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.

is there a unit test about this problem ?

Aug 14 2018, 6:00 AM · efl
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

sorry, i was on holydays and forget about your patch

Aug 14 2018, 2:08 AM · efl

Aug 6 2018

vtorri added a comment to D6742: eina_vpath: fix homedirectory fetching.

getpwnam does not exist on Windows. it may be possible to get the home directory of a user. It is not straightforward, but i have seen some ideas about that

Aug 6 2018, 9:28 PM · efl

Aug 2 2018

vtorri added a comment to D6682: build: break out ddraw and cocoa static engine builds into utility libraries.

i plan to use C API for the ddraw engine, so there should be no problem in the future (around september/october)

Aug 2 2018, 9:01 PM · Restricted Project

Jul 30 2018

vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

you have not documented the behavior of the API function when the first argument is NULL or empty

Jul 30 2018, 3:45 AM · efl
vtorri added a comment to T7221: efl_selection_manager: implement full clipboard support.

that will certainly help, thank you

Jul 30 2018, 2:15 AM · Active Work Proposal, efl: widgets, Restricted Project, efl (efl-1.22)
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

rename _eina_c_locale_get() to _eina_c_locale_new() and _eina_c_locale_free() to _eina_c_locale_del() to follow EFL conventions

Jul 30 2018, 2:14 AM · efl
vtorri accepted D6635: build: fix rpath for binaries which use ecore-x dependencies.

no problem for me, the m4 diff is only a reordering of variables

Jul 30 2018, 12:57 AM · Restricted Project
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

add also several tests for exponential representation of the number

Jul 30 2018, 12:31 AM · efl
vtorri added a comment to T7221: efl_selection_manager: implement full clipboard support.

i've already implemented the clipboard support. Maybe change in the infra has removed it

Jul 30 2018, 12:28 AM · Active Work Proposal, efl: widgets, Restricted Project, efl (efl-1.22)
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

I've just realized that you don't call freelocale() to deallocate the resources.

Jul 30 2018, 12:22 AM · efl

Jul 28 2018

vtorri created T7220: multiple defined variables in Makefiles.
Jul 28 2018, 4:54 AM · Restricted Project, Restricted Project

Jul 27 2018

vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

strtod_l does not exist on Windows, use _strtod_l instead

Jul 27 2018, 12:39 PM · efl

Jul 26 2018

vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

you didn't add the typedef

Jul 26 2018, 5:35 AM · efl
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

still error : line 457, the type is still locale_t

Jul 26 2018, 5:09 AM · efl
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

is there a test program so i can test this code ?

Jul 26 2018, 4:17 AM · efl
vtorri requested changes to D6644: eina: add locale-independent eina_convert_strtod_c function.

on Windows, newlocale() does not exist :

Jul 26 2018, 2:45 AM · efl

Jul 20 2018

vtorri accepted D6648: ecore: remove exit_signal_received conditional from windows build.
Jul 20 2018, 12:14 PM · Restricted Project

Jul 13 2018

vtorri accepted D6591: evas: fix minor typo in smart class color_set method doc.
Jul 13 2018, 2:08 PM · efl: docs

Jun 29 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

i will open a new ticket instead of trying to fix this mess, arcanist is too complicated for me

Jun 29 2018, 11:41 AM · efl
vtorri abandoned D6363: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206.

i used wrongly arcanist locally, so i created another patch, see D6478
closing this one

Jun 29 2018, 1:00 AM · efl
vtorri added a reviewer for D6478: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix T5206: an.kroitor.
Jun 29 2018, 12:59 AM · efl
Herald added a reviewer for D6478: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix T5206: devilhorns.
Jun 29 2018, 12:58 AM · efl

Jun 28 2018

vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
  • Evil: fix usage of Evil in a program compiled with vc++
  • Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206
Jun 28 2018, 11:07 PM · efl

Jun 26 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

@lauromoura but you said : "According to msys' pacman, I'm using mingw64/mingw-w64-x86_64-dbus 1.12.8-1." ?!?!?

Jun 26 2018, 5:59 AM · efl

Jun 25 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

i use d-bus from win-builds

Jun 25 2018, 9:49 PM · efl

Jun 22 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

patch update

Jun 22 2018, 1:45 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
Jun 22 2018, 1:44 PM · efl
vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

ok, tests are run now, i have 12 successful tests and 15 which fail

Jun 22 2018, 1:22 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
  • Tests: remove warnings when compiling tests if fork is not available and run tests properly on Windows
Jun 22 2018, 1:20 PM · efl
vtorri accepted D6369: ecore/glib: add #ifdef guards for newly added includes.
Jun 22 2018, 12:38 PM · efl
vtorri accepted D6368: evas/cpu: rework SIGILL code for non-x86 (and fix windows build).
Jun 22 2018, 12:36 PM · efl
vtorri added a comment to D6369: ecore/glib: add #ifdef guards for newly added includes.

i would have done :

Jun 22 2018, 12:23 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
Jun 22 2018, 11:55 AM · efl
vtorri added a comment to D6363: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206.

i've already broken the API on Windows several times. These functions are not used anymore and should not be used, even internally.

Jun 22 2018, 6:44 AM · efl
vtorri added a comment to T5206: windows: headers are messed up.

see D6363

Jun 22 2018, 12:07 AM · efl (efl-1.21), Restricted Project, Windows
Herald added a reviewer for D6363: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206: devilhorns.
Jun 22 2018, 12:06 AM · efl

Jun 21 2018

vtorri triaged T7055: EINA: recent changes causing breakage and build failure on other architectures. as High priority.
Jun 21 2018, 11:44 PM · regression, efl (efl-1.21), Restricted Project
vtorri accepted D6348: eina_debug_bt: add ifdef for windows build.
Jun 21 2018, 2:42 PM · efl

Jun 20 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

hmm, arc diff fucked up this diff, i need help to restore the previous state...

Jun 20 2018, 1:47 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
  • Evil: fix usage of Evil in a program compiled with vc++
Jun 20 2018, 1:44 PM · efl

Jun 15 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.
./dbus-session.sh: ligne 7: -- : commande introuvable
kill : utilisation :kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... ou kill -l [sigspec]
FAIL tests/evil/evil_suite.exe (exit status: 127)
Jun 15 2018, 12:38 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
Jun 15 2018, 4:28 AM · efl

Jun 13 2018

Herald added a reviewer for D6286: Tests: remove warnings when compiling tests if fork is not available: devilhorns.
Jun 13 2018, 9:15 PM · efl

Jun 12 2018

vtorri accepted D6262: evil: Fix test compilation..
Jun 12 2018, 9:16 PM · Windows, efl

Jun 11 2018

vtorri added a comment to T5206: windows: headers are messed up.

that is the problem of Ecore.h relying on unix types... It is too late to change Ecore.h, unfortunately, maybe for EFL 2.0 we can change this.

Jun 11 2018, 2:37 AM · efl (efl-1.21), Restricted Project, Windows

Jun 4 2018

vtorri added a comment to T6964: object life-cycle issue..

same with Etui (launch, then close, i removed all the focus error messages) :

Jun 4 2018, 4:57 AM · efl (efl-1.21), regression, efl: widgets

May 3 2018

vtorri edited the content of Windows.
May 3 2018, 8:07 AM

May 2 2018

vtorri accepted D6034: ecore-evas-win32: set draw_block until the window receives a configure event.
May 2 2018, 11:29 AM
vtorri accepted D6033: ecore-win32: propagate WM_SIZE event.
May 2 2018, 11:29 AM
vtorri accepted D6016: efl_ui_win: ignore attempts to resize window to 0x0 during frame sizing.
May 2 2018, 11:28 AM · efl

May 1 2018

vtorri edited the content of Windows.
May 1 2018, 11:04 PM

Apr 27 2018

vtorri added a comment to D5966: efreet: add method for disabling efreetd connection.

why not efreet_cache_set(bool) ?

Apr 27 2018, 1:04 PM

Mar 5 2018

vtorri edited the content of Efl Apps Todo.
Mar 5 2018, 8:33 AM

Mar 4 2018

vtorri added a comment to D5831: Elm_code test: fix compilation.

because of inclusion of .c files, I get multiple defined symbols, like :

Mar 4 2018, 4:27 AM

Feb 7 2018

vtorri added a comment to D5792: Evas: remove depth usage in GDI and DirectDraw engines.

indeed, it has nothing to do with 16bpp. So ignore that diff, i'll send another one with only depth removal

Feb 7 2018, 5:06 AM
vtorri added a comment to D5792: Evas: remove depth usage in GDI and DirectDraw engines.

this pool was added in the Xlib engine for shm and small buffer size, right ? So it is useless in Windows engine.

Feb 7 2018, 5:02 AM

Jan 27 2018

vtorri updated subscribers of T6645: 789c2892a3e6e3ef4c9661b90236f62b0c55d341 breaks compilation on Windows.
Jan 27 2018, 2:42 AM · efl
vtorri triaged T6645: 789c2892a3e6e3ef4c9661b90236f62b0c55d341 breaks compilation on Windows as Showstopper Issues priority.
Jan 27 2018, 2:41 AM · efl

Jan 19 2018

vtorri closed D5751: efl selection: fix compilation on windows.
Jan 19 2018, 1:36 PM

Jan 14 2018

vtorri updated the summary of D5736: Ecore_Win32: do not allocate useless memory for the monitor window.
Jan 14 2018, 5:04 AM

Jan 13 2018

vtorri created D5736: Ecore_Win32: do not allocate useless memory for the monitor window.
Jan 13 2018, 1:02 PM

Jan 12 2018

vtorri added a comment to T6607: Elementary_test seg fault on Windows.

how do you know that sndfile dll is not loaded ? you have added some printf ? is the sndfile dll in your PATH ?

Jan 12 2018, 11:13 PM · efl
vtorri created D5735: Evil: remove useless dirent code.
Jan 12 2018, 12:50 PM
vtorri reassigned T6607: Elementary_test seg fault on Windows from raster to i.furs.
Jan 12 2018, 10:09 AM · efl
vtorri added a comment to T6607: Elementary_test seg fault on Windows.

I have looked abit at the code of ecore_audio_obj_out_wasapi.c It does wrong stuff :

Jan 12 2018, 10:06 AM · efl
vtorri added a comment to T6607: Elementary_test seg fault on Windows.

pass --disable-pulseaudio to configure to have wasapi enabled

Jan 12 2018, 2:12 AM · efl

Jan 11 2018

vtorri created D5733: remove inclusion of dirent.h where it is not used.
Jan 11 2018, 9:37 PM
vtorri added a comment to T6607: Elementary_test seg fault on Windows.

yes. It's between the january the 6th and january the 11th

Jan 11 2018, 9:24 PM · efl
vtorri created T6607: Elementary_test seg fault on Windows.
Jan 11 2018, 1:56 PM · efl

Jan 10 2018

vtorri closed D5731: Elm_test panel: use eina instead of dirent to list files.
Jan 10 2018, 11:16 PM
vtorri updated the diff for D5731: Elm_test panel: use eina instead of dirent to list files.

Short/middle term: use UTF-16 on Windows. So I plan to remove most of
external API (like dirent in Evil) and use only EFL to have less work later

Jan 10 2018, 10:40 PM
vtorri created D5731: Elm_test panel: use eina instead of dirent to list files.
Jan 10 2018, 9:48 PM

Jan 8 2018

vtorri closed D5723: elm example : on some OS (windows...) struct tm has 9 fields and not 11. Fix warning..
Jan 8 2018, 4:23 AM
vtorri added a comment to D5724: evas/vg: Use always blending op while drawing the vector..

render_op will be removed in another commit ? Maybe it should be done quickly

Jan 8 2018, 2:57 AM

Jan 7 2018

vtorri added a comment to D5724: evas/vg: Use always blending op while drawing the vector..

problem fixed with software. I can't test with opengl

Jan 7 2018, 9:39 PM

Jan 6 2018

vtorri edited the content of Windows.
Jan 6 2018, 8:51 AM