Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (412 w, 4 d)
Availability
Available

Recent Activity

Tue, Jan 19

vtorri added a comment to T8866: FreeBSD: E-0.24.2 + EFL-1.25.1 + wayland + drm..

@cederom what is the status of that task ?

Tue, Jan 19, 11:16 PM · Restricted Project, E on FreeBSD
vtorri added a comment to D12217: evas/drm/gl: Fix meson configuration..

@cederom what is the status of that diff ?

Tue, Jan 19, 11:15 PM · efl

Mon, Jan 18

vtorri added a comment to D12217: evas/drm/gl: Fix meson configuration..

Yes this seems to be the cause of the problem - different defines for -Dopengl=full and -Dopengl=eg-gl (second one valid for drm+wayland?):

Mon, Jan 18, 2:09 AM · efl
vtorri added a comment to D12217: evas/drm/gl: Fix meson configuration..

btw, replace -Dopengl=full with -Dopengl=es-egl

Mon, Jan 18, 1:48 AM · efl
vtorri added a comment to D12217: evas/drm/gl: Fix meson configuration..

@cederom can you give the meson command please ?

Mon, Jan 18, 1:41 AM · efl
vtorri added inline comments to D12217: evas/drm/gl: Fix meson configuration..
Mon, Jan 18, 1:33 AM · efl

Wed, Jan 13

vtorri created T8875: Eina_File: add creation time for files.
Wed, Jan 13, 1:18 AM · efl

Mon, Jan 11

vtorri closed T8872: EAPI incorrectly defined on Windows for loaders as Resolved.

fixed in f6d0bc1b2980098859f6181bf823c6b627ae6a5b

Mon, Jan 11, 3:12 AM · Restricted Project
vtorri added a comment to T8872: EAPI incorrectly defined on Windows for loaders.

it's good for me

Mon, Jan 11, 2:46 AM · Restricted Project

Thu, Jan 7

vtorri accepted D12227: emotion: emotion EAPI macro to EMOTION_API in Emotion library.

ok for me

Thu, Jan 7, 12:04 AM · efl

Wed, Dec 30

vtorri accepted D12226: ector: Rename EAPI macro to ECTOR_API in Ector library.

no problem here

Wed, Dec 30, 10:55 AM · efl

Mon, Dec 28

vtorri accepted D12225: ecore_con: Rename EAPI macro to ECORE_CON_API in Ecore Con library.

ecore_con_client|server_example.exe is behaving the same with and without patch, so ok

Mon, Dec 28, 8:09 AM · efl
vtorri added a comment to D12225: ecore_con: Rename EAPI macro to ECORE_CON_API in Ecore Con library.

do you have an example to test ecore_con ?

Mon, Dec 28, 7:12 AM · efl
vtorri created T8872: EAPI incorrectly defined on Windows for loaders.
Mon, Dec 28, 7:05 AM · Restricted Project

Dec 22 2020

vtorri added a reviewer for D12224: eeze walk: fix a memory leaking: zmike.
Dec 22 2020, 11:57 PM · efl
vtorri added a reviewer for D12223: eeze_disk: fix a potention memory leak: zmike.
Dec 22 2020, 11:54 PM · efl
vtorri added a reviewer for D12221: eeze_net: fix a potentional memory leak case: zmike.

seems good to me

Dec 22 2020, 11:51 PM · efl
vtorri added a reviewer for D12222: eeze_syspaty: fix a potention memory leak: zmike.

seems good to me

Dec 22 2020, 11:50 PM · efl

Dec 16 2020

vtorri added reviewers for D12217: evas/drm/gl: Fix meson configuration.: devilhorns, raster, bu5hm4n.
Dec 16 2020, 7:52 PM · efl
vtorri added reviewers for D12216: Evas, Eolian: install missing *_api.h files: felipealmeida, lucas, jptiz.
Dec 16 2020, 6:17 AM · efl
vtorri requested review of D12216: Evas, Eolian: install missing *_api.h files.
Dec 16 2020, 6:16 AM · efl

Dec 15 2020

vtorri accepted D12214: evas: Rename EAPI macro to EVAS_API in Evas library.
Dec 15 2020, 12:18 PM · efl
vtorri requested changes to D12214: evas: Rename EAPI macro to EVAS_API in Evas library.
Dec 15 2020, 10:49 AM · efl
vtorri accepted D12214: evas: Rename EAPI macro to EVAS_API in Evas library.

it compiles and elm_test runs

Dec 15 2020, 9:59 AM · efl
vtorri accepted D12212: ecore_audio: Rename EAPI macro to ECORE_AUDIO_API in Ecore Audio library.

it compiles and elm_test plays sound, so ok

Dec 15 2020, 6:19 AM · efl

Dec 14 2020

vtorri added inline comments to D12212: ecore_audio: Rename EAPI macro to ECORE_AUDIO_API in Ecore Audio library.
Dec 14 2020, 6:59 AM · efl

Dec 12 2020

vtorri accepted D12208: evil: Fix fcntl for F_SETLK and F_SETLKW wrong length calculation.
Dec 12 2020, 11:31 PM · efl
vtorri accepted D12210: eio: Rename EAPI macro to EIO_API in Eio library.

ok checked, good for me

Dec 12 2020, 11:28 PM · efl

Dec 9 2020

vtorri added a comment to D12208: evil: Fix fcntl for F_SETLK and F_SETLKW wrong length calculation.

in efreet, it's for locking a file, so I think the code in evil is useful

Dec 9 2020, 11:55 AM · efl
vtorri added a comment to D12208: evil: Fix fcntl for F_SETLK and F_SETLKW wrong length calculation.

i don't know about efreet yet, i've not looked at the code

Dec 9 2020, 11:52 AM · efl
vtorri added inline comments to D12210: eio: Rename EAPI macro to EIO_API in Eio library.
Dec 9 2020, 11:51 AM · efl
vtorri added a comment to D12208: evil: Fix fcntl for F_SETLK and F_SETLKW wrong length calculation.

what i meant is, in src/modules/ecore_evas/engines/extn/ecore_evas_extn_buf.c, line 156 :

Dec 9 2020, 11:40 AM · efl
vtorri added a comment to D12209: evil: Define environ macro when using VS based on UCRT definition.

no objection for me. If it works for you, i'm ok with this fix

Dec 9 2020, 10:59 AM · efl
vtorri accepted D12207: Fixing conversion from size_t to high-low dwords for _WIN64..
Dec 9 2020, 10:57 AM · efl
vtorri added a comment to D12208: evil: Fix fcntl for F_SETLK and F_SETLKW wrong length calculation.

no problem for me, but i think that this function should not exist in evil at all.

Dec 9 2020, 10:47 AM · efl
vtorri added inline comments to D12207: Fixing conversion from size_t to high-low dwords for _WIN64..
Dec 9 2020, 8:12 AM · efl

Dec 8 2020

vtorri accepted D12203: eo: Rename EAPI macro to EO_API in Eo library.

still good for me

Dec 8 2020, 9:17 AM · efl

Dec 4 2020

vtorri accepted D12200: benchmark: Remove unnecessary import and export macros from benchmark executables.

seems good

Dec 4 2020, 11:13 PM · efl
vtorri accepted D12201: eio: Add weak symbol.

seems good

Dec 4 2020, 11:11 PM · efl
vtorri accepted D12202: eldbus: Add Eldbus.h include entry point header to eldbus_instrospection.h.

seems good

Dec 4 2020, 11:10 PM · efl
vtorri accepted D12197: eolian: Add -e parameter to pass export symbol to eolian generator.

ok for me too

Dec 4 2020, 12:38 AM · efl

Dec 1 2020

vtorri added a comment to D12135: Added the heif loader.

@raster is it ok ?

Dec 1 2020, 3:21 AM · efl

Nov 28 2020

vtorri added a comment to D12197: eolian: Add -e parameter to pass export symbol to eolian generator.

for me, it compiles, there is only the note i added
if @q66 could look at this, that would be nice

Nov 28 2020, 6:05 AM · efl

Nov 26 2020

vtorri added a comment to D12197: eolian: Add -e parameter to pass export symbol to eolian generator.

_eolian_api_symbol is not freed, is it normal ? i know that anyway the mem is freed when the prog is shutdown, bu i prefer to mention it

Nov 26 2020, 10:46 PM · efl

Nov 25 2020

vtorri added a comment to D12197: eolian: Add -e parameter to pass export symbol to eolian generator.

are you sure that the summary is correct ?

Nov 25 2020, 7:00 AM · efl
vtorri accepted D12196: eolian: Rename EAPI macro to EOLIAN_API in Eolian library.

seems good, and efl and etui compiled, so ok

Nov 25 2020, 6:29 AM · efl

Nov 24 2020

vtorri accepted D12188: eina: Rename EAPI macro to EINA_API in Eina library.

good now

Nov 24 2020, 11:08 PM · efl

Nov 22 2020

vtorri added a comment to D12188: eina: Rename EAPI macro to EINA_API in Eina library.

Found ninja.EXE-1.10.1 at E:\Documents\programmes_x64\msys2\mingw64\bin/ninja.EXE
[1/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_locale.c.obj
[2/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_langinfo.c.obj
[3/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_string.c.obj
[4/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_stdlib.c.obj
[5/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_mman.c.obj
[6/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_dlfcn.c.obj
[7/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_time.c.obj
[8/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_main.c.obj
[9/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_stdio.c.obj
[10/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_unistd.c.obj
[11/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_util.c.obj
[12/2419] Compiling C object src/lib/evil/41a5db3@@evil@sha/evil_fcntl.c.obj
[13/2419] Linking target src/lib/evil/libevil-1.dll
[14/2419] Generating symbol file src/lib/evil/41a5db3@@evil@sha/libevil-1.dll.symbols
[15/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_abi.c.obj
[16/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_binshare.c.obj
[17/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_counter.c.obj
[18/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_array.c.obj
[19/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_convert.c.obj
[20/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_binbuf.c.obj
[21/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_crc.c.obj
[22/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_cow.c.obj
[23/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_cpu.c.obj
[24/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_debug_bt.c.obj
../src/lib/eina/eina_debug_bt.c: In function '_collect_bt':
../src/lib/eina/eina_debug_bt.c:296:23: warning: unused parameter 'pth' [-Wunused-parameter]

296 | _collect_bt(pthread_t pth)
    |             ~~~~~~~~~~^~~

[25/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_benchmark.c.obj
[26/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_accessor.c.obj
[27/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_debug_thread.c.obj
[28/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_debug_cpu.c.obj
[29/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_debug_timer.c.obj
[30/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_fp.c.obj
[31/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_hamster.c.obj
[32/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_debug_bt_file.c.obj
[33/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_debug_chunk.c.obj
[34/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_evlog.c.obj
[35/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_debug.c.obj
../src/lib/eina/eina_debug.c: In function 'eina_debug_session_send':
../src/lib/eina/eina_debug.c:148:29: warning: variable 'hdr' set but not used [-Wunused-but-set-variable]

148 |    Eina_Debug_Packet_Header hdr;
    |                             ^~~

[36/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_error.c.obj
[37/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_file_common.c.obj
[38/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_lock.c.obj
[39/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_inarray.c.obj
[40/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_iterator.c.obj
[41/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_inlist.c.obj
[42/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_lalloc.c.obj
[43/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_list.c.obj
[44/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_hash.c.obj
[45/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_magic.c.obj
[46/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_main.c.obj
[47/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_module.c.obj
[48/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_mempool.c.obj
[49/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_log.c.obj
[50/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_mmap.c.obj
[51/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_matrix.c.obj
[52/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_prefix.c.obj
[53/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_sched.c.obj
[54/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_matrixsparse.c.obj
[55/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_quad.c.obj
[56/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_quadtree.c.obj
[57/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_share_common.c.obj
[58/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_safety_checks.c.obj
[59/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_rectangle.c.obj
[60/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_thread.c.obj
[61/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_rbtree.c.obj
[62/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_str.c.obj
[63/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_strbuf.c.obj
[64/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_simple_xml_parser.c.obj
[65/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_promise.c.obj
[66/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_strbuf_common.c.obj
[67/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_tmpstr.c.obj
[68/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_ustringshare.c.obj
[69/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_unicode.c.obj
[70/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_value_util.c.obj
[71/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_stringshare.c.obj
[72/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_thread_queue.c.obj
[73/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_ustrbuf.c.obj
[74/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_tiler.c.obj
[75/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_util.c.obj
[76/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_safepointer.c.obj
[77/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_abstract_content.c.obj
[78/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_vpath.c.obj
[79/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_xattr.c.obj
[80/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_vpath_xdg.c.obj
[81/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_quaternion.c.obj
[82/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_freeq.c.obj
[83/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_bezier.c.obj
[84/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_slstr.c.obj
[85/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/.._.._modules_eina_mp_one_big_eina_one_big.c.obj
[86/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/eolian.c.obj
[87/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/eo_lexer.c.obj
[88/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_class.c.obj
[89/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/.._.._modules_eina_mp_pass_through_eina_pass_through.c.obj
[90/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_class_api.c.obj
[91/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/eolian_database.c.obj
[92/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_function.c.obj
[93/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_file_win32.c.obj
../src/lib/eina/eina_file_win32.c: In function 'eina_file_map_faulted':
../src/lib/eina/eina_file_win32.c:1127:2: warning: #warning "We need to handle access to corrupted memory mapped file." [-Wcpp]
1127 | #warning "We need to handle access to corrupted memory mapped file."

|  ^~~~~~~

[94/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_function_parameter.c.obj
[95/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_check.c.obj
[96/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_function_api.c.obj
[97/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/eina_value.c.obj
[98/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_function_parameter_api.c.obj
[99/2419] Compiling C object src/lib/eina/803ee99@@eina@sha/.._.._modules_eina_mp_chained_pool_eina_chained_mempool.c.obj
[100/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_implement.c.obj
[101/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_constructor.c.obj
[102/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_implement_api.c.obj
[103/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_type.c.obj
[104/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_type_api.c.obj
[105/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_constructor_api.c.obj
[106/2419] Linking target src/lib/eina/libeina-1.dll
[107/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_event.c.obj
[108/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_event_api.c.obj
[109/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_part.c.obj
[110/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_part_api.c.obj
[111/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/eo_parser.c.obj
[112/2419] Generating symbol file src/lib/eina/803ee99@@eina@sha/libeina-1.dll.symbols
[113/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_var.c.obj
[114/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_var_api.c.obj
[115/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_expr_api.c.obj
[116/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/eolian_aux.c.obj
[117/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_expr.c.obj
[118/2419] Compiling C object src/bin/eolian/70b716a@@eolian_gen@exe/headers.c.obj
[119/2419] Compiling C object src/bin/eolian/70b716a@@eolian_gen@exe/types.c.obj
[120/2419] Compiling C object src/bin/eolian/70b716a@@eolian_gen@exe/main.c.obj
[121/2419] Compiling C object src/static_libs/freetype/5553d54@@freetype@sta/sw_ft_math.c.obj
[122/2419] Compiling C object src/static_libs/libunibreak/7585b50@@libunibreak@sta/unibreakbase.c.obj
[123/2419] Compiling C object src/static_libs/libunibreak/7585b50@@libunibreak@sta/unibreakdef.c.obj
[124/2419] Compiling C object src/static_libs/freetype/5553d54@@freetype@sta/sw_ft_raster.c.obj
[125/2419] Compiling C object src/static_libs/libunibreak/7585b50@@libunibreak@sta/linebreakdata.c.obj
[126/2419] Compiling C object src/static_libs/libunibreak/7585b50@@libunibreak@sta/linebreak.c.obj
[127/2419] Compiling C object src/bin/eolian/70b716a@@eolian_gen@exe/docs.c.obj
[128/2419] Compiling C object src/static_libs/libunibreak/7585b50@@libunibreak@sta/linebreakdef.c.obj
[129/2419] Compiling C object src/lib/eolian/15a7593@@eolian@sha/database_validate.c.obj
[130/2419] Compiling C object src/bin/eolian/70b716a@@eolian_gen@exe/sources.c.obj
[131/2419] Compiling C object src/static_libs/libunibreak/7585b50@@libunibreak@sta/emojidef.c.obj
[132/2419] Compiling C object src/static_libs/libunibreak/7585b50@@libunibreak@sta/graphemebreak.c.obj
[133/2419] Compiling C object src/static_libs/http-parser/4a9ca9e@@http-parser@sta/http_parser.c.obj
[134/2419] Compiling C object src/static_libs/libunibreak/7585b50@@libunibreak@sta/wordbreak.c.obj
[135/2419] Linking static target src/static_libs/http-parser/libhttp-parser.a
[136/2419] Compiling C object src/tests/a4ccf2d@@timeout@exe/timeout.c.obj
[137/2419] Linking target src/lib/eolian/libeolian-1.dll
[138/2419] Linking static target src/static_libs/libunibreak/liblibunibreak.a
[139/2419] Compiling C object src/static_libs/freetype/5553d54@@freetype@sta/sw_ft_stroker.c.obj
[140/2419] Linking static target src/static_libs/freetype/libfreetype.a
[141/2419] Linking target src/tests/timeout.exe
[142/2419] Compiling C object src/generic/evas/580f2bf@@evas_image_loader.gst@exe/gst_main.c.obj
[143/2419] Generating symbol file src/lib/eolian/15a7593@@eolian@sha/libeolian-1.dll.symbols
[144/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_fp.c.obj
[145/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_ustringshare.c.obj
[146/2419] Compiling C object src/generic/evas/580f2bf@@evas_image_loader.xcf@exe/xcf_pixelfuncs.c.obj
[147/2419] Linking target src/bin/eolian/eolian_gen.exe
[148/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_suite.c.obj
[149/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_debug.c.obj
../src/tests/eina/eina_test_debug.c: In function 'eina_test_debug':
../src/tests/eina/eina_test_debug.c:21:24: warning: unused parameter 'tc' [-Wunused-parameter]

21 | eina_test_debug(TCase *tc)
   |                 ~~~~~~~^~

[150/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_binshare.c.obj
[151/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_binbuf.c.obj
[152/2419] Generating eolian_gen_efl_object_override.eo with a meson_exe.py custom command
[153/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_array.c.obj
[154/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_clist.c.obj
[155/2419] Generating eolian_gen_eina_types.eot with a meson_exe.py custom command
[156/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_inarray.c.obj
[157/2419] Generating eolian_gen_efl_object.eo with a meson_exe.py custom command
[158/2419] Generating eolian_gen_efl_gfx_fill.eo with a meson_exe.py custom command
[159/2419] Generating eolian_gen_efl_gfx_entity.eo with a meson_exe.py custom command
[160/2419] Generating eolian_gen_efl_class.eo with a meson_exe.py custom command
[161/2419] Generating eolian_gen_efl_gfx_color.eo with a meson_exe.py custom command
[162/2419] Generating eolian_gen_efl_ui_draggable.eo with a meson_exe.py custom command
[163/2419] Generating eolian_gen_efl_gfx_image.eo with a meson_exe.py custom command
[164/2419] Generating eolian_gen_efl_ui_scrollbar.eo with a meson_exe.py custom command
[165/2419] Generating eolian_gen_efl_ui_scrollable.eo with a meson_exe.py custom command
[166/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_ustr.c.obj
[167/2419] Generating eolian_gen_efl_gfx_frame_controller.eo with a meson_exe.py custom command
[168/2419] Generating eolian_gen_efl_ui_container_selectable.eo with a meson_exe.py custom command
[169/2419] Compiling C object src/tests/eina/b4d9399@@eina_suite@exe/eina_test_abi.c.obj
[170/2419] Compiling C object src/lib/eo/69b6b62@@eo@sha/eo_class_class.c.obj
In file included from ../src/lib/eo/eo_class_class.c:5:
src/lib/eo/efl_class.eo.c:27:18: warning: 'efl_class_class_get' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]

27 | EFL_DEFINE_CLASS(efl_class_class_get, &_efl_class_class_desc, NULL, NULL);
   |                  ^~~~~~~~~~~~~~~~~~~

../src/lib/eo/Eo.h:801:1: note: in definition of macro 'EFL_DEFINE_CLASS'

801 | class_get_func_name(void) \
    | ^~~~~~~~~~~~~~~~~~~

[171/2419] Compiling C object src/lib/eo/69b6b62@@eo_dbg@sha/eo_class_class.c.obj
In file included from ../src/lib/eo/eo_class_class.c:5:
src/lib/eo/efl_class.eo.c:27:18: warning: 'efl_class_class_get' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]

27 | EFL_DEFINE_CLASS(efl_class_class_get, &_efl_class_class_desc, NULL, NULL);
   |                  ^~~~~~~~~~~~~~~~~~~

../src/lib/eo/Eo.h:801:1: note: in definition of macro 'EFL_DEFINE_CLASS'

801 | class_get_func_name(void) \
    | ^~~~~~~~~~~~~~~~~~~

[172/2419] Compiling C object src/lib/eo/69b6b62@@eo@sha/eo_ptr_indirection.c.obj
[173/2419] Generating eolian_gen_efl_ui_zoom.eo with a meson_exe.py custom command
[174/2419] Generating eolian_gen_efl_playable.eo with a meson_exe.py custom command
[175/2419] Compiling C object src/lib/eo/69b6b62@@eo@sha/eo_add_fallback.c.obj
[176/2419] Compiling C object src/lib/eo/69b6b62@@eo@sha/eo_base_class.c.obj
FAILED: src/lib/eo/69b6b62@@eo@sha/eo_base_class.c.obj
cc @src/lib/eo/69b6b62@@eo@sha/eo_base_class.c.obj.rsp
In file included from ../src/lib/eo/eo_base_class.c:2852:
src/lib/eo/efl_object.eo.c:1:35: error: variable '_EFL_EVENT_DEL' definition is marked dllimport

1 | EWAPI const Efl_Event_Description _EFL_EVENT_DEL =
  |                                   ^~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:1:35: warning: '_EFL_EVENT_DEL' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:3:35: error: variable '_EFL_EVENT_INVALIDATE' definition is marked dllimport

3 | EWAPI const Efl_Event_Description _EFL_EVENT_INVALIDATE =
  |                                   ^~~~~~~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:3:35: warning: '_EFL_EVENT_INVALIDATE' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:5:35: error: variable '_EFL_EVENT_NOREF' definition is marked dllimport

5 | EWAPI const Efl_Event_Description _EFL_EVENT_NOREF =
  |                                   ^~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:5:35: warning: '_EFL_EVENT_NOREF' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:7:35: error: variable '_EFL_EVENT_OWNERSHIP_UNIQUE' definition is marked dllimport

7 | EWAPI const Efl_Event_Description _EFL_EVENT_OWNERSHIP_UNIQUE =
  |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:7:35: warning: '_EFL_EVENT_OWNERSHIP_UNIQUE' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:9:35: error: variable '_EFL_EVENT_OWNERSHIP_SHARED' definition is marked dllimport

9 | EWAPI const Efl_Event_Description _EFL_EVENT_OWNERSHIP_SHARED =
  |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:9:35: warning: '_EFL_EVENT_OWNERSHIP_SHARED' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:11:35: error: variable '_EFL_EVENT_DESTRUCT' definition is marked dllimport

11 | EWAPI const Efl_Event_Description _EFL_EVENT_DESTRUCT =
   |                                   ^~~~~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:11:35: warning: '_EFL_EVENT_DESTRUCT' redeclared without dllimport attribute after being referenced with dll linkage
In file included from ../src/lib/eo/eo_base_class.c:8:
src/lib/eo/efl_object.eo.c:338:18: warning: 'efl_object_class_get' redeclared without dllimport attribute after being referenced with dll linkage

338 | EFL_DEFINE_CLASS(efl_object_class_get, &_efl_object_class_desc, NULL, NULL);
    |                  ^~~~~~~~~~~~~~~~~~~~

../src/lib/eo/Eo.h:801:1: note: in definition of macro 'EFL_DEFINE_CLASS'

801 | class_get_func_name(void) \
    | ^~~~~~~~~~~~~~~~~~~

[177/2419] Compiling C object src/lib/eo/69b6b62@@eo_dbg@sha/eo_ptr_indirection.c.obj
[178/2419] Generating eolian_gen_efl_config.eo with a meson_exe.py custom command
[179/2419] Generating eolian_gen_efl_duplicate.eo with a meson_exe.py custom command
[180/2419] Generating eolian_gen_efl_control.eo with a meson_exe.py custom command
[181/2419] Compiling C object src/lib/eo/69b6b62@@eo_dbg@sha/eo_add_fallback.c.obj
[182/2419] Generating eolian_gen_efl_file.eo with a meson_exe.py custom command
[183/2419] Compiling C object src/lib/eo/69b6b62@@eo_dbg@sha/eo_base_class.c.obj
FAILED: src/lib/eo/69b6b62@@eo_dbg@sha/eo_base_class.c.obj
cc @src/lib/eo/69b6b62@@eo_dbg@sha/eo_base_class.c.obj.rsp
In file included from ../src/lib/eo/eo_base_class.c:2852:
src/lib/eo/efl_object.eo.c:1:35: error: variable '_EFL_EVENT_DEL' definition is marked dllimport

1 | EWAPI const Efl_Event_Description _EFL_EVENT_DEL =
  |                                   ^~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:1:35: warning: '_EFL_EVENT_DEL' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:3:35: error: variable '_EFL_EVENT_INVALIDATE' definition is marked dllimport

3 | EWAPI const Efl_Event_Description _EFL_EVENT_INVALIDATE =
  |                                   ^~~~~~~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:3:35: warning: '_EFL_EVENT_INVALIDATE' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:5:35: error: variable '_EFL_EVENT_NOREF' definition is marked dllimport

5 | EWAPI const Efl_Event_Description _EFL_EVENT_NOREF =
  |                                   ^~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:5:35: warning: '_EFL_EVENT_NOREF' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:7:35: error: variable '_EFL_EVENT_OWNERSHIP_UNIQUE' definition is marked dllimport

7 | EWAPI const Efl_Event_Description _EFL_EVENT_OWNERSHIP_UNIQUE =
  |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:7:35: warning: '_EFL_EVENT_OWNERSHIP_UNIQUE' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:9:35: error: variable '_EFL_EVENT_OWNERSHIP_SHARED' definition is marked dllimport

9 | EWAPI const Efl_Event_Description _EFL_EVENT_OWNERSHIP_SHARED =
  |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:9:35: warning: '_EFL_EVENT_OWNERSHIP_SHARED' redeclared without dllimport attribute after being referenced with dll linkage
src/lib/eo/efl_object.eo.c:11:35: error: variable '_EFL_EVENT_DESTRUCT' definition is marked dllimport

11 | EWAPI const Efl_Event_Description _EFL_EVENT_DESTRUCT =
   |                                   ^~~~~~~~~~~~~~~~~~~

src/lib/eo/efl_object.eo.c:11:35: warning: '_EFL_EVENT_DESTRUCT' redeclared without dllimport attribute after being referenced with dll linkage
In file included from ../src/lib/eo/eo_base_class.c:8:
src/lib/eo/efl_object.eo.c:338:18: warning: 'efl_object_class_get' redeclared without dllimport attribute after being referenced with dll linkage

338 | EFL_DEFINE_CLASS(efl_object_class_get, &_efl_object_class_desc, NULL, NULL);
    |                  ^~~~~~~~~~~~~~~~~~~~

../src/lib/eo/Eo.h:801:1: note: in definition of macro 'EFL_DEFINE_CLASS'

801 | class_get_func_name(void) \
    | ^~~~~~~~~~~~~~~~~~~

[184/2419] Compiling C object src/lib/eo/69b6b62@@eo@sha/eo.c.obj
In file included from ../src/lib/eo/eo.c:19:
src/lib/eo/efl_object_override.eo.c:27:18: warning: 'efl_object_override_class_get' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]

27 | EFL_DEFINE_CLASS(efl_object_override_class_get, &_efl_object_override_class_desc, NULL, NULL);
   |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../src/lib/eo/Eo.h:801:1: note: in definition of macro 'EFL_DEFINE_CLASS'

801 | class_get_func_name(void) \
    | ^~~~~~~~~~~~~~~~~~~

[185/2419] Compiling C object src/lib/eo/69b6b62@@eo_dbg@sha/eo.c.obj
In file included from ../src/lib/eo/eo.c:19:
src/lib/eo/efl_object_override.eo.c:27:18: warning: 'efl_object_override_class_get' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]

27 | EFL_DEFINE_CLASS(efl_object_override_class_get, &_efl_object_override_class_desc, NULL, NULL);
   |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../src/lib/eo/Eo.h:801:1: note: in definition of macro 'EFL_DEFINE_CLASS'

801 | class_get_func_name(void) \
    | ^~~~~~~~~~~~~~~~~~~

ninja: build stopped: subcommand failed.

Nov 22 2020, 1:27 PM · efl

Nov 6 2020

vtorri added a comment to T8852: [mingw] expedite-cmp fails to compare files generate by expedite.exe.

the problem is that the output of expedite has been changed after expedite-cmp has been written. So the python script must be change to ignore the first line (iirc)

Nov 6 2020, 5:56 AM · expedite

Nov 5 2020

vtorri added a comment to D12037: Implement eina_thread for native windows.

@walac if you have problems with expedite or the fractal prog, open a task

Nov 5 2020, 10:53 AM · efl
vtorri accepted D12182: evil: Rename EAPI macro to EVIL_API in Evil library.
Nov 5 2020, 5:56 AM · efl

Nov 4 2020

vtorri added inline comments to D12037: Implement eina_thread for native windows.
Nov 4 2020, 9:30 AM · efl
vtorri added a comment to D12037: Implement eina_thread for native windows.

have you tested with expedite and the fractal code ?

Nov 4 2020, 9:26 AM · efl

Nov 3 2020

vtorri closed T8783: eina_file_test: unlink test may fail due to tmpfile is already open as Resolved.

fixed in git

Nov 3 2020, 7:02 AM · efl

Oct 26 2020

vtorri added inline comments to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.
Oct 26 2020, 11:26 PM · efl
vtorri accepted D12184: evil: undef setlocale to avoid recursion.
Oct 26 2020, 11:20 PM · efl
vtorri added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

do you mean you plan to include only evil_stdio.h for example ?

Do you think I should just add EVIL_API to evil_private.h then and have all files include it instead of evil_api.h? I can do that. Let me know if you think that's the best way.

Oct 26 2020, 1:09 PM · efl

Oct 25 2020

vtorri added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

Everything seems fine, but just to be sure, is there a real need to include evil_api.h at evil_stdlib.h and evil_dlfcn.h as it is already included at evil_private.h?

For me, it seems that including it only on evil_private.h would fit EFL's private header inclusion standard better.

It is better that when you use something, you include it. So modifications in other parts of the headers won't break something else. Just like you may get away with using size_t without include'ing stddef.h, but it is a good practice to include it anwyay.

Oct 25 2020, 12:45 PM · efl

Oct 20 2020

vtorri added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

something like

Oct 20 2020, 7:34 AM · efl

Oct 19 2020

vtorri added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

do you think that, if evil_api.h and eina_api.h are the same, we could write a macro efl_api(LIB) and we replace LIB with EVIL, EINA etc... ?

Oct 19 2020, 11:12 PM · efl

Oct 13 2020

vtorri closed T8833: Windows: States test fails as Resolved.
Oct 13 2020, 7:30 AM · efl
vtorri closed T8833: Windows: States test fails, a subtask of T8825: Windows bugs to fix, as Resolved.
Oct 13 2020, 7:30 AM · efl
vtorri added a comment to T8833: Windows: States test fails.

D12177 fixes the (un)maximize bug

Oct 13 2020, 7:29 AM · efl
vtorri added a comment to T8783: eina_file_test: unlink test may fail due to tmpfile is already open.

@jptiz normally it is fixed in git. See eacee53c2e795a1c5e187558ccced2d66390d761
At least, it works on my computer

Oct 13 2020, 7:06 AM · efl

Oct 12 2020

vtorri added inline comments to D12178: eina_value: Fix memory leak..
Oct 12 2020, 10:45 PM · efl
vtorri abandoned D12168: Evil: add native mkstemp.

rework this in D12170

Oct 12 2020, 7:03 AM · efl
vtorri added a parent revision for D12177: Ecore_Win32: add the API ecore_win32_window_maximized_set(): D12176: Ecore_Evas win32: fix activate() function.
Oct 12 2020, 7:01 AM · efl
vtorri added a child revision for D12176: Ecore_Evas win32: fix activate() function: D12177: Ecore_Win32: add the API ecore_win32_window_maximized_set().
Oct 12 2020, 7:01 AM · efl
vtorri requested review of D12177: Ecore_Win32: add the API ecore_win32_window_maximized_set().
Oct 12 2020, 6:36 AM · efl
vtorri updated the diff for D12176: Ecore_Evas win32: fix activate() function.

revert efreet modification

Oct 12 2020, 4:10 AM · efl
vtorri updated the diff for D12176: Ecore_Evas win32: fix activate() function.

use restore option to activate a window

Oct 12 2020, 4:08 AM · efl
vtorri added a comment to D12175: [WIP/Temp] Support Apng format.

why is it abandoned ?

Oct 12 2020, 3:18 AM · efl
vtorri added a comment to T8833: Windows: States test fails.

fixed activation of windows (D12176)

Oct 12 2020, 3:15 AM · efl
vtorri added reviewers for D12176: Ecore_Evas win32: fix activate() function: jptiz, felipealmeida.
Oct 12 2020, 3:13 AM · efl
vtorri requested review of D12176: Ecore_Evas win32: fix activate() function.
Oct 12 2020, 3:12 AM · efl

Oct 9 2020

vtorri updated subscribers of T8833: Windows: States test fails.
Oct 9 2020, 1:38 PM · efl
vtorri added a comment to T8833: Windows: States test fails.

2 bugs :

Oct 9 2020, 1:37 PM · efl
vtorri added a reviewer for D12171: Ecore_Evas win32 module: do not set evas viewport size to 0: jptiz.
Oct 9 2020, 1:19 PM · efl
vtorri added reviewers for D12171: Ecore_Evas win32 module: do not set evas viewport size to 0: jpcordovae, felipealmeida.
Oct 9 2020, 1:18 PM · efl
vtorri updated the test plan for D12171: Ecore_Evas win32 module: do not set evas viewport size to 0.
Oct 9 2020, 1:18 PM · efl
vtorri requested review of D12172: elua test: fix undeclared variable.
Oct 9 2020, 1:16 PM · efl
vtorri requested review of D12171: Ecore_Evas win32 module: do not set evas viewport size to 0.
Oct 9 2020, 1:07 PM · efl

Oct 8 2020

vtorri added a parent task for T8837: Eina test: eina_value test fails with long: T8825: Windows bugs to fix.
Oct 8 2020, 6:33 AM · efl
vtorri added a subtask for T8825: Windows bugs to fix: T8837: Eina test: eina_value test fails with long.
Oct 8 2020, 6:33 AM · efl
vtorri created T8837: Eina test: eina_value test fails with long.
Oct 8 2020, 6:33 AM · efl
vtorri closed T8828: Windows: cnp does not work anymore as Resolved.

solved in D12166

Oct 8 2020, 6:30 AM · efl
vtorri closed T8828: Windows: cnp does not work anymore, a subtask of T8825: Windows bugs to fix, as Resolved.
Oct 8 2020, 6:30 AM · efl
vtorri closed T8827: Windows: elementary_config does not save configuration as Resolved.

solved in D12165

Oct 8 2020, 6:30 AM · efl
vtorri closed T8827: Windows: elementary_config does not save configuration, a subtask of T8825: Windows bugs to fix, as Resolved.
Oct 8 2020, 6:30 AM · efl
vtorri requested review of D12170: Evil : move mkstemp(s) and mkdtemp in eina_file directly.
Oct 8 2020, 3:17 AM · efl

Oct 6 2020

vtorri added a comment to T8807: emile doesn't compile with gnutls.

yes, and on BSD, only openssl is used, no gnutls.

Oct 6 2020, 11:18 PM · efl
vtorri assigned T8807: emile doesn't compile with gnutls to bu5hm4n.

if it's on BSD, there is a reason explained in top level meson.build, line 225

Oct 6 2020, 9:27 PM · efl

Oct 5 2020

vtorri added a comment to D12135: Added the heif loader.

ok. I have asked on libheif github if they can re-license the code to lgpl v2. Let's see if they accept or not

Oct 5 2020, 3:33 PM · efl
vtorri added a comment to D12135: Added the heif loader.

or we can do like poppler, maybe ? using the generic loader

Oct 5 2020, 9:29 AM · efl
vtorri updated subscribers of D12135: Added the heif loader.

@thierry1970 btw, something that is annoying is the license of libheif (found there : https://github.com/strukturag/libheif) : the license is LGPL v3, and not v2.
@raster do you htink the license is a problem ?

Oct 5 2020, 6:47 AM · efl
vtorri added a comment to D12167: Eina value: fix test on Windows.

doing a test with long and 32 bits value just hide the problem

Oct 5 2020, 3:55 AM · efl
vtorri added a comment to D12167: Eina value: fix test on Windows.

you can't have a cross-compiled way to use eina_value with long . So i think it would be better to deprecated eina_value with long (imho)

Oct 5 2020, 3:54 AM · efl
vtorri added reviewers for D12168: Evil: add native mkstemp: raster, jptiz, felipealmeida.
Oct 5 2020, 2:18 AM · efl
vtorri requested review of D12168: Evil: add native mkstemp.
Oct 5 2020, 2:15 AM · efl

Oct 2 2020

vtorri added a reviewer for D12167: Eina value: fix test on Windows: felipealmeida.
Oct 2 2020, 2:23 AM · efl