Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (383 w, 5 d)
Availability
Available

Recent Activity

Today

vtorri updated the diff for D12039: Windows: remove Evil dependency, general cleanup for Windows.

remove objc support

Mon, Jul 6, 10:49 AM

Thu, Jul 2

vtorri accepted D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.
Thu, Jul 2, 10:36 PM · efl
vtorri updated the diff for D12039: Windows: remove Evil dependency, general cleanup for Windows.

remove unused c++ files, clean up configure.ac

Thu, Jul 2, 6:40 AM

Wed, Jul 1

vtorri requested review of D12039: Windows: remove Evil dependency, general cleanup for Windows.
Wed, Jul 1, 12:30 PM

Tue, Jun 30

vtorri accepted D12022: windows: Fix path for file sanitization.

i've applied it and unit tests are successful, so ok for it

Tue, Jun 30, 12:09 PM · efl
vtorri added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

I don't want to install an application to be able to compile or download dependencies. This makes no sense at all IMO. If we're not going to have wrap dependencies, we still need to be able to tell where dependencies are without pkg-config.

Tue, Jun 30, 11:24 AM · efl
vtorri added a comment to D12037: Implement eina_thread for native windows.

note that, for ecore, the handle returned by _beginthreadex() must wait with the WaitFor* functions, that is, it must be used with ecore_main_win32_handler_add()

Tue, Jun 30, 1:54 AM · efl
vtorri added inline comments to D12037: Implement eina_thread for native windows.
Tue, Jun 30, 1:52 AM · efl

Mon, Jun 29

vtorri added a comment to D12037: Implement eina_thread for native windows.

for expedite, with and without -y parameter (async on/off)

Mon, Jun 29, 11:01 AM · efl
vtorri added inline comments to D12037: Implement eina_thread for native windows.
Mon, Jun 29, 10:44 AM · efl
vtorri added a comment to D12037: Implement eina_thread for native windows.

try also expedite (https://git.enlightenment.org/tools/expedite.git/) with the software (gdi or ddraw) backend to benchmark it, compared to the current efl git

Mon, Jun 29, 10:04 AM · efl
vtorri added inline comments to D12037: Implement eina_thread for native windows.
Mon, Jun 29, 9:39 AM · efl
vtorri added inline comments to D12037: Implement eina_thread for native windows.
Mon, Jun 29, 9:37 AM · efl
vtorri added a comment to D12037: Implement eina_thread for native windows.

test this program on linux, then test it on windows and see if it is working nicely

Mon, Jun 29, 9:19 AM · efl

Sat, Jun 27

vtorri added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

people who are compiling the EFL are very few : packagers (unix world), and devs. Packagers don't need wrap stuff at all. They represent 99% of the people who compile
the others are devs. And the devs are those who compile on unix and those who compile on Windows
and on Windows, there are those who compile with gcc, and the others for Visual Studio

Sat, Jun 27, 1:12 PM · efl
vtorri added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

and I honestly think that it is not the purpose of the EFL build system to build the dependencies. It will add too much stuff to meson

Sat, Jun 27, 12:38 AM · efl

Fri, Jun 26

vtorri added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

i'm not very fond of wrapping in meson, because you don't have any control on how the lib is built. For example, is zlib built using the asm files ?

Fri, Jun 26, 2:17 PM · efl
vtorri added a comment to D12021: Fix eina file thread test on Windows.

@stefan_schmidt is there something else to do ?

Fri, Jun 26, 6:24 AM · efl
vtorri accepted D12033: Native Windows: Eina: Resolve bad comparison while using windows strerror_s.
Fri, Jun 26, 5:54 AM · efl

Thu, Jun 25

vtorri updated the diff for D12031: Windows: fix eina_file_map_new().

fix case when map is found in the hash table

Thu, Jun 25, 7:44 AM · efl
vtorri added inline comments to D12031: Windows: fix eina_file_map_new().
Thu, Jun 25, 7:00 AM · efl
vtorri updated the summary of D12031: Windows: fix eina_file_map_new().
Thu, Jun 25, 4:34 AM · efl
vtorri added inline comments to D11994: Meson.build cleanup..
Thu, Jun 25, 4:30 AM · efl
vtorri requested review of D12031: Windows: fix eina_file_map_new().
Thu, Jun 25, 4:23 AM · efl

Wed, Jun 24

vtorri added inline comments to D12021: Fix eina file thread test on Windows.
Wed, Jun 24, 6:28 AM · efl
vtorri added inline comments to D12021: Fix eina file thread test on Windows.
Wed, Jun 24, 6:26 AM · efl
vtorri added inline comments to D12021: Fix eina file thread test on Windows.
Wed, Jun 24, 2:49 AM · efl

Tue, Jun 23

vtorri added a comment to D12022: windows: Fix path for file sanitization.

i've looked at https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths and i indeed see it can begin with \ (but not /) :

"A file name is relative to the current directory if it does not begin with one of the following etc... "
"A single backslash, for example, "\directory" or "\file.txt". This is also referred to as an absolute path."

i don't know if you should also consider /

It's common for applications ported to windows to consider both \ and / (e.g. neovim). Maybe it would be a nice idea if EFL accepted both as well? At least in Windows.

we do almost nothing about that. Usually, when one passes a path to a Windows file API, the API changes all the slashes to backslashes

Hm, so you mean that in EFL's point of view, it doesn't matter if the path is with \\ or /, the only one who would and should care is the underlying OS API (which will then report if the path is or not valid)?

Tue, Jun 23, 11:30 AM · efl
vtorri added a comment to D12022: windows: Fix path for file sanitization.

and if an application is not working correctly wrt (back)slashes, then i consider this as a bug

Tue, Jun 23, 11:29 AM · efl
vtorri added a comment to D12022: windows: Fix path for file sanitization.

i've looked at https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths and i indeed see it can begin with \ (but not /) :

"A file name is relative to the current directory if it does not begin with one of the following etc... "
"A single backslash, for example, "\directory" or "\file.txt". This is also referred to as an absolute path."

i don't know if you should also consider /

It's common for applications ported to windows to consider both \ and / (e.g. neovim). Maybe it would be a nice idea if EFL accepted both as well? At least in Windows.

Tue, Jun 23, 11:13 AM · efl
vtorri added a comment to D12022: windows: Fix path for file sanitization.

i've looked at https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths and i indeed see it can begin with \ (but not /) :

Tue, Jun 23, 9:35 AM · efl
vtorri accepted D12021: Fix eina file thread test on Windows.
Tue, Jun 23, 8:18 AM · efl
vtorri added a comment to D12021: Fix eina file thread test on Windows.

more a coding convention

Tue, Jun 23, 8:03 AM · efl
vtorri added a comment to D12021: Fix eina file thread test on Windows.

last thing for me : we declare variables always at the beginning of the block (exception in eo/eolian)
otherwise, good for me (tested)

Tue, Jun 23, 7:50 AM · efl
vtorri added inline comments to D12021: Fix eina file thread test on Windows.
Tue, Jun 23, 7:40 AM · efl
vtorri requested changes to D12021: Fix eina file thread test on Windows.
Tue, Jun 23, 7:24 AM · efl

Sat, Jun 20

vtorri added inline comments to D11999: Get rid of trailing whitespace (1 / 14).
Sat, Jun 20, 8:55 AM · efl

Fri, Jun 19

vtorri added a comment to D11972: eina_unicode: have explicit type conversions.

seems good to me

Fri, Jun 19, 9:20 PM · efl
vtorri added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

now look at what i have written :

[snip code]

5 modified files, 4 libraries (evil, eina, eolian, eo), patch of 95 lines. I've verified that for each of these 4 libs, EAPI is dllexport, and for eolian_gen, it's dllimport

Why should eolian_gen be dllimport?

Fri, Jun 19, 11:50 AM · efl
vtorri added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

with my patch,there can't be any, by the very definition of EFL_XXX_BUILD that i am doing

Fri, Jun 19, 7:50 AM · efl
vtorri added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

do you realize that, with this kind of changes, you are going to change almost all the files of the EFL ?

Fri, Jun 19, 5:59 AM · efl
vtorri added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

@walac your prefer this patch which modifies 143 files, ONLY for eina, to my patch, which modifies 5 files for 4 libraries, with the same result ?? that's crazy

Fri, Jun 19, 5:58 AM · efl
vtorri added a comment to D11994: Meson.build cleanup..

for 8, i am not against /. Windows file system understands / as path separator, so same path separator for all the OS

Fri, Jun 19, 2:04 AM · efl

Thu, Jun 18

vtorri added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

now look at what i have written :

Thu, Jun 18, 11:23 PM · efl
vtorri added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

and in case you don't know, i've supported Visual Studio build system for the EFL during years , with only EAPI and not a macro for each library.

I imagine your pain! Just because something is possible, doesn't mean it is a good thing.

Thu, Jun 18, 11:48 AM · efl
vtorri added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

i'm against this patch.

  • Even if EAPI is only needed in the header file, we keep EAPI in source file so that it is easier to see the definition of public symbols

There are sometime warnings when used in definitions. But I'm not against in keeping it. I can re-add them in .c files in a new patch if you want.

  • it's perfectly possible to define correctly EAPI without modifying all the files

This patch fixed two errors that nobody, EVER, noticed. Because EAPI is being reused. This is the right way to go, because it is simple, elegant, more flexible and easier to understand. Wanting to keep a bad thing just for keeping makes no sense.

Thu, Jun 18, 11:30 AM · efl
vtorri requested changes to D11993: eina: Change EAPI to EINA_API in Eina Library.

i'm against this patch.

Thu, Jun 18, 10:54 AM · efl

Tue, Jun 16

vtorri added a comment to D11973: meson: add Solaris support.

@bu5hm4n wait a bit : it seems that mallinfo in libmalloc should not be used, i am waiting some confirmation

Tue, Jun 16, 9:25 PM · efl
vtorri added reviewers for D11983: Fix ENOMEM message on Windows and solaris: jptiz, walac.
Tue, Jun 16, 2:52 PM · efl
vtorri updated subscribers of D11983: Fix ENOMEM message on Windows and solaris.
Tue, Jun 16, 2:51 PM · efl
vtorri updated subscribers of D11983: Fix ENOMEM message on Windows and solaris.
Tue, Jun 16, 2:48 PM · efl
vtorri requested review of D11983: Fix ENOMEM message on Windows and solaris.
Tue, Jun 16, 2:47 PM · efl
vtorri updated subscribers of D11973: meson: add Solaris support.
Tue, Jun 16, 12:48 PM · efl
vtorri added inline comments to D11973: meson: add Solaris support.
Tue, Jun 16, 12:44 PM · efl
vtorri updated the diff for D11973: meson: add Solaris support.

remove useless link flag

Tue, Jun 16, 12:43 PM · efl
vtorri added inline comments to D11949: efl_ui_textpath: mathmatical calculations.
Tue, Jun 16, 12:58 AM · efl
vtorri added inline comments to D11949: efl_ui_textpath: mathmatical calculations.
Tue, Jun 16, 12:53 AM · efl

Mon, Jun 15

vtorri updated the diff for D11973: meson: add Solaris support.

pie is not supported by the solaris linker

Mon, Jun 15, 5:46 AM · efl
vtorri updated the diff for D11973: meson: add Solaris support.

sunos build : add mallinfo() check

Mon, Jun 15, 5:20 AM · efl
vtorri updated the diff for D11973: meson: add Solaris support.

move socket dep to eina_deps

Mon, Jun 15, 4:20 AM · efl
vtorri abandoned D11977: sunos: move socket dpe in eina_deps.
Mon, Jun 15, 4:16 AM · efl
vtorri requested review of D11977: sunos: move socket dpe in eina_deps.
Mon, Jun 15, 4:15 AM · efl

Sat, Jun 13

vtorri requested review of D11973: meson: add Solaris support.
Sat, Jun 13, 1:24 AM · efl

Fri, Jun 12

vtorri added inline comments to D11971: eina_test_file.c: Do not test errno if the function doesn't fail.
Fri, Jun 12, 1:14 PM · efl
vtorri added a comment to D11970: efl_check.h: Replace stack allocated array by heap allocated.

or alloca() ? Normally, it is correctly declares (see eina_alloca.h)

Fri, Jun 12, 1:12 PM · efl

Wed, Jun 10

vtorri added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

Exactly. Another special case. What do we want to accomplish with this added complexity? Is EFL supposed to be multi-platform or not? Is Windows a platform that EFL is supposed to run on ? If it is not supposed to run in WIndows, then I'll glad fork it for what we need. But go through with undef/def of symbols which means ABSOLUTELLY different things in the same translation unit is completely bizarre.

Wed, Jun 10, 11:59 AM · efl

Tue, Jun 9

vtorri added reviewers for D11961: Use extern after EAPI: raster, bu5hm4n, stefan_schmidt.
Tue, Jun 9, 10:14 PM · efl
vtorri requested review of D11961: Use extern after EAPI.
Tue, Jun 9, 10:07 PM · efl
vtorri added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

#if defined EFL_ONE_BUILD || defined EFL_EINA_BUILD

Tue, Jun 9, 2:05 PM · efl
vtorri added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

@felipealmeida that's what i did in my first definition of EAPI a long time ago : i used EFL_EINA_BUILD in EAPI definition and I added -DEFL_EINA_BUILD when compiling the lib, that's all

Tue, Jun 9, 1:07 PM · efl
vtorri added a comment to D11949: efl_ui_textpath: mathmatical calculations.

note that there is a company which is actually trying to help the windows port, using the microsoft compiler, so please don't consider that only gcc will be used

Tue, Jun 9, 6:04 AM · efl

Mon, Jun 8

vtorri added inline comments to D11947: efl: reduce PI calculations.
Mon, Jun 8, 1:26 PM · efl

Jun 4 2020

vtorri added inline comments to D11939: [WIP] eapi: Fix usage of dllimport/export.
Jun 4 2020, 9:19 PM · efl
vtorri added inline comments to D11939: [WIP] eapi: Fix usage of dllimport/export.
Jun 4 2020, 9:16 PM · efl
vtorri added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

Hum, right. Does it apply for the "upper" libraries? i.e. ecore_something.h including Eina.h? I.e. #include Eina.h should come before any #include ecore_<...>.h, right?

Jun 4 2020, 12:25 PM · efl
vtorri added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

but eina_types.h must not be inluded by any program, never. It's Eina.h that must be included, always. eina_types.h is included explicitely only in eina source code. Also the order of all the eina_.h is important, and including for example, evil_private.h in between eina_*.h is just wrong. evil_private.h MUST be included before any eina header file used in eina source code.

Jun 4 2020, 11:57 AM · efl
vtorri requested changes to D11939: [WIP] eapi: Fix usage of dllimport/export.
Jun 4 2020, 9:41 AM · efl
vtorri added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

why not letting EAPI in eina_types.h ? I don't think that there is any benefit

Jun 4 2020, 9:40 AM · efl

May 26 2020

vtorri added a reviewer for D11885: Eina file test: use the correct Eina file object: jptiz.
May 26 2020, 2:51 PM · efl
vtorri added a reviewer for D11884: Eina file test: on Windows, open cmd, not a shell: jptiz.
May 26 2020, 2:50 PM · efl
vtorri requested review of D11885: Eina file test: use the correct Eina file object.
May 26 2020, 2:49 PM · efl
vtorri requested review of D11884: Eina file test: on Windows, open cmd, not a shell.
May 26 2020, 2:45 PM · efl
vtorri accepted D11881: ecore_main_timechanges: fix include.
May 26 2020, 1:53 AM · efl
vtorri accepted D11851: build: move EFL_BUILD to package_c_args used in all subprojects.
May 26 2020, 12:57 AM · efl

May 25 2020

vtorri added a comment to D11855: build: modules: harmonize use of package_c_args.

ok for clang format

May 25 2020, 12:26 AM · efl

May 24 2020

vtorri added a comment to T8731: eina thread compilation fails on Windows because of undeclared identifiers.

this should also break everything not linux, as SCHED_IDLE is specific to linux

May 24 2020, 6:20 AM · Restricted Project
vtorri added a comment to T8731: eina thread compilation fails on Windows because of undeclared identifiers.

on Windows, see

May 24 2020, 6:03 AM · Restricted Project
vtorri added a comment to T8731: eina thread compilation fails on Windows because of undeclared identifiers.

https://git.enlightenment.org/core/efl.git/commit/src/lib/eina?id=a555fbf7693338d8b545d89f87a45852958a2166

May 24 2020, 4:34 AM · Restricted Project
vtorri added a project to T8731: eina thread compilation fails on Windows because of undeclared identifiers: Restricted Project.
May 24 2020, 4:02 AM · Restricted Project
vtorri triaged T8731: eina thread compilation fails on Windows because of undeclared identifiers as Showstopper Issues priority.
May 24 2020, 4:02 AM · Restricted Project

May 22 2020

vtorri added reviewers for D11872: elm test: include evil_private.h to declare realpath() on Windows: raster, zmike.
May 22 2020, 9:45 PM · efl
vtorri added a parent revision for D11873: allow compilation on OS != Windows: D11872: elm test: include evil_private.h to declare realpath() on Windows.
May 22 2020, 9:43 PM · efl
vtorri added a child revision for D11872: elm test: include evil_private.h to declare realpath() on Windows: D11873: allow compilation on OS != Windows.
May 22 2020, 9:43 PM · efl
vtorri added a comment to D11872: elm test: include evil_private.h to declare realpath() on Windows.

missing guards, see D11873

May 22 2020, 9:43 PM · efl
vtorri added reviewers for D11873: allow compilation on OS != Windows: raster, zmike.
May 22 2020, 9:42 PM · efl
vtorri requested review of D11873: allow compilation on OS != Windows.
May 22 2020, 9:39 PM · efl
vtorri requested review of D11872: elm test: include evil_private.h to declare realpath() on Windows.
May 22 2020, 9:36 PM · efl
vtorri requested review of D11871: ecore_evas: fix uninitialized variable warning.
May 22 2020, 9:26 PM · efl

May 20 2020

vtorri accepted D11860: lib: add more c_args handling for places we missed before.

i didn't touch those meson files as they are not used on Windows :-)

May 20 2020, 1:21 AM · efl

May 19 2020

vtorri added a comment to D11851: build: move EFL_BUILD to package_c_args used in all subprojects.

what about setting EFL_BUILD only if subproject is mod or lib ? it seems more logical to set it when needed, not unset it when it's not needed

May 19 2020, 5:02 AM · efl