Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (312 w, 1 d)
Availability
Available

Recent Activity

Yesterday

vtorri updated the diff for D7926: Eina: implement strtod in C locale and remove linkl against msvcr100. This fixes compilation on Windows More precisely edje_cc could not compile emotion edc files, so it was a runtime problem because of msvcr100 link. Add more tests than before.
Wed, Feb 20, 9:10 PM · efl

Fri, Feb 15

vtorri added a comment to D7926: Eina: implement strtod in C locale and remove linkl against msvcr100. This fixes compilation on Windows More precisely edje_cc could not compile emotion edc files, so it was a runtime problem because of msvcr100 link. Add more tests than before.

it seems that whatever fix I do, i will never be able to implement a strtod so that it gives the same results than all the possible imlementations of strtod in the world (glibc, Windows libc, clang, newlib, freebsd, musl, maybe cygwin too, etc...).

Fri, Feb 15, 12:02 AM · efl

Thu, Feb 14

vtorri accepted D7947: tests: guard eina bool variable to avoid compilation failure on windows.
Thu, Feb 14, 2:51 AM · efl

Wed, Feb 13

vtorri added a comment to D7926: Eina: implement strtod in C locale and remove linkl against msvcr100. This fixes compilation on Windows More precisely edje_cc could not compile emotion edc files, so it was a runtime problem because of msvcr100 link. Add more tests than before.

about the first test which fails, it's not a problem of value, it's a problem of errno value which is not the same (no errno set contrary to strtod which sets errno to ERANGE)

Wed, Feb 13, 10:08 AM · efl
vtorri added a comment to D7926: Eina: implement strtod in C locale and remove linkl against msvcr100. This fixes compilation on Windows More precisely edje_cc could not compile emotion edc files, so it was a runtime problem because of msvcr100 link. Add more tests than before.

on fedora, in the eina suite, only eina_convert fails.
I can comment the tests which fail if you want :-)

Wed, Feb 13, 10:05 AM · efl
vtorri added a comment to D7926: Eina: implement strtod in C locale and remove linkl against msvcr100. This fixes compilation on Windows More precisely edje_cc could not compile emotion edc files, so it was a runtime problem because of msvcr100 link. Add more tests than before.

about the bugs, it's certainly something which can be fixed. but instead of having 0, this implementation return 2E-308, or the contrary (not a big deal imho, especially for a function which is never used).

Wed, Feb 13, 8:01 AM · efl
vtorri closed T7693: efl_core_env: setenv, unsetenv and clearenv do not exist on Windows as Invalid.

after checking, with D7926, no problem with env functions, closing

Wed, Feb 13, 4:10 AM · efl
vtorri added a comment to D7872: Revert "autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale()".

can be abandoned after push of D7926 (D7926 also fixes meson)

Wed, Feb 13, 4:08 AM · efl
vtorri added a comment to D7926: Eina: implement strtod in C locale and remove linkl against msvcr100. This fixes compilation on Windows More precisely edje_cc could not compile emotion edc files, so it was a runtime problem because of msvcr100 link. Add more tests than before.

I've check the compilation on Windows (MSYS2, mingw-w64, autotools) and Fedora. Compilation was fine on both OS. On Fedora, tests fail (when compared to strtod) on some rare values (around 2e-308) and for NAN

Wed, Feb 13, 4:06 AM · efl
vtorri added a comment to D7877: ecore: tests: add missing include path to make ecore_audio build in distcheck.
Wed, Feb 13, 4:05 AM · efl
vtorri requested review of D7926: Eina: implement strtod in C locale and remove linkl against msvcr100. This fixes compilation on Windows More precisely edje_cc could not compile emotion edc files, so it was a runtime problem because of msvcr100 link. Add more tests than before.
Wed, Feb 13, 4:01 AM · efl

Tue, Feb 12

vtorri updated subscribers of T7693: efl_core_env: setenv, unsetenv and clearenv do not exist on Windows.
Tue, Feb 12, 3:28 AM · efl
vtorri triaged T7693: efl_core_env: setenv, unsetenv and clearenv do not exist on Windows as Showstopper Issues priority.
Tue, Feb 12, 3:26 AM · efl

Mon, Feb 4

vtorri updated subscribers of D7872: Revert "autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale()".

we need a strtod implementation. I have one that i have sent to @raster by mail.
this strtod function can be used for all platform

Mon, Feb 4, 6:45 AM · efl
vtorri accepted D7873: examples: ecore: bring back inet.h include for inet_pton().

no problem on Windows side.

Mon, Feb 4, 6:43 AM · efl

Sun, Feb 3

vtorri added a comment to T7088: git-phab documentation needs improving.

the fdo link in https://phab.enlightenment.org/w/arcanist/ is just not working at all

Sun, Feb 3, 10:23 PM · efl: docs

Fri, Feb 1

vtorri added a comment to D7834: replace hton and ntoh family functions with ones defined in eina.

@ManMower if the question is for me, yes : Windows and Fedora

Fri, Feb 1, 11:06 AM · efl

Wed, Jan 30

vtorri added a comment to D7834: replace hton and ntoh family functions with ones defined in eina.

somme comments:

Wed, Jan 30, 10:13 PM · efl
vtorri requested review of D7834: replace hton and ntoh family functions with ones defined in eina.
Wed, Jan 30, 12:23 PM · efl

Tue, Jan 22

vtorri added a comment to T2261: ecore_file_ls must be reviewed on Windows.

for now, i can't even compile the EFL on Windows, so...

Tue, Jan 22, 1:08 PM · efl: system integration
vtorri edited the content of Windows.
Tue, Jan 22, 5:02 AM

Jan 2 2019

vtorri closed D7528: Add support of Windows 8, 8.1 and 10.
Jan 2 2019, 1:35 AM · efl

Jan 1 2019

vtorri added a comment to D7528: Add support of Windows 8, 8.1 and 10.

fix wrong ]

Jan 1 2019, 11:16 PM · efl
vtorri updated the diff for D7528: Add support of Windows 8, 8.1 and 10.
  • meson: remove wrong ]
Jan 1 2019, 11:16 PM · efl
vtorri added a comment to D7528: Add support of Windows 8, 8.1 and 10.

i've tested the autotools before creating this diff

Jan 1 2019, 9:53 AM · efl

Dec 31 2018

vtorri updated the diff for D7528: Add support of Windows 8, 8.1 and 10.
  • meson: Improve description of 'windows-version' option
Dec 31 2018, 3:19 AM · efl
vtorri updated the diff for D7528: Add support of Windows 8, 8.1 and 10.
  • Add windows-version option to meson build (like autotools)
Dec 31 2018, 12:22 AM · efl

Dec 29 2018

vtorri added a comment to D7528: Add support of Windows 8, 8.1 and 10.

@bu5hm4n you do not *find* what you target, you *set* what you target. It is the way to make available some features in the header files, at compile time, for the target we want. That's why there is no way to automatically know which version we target, especially if we cross compile on linux...

Dec 29 2018, 6:50 AM · efl

Dec 28 2018

vtorri updated the diff for D7528: Add support of Windows 8, 8.1 and 10.
  • Evil: simplify m4 code for the target Windows we want
Dec 28 2018, 10:03 PM · efl
vtorri requested review of D7528: Add support of Windows 8, 8.1 and 10.
Dec 28 2018, 11:29 AM · efl

Dec 20 2018

vtorri added a comment to D7471: eina blist data structure proposal.

On Windows (i7 6700K):

Dec 20 2018, 4:00 AM · efl
vtorri accepted D7458: eina: use the correct type for casting to avoid issue on Windows..
Dec 20 2018, 12:00 AM · efl

Dec 19 2018

vtorri added a comment to D7471: eina blist data structure proposal.

yes, i'vealso seen this in SO. I've changed the blist code directly...
now i'm recompiling the efl 1.21 with -O3 -march=native ...

Dec 19 2018, 12:07 PM · efl
vtorri added a comment to D7471: eina blist data structure proposal.

on Windows :

Dec 19 2018, 11:41 AM · efl

Dec 7 2018

vtorri added a comment to D7428: autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale().

someting like that :

Dec 7 2018, 5:49 AM · efl
vtorri reopened D7428: autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale().

we need to think of better ways

Dec 7 2018, 5:35 AM · efl
vtorri reopened D7378: ci: mingw: enable various build options with dependencies now satisfied.

harfbuzz too

Dec 7 2018, 5:33 AM · efl
vtorri added a comment to D7378: ci: mingw: enable various build options with dependencies now satisfied.

libwebp must be added

Dec 7 2018, 3:52 AM · efl
vtorri added a comment to D7428: autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale().

btw why linking in evil ?? the symbols are in eina...

Dec 7 2018, 3:50 AM · efl
vtorri added a comment to D7428: autotools: evil: add needed -lmsvcr100 library flag for _create/_free_locale().

msvcr100.a is provided by mingw64, but are we sure that the DLL is installed ? If not, the application will fail with function not defined. That can be a problem

Dec 7 2018, 3:47 AM · efl

Dec 6 2018

vtorri added a comment to T7497: _create_locale and _free_locale undefined on Windows.

you reverted the revert so you knew what you were doing.
otherwise, don't revert

Dec 6 2018, 2:14 PM · efl (efl-1.22), Restricted Project
vtorri updated the task description for T7497: _create_locale and _free_locale undefined on Windows.
Dec 6 2018, 1:26 PM · efl (efl-1.22), Restricted Project
vtorri triaged T7497: _create_locale and _free_locale undefined on Windows as Showstopper Issues priority.
Dec 6 2018, 1:20 PM · efl (efl-1.22), Restricted Project

Nov 29 2018

vtorri edited the content of Windows.
Nov 29 2018, 1:56 PM
vtorri added a comment to D7378: ci: mingw: enable various build options with dependencies now satisfied.

Stefan helped me to fix issues with ewpi and ewpi compiles finely on fedora. So for me no problem on the ewpi side

Nov 29 2018, 2:20 AM · efl

Nov 27 2018

vtorri edited the content of Windows.
Nov 27 2018, 7:47 AM

Nov 25 2018

vtorri edited the content of Windows.
Nov 25 2018, 5:37 AM

Nov 16 2018

vtorri edited the content of Windows.
Nov 16 2018, 12:51 PM

Nov 12 2018

vtorri edited the content of Windows.
Nov 12 2018, 12:29 PM
vtorri edited the content of Windows.
Nov 12 2018, 12:20 PM
vtorri edited the content of Windows.
Nov 12 2018, 11:53 AM

Sep 10 2018

vtorri accepted D6644: eina: add locale-independent eina_convert_strtod_c function.
Sep 10 2018, 9:16 PM · efl

Aug 23 2018

vtorri added a comment to D6869: eina: find a real path of dynamic library.

i don't understand why using a function (using it only once) with a #ifdef instead of using the #ifdef directly...

Aug 23 2018, 10:19 PM · efl

Aug 16 2018

vtorri accepted D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.
Aug 16 2018, 9:33 PM · efl

Aug 15 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

i can't test anything until september, just look at code
i will abandon it and open another one, then, but in september

Aug 15 2018, 6:51 AM · efl

Aug 14 2018

vtorri added a comment to D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.

man strncpy says

Aug 14 2018, 9:43 AM · efl
vtorri added a comment to D6681: build: fix evas static build of gl engines.

there is no gl engines on Windows, so...

Aug 14 2018, 8:38 AM · Restricted Project
vtorri added a comment to D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.

is there a unit test about this problem ?

Aug 14 2018, 6:00 AM · efl
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

sorry, i was on holydays and forget about your patch

Aug 14 2018, 2:08 AM · efl

Aug 6 2018

vtorri added a comment to D6742: eina_vpath: fix homedirectory fetching.

getpwnam does not exist on Windows. it may be possible to get the home directory of a user. It is not straightforward, but i have seen some ideas about that

Aug 6 2018, 9:28 PM · efl

Aug 2 2018

vtorri added a comment to D6682: build: break out ddraw and cocoa static engine builds into utility libraries.

i plan to use C API for the ddraw engine, so there should be no problem in the future (around september/october)

Aug 2 2018, 9:01 PM · Restricted Project

Jul 30 2018

vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

you have not documented the behavior of the API function when the first argument is NULL or empty

Jul 30 2018, 3:45 AM · efl
vtorri added a comment to T7221: efl_selection_manager: implement full clipboard support.

that will certainly help, thank you

Jul 30 2018, 2:15 AM · Active Work Proposal, efl: widgets, Restricted Project, efl (efl-1.22)
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

rename _eina_c_locale_get() to _eina_c_locale_new() and _eina_c_locale_free() to _eina_c_locale_del() to follow EFL conventions

Jul 30 2018, 2:14 AM · efl
vtorri accepted D6635: build: fix rpath for binaries which use ecore-x dependencies.

no problem for me, the m4 diff is only a reordering of variables

Jul 30 2018, 12:57 AM · Restricted Project
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

add also several tests for exponential representation of the number

Jul 30 2018, 12:31 AM · efl
vtorri added a comment to T7221: efl_selection_manager: implement full clipboard support.

i've already implemented the clipboard support. Maybe change in the infra has removed it

Jul 30 2018, 12:28 AM · Active Work Proposal, efl: widgets, Restricted Project, efl (efl-1.22)
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

I've just realized that you don't call freelocale() to deallocate the resources.

Jul 30 2018, 12:22 AM · efl

Jul 28 2018

vtorri created T7220: multiple defined variables in Makefiles.
Jul 28 2018, 4:54 AM · Restricted Project, Restricted Project

Jul 27 2018

vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

strtod_l does not exist on Windows, use _strtod_l instead

Jul 27 2018, 12:39 PM · efl

Jul 26 2018

vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

you didn't add the typedef

Jul 26 2018, 5:35 AM · efl
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

still error : line 457, the type is still locale_t

Jul 26 2018, 5:09 AM · efl
vtorri added a comment to D6644: eina: add locale-independent eina_convert_strtod_c function.

is there a test program so i can test this code ?

Jul 26 2018, 4:17 AM · efl
vtorri requested changes to D6644: eina: add locale-independent eina_convert_strtod_c function.

on Windows, newlocale() does not exist :

Jul 26 2018, 2:45 AM · efl

Jul 20 2018

vtorri accepted D6648: ecore: remove exit_signal_received conditional from windows build.
Jul 20 2018, 12:14 PM · Restricted Project

Jul 13 2018

vtorri accepted D6591: evas: fix minor typo in smart class color_set method doc.
Jul 13 2018, 2:08 PM · efl: docs

Jun 29 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

i will open a new ticket instead of trying to fix this mess, arcanist is too complicated for me

Jun 29 2018, 11:41 AM · efl
vtorri abandoned D6363: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206.

i used wrongly arcanist locally, so i created another patch, see D6478
closing this one

Jun 29 2018, 1:00 AM · efl
vtorri added a reviewer for D6478: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix T5206: an.kroitor.
Jun 29 2018, 12:59 AM · efl
Herald added a reviewer for D6478: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix T5206: devilhorns.
Jun 29 2018, 12:58 AM · efl

Jun 28 2018

vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
  • Evil: fix usage of Evil in a program compiled with vc++
  • Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206
Jun 28 2018, 11:07 PM · efl

Jun 26 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

@lauromoura but you said : "According to msys' pacman, I'm using mingw64/mingw-w64-x86_64-dbus 1.12.8-1." ?!?!?

Jun 26 2018, 5:59 AM · efl

Jun 25 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

i use d-bus from win-builds

Jun 25 2018, 9:49 PM · efl

Jun 22 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

patch update

Jun 22 2018, 1:45 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
Jun 22 2018, 1:44 PM · efl
vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

ok, tests are run now, i have 12 successful tests and 15 which fail

Jun 22 2018, 1:22 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
  • Tests: remove warnings when compiling tests if fork is not available and run tests properly on Windows
Jun 22 2018, 1:20 PM · efl
vtorri accepted D6369: ecore/glib: add #ifdef guards for newly added includes.
Jun 22 2018, 12:38 PM · efl
vtorri accepted D6368: evas/cpu: rework SIGILL code for non-x86 (and fix windows build).
Jun 22 2018, 12:36 PM · efl
vtorri added a comment to D6369: ecore/glib: add #ifdef guards for newly added includes.

i would have done :

Jun 22 2018, 12:23 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
Jun 22 2018, 11:55 AM · efl
vtorri added a comment to D6363: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206.

i've already broken the API on Windows several times. These functions are not used anymore and should not be used, even internally.

Jun 22 2018, 6:44 AM · efl
vtorri added a comment to T5206: windows: headers are messed up.

see D6363

Jun 22 2018, 12:07 AM · efl (efl-1.21), Restricted Project, Windows
Herald added a reviewer for D6363: Evil: fix usage of Evil in a program compiled with vc++ this should be enough to fix #T5206: devilhorns.
Jun 22 2018, 12:06 AM · efl

Jun 21 2018

vtorri triaged T7055: EINA: recent changes causing breakage and build failure on other architectures. as High priority.
Jun 21 2018, 11:44 PM · regression, efl (efl-1.21), Restricted Project
vtorri accepted D6348: eina_debug_bt: add ifdef for windows build.
Jun 21 2018, 2:42 PM · efl

Jun 20 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

hmm, arc diff fucked up this diff, i need help to restore the previous state...

Jun 20 2018, 1:47 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
  • Evil: fix usage of Evil in a program compiled with vc++
Jun 20 2018, 1:44 PM · efl

Jun 15 2018

vtorri added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.
./dbus-session.sh: ligne 7: -- : commande introuvable
kill : utilisation :kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... ou kill -l [sigspec]
FAIL tests/evil/evil_suite.exe (exit status: 127)
Jun 15 2018, 12:38 PM · efl
vtorri updated the diff for D6286: Tests: remove warnings when compiling tests if fork is not available.
Jun 15 2018, 4:28 AM · efl