Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (320 w, 1 d)
Availability
Available

Recent Activity

Today

vtorri requested review of D8647: ecore_sdl: fix detection of sdl with meson build.
Thu, Apr 18, 5:51 AM · efl
vtorri requested review of D8646: Windows: remove fnmatch and regex in Evil and use the ones in regex DLL installed by ewpi.
Thu, Apr 18, 5:50 AM · efl
vtorri added a comment to D8644: ecore_win32: use AddClipboardFormatListener and RemoveClipboardFormatListener explicitely instead of loading them from user32.dll.

because mingw-w64 is too old. The fix is done in the link I gave : https://sourceforge.net/p/mingw-w64/mailman/message/34033485/

Thu, Apr 18, 3:20 AM · efl
vtorri added a comment to D8644: ecore_win32: use AddClipboardFormatListener and RemoveClipboardFormatListener explicitely instead of loading them from user32.dll.

no because gcc (for windows) adds it by default, otherwise you will have a bunch of functions which are not defined.

Thu, Apr 18, 2:44 AM · efl
vtorri added a comment to D8571: Windows: remove fnmatch in Evil and use the one in regex DLL installed by ewpi.

so if you don't care i'll abandon this revision and i'll do both fnmatch and regex removal, i'm fed up this takes so long

Thu, Apr 18, 1:33 AM · efl
vtorri added a comment to D8571: Windows: remove fnmatch in Evil and use the one in regex DLL installed by ewpi.

it's not my fault if you use an old mingw-w64 which does not have AddClipboardFormatListener (). this function is there since vista (cf https://docs.microsoft.com/sr-latn-rs/windows/desktop/api/winuser/nf-winuser-addclipboardformatlistener ) and has been in minw-w64 for 4 years (see https://sourceforge.net/p/mingw-w64/mailman/message/34033485/ ). It works perfectly on my computer with win7. So what is broken is not D8644, it's your CI for windows.

Thu, Apr 18, 1:19 AM · efl
vtorri added a comment to D8571: Windows: remove fnmatch in Evil and use the one in regex DLL installed by ewpi.

it will break if there is a CI for windows...

Thu, Apr 18, 1:02 AM · efl

Yesterday

vtorri added a comment to D8571: Windows: remove fnmatch in Evil and use the one in regex DLL installed by ewpi.

ok, you prefer another approach

Wed, Apr 17, 8:30 PM · efl
vtorri requested review of D8644: ecore_win32: use AddClipboardFormatListener and RemoveClipboardFormatListener explicitely instead of loading them from user32.dll.
Wed, Apr 17, 2:27 PM · efl
vtorri requested review of D8643: ecore_win32: remove explicit define of WM_CLIPBOARDUPDATE.
Wed, Apr 17, 12:41 PM · efl
vtorri requested review of D8633: eina_vpath: port to Windows.
Wed, Apr 17, 6:33 AM · efl
vtorri requested review of D8632: efl-net.pc.in : honor datarootdir.
Wed, Apr 17, 6:23 AM · efl

Tue, Apr 16

vtorri requested review of D8621: evil: remove tmp and home dir get.
Tue, Apr 16, 9:57 AM · efl

Mon, Apr 15

vtorri triaged T7812: meson build system should manage c++ header files as TODO priority.
Mon, Apr 15, 1:37 PM · Restricted Project, efl: meson
vtorri accepted D8611: cxx: Fix eldbus meta include name.
Mon, Apr 15, 1:35 PM · efl
vtorri added a comment to D8611: cxx: Fix eldbus meta include name.

i don't see anything in eldbus/meson.build about c++ files

Mon, Apr 15, 1:30 PM · efl
vtorri added a comment to D8611: cxx: Fix eldbus meta include name.

otherwise, installation has finished without problem

Mon, Apr 15, 1:18 PM · efl
vtorri added a comment to D8611: cxx: Fix eldbus meta include name.

what about meson ?

Mon, Apr 15, 1:00 PM · efl
vtorri updated subscribers of T7805: error when installing c++ header.
Mon, Apr 15, 10:59 AM · Restricted Project

Sun, Apr 14

vtorri added a comment to T7805: error when installing c++ header.

the fix should be backported to 1.22

Sun, Apr 14, 9:00 AM · Restricted Project

Sat, Apr 13

vtorri added a comment to T7805: error when installing c++ header.

$ git grep eldbus_eolian_cxx_hh
src/Makefile_Cxx.am:nodist_installed_eldbuscxxmainheaders_DATA = $(eldbus_eolian_cxx_hh) $(eldbus_eolian_cxx_impl_hh) lib/eldbus/Eldbus_Model.eo.hh

Sat, Apr 13, 9:57 PM · Restricted Project
vtorri triaged T7805: error when installing c++ header as High priority.
Sat, Apr 13, 10:52 AM · Restricted Project

Fri, Apr 12

vtorri edited the content of Windows.
Fri, Apr 12, 11:59 PM · efl
vtorri updated the summary of D8602: Windows : fix the definition of EAPI.
Fri, Apr 12, 9:26 PM · efl
vtorri updated the summary of D8602: Windows : fix the definition of EAPI.
Fri, Apr 12, 9:25 PM · efl
vtorri requested review of D8602: Windows : fix the definition of EAPI.
Fri, Apr 12, 9:22 PM · efl
vtorri closed T7798: Elementary does not use EFL_BUILD as Resolved.

fixed with D8598

Fri, Apr 12, 9:18 PM · Restricted Project
vtorri closed T7798: Elementary does not use EFL_BUILD, a subtask of T7797: problem with EAPI on Windows (again), as Resolved.
Fri, Apr 12, 9:18 PM · efl: api

Thu, Apr 11

vtorri updated the diff for D8598: elementary: rename ELEMENTARY_BUILD to EFL_BUILD like all other libs.
  • remove unwanted comment
Thu, Apr 11, 7:32 AM · efl
vtorri requested review of D8598: elementary: rename ELEMENTARY_BUILD to EFL_BUILD like all other libs.
Thu, Apr 11, 7:30 AM · efl

Wed, Apr 10

vtorri added a subtask for T7797: problem with EAPI on Windows (again): T7798: Elementary does not use EFL_BUILD.
Wed, Apr 10, 9:38 PM · efl: api
vtorri added a parent task for T7798: Elementary does not use EFL_BUILD: T7797: problem with EAPI on Windows (again).
Wed, Apr 10, 9:38 PM · Restricted Project
vtorri created T7798: Elementary does not use EFL_BUILD.
Wed, Apr 10, 9:38 PM · Restricted Project
vtorri added a parent task for T7797: problem with EAPI on Windows (again): T7780: remove autotools.
Wed, Apr 10, 9:34 PM · efl: api
vtorri added a subtask for T7780: remove autotools: T7797: problem with EAPI on Windows (again).
Wed, Apr 10, 9:34 PM · Restricted Project, efl: meson
vtorri created T7797: problem with EAPI on Windows (again).
Wed, Apr 10, 9:34 PM · efl: api
vtorri added a comment to D8546: fix message typo.

it's normal : D8543 must be applied first

Wed, Apr 10, 4:58 AM · efl
vtorri assigned T7786: Support ecore_win32 to bu5hm4n.
Wed, Apr 10, 4:52 AM · Restricted Project, efl: meson
vtorri assigned T7795: Add Windows evas engines (GDI and DirectDraw) to bu5hm4n.
Wed, Apr 10, 4:52 AM · Restricted Project, efl: meson
vtorri triaged T7795: Add Windows evas engines (GDI and DirectDraw) as TODO priority.
Wed, Apr 10, 4:50 AM · Restricted Project, efl: meson

Tue, Apr 9

vtorri abandoned D8581: unit tests: fix warnings when fork() is not available, fix evil's unit tests compilation.

see D8586

Tue, Apr 9, 6:43 AM · Restricted Project
vtorri abandoned D8584: fix scope of pid.

see D8586

Tue, Apr 9, 6:42 AM · efl
Herald added a reviewer for D8586: unit tests: fix warnings when fork() is not available, fix evil's unit tests compilation: devilhorns.
Tue, Apr 9, 6:41 AM · Restricted Project
vtorri requested review of D8586: unit tests: fix warnings when fork() is not available, fix evil's unit tests compilation.
Tue, Apr 9, 6:41 AM · Restricted Project
vtorri added inline comments to D8581: unit tests: fix warnings when fork() is not available, fix evil's unit tests compilation.
Tue, Apr 9, 6:10 AM · Restricted Project
vtorri requested review of D8584: fix scope of pid.
Tue, Apr 9, 6:10 AM · efl
vtorri retitled D8583: eldbus unit test: fix warnings from eldus unit test: fix warnings to eldbus unit test: fix warnings.
Tue, Apr 9, 1:44 AM · Restricted Project

Mon, Apr 8

Herald added a reviewer for D8583: eldbus unit test: fix warnings: devilhorns.
Mon, Apr 8, 9:34 PM · Restricted Project
vtorri requested review of D8583: eldbus unit test: fix warnings.
Mon, Apr 8, 9:33 PM · Restricted Project
Herald added a reviewer for D8581: unit tests: fix warnings when fork() is not available, fix evil's unit tests compilation: devilhorns.
Mon, Apr 8, 9:16 PM · Restricted Project
vtorri requested review of D8581: unit tests: fix warnings when fork() is not available, fix evil's unit tests compilation.
Mon, Apr 8, 9:14 PM · Restricted Project
vtorri added a comment to D8571: Windows: remove fnmatch in Evil and use the one in regex DLL installed by ewpi.

that's my way of doing things : i add symbols only when needed.
if it is the way t go (adding a lib in eina so that all the libs/bins have that lib), then why not adding all the libs to eina and none to the other libs ?
there are several meson.build where some libs are explicitely added.

Mon, Apr 8, 12:40 PM · efl

Sun, Apr 7

vtorri edited the content of Windows.
Sun, Apr 7, 9:36 PM · efl

Sat, Apr 6

vtorri added a reviewer for D8571: Windows: remove fnmatch in Evil and use the one in regex DLL installed by ewpi: bu5hm4n.
Sat, Apr 6, 8:44 PM · efl
vtorri requested review of D8571: Windows: remove fnmatch in Evil and use the one in regex DLL installed by ewpi.
Sat, Apr 6, 8:40 PM · efl

Thu, Apr 4

vtorri requested review of D8558: dist rule: add files to EXTRA_DIST2 inconditionally.
Thu, Apr 4, 6:29 AM · efl
vtorri added a comment to D8553: eina: move builtin detection to eina_config.h.

S you consider that, if byteswap.h exists, then the functions bswap_** exist ?

Thu, Apr 4, 2:41 AM · efl

Wed, Apr 3

vtorri added a comment to D8545: add builtin lround() check if it is not in libm.

maybe actually this diff should be abandoned and i should remove the test in configure.ac about __builtin_lround ?

Wed, Apr 3, 8:44 PM · efl
vtorri accepted D8549: autotools: add another entry test file to dist.
Wed, Apr 3, 12:52 PM · efl
vtorri requested changes to D8548: eina: redo the swap checking.

the autotools should also be updated (to verify the concordance of config.h), as well as eina_config.h.in, which then has useless macro

Wed, Apr 3, 11:23 AM · efl
vtorri added a comment to D8545: add builtin lround() check if it is not in libm.

actually, __builtin_lround() is not used at all in the code ,afaics

Wed, Apr 3, 6:15 AM · efl
vtorri added a comment to D8543: eina: check bswap* in byteswap.h only if it exists, otherwise check if gcc builtin bswap* exists.

can you be a bit more explicit, please ? i fear i don't understand what you want me to do

Wed, Apr 3, 5:20 AM · efl
vtorri added a comment to D8545: add builtin lround() check if it is not in libm.

git grep HAVE_LROUND :

Wed, Apr 3, 5:16 AM · efl

Tue, Apr 2

vtorri requested review of D8546: fix message typo.
Tue, Apr 2, 10:43 PM · efl
vtorri requested review of D8545: add builtin lround() check if it is not in libm.
Tue, Apr 2, 10:41 PM · efl
vtorri requested review of D8543: eina: check bswap* in byteswap.h only if it exists, otherwise check if gcc builtin bswap* exists.
Tue, Apr 2, 8:46 PM · efl
vtorri requested review of D8535: remove useless check of ws2tcpip.h.
Tue, Apr 2, 6:53 AM · efl
vtorri triaged T7776: compilation error on Windows : elm_naviframe_item_push() is redeclared differently as Showstopper Issues priority.
Tue, Apr 2, 3:46 AM · Restricted Project
vtorri requested review of D8533: elm: allow config_embed to be run out of tree.
Tue, Apr 2, 3:39 AM · efl
vtorri requested review of D8532: configure.ac : remove definition of HAVE_ECORE_AUDIO_WASAPI as it is never used.
Tue, Apr 2, 2:17 AM · efl

Mon, Apr 1

vtorri edited the content of Windows.
Mon, Apr 1, 2:00 PM · efl

Fri, Mar 29

vtorri added a comment to D8497: Speedup finding new line, prevent readind invalid memory.

can't strncmp(pTemp, "br", 2) be replaced with 2 tests (same for "ps") ?

Fri, Mar 29, 7:46 AM · efl

Thu, Mar 28

vtorri requested review of D8493: remove the definition of HAVE_WASAPI as it is never used.
Thu, Mar 28, 2:11 AM · efl

Wed, Mar 27

vtorri added a comment to D3965: evas/engine: changed the default ector engine to native engine. To change the engine to cairo use ECTOR_BACKEND=cairo.

and we should open a task to mention we must have a test suite

Wed, Mar 27, 10:44 PM · efl
vtorri added a comment to D3965: evas/engine: changed the default ector engine to native engine. To change the engine to cairo use ECTOR_BACKEND=cairo.

imho, if cairo backend has bugs that the native one has not, and if it is not maintained anymore, it should just be dropped

Wed, Mar 27, 10:42 PM · efl

Tue, Mar 26

vtorri added a comment to T7763: Windows : meson build fails with undef ref.

btw, meson configure returns :

Tue, Mar 26, 3:10 PM · Restricted Project
vtorri requested review of D8482: eina benchmark: fix warnings on Windows 64 bits.
Tue, Mar 26, 2:58 PM · efl
vtorri added a comment to T7763: Windows : meson build fails with undef ref.

why is that option not necessary on linux ?

Tue, Mar 26, 2:46 PM · Restricted Project
vtorri created T7768: src/lib/ecore/meson.build checks if gstreamer is available.
Tue, Mar 26, 6:31 AM · Restricted Project
vtorri accepted D8480: build: fix meson vnc-server option text.
Tue, Mar 26, 6:19 AM · Restricted Project
vtorri accepted D8479: build: fix meson pixman dependency name.
Tue, Mar 26, 6:13 AM · Restricted Project

Sun, Mar 24

vtorri requested review of D8460: meson build : remove duplicate check of dirent.h.
Sun, Mar 24, 11:42 AM · efl

Sat, Mar 23

vtorri requested review of D8454: evil : remove mkstemp, which is already defined in mingw-w64.
Sat, Mar 23, 12:32 PM · efl
vtorri requested review of D8453: meson build : remove duplicate check of strerror_r.
Sat, Mar 23, 12:27 PM · efl

Fri, Mar 22

vtorri closed T7750: Windows build with meson : define __USE_MINGW_ANSI_STDIO for all the projects to have a posix *printf functions as Resolved.
Fri, Mar 22, 1:47 PM · Restricted Project
vtorri added a comment to T7750: Windows build with meson : define __USE_MINGW_ANSI_STDIO for all the projects to have a posix *printf functions.

Fixed in D8432

Fri, Mar 22, 1:47 PM · Restricted Project
vtorri requested review of D8444: evil: fix wrong values in timeval.
Fri, Mar 22, 1:41 AM · efl

Wed, Mar 20

vtorri requested review of D8432: Windows, meson build : use posix *printf family function.
Wed, Mar 20, 1:11 PM · efl
vtorri edited the content of Windows.
Wed, Mar 20, 8:17 AM · efl

Tue, Mar 19

vtorri edited the content of Windows.
Tue, Mar 19, 11:30 PM · efl
vtorri added a comment to T7763: Windows : meson build fails with undef ref.

btw, meson command :

Tue, Mar 19, 11:30 PM · Restricted Project
vtorri triaged T7763: Windows : meson build fails with undef ref as Showstopper Issues priority.
Tue, Mar 19, 11:28 PM · Restricted Project
vtorri created T7762: warning in meson output : 'break' keyword.
Tue, Mar 19, 11:12 PM · Restricted Project

Mar 17 2019

vtorri updated subscribers of T7749: windows build with meson : define HAVE_DLADDR.
Mar 17 2019, 12:53 PM · Restricted Project
vtorri added a project to T7749: windows build with meson : define HAVE_DLADDR: Restricted Project.
Mar 17 2019, 12:53 PM · Restricted Project
vtorri triaged T7750: Windows build with meson : define __USE_MINGW_ANSI_STDIO for all the projects to have a posix *printf functions as Normal priority.
Mar 17 2019, 12:27 PM · Restricted Project
vtorri triaged T7749: windows build with meson : define HAVE_DLADDR as Normal priority.
Mar 17 2019, 11:47 AM · Restricted Project
vtorri added a comment to T7746: Windows build with meson : allow cross compilation when we compile on Windows.

What is problematic is that I want to compile the EFL with ewpi. and I don't know the computer on which a user can compile the EFL.

Mar 17 2019, 11:06 AM · Restricted Project
vtorri added a comment to T7746: Windows build with meson : allow cross compilation when we compile on Windows.

As I have said, using MSYS2 + mingw-w64 IS cross compilation : I have a windows 7 64 bits where I build the EFL for 32 bits. Then having cpu and cpu_family is important. I agree that endianness and system are not important.

Mar 17 2019, 5:43 AM · Restricted Project
vtorri added a comment to T7746: Windows build with meson : allow cross compilation when we compile on Windows.

you don't tell me how to set the properties for host_machine : system, cpu, cpu_family endiannes

Mar 17 2019, 5:15 AM · Restricted Project