Page MenuHomePhabricator

vtorri (Vincent Torri)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2013, 12:20 AM (396 w, 1 d)
Availability
Available

Recent Activity

Mon, Sep 28

vtorri added a comment to T8832: Windows: photocam crashes in elm_test.

more precisely, it's the file selector which is crashing (and crashed my Windows...)

Mon, Sep 28, 3:25 PM · efl
vtorri added a comment to D12166: Windows: fix copy'n paste.

@netstar even lines 1244 to 1246 of the patch ? (nullification of fields of edata->clipboard)

Mon, Sep 28, 2:34 AM · efl

Sun, Sep 27

vtorri added a comment to T8828: Windows: cnp does not work anymore.

see D12166

Sun, Sep 27, 10:24 AM · efl
vtorri added reviewers for D12166: Windows: fix copy'n paste: cochisecesar, bu5hm4n.
Sun, Sep 27, 10:23 AM · efl
vtorri requested review of D12166: Windows: fix copy'n paste.
Sun, Sep 27, 10:22 AM · efl

Fri, Sep 25

vtorri added a comment to T8831: Windows: multiple monitors seems to be broken.

see P339 for a back trace

Fri, Sep 25, 11:43 PM · efl
vtorri added a parent task for T8833: Windows: States test fails: T8825: Windows bugs to fix.
Fri, Sep 25, 11:29 PM · efl
vtorri added a subtask for T8825: Windows bugs to fix: T8833: Windows: States test fails.
Fri, Sep 25, 11:29 PM · efl
vtorri created T8833: Windows: States test fails.
Fri, Sep 25, 11:28 PM · efl
vtorri added a parent task for T8832: Windows: photocam crashes in elm_test: T8825: Windows bugs to fix.
Fri, Sep 25, 11:27 PM · efl
vtorri added a subtask for T8825: Windows bugs to fix: T8832: Windows: photocam crashes in elm_test.
Fri, Sep 25, 11:27 PM · efl
vtorri created T8832: Windows: photocam crashes in elm_test.
Fri, Sep 25, 11:27 PM · efl
vtorri added a parent task for T8831: Windows: multiple monitors seems to be broken: T8825: Windows bugs to fix.
Fri, Sep 25, 11:25 PM · efl
vtorri added a subtask for T8825: Windows bugs to fix: T8831: Windows: multiple monitors seems to be broken.
Fri, Sep 25, 11:25 PM · efl
vtorri created T8831: Windows: multiple monitors seems to be broken.
Fri, Sep 25, 11:25 PM · efl
Herald added a project to T8830: Windows: multiple monitors seems to be broken: Restricted Project.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

needs review

Fri, Sep 25, 11:24 PM · Restricted Project, efl
vtorri added a parent task for T8830: Windows: multiple monitors seems to be broken: T8825: Windows bugs to fix.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Fri, Sep 25, 11:23 PM · Restricted Project, efl
vtorri added a subtask for T8825: Windows bugs to fix: T8830: Windows: multiple monitors seems to be broken.
Fri, Sep 25, 11:23 PM · efl
Herald closed T8830: Windows: multiple monitors seems to be broken as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Fri, Sep 25, 11:22 PM · Restricted Project, efl
vtorri added a parent task for T8829: Windows: eio file monitoring tests fail: T8825: Windows bugs to fix.
Fri, Sep 25, 11:20 PM · efl
vtorri added a subtask for T8825: Windows bugs to fix: T8829: Windows: eio file monitoring tests fail.
Fri, Sep 25, 11:20 PM · efl
vtorri created T8829: Windows: eio file monitoring tests fail.
Fri, Sep 25, 11:20 PM · efl
vtorri renamed T8827: Windows: elementary_config does not save configuration from elementary_config does not save configuration to Windows: elementary_config does not save configuration.
Fri, Sep 25, 10:56 PM · efl
vtorri added a parent task for T8828: Windows: cnp does not work anymore: T8825: Windows bugs to fix.
Fri, Sep 25, 10:56 PM · efl
vtorri added a subtask for T8825: Windows bugs to fix: T8828: Windows: cnp does not work anymore.
Fri, Sep 25, 10:56 PM · efl
vtorri created T8828: Windows: cnp does not work anymore.
Fri, Sep 25, 10:56 PM · efl
vtorri added a subtask for T8825: Windows bugs to fix: T8827: Windows: elementary_config does not save configuration.
Fri, Sep 25, 10:52 PM · efl
vtorri added a parent task for T8827: Windows: elementary_config does not save configuration: T8825: Windows bugs to fix.
Fri, Sep 25, 10:52 PM · efl
vtorri added a comment to T8827: Windows: elementary_config does not save configuration.

see D12165

Fri, Sep 25, 10:52 PM · efl
vtorri created T8827: Windows: elementary_config does not save configuration.
Fri, Sep 25, 10:50 PM · efl
vtorri added a subtask for T8825: Windows bugs to fix: T8826: Ecore audio does not work on Windows.
Fri, Sep 25, 10:46 PM · efl
vtorri added a parent task for T8826: Ecore audio does not work on Windows: T8825: Windows bugs to fix.
Fri, Sep 25, 10:46 PM · efl
vtorri created T8826: Ecore audio does not work on Windows.
Fri, Sep 25, 10:46 PM · efl
vtorri created T8825: Windows bugs to fix.
Fri, Sep 25, 10:44 PM · efl
vtorri requested review of D12165: Ecore_file: on Windows, fix errno value when dst exists..
Fri, Sep 25, 12:48 AM · efl

Thu, Sep 24

vtorri added a comment to D12135: Added the heif loader.

i think i'll be able to test your patch this week-end

Thu, Sep 24, 7:18 AM · efl

Wed, Sep 23

vtorri updated the summary of D12162: fix order and simplify a bit order of _init|_shutdown functions.
Wed, Sep 23, 11:25 AM · efl
vtorri requested review of D12162: fix order and simplify a bit order of _init|_shutdown functions.
Wed, Sep 23, 11:20 AM · efl
vtorri requested review of D12161: Ethumb: reorder _init/shutdown functions, ecore and evas init/shutdown are useless, as ecore_evas already manages them.
Wed, Sep 23, 3:50 AM · efl
vtorri requested review of D12160: edje_external_inspector: re-order _init a bit: log after eina, remove ecore_init/shutdown as it is already managed by edje_init/shutdown.
Wed, Sep 23, 3:32 AM · efl

Sun, Sep 20

vtorri requested review of D12155: elm_config: don't prepend /tmp/ to file name, eina_file_mkstemp() already takes care of this.
Sun, Sep 20, 11:22 PM · efl
vtorri added a comment to D12153: edje_external_inspector: fix order dans of _init() and _shutdown() functions.

does it hurt to apply this patch ? It's now clean and show others how it has to be done

Sun, Sep 20, 6:04 AM · efl
vtorri requested review of D12154: Ethumb: fix order of _init() and _shutdown() functions.
Sun, Sep 20, 6:02 AM · efl
vtorri requested review of D12153: edje_external_inspector: fix order dans of _init() and _shutdown() functions.
Sun, Sep 20, 3:58 AM · efl

Fri, Sep 18

vtorri added inline comments to D12151: efreet: make efreet optional.
Fri, Sep 18, 1:43 PM · efl

Thu, Sep 17

vtorri added a reviewer for D12149: elm_config: remove useless init|shutdown of ecore_win32 and eocore_cocoa (done in ecore_evas module), and useless wayland variable: raster.
Thu, Sep 17, 10:34 AM · efl
vtorri requested review of D12149: elm_config: remove useless init|shutdown of ecore_win32 and eocore_cocoa (done in ecore_evas module), and useless wayland variable.
Thu, Sep 17, 9:27 AM · efl

Wed, Sep 16

vtorri resigned from D12147: evas_main: Fix memory leak..
Wed, Sep 16, 10:12 PM · efl
vtorri requested changes to D12147: evas_main: Fix memory leak..
Wed, Sep 16, 10:11 PM · efl

Tue, Sep 15

vtorri added inline comments to D10290: efl_app and efl_exe: support get and set priority of a process on Windows.
Tue, Sep 15, 6:53 AM · efl

Mon, Sep 14

vtorri added a comment to D12135: Added the heif loader.

why was checkme deleted ?

Mon, Sep 14, 9:31 AM · efl

Tue, Sep 8

vtorri added a comment to D12135: Added the heif loader.

do you plan to write a saver too ?

Tue, Sep 8, 9:46 AM · efl
vtorri added inline comments to D12135: Added the heif loader.
Tue, Sep 8, 9:39 AM · efl

Mon, Sep 7

vtorri renamed T8805: ephoto does not use ELM_MAIN from okra does not use ELM_MAIN to ephoto does not use ELM_MAIN.
Mon, Sep 7, 11:01 PM · Restricted Project
vtorri created T8805: ephoto does not use ELM_MAIN.
Mon, Sep 7, 11:00 PM · Restricted Project

Wed, Sep 2

vtorri retitled D12125: eina file test: check rmdir result. Fix CID 1432267 from eina file test: check rmdir result. Fix CID 1432267 1432268 and 1432269 to eina file test: check rmdir result. Fix CID 1432267.
Wed, Sep 2, 1:22 AM · efl
vtorri updated the diff for D12125: eina file test: check rmdir result. Fix CID 1432267.

remove the 2 first changes

Wed, Sep 2, 1:21 AM · efl

Sep 1 2020

vtorri abandoned D12113: add mkv to elm_icon and elm_thumb.

already in git

Sep 1 2020, 4:56 AM · efl
vtorri added a comment to D11743: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2).

just for your information, 4.3 is out (topic mentions 4.2)

Sep 1 2020, 4:04 AM · efl
vtorri updated the diff for D12125: eina file test: check rmdir result. Fix CID 1432267.

test_dirname, not dirname

Sep 1 2020, 4:01 AM · efl
vtorri requested review of D12125: eina file test: check rmdir result. Fix CID 1432267.
Sep 1 2020, 2:35 AM · efl
vtorri abandoned D12124: update libunibreak to 4.3.
Sep 1 2020, 1:41 AM · efl
vtorri requested review of D12124: update libunibreak to 4.3.
Sep 1 2020, 12:40 AM · efl

Aug 31 2020

vtorri requested review of D12123: eeze_mount binary: more secure check extension ('.iso' and not 'iso').
Aug 31 2020, 6:55 AM · efl
vtorri requested review of D12122: ecore_file_can_exec: fix .bat case.
Aug 31 2020, 6:46 AM · efl
vtorri abandoned D12080: fix warning in elm test slider (maybe uninitialized).

already in master

Aug 31 2020, 5:19 AM · efl
vtorri updated the summary of D12118: ecore-file: fix ecore_file_can_exec() on Windows.
Aug 31 2020, 5:08 AM · efl
vtorri updated the diff for D12118: ecore-file: fix ecore_file_can_exec() on Windows.

add comments decribing the parsing of a PE file

Aug 31 2020, 4:55 AM · efl

Aug 30 2020

vtorri added a comment to D12121: elm_theme: more secure check extension as '.edj' and not 'edj'.

there is also

Aug 30 2020, 1:24 PM · efl
vtorri requested review of D12121: elm_theme: more secure check extension as '.edj' and not 'edj'.
Aug 30 2020, 1:22 PM · efl
vtorri updated the diff for D12118: ecore-file: fix ecore_file_can_exec() on Windows.

add .bat files support

Aug 30 2020, 5:40 AM · efl

Aug 27 2020

vtorri updated the diff for D12118: ecore-file: fix ecore_file_can_exec() on Windows.

SHGetFileInfo() look at the file extension only. Parse file to see if it is an executable or not instead

Aug 27 2020, 10:51 PM · efl
vtorri added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

But test will need changes anyway, right?

Aug 27 2020, 6:54 AM · efl
vtorri added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

i renamed a .exe into a .isexe and SHGetFileInfo() fails, so it's really the extension which matters here

Aug 27 2020, 6:53 AM · efl
vtorri added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

another solution : consider only PE binaries and parse the file (i've alredy done that), and check if it's a binary or not

Aug 27 2020, 6:13 AM · efl
vtorri added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

also see https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfoa

the 'return value' section.

I test only if the result is 0 or not.

Ooooh right. So in that case, it would be necessary to split Hi and Lo bits and compare them separately?

Aug 27 2020, 6:02 AM · efl
vtorri added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

also see https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfoa

Aug 27 2020, 5:58 AM · efl
vtorri added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

strange because i've tested on a .bat explicitely. Here the problem is a .sh which is not supported outside a unix shell

Aug 27 2020, 5:56 AM · efl
vtorri requested review of D12118: ecore-file: fix ecore_file_can_exec() on Windows.
Aug 27 2020, 12:13 AM · efl

Aug 26 2020

vtorri updated the diff for D12111: Evil: add gettimeofday().

define HAVE_GETTIMEOFDAY if not defined
some formatting in evil_dlfcn.h too

Aug 26 2020, 11:44 AM · efl

Aug 25 2020

vtorri added a parent revision for D12111: Evil: add gettimeofday(): D12112: Ecore: more precise implementation of ecore_time_get on Windows.
Aug 25 2020, 7:00 AM · efl
vtorri added a child revision for D12112: Ecore: more precise implementation of ecore_time_get on Windows: D12111: Evil: add gettimeofday().
Aug 25 2020, 7:00 AM · efl

Aug 24 2020

vtorri added a comment to D12111: Evil: add gettimeofday().

yes please

Aug 24 2020, 2:15 PM · efl
vtorri added a comment to D12111: Evil: add gettimeofday().

see D12112

Aug 24 2020, 12:18 PM · efl
vtorri accepted D12115: eina: Replace remove with rmdir and delete tmpstr.

looks good to me

Aug 24 2020, 10:00 AM · efl

Aug 22 2020

vtorri requested review of D12113: add mkv to elm_icon and elm_thumb.
Aug 22 2020, 8:16 AM · efl

Aug 21 2020

vtorri requested review of D12112: Ecore: more precise implementation of ecore_time_get on Windows.
Aug 21 2020, 10:56 PM · efl
vtorri requested review of D12111: Evil: add gettimeofday().
Aug 21 2020, 10:54 PM · efl

Aug 19 2020

vtorri added a comment to D12062: eina: Close file in unlink test.

@stefan_schmidt it's ok for me

Aug 19 2020, 10:08 PM · efl

Aug 17 2020

vtorri added a comment to D12103: eet: Fix 'No OPENSSL_Applink' error message..

emile has also openssl code. Can you look at it too please ?

Aug 17 2020, 10:50 PM · efl
vtorri added inline comments to D12108: eet test: use eina_file_mkstemp, fix include for vc++.
Aug 17 2020, 10:05 PM · efl
vtorri updated the diff for D12108: eet test: use eina_file_mkstemp, fix include for vc++.

add close() to comment

Aug 17 2020, 10:04 PM · efl
vtorri requested review of D12108: eet test: use eina_file_mkstemp, fix include for vc++.
Aug 17 2020, 2:18 PM · efl

Aug 14 2020

vtorri added inline comments to D12105: eolian_gen: Add support to response files..
Aug 14 2020, 8:20 AM · efl
vtorri added a reviewer for D12107: ecore_exe_posix: add timeout exception to avoid deadlock.: alarcher.

and for solaris (openindiana + illumos) ? i've added @alarcher as reviewer

Aug 14 2020, 7:39 AM · efl

Aug 13 2020

vtorri added a comment to D12107: ecore_exe_posix: add timeout exception to avoid deadlock..

maybe use readdir_r()

Aug 13 2020, 12:22 PM · efl

Aug 12 2020

vtorri accepted D12106: eina: Use INVALID_FILE_ATTRIBUTES instead of magic number.
Aug 12 2020, 7:35 AM · efl

Aug 11 2020

vtorri added inline comments to D12105: eolian_gen: Add support to response files..
Aug 11 2020, 1:51 PM · efl

Aug 6 2020

vtorri accepted D12095: evil: Remove OS version check.
Aug 6 2020, 12:59 PM · efl

Aug 5 2020

vtorri abandoned D8545: add builtin lround() check if it is not in libm.
Aug 5 2020, 6:18 AM · efl