Page MenuHomePhabricator

walac (Wander Lairson Costa)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 8 2020, 6:04 AM (32 w, 3 d)
Availability
Available

Recent Activity

Nov 9 2020

walac updated the diff for D12037: Implement eina_thread for native windows.

Code rebase

Nov 9 2020, 5:53 AM · efl
walac updated the diff for D12037: Implement eina_thread for native windows.

Address comments and rebase the code

Nov 9 2020, 5:52 AM · efl

Nov 6 2020

walac added a comment to D12037: Implement eina_thread for native windows.

As long as expedite test pass and everyone comments has been addressed, I think this is good to go. The thread API is not used by EFL in the hot path, so that part is not the important bit. Maintenance and fitting into the host OS is more important.

I don't think that even if you run expedite 20 times with your CPU power saving disable you would anything.

Nov 6 2020, 9:23 AM · efl
walac added a comment to D12037: Implement eina_thread for native windows.

have you tested with expedite and the fractal code ?

iirc, I couldn't compile the fracal app. The expedite I had to hijack some files to compile. I remember I didn't find any significant difference. Anyway, I have to rebase the code and will test it again.

Nov 6 2020, 8:31 AM · efl
walac added a revision to T8852: [mingw] expedite-cmp fails to compare files generate by expedite.exe: D12186: Skip ill formed lines.
Nov 6 2020, 7:47 AM · expedite
walac requested review of D12186: Skip ill formed lines.
Nov 6 2020, 7:47 AM
walac updated the task description for T8852: [mingw] expedite-cmp fails to compare files generate by expedite.exe.
Nov 6 2020, 5:51 AM · expedite
walac created T8852: [mingw] expedite-cmp fails to compare files generate by expedite.exe.
Nov 6 2020, 5:51 AM · expedite

Nov 5 2020

walac added a comment to D12037: Implement eina_thread for native windows.

have you tested with expedite and the fractal code ?

Nov 5 2020, 10:08 AM · efl

Nov 4 2020

walac updated the diff for D12043: eo_test_general.c: Make eo_signals tests pass on Windows.

Fix typos in the comments

Nov 4 2020, 9:53 AM · efl

Nov 3 2020

walac added inline comments to D12167: Eina value: fix test on Windows.
Nov 3 2020, 4:28 AM · efl

Jul 7 2020

walac updated the diff for D12037: Implement eina_thread for native windows.

Fix minor compatibility corner cases with the posix counterpart.

Jul 7 2020, 11:12 AM · efl

Jul 6 2020

walac requested review of D12043: eo_test_general.c: Make eo_signals tests pass on Windows.
Jul 6 2020, 1:17 PM · efl

Jul 3 2020

walac closed D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.
Jul 3 2020, 9:18 AM · efl
walac updated subscribers of D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.

Patch does not apply ...

Jul 3 2020, 7:07 AM · efl
walac updated the diff for D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.

Fix patch to apply to HEAD

Jul 3 2020, 7:06 AM · efl

Jul 2 2020

walac requested review of D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.
Jul 2 2020, 2:39 PM · efl

Jun 30 2020

walac updated the diff for D12037: Implement eina_thread for native windows.

Add tests and fix bugs

Jun 30 2020, 11:39 AM · efl
walac added inline comments to D12037: Implement eina_thread for native windows.
Jun 30 2020, 6:49 AM · efl
walac updated the diff for D12037: Implement eina_thread for native windows.

Address raster's review comments

Jun 30 2020, 6:45 AM · efl

Jun 29 2020

walac updated the diff for D12037: Implement eina_thread for native windows.

Fix undefined behavior in eina_thread_self

Jun 29 2020, 1:17 PM · efl
walac updated the diff for D12037: Implement eina_thread for native windows.

Use native windows threads in mingw

Jun 29 2020, 12:53 PM · efl
walac added inline comments to D12037: Implement eina_thread for native windows.
Jun 29 2020, 10:08 AM · efl
walac added inline comments to D12037: Implement eina_thread for native windows.
Jun 29 2020, 10:04 AM · efl
walac requested review of D12037: Implement eina_thread for native windows.
Jun 29 2020, 7:50 AM · efl

Jun 26 2020

walac abandoned D12024: windows: Fix file mapping.
Jun 26 2020, 7:31 AM · efl
walac accepted D12031: Windows: fix eina_file_map_new().
Jun 26 2020, 6:32 AM · efl
walac accepted D12033: Native Windows: Eina: Resolve bad comparison while using windows strerror_s.
Jun 26 2020, 6:20 AM · efl

Jun 25 2020

walac added inline comments to D12031: Windows: fix eina_file_map_new().
Jun 25 2020, 6:57 AM · efl

Jun 24 2020

walac updated the diff for D12021: Fix eina file thread test on Windows.

Address review comments

Jun 24 2020, 6:32 AM · efl
walac added inline comments to D12021: Fix eina file thread test on Windows.
Jun 24 2020, 6:16 AM · efl
walac updated the diff for D12024: windows: Fix file mapping.

Fix struct layout compatibility

Jun 24 2020, 6:07 AM · efl

Jun 23 2020

walac requested review of D12024: windows: Fix file mapping.
Jun 23 2020, 1:23 PM · efl
walac requested review of D12023: eina_test_lock.c: Implement clock_gettime for Windows.
Jun 23 2020, 1:20 PM · efl
walac added a comment to D12022: windows: Fix path for file sanitization.

i've looked at https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths and i indeed see it can begin with \ (but not /) :

"A file name is relative to the current directory if it does not begin with one of the following etc... "
"A single backslash, for example, "\directory" or "\file.txt". This is also referred to as an absolute path."

i don't know if you should also consider /

Jun 23 2020, 9:42 AM · efl
walac requested review of D12022: windows: Fix path for file sanitization.
Jun 23 2020, 8:21 AM · efl
walac updated the diff for D12021: Fix eina file thread test on Windows.

Update the patch based on reviewer feedback

Jun 23 2020, 8:16 AM · efl
walac updated the diff for D12021: Fix eina file thread test on Windows.

Fix typo

Jun 23 2020, 7:41 AM · efl
walac added inline comments to D12021: Fix eina file thread test on Windows.
Jun 23 2020, 7:37 AM · efl
walac updated the diff for D12021: Fix eina file thread test on Windows.

Fix patch update

Jun 23 2020, 7:36 AM · efl
walac updated the diff for D12021: Fix eina file thread test on Windows.

Fix negative path length calculation

Jun 23 2020, 7:35 AM · efl
walac requested review of D12021: Fix eina file thread test on Windows.
Jun 23 2020, 6:55 AM · efl

Jun 22 2020

walac added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

@walac your prefer this patch which modifies 143 files, ONLY for eina, to my patch, which modifies 5 files for 4 libraries, with the same result ?? that's crazy

Jun 22 2020, 7:26 AM · efl

Jun 19 2020

walac added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

do you realize that, with this kind of changes, you are going to change almost all the files of the EFL ?

Jun 19 2020, 7:39 AM · efl
walac accepted D11993: eina: Change EAPI to EINA_API in Eina Library.

That patch seems a step towards in the right direction IMHO. Things get tricky when EFL try to use each other since, in some places, EAPI must be __declspec(dllimport) and in others __declspec(dllexport), which leads walking on thin ice by playing around with the preprocessor. I understand that each library should define its XXX_API macro. The static library support is a win, but not the main point of the patch.

Jun 19 2020, 5:31 AM · efl

Jun 17 2020

walac accepted D11983: Fix ENOMEM message on Windows and solaris.
Jun 17 2020, 5:07 AM · efl

Jun 15 2020

walac added a comment to D11970: efl_check.h: Replace stack allocated array by heap allocated.

Gettign of a tons of errors with this patch and cxx bindings enabled. One example (there are more):

[219/398] Compiling C++ object 'src/tests/eina_cxx/6b3491e@@eina_cxx_suite@exe/eina_cxx_suite.cc.o'
In file included from ../src/tests/eina_cxx/eina_cxx_suite.h:8,
                 from ../src/tests/eina_cxx/eina_cxx_suite.cc:20:
../src/tests/eina_cxx/../efl_check.h: In function ‘int _efl_test_option_disp(int, char**, const Efl_Test_Case*)’:
../src/tests/eina_cxx/../efl_check.h:137:23: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings]
  137 |              nav[0] = "valgrind";
      |                       ^~~~~~~~~~
../src/tests/eina_cxx/../efl_check.h:138:23: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings]
  138 |              nav[1] = "--trace-children=yes";
Jun 15 2020, 5:30 AM · efl
walac updated the diff for D11970: efl_check.h: Replace stack allocated array by heap allocated.

Make C++ compiler happy

Jun 15 2020, 5:27 AM · efl

Jun 12 2020

walac added a comment to D11970: efl_check.h: Replace stack allocated array by heap allocated.

@vtorri done

Jun 12 2020, 1:54 PM · efl
walac updated the diff for D11970: efl_check.h: Replace stack allocated array by heap allocated.

Replace malloc by alloca

Jun 12 2020, 1:53 PM · efl
walac added inline comments to D11971: eina_test_file.c: Do not test errno if the function doesn't fail.
Jun 12 2020, 1:29 PM · efl
walac updated the diff for D11971: eina_test_file.c: Do not test errno if the function doesn't fail.

Remove all references to errno in eina_test_file.c

Jun 12 2020, 1:27 PM · efl
walac requested review of D11971: eina_test_file.c: Do not test errno if the function doesn't fail.
Jun 12 2020, 11:51 AM · efl
walac requested review of D11970: efl_check.h: Replace stack allocated array by heap allocated.
Jun 12 2020, 11:40 AM · efl