Page MenuHomePhabricator

woohyun (WooHyun Jung)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 4:22 AM (304 w, 1 d)
Availability
Available

Recent Activity

Fri, Dec 7

woohyun updated subscribers of T5979: C++ bindings should use the same directives as C for protected functions (#define).

Could you check this task ? I also agree with JackDaniel.

Fri, Dec 7, 12:37 AM · efl: language bindings, Restricted Project

Thu, Dec 6

woohyun added a comment to T7394: C#: Fix class registration when running with dotnet core.

Could you share the progress of this work ?

Thu, Dec 6, 6:29 PM · efl: language bindings
woohyun added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

Do we have a way something like ...

Thu, Dec 6, 6:12 PM · Restricted Project
woohyun added a comment to T7248: C# Bindings automated TC.

I think customizing for Tizen could be discussed privately.
Except that, what are left for this task ?

Thu, Dec 6, 6:06 PM · efl: language bindings

Thu, Nov 22

woohyun added a comment to T7470: [MVVM] Create a ViewModel helper class.
Thu, Nov 22, 8:53 PM

Fri, Nov 16

woohyun added a comment to T7358: EO: Support ecore_event APIs.

@cedric welcome back :)
@Jaehyun_Cho

Fri, Nov 16, 5:25 PM · efl, Restricted Project

Oct 28 2018

woohyun added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I also agree with @lauromoura that we don't need to wait for the works of @lauromoura.
Eo class inheritance refactoring should be done independently with his C# binding works.

Oct 28 2018, 6:41 PM · efl: language bindings, Restricted Project

Oct 19 2018

woohyun added a comment to T7399: eolian: Add @ctor_param hint to constructors section.

I agree with the opinion of @bu5hm4n if the way that can make you happy can not be realized soon.
If you have some idea about how to fix (or improve) the bad construrctor system, could you share your idea here ?

Oct 19 2018, 12:15 AM · efl: language bindings

Oct 16 2018

woohyun closed D7168: evas_events: Fix wrong condtion..
Oct 16 2018, 10:27 PM · efl
woohyun closed D7167: ecore_wl2: Fix a memory leaking case.
Oct 16 2018, 6:20 PM · efl

Oct 11 2018

woohyun closed D7156: efl_ui_win: Move force resize code on first draw.
Oct 11 2018, 4:28 AM · efl

Oct 5 2018

woohyun closed D7146: elm_genlist: prevent null pointer access.
Oct 5 2018, 1:15 AM · efl
woohyun accepted D7146: elm_genlist: prevent null pointer access.
Oct 5 2018, 1:15 AM · efl
woohyun requested changes to D7146: elm_genlist: prevent null pointer access.

Please check inline comment ~

Oct 5 2018, 12:25 AM · efl

Oct 4 2018

woohyun closed D7137: eina debug: fix a double unlock issue.
Oct 4 2018, 2:57 AM · efl
woohyun closed D7140: elementary entry: apply scale to all edje objects.
Oct 4 2018, 2:54 AM · efl

Oct 2 2018

woohyun added a comment to T7248: C# Bindings automated TC.

Could you explain how to check the results for automated test cases In devs/felipealmeida/tct ?

Oct 2 2018, 12:55 AM · efl: language bindings

Sep 18 2018

woohyun added a comment to T7248: C# Bindings automated TC.

@felipealmeida
We only need to include the methods which are "implemented" by the specific class.
That is, we don't need to include the method "not implemented".

Sep 18 2018, 7:09 PM · efl: language bindings

Sep 10 2018

woohyun added a comment to T7241: Removing underline('_') in class name in C# bindings.

@felipealmeida
Could you take care of the case of "efl.ui.Button should be changed to Efl.Ui.Button" together ?
Plus, will you update this to the master branch directly ?
Or, if you are managing another branch for this work, please share the branch name.

Sep 10 2018, 12:28 AM · efl: language bindings

May 8 2018

woohyun closed D6133: efl_ui_widget: use efl_data_scope_safe_get instead of macro.
May 8 2018, 6:20 PM · efl
woohyun accepted D6133: efl_ui_widget: use efl_data_scope_safe_get instead of macro.
May 8 2018, 6:20 PM · efl

May 2 2018

woohyun added a comment to D4986: elm: efl_ui_list partial implementation.

Please give a feedback whether to keep this patch or not.
I think we already have another way to communicate for this subject.

May 2 2018, 6:25 PM · efl
woohyun added a comment to D5726: efl_ui_popup: add efl_ui_bg interface to backwall part.

Could you give a feedback on this ?

May 2 2018, 6:22 PM · efl
woohyun abandoned D5593: efl/frame.edc: create new group for efl_ui_frame.
May 2 2018, 6:12 PM · efl
woohyun updated subscribers of D5593: efl/frame.edc: create new group for efl_ui_frame.

This was a prototyping of new theme for efl_ui_xxx. And I can abandon this because it's already applied by @singh.amitesh.

May 2 2018, 6:12 PM · efl
woohyun added a comment to D5666: Efl.Ui.Popup.Anchor.List: add initial code.

Could you give a dicision whether to keep this patch or not ?

May 2 2018, 6:05 PM · efl
woohyun added a comment to D5430: efl_ui_pager: add a new class.

@eunue
Could you abandon this patch ?

May 2 2018, 6:03 PM · Restricted Project, efl

Apr 23 2018

woohyun accepted D5979: elementary bg: allow NULL pointers in legacy usage.
Apr 23 2018, 5:05 AM

Apr 12 2018

woohyun added a comment to D5932: Revert Efl.Ui.Multibuttonentry to create new one..

I hope this patch would be updated together with new patch which introduces new MBE class.

Apr 12 2018, 9:58 PM

Apr 11 2018

woohyun added a comment to D5908: efl_ui_slider: refactor slider widget..

@cedric
Oh. ok :) Then, everything is good.

Apr 11 2018, 1:06 AM · efl

Apr 10 2018

woohyun added a comment to D5908: efl_ui_slider: refactor slider widget..

This work includes simplify efl_ui_slider (it includes too much feature inside as a default slider class).
Could you explain why this thing should not be applied on master ?

Apr 10 2018, 9:48 PM · efl
woohyun updated subscribers of D5861: efl_ui_list : introduce new list widget for simple usage.

I've added some inline comments.

Apr 10 2018, 7:34 PM

Apr 8 2018

woohyun added a comment to D5832: Add a new class efl_ui_pager and more.

I don't know whether B is doable.
To support with B concept, we need to give description what types(or classes) are available for transition_set(or indicator_set).

Apr 8 2018, 10:10 PM
woohyun added a comment to T5358: Refactoring multi button entry.

@cedric
Ok. I got it.

Apr 8 2018, 8:58 PM · efl: widgets, Restricted Project
woohyun added a comment to T5358: Refactoring multi button entry.

I'm also confused with the concept you talked.
If we want to make "value" as a property for efl_ui_mbe, it should have specific data type.

Apr 8 2018, 7:26 PM · efl: widgets, Restricted Project
woohyun added a comment to T6540: New Date and Time classes and their APIs.

@cedric
Thank you for your feedback :)

Apr 8 2018, 7:08 PM
woohyun updated subscribers of D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop.

@cedric
I think internal things could be arranged later.
After closing this task, @eagle001 needs to apply new efl_ui_scrollable to efl_ui_xxx classes.
(not for elm_xxx class which would be covered by elm_interface_scrollable. I don't think replacing elm_interface_scrollable to efl_ui_scrollable is urgent)

Apr 8 2018, 7:05 PM · efl

Mar 29 2018

woohyun added a comment to T5358: Refactoring multi button entry.

Ok. Let's try to merge [1] and [3]....

Mar 29 2018, 10:03 PM · efl: widgets, Restricted Project
woohyun added a comment to T5358: Refactoring multi button entry.

I think you have summarized every option quite well. I do just have a question about [2] and why you think that this is impossible to decide what kind of item UI should be created when entry input happened. I would have expected that the UI item would be choosen depending on the input and some global state.

You mean that an application needs to choose specific item UI for each entry input. Am I right ?
I don't think application developers may want to do this by themselves.
This should be the one of major features of MBE.

Also I am thinking of another variant that I can see like :
MBE class + MBE item class (child of button class) instantiation on input parsed event.

The idea would be that when you press enter an event is fired with the inputed text as part of the event information. From there the user can decide to filter it out, or create any object that would be of MBE item class. The MBE would get back the text by doing text_get on the MBE item that get packed in. Allowing for changing the text easily if scenario require it.

With this idea, we can support the concept of "MBE class + MBE_ITEM(Item UI)".
But, as I talked before, I am sure no application may want to add an item everytime entry input is happened.
Plus, if this work would be done by application side, MBE is only a set of buttons. Nothing else.

Mar 29 2018, 9:22 PM · efl: widgets, Restricted Project
woohyun added a comment to T5358: Refactoring multi button entry.

@cedric
I think we need to think about the pros anc cons for each suggestion.

Mar 29 2018, 4:06 AM · efl: widgets, Restricted Project

Mar 28 2018

woohyun added a comment to T6540: New Date and Time classes and their APIs.

As @CHAN talked, we want to develope time and date widget classes for EFL and Application developers togehter.

Mar 28 2018, 9:52 PM

Mar 27 2018

woohyun updated subscribers of T5358: Refactoring multi button entry.
Mar 27 2018, 10:00 PM · efl: widgets, Restricted Project
woohyun added a comment to T5317: Add a tab/pageview widget.

@cedric
Ok. I will ask @bowonryu to modifiy his patch based on the idea of [2].

Mar 27 2018, 12:57 AM · efl: widgets, Restricted Project

Mar 26 2018

woohyun added a comment to T5317: Add a tab/pageview widget.

I think that efl_part(page, "indicator") is enough with text_set, icon_set, and content_set.
That is, we don't need to think about text2_set or icon2_set.

Mar 26 2018, 5:15 AM · efl: widgets, Restricted Project
woohyun added a comment to T5317: Add a tab/pageview widget.
Mar 26 2018, 3:31 AM · efl: widgets, Restricted Project
woohyun added a comment to T5351: New Naviframe API.

@Jaehyun_Cho
If each Navigation_Bar needs different Navigation_Frame, then I think #2 is better.
If every Navigation_Bar needs only one Navigation_Frame with title area, then #1 looks better.

Mar 26 2018, 1:56 AM · efl (efl-1.21), efl: widgets, Restricted Project
woohyun added a comment to D5430: efl_ui_pager: add a new class.

@cedric
I think @eunue is handling this work in https://phab.enlightenment.org/D5832.
So we can abandon this contribution.

Mar 26 2018, 1:13 AM · Restricted Project, efl

Mar 13 2018

woohyun added a comment to T5358: Refactoring multi button entry.

I agree we should focus on making it a simple MBE (meaning not handling MVVM nor vast amount of content). Now, I have been wondering if we could not use the pack interface to add new item and have a specific expected item type that would be the only type accepted inside the MBE. This is kind of with item, except that the item will be real object and that they will be build outside of the MBE (This would give more freedom for customisation).

I need to be look at current MBE, but I think that MBE does create some object itself automatically, no ? If so, we have to either add an event that would expect a call to add an item to the MBE be done there or we register a factory type of object that would automatically do the conversion. I know that you guys are not at ease with factory design pattern, so if the event is good enough, we can start with that and add factory support later as they are orthogonal and won't impact the API.

Mar 13 2018, 11:30 PM · efl: widgets, Restricted Project
woohyun added a comment to T5317: Add a tab/pageview widget.

Hmm. I want to get the spec of Efl.Ui.Tab.Indicator.
Based on your basic idea of this, does the class include UI or not ?
If it includes UI, then what is the difference between the new class and old elm_toolbar ?

Mar 13 2018, 11:17 PM · efl: widgets, Restricted Project
woohyun updated subscribers of T5317: Add a tab/pageview widget.
Mar 13 2018, 7:13 PM · efl: widgets, Restricted Project
woohyun added a comment to T5358: Refactoring multi button entry.
Mar 13 2018, 7:08 PM · efl: widgets, Restricted Project
woohyun added a comment to T5317: Add a tab/pageview widget.

@cedric
If my understanding is correct developers don't need to know about the existence of Efl.Ui.Tab.Indicator and Efl.Ui.Tab.Pager,
because developers will do (in C#) ....

Mar 13 2018, 5:23 PM · efl: widgets, Restricted Project
woohyun added a comment to T5358: Refactoring multi button entry.

@CHAN
I think below are correct. Please check whether I'm wrong.

efl_ui_multibuttonentry_item_append(mbe, 1, "test"); -> efl_ui_multibuttonentry_item_append(obj, text);
efl_ui_multibuttonetnry_item_text_set(mbe, 1, "change"); -> efl_ui_multibuttonetnry_item_text_set(obj, text, index);

IMHO, efl_ui_multibuttonetnry_item_text_set(mbe, 1, "change"); is better.
i.e. efl_ui_multibuttonetnry_item_text_set(obj, index, text) because the object index means like obj[i].text = "ABCD";
So I think keeping the order is better.

Mar 13 2018, 4:31 PM · efl: widgets, Restricted Project
woohyun added a comment to T5358: Refactoring multi button entry.

@CHAN
I think below are correct. Please check whether I'm wrong.

Mar 13 2018, 2:18 AM · efl: widgets, Restricted Project

Mar 12 2018

woohyun added a comment to T5317: Add a tab/pageview widget.

Dear. @cedric
I would give some information for better understanding.
Efl.Ui.Pager (@eunue is creating) supports Efl.Pack interface to insert contents in it.
So, the above Efl.Ui.Tab_Pager should support this interface together.

Mar 12 2018, 10:58 PM · efl: widgets, Restricted Project

Mar 8 2018

woohyun updated subscribers of T5317: Add a tab/pageview widget.

Could you update your Efl.Ui.TabPager Class definition here to get the review from @cedric and @eunue together :)

Mar 8 2018, 10:59 PM · efl: widgets, Restricted Project
woohyun added a comment to D5541: efl_ui_toolbar: create new efl_ui_toolbar.

We will create new tab pager so, removing this commit looks ok for me.

Mar 8 2018, 10:55 PM

Mar 6 2018

woohyun added a comment to D5832: Add a new class efl_ui_pager and more.

I added some inline comments. Please check them.

Mar 6 2018, 11:46 PM

Feb 20 2018

woohyun added a comment to D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop.

@cedric
I need to handle this problem by myself because @eagleeye is in education for a month.
Could you decribe what are the error prone codes ?

Feb 20 2018, 8:55 PM · efl

Feb 13 2018

woohyun closed D5793: elementary: modify return value of scroller_movement_block_get.
Feb 13 2018, 5:42 PM

Feb 12 2018

woohyun closed D5801: evas_polygon: Fix segfault while creating the object.
Feb 12 2018, 8:16 PM

Jan 18 2018

woohyun updated subscribers of T6441: Refactor Elm interfaces to Efl.Ui.

@jpeg
We had not discussed about this, but I don't think it is needed now.
Then, could I close this task after @eagleeye finishes https://phab.enlightenment.org/T5319 ?

Jan 18 2018, 1:50 AM · Restricted Project, efl: widgets, Restricted Project

Jan 16 2018

woohyun added a comment to T5351: New Naviframe API.
  1. Stacker, Frame_Stacker or Frame_Stack ? If this will only allow to insert Frame object, then Frame_Stack looks good.
  2. I also agree to promote it to the top.
  3. What is "title_bar" ? Text area for title ? or ... background area of title text ?
  4. I think many applications may want to pull their own Layout object. If we will only allow frame object, then , at least, we need to make a empty frame class for them.
Jan 16 2018, 11:10 PM · efl (efl-1.21), efl: widgets, Restricted Project

Jan 15 2018

woohyun added a comment to T5326: Refactor ctxpopup, popup and notify.

Could we close this task ? Or, are there something remained to do ?

Jan 15 2018, 1:04 AM · efl: widgets, Restricted Project

Jan 14 2018

woohyun added a comment to T5320: Create Gesture Framework in Elementary.

@smohanty
Would you share the plan for this task ?

Jan 14 2018, 11:16 PM · efl: widgets, Restricted Project
woohyun updated subscribers of T6182: Focus: custom_chain / explicit order setting.
Jan 14 2018, 11:06 PM · Restricted Project
woohyun added a comment to T6182: Focus: custom_chain / explicit order setting.

@bu5hm4n
I want to get the idea about how to support legacy focus custom chain.
Do you have any plan for that ?

Jan 14 2018, 11:05 PM · Restricted Project
woohyun added a comment to T5351: New Naviframe API.

@Jaehyun_Cho
Would you share the class specification on this task ?

Jan 14 2018, 9:53 PM · efl (efl-1.21), efl: widgets, Restricted Project

Dec 11 2017

woohyun added a comment to T5353: EO: Calendar widget for EO API.

@jpeg
There is nothing left for this. Later, we need to do something more, then I'll create new task :)

Dec 11 2017, 1:07 AM · Restricted Project, efl

Dec 4 2017

woohyun created D5593: efl/frame.edc: create new group for efl_ui_frame.
Dec 4 2017, 11:02 PM · efl

Nov 30 2017

woohyun added reviewers for D5578: efl_ui_calendar: apply new theme policy: jpeg, taxi2se.
Nov 30 2017, 9:05 PM
woohyun created D5578: efl_ui_calendar: apply new theme policy.
Nov 30 2017, 9:04 PM

Nov 26 2017

woohyun updated the diff for D5541: efl_ui_toolbar: create new efl_ui_toolbar.

Modify some wrong words in header file

Nov 26 2017, 8:11 PM
woohyun created D5541: efl_ui_toolbar: create new efl_ui_toolbar.
Nov 26 2017, 6:34 PM

Nov 20 2017

woohyun added a comment to T6296: Supporting text interface to control text properties and size calculation rule..

@herdsman ping :) Could you update your idea on this task ?

Nov 20 2017, 1:47 AM · efl

Nov 13 2017

woohyun added a comment to T5353: EO: Calendar widget for EO API.

@jpeg
"Today" cannot be changed. That is the role of god :P joke.

Nov 13 2017, 5:12 PM · Restricted Project, efl
woohyun added a comment to T5353: EO: Calendar widget for EO API.

@jpeg Sure, you can see it elementary_test -> "Efl Ui Calendar".

Nov 13 2017, 3:09 AM · Restricted Project, efl

Nov 5 2017

woohyun added a comment to D5151: efl_ui_layout: create efl_ui_bg when efl_part for background is called..

bg_add is still ambiguous for me. Except that I don't have any objection about your codes :)

Nov 5 2017, 5:24 PM

Oct 26 2017

woohyun added a comment to T5327: Refactor toolbar.

@cedric
I want to know the progress of this work - with simple factory thing together.

Oct 26 2017, 12:38 AM · efl: widgets, Restricted Project

Oct 25 2017

woohyun added a comment to T5353: EO: Calendar widget for EO API.

I made the first version of new calendar.
And I will do some more works to close this task.

Oct 25 2017, 6:12 PM · Restricted Project, efl
woohyun closed D5346: efl_ui_calendar: create new efl_ui_calendar.
Oct 25 2017, 12:55 AM
woohyun updated the diff for D5346: efl_ui_calendar: create new efl_ui_calendar.
  • fix make file to include some headers
Oct 25 2017, 12:36 AM

Oct 24 2017

woohyun updated the diff for D5346: efl_ui_calendar: create new efl_ui_calendar.
  • add validating with mktime for each date setting
  • fix some docs
  • rebasing
Oct 24 2017, 11:20 PM
woohyun added inline comments to D5346: efl_ui_calendar: create new efl_ui_calendar.
Oct 24 2017, 7:37 PM
woohyun updated the diff for D5346: efl_ui_calendar: create new efl_ui_calendar.

fixed some docs

Oct 24 2017, 3:30 AM
woohyun updated the diff for D5346: efl_ui_calendar: create new efl_ui_calendar.
  • change group_add/group_del to constructor/destructor
  • add return value for date_min, date_max, and date
  • fix wrong date setting when the value is less than min or greater than max
Oct 24 2017, 1:46 AM
woohyun added inline comments to D5346: efl_ui_calendar: create new efl_ui_calendar.
Oct 24 2017, 1:46 AM

Oct 23 2017

woohyun added inline comments to D5346: efl_ui_calendar: create new efl_ui_calendar.
Oct 23 2017, 1:25 AM
woohyun updated the diff for D5346: efl_ui_calendar: create new efl_ui_calendar.

Modificaion on jpeg's comment.

Oct 23 2017, 1:24 AM

Oct 22 2017

woohyun added reviewers for D5346: efl_ui_calendar: create new efl_ui_calendar: jpeg, singh.amitesh, cedric, CHAN, Jaehyun_Cho.
Oct 22 2017, 7:33 PM
woohyun created D5346: efl_ui_calendar: create new efl_ui_calendar.
Oct 22 2017, 7:31 PM

Oct 13 2017

woohyun added a comment to D5222: scroll_manager: new scoller scratch.

Please check my inline comments :)

Oct 13 2017, 7:01 PM

Sep 19 2017

woohyun added a comment to T5940: "elm_object_focus_next_object_set" is not working any more.

I think we need to think about the best way - how to keep the backward compatibility well.

Sep 19 2017, 7:47 PM · efl (efl-1.21), Restricted Project

Aug 31 2017

woohyun added a comment to T5923: Focus Next/Prev is not working properly.

Right !! I just found one problem not fixed for [Case 1].
Sorry for making you confused by re-openning this task.

Aug 31 2017, 4:11 AM · efl
woohyun reopened T5923: Focus Next/Prev is not working properly as "Open".
Aug 31 2017, 4:04 AM · efl
woohyun closed T5923: Focus Next/Prev is not working properly as Resolved.
Aug 31 2017, 4:01 AM · efl
woohyun added a comment to T5923: Focus Next/Prev is not working properly.
Aug 31 2017, 4:01 AM · efl

Aug 30 2017

woohyun added a comment to T5923: Focus Next/Prev is not working properly.

For the [Case2], I also did some debugging, and want to share the result.

Aug 30 2017, 4:46 AM · efl
woohyun added a comment to T5923: Focus Next/Prev is not working properly.

For the [Case 1], I did some debugging on this.
And, I could not understand well about "_border_flush" (which is in efl_ui_focus_manager_sub.c file).

Aug 30 2017, 4:02 AM · efl
woohyun added a comment to T5940: "elm_object_focus_next_object_set" is not working any more.

Including this API, most of elm_object_focus_xxx APIs are woking not properly.
Do you have any plan to test all the elm_object_focus_xxx APIs to keep the backward compatibility ?

Aug 30 2017, 1:53 AM · efl (efl-1.21), Restricted Project