Page MenuHomePhabricator

woohyun (WooHyun Jung)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 4:22 AM (339 w, 5 d)
Availability
Available

Recent Activity

Today

woohyun added a comment to T7893: efl.ui.slider.

As @bu5hm4n talked before - there are lots of bad things in both efl_ui_slider and efl_ui_slider_interval.

Wed, Aug 21, 3:52 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun updated the diff for D9670: efl_ui_slider : remove all the legacy checking.

fix build warnings

Wed, Aug 21, 2:58 AM · efl
woohyun added reviewers for D9670: efl_ui_slider : remove all the legacy checking: Jaehyun_Cho, bu5hm4n, zmike.
Wed, Aug 21, 1:49 AM · efl
woohyun requested review of D9670: efl_ui_slider : remove all the legacy checking.
Wed, Aug 21, 1:46 AM · efl
woohyun added a revision to T7893: efl.ui.slider: D9670: efl_ui_slider : remove all the legacy checking.
Wed, Aug 21, 1:46 AM · efl: api, efl (efl-1.23), efl: language bindings

Yesterday

woohyun added a comment to D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
In D9628#178653, @tasn wrote:

I haven't looked at the actual code, but I do plan on making textblock2 work on grapheme clusters too, so this is inline with that change.
Though maybe I'd wait with this until TB2 is in, hopefully in a few weeks?

Tue, Aug 20, 7:07 PM · efl
woohyun added a comment to T8151: RFC: Text interfaces design proposal.

I also like the idea of @cedric to keep all the discussions here.
But, because we only have limited time for this work, I think it can be good to talk in chat for long discussion.
(And then, let's share the result here)

Tue, Aug 20, 6:47 PM · efl: api
woohyun added a comment to T7893: efl.ui.slider.

Ok. I'm moving to Action Item #3.
If anyone has another idea on the slider class (and it needs big change), please let me know asap :)

Tue, Aug 20, 5:59 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun updated the task description for T7893: efl.ui.slider.
Tue, Aug 20, 5:57 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T8151: RFC: Text interfaces design proposal.

Some questions while checking the description of this task.

Tue, Aug 20, 2:08 AM · efl: api
woohyun added a comment to T8151: RFC: Text interfaces design proposal.

@tasn
You are so fast ! You added reply just after I deleted my comment !! HAHA. (I needed more time to arrange my idea)
Anyway thanks for the reply.

Tue, Aug 20, 1:47 AM · efl: api
woohyun added a comment to T8151: RFC: Text interfaces design proposal.
Tue, Aug 20, 1:16 AM · efl: api

Mon, Aug 19

woohyun added a comment to D9623: elm_slider: remove dependency with efl_ui_slider.

Thank very much. I did update the codes to fix the things you indicated.
Let me know if there is anything wrong.

Mon, Aug 19, 6:11 PM · efl
woohyun updated the diff for D9623: elm_slider: remove dependency with efl_ui_slider.

update test suite for more events

Mon, Aug 19, 6:06 PM · efl
woohyun updated the diff for D9623: elm_slider: remove dependency with efl_ui_slider.

update codes to solve the failures in test suite

Mon, Aug 19, 5:56 PM · efl
woohyun added reviewers for D9623: elm_slider: remove dependency with efl_ui_slider: bu5hm4n, segfaultxavi, eagleeye.
Mon, Aug 19, 5:09 AM · efl
woohyun updated the diff for D9623: elm_slider: remove dependency with efl_ui_slider.

fix wrong indentation

Mon, Aug 19, 5:08 AM · efl
woohyun requested review of D9623: elm_slider: remove dependency with efl_ui_slider.
Mon, Aug 19, 5:05 AM · efl
woohyun added a revision to T7893: efl.ui.slider: D9623: elm_slider: remove dependency with efl_ui_slider.
Mon, Aug 19, 5:05 AM · efl: api, efl (efl-1.23), efl: language bindings

Fri, Aug 16

woohyun added a comment to T7893: efl.ui.slider.

I will try the work item #2, and try to estimate the things you are worrying about.

Fri, Aug 16, 11:36 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun updated the task description for T7893: efl.ui.slider.
Fri, Aug 16, 11:17 PM · efl: api, efl (efl-1.23), efl: language bindings

Thu, Aug 15

woohyun added a comment to T7852: efl.ui.selectable.

@bu5hm4n
Thanks for sharing the current status :)

Thu, Aug 15, 10:31 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T8097: efl_ui_spin_button.

You are not such a horrible person :)

Thu, Aug 15, 7:00 PM · efl: api, efl (efl-1.23), efl: language bindings

Wed, Aug 14

woohyun added a comment to T7852: efl.ui.selectable.

Is this ok for following dependencies - or Do we need to remove this interface perfectly ?

Wed, Aug 14, 4:52 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7592: efl.config.

Please look into this task with T7383.
I cannot trace the discussion results so far.

Wed, Aug 14, 4:47 AM · efl (efl-1.23), efl: api
woohyun added a comment to T7921: enum Efl.Ui.Scroll_Block.

@eagleeye
Do you think there can be any reason why this cannot be merged with T7924 ?
We may need to think about the future extension of each enum.

Wed, Aug 14, 4:38 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7922: enum Efl.Ui.Select_Mode.

@SanghyeonLee
Could you give a reply on question of @bu5hm4n ?

Wed, Aug 14, 4:28 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7946: enum Efl.Ui.Popup_Align.

Could you do the action item on the description ?
Plus, if you are thinking of another action item - please share it here.

Wed, Aug 14, 4:27 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7923: enum Efl.Ui.Scrollbar_Mode.

I think this looks ok - because legacy scroller has proved that this enum is needed with this definition.

Wed, Aug 14, 4:25 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7953: efl.ui.scroll_manager.

Let's make a list of work items here (and add them in the description comment)
I think below things need to be considered together as work items.

Wed, Aug 14, 4:15 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T8093: Name conflict between class and property.

Do you have other candidate names for Text classes ?
I also like the idea of WPF, but I hope to hear your ideas.

Wed, Aug 14, 3:58 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T8097: efl_ui_spin_button.

Hmm. I am still confused which one is better.
And, I could not find similar names in other platforms, so it is much difficult problem for me.
(Plus, I'm not that good person for naming !!)

Wed, Aug 14, 3:43 AM · efl: api, efl (efl-1.23), efl: language bindings

Tue, Aug 13

woohyun added a comment to T8097: efl_ui_spin_button.

Are you ok with "wraparound" and "text_editable" ?
Then, I'll add action items, and will do by my own soon.

Tue, Aug 13, 6:40 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T8100: widget style property.

If my memory is correct -
when we began these interface works, upstream developers discussed together about STYLE.

Tue, Aug 13, 5:48 PM · efl (efl-1.23), efl: api
woohyun added a comment to T7865: efl.ui.check.

Could we move this task to "Stabilized" ?

Tue, Aug 13, 4:04 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7893: efl.ui.slider.

So, could I add below two work items ?

Tue, Aug 13, 3:59 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7847: efl.input.clickable.

I hope so :) no more feedback ?

Tue, Aug 13, 3:51 AM · efl: api, efl (efl-1.23), efl: language bindings

Wed, Aug 7

woohyun closed D9519: evas_text: backward compatibility for setting text size.
Wed, Aug 7, 4:40 AM · efl
woohyun accepted D9519: evas_text: backward compatibility for setting text size.
Wed, Aug 7, 4:31 AM · efl

Mon, Aug 5

woohyun closed D9486: efl_ui_action_connector: rename clickable_util to action_connector.
Mon, Aug 5, 8:44 AM · efl

Sat, Aug 3

woohyun added a comment to T8097: efl_ui_spin_button.

I also like wraparound.

Sat, Aug 3, 6:02 PM · efl: api, efl (efl-1.23), efl: language bindings

Fri, Aug 2

woohyun added a comment to T7893: efl.ui.slider.

How would we do that? We make this release without user,changed events and add them afterwards? I'm OK with this but are these events required by any app right now?

Fri, Aug 2, 1:10 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7893: efl.ui.slider.

How about discussing "user,changed' later after the next release ?
When I asked about this, I just thought that it was a simple thing by adding it to efl_ui_slider only.
But, while discussion, I have felt like this one needed to be handled with more general consideration for whole widgets.
So, I think it would be better to discuss this after doing the basic interface works.

Fri, Aug 2, 12:48 AM · efl: api, efl (efl-1.23), efl: language bindings

Thu, Aug 1

woohyun added reviewers for D9486: efl_ui_action_connector: rename clickable_util to action_connector: bu5hm4n, segfaultxavi, zmike, Jaehyun_Cho.
Thu, Aug 1, 10:05 PM · efl
woohyun requested review of D9486: efl_ui_action_connector: rename clickable_util to action_connector.
Thu, Aug 1, 10:03 PM · efl
woohyun updated the task description for T7847: efl.input.clickable.
Thu, Aug 1, 6:23 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7868: efl.ui.clock.

I checked the first commit of this widget class.

Thu, Aug 1, 3:34 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a commit to T7847: efl.input.clickable: rEFLd02a3ecb663a: efl_input_clickable: add longpress_abort.
Thu, Aug 1, 2:33 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun closed D9455: efl_input_clickable: add longpress_abort.
Thu, Aug 1, 2:33 AM · efl
woohyun added a comment to D9455: efl_input_clickable: add longpress_abort.

I updated a test suite. Let me know if the test case has something wrong.

Thu, Aug 1, 2:22 AM · efl
woohyun updated the diff for D9455: efl_input_clickable: add longpress_abort.

update test suite

Thu, Aug 1, 2:19 AM · efl
woohyun added a comment to D9455: efl_input_clickable: add longpress_abort.

Looks good, thank you :)
But can you add a event to efl_test_clickable.c in the spec test suite ? :)

Thu, Aug 1, 1:04 AM · efl

Wed, Jul 31

woohyun added a comment to T7897: efl.ui.spin.

+1 :)

Wed, Jul 31, 6:42 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to D9455: efl_input_clickable: add longpress_abort.

This commit depends on D9454.

Wed, Jul 31, 4:30 AM · efl
woohyun added reviewers for D9455: efl_input_clickable: add longpress_abort: bu5hm4n, segfaultxavi, zmike, Jaehyun_Cho.
Wed, Jul 31, 4:26 AM · efl
woohyun added reviewers for D9454: efl_ui_clickable_util: remove efl_input_processed_set: bu5hm4n, Jaehyun_Cho.
Wed, Jul 31, 4:25 AM · efl
woohyun requested review of D9455: efl_input_clickable: add longpress_abort.
Wed, Jul 31, 4:24 AM · efl
woohyun added a child revision for D9454: efl_ui_clickable_util: remove efl_input_processed_set: D9455: efl_input_clickable: add longpress_abort.
Wed, Jul 31, 4:24 AM · efl
woohyun added a revision to T7847: efl.input.clickable: D9455: efl_input_clickable: add longpress_abort.
Wed, Jul 31, 4:24 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun updated the diff for D9454: efl_ui_clickable_util: remove efl_input_processed_set.

revert back wrong modification

Wed, Jul 31, 4:02 AM · efl
woohyun requested review of D9454: efl_ui_clickable_util: remove efl_input_processed_set.
Wed, Jul 31, 4:00 AM · efl

Mon, Jul 29

woohyun updated the task description for T7847: efl.input.clickable.
Mon, Jul 29, 5:59 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7897: efl.ui.spin.

If there can be a usage with this, then, I have no objection.
Is there anything left to be discussed for this class ?

Mon, Jul 29, 2:31 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7897: efl.ui.spin.

After removing event implementation (for mouse-wheel event),
it would be better to keep this class as abstract one.
(It just implements some interfaces relating range things)

Mon, Jul 29, 1:34 AM · efl: api, efl (efl-1.23), efl: language bindings

Sun, Jul 28

woohyun added a comment to T7900: efl.pack_table.

I think your research of other platforms could be very useful for this discussion :)
Can you share the results of research ?

Sun, Jul 28, 6:59 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added reviewers for D9427: efl_input_clickable: rename efl_ui_clickable to efl_input_clickable: zmike, bu5hm4n, segfaultxavi.
Sun, Jul 28, 3:53 PM · efl
woohyun added a comment to T7847: efl.input.clickable.

I made a patch for work item #1. (D9427)
After this patch, I'll make two patches additionally for #2 and #3 at the same time.

Sun, Jul 28, 3:49 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun requested review of D9427: efl_input_clickable: rename efl_ui_clickable to efl_input_clickable.
Sun, Jul 28, 3:46 PM · efl
woohyun added a revision to T7847: efl.input.clickable: D9427: efl_input_clickable: rename efl_ui_clickable to efl_input_clickable.
Sun, Jul 28, 3:46 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a revision to T7976: Efl.Input.Clickable_Clicked: D9427: efl_input_clickable: rename efl_ui_clickable to efl_input_clickable.
Sun, Jul 28, 3:46 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun updated the task description for T7847: efl.input.clickable.
Sun, Jul 28, 3:20 PM · efl: api, efl (efl-1.23), efl: language bindings

Fri, Jul 26

woohyun added a comment to T7847: efl.input.clickable.

Right.
So, my question was that it could be confused to the developers who are familiar with "clicked" (used as clicked,primary in the other platforms) .
Because they will use "Clicked" event without any doubt.

Fri, Jul 26, 3:46 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7847: efl.input.clickable.

Oh, I was confused a bit.

Fri, Jul 26, 3:29 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7847: efl.input.clickable.

While doing the work items, I have two questions.

Fri, Jul 26, 2:13 AM · efl: api, efl (efl-1.23), efl: language bindings

Thu, Jul 25

woohyun added a comment to T8039: C#: Code lacks License headers.

I hope this work can be done till the end of July.

Thu, Jul 25, 7:09 PM · Restricted Project, efl: language bindings
woohyun updated the task description for T7847: efl.input.clickable.
Thu, Jul 25, 1:46 AM · efl: api, efl (efl-1.23), efl: language bindings

Wed, Jul 24

woohyun added a comment to T7847: efl.input.clickable.

I have been talking about STATIC class with @felipealmeida, and will create another task to talk about this deeply.

Wed, Jul 24, 9:15 PM · efl: api, efl (efl-1.23), efl: language bindings

Jul 19 2019

woohyun added a comment to T7893: efl.ui.slider.

I'm curious, why do you want to distinguish between changed and user_changed? What is the use case?

Jul 19 2019, 2:21 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7893: efl.ui.slider.

Thanks for your explanation.
So, can we summarize the work items like -

Jul 19 2019, 1:00 AM · efl: api, efl (efl-1.23), efl: language bindings

Jul 18 2019

woohyun updated subscribers of T8051: Indicators on the scrollbar do not work.

Let's check this together ~

Jul 18 2019, 1:18 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun updated subscribers of T7893: efl.ui.slider.

Just as a quick heads up of that widget:

@eagleeye and I also want to check the things together ~ :)

Jul 18 2019, 1:07 AM · efl: api, efl (efl-1.23), efl: language bindings

Jul 17 2019

woohyun added a comment to T7847: efl.input.clickable.

I agree with that idea - and I hope it could be generated as STATIC class in other bindings (such as C#).

Jul 17 2019, 3:41 AM · efl: api, efl (efl-1.23), efl: language bindings

Jul 16 2019

woohyun added a comment to T7847: efl.input.clickable.

For #2, we can choose one of below candidates.

Jul 16 2019, 5:40 AM · efl: api, efl (efl-1.23), efl: language bindings

Jul 15 2019

woohyun added a comment to T7847: efl.input.clickable.

Before beginning to modify codes, I have some questions.

Jul 15 2019, 6:44 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun updated the task description for T7847: efl.input.clickable.
Jul 15 2019, 6:31 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun updated the task description for T7847: efl.input.clickable.
Jul 15 2019, 1:43 AM · efl: api, efl (efl-1.23), efl: language bindings

Jul 14 2019

woohyun added a comment to T8045: How to handle longpress in efl_ui_text.

I don't like this way in the aspect of maintenance. (Plus, I'm not sure this works for all cases with user test cases)
This is because efl_ui_text never know when the longpress callback is called and aborted.
If there would be a change on "when the longpress callback is called", your logic needs to be modified.
That is, "sd->long_pressed" can be set to EINA_TRUE almost randomly in efl_ui_text.

So, I think that "supporting a way to abort longpress timer" would be better if we will decide to use efl.ui.clickable in efl.ui.text.

How do you think about this ?

Names are confusing.

Do you mean cancel Long-Press Event or Timer created inside efl_text_ui?
because created timer (old timer) never initialized so removing it make sense.

This is because efl_ui_text never know when the longpress callback is called and aborted.
inside the constructor efl_event_callback_add(obj, EFL_UI_EVENT_LONGPRESSED, _long_press_cb, obj); so it know when callback is called.

If there would be a change on "when the longpress callback is called", your logic needs to be modified.
That is, "sd->long_pressed" can be set to EINA_TRUE almost randomly in efl_ui_text.

The Issue here that for desktop environment, even if long press is called, it will wait until mouse-up happened after long press.
If this behavior is changed it will be very simple to fix.

So, I think that "supporting a way to abort longpress timer" would be better if we will decide to use efl.ui.clickable in efl.ui.text.
I think right now we can cancel the event, or at least unregister/register longpress event.

**How do you think about this ?**

Maybe I do not understand exactly what is main problem, but if you mean ability to cancel event. I think it is good feature.

Jul 14 2019, 7:33 PM
woohyun added a comment to T8045: How to handle longpress in efl_ui_text.

@woohyun After sleeping one night over it, I think we should add something like "abort_longpress()" to "Efl.Ui.Clickable". Other usecases:

  • Rect selection in something like item_container. When the rect selection starts, longpress should be aborted.
  • Drag and Drop: when a drag starts, we should abort the longpress. [...]

    So i like the idea of "abort_longpress" :)
Jul 14 2019, 7:21 PM

Jul 13 2019

woohyun added a comment to T7865: efl.ui.check.

I also agree that "selected" is weird, but I'm sorry to not give good new name.

Jul 13 2019, 1:54 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7895: efl.ui.range_display.

We might want to check, if setting limits to the same value (min=max) results in the implementor beeing disabled?

@bu5hm4n

Jul 13 2019, 1:35 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T8045: How to handle longpress in efl_ui_text.
Jul 13 2019, 1:12 AM
woohyun added a comment to T8045: How to handle longpress in efl_ui_text.

After reading the code of efl_ui_text:

  • One case cancels the longpress in case that a mouse move to some other element happend, i think that is equal to what @Jaehyun_Cho implemented recently. Entry how ever does that a little more "high quality" and check for the finger size of elm, we can also implement that if this is generally needed

I will talk with @Jaehyun_Cho and try to verify whether "entry's longpress logic" can be applied to other widgets together.

  • The other case is in case that there is a selection in progress the longpress timer is stopped, which is IMO a perfect case of where this does make sense. So i would totally agree on adding such a API to the mixin.

I focused on the "definition of Efl.Ui.Clickable class", and felt little bit ambiguous that there would be a method for "longpress" for clickable feature.
Just my opinion :)

Jul 13 2019, 12:55 AM

Jul 11 2019

woohyun added a comment to T7858: efl.text_markup.

What kind of markup do we actually use? Is this documented anywhere?

@segfaultxavi
I think that tags (=formats) which can be used with EFL markup text are listed up in evas_textblock_legacy.h.
(I'm not sure whether this is something you want to know)

Maybe we can add a markup_type property which is an enum to support multiple types?
Although that means we need to keep the original markup around in case the property is changed later and we need to re-interpret the markup string.
Probably a better approach is a set_markup method with a type parameter besides the actual markup text, instead of a plain markup property.
If the type parameter has a default value then we do not add any complexity for the user (for languages supporting default parameters).

I'm wonderting what you mean with "markup_type". I don't know whether there can be multiple types for this feature.
What I only know is that there are only utf8 and markup which need to be covered by efl.canvas.text.
(Please let me know if I'm wrong)

Jul 11 2019, 9:29 PM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to D9274: efl_ui_text: avoid infinite loop when long pressing.

@woohyun Can you create a task so we can discuss that further ?

Jul 11 2019, 5:47 PM · efl
woohyun created T8045: How to handle longpress in efl_ui_text.
Jul 11 2019, 5:46 PM
woohyun added a comment to T7970: Efl.Input.Device_Type.

no objection :)

Jul 11 2019, 5:49 AM · efl (efl-1.23), efl: api
woohyun closed D9274: efl_ui_text: avoid infinite loop when long pressing.
Jul 11 2019, 4:40 AM · efl
woohyun added a comment to T7848: efl.ui.autorepeat.

All look reasonable for me, too.

Jul 11 2019, 4:10 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to D9274: efl_ui_text: avoid infinite loop when long pressing.

@woohyun

The Issue I am taling about is after applying the patch. (So are there more things to do to clear the times ?)

Jul 11 2019, 3:51 AM · efl
woohyun added a comment to T7976: Efl.Input.Clickable_Clicked.

This will be changed when "efl.ui.clickable(T7847)" will have different name. Am I right?
If so, we may need to postpone removing @beta from this structure.

Jul 11 2019, 3:34 AM · efl: api, efl (efl-1.23), efl: language bindings