Page MenuHomePhabricator

woohyun (WooHyun Jung)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 4:22 AM (313 w, 6 d)
Availability
Available

Recent Activity

Fri, Feb 15

woohyun added a comment to T7585: efl.access.window.

@woohyun
As a part of T7653 this interface can be removed completely and moved into efl_access_object. Additionally events can be refactored into regular methods, so instead of "window,created" we will have something like window_created_emit method or just emit with some parameter. Is this acceptable?

Fri, Feb 15, 8:12 PM · efl: api, efl (efl-1.22)
woohyun accepted D7899: api: remove efl.ui.cursor interface.
Fri, Feb 15, 7:44 PM · efl: api

Mon, Feb 11

woohyun added inline comments to D7776: efl_ui_scroller: apply handling focus..
Mon, Feb 11, 11:03 PM · efl
woohyun added a comment to T7576: efl.container.

Currentrly, Efl.Pack extends Efl.Container.
And Efl.Pack includes "unpack" which seems almost similar with "content_remove".

Mon, Feb 11, 10:29 PM · efl: api, efl (efl-1.22)
woohyun added a comment to T7567: efl.canvas.pointer.

I also think this does not have any problem. Let's move this to "Stabilized". :)

Mon, Feb 11, 3:26 AM · efl: api, efl (efl-1.22)

Sat, Feb 9

woohyun updated subscribers of T7587: efl.access.action.

Plus, I'm not sure why this is separated with efl_access_widget_action.eo.

Sat, Feb 9, 12:52 AM · efl: api, efl (efl-1.22)
woohyun updated subscribers of T7586: efl.access.widget.action.

elm_actions_get(of efl.access.widget.action) returns "Efl_Access_Action_Data * ",
and actions_get(of efl.access.action) returns "Eina_List * " of action names....

Sat, Feb 9, 12:46 AM · efl: api, efl (efl-1.22)
woohyun updated subscribers of T7585: efl.access.window.

Those are special set of events for efl_access_object_event_emit.
And the method looks ... static one. (i.e. not a method for a specific object)

Sat, Feb 9, 12:20 AM · efl: api, efl (efl-1.22)

Fri, Feb 8

woohyun requested changes to D7899: api: remove efl.ui.cursor interface.

I don't think efl_ui_layout_part is needed anymore because it is just the same with efl_ui_widget_part now.
Do we have any problem after removing it ?

Fri, Feb 8, 6:29 PM · efl: api

Wed, Feb 6

woohyun added a comment to T7572: efl.ui.cursor.

Currently, only "Efl.Ui.Widget" and "Efl.Ui.Layout_Part" are implementing this interface.

Wed, Feb 6, 11:35 PM · efl: api, efl (efl-1.22)
woohyun added a comment to T7579: efl.ui.model.connect.

If @cedric @felipealmeida , and @SanghyeonLee don't have any objection on this definition, I think there would be no problem.

Wed, Feb 6, 8:20 PM · efl: api, efl (efl-1.22)
woohyun added a comment to T7578: efl.ui.view.

If @cedric @felipealmeida , and @SanghyeonLee don't have any objection on this definition, I think there would be no problem.

Wed, Feb 6, 8:19 PM · efl: api, efl (efl-1.22)

Thu, Jan 31

woohyun added a comment to T5719: Force all apis to be implemented.

@zmike
Ok ~ I got your point well, and also check T7436 together.
Thank you !

Thu, Jan 31, 5:40 PM · Restricted Project, efl: language bindings, Restricted Project
woohyun added reviewers for D7844: efl_ui_win_part: remove unused interface: zmike, bu5hm4n, cedric, Jaehyun_Cho.
Thu, Jan 31, 3:51 AM · efl
woohyun requested review of D7844: efl_ui_win_part: remove unused interface.
Thu, Jan 31, 3:50 AM · efl
woohyun added a revision to T5719: Force all apis to be implemented: D7844: efl_ui_win_part: remove unused interface.
Thu, Jan 31, 3:49 AM · Restricted Project, efl: language bindings, Restricted Project

Wed, Jan 30

woohyun added a comment to T5719: Force all apis to be implemented.

Then, why are we handling legacy things now ?

Wed, Jan 30, 10:43 PM · Restricted Project, efl: language bindings, Restricted Project
woohyun added a comment to T5719: Force all apis to be implemented.

One question.
Do we need to handle legacy eo files (for example, elm_xxx.eo, evas_xxx.eo, and so on) now - even those will not be bind to other languages ?

Wed, Jan 30, 3:51 AM · Restricted Project, efl: language bindings, Restricted Project

Tue, Jan 29

woohyun added a comment to T7583: efl.layout.group.

I think this interface looks good, but I'm not sure whether we need to support edje features in efl_ui_image.eo.

Tue, Jan 29, 12:23 AM · efl: api, efl (efl-1.22)
woohyun added a comment to T7582: efl.layout.signal.

I think this interface looks good, but I'm not sure whether we need to support edje features in efl_ui_image.eo.

Tue, Jan 29, 12:22 AM · efl: api, efl (efl-1.22)
woohyun added a comment to T7581: efl.layout.calc.

I think this interface looks good, but I'm not sure whether we need to support edje features in efl_ui_image.eo.

Tue, Jan 29, 12:21 AM · efl: api, efl (efl-1.22)

Mon, Jan 28

woohyun added a comment to T7580: efl.ui.factory.

I think Efl.Ui.Factory needs to include "create", "release" (and "created" event), and "model_connect" needs to be included to another interface (or class).
I've heard from @SanghyeonLee that MVVM related things are still in changing, so please check this task together :)

Mon, Jan 28, 11:27 PM · efl: api, efl (efl-1.22)
woohyun updated the diff for D7801: elm: prevent from accessing null pointer after memory allocation.

Update elm_code_widget_text.c to free allocated memory

Mon, Jan 28, 10:43 PM · efl
woohyun added inline comments to D7801: elm: prevent from accessing null pointer after memory allocation.
Mon, Jan 28, 10:40 PM · efl
woohyun added a comment to D7801: elm: prevent from accessing null pointer after memory allocation.
In D7801#138165, @zmike wrote:

This commit log should use the elm: prefix on the first line.

Mon, Jan 28, 6:45 PM · efl
woohyun updated the diff for D7801: elm: prevent from accessing null pointer after memory allocation.

update commit message

Mon, Jan 28, 6:44 PM · efl
woohyun updated the diff for D7801: elm: prevent from accessing null pointer after memory allocation.

Change the commit message

Mon, Jan 28, 6:41 PM · efl
woohyun added inline comments to D7801: elm: prevent from accessing null pointer after memory allocation.
Mon, Jan 28, 6:38 PM · efl
woohyun added reviewers for D7801: elm: prevent from accessing null pointer after memory allocation: jypark, Jaehyun_Cho.
Mon, Jan 28, 3:42 AM · efl
woohyun requested review of D7801: elm: prevent from accessing null pointer after memory allocation.
Mon, Jan 28, 3:41 AM · efl

Fri, Jan 25

woohyun closed D7770: efl-mono: Add new dependencies to autotools.
Fri, Jan 25, 3:57 AM · efl
woohyun updated the diff for D7747: efl_task: remove efl.io.* interfaces.

Remove efl.io.* implementing from efl_app

Fri, Jan 25, 12:58 AM · efl
woohyun added a revision to T7657: Remove Efl.Io.* interfaces from efl_task: D7747: efl_task: remove efl.io.* interfaces.
Fri, Jan 25, 12:57 AM · efl: api, efl (efl-1.22)
woohyun accepted D7770: efl-mono: Add new dependencies to autotools.
Fri, Jan 25, 12:43 AM · efl

Thu, Jan 24

woohyun added a comment to T7657: Remove Efl.Io.* interfaces from efl_task.

Could you check if this task is ok with following patch (D7747) ?
https://phab.enlightenment.org/D7747

Thu, Jan 24, 1:04 AM · efl: api, efl (efl-1.22)
woohyun added reviewers for D7747: efl_task: remove efl.io.* interfaces: bu5hm4n, zmike, Jaehyun_Cho, cedric.
Thu, Jan 24, 1:03 AM · efl
woohyun requested review of D7747: efl_task: remove efl.io.* interfaces.
Thu, Jan 24, 1:00 AM · efl

Wed, Jan 23

woohyun added a comment to T7597: efl.loop.

Thanks for giving an answer.
#1 As you described in T7514 like :
reading and writing to the task is feeling a bit weird, and is not really documented what it is supposed to to, in efl_app this is writing to the console, which is a lot complexer with c#&efl.io.writer, than a simpler Console.PrintLine("asfd")

Wed, Jan 23, 12:21 AM · efl: api, efl (efl-1.22)

Tue, Jan 22

woohyun closed D7666: efl_ui_widget: set a proper legacy name for widget_parent_set.
Tue, Jan 22, 11:12 PM · efl
woohyun added a comment to T7597: efl.loop.

Undefined API!:

eolian: efl_loop.eo:7:1: partially implemented function 'closed' (originally defined at efl_io_closer.eo:35:13)
eolian: efl_loop.eo:7:1: unimplemented function 'can_read' (originally defined at efl_io_reader.eo:39:13)
eolian: efl_loop.eo:7:1: unimplemented function 'can_write' (originally defined at efl_io_writer.eo:40:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close_on_exec' (originally defined at efl_io_closer.eo:52:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close_on_invalidate' (originally defined at efl_io_closer.eo:68:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close' (originally defined at efl_io_closer.eo:18:9)
eolian: efl_loop.eo:7:1: unimplemented function 'eos' (originally defined at efl_io_reader.eo:49:13)
eolian: efl_loop.eo:7:1: unimplemented function 'read' (originally defined at efl_io_reader.eo:19:9)
eolian: efl_loop.eo:7:1: unimplemented function 'write' (originally defined at efl_io_writer.eo:19:9)

I'm wondering how we will handle this unimplemented things.
What I can only think is that separating interface properly if those are not something that have plan to be implemented soon.
(Or removing some interfaces if necessary from the class)

Tue, Jan 22, 6:17 PM · efl: api, efl (efl-1.22)
woohyun added a reviewer for D7666: efl_ui_widget: set a proper legacy name for widget_parent_set: Jaehyun_Cho.
Tue, Jan 22, 5:26 PM · efl

Jan 17 2019

woohyun closed T7498: C#: Add build option to control generation of @beta items. as Resolved.
Jan 17 2019, 10:46 PM · efl: language bindings
woohyun accepted D7637: efl-mono: Enable selecting to build @beta items.
Jan 17 2019, 4:16 AM · efl
woohyun accepted D7636: eolian-mono: Add interface registration to inherited classes.
Jan 17 2019, 3:51 AM · efl
woohyun accepted D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces.
Jan 17 2019, 3:50 AM · efl
woohyun accepted D7634: efl-mono: Add proper test for interface inheritance.
Jan 17 2019, 3:50 AM · efl

Jan 16 2019

woohyun added a comment to D7666: efl_ui_widget: set a proper legacy name for widget_parent_set.

Do you have any plan to auto-remove a duplicated word between @legacy_prefix and @property name ?

Jan 16 2019, 10:35 PM · efl
woohyun added reviewers for D7666: efl_ui_widget: set a proper legacy name for widget_parent_set: q66, zmike.
Jan 16 2019, 10:26 PM · efl
woohyun requested review of D7666: efl_ui_widget: set a proper legacy name for widget_parent_set.
Jan 16 2019, 10:19 PM · efl

Jan 15 2019

woohyun added a comment to T7407: efl-mono: Crash on focus callback when quitting focus example.

Today, I can get following errors when push "quit" button.
(of course, you need some changes on the example codes to avoid build errors)
(I executed the sample with "mono")

Jan 15 2019, 5:50 PM · Restricted Project, efl: language bindings

Jan 14 2019

woohyun updated subscribers of T7506: efl-mono: Add support for global constants.

I think we can make a list of constants + enums in EFL. And then, let's think which are needed to be set as global.

Jan 14 2019, 11:52 PM · efl: language bindings
woohyun updated subscribers of T7506: efl-mono: Add support for global constants.
Jan 14 2019, 11:39 PM · efl: language bindings

Jan 11 2019

woohyun removed a project from T7619: C# Interface Concrete classes are generating methods as if they were static : Restricted Project.
Jan 11 2019, 12:26 AM · efl: language bindings
woohyun assigned T7494: C#: Mark protected methods as protected to felipealmeida.
Jan 11 2019, 12:16 AM · efl: language bindings
woohyun assigned T7108: C# bindings: eo-intro tutorial has an ERROR on shutdown to felipealmeida.
Jan 11 2019, 12:09 AM · efl: language bindings

Jan 9 2019

woohyun reassigned T7418: efl-mono: Removing widgets leaves app in unstable state from lauromoura to felipealmeida.
Jan 9 2019, 11:30 PM · efl: language bindings
woohyun reassigned T7364: efl-mono: Object gets deleted after a while even though it has an EFL parent from lauromoura to felipealmeida.
Jan 9 2019, 11:18 PM · efl: language bindings
woohyun reassigned T7525: C#: Fix marshalling of structs with complex types from lauromoura to felipealmeida.
Jan 9 2019, 10:50 PM · efl: mvvm, efl: language bindings
woohyun reassigned T7394: C#: Fix class registration when running with dotnet core from lauromoura to felipealmeida.
Jan 9 2019, 10:47 PM · efl: language bindings
woohyun added a comment to T7553: efl.ui.widget.

I've added @protected and @beta in the description for better understanding.

Jan 9 2019, 1:08 AM · efl: api, efl (efl-1.22)

Jan 8 2019

woohyun updated the task description for T7553: efl.ui.widget.
Jan 8 2019, 10:11 PM · efl: api, efl (efl-1.22)
woohyun updated the task description for T7553: efl.ui.widget.
Jan 8 2019, 10:09 PM · efl: api, efl (efl-1.22)
woohyun updated the task description for T7553: efl.ui.widget.
Jan 8 2019, 10:06 PM · efl: api, efl (efl-1.22)
woohyun added a comment to T7494: C#: Mark protected methods as protected.

I know you are very busy, but -
please care about this problem together :)

Jan 8 2019, 9:43 PM · efl: language bindings

Dec 30 2018

woohyun added a comment to T7512: efl.ui.layout.

Some of above classes include lots of definitions it them.
For instance, "Efl.Ui.Widget" and "Efl.Canvas.Object".

Dec 30 2018, 10:59 PM · efl (efl-1.22), efl: language bindings

Dec 25 2018

woohyun added a comment to T6716: allow enum/class/struct renaming.

I'm wondering the goal of this task.
Is this task to manage commits something like https://phab.enlightenment.org/rEFLbbbdfbecc4ecafc25841fc1b36d82916f5db6e0e ?

Dec 25 2018, 10:54 PM · efl: language bindings, Restricted Project
woohyun added a comment to T7394: C#: Fix class registration when running with dotnet core.

ping ? Could you check above question ?

Dec 25 2018, 6:11 PM · efl: language bindings
woohyun added a comment to T7248: C# Bindings automated TC.

@larryolj
ping ? Could you check above question ?

Dec 25 2018, 6:08 PM · efl: language bindings

Dec 7 2018

woohyun updated subscribers of T5979: C++ bindings should use the same directives as C for protected functions (#define).

Could you check this task ? I also agree with JackDaniel.

Dec 7 2018, 12:37 AM · efl: language bindings, Restricted Project

Dec 6 2018

woohyun added a comment to T7394: C#: Fix class registration when running with dotnet core.

Could you share the progress of this work ?

Dec 6 2018, 6:29 PM · efl: language bindings
woohyun added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

Do we have a way something like ...

Dec 6 2018, 6:12 PM · Restricted Project
woohyun added a comment to T7248: C# Bindings automated TC.

I think customizing for Tizen could be discussed privately.
Except that, what are left for this task ?

Dec 6 2018, 6:06 PM · efl: language bindings

Nov 22 2018

woohyun added a comment to T7470: [MVVM] Create a ViewModel helper class.
Nov 22 2018, 8:53 PM · efl: mvvm

Nov 16 2018

woohyun added a comment to T7358: EO: Support ecore_event APIs.

@cedric welcome back :)
@Jaehyun_Cho

Nov 16 2018, 5:25 PM · efl, Restricted Project

Oct 28 2018

woohyun added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I also agree with @lauromoura that we don't need to wait for the works of @lauromoura.
Eo class inheritance refactoring should be done independently with his C# binding works.

Oct 28 2018, 6:41 PM · efl: language bindings, Restricted Project

Oct 19 2018

woohyun added a comment to T7399: eolian: Add @ctor_param hint to constructors section.

I agree with the opinion of @bu5hm4n if the way that can make you happy can not be realized soon.
If you have some idea about how to fix (or improve) the bad construrctor system, could you share your idea here ?

Oct 19 2018, 12:15 AM · efl: language bindings

Oct 16 2018

woohyun closed D7168: evas_events: Fix wrong condtion..
Oct 16 2018, 10:27 PM · efl
woohyun closed D7167: ecore_wl2: Fix a memory leaking case.
Oct 16 2018, 6:20 PM · efl

Oct 11 2018

woohyun closed D7156: efl_ui_win: Move force resize code on first draw.
Oct 11 2018, 4:28 AM · efl

Oct 5 2018

woohyun closed D7146: elm_genlist: prevent null pointer access.
Oct 5 2018, 1:15 AM · efl
woohyun accepted D7146: elm_genlist: prevent null pointer access.
Oct 5 2018, 1:15 AM · efl
woohyun requested changes to D7146: elm_genlist: prevent null pointer access.

Please check inline comment ~

Oct 5 2018, 12:25 AM · efl

Oct 4 2018

woohyun closed D7137: eina debug: fix a double unlock issue.
Oct 4 2018, 2:57 AM · efl
woohyun closed D7140: elementary entry: apply scale to all edje objects.
Oct 4 2018, 2:54 AM · efl

Oct 2 2018

woohyun added a comment to T7248: C# Bindings automated TC.

Could you explain how to check the results for automated test cases In devs/felipealmeida/tct ?

Oct 2 2018, 12:55 AM · efl: language bindings

Sep 18 2018

woohyun added a comment to T7248: C# Bindings automated TC.

@felipealmeida
We only need to include the methods which are "implemented" by the specific class.
That is, we don't need to include the method "not implemented".

Sep 18 2018, 7:09 PM · efl: language bindings

Sep 10 2018

woohyun added a comment to T7241: Removing underline('_') in class name in C# bindings.

@felipealmeida
Could you take care of the case of "efl.ui.Button should be changed to Efl.Ui.Button" together ?
Plus, will you update this to the master branch directly ?
Or, if you are managing another branch for this work, please share the branch name.

Sep 10 2018, 12:28 AM · efl: language bindings

May 8 2018

woohyun closed D6133: efl_ui_widget: use efl_data_scope_safe_get instead of macro.
May 8 2018, 6:20 PM · efl
woohyun accepted D6133: efl_ui_widget: use efl_data_scope_safe_get instead of macro.
May 8 2018, 6:20 PM · efl

May 2 2018

woohyun added a comment to D4986: elm: efl_ui_list partial implementation.

Please give a feedback whether to keep this patch or not.
I think we already have another way to communicate for this subject.

May 2 2018, 6:25 PM · efl
woohyun added a comment to D5726: efl_ui_popup: add efl_ui_bg interface to backwall part.

Could you give a feedback on this ?

May 2 2018, 6:22 PM · efl
woohyun abandoned D5593: efl/frame.edc: create new group for efl_ui_frame.
May 2 2018, 6:12 PM · efl
woohyun updated subscribers of D5593: efl/frame.edc: create new group for efl_ui_frame.

This was a prototyping of new theme for efl_ui_xxx. And I can abandon this because it's already applied by @singh.amitesh.

May 2 2018, 6:12 PM · efl
woohyun added a comment to D5666: Efl.Ui.Popup.Anchor.List: add initial code.

Could you give a dicision whether to keep this patch or not ?

May 2 2018, 6:05 PM · efl
woohyun added a comment to D5430: efl_ui_pager: add a new class.

@eunue
Could you abandon this patch ?

May 2 2018, 6:03 PM · Restricted Project, efl

Apr 23 2018

woohyun accepted D5979: elementary bg: allow NULL pointers in legacy usage.
Apr 23 2018, 5:05 AM

Apr 12 2018

woohyun added a comment to D5932: Revert Efl.Ui.Multibuttonentry to create new one..

I hope this patch would be updated together with new patch which introduces new MBE class.

Apr 12 2018, 9:58 PM

Apr 11 2018

woohyun added a comment to D5908: efl_ui_slider: refactor slider widget..

@cedric
Oh. ok :) Then, everything is good.

Apr 11 2018, 1:06 AM · efl

Apr 10 2018

woohyun added a comment to D5908: efl_ui_slider: refactor slider widget..

This work includes simplify efl_ui_slider (it includes too much feature inside as a default slider class).
Could you explain why this thing should not be applied on master ?

Apr 10 2018, 9:48 PM · efl
woohyun updated subscribers of D5861: efl_ui_list : introduce new list widget for simple usage.

I've added some inline comments.

Apr 10 2018, 7:34 PM