Page MenuHomePhabricator

woohyun (WooHyun Jung)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 4:22 AM (321 w, 6 d)
Availability
Available

Recent Activity

Today

woohyun requested changes to D8603: Change Single Line Mode behaviour in Entry.

I don't think your patch is not working fine.

Thu, Apr 18, 12:49 AM · efl

Yesterday

woohyun added a comment to T7800: C#: Attach wrapper lifetime to the Eo instance.

@felipealmeida @lauromoura
If you have working branch to handle this task, would you share the branch name here ?

Wed, Apr 17, 12:55 AM · efl: language bindings

Tue, Apr 2

woohyun closed D8544: elm_entry: prevent from accessing null pointer.
Tue, Apr 2, 9:59 PM · efl

Sun, Mar 24

woohyun added a comment to T7202: entry magnifier triggers infinite loop.

I've fixed this issue by D8462.
But I think the magnifier feature in elm_entry has been bad as it has not been worked at all.
Anyway - my patch will fix "infinite recursion and crash" at least.

Sun, Mar 24, 10:54 PM · efl (efl-1.22), efl: widgets
woohyun requested review of D8462: elm_entry: fix a bug in moving the magnifier.
Sun, Mar 24, 10:52 PM · efl
woohyun added a revision to T7202: entry magnifier triggers infinite loop: D8462: elm_entry: fix a bug in moving the magnifier.
Sun, Mar 24, 10:52 PM · efl (efl-1.22), efl: widgets

Mar 7 2019

woohyun abandoned D8100: efl_ui_win: remove accel_preference and win_type from constructors.

Thank you for handling this with proper way : ) So, I abandoned.

Mar 7 2019, 9:38 PM · efl

Mar 6 2019

woohyun added a comment to T7511: efl.ui.win.
In T7511#132129, @zmike wrote:

I am now wondering whether we need:

├ (P) indicator_mode
├ (P) keyboard_mode
├ (P) screen_constrain
├ (E) indicator,prop,changed

in the initial stabilization or whether these can remain beta. @woohyun @Jaehyun_Cho

Mar 6 2019, 10:10 PM · efl: api, efl (efl-1.22)

Mar 5 2019

woohyun requested review of D8100: efl_ui_win: remove accel_preference and win_type from constructors.
Mar 5 2019, 12:41 AM · efl

Mar 4 2019

woohyun updated subscribers of T7553: efl.ui.widget.
In T7553#131982, @zmike wrote:

I think we should mark all the cursor apis as beta for now; these seem very X11-specific (e.g., Wayland has no cursor "name" property, you just send render buffers to the compositor) and we may want to change it later.

I also agree with this opinion. We can find a better way to get along with wayland.

Mar 4 2019, 3:30 AM · efl: api, efl (efl-1.22)

Feb 28 2019

woohyun added a commit to T7553: efl.ui.widget: rEFLbba6339cc421: efl.ui.widget: mark scroll_* methods @beta.
Feb 28 2019, 6:49 AM · efl: api, efl (efl-1.22)
woohyun added a commit to T7714: Remove scroll push/pop methods from Efl.Ui.Widget: rEFLbba6339cc421: efl.ui.widget: mark scroll_* methods @beta.
Feb 28 2019, 6:49 AM · efl
woohyun closed D8055: efl.ui.widget: mark scroll_* methods @beta.
Feb 28 2019, 6:49 AM · efl: api
woohyun added a comment to T7512: efl.ui.layout.
In T7512#131886, @zmike wrote:

Thinking further, theme should contain style because if they are separate then this will trigger unnecessary recalcs and/or errors when the group and style are applied separately. But I am still not sure of the requirement to keep $widgetname and $subobject separated.

Feb 28 2019, 6:30 AM · efl: api, efl (efl-1.22)
woohyun accepted D8055: efl.ui.widget: mark scroll_* methods @beta.
Feb 28 2019, 6:01 AM · efl: api
woohyun added a comment to T7511: efl.ui.win.

@zmike
I also agree with your point that almost all methods and properties need to be set as beta.
So, we can re-define them all after this release.

Feb 28 2019, 2:34 AM · efl: api, efl (efl-1.22)

Feb 26 2019

woohyun requested changes to D8017: efl_ui_widget: redo disable handling.
Feb 26 2019, 5:07 PM · efl
woohyun accepted D8025: efl_ui_widget: move focus_highlight to the window.
Feb 26 2019, 3:41 AM · efl
woohyun accepted D8017: efl_ui_widget: redo disable handling.
Feb 26 2019, 3:04 AM · efl
woohyun added a comment to D8017: efl_ui_widget: redo disable handling.

@woohyun Yes this is on purpose, for this reason:

Imagine a window with a table, that contains 6 buttons. If you now do:
efl_widget_disabled_set(win, EINA_TRUE); then the window will be disabled, and all widgets that are inside.
Now you do efl_widget_disabled_set(button5, EINA_TRUE);, the state of the window does not change.
Now you do efl_widget_disabled_set(win, EINA_FALSE); now the whole tree is enabled again except button5. Its still disabled since its explicitly disabled :)

This is why this is now an int and not a boolean flag anymore.
(btw. the behaviour above can also be done in legacy, which makes sense to me :))

A int might be a big giant, maybe a short or char is enough ?

Feb 26 2019, 3:04 AM · efl

Feb 25 2019

woohyun requested changes to D8017: efl_ui_widget: redo disable handling.
Feb 25 2019, 9:03 PM · efl
woohyun accepted D8017: efl_ui_widget: redo disable handling.
Feb 25 2019, 8:30 PM · efl
woohyun added inline comments to D8014: efl_ui_widget: introduce a new API.
Feb 25 2019, 5:48 PM · efl

Feb 24 2019

woohyun accepted D8013: efl_ui_widget: remove focused_item.
Feb 24 2019, 8:39 PM · efl
woohyun added a commit to T7553: efl.ui.widget: rEFLa2cfa9340a46: efl_ui_widget: remove "moved" event.
Feb 24 2019, 8:14 PM · efl: api, efl (efl-1.22)
woohyun closed D8005: efl_ui_widget: remove "moved" event.
Feb 24 2019, 8:14 PM · efl

Feb 23 2019

woohyun added a comment to T7553: efl.ui.widget.

@bu5hm4n @YOhoho
Thank you,
and I made D8005 because both of your comments looked correct :)

Feb 23 2019, 2:42 AM · efl: api, efl (efl-1.22)
woohyun requested review of D8005: efl_ui_widget: remove "moved" event.
Feb 23 2019, 2:40 AM · efl
woohyun added a revision to T7553: efl.ui.widget: D8005: efl_ui_widget: remove "moved" event.
Feb 23 2019, 2:40 AM · efl: api, efl (efl-1.22)

Feb 22 2019

woohyun added a comment to T7553: efl.ui.widget.

I cannot find any trace about "moved" event. Somebody knows about this ?

Feb 22 2019, 1:19 AM · efl: api, efl (efl-1.22)

Feb 15 2019

woohyun added a comment to T7585: efl.access.window.

@woohyun
As a part of T7653 this interface can be removed completely and moved into efl_access_object. Additionally events can be refactored into regular methods, so instead of "window,created" we will have something like window_created_emit method or just emit with some parameter. Is this acceptable?

Feb 15 2019, 8:12 PM · efl (efl-1.23), efl: api
woohyun accepted D7899: api: remove efl.ui.cursor interface.
Feb 15 2019, 7:44 PM · efl: api

Feb 11 2019

woohyun added inline comments to D7776: efl_ui_scroller: apply handling focus..
Feb 11 2019, 11:03 PM · efl
woohyun added a comment to T7576: efl.container.

Currentrly, Efl.Pack extends Efl.Container.
And Efl.Pack includes "unpack" which seems almost similar with "content_remove".

Feb 11 2019, 10:29 PM · efl: api, efl (efl-1.22)
woohyun added a comment to T7567: efl.canvas.pointer.

I also think this does not have any problem. Let's move this to "Stabilized". :)

Feb 11 2019, 3:26 AM · efl: api, efl (efl-1.22)

Feb 9 2019

woohyun updated subscribers of T7587: efl.access.action.

Plus, I'm not sure why this is separated with efl_access_widget_action.eo.

Feb 9 2019, 12:52 AM · efl (efl-1.23), efl: api
woohyun updated subscribers of T7586: efl.access.widget.action.

elm_actions_get(of efl.access.widget.action) returns "Efl_Access_Action_Data * ",
and actions_get(of efl.access.action) returns "Eina_List * " of action names....

Feb 9 2019, 12:46 AM · efl (efl-1.23), efl: api
woohyun updated subscribers of T7585: efl.access.window.

Those are special set of events for efl_access_object_event_emit.
And the method looks ... static one. (i.e. not a method for a specific object)

Feb 9 2019, 12:20 AM · efl (efl-1.23), efl: api

Feb 8 2019

woohyun requested changes to D7899: api: remove efl.ui.cursor interface.

I don't think efl_ui_layout_part is needed anymore because it is just the same with efl_ui_widget_part now.
Do we have any problem after removing it ?

Feb 8 2019, 6:29 PM · efl: api

Feb 6 2019

woohyun added a comment to T7572: efl.ui.cursor.

Currently, only "Efl.Ui.Widget" and "Efl.Ui.Layout_Part" are implementing this interface.

Feb 6 2019, 11:35 PM · efl: api, efl (efl-1.22)
woohyun added a comment to T7579: efl.ui.model.connect.

If @cedric @felipealmeida , and @SanghyeonLee don't have any objection on this definition, I think there would be no problem.

Feb 6 2019, 8:20 PM · efl (efl-1.23), efl: api
woohyun added a comment to T7578: efl.ui.view.

If @cedric @felipealmeida , and @SanghyeonLee don't have any objection on this definition, I think there would be no problem.

Feb 6 2019, 8:19 PM · efl (efl-1.23), efl: api

Jan 31 2019

woohyun added a comment to T5719: Force all apis to be implemented.

@zmike
Ok ~ I got your point well, and also check T7436 together.
Thank you !

Jan 31 2019, 5:40 PM · Restricted Project, efl: language bindings, Restricted Project
woohyun added reviewers for D7844: efl_ui_win_part: remove unused interface: zmike, bu5hm4n, cedric, Jaehyun_Cho.
Jan 31 2019, 3:51 AM · efl
woohyun requested review of D7844: efl_ui_win_part: remove unused interface.
Jan 31 2019, 3:50 AM · efl
woohyun added a revision to T5719: Force all apis to be implemented: D7844: efl_ui_win_part: remove unused interface.
Jan 31 2019, 3:49 AM · Restricted Project, efl: language bindings, Restricted Project

Jan 30 2019

woohyun added a comment to T5719: Force all apis to be implemented.

Then, why are we handling legacy things now ?

Jan 30 2019, 10:43 PM · Restricted Project, efl: language bindings, Restricted Project
woohyun added a comment to T5719: Force all apis to be implemented.

One question.
Do we need to handle legacy eo files (for example, elm_xxx.eo, evas_xxx.eo, and so on) now - even those will not be bind to other languages ?

Jan 30 2019, 3:51 AM · Restricted Project, efl: language bindings, Restricted Project

Jan 29 2019

woohyun added a comment to T7583: efl.layout.group.

I think this interface looks good, but I'm not sure whether we need to support edje features in efl_ui_image.eo.

Jan 29 2019, 12:23 AM · efl: api, efl (efl-1.22)
woohyun added a comment to T7582: efl.layout.signal.

I think this interface looks good, but I'm not sure whether we need to support edje features in efl_ui_image.eo.

Jan 29 2019, 12:22 AM · efl: api, efl (efl-1.22)
woohyun added a comment to T7581: efl.layout.calc.

I think this interface looks good, but I'm not sure whether we need to support edje features in efl_ui_image.eo.

Jan 29 2019, 12:21 AM · efl: api, efl (efl-1.22)

Jan 28 2019

woohyun added a comment to T7580: efl.ui.factory.

I think Efl.Ui.Factory needs to include only "create", "release", and "created" event.
That is, "model_connect" needs to be included to another interface (or class).

Jan 28 2019, 11:27 PM · efl (efl-1.23), efl: api
woohyun updated the diff for D7801: elm: prevent from accessing null pointer after memory allocation.

Update elm_code_widget_text.c to free allocated memory

Jan 28 2019, 10:43 PM · efl
woohyun added inline comments to D7801: elm: prevent from accessing null pointer after memory allocation.
Jan 28 2019, 10:40 PM · efl
woohyun added a comment to D7801: elm: prevent from accessing null pointer after memory allocation.
In D7801#138165, @zmike wrote:

This commit log should use the elm: prefix on the first line.

Jan 28 2019, 6:45 PM · efl
woohyun updated the diff for D7801: elm: prevent from accessing null pointer after memory allocation.

update commit message

Jan 28 2019, 6:44 PM · efl
woohyun updated the diff for D7801: elm: prevent from accessing null pointer after memory allocation.

Change the commit message

Jan 28 2019, 6:41 PM · efl
woohyun added inline comments to D7801: elm: prevent from accessing null pointer after memory allocation.
Jan 28 2019, 6:38 PM · efl
woohyun added reviewers for D7801: elm: prevent from accessing null pointer after memory allocation: jypark, Jaehyun_Cho.
Jan 28 2019, 3:42 AM · efl
woohyun requested review of D7801: elm: prevent from accessing null pointer after memory allocation.
Jan 28 2019, 3:41 AM · efl

Jan 25 2019

woohyun closed D7770: efl-mono: Add new dependencies to autotools.
Jan 25 2019, 3:57 AM · efl
woohyun updated the diff for D7747: efl_task: remove efl.io.* interfaces.

Remove efl.io.* implementing from efl_app

Jan 25 2019, 12:58 AM · efl
woohyun added a revision to T7657: Remove Efl.Io.* interfaces from efl_task: D7747: efl_task: remove efl.io.* interfaces.
Jan 25 2019, 12:57 AM · efl: api, efl (efl-1.22)
woohyun accepted D7770: efl-mono: Add new dependencies to autotools.
Jan 25 2019, 12:43 AM · efl

Jan 24 2019

woohyun added a comment to T7657: Remove Efl.Io.* interfaces from efl_task.

Could you check if this task is ok with following patch (D7747) ?
https://phab.enlightenment.org/D7747

Jan 24 2019, 1:04 AM · efl: api, efl (efl-1.22)
woohyun added reviewers for D7747: efl_task: remove efl.io.* interfaces: bu5hm4n, zmike, Jaehyun_Cho, cedric.
Jan 24 2019, 1:03 AM · efl
woohyun requested review of D7747: efl_task: remove efl.io.* interfaces.
Jan 24 2019, 1:00 AM · efl

Jan 23 2019

woohyun added a comment to T7597: efl.loop.

Thanks for giving an answer.
#1 As you described in T7514 like :
reading and writing to the task is feeling a bit weird, and is not really documented what it is supposed to to, in efl_app this is writing to the console, which is a lot complexer with c#&efl.io.writer, than a simpler Console.PrintLine("asfd")

Jan 23 2019, 12:21 AM · efl: api, efl (efl-1.22)

Jan 22 2019

woohyun closed D7666: efl_ui_widget: set a proper legacy name for widget_parent_set.
Jan 22 2019, 11:12 PM · efl
woohyun added a comment to T7597: efl.loop.

Undefined API!:

eolian: efl_loop.eo:7:1: partially implemented function 'closed' (originally defined at efl_io_closer.eo:35:13)
eolian: efl_loop.eo:7:1: unimplemented function 'can_read' (originally defined at efl_io_reader.eo:39:13)
eolian: efl_loop.eo:7:1: unimplemented function 'can_write' (originally defined at efl_io_writer.eo:40:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close_on_exec' (originally defined at efl_io_closer.eo:52:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close_on_invalidate' (originally defined at efl_io_closer.eo:68:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close' (originally defined at efl_io_closer.eo:18:9)
eolian: efl_loop.eo:7:1: unimplemented function 'eos' (originally defined at efl_io_reader.eo:49:13)
eolian: efl_loop.eo:7:1: unimplemented function 'read' (originally defined at efl_io_reader.eo:19:9)
eolian: efl_loop.eo:7:1: unimplemented function 'write' (originally defined at efl_io_writer.eo:19:9)

I'm wondering how we will handle this unimplemented things.
What I can only think is that separating interface properly if those are not something that have plan to be implemented soon.
(Or removing some interfaces if necessary from the class)

Jan 22 2019, 6:17 PM · efl: api, efl (efl-1.22)
woohyun added a reviewer for D7666: efl_ui_widget: set a proper legacy name for widget_parent_set: Jaehyun_Cho.
Jan 22 2019, 5:26 PM · efl

Jan 17 2019

woohyun closed T7498: C#: Add build option to control generation of @beta items. as Resolved.
Jan 17 2019, 10:46 PM · efl: language bindings
woohyun accepted D7637: efl-mono: Enable selecting to build @beta items.
Jan 17 2019, 4:16 AM · efl
woohyun accepted D7636: eolian-mono: Add interface registration to inherited classes.
Jan 17 2019, 3:51 AM · efl
woohyun accepted D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces.
Jan 17 2019, 3:50 AM · efl
woohyun accepted D7634: efl-mono: Add proper test for interface inheritance.
Jan 17 2019, 3:50 AM · efl

Jan 16 2019

woohyun added a comment to D7666: efl_ui_widget: set a proper legacy name for widget_parent_set.

Do you have any plan to auto-remove a duplicated word between @legacy_prefix and @property name ?

Jan 16 2019, 10:35 PM · efl
woohyun added reviewers for D7666: efl_ui_widget: set a proper legacy name for widget_parent_set: q66, zmike.
Jan 16 2019, 10:26 PM · efl
woohyun requested review of D7666: efl_ui_widget: set a proper legacy name for widget_parent_set.
Jan 16 2019, 10:19 PM · efl

Jan 15 2019

woohyun added a comment to T7407: efl-mono: Crash on focus callback when quitting focus example.

Today, I can get following errors when push "quit" button.
(of course, you need some changes on the example codes to avoid build errors)
(I executed the sample with "mono")

Jan 15 2019, 5:50 PM · Restricted Project, efl: language bindings

Jan 14 2019

woohyun updated subscribers of T7506: efl-mono: Add support for global constants.

I think we can make a list of constants + enums in EFL. And then, let's think which are needed to be set as global.

Jan 14 2019, 11:52 PM · efl: language bindings
woohyun updated subscribers of T7506: efl-mono: Add support for global constants.
Jan 14 2019, 11:39 PM · efl: language bindings

Jan 11 2019

woohyun removed a project from T7619: C# Interface Concrete classes are generating methods as if they were static : Restricted Project.
Jan 11 2019, 12:26 AM · efl: language bindings
woohyun assigned T7494: C#: Mark protected methods as protected to felipealmeida.
Jan 11 2019, 12:16 AM · efl: language bindings
woohyun assigned T7108: C# bindings: eo-intro tutorial has an ERROR on shutdown to felipealmeida.
Jan 11 2019, 12:09 AM · efl: language bindings

Jan 9 2019

woohyun reassigned T7418: efl-mono: Removing widgets leaves app in unstable state from lauromoura to felipealmeida.
Jan 9 2019, 11:30 PM · efl: language bindings
woohyun reassigned T7364: efl-mono: Object gets deleted after a while even though it has an EFL parent from lauromoura to felipealmeida.
Jan 9 2019, 11:18 PM · efl: language bindings
woohyun reassigned T7525: C#: Fix marshalling of structs with complex types from lauromoura to felipealmeida.
Jan 9 2019, 10:50 PM · efl: mvvm, efl: language bindings
woohyun reassigned T7394: C#: Fix class registration when running with dotnet core from lauromoura to felipealmeida.
Jan 9 2019, 10:47 PM · efl: language bindings
woohyun added a comment to T7553: efl.ui.widget.

I've added @protected and @beta in the description for better understanding.

Jan 9 2019, 1:08 AM · efl: api, efl (efl-1.22)

Jan 8 2019

woohyun updated the task description for T7553: efl.ui.widget.
Jan 8 2019, 10:11 PM · efl: api, efl (efl-1.22)
woohyun updated the task description for T7553: efl.ui.widget.
Jan 8 2019, 10:09 PM · efl: api, efl (efl-1.22)
woohyun updated the task description for T7553: efl.ui.widget.
Jan 8 2019, 10:06 PM · efl: api, efl (efl-1.22)
woohyun added a comment to T7494: C#: Mark protected methods as protected.

I know you are very busy, but -
please care about this problem together :)

Jan 8 2019, 9:43 PM · efl: language bindings

Dec 30 2018

woohyun added a comment to T7512: efl.ui.layout.

Some of above classes include lots of definitions it them.
For instance, "Efl.Ui.Widget" and "Efl.Canvas.Object".

Dec 30 2018, 10:59 PM · efl: api, efl (efl-1.22)

Dec 25 2018

woohyun added a comment to T6716: allow enum/class/struct renaming.

I'm wondering the goal of this task.
Is this task to manage commits something like https://phab.enlightenment.org/rEFLbbbdfbecc4ecafc25841fc1b36d82916f5db6e0e ?

Dec 25 2018, 10:54 PM · efl: language bindings, Restricted Project
woohyun added a comment to T7394: C#: Fix class registration when running with dotnet core.

ping ? Could you check above question ?

Dec 25 2018, 6:11 PM · efl: language bindings
woohyun added a comment to T7248: C# Bindings automated TC.

@larryolj
ping ? Could you check above question ?

Dec 25 2018, 6:08 PM · efl: language bindings

Dec 7 2018

woohyun updated subscribers of T5979: C++ bindings should use the same directives as C for protected functions (#define).

Could you check this task ? I also agree with JackDaniel.

Dec 7 2018, 12:37 AM · efl: language bindings, Restricted Project

Dec 6 2018

woohyun added a comment to T7394: C#: Fix class registration when running with dotnet core.

Could you share the progress of this work ?

Dec 6 2018, 6:29 PM · efl: language bindings