Page MenuHomePhabricator

zehortigoza (José Roberto de Souza)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2013, 9:00 AM (333 w, 6 d)
Availability
Available

Recent Activity

Apr 23 2018

zehortigoza added a comment to D5852: Bring back the user title per tab.

That is okay, it is Phabricator fault.
Thanks for merging

Apr 23 2018, 12:13 PM

Apr 20 2018

zehortigoza added a comment to D5852: Bring back the user title per tab.

Fixed the code style errors and also rename the termio_title_set() to termio_user_title_set() to make it more explicit.

Apr 20 2018, 10:36 AM
zehortigoza updated the diff for D5852: Bring back the user title per tab.
Apr 20 2018, 10:34 AM

Mar 25 2018

zehortigoza added a comment to D5852: Bring back the user title per tab.

User can not set a per tab title with -T argument, it sets a title and all tabs in that instance of terminology will have this title.
Or you think different?

Mar 25 2018, 11:42 PM

Feb 21 2018

zehortigoza added a comment to T6719: Setting tab title using GUI(Right-click > Set title) is not permanent.

@billiob I can take a look at that(in a few days) I just want to make sure if the expected behavior have changed in Terminology.

Feb 21 2018, 5:30 PM · Terminology
zehortigoza created T6719: Setting tab title using GUI(Right-click > Set title) is not permanent.
Feb 21 2018, 5:29 PM · Terminology

Jul 31 2017

zehortigoza added a comment to D5053: eldbus: check message serial before using.

LGTM, I would just say to add "static" to _eldbus_message_error_get()

Jul 31 2017, 10:32 AM

Mar 4 2016

zehortigoza added a comment to D3750: RFC: Allow user to set the title of the each tab.

Thanks for the review.
This was pushed with the fixes.

Mar 4 2016, 6:42 AM · Terminology

Mar 3 2016

zehortigoza added a comment to D3750: RFC: Allow user to set the title of the each tab.

Ok, beside that everything else looks good?
The position of the button on the menu is ok? Should I draw an icon to the button? Or who should I ping?

Mar 3 2016, 5:43 AM · Terminology

Mar 2 2016

zehortigoza added inline comments to D3750: RFC: Allow user to set the title of the each tab.
Mar 2 2016, 5:54 PM · Terminology
zehortigoza retitled D3750: RFC: Allow user to set the title of the each tab from to RFC: Allow user to set the title of the each tab.
Mar 2 2016, 1:18 PM · Terminology
zehortigoza added a member for Terminology: zehortigoza.
Mar 2 2016, 12:57 PM

Feb 1 2016

zehortigoza added a comment to T3089: Stack buffer overflow overflow in _dbus_marshal_read_basic from eldbus due to wrong size of allocated buffer..

Merged thanks.

Feb 1 2016, 6:54 AM · efl
zehortigoza closed T3089: Stack buffer overflow overflow in _dbus_marshal_read_basic from eldbus due to wrong size of allocated buffer. as Resolved.
Feb 1 2016, 6:54 AM · efl

Jan 27 2016

zehortigoza added a comment to T3089: Stack buffer overflow overflow in _dbus_marshal_read_basic from eldbus due to wrong size of allocated buffer..

Everything looks good but could you also test before push it?
http://pastebin.com/2bPd4njE

Jan 27 2016, 12:49 PM · efl

Jan 25 2016

zehortigoza added a comment to T3089: Stack buffer overflow overflow in _dbus_marshal_read_basic from eldbus due to wrong size of allocated buffer..

@m.ostapenko The application that you ran to got this error is a public one? Could you share it? If not I will write one here.
According to the trace the problem is not on the first eldbus code block but I will fix both cases.

Jan 25 2016, 12:19 PM · efl

Jan 23 2016

zehortigoza added a comment to T3089: Stack buffer overflow overflow in _dbus_marshal_read_basic from eldbus due to wrong size of allocated buffer..

Huum nice catch, I will look at it better on monday.
Thanks

Jan 23 2016, 5:56 PM · efl

Feb 3 2015

zehortigoza added a comment to T1800: eldbus blockers.
  • lib
    • at the time it was write, EFL was separated libs yet so we did not have many tests on most of the libs and we don't have any tests running on the server. But if someone with admin access and knowledge on tests help me, I would be glad to write some test cases.(We need to find a way to run an application as dbus server another as dbus client and make then talk all this inside of the test environment)
    • about the examples it have some simple and complex examples, also the eldbus API is used in several libs of EFL and on E, so we have real world examples, maybe they are not on the better place to EFL users.
    • all the main APIs have documentation, the ones that do not have are simple enough. Until today very very few question about eldbus was made on IRC on the mail list until today. And I know several people that had write application/libs beside me with eldbus.
    • On the last 6 months only one bug was open and an API was add(that I had help fix the API add)
Feb 3 2015, 5:04 PM · Restricted Project, efl: networking, efl: system integration
zehortigoza updated subscribers of T1800: eldbus blockers.
Feb 3 2015, 4:24 PM · Restricted Project, efl: networking, efl: system integration