Page MenuHomePhabricator

zmike (Mike Blumenkrantz)Administrator
Enlightenment Release Manager

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2013, 12:55 AM (343 w, 1 d)
Roles
Administrator
Availability
Available

Sometimes I make releases without compile testing.

Recent Activity

Today

zmike added a reviewer for D9316: efl_ui : add efl.extra part as layout swallow part list.: segfaultxavi.

I missed this somehow.

Fri, Aug 23, 12:13 PM · efl
zmike accepted D9662: efl_ui_single_selectable: add properties and events.
Fri, Aug 23, 12:10 PM · efl
zmike accepted D9706: efl_ui_radio_group: migrate to Efl.Ui.Single_Selectable.
Fri, Aug 23, 12:08 PM · efl
zmike requested changes to D9660: efl_ui_multi_selectable: add APIs for selecting.

Looks pretty good

Fri, Aug 23, 12:07 PM · efl
zmike closed D9733: elm: Fix Scrollable_Content namespace.
Fri, Aug 23, 12:03 PM · efl
zmike closed D9565: efl_canvas_text: remove unused Text_Style eo struct.
Fri, Aug 23, 12:03 PM · efl
zmike accepted D9723: efl_ui_item: add keybindings for selecting changes.

I suppose I'm okay with a one-time config upgrade for this case. But for future cases then it should work as I described.

Fri, Aug 23, 12:03 PM · efl
zmike added a comment to D9625: efl_io_model: remove custom counting logic.

No, that's the specific case that D9708 fixed.

Fri, Aug 23, 12:00 PM · efl
zmike edited projects for D9611: efl_pack_table: rename table_position to cell_column, cell_row, added: efl: api; removed efl.

This needs doc cop review. I'm okay with it.

Fri, Aug 23, 12:00 PM · efl: api
zmike added a comment to D9625: efl_io_model: remove custom counting logic.

I think I may have fixed this case with D9708?

Fri, Aug 23, 11:37 AM · efl
zmike accepted D9733: elm: Fix Scrollable_Content namespace.
Fri, Aug 23, 11:31 AM · efl
zmike requested changes to D9723: efl_ui_item: add keybindings for selecting changes.

Historically in EFL projects we've just added keybindings based on version changes, e.g., version X adds keybind Y, so add Y to the config when doing the X upgrade. This change would add back bindings which have been manually deleted by users. Instead, the bindings update function should just copy the system config (and then not destroy the system config unnecessarily) for the config version being upgraded for.

Fri, Aug 23, 11:18 AM · efl
zmike accepted D9722: efl_ui_item: only fetch multiselection state if this is relevant.
Fri, Aug 23, 11:17 AM · efl
zmike requested changes to D9706: efl_ui_radio_group: migrate to Efl.Ui.Single_Selectable.

Seems good overall.

Fri, Aug 23, 11:04 AM · efl
zmike accepted D9664: efl_ui_collection: honor desktop vs. touch setting of elm config.
Fri, Aug 23, 10:56 AM · efl
zmike accepted D9663: efl_input_clickable: add a flag for showing user interaction.
Fri, Aug 23, 10:54 AM · efl
zmike requested changes to D9662: efl_ui_single_selectable: add properties and events.

There's not actually a single change to src/tests/elementary/spec/efl_test_multi_selectable.c in this patch which has any relation to the rest of the patch despite the changes being significant. Can you break this out?

Fri, Aug 23, 10:51 AM · efl
zmike requested changes to D9660: efl_ui_multi_selectable: add APIs for selecting.

A small but significant nit: there's no specification in the doc about what happens if end is greater than the total number of items. In _range_selection_find you handle this by verifying the end marker for the range and erroring if it isn't found (without making the change). This seems like probably not what app developers expect, and it certainly is not specified in the docs.

Fri, Aug 23, 10:48 AM · efl
zmike closed D9701: elm/config: always use default profile with EFL_RUN_IN_TREE.
Fri, Aug 23, 10:39 AM · efl
zmike closed D9702: tests/edje: disable efreetd and ecore system modules in unit tests.
Fri, Aug 23, 10:39 AM · Restricted Project
zmike closed D9699: efl_ui_table: remove inlist items in EINA_INLIST_FREE macro.
Fri, Aug 23, 10:39 AM · efl
zmike closed D9681: efl_ui/scroll_util: block scroll calc tsunamis caused by repeat signal emits.
Fri, Aug 23, 10:39 AM · efl: widgets
zmike added a commit to T8145: C/C#: Efl.Ui.Table causes app do not quit and froze: rEFLb60e949fb699: efl_ui_table: remove inlist items in EINA_INLIST_FREE macro.
Fri, Aug 23, 10:39 AM · efl: language bindings
zmike closed D9680: theme/scroller: don't "check" bar positions randomly in other programs.
Fri, Aug 23, 10:39 AM · efl: widgets
zmike closed D9710: tests/eio: verify that the model monitor test's file is successfully created.
Fri, Aug 23, 10:39 AM · efl
zmike closed D9711: tests/eio: unlink tmpfiles after tests.
Fri, Aug 23, 10:39 AM · efl
zmike closed D9708: efl/io: fix race condition with child model deletion.
Fri, Aug 23, 10:39 AM · efl
zmike closed D9709: eio/poll: avoid ever dereferencing the backend's parent in a thread.
Fri, Aug 23, 10:39 AM · efl
zmike added a commit to T7884: efl.ui.scrollbar: rEFL6b3d430f1262: efl_ui_scrollbar_direction: replace with efl_ui_layout_orientation.
Fri, Aug 23, 10:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a commit to T7924: enum Efl.Ui.Scrollbar_Direction: rEFL6b3d430f1262: efl_ui_scrollbar_direction: replace with efl_ui_layout_orientation.
Fri, Aug 23, 10:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9612: efl_ui_scrollbar_direction: replace with efl_ui_layout_orientation.
Fri, Aug 23, 10:38 AM · efl
zmike accepted D9612: efl_ui_scrollbar_direction: replace with efl_ui_layout_orientation.

Alright then

Fri, Aug 23, 10:17 AM · efl
zmike added reviewers for D8843: evas_object_textblock: utf8_to_markup support all escapse chars: tasn, herdsman.

Summoning textperts.

Fri, Aug 23, 8:25 AM · efl
zmike added a comment to D9715: edje/cache: Refactor _edje_cache_file_coll_open().
In D9715#180358, @zmike wrote:

I think the list -> array should be broken out into a separate patch (using git-phab). Also some other minor nits. Seems fine otherwise though.

Actually I created a separate patch for it . As it based on the first patch , when I did arc diff it just combined it to one phab ID :(. if you know how to create separate phab id please let me know.

Fri, Aug 23, 8:23 AM · efl
zmike requested changes to D9715: edje/cache: Refactor _edje_cache_file_coll_open().

I think the list -> array should be broken out into a separate patch (using git-phab). Also some other minor nits. Seems fine otherwise though.

Fri, Aug 23, 7:19 AM · efl
zmike added a comment to D9719: edje/text_class: Add test case for text_class feature.

@smohanty Are you doing anything after those calls? You might accidentally be triggering an edje recalc that reapplies the default class.

Fri, Aug 23, 6:14 AM · efl

Yesterday

zmike closed D9705: efl_ui/image: explicitly mark 'drop' event @beta.
Thu, Aug 22, 10:36 PM · efl
zmike closed D9704: efl_ui/image: scalable -> efl.gfx.image::can_up/downscale.
Thu, Aug 22, 10:36 PM · efl
zmike added a commit to T7873: efl.ui.image: rEFLe84ecd95520e: efl_ui/image: scalable -> efl.gfx.image::can_up/downscale.
Thu, Aug 22, 10:36 PM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a commit to T7873: efl.ui.image: rEFL4acb83c8d95b: efl_ui/image: explicitly mark 'drop' event @beta.
Thu, Aug 22, 10:36 PM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9703: efl/gfx.image: add can_upscale and can_downscale properties.
Thu, Aug 22, 10:36 PM · efl
zmike added a commit to T7875: Efl.Gfx.Image: rEFLd50fdce4d3fc: efl/gfx.image: add can_upscale and can_downscale properties.
Thu, Aug 22, 10:36 PM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.
Thu, Aug 22, 10:36 PM · efl: widgets
zmike closed D9691: efl/gfx: redo image scale_type enum.
Thu, Aug 22, 10:36 PM · efl
zmike closed D9687: efl_ui/image: remove geometry from internal struct, clean up geometry methods.
Thu, Aug 22, 10:36 PM · efl: widgets
zmike added a commit to T7873: efl.ui.image: rEFL81183e042387: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.
Thu, Aug 22, 10:36 PM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9685: elm: fix macro for group_calc function naming.
Thu, Aug 22, 10:35 PM · efl
zmike closed D9686: efl_ui/image: add group_calc implementation, use deferred calc for sizing.
Thu, Aug 22, 10:35 PM · efl: widgets
zmike closed D9677: efl_ui/popup: remove text_alert class.
Thu, Aug 22, 10:35 PM · efl: widgets
zmike closed D9676: efl_ui/scrollable_content: add scrollable_text property.
Thu, Aug 22, 10:35 PM · efl: widgets
zmike closed D9675: efl_ui/popup: remove scroll_alert class.
Thu, Aug 22, 10:35 PM · efl: widgets
zmike closed D9674: efl_ui: add scrollable_content mixin.
Thu, Aug 22, 10:35 PM · efl: widgets
zmike added a comment to D9674: efl_ui: add scrollable_content mixin.

I've removed this functionality entirely since there is currently no demand for it and we aren't able to come to an agreement.

Thu, Aug 22, 3:59 PM · efl: widgets
zmike removed a parent revision for D9678: efl_ui/popup: use array for internal anchor callbacks: D9677: efl_ui/popup: remove text_alert class.
Thu, Aug 22, 3:59 PM · efl: widgets
zmike removed a child revision for D9677: efl_ui/popup: remove text_alert class: D9678: efl_ui/popup: use array for internal anchor callbacks.
Thu, Aug 22, 3:59 PM · efl: widgets
zmike updated the diff for D9677: efl_ui/popup: remove text_alert class.

rebase

Thu, Aug 22, 3:58 PM · efl: widgets
zmike updated the diff for D9676: efl_ui/scrollable_content: add scrollable_text property.

rebase

Thu, Aug 22, 3:58 PM · efl: widgets
zmike updated the diff for D9675: efl_ui/popup: remove scroll_alert class.

rebase

Thu, Aug 22, 3:58 PM · efl: widgets
zmike updated the diff for D9674: efl_ui: add scrollable_content mixin.

remove configurability of styles

Thu, Aug 22, 3:57 PM · efl: widgets
zmike abandoned D9679: efl_ui/popup: reuse existing internal data pointer.
Thu, Aug 22, 3:55 PM · efl: widgets
zmike abandoned D9678: efl_ui/popup: use array for internal anchor callbacks.
Thu, Aug 22, 3:55 PM · efl: widgets
zmike updated the diff for D9709: eio/poll: avoid ever dereferencing the backend's parent in a thread.

do not access data outside of main thread lock

Thu, Aug 22, 9:57 AM · efl
zmike added a comment to D9624: eio: fix poll backend.

I suppose we can agree to disagree on a number of things here. I don't see continuing this discussion as productive on any level.

Thu, Aug 22, 9:53 AM · efl
zmike added a comment to D9624: eio: fix poll backend.

This patch continues to dereference the parent pointer in the thread outside of proper locking, which means it is potentially dereferencing a garbage pointer. In addition to my previous comment regarding access of delete_me outside of locks, this patch also dereferences parent outside of locks, which can (and sometimes is) a garbage pointer.

Thu, Aug 22, 9:23 AM · efl
zmike requested review of D9711: tests/eio: unlink tmpfiles after tests.
Thu, Aug 22, 8:38 AM · efl
zmike added a child revision for D9710: tests/eio: verify that the model monitor test's file is successfully created: D9711: tests/eio: unlink tmpfiles after tests.
Thu, Aug 22, 8:38 AM · efl
zmike requested review of D9710: tests/eio: verify that the model monitor test's file is successfully created.
Thu, Aug 22, 8:38 AM · efl
zmike added a child revision for D9709: eio/poll: avoid ever dereferencing the backend's parent in a thread: D9710: tests/eio: verify that the model monitor test's file is successfully created.
Thu, Aug 22, 8:38 AM · efl
zmike requested review of D9709: eio/poll: avoid ever dereferencing the backend's parent in a thread.
Thu, Aug 22, 8:38 AM · efl
zmike added a child revision for D9708: efl/io: fix race condition with child model deletion: D9709: eio/poll: avoid ever dereferencing the backend's parent in a thread.
Thu, Aug 22, 8:38 AM · efl
zmike requested review of D9708: efl/io: fix race condition with child model deletion.
Thu, Aug 22, 8:37 AM · efl
zmike requested changes to D9624: eio: fix poll backend.

Yea tbh this doesn't actually fix the issue even if we disregard the previous issue that I cited. I've prepared another patch which avoids it entirely.

Thu, Aug 22, 8:30 AM · efl
zmike added a comment to D9674: efl_ui: add scrollable_content mixin.

My biggest concern is: Any user could just set this key before _scroller_setup gets called, and the will then be applied, this looks to me just too easy to abuse. And for us, no protection of hiding it...

Thu, Aug 22, 6:07 AM · efl: widgets
zmike added a comment to T7884: efl.ui.scrollbar.

I am not sure we can use the interface. The users of this interface already use this interface.

Sorry, what?

Thu, Aug 22, 5:43 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7873: efl.ui.image.

scalable is gone, drop is @beta (and we can ignore it). All that's left is icon.

Thu, Aug 22, 5:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested review of D9705: efl_ui/image: explicitly mark 'drop' event @beta.
Thu, Aug 22, 5:39 AM · efl
zmike added a child revision for D9704: efl_ui/image: scalable -> efl.gfx.image::can_up/downscale: D9705: efl_ui/image: explicitly mark 'drop' event @beta.
Thu, Aug 22, 5:39 AM · efl
zmike added a revision to T7873: efl.ui.image: D9705: efl_ui/image: explicitly mark 'drop' event @beta.
Thu, Aug 22, 5:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested review of D9704: efl_ui/image: scalable -> efl.gfx.image::can_up/downscale.
Thu, Aug 22, 5:39 AM · efl
zmike added a child revision for D9703: efl/gfx.image: add can_upscale and can_downscale properties: D9704: efl_ui/image: scalable -> efl.gfx.image::can_up/downscale.
Thu, Aug 22, 5:38 AM · efl
zmike added a revision to T7873: efl.ui.image: D9704: efl_ui/image: scalable -> efl.gfx.image::can_up/downscale.
Thu, Aug 22, 5:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested review of D9703: efl/gfx.image: add can_upscale and can_downscale properties.
Thu, Aug 22, 5:38 AM · efl
zmike added a child revision for D9691: efl/gfx: redo image scale_type enum: D9703: efl/gfx.image: add can_upscale and can_downscale properties.
Thu, Aug 22, 5:38 AM · efl
zmike added a revision to T7875: Efl.Gfx.Image: D9703: efl/gfx.image: add can_upscale and can_downscale properties.
Thu, Aug 22, 5:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike triaged T8171: document default values of properties as High priority.
Thu, Aug 22, 5:23 AM · efl: docs
zmike added a comment to D9674: efl_ui: add scrollable_content mixin.

My issue with a property for this is that then it seems like this opens up the possibility of having this sort of property in more places. I don't think we want to end up with properties to set styles for internal objects anywhere, as they should generally be using the same style as the widget. This is a special case where the internal widget should not be using the same style.

Thu, Aug 22, 5:20 AM · efl: widgets
zmike added a comment to T7873: efl.ui.image.

I smashed align out. I wonder if we could do something with efl.file to replace icon in some way.

Thu, Aug 22, 5:14 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9700: elm/config: avoid unnecessary elm cache flush.
Thu, Aug 22, 5:14 AM · efl
zmike accepted D9700: elm/config: avoid unnecessary elm cache flush.

There's no notes in the patch which added this, so I think we can just assume that it was a mistake.

Thu, Aug 22, 5:13 AM · efl
zmike requested review of D9702: tests/edje: disable efreetd and ecore system modules in unit tests.
Thu, Aug 22, 5:13 AM · Restricted Project
zmike requested review of D9701: elm/config: always use default profile with EFL_RUN_IN_TREE.
Thu, Aug 22, 4:47 AM · efl
zmike added a comment to T8100: widget style property.

I don't see a particular reason why it should be @protected other than preventing people from potentially footgunning themselves by overriding it improperly.

Thu, Aug 22, 4:45 AM · efl (efl-1.23), efl: api
zmike accepted D9699: efl_ui_table: remove inlist items in EINA_INLIST_FREE macro.

This is a very poorly named macro...

Thu, Aug 22, 4:33 AM · efl
zmike closed D9695: efl_ui_widget: correct the comparison parameter in scroll_freeze_pop.
Thu, Aug 22, 4:18 AM · efl
zmike closed D9667: edje_cc: Fix always true condition..
Thu, Aug 22, 4:18 AM · efl
zmike accepted D9695: efl_ui_widget: correct the comparison parameter in scroll_freeze_pop.
Thu, Aug 22, 4:16 AM · efl
zmike accepted D9667: edje_cc: Fix always true condition..
Thu, Aug 22, 4:15 AM · efl

Wed, Aug 21

zmike added a task to D9691: efl/gfx: redo image scale_type enum: T7927: enum Efl.Gfx.Image_Scale_Type.
Wed, Aug 21, 12:38 PM · efl
zmike added a revision to T7927: enum Efl.Gfx.Image_Scale_Type: D9691: efl/gfx: redo image scale_type enum.
Wed, Aug 21, 12:38 PM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested review of D9691: efl/gfx: redo image scale_type enum.
Wed, Aug 21, 12:38 PM · efl