Page MenuHomePhabricator

zmike (Mike Blumenkrantz)Administrator
Enlightenment Release Manager

Projects (12)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2013, 12:55 AM (307 w, 2 d)
Roles
Administrator
Availability
Available

Sometimes I make releases without compile testing.

Recent Activity

Nov 2 2018

zmike added a comment to D6880: build: move examples to submodule.

@zmike ... this does not compile for me

ecore_animator_example.c:4:10: fatal error: Ecore.h: No such file or directory
 #include <Ecore.h>
          ^~~~~~~~~
compilation terminated.
make[1]: *** [Makefile.examples:76: ecore_animator_example] Error 1
make[1]: Leaving directory '/home/marcel/git/examples/unsorted/ecore'
make: *** [Makefile:23: all] Error 1
Nov 2 2018, 7:55 AM · Restricted Project
zmike added a comment to D7220: ecore_wl2_window: use client window dimension.

@ManMower I am handling _ecore_wl_window_cb_angle_change which does not exist on the Upsteam now.
Tizen still has _ecore_wl_window_cb_angle_change and use def_config...
But it seems that the Tizen enlightenment does not update (not send configure) def_config. So rotated window does not show.
TBH I would like to want to know your opinion with this change.

Nov 2 2018, 6:29 AM · efl

Oct 29 2018

zmike added a comment to D7122: software_generic: Fix memory leak when resizing dmabuf native surfaces.

Strange... this native surface has been used long time in Tizen without any leak issues. It would be better if introduce use-case to assume this issue scenario...

Oct 29 2018, 7:38 AM · efl

Sep 13 2018

zmike closed D6766: tests/elm: use custom tick source for animator events.
Sep 13 2018, 12:56 AM · Restricted Project

Sep 11 2018

zmike updated subscribers of T7333: EFL meson branch crash in elementary suite..

@ManMower can you verify that this is completely impossible when using buffer engine?

Sep 11 2018, 9:23 AM · efl: meson, efl (efl-1.22)
zmike added a comment to T7333: EFL meson branch crash in elementary suite..

If you're running this on a systemd system then you should be able to provide backtraces using something like coredumpctl dump <pid>. You can see a list of recent cores with coredumpctl list | tail.

Sep 11 2018, 6:33 AM · efl: meson, efl (efl-1.22)

Sep 10 2018

zmike added a comment to T7333: EFL meson branch crash in elementary suite..

Not really. Both the evas and elm suites are failing in the log, so probably an issue related to evas or modules I'd guess. Hard to say from the elm suite log since 90% of that log is just random output from focus tests.

Sep 10 2018, 5:14 AM · efl: meson, efl (efl-1.22)

Aug 29 2018

zmike updated the diff for D6920: ci: run tests up to 5 times before failing.
Aug 29 2018, 9:44 AM · efl
zmike updated the diff for D6920: ci: run tests up to 5 times before failing.
Aug 29 2018, 7:41 AM · efl
zmike planned changes to D6920: ci: run tests up to 5 times before failing.

Sure.

Aug 29 2018, 7:41 AM · efl

Aug 28 2018

zmike updated the diff for D6921: efl_ui/layout: check finalized state before completing sizing_eval call.
Aug 28 2018, 11:57 AM · efl
zmike planned changes to D6921: efl_ui/layout: check finalized state before completing sizing_eval call.

Good point.

Aug 28 2018, 11:56 AM · efl
zmike abandoned D6830: efl/layout: check if object is finalized before internally triggering sizing_eval.

I've created D6921, but I don't currently have the time to evaluate unnecessary sizing evals during construction.

Aug 28 2018, 11:15 AM · efl: widgets
zmike requested review of D6921: efl_ui/layout: check finalized state before completing sizing_eval call.
Aug 28 2018, 11:14 AM · efl
zmike requested review of D6920: ci: run tests up to 5 times before failing.
Aug 28 2018, 11:11 AM · efl
zmike reassigned T7349: efl_app_suite failing from zmike to jayji.

If we consider #3009 as the last successful build (despite not having retried tests enough times, probably should have the iterations further increased), this means that a commit in the range from the last successful commit (rEFLb91a18524f9775449091ad6d5dd8770962c80a40) to the latest commit which you linked (rEFL351a4c828ef1c42051386141b0dd32031d74695d) broke things:

Aug 28 2018, 6:59 AM · regression, Testing, efl (efl-1.22)

Aug 27 2018

zmike requested changes to D6723: eo: add funktion for alive checks.
Aug 27 2018, 4:21 AM · efl
zmike added a comment to D6723: eo: add funktion for alive checks.

Remove DO NOT MERGE for patches that should be reviewed...

Aug 27 2018, 4:06 AM · efl
zmike accepted D6820: ethumb: fix module loading when running in tree.
Aug 27 2018, 4:05 AM · efl

Aug 24 2018

zmike closed D6825: elm/config: use correct function to return audio mute value.
Aug 24 2018, 7:05 AM · efl: widgets

Aug 23 2018

zmike added a comment to T7345: Does 'make check' work well on the latest version of check?.

I don't have any issue with v0.12.0. This patch seems fine, feel free to land it.

Aug 23 2018, 4:50 PM · enlightenment-git

Aug 22 2018

zmike closed T6816: verify init/shutdown counts in elm_suite shutdown fixture as Resolved.
Aug 22 2018, 12:35 PM · Restricted Project, Testing
zmike closed T6816: verify init/shutdown counts in elm_suite shutdown fixture, a subtask of T6824: improve testing, as Resolved.
Aug 22 2018, 12:35 PM · Restricted Project, Testing
zmike closed T7239: automatically clear config.cache on ci when env changes as Resolved.
Aug 22 2018, 12:35 PM · Restricted Project, Testing
zmike closed T7239: automatically clear config.cache on ci when env changes, a subtask of T6824: improve testing, as Resolved.
Aug 22 2018, 12:35 PM · Restricted Project, Testing
zmike closed T7238: create script for running distcheck on ci as Resolved.
Aug 22 2018, 12:35 PM · Restricted Project, Restricted Project, Testing
zmike closed T7238: create script for running distcheck on ci, a subtask of T7094: `make check` needs to pass on travis, as Resolved.
Aug 22 2018, 12:35 PM · Restricted Project, Restricted Project, Testing
zmike closed T7179: elm_suite hangs, a subtask of T6838: improve test reliability, as Resolved.
Aug 22 2018, 12:31 PM · Restricted Project, Testing
zmike closed T7179: elm_suite hangs as Resolved.
Aug 22 2018, 12:31 PM · Restricted Project, Testing
zmike closed T6811: move all tests to using fixtures for init+shutdown as Resolved.

This is done for C API.

Aug 22 2018, 12:30 PM · Restricted Project, Testing
zmike closed T6811: move all tests to using fixtures for init+shutdown, a subtask of T6824: improve testing, as Resolved.
Aug 22 2018, 12:30 PM · Restricted Project, Testing
zmike added a comment to T6605: Ecore_Exe seems to send spurious events.

That's what I tried when I first discovered it and I'm getting constant crashes. I suppose it's possible that it could somehow be local, but I did a clean reinstall...

Aug 22 2018, 10:31 AM · efl (efl-1.21), efl: system integration
zmike accepted D6893: examples: elementary: fix path for image include to dist.
Aug 22 2018, 6:26 AM · efl

Aug 21 2018

zmike updated subscribers of T7169: Create release plan.
Aug 21 2018, 2:39 PM · efl: release team, efl (efl-1.22)
zmike added a comment to T7169: Create release plan.

After some discussion on IRC, it seems some people have issues related to the voting process. An idea to improve this could be something like:

Aug 21 2018, 2:39 PM · efl: release team, efl (efl-1.22)
zmike added a comment to T6605: Ecore_Exe seems to send spurious events.

Okay, like an idiot I believed the comment that I found. @jayji adding that extra call (and removing the wrong comment) does resolve it. If you submit a patch for this I'll review.

Aug 21 2018, 1:50 PM · efl (efl-1.21), efl: system integration
zmike added a comment to T6605: Ecore_Exe seems to send spurious events.

Although now that I'm testing a patch to do this, I'm getting an immediate crash on init?

Aug 21 2018, 1:47 PM · efl (efl-1.21), efl: system integration
zmike added a comment to T6605: Ecore_Exe seems to send spurious events.

No, this should be done in the constructor, which does the initialization to -1 instead of 0.

Aug 21 2018, 1:45 PM · efl (efl-1.21), efl: system integration
zmike added a comment to T6605: Ecore_Exe seems to send spurious events.

Oh.

Aug 21 2018, 1:31 PM · efl (efl-1.21), efl: system integration
zmike added a comment to T6605: Ecore_Exe seems to send spurious events.

wtf

Aug 21 2018, 1:29 PM · efl (efl-1.21), efl: system integration
zmike added a comment to D6882: efl_input: fix problem that ref count does not become 0..

Can you describe (in the commit message) why this patch is needed?

Aug 21 2018, 11:55 AM · efl
zmike added a comment to D6870: evas cache image: compare with cached image file.

@raster Thank you. If I got it correctly I need to use evas_object_image_data_get.

Aug 21 2018, 11:52 AM · efl
zmike closed D6889: examples: emile: make sure we ship the Makefile.examples file in dist.
Aug 21 2018, 11:32 AM · efl
zmike closed D6888: examples: edje: fix warning from newly build edje-anchors example.
Aug 21 2018, 11:32 AM · efl
zmike closed D6887: examples: edje: add forgotten edje-anchors example to build.
Aug 21 2018, 11:32 AM · efl
zmike closed D6886: examples: edje: remove unreferenced file in examples.
Aug 21 2018, 11:32 AM · efl
zmike closed D6885: examples: eina: fix warnings in newly build examples.
Aug 21 2018, 11:32 AM · efl
zmike closed D6884: examples: eina: add missing example source files to dist.
Aug 21 2018, 11:31 AM · efl
zmike closed D6883: examples: evas: we had a couple of files missing in the tarballs.
Aug 21 2018, 11:31 AM · efl
zmike accepted D6883: examples: evas: we had a couple of files missing in the tarballs.
Aug 21 2018, 11:26 AM · efl
zmike accepted D6884: examples: eina: add missing example source files to dist.
Aug 21 2018, 11:26 AM · efl
zmike accepted D6885: examples: eina: fix warnings in newly build examples.
Aug 21 2018, 11:26 AM · efl
zmike accepted D6886: examples: edje: remove unreferenced file in examples.
Aug 21 2018, 11:25 AM · efl
zmike accepted D6887: examples: edje: add forgotten edje-anchors example to build.
Aug 21 2018, 11:25 AM · efl
zmike accepted D6888: examples: edje: fix warning from newly build edje-anchors example.
Aug 21 2018, 11:24 AM · efl
zmike accepted D6889: examples: emile: make sure we ship the Makefile.examples file in dist.
Aug 21 2018, 11:24 AM · efl
zmike closed T7324: Circular dependency as Resolved by committing rEFLf1fddf5c741e: cxx: Remove libeolian_cxx dependency on eo_cxx.
Aug 21 2018, 11:22 AM · efl: meson, Restricted Project
zmike closed T7324: Circular dependency, a subtask of T7322: CXX, as Resolved.
Aug 21 2018, 11:22 AM · efl: meson, Restricted Project
zmike closed D6881: cxx: Remove libeolian_cxx dependency on eo_cxx.
Aug 21 2018, 11:22 AM · efl
zmike changed the visibility for V38: test.
Aug 21 2018, 11:12 AM
zmike changed the visibility for V38: test.
Aug 21 2018, 11:12 AM
zmike accepted D6881: cxx: Remove libeolian_cxx dependency on eo_cxx.
Aug 21 2018, 7:40 AM · efl
zmike closed D6855: efl_ui_image: apply some image options as retained way..
Aug 21 2018, 7:39 AM · efl
zmike closed T7227: remove render2 from master as Resolved by committing rEFL69fae8c7bfa0: evas: remove render2.
Aug 21 2018, 7:38 AM · Active Work Proposal, efl (efl-1.22), major change, efl: rendering
zmike closed D6878: evas: remove render2.
Aug 21 2018, 7:38 AM · efl
zmike closed D6831: elm/genlist: check for item invalidation after setting item focus on click.
Aug 21 2018, 7:38 AM · efl: widgets
zmike added a commit to T7292: Elementary test genlist crash, freeze and other bugs: rEFLdaaf5ad190ab: elm/genlist: check for item invalidation after setting item focus on click.
Aug 21 2018, 7:38 AM · efl (efl-1.21)
zmike added a commit to T7292: Elementary test genlist crash, freeze and other bugs: rEFLdcac8b24f189: elm/genlist: unset callbacks flag when destroying view object in unrealize.
Aug 21 2018, 7:38 AM · efl (efl-1.21)
zmike closed D6832: elm/genlist: unset callbacks flag when destroying view object in unrealize.
Aug 21 2018, 7:38 AM · efl: widgets
zmike abandoned D6735: ci: move distcheck build skipping to earliest possible place in build.
Aug 21 2018, 7:34 AM · efl
zmike abandoned D6664: ci: trigger distcheck only if build files changed or keyword present.

I am not sure this has much value anymore. With the full patch series, distcheck builds take around 20 minutes. I expect this to be reduced by 50-75% with a meson build. I will revisit it if this is no longer the case...

Aug 21 2018, 7:34 AM · Restricted Project
zmike updated subscribers of D6871: efl_ui_format: remove supporting default TM format in interface..

@segfaultxavi do we have plans to do anything related to datetime format strings in interfaces?

Aug 21 2018, 7:28 AM · efl
zmike updated the diff for D6787: efl/timer: correctly handle timer freeze during construction.

add explicit initialized check

Aug 21 2018, 7:25 AM · efl: main loop
zmike added a comment to D6830: efl/layout: check if object is finalized before internally triggering sizing_eval.
In D6830#118984, @zmike wrote:

It's not a fundamental eo problem: it has no relation to eo at all. If the object is not constructed then why would you be trying to evaluate its size? This is an elm problem which has existed since elm was created, eo just provides a way to fix it.

Though you say it's elm problem, still this is a bad symptom.
Unless programmers could know when obj is finalized exactly, they potentially need to add this exception handlings for all cases or probably case-by-case. That's worse. it's a new burden for efl programming from now.

Aug 21 2018, 7:16 AM · efl: widgets
zmike added a comment to D6867: Format-string harden eina_strbuf_append_printf use.

The original patch was to use append, which introduced regressions, the other hunk was to attempt to fix those regressions (which fixed some but not all). We should test this patch (and add unit tests related to this) to ensure that we are not adding more regressions.

Aug 21 2018, 7:08 AM · efl
zmike added a comment to D6831: elm/genlist: check for item invalidation after setting item focus on click.

Yes, I think this is probably not a normal case, but I guess it must be handled correctly just to be sure..

Aug 21 2018, 7:06 AM · efl: widgets
zmike added inline comments to D6876: ecore-evas/buffer: implement ignore_events method.
Aug 21 2018, 7:05 AM · efl: display system
zmike accepted D6855: efl_ui_image: apply some image options as retained way..

I misread your comment a bit, so I am rephrasing.

Aug 21 2018, 7:03 AM · efl
zmike added a comment to D6832: elm/genlist: unset callbacks flag when destroying view object in unrealize.

the inner 'if' statement is the case item is not cached and directly delete view of item, so I think we might be call item_mouse_callback_del before initialize it->callbacks ....
or... those callback will be automatically removed by efl_del so you don't call them in there?

Aug 21 2018, 6:24 AM · efl: widgets
zmike added a comment to T7301: missing config options.

xinput2 and 22 are different, both options are needed. lua-old, as I've explained above, is also needed.

Aug 21 2018, 6:22 AM · efl: meson, Restricted Project

Aug 20 2018

zmike requested review of D6878: evas: remove render2.
Aug 20 2018, 3:28 PM · efl
zmike added a comment to D6880: build: move examples to submodule.

I had to manually upload this diff from a file because git-phab exploded when I tried to run it normally.

Aug 20 2018, 2:52 PM · Restricted Project
zmike requested review of D6880: build: move examples to submodule.
Aug 20 2018, 2:48 PM · Restricted Project
zmike added a revision to T7182: split legacy examples into examples repo as submodule: D6880: build: move examples to submodule.
Aug 20 2018, 2:48 PM · Active Work Proposal, major change, efl (efl-1.22), Restricted Project, efl: docs
zmike added a comment to D6879: build: remove src/benchmarks from tree.

Completed CI build of recent patches (with random distcheck fail due to missing D6877):

Aug 20 2018, 2:42 PM · Restricted Project
zmike added a comment to D6878: evas: remove render2.

Completed CI build of recent patches (with random distcheck fail due to missing D6877):

Aug 20 2018, 2:39 PM · efl
zmike requested review of D6879: build: remove src/benchmarks from tree.
Aug 20 2018, 2:37 PM · Restricted Project
zmike added a revision to T7183: remove efl.git/src/benchmarks: D6879: build: remove src/benchmarks from tree.
Aug 20 2018, 2:37 PM · Active Work Proposal, efl: rendering, efl: data types, efl (efl-1.22), major change
zmike requested review of D6878: evas: remove render2.
Aug 20 2018, 2:36 PM · efl
zmike added a revision to T7227: remove render2 from master: D6878: evas: remove render2.
Aug 20 2018, 2:36 PM · Active Work Proposal, efl (efl-1.22), major change, efl: rendering
zmike requested review of D6877: ci: use distcheck script.
Aug 20 2018, 2:35 PM · Restricted Project
zmike added a comment to T7301: missing config options.

Hm probably having a single option for pixman is enough.

Aug 20 2018, 2:34 PM · efl: meson, Restricted Project
zmike added a comment to T7301: missing config options.

I think we need all of the option functionality except for:
--enable-debug
--enable-cancel-ok
--enable-tile-rotate
rsvg (I'm not sure can be removed since our svg support is too basic to do very much atm?)

Aug 20 2018, 1:57 PM · efl: meson, Restricted Project
zmike added a comment to T7273: eolian_cxx Makefile.examples broken.

@felipealmeida I've merged the grafted history into master of the examples repo. All future patches can just go directly into master.

Aug 20 2018, 1:06 PM · Restricted Project, efl: language bindings
zmike added a commit to T6718: clean up uninitialized variable warnings in examples compile: Unknown Object (Diffusion Commit).
Aug 20 2018, 1:03 PM · efl: docs, Restricted Project
zmike added a comment to T7329: Document the release process on the Enlightenment site.

The creator of the proposal must add work proposal (and efl or efl subproject tags) in order for the proposal to be visible.

Aug 20 2018, 11:54 AM · efl: docs, efl: release team, efl (efl-1.22)
zmike requested review of D6876: ecore-evas/buffer: implement ignore_events method.
Aug 20 2018, 11:44 AM · efl: display system
zmike added a revision to T4700: implement ignore_events in ecore-evas bufer engine: D6876: ecore-evas/buffer: implement ignore_events method.
Aug 20 2018, 11:44 AM · Active Work Proposal, major change, efl (efl-1.22), efl: input, efl: display system
zmike added a commit to T7327: dmabuf module build breaks with strict linking: rEFLe793a698dc39: ecore_wl2_dmabuf: Depend on ecore_wl2.
Aug 20 2018, 11:11 AM · efl (efl-1.21)
zmike closed D6875: ecore_wl2_dmabuf: Depend on ecore_wl2.
Aug 20 2018, 11:11 AM · efl