Page MenuHomePhabricator

zmike (Mike Blumenkrantz)Administrator
Enlightenment Release Manager

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2013, 12:55 AM (334 w, 4 d)
Roles
Administrator
Availability
Available

Sometimes I make releases without compile testing.

Recent Activity

Yesterday

zmike closed D9152: tests/slider: verify emission of changed and delay,changed events.
Mon, Jun 24, 9:32 AM · efl: widgets
zmike closed D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.
Mon, Jun 24, 9:31 AM · efl: widgets
zmike updated the diff for D7591: Exactness: porting to Meson.
Mon, Jun 24, 9:13 AM · efl
zmike updated the diff for D7590: Exactness: code importation.

sync api

Mon, Jun 24, 9:13 AM · efl
zmike requested review of D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.
Mon, Jun 24, 6:35 AM · efl: widgets
zmike added a comment to D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.

It gets unset at the point of being swallowed:

Mon, Jun 24, 6:35 AM · efl: widgets
zmike added a comment to D9152: tests/slider: verify emission of changed and delay,changed events.

It's planned, but I'm doing something else right now.

Mon, Jun 24, 6:29 AM · efl: widgets
zmike closed D9162: ci: travis: osx: switch to newer macos image and brew addon for packages.
Mon, Jun 24, 6:11 AM · efl
zmike accepted D9162: ci: travis: osx: switch to newer macos image and brew addon for packages.
Mon, Jun 24, 6:10 AM · efl
zmike requested changes to D9160: ci: travis: remove left over from autotools build.
Mon, Jun 24, 6:10 AM · efl
zmike closed D9161: ci: enforce ccache for macos meson run.
Mon, Jun 24, 6:10 AM · efl
zmike accepted D9161: ci: enforce ccache for macos meson run.

huge patch.

Mon, Jun 24, 6:09 AM · efl
zmike added a comment to T7902: efl.ui.popup.

I agree that it seems like align could be handled using align_hint.

Mon, Jun 24, 6:07 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

I think maybe I am not understanding this: what exactly are you proposing?

Mon, Jun 24, 6:05 AM · Restricted Project
zmike closed D9154: remove last bits of Evil.h in tests and use evil_private.h instead.
Mon, Jun 24, 6:01 AM · efl
zmike accepted D9154: remove last bits of Evil.h in tests and use evil_private.h instead.
Mon, Jun 24, 6:01 AM · efl
zmike added a comment to T7898: efl.ui.format.

I think if we are going with a priority system then the most bespoke one should be the highest priority. This would mean cb > values > string.

Mon, Jun 24, 6:00 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7947: Efl.Ui.Anchor_Popup.

align_priority is (iirc) a way to specify how you prefer the popup to do layout if it is constrained. We may want to copy/research xdg-popup semantics for this (which I also wrote) since they're a bit more robust.

Mon, Jun 24, 5:53 AM · efl (efl-1.23), efl: language bindings
zmike added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

@zmike

Thank you for the suggestion.
I want to fully understand your idea so I have some questions about the ownership steps.

  1. clickable duplicates mouse-up event
  2. activeview unsets ownership on pointer events for the unpressed pointer
  3. clickable receives mouse,up signal, checks cached mouse-up event for owner, sends 'click' event after checking for ownership

For now, Efl.Ui.Clickable_Util provides "bind_to_theme" and it adds signal callbacks to the given edj obejct for the clickable object.
So Efl.Ui.Clickable_Util only registers signal callback from the given edj object.

To do 7, do we need to register event callback for mouse up (POINTER_UP) for bind_to_theme case as well?
(as far as I can see, we cannot get mouse event in the signal callback.)

Mon, Jun 24, 5:47 AM

Fri, Jun 21

zmike requested review of D9152: tests/slider: verify emission of changed and delay,changed events.
Fri, Jun 21, 11:09 AM · efl: widgets
zmike requested review of D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.
Fri, Jun 21, 11:09 AM · efl: widgets
zmike added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

Is there anything specific that you don't understand?

Fri, Jun 21, 6:40 AM
zmike closed D9144: efl_ui_win: fix emitting of object focus events.
Fri, Jun 21, 6:40 AM · efl
zmike updated the diff for D9091: tests: add functional unit tests for radio widgets.
Fri, Jun 21, 6:39 AM · efl
zmike accepted D9144: efl_ui_win: fix emitting of object focus events.
Fri, Jun 21, 6:37 AM · efl
zmike added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

This seems like it's just continuing to add more bandaids and workarounds rather than being a prescriptive solution. Is there a reason my ownership proposal would not solve this issue?

Fri, Jun 21, 6:23 AM
zmike added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

There's no docs about it because this is efl.

Fri, Jun 21, 5:22 AM

Thu, Jun 20

zmike updated subscribers of T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

Just brainstorming here, but it seems like what we actually want to provide info about is the ownership of events. In the case where the scroller is being dragged, the scroller can be said to own the next mouse-up event, yes? So then for this case it may be useful to add a method of setting an owner property to a sequence of events by allowing it to be set on the input device object: sort of like a "grab". It could look something like this:

Thu, Jun 20, 10:53 AM
zmike added a comment to D9093: evas: add an API to know where inside an object content can be layout over..

region++

Thu, Jun 20, 10:13 AM · efl
zmike added a comment to T7967: Efl.Input.Event.

It does seem weird to have both.

Thu, Jun 20, 10:12 AM · efl (efl-1.23), efl: api
zmike closed D9143: remove more files.
Thu, Jun 20, 10:05 AM · efl
zmike accepted D9143: remove more files.
Thu, Jun 20, 10:05 AM · efl
zmike added a comment to D9138: efl_ui_win: repair scene event emission.

You can just land this series yourself

Thu, Jun 20, 8:07 AM · efl
zmike added a comment to D9138: efl_ui_win: repair scene event emission.

Uhh this still fails to apply?

Thu, Jun 20, 8:07 AM · efl
zmike accepted D9138: efl_ui_win: repair scene event emission.
Thu, Jun 20, 8:05 AM · efl
zmike requested changes to D9138: efl_ui_win: repair scene event emission.

Actually this no longer applies...

Thu, Jun 20, 7:22 AM · efl
zmike accepted D9135: efl_input_pointer: rename tool to touch_id.
Thu, Jun 20, 7:20 AM · efl
zmike accepted D9138: efl_ui_win: repair scene event emission.

A+ for adding the test

Thu, Jun 20, 7:15 AM · efl
zmike accepted D9137: evas: emit the corrent event here,.

This should probably have a unit test?

Thu, Jun 20, 7:14 AM · efl
zmike added a comment to T7893: efl.ui.slider.

This seems like it should have a unit test?

Thu, Jun 20, 7:13 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7900: efl.pack_table.

But those are for the individual properties and we're talking about the combined property...

Thu, Jun 20, 7:11 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike accepted D9105: evas: add a test for loading Android 9patch file..

Oops, I misread.

Thu, Jun 20, 7:04 AM · efl
zmike requested changes to D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..

No, I meant this as in 'answer these questions in the commit log'

Thu, Jun 20, 7:03 AM · efl
zmike added a comment to D9093: evas: add an API to know where inside an object content can be layout over..

I'm just not sure we want to use zone here, but maybe that's only me. @segfaultxavi what do you think?

Thu, Jun 20, 6:57 AM · efl
zmike accepted D9060: efl_ui_radio: cleanup API.

Oh I forgot about this.

Thu, Jun 20, 6:47 AM · efl
zmike added inline comments to D9125: efl_ui/active_view: fix object destruction.
Thu, Jun 20, 6:45 AM · efl: widgets
zmike closed D9127: ecore: do not rely on implicit rules for memory lifecycle during test..
Thu, Jun 20, 6:40 AM · efl
zmike accepted D9127: ecore: do not rely on implicit rules for memory lifecycle during test..
Thu, Jun 20, 6:38 AM · efl

Wed, Jun 19

zmike closed D9126: Revert "efl_ui_suite_spec: add a hack to have running tests again".
Wed, Jun 19, 11:11 PM · efl
zmike closed D9125: efl_ui/active_view: fix object destruction.
Wed, Jun 19, 11:11 PM · efl: widgets
zmike requested review of D9126: Revert "efl_ui_suite_spec: add a hack to have running tests again".
Wed, Jun 19, 11:11 AM · efl
zmike added a child revision for D9125: efl_ui/active_view: fix object destruction: D9126: Revert "efl_ui_suite_spec: add a hack to have running tests again".
Wed, Jun 19, 11:11 AM · efl: widgets
zmike requested review of D9125: efl_ui/active_view: fix object destruction.
Wed, Jun 19, 11:10 AM · efl: widgets
zmike requested review of D9124: eolian: fix leak in eolian_state_file_path_parse.
Wed, Jun 19, 9:52 AM · efl
zmike added a comment to T7900: efl.pack_table.

It's used in the code now, so there must be a reason for it...probably.

Wed, Jun 19, 9:32 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike triaged T8020: promise unit tests fail with CK_FORK=no as Showstopper Issues priority.
Wed, Jun 19, 9:29 AM · Restricted Project
zmike added a comment to T7981: what even is this.

@cedric

Wed, Jun 19, 9:28 AM · efl, BBQ
zmike closed T7780: remove autotools as Resolved.
Wed, Jun 19, 9:27 AM · Restricted Project, efl: meson
zmike closed T7782: verify config.h equivalence, a subtask of T7780: remove autotools, as Resolved.
Wed, Jun 19, 9:27 AM · Restricted Project, efl: meson
zmike closed T7782: verify config.h equivalence as Resolved.
Wed, Jun 19, 9:27 AM · Restricted Project, efl: meson
zmike closed T7980: elm_test fileselector crash as Resolved.
Wed, Jun 19, 9:27 AM · regression, efl: widgets
zmike requested review of D9123: ci: move release-ready to default build and enable tests+install on it.
Wed, Jun 19, 6:51 AM · efl
zmike requested changes to D9115: [edje] Add support for map zoom to use other part center..

This seems okay to me other than the doc typo. It needs a real commit message, however, to explain the purpose of the patch.

Wed, Jun 19, 6:45 AM · efl
zmike added a comment to T7900: efl.pack_table.

This chart https://i.imgur.com/QONVIyz.gif

Wed, Jun 19, 6:41 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9112: efl_ui_suite_spec: add a hack to have running tests again.
Wed, Jun 19, 6:37 AM · efl
zmike accepted D9112: efl_ui_suite_spec: add a hack to have running tests again.
Wed, Jun 19, 6:36 AM · efl
zmike added a comment to D9089: efl_ui/layout: apply theme during constructor if widget class has been set.

Maybe we need to approach it a bit differently then. Things like packing an object into a box or setting hints during construction should always work (and they do without this patch), but also I think it's important that e.g., efl_text_set should always work on an object. So it may be the case that I need to improve edje internal caching somehow to allow "pre-setting" text and swallow parts or something...

Wed, Jun 19, 6:33 AM · efl: widgets
zmike closed D9122: ci: travis: no need to cache the autom4te.cache any longer.
Wed, Jun 19, 6:28 AM · efl
zmike closed D9121: ci: remove no longer needed make examples script.
Wed, Jun 19, 6:28 AM · efl
zmike closed D9120: ci: rename some travis fold log names and add more.
Wed, Jun 19, 6:28 AM · efl
zmike closed D9119: ci: enhance enabled/disabled meson builds to cover almost all options.
Wed, Jun 19, 6:28 AM · efl
zmike closed D9118: ci: remove no longer needed MAKEFLAGS env variable.
Wed, Jun 19, 6:28 AM · efl
zmike closed D9117: ci: travis: remove no longer used BUILDSYSTEM env variable.
Wed, Jun 19, 6:28 AM · efl
zmike closed D9116: ci: remove no longer used scripts and patch file.
Wed, Jun 19, 6:28 AM · efl
zmike accepted D9122: ci: travis: no need to cache the autom4te.cache any longer.
Wed, Jun 19, 6:22 AM · efl
zmike accepted D9121: ci: remove no longer needed make examples script.
Wed, Jun 19, 6:22 AM · efl
zmike accepted D9120: ci: rename some travis fold log names and add more.
Wed, Jun 19, 6:22 AM · efl
zmike accepted D9119: ci: enhance enabled/disabled meson builds to cover almost all options.
Wed, Jun 19, 6:21 AM · efl
zmike accepted D9118: ci: remove no longer needed MAKEFLAGS env variable.
Wed, Jun 19, 6:20 AM · efl
zmike accepted D9117: ci: travis: remove no longer used BUILDSYSTEM env variable.
Wed, Jun 19, 6:20 AM · efl
zmike accepted D9116: ci: remove no longer used scripts and patch file.
Wed, Jun 19, 6:20 AM · efl

Tue, Jun 18

zmike added a comment to T7898: efl.ui.format.

My first reaction is that this sounds awful to use and is massively overengineered, but I'll sleep on it.

Tue, Jun 18, 10:00 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested review of D9110: efl_ui_range_display: range_min_max -> range_limits.
Tue, Jun 18, 9:58 AM · efl: api
zmike added a revision to T7895: efl.ui.range_display: D9110: efl_ui_range_display: range_min_max -> range_limits.
Tue, Jun 18, 9:58 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7866: efl.ui.nstate.

@woohyun ?

Tue, Jun 18, 9:41 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7898: efl.ui.format.

I'm not sure we want to use the word special here since it's just strings? I really would prefer something like format_string_array but then that's misleading because format string is an actual programming term...

Tue, Jun 18, 9:28 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7897: efl.ui.spin.

Yea I read this before I saw the format ticket comments.

Tue, Jun 18, 9:24 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9109: efl_ui_spec: Support running with CK_FORK=no.
Tue, Jun 18, 9:23 AM · efl
zmike accepted D9109: efl_ui_spec: Support running with CK_FORK=no.
Tue, Jun 18, 9:22 AM · efl
zmike added a comment to T7858: efl.text_markup.

http://i.imgur.com/1miaoW9.gifv

Tue, Jun 18, 9:21 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7580: efl.ui.factory.

As we discussed in voice call meeting,
Event abstraction on item can be the additional role of factory.
here my question is, if factory can abstract the event callback add,
what object should be passed as the result of this event? item object or widget object with index as event info?

Tue, Jun 18, 9:20 AM · efl (efl-1.23), efl: api
zmike added a comment to T7964: Efl.Input.Key.

You're just mad because we have all the best memes.

Tue, Jun 18, 9:17 AM · efl (efl-1.23), efl: api
zmike added a comment to T7900: efl.pack_table.

Maybe table_cell instead of position? Feels weird if that has a setter since then there's pack and table_cell_get. Isn't there some kind of interface for calling on packed subobjects for things like this? Maybe there should be one?

Tue, Jun 18, 9:16 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7898: efl.ui.format.

I think something more like format_values would be a better name, in keeping with format_ namespacing?

Tue, Jun 18, 9:04 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7897: efl.ui.spin.

I think it's a corner case. This should be handled through the callback I think, if I'm remembering correctly how that works.

Tue, Jun 18, 9:00 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7895: efl.ui.range_display.

Do we want to perhaps rename range_min_max to range_limits?

Tue, Jun 18, 8:59 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to D8920: efl_ui_stack: remove!.

As @bu5hm4n has said, I think it's a clear indicator that the API is useful enough to keep if application developers are interested in using it during this evaluation period.

Tue, Jun 18, 8:55 AM · efl
zmike added a comment to D9108: ci: remove autotools-related conditionals.

https://travis-ci.org/Enlightenment/efl/builds/547264596

Tue, Jun 18, 7:24 AM · efl
zmike requested review of D9108: ci: remove autotools-related conditionals.
Tue, Jun 18, 7:24 AM · efl
zmike added a comment to D8920: efl_ui_stack: remove!.

@bu5hm4n @segfaultxavi

I am sorry for saying this now.

But I discussed about this topic with my colleague developers and the major feedback was that push/pop is not required for this case.

In C#, developers normally do not care about deleting an object (due to garbage collector). Even in C, developers hardly unpacks views (they just move the active index without unpacking views).

Moreover, current push/pop concept here is not exactly the push/pop concept of stack data structure. So it confuses developers too.

In short, how about not support push/pop?

Tue, Jun 18, 6:37 AM · efl