Page MenuHomePhabricator

zmike (Mike Blumenkrantz)Administrator
Enlightenment Release Manager

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2013, 12:55 AM (317 w, 4 h)
Roles
Administrator
Availability
Available

Sometimes I make releases without compile testing.

Recent Activity

Fri, Feb 15

zmike added a comment to T7571: efl.ui.focus.object.

Yea seems fine on the rename. As for method naming, I meant that prepare_logical is not a super informative method name. What does efl_ui_focus_object_prepare_logical even mean at first glance? Nothing, at least to me...

Fri, Feb 15, 12:33 PM · efl: api, efl (efl-1.22)
zmike closed T7572: efl.ui.cursor as Resolved.

Closing this since we're removing the interface.

Fri, Feb 15, 12:04 PM · efl: api, efl (efl-1.22)
zmike closed T7572: efl.ui.cursor, a subtask of T7553: efl.ui.widget, as Resolved.
Fri, Feb 15, 12:04 PM · efl: api, efl (efl-1.22)
zmike requested review of D7968: efl.gfx.stack: restack -> stack,changed.
Fri, Feb 15, 12:04 PM · efl: api
zmike added a revision to T7560: efl.gfx.stack: D7968: efl.gfx.stack: restack -> stack,changed.
Fri, Feb 15, 12:04 PM · efl: api, efl (efl-1.22)
zmike added a comment to T7560: efl.gfx.stack.

So I think all we need here is to rename the event? I'm on it.

Fri, Feb 15, 12:03 PM · efl: api, efl (efl-1.22)
zmike moved T7570: efl.part from "easy" to Stabilized on the efl: api board.
Fri, Feb 15, 11:59 AM · efl: api, efl (efl-1.22)
zmike updated the diff for D7967: efl.screen: add screen_scale_factor property.
Fri, Feb 15, 11:57 AM · efl: api
zmike updated the diff for D7966: efl.screen: add screen_size_in_mm property.
Fri, Feb 15, 11:57 AM · efl: api
zmike updated the diff for D7965: efl.screen: screen_size -> screen_size_in_pixels.
Fri, Feb 15, 11:57 AM · efl: api
zmike planned changes to D7967: efl.screen: add screen_scale_factor property.
Fri, Feb 15, 11:50 AM · efl: api
zmike added a comment to T7571: efl.ui.focus.object.

The method naming here seems a bit uninformative?

Fri, Feb 15, 11:46 AM · efl: api, efl (efl-1.22)
zmike added a comment to D7899: api: remove efl.ui.cursor interface.

I think @woohyun is making a good suggestion here.

Fri, Feb 15, 11:45 AM · efl: api
zmike added a comment to T7553: efl.ui.widget.

Why does this have a moved event?

Fri, Feb 15, 11:43 AM · efl: api, efl (efl-1.22)
zmike added inline comments to D7966: efl.screen: add screen_size_in_mm property.
Fri, Feb 15, 11:42 AM · efl: api
zmike added a comment to T7383: Efl.Config and Efl.Config_GLobal.

What's going on here?

Fri, Feb 15, 11:04 AM · efl (efl-1.22)
zmike added a subtask for T7592: efl.config: T7383: Efl.Config and Efl.Config_GLobal.
Fri, Feb 15, 11:04 AM · efl: api, efl (efl-1.22)
zmike added a parent task for T7383: Efl.Config and Efl.Config_GLobal: T7592: efl.config.
Fri, Feb 15, 11:04 AM · efl (efl-1.22)
zmike added a comment to T7590: efl.screen.

I've created patches for the above, though the new properties lack implementations. This can be solved at a later point.

Fri, Feb 15, 11:01 AM · efl: api, efl (efl-1.22)
zmike requested review of D7967: efl.screen: add screen_scale_factor property.
Fri, Feb 15, 11:01 AM · efl: api
zmike added a child revision for D7966: efl.screen: add screen_size_in_mm property: D7967: efl.screen: add screen_scale_factor property.
Fri, Feb 15, 11:01 AM · efl: api
zmike added a revision to T7590: efl.screen: D7967: efl.screen: add screen_scale_factor property.
Fri, Feb 15, 11:01 AM · efl: api, efl (efl-1.22)
zmike requested review of D7966: efl.screen: add screen_size_in_mm property.
Fri, Feb 15, 11:01 AM · efl: api
zmike added a child revision for D7965: efl.screen: screen_size -> screen_size_in_pixels: D7966: efl.screen: add screen_size_in_mm property.
Fri, Feb 15, 11:01 AM · efl: api
zmike added a revision to T7590: efl.screen: D7966: efl.screen: add screen_size_in_mm property.
Fri, Feb 15, 11:01 AM · efl: api, efl (efl-1.22)
zmike requested review of D7965: efl.screen: screen_size -> screen_size_in_pixels.
Fri, Feb 15, 11:01 AM · efl: api
zmike added a revision to T7590: efl.screen: D7965: efl.screen: screen_size -> screen_size_in_pixels.
Fri, Feb 15, 11:01 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7590: efl.screen.

So maybe something like:

Fri, Feb 15, 10:48 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7672: efl.file_save.

I initially listed some concerns, which you addressed with specific proposals:

In T7672#130634, @zmike wrote:

To propose a more concrete change here:

  • move existing efl_file(_save) into efl_gfx (either directly or as efl.gfx.file)
  • keep simple efl.file mixin with only file property
    • remove key
  • keep simple efl.file_save interface
    • remove flags
  • create file_key property to go with the file api which has been moved to efl_gfx
  • create save_flags property to go with file api in efl_gfx

And we all agreed, so you are free to implement those.

Afterwards, I also complained (like the tireless little whiner that I am) about the asymmetry of having save() but no load(), and the fact that the filename you save() to is not the same you will retrieve later when reading the file property.
@cedric agreed that conventional load() and save() methods would be nice, but warned us that some work will then be required to link these methods with a filename property on a Model object. I do not know what this work is, but Cedric thinks it is doable.

And this is the TL;DR, as I understand it.

Fri, Feb 15, 10:00 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7562: efl.input.interface.
(E) focus,in
(E) focus,out
Fri, Feb 15, 8:43 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7574: efl.ui.selection.

I don't think there's any way this makes it for 1.22 given that it goes with T7575 and requires dnd/selection types...

Fri, Feb 15, 6:50 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7563: efl.gfx.size_hint.

Not totally sold on hint_margin naming? Was this hint_padding or similar at some point?

Fri, Feb 15, 6:49 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7555: efl.canvas.object.

is_frame_object seems bad to expose since this should only be used by internals?

Fri, Feb 15, 6:48 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7562: efl.input.interface.

This seems like it has some overlap with T7584?

Fri, Feb 15, 6:47 AM · efl: api, efl (efl-1.22)
zmike moved T7582: efl.layout.signal from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7559: efl.gfx.color from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7567: efl.canvas.pointer from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7576: efl.container from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7589: efl.input.state from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7593: efl.ui.widget_focus_manager from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7588: efl.content from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7591: efl.text from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7594: efl.ui.focus.manager_window_root from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7672: efl.file_save.

If someone gives me a tl;dr of what's happening I can take care of this

Fri, Feb 15, 6:08 AM · efl: api, efl (efl-1.22)
zmike updated the diff for D7954: efl.canvas.scene: improve class docs.

I don't know what this is so I removed it

Fri, Feb 15, 6:07 AM · efl
zmike updated the diff for D7899: api: remove efl.ui.cursor interface.

remove file

Fri, Feb 15, 6:05 AM · efl: api
zmike updated the diff for D7955: interfaces: move pointer_iterate method efl.canvas.scene -> efl.ui.win.
Fri, Feb 15, 6:01 AM · efl
zmike added a comment to D7955: interfaces: move pointer_iterate method efl.canvas.scene -> efl.ui.win.

Good catch, the @beta patch came in while I was doing this so I guess I messed up the rebase.

Fri, Feb 15, 5:59 AM · efl

Thu, Feb 14

zmike closed D7953: Move Efl.Observable_Tuple into efl_observable.eo.
Thu, Feb 14, 12:41 PM · efl
zmike accepted D7953: Move Efl.Observable_Tuple into efl_observable.eo.
Thu, Feb 14, 12:41 PM · efl
zmike closed D7958: Remove warnings when building without EFL_BETA_API_SUPPORT.
Thu, Feb 14, 12:34 PM · efl
zmike accepted D7958: Remove warnings when building without EFL_BETA_API_SUPPORT.
Thu, Feb 14, 12:33 PM · efl
zmike requested review of D7957: efl.canvas.scene: clean up pointer_position property.
Thu, Feb 14, 12:26 PM · efl
zmike added a child revision for D7956: efl.canvas.scene: add 'seat_default' property: D7957: efl.canvas.scene: clean up pointer_position property.
Thu, Feb 14, 12:25 PM · efl
zmike added a revision to T7584: efl.canvas.scene: D7957: efl.canvas.scene: clean up pointer_position property.
Thu, Feb 14, 12:25 PM · efl: api, efl (efl-1.22)
zmike requested review of D7956: efl.canvas.scene: add 'seat_default' property.
Thu, Feb 14, 12:25 PM · efl
zmike added a child revision for D7955: interfaces: move pointer_iterate method efl.canvas.scene -> efl.ui.win: D7956: efl.canvas.scene: add 'seat_default' property.
Thu, Feb 14, 12:25 PM · efl
zmike added a revision to T7584: efl.canvas.scene: D7956: efl.canvas.scene: add 'seat_default' property.
Thu, Feb 14, 12:25 PM · efl: api, efl (efl-1.22)
zmike requested review of D7955: interfaces: move pointer_iterate method efl.canvas.scene -> efl.ui.win.
Thu, Feb 14, 12:25 PM · efl
zmike added a child revision for D7954: efl.canvas.scene: improve class docs: D7955: interfaces: move pointer_iterate method efl.canvas.scene -> efl.ui.win.
Thu, Feb 14, 12:25 PM · efl
zmike added a revision to T7584: efl.canvas.scene: D7955: interfaces: move pointer_iterate method efl.canvas.scene -> efl.ui.win.
Thu, Feb 14, 12:25 PM · efl: api, efl (efl-1.22)
zmike requested review of D7954: efl.canvas.scene: improve class docs.
Thu, Feb 14, 12:24 PM · efl
zmike added a revision to T7584: efl.canvas.scene: D7954: efl.canvas.scene: improve class docs.
Thu, Feb 14, 12:24 PM · efl: api, efl (efl-1.22)
zmike updated the diff for D7905: interfaces: move animator,tick to efl.canvas.object and remove efl.animator.

rebase

Thu, Feb 14, 10:56 AM · efl
zmike updated the diff for D7899: api: remove efl.ui.cursor interface.

rebase

Thu, Feb 14, 10:56 AM · efl: api
zmike added a comment to T7584: efl.canvas.scene.

seats method is not implemented by anything at present btw.

Thu, Feb 14, 10:10 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7584: efl.canvas.scene.

Seems fine.

Thu, Feb 14, 9:53 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7584: efl.canvas.scene.

The lack of docs seems to be the main issue here. I am not very convinced of exposing smart_objects_calculating and smart_objects_calculate, but the rest seems to be properly related to a canvas scene.

Thu, Feb 14, 9:38 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7584: efl.canvas.scene.

Yeah, I think a lot of this was slapped together a bit hastily.

Thu, Feb 14, 7:38 AM · efl: api, efl (efl-1.22)
zmike added a commit to T7560: efl.gfx.stack: rEFLc2adefd7f29e: Efl.Gfx.Stack: Rename raise and lower.
Thu, Feb 14, 5:58 AM · efl: api, efl (efl-1.22)
zmike closed D7934: Efl.Gfx.Stack: Rename raise and lower.
Thu, Feb 14, 5:57 AM · efl
zmike accepted D7934: Efl.Gfx.Stack: Rename raise and lower.

"bring to front"
"send to back"
which is same with EVIL's PowerPoint.
Please never mind. :-P

Thu, Feb 14, 5:57 AM · efl
zmike closed D7925: efl_ui : fix infinite loop in efl_ui_exact model.
Thu, Feb 14, 5:52 AM · efl
zmike accepted D7925: efl_ui : fix infinite loop in efl_ui_exact model.

Thanks! I changed the i declaration to be unsigned int to avoid a signedness compiler warning when landing.

Thu, Feb 14, 5:51 AM · efl
zmike added a comment to T7584: efl.canvas.scene.

seat is a widely used term meaning "group of devices", where a device is the representation of a physical input device. Not sure what you mean by "device ID"; sometimes an int is associated with a device/seat based on arbitrary ordering in the display backend.

Thu, Feb 14, 5:48 AM · efl: api, efl (efl-1.22)

Wed, Feb 13

zmike requested changes to D7934: Efl.Gfx.Stack: Rename raise and lower.

Actually, I'm not sure I like using the word "move" here since that relates to position. What if we use raise_to_top and lower_to_bottom instead to ensure that we're always using terms that correspond to the API. Thoughts?

Wed, Feb 13, 10:51 AM · efl
zmike added a comment to T7584: efl.canvas.scene.

I think device,changed is slightly ambiguously named given that there are also added and removed events; for example, if I hook changed then is that triggered with the other two?

Wed, Feb 13, 8:49 AM · efl: api, efl (efl-1.22)
zmike closed D7923: New entry is added to _ecore_key_grabs even when no key was grabbed..
Wed, Feb 13, 8:39 AM · efl
zmike accepted D7923: New entry is added to _ecore_key_grabs even when no key was grabbed..

Okay, I'll just take care of it. Thx!

Wed, Feb 13, 8:27 AM · efl
zmike added a comment to T7695: create wiki page with unit test docs+diagrams.

Oops. https://phab.enlightenment.org/w/unit_tests/

Wed, Feb 13, 8:06 AM · Restricted Project, efl: docs
zmike created Unit Tests.
Wed, Feb 13, 8:06 AM · Restricted Project
zmike edited the content of Main.
Wed, Feb 13, 8:06 AM
zmike closed D7889: ui.box: implement homogeneous mode.
Wed, Feb 13, 6:23 AM · efl
zmike closed D7463: test/ui_box: add unittest for Efl.Ui.Box.
Wed, Feb 13, 6:23 AM · efl
zmike added a commit to T5487: edje & elm sizing: respect hints & simplify layout api: rEFLb1f280f0c2c3: test/ui_box: add unittest for Efl.Ui.Box.
Wed, Feb 13, 6:23 AM · efl: widgets, Restricted Project
zmike added a commit to T5487: edje & elm sizing: respect hints & simplify layout api: rEFL846492ebd7b8: ui.box: refactor layout_update.
Wed, Feb 13, 6:23 AM · efl: widgets, Restricted Project
zmike closed D7750: ui.box: refactor layout_update.
Wed, Feb 13, 6:23 AM · efl
zmike triaged T7695: create wiki page with unit test docs+diagrams as TODO priority.
Wed, Feb 13, 5:36 AM · Restricted Project, efl: docs
zmike accepted D7463: test/ui_box: add unittest for Efl.Ui.Box.
Wed, Feb 13, 5:32 AM · efl
zmike added a comment to D7463: test/ui_box: add unittest for Efl.Ui.Box.

Perfect, thanks!

Wed, Feb 13, 5:31 AM · efl
zmike requested changes to D7925: efl_ui : fix infinite loop in efl_ui_exact model.

Can you convert this to a for loop to make it a bit more readable? Otherwise seems like a good fix.

Wed, Feb 13, 5:25 AM · efl
zmike added a comment to T7554: efl.canvas.group.

I'm also somewhat confused by the existence of group_member_is, which seems like it exists in order to check whether an object is parented to an event grabber? Otherwise one would just check the object's render_parent property.

Wed, Feb 13, 5:24 AM · efl: api, efl (efl-1.22)
zmike requested changes to D7923: New entry is added to _ecore_key_grabs even when no key was grabbed..
Wed, Feb 13, 5:23 AM · efl
zmike added a comment to D7923: New entry is added to _ecore_key_grabs even when no key was grabbed..

This makes sense. Can you reformat the commit log to be more like

Wed, Feb 13, 5:23 AM · efl
zmike added a comment to T7560: efl.gfx.stack.

To me, move_to_top and move_to_bottom sounds confusing as I would expect them to go all the way down or all the way up.

"All the way up" is the behavior described in the docs:

Raise $obj to the top of its layer. $obj will, then, be the highest one in the layer it belongs to.

I have tried to look at the code to find out what is the REAL behavior of this method, but I got lost. Only Efl.Ui.Win and Efl.Canvas.Vg.Node seem to implement it.

Wed, Feb 13, 5:18 AM · efl: api, efl (efl-1.22)

Tue, Feb 12

zmike added inline comments to D7914: ecore_main: Add ECORE_FD_ALWAYS flag.
Tue, Feb 12, 9:13 AM · efl
zmike added a comment to T7563: efl.gfx.size_hint.

edited because base and step are no longer here

Tue, Feb 12, 7:39 AM · efl: api, efl (efl-1.22)
zmike updated the task description for T7563: efl.gfx.size_hint.
Tue, Feb 12, 7:39 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7554: efl.canvas.group.

Some issues:

  • It feels weird to me that there's no events for this class. At a minimum I would expect member,added and member,removed
  • Why are the methods named add and del when we use add and remove in the rest of efl?
Tue, Feb 12, 7:38 AM · efl: api, efl (efl-1.22)
zmike moved T7558: efl.gfx.entity from Backlog to Evaluating on the efl: api board.
Tue, Feb 12, 7:08 AM · efl: api, efl (efl-1.22)