Page MenuHomePhabricator

eflProject
ActivePublic

Details

Description

Enlightenment Foundation Libraries Project

Recent Activity

Today

stefan_schmidt closed D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used.
Fri, Apr 3, 1:37 AM · efl
stefan_schmidt accepted D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used.

This looks like a good start.

Fri, Apr 3, 1:22 AM · efl
stefan_schmidt accepted D11629: tests/elm: add helper macros for asserting size and position of objects.
Fri, Apr 3, 1:17 AM · efl
stefan_schmidt accepted D11630: tests/elm: add wrapper for forcing manual render in tests.
Fri, Apr 3, 1:15 AM · efl
stefan_schmidt closed D11564: free memory in clipboard notify event and fix clipboard clear event.
Fri, Apr 3, 1:03 AM · efl
stefan_schmidt added a comment to D11368: emile: fix a potentional resource leaking..

@bu5hm4n, @ProhtMeyhet are you happy with the rebased version now?

Fri, Apr 3, 12:36 AM · efl
stefan_schmidt accepted D11632: tests/hover: add behavior tests for elm_hover.
Fri, Apr 3, 12:34 AM · efl
stefan_schmidt accepted D11631: tests/layout: add explicit test for freeze and thaw no-op correctness.
Fri, Apr 3, 12:31 AM · efl

Yesterday

segfaultxavi closed D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 4:02 AM · efl
stefan_schmidt accepted D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 4:00 AM · efl
segfaultxavi updated the diff for D11637: exactness docs: Add docs, fix docs, remove docs.

Take comments into account.

Thu, Apr 2, 3:57 AM · efl
segfaultxavi added a child revision for D11634: exactness: protect against forked calls: D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 3:57 AM · efl
stefan_schmidt closed D11636: ci: travis: switch exactness testing to normal test file.
Thu, Apr 2, 3:53 AM · efl
bu5hm4n accepted D11636: ci: travis: switch exactness testing to normal test file.

Macro feels_good:

Thu, Apr 2, 3:41 AM · efl
stefan_schmidt requested changes to D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 3:38 AM · efl
stefan_schmidt added a comment to D11637: exactness docs: Add docs, fix docs, remove docs.

Thanks for taking the time and making this usable! :-)

Thu, Apr 2, 3:38 AM · efl
segfaultxavi added a comment to D11638: C#: Remove warning about `if constexpr`.

I confirm this patch removes the C++17 warnings I reported, but I'll let somebody else review the code.

Thu, Apr 2, 1:42 AM · efl

Wed, Apr 1

lucas added a comment to D11434: C#: Update C# code-generation to use a new ICustomMarshaler in some string usages that were leaking.

@segfaultxavi D11638 should deal with it.

Wed, Apr 1, 2:29 PM · efl
lucas requested review of D11638: C#: Remove warning about `if constexpr`.
Wed, Apr 1, 2:27 PM · efl
segfaultxavi removed a parent revision for D11637: exactness docs: Add docs, fix docs, remove docs: D11634: exactness: protect against forked calls.
Wed, Apr 1, 10:28 AM · efl
segfaultxavi removed a child revision for D11634: exactness: protect against forked calls: D11637: exactness docs: Add docs, fix docs, remove docs.
Wed, Apr 1, 10:28 AM · efl
Diffusion closed D11634: exactness: protect against forked calls.
Wed, Apr 1, 10:27 AM · efl
segfaultxavi requested review of D11637: exactness docs: Add docs, fix docs, remove docs.
Wed, Apr 1, 9:44 AM · efl
segfaultxavi added a child revision for D11634: exactness: protect against forked calls: D11637: exactness docs: Add docs, fix docs, remove docs.
Wed, Apr 1, 9:44 AM · efl
bu5hm4n added a comment to D11634: exactness: protect against forked calls.

That does also not work, because a eventual execp would overwrite anything in there, that is not in a environmemt variable .

Wed, Apr 1, 8:46 AM · efl
zmike added a comment to D11634: exactness: protect against forked calls.

In that case you should probably have a ecore_fork_reset_callback_add() call to correctly handle forks.

Wed, Apr 1, 8:42 AM · efl
bu5hm4n added a comment to D11634: exactness: protect against forked calls.

@zmike mhm it cannot fix the issue here, as the same might happen theoretically due to evas forking, or efl_net or eio or eeze ... we have a lot places where we do that ...

Wed, Apr 1, 8:39 AM · efl
zmike added a comment to D11634: exactness: protect against forked calls.

efreet_cache_disable() for exactness overall might be a more permanent solution here.

Wed, Apr 1, 8:33 AM · efl
segfaultxavi accepted D11634: exactness: protect against forked calls.

I confirm this fixes my problems with Exactness. Please land.

Wed, Apr 1, 8:31 AM · efl
bu5hm4n added reviewers for D11634: exactness: protect against forked calls: stefan_schmidt, segfaultxavi, zmike.
Wed, Apr 1, 8:24 AM · efl
bu5hm4n updated the diff for D11634: exactness: protect against forked calls.

this time a working possibility

Wed, Apr 1, 8:24 AM · efl
stefan_schmidt added a reviewer for D11636: ci: travis: switch exactness testing to normal test file: bu5hm4n.
Wed, Apr 1, 6:34 AM · efl
stefan_schmidt requested review of D11636: ci: travis: switch exactness testing to normal test file.
Wed, Apr 1, 6:33 AM · efl
ali.alzyod closed T8637: evas_textblock : segmentation fault when using markup set with <ps> as Resolved.
Wed, Apr 1, 5:56 AM · efl
netstar abandoned D11635: elm_naviframe: Do not pop top item if top item..

Thanks guys.

Wed, Apr 1, 5:48 AM · efl
netstar updated subscribers of D11635: elm_naviframe: Do not pop top item if top item..

@Jaehyun Is that a feature or a miracle? It works here. @bu5hm4n probably a good idea, the solution is a bit tricky and could do with being documented.

Wed, Apr 1, 5:40 AM · efl
Jaehyun_Cho added a comment to D11635: elm_naviframe: Do not pop top item if top item..

I think that if EDI's wizard registers pop_cb and does nothing in pop_cb and returns EINA_FALSE in the pop_cb, then the last item is not popped.

Wed, Apr 1, 3:47 AM · efl
bu5hm4n added a comment to D11635: elm_naviframe: Do not pop top item if top item..

While i agree with @Jaehyun_Cho what do you think of adding a flag to enable that feature ? The feature itself sounds usefull to me :)

Wed, Apr 1, 3:44 AM · efl
Jaehyun_Cho requested changes to D11635: elm_naviframe: Do not pop top item if top item..

I think this patch breaks the backward compatibility.
Because users can register their own pop_cb by using elm_naviframe_item_pop_cb_set().
So if the popped item is the last item, then users' pop_cb is called and elm_win or something is deleted manually in the pop_cb.
However, this patch do not allow pop_cb is called if the popped item is the last item.
So I think this patch should not be accepted.

Wed, Apr 1, 3:42 AM · efl
netstar requested review of D11635: elm_naviframe: Do not pop top item if top item..
Wed, Apr 1, 3:29 AM · efl
bu5hm4n updated the diff for D11634: exactness: protect against forked calls.

git add -p mistake

Wed, Apr 1, 3:15 AM · efl
bu5hm4n requested review of D11634: exactness: protect against forked calls.
Wed, Apr 1, 3:02 AM · efl

Tue, Mar 31

kimcinoo abandoned D11626: support density independent pixel.

@devilhorns thanks for your review, but I would like to abandon this patch.

Tue, Mar 31, 9:54 PM · efl
zmike requested review of D11632: tests/hover: add behavior tests for elm_hover.
Tue, Mar 31, 10:02 AM · efl
zmike added a child revision for D11631: tests/layout: add explicit test for freeze and thaw no-op correctness: D11632: tests/hover: add behavior tests for elm_hover.
Tue, Mar 31, 10:02 AM · efl
zmike requested review of D11631: tests/layout: add explicit test for freeze and thaw no-op correctness.
Tue, Mar 31, 10:02 AM · efl
zmike added a child revision for D11630: tests/elm: add wrapper for forcing manual render in tests: D11631: tests/layout: add explicit test for freeze and thaw no-op correctness.
Tue, Mar 31, 10:02 AM · efl
zmike requested review of D11630: tests/elm: add wrapper for forcing manual render in tests.
Tue, Mar 31, 10:01 AM · efl
zmike added a child revision for D11629: tests/elm: add helper macros for asserting size and position of objects: D11630: tests/elm: add wrapper for forcing manual render in tests.
Tue, Mar 31, 10:01 AM · efl
zmike requested review of D11629: tests/elm: add helper macros for asserting size and position of objects.
Tue, Mar 31, 10:01 AM · efl