Enlightenment Foundation Libraries Project
here comes a test
Have you verified that this test fails without the corresponding library changes?
Example unit test: copy the elm_test ui, feed mouse position to be over the slider, attempt to trigger wheel motion and then fail if scroller callbacks trigger.
I think so! but let's hear @Jaehyun_Cho's opinion, since he created the ticket.
OK, got it. Using the scrollwheel on a scroller full of sliders is still a dangerous business, but it makes a bit more sense this way.
I cannot review the changes, though, you should add some reviewers :)
Can we continue this discussion in the original thread? D7495#152500
As constructors now accept parameters, could this be marked as done?
Its hard to impossible to test this commit. It just holds the scrollers while the mouse is over a slider. there is no example to particulary verify this single commit.
I do not understand what do I need to test here. Can you point me to an example like elementary_test?
update commit message
And its actaully a bug fix ... :)
Just take a look into the referenced task
Can you explain how can I verify this patch? What is the problem being fixed?
Looks like an optimization PLUS an event was missing?
Okay, i don't know whatever commit in this stack caused this, but now my testsuite fails with: ../src/tests/elementary/elm_test_fileselector.c:135:F:elm_fileselector:elm_fileselector_selected:0: Assertion 'elm_fileselector_selected_get(fileselector) == exist' failed: elm_fileselector_selected_get(fileselector) == "/tmp/elm_test-bQ9btE", exist == "/tmp/elm_test-bQ9btE/exist"
Given that we are heading from one *deepshit* issue into the next, i will just closed eye approve this, given that the appearance before the commits is the same just with a lots more errors.
clean up code.
clean up code
clean up code.
Thanks a lot! :)
The reason i did not review this earlier was, that there was a open question from you to jsuyu, can you next time clarify that his concerns have been met or they have been invalid, I did not want to land this before this questions have been addressed / clarified. Thank you :)