Page MenuHomePhabricator

eflProject
ActivePublic

Details

Description

Enlightenment Foundation Libraries Project

Recent Activity

Yesterday

vtorri added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

Everything seems fine, but just to be sure, is there a real need to include evil_api.h at evil_stdlib.h and evil_dlfcn.h as it is already included at evil_private.h?

For me, it seems that including it only on evil_private.h would fit EFL's private header inclusion standard better.

It is better that when you use something, you include it. So modifications in other parts of the headers won't break something else. Just like you may get away with using size_t without include'ing stddef.h, but it is a good practice to include it anwyay.

Sun, Oct 25, 12:45 PM · efl

Fri, Oct 23

ProhtMeyhet added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

I took the liberty to correct your code quotation in your post. Please watch out in the future for this.

Fri, Oct 23, 4:37 PM · efl
ProhtMeyhet updated the summary of D12182: evil: Rename EAPI macro to EVIL_API in Evil library.
Fri, Oct 23, 4:36 PM · efl
felipealmeida added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

Everything seems fine, but just to be sure, is there a real need to include evil_api.h at evil_stdlib.h and evil_dlfcn.h as it is already included at evil_private.h?

For me, it seems that including it only on evil_private.h would fit EFL's private header inclusion standard better.

Fri, Oct 23, 10:56 AM · efl
lucas added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

Everything seems fine, but just to be sure, is there a real need to include evil_api.h at evil_stdlib.h and evil_dlfcn.h as it is already included at evil_private.h?

Fri, Oct 23, 10:02 AM · efl

Wed, Oct 21

ali.alzyod accepted D12183: evas/textblock: apply style paddings in fit calculation.

This is right

Wed, Oct 21, 8:47 PM · efl
thierry1970 added a comment to D12135: Added the heif loader.

Sorry, I didn't see your answer.
I don't receive notifications anymore, despite the settings.

Wed, Oct 21, 7:52 AM · efl
thierry1970 updated the diff for D12135: Added the heif loader.
  • Disabled by default heif loaders
  • Add readme section Heif
Wed, Oct 21, 7:50 AM · efl
EndlessEden created T8843: BUG: EFL - ecore_fb: efl fails to build when both tslib and fb(fbcon) are enabled..
Wed, Oct 21, 5:40 AM · Restricted Project

Tue, Oct 20

woohyun accepted D12183: evas/textblock: apply style paddings in fit calculation.

I think this looks proper modification.

Tue, Oct 20, 10:48 PM · efl
id213sin added a reviewer for D12183: evas/textblock: apply style paddings in fit calculation: ali.alzyod.
Tue, Oct 20, 10:05 PM · efl
id213sin requested review of D12183: evas/textblock: apply style paddings in fit calculation.
Tue, Oct 20, 10:04 PM · efl
felipealmeida updated the diff for D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

Change EVIL_API if/else preprocessor directives to have less indentation

Tue, Oct 20, 11:05 AM · efl
felipealmeida added inline comments to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.
Tue, Oct 20, 7:44 AM · efl
felipealmeida added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

something like

#define EFLAPI(EFLLIB) \
#ifdef _WIN32 \

  1. ifndef EFLLIB_STATIC \ etc...
Tue, Oct 20, 7:42 AM · efl
vtorri added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

something like

Tue, Oct 20, 7:34 AM · efl
felipealmeida added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

do you think that, if evil_api.h and eina_api.h are the same, we could write a macro efl_api(LIB) and we replace LIB with EVIL, EINA etc... ?

Tue, Oct 20, 7:27 AM · efl
ali.alzyod closed T8663: Entry & UI Text : Fixing Cursor movement with Emoji for text as Resolved.
Tue, Oct 20, 3:46 AM · efl
woohyun closed T8666: UI Text : Fixing cursor movement with emoji using keyboard arrows/mouse click as Resolved by committing rEFLd6a6dd54a13b: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.
Tue, Oct 20, 3:31 AM · efl
woohyun closed T8666: UI Text : Fixing cursor movement with emoji using keyboard arrows/mouse click, a subtask of T8663: Entry & UI Text : Fixing Cursor movement with Emoji for text, as Resolved.
Tue, Oct 20, 3:31 AM · efl
woohyun closed D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.
Tue, Oct 20, 3:31 AM · efl
woohyun accepted D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

This also seems ok for me :)

Tue, Oct 20, 3:21 AM · efl
ali.alzyod updated the diff for D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

rebase

Tue, Oct 20, 3:18 AM · efl

Mon, Oct 19

vtorri added a comment to D12182: evil: Rename EAPI macro to EVIL_API in Evil library.

do you think that, if evil_api.h and eina_api.h are the same, we could write a macro efl_api(LIB) and we replace LIB with EVIL, EINA etc... ?

Mon, Oct 19, 11:12 PM · efl
felipealmeida abandoned D11993: eina: Change EAPI to EINA_API in Eina Library.
Mon, Oct 19, 8:21 PM · efl
felipealmeida requested review of D12182: evil: Rename EAPI macro to EVIL_API in Evil library.
Mon, Oct 19, 8:18 PM · efl
felipealmeida abandoned D12181: evil: Rename EAPI macro to EVIL_API in Evil library.
Mon, Oct 19, 8:15 PM · efl
felipealmeida requested review of D12181: evil: Rename EAPI macro to EVIL_API in Evil library.
Mon, Oct 19, 8:14 PM · efl

Thu, Oct 15

lucas requested review of D12180: CI: Enable unity tests at MacOS CI.
Thu, Oct 15, 6:54 AM · efl
lucas added a child revision for D12157: efl_mono: Use architecture independent ECANCELED: D12180: CI: Enable unity tests at MacOS CI.
Thu, Oct 15, 6:54 AM · efl

Wed, Oct 14

Thanatermesis closed T8836: Efreet icon cache & eina segfault as Invalid.
Wed, Oct 14, 9:40 AM · efl
Hermet closed D12179: vg_load_svg: Implement ClipPath feature.
Wed, Oct 14, 3:18 AM · efl
Hermet accepted D12179: vg_load_svg: Implement ClipPath feature.
Wed, Oct 14, 2:20 AM · efl

Tue, Oct 13

jsuya updated the diff for D12179: vg_load_svg: Implement ClipPath feature.

modify code

Tue, Oct 13, 7:07 PM · efl
jsuya updated the test plan for D12179: vg_load_svg: Implement ClipPath feature.
Tue, Oct 13, 7:05 PM · efl
jsuya requested review of D12179: vg_load_svg: Implement ClipPath feature.
Tue, Oct 13, 7:04 PM · efl
vtorri closed T8833: Windows: States test fails as Resolved.
Tue, Oct 13, 7:30 AM · efl
vtorri closed T8833: Windows: States test fails, a subtask of T8825: Windows bugs to fix, as Resolved.
Tue, Oct 13, 7:30 AM · efl
vtorri added a comment to T8833: Windows: States test fails.

D12177 fixes the (un)maximize bug

Tue, Oct 13, 7:29 AM · efl
raster closed D12177: Ecore_Win32: add the API ecore_win32_window_maximized_set().
Tue, Oct 13, 7:24 AM · efl
raster closed D12176: Ecore_Evas win32: fix activate() function.
Tue, Oct 13, 7:24 AM · efl
raster accepted D12177: Ecore_Win32: add the API ecore_win32_window_maximized_set().
Tue, Oct 13, 7:23 AM · efl
vtorri added a comment to T8783: eina_file_test: unlink test may fail due to tmpfile is already open.

@jptiz normally it is fixed in git. See eacee53c2e795a1c5e187558ccced2d66390d761
At least, it works on my computer

Tue, Oct 13, 7:06 AM · efl
lucas added a comment to D12157: efl_mono: Use architecture independent ECANCELED.

Correct ECANCELED code for Windows

It, actually, is 105.

Please update the comment as well.

/// Returns 125 for Linux and 89 for OSX
Tue, Oct 13, 5:05 AM · efl
lucas updated the diff for D12157: efl_mono: Use architecture independent ECANCELED.

Update summary description

Tue, Oct 13, 5:03 AM · efl
CHAN abandoned D12178: eina_value: Fix memory leak..

False alarm in macro.

Tue, Oct 13, 1:40 AM · efl

Mon, Oct 12

vtorri added inline comments to D12178: eina_value: Fix memory leak..
Mon, Oct 12, 10:45 PM · efl
CHAN added reviewers for D12178: eina_value: Fix memory leak.: cedric, raster, Hermet.
Mon, Oct 12, 10:26 PM · efl
CHAN requested review of D12178: eina_value: Fix memory leak..
Mon, Oct 12, 10:26 PM · efl
vtorri abandoned D12168: Evil: add native mkstemp.

rework this in D12170

Mon, Oct 12, 7:03 AM · efl