Page MenuHomePhabricator

eflProject
ActivePublic

Details

Description

Enlightenment Foundation Libraries Project

Recent Activity

Today

bu5hm4n updated the diff for D8456: efl_scroll: do not eat wheel events.

here comes a test

Mon, Mar 25, 9:38 AM · efl
bu5hm4n added a comment to D8455: efl_ui_slider: block scrolling when on slider.

yes.

Mon, Mar 25, 9:21 AM · efl
zmike added a comment to D8455: efl_ui_slider: block scrolling when on slider.

Have you verified that this test fails without the corresponding library changes?

Mon, Mar 25, 9:17 AM · efl
bu5hm4n updated the diff for D8455: efl_ui_slider: block scrolling when on slider.

added testcase

Mon, Mar 25, 9:15 AM · efl
zmike closed D8460: meson build : remove duplicate check of dirent.h.
Mon, Mar 25, 7:11 AM · efl
zmike closed D8453: meson build : remove duplicate check of strerror_r.
Mon, Mar 25, 7:11 AM · efl
zmike accepted D8460: meson build : remove duplicate check of dirent.h.
Mon, Mar 25, 7:10 AM · efl
zmike accepted D8453: meson build : remove duplicate check of strerror_r.
Mon, Mar 25, 7:09 AM · efl
zmike added a comment to D8455: efl_ui_slider: block scrolling when on slider.

Example unit test: copy the elm_test ui, feed mouse position to be over the slider, attempt to trigger wheel motion and then fail if scroller callbacks trigger.

Mon, Mar 25, 6:09 AM · efl
bu5hm4n added reviewers for D8455: efl_ui_slider: block scrolling when on slider: zmike, cedric, segfaultxavi.
Mon, Mar 25, 6:04 AM · efl
bu5hm4n added reviewers for D8456: efl_scroll: do not eat wheel events: zmike, cedric, stefan_schmidt.
Mon, Mar 25, 6:03 AM · efl
zmike closed D8462: elm_entry: fix a bug in moving the magnifier.
Mon, Mar 25, 5:52 AM · efl
zmike accepted D8462: elm_entry: fix a bug in moving the magnifier.
Mon, Mar 25, 5:51 AM · efl
segfaultxavi added a comment to T7375: Support widget styles in C# bindings.

I think so! but let's hear @Jaehyun_Cho's opinion, since he created the ticket.

Mon, Mar 25, 4:18 AM · efl
segfaultxavi added a comment to D8456: efl_scroll: do not eat wheel events.

OK, got it. Using the scrollwheel on a scroller full of sliders is still a dangerous business, but it makes a bit more sense this way.
I cannot review the changes, though, you should add some reviewers :)

Mon, Mar 25, 4:16 AM · efl
segfaultxavi added a comment to D8463: efl_mono: move enum Components out of Csharp namespace.

Can we continue this discussion in the original thread? D7495#152500

Mon, Mar 25, 3:48 AM · efl
lauromoura added a comment to T7375: Support widget styles in C# bindings.

As constructors now accept parameters, could this be marked as done?

Mon, Mar 25, 3:45 AM · efl
Hermet added a reviewer for D8465: efl_ui_textpath : enable anti-alising for better quality.: committers.
Mon, Mar 25, 3:41 AM · efl
Hermet requested review of D8465: efl_ui_textpath : enable anti-alising for better quality..
Mon, Mar 25, 3:40 AM · efl
Hermet added a child revision for D8106: canvas map: introduce a new texture mapping for better quality.: D8465: efl_ui_textpath : enable anti-alising for better quality..
Mon, Mar 25, 3:40 AM · efl
bu5hm4n added a comment to D8455: efl_ui_slider: block scrolling when on slider.

Its hard to impossible to test this commit. It just holds the scrollers while the mouse is over a slider. there is no example to particulary verify this single commit.

Mon, Mar 25, 3:39 AM · efl
Diffusion closed D8464: elm_win: fix correct rot variable in elm_win_rotation_get.
Mon, Mar 25, 3:36 AM · efl
bu5hm4n accepted D8464: elm_win: fix correct rot variable in elm_win_rotation_get.

Nice catch!

Mon, Mar 25, 3:35 AM · efl
segfaultxavi added a comment to D8455: efl_ui_slider: block scrolling when on slider.

I do not understand what do I need to test here. Can you point me to an example like elementary_test?

Mon, Mar 25, 3:34 AM · efl
YOhoho updated the diff for D8464: elm_win: fix correct rot variable in elm_win_rotation_get.

update commit message

Mon, Mar 25, 3:33 AM · efl
bu5hm4n added a comment to D8456: efl_scroll: do not eat wheel events.

And its actaully a bug fix ... :)

Mon, Mar 25, 3:32 AM · efl
bu5hm4n added a comment to D8456: efl_scroll: do not eat wheel events.

Just take a look into the referenced task

Mon, Mar 25, 3:32 AM · efl
YOhoho requested review of D8464: elm_win: fix correct rot variable in elm_win_rotation_get.
Mon, Mar 25, 3:31 AM · efl
segfaultxavi added a comment to D8456: efl_scroll: do not eat wheel events.

Can you explain how can I verify this patch? What is the problem being fixed?
Looks like an optimization PLUS an event was missing?

Mon, Mar 25, 3:30 AM · efl
bu5hm4n requested changes to D8450: elementary: make sure that the model parent being used is always the fileselector..

Okay, i don't know whatever commit in this stack caused this, but now my testsuite fails with: ../src/tests/elementary/elm_test_fileselector.c:135:F:elm_fileselector:elm_fileselector_selected:0: Assertion 'elm_fileselector_selected_get(fileselector) == exist' failed: elm_fileselector_selected_get(fileselector) == "/tmp/elm_test-bQ9btE", exist == "/tmp/elm_test-bQ9btE/exist"

Mon, Mar 25, 3:30 AM · efl
bu5hm4n accepted D8450: elementary: make sure that the model parent being used is always the fileselector..
Mon, Mar 25, 3:25 AM · efl
bu5hm4n accepted D8449: elementary: prevent asynchronous properties change to believe target is ready when it is not in fileselector..
Mon, Mar 25, 3:25 AM · efl
bu5hm4n accepted D8448: elementary: fix fileselector entry support to define path manually..
Mon, Mar 25, 3:24 AM · efl
bu5hm4n accepted D8447: eio: guarantee that we will at least process one request per loop iteration for very slow system..
Mon, Mar 25, 3:24 AM · efl
bu5hm4n accepted D8375: elementary: destroy fileselector children when they are not itemized yet..
Mon, Mar 25, 3:23 AM · efl
bu5hm4n accepted D8336: elementary: improve lifecycle of model object in the fileselector widget..
Mon, Mar 25, 3:23 AM · efl
bu5hm4n added a comment to D8336: elementary: improve lifecycle of model object in the fileselector widget..

Given that we are heading from one *deepshit* issue into the next, i will just closed eye approve this, given that the appearance before the commits is the same just with a lots more errors.

Mon, Mar 25, 3:23 AM · efl
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..

clean up code.

Mon, Mar 25, 3:10 AM · efl
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..

clean up code

Mon, Mar 25, 3:09 AM · efl
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..

clean up code.

Mon, Mar 25, 3:07 AM · efl
Diffusion closed D8461: efl_ui_container_layout: use correct property.
Mon, Mar 25, 2:58 AM · efl
bu5hm4n accepted D8461: efl_ui_container_layout: use correct property.

Thanks a lot! :)

Mon, Mar 25, 2:58 AM · efl
YOhoho updated the diff for D8461: efl_ui_container_layout: use correct property.

incorrect :(

Mon, Mar 25, 2:56 AM · efl
Diffusion closed D8367: elm_gengrid: speed up update order calls.
Mon, Mar 25, 2:54 AM · efl
Diffusion closed D8366: elm_gengrid: rework focus registration.
Mon, Mar 25, 2:54 AM · efl
bu5hm4n removed a child revision for D8365: meson: do not set max log level: D8366: elm_gengrid: rework focus registration.
Mon, Mar 25, 2:50 AM · efl
bu5hm4n removed a parent revision for D8366: elm_gengrid: rework focus registration: D8365: meson: do not set max log level.
Mon, Mar 25, 2:50 AM · efl
bu5hm4n added inline comments to D8461: efl_ui_container_layout: use correct property.
Mon, Mar 25, 2:42 AM · efl
shilpasingh closed D8427: efl_access: add test cases for reading_info_type_set/get API.
Mon, Mar 25, 2:42 AM · efl
bu5hm4n added a comment to D8427: efl_access: add test cases for reading_info_type_set/get API.

The reason i did not review this earlier was, that there was a open question from you to jsuyu, can you next time clarify that his concerns have been met or they have been invalid, I did not want to land this before this questions have been addressed / clarified. Thank you :)

Mon, Mar 25, 2:41 AM · efl