Page MenuHomePhabricator

eflProject
ActivePublic

Details

Description

Enlightenment Foundation Libraries Project

Recent Activity

Today

felipealmeida requested review of D7637: efl-mono: Enable selecting to build @beta items.
Tue, Jan 15, 8:29 PM · efl
felipealmeida requested review of D7636: eolian-mono: Add interface registration to inherited classes.
Tue, Jan 15, 8:00 PM · efl
felipealmeida added a parent revision for D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces: D7634: efl-mono: Add proper test for interface inheritance.
Tue, Jan 15, 7:56 PM · efl
felipealmeida added a child revision for D7634: efl-mono: Add proper test for interface inheritance: D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces.
Tue, Jan 15, 7:56 PM · efl
felipealmeida requested review of D7636: eolian-mono: Add interface registration to inherited classes.
Tue, Jan 15, 7:55 PM · efl
felipealmeida added a child revision for D7634: efl-mono: Add proper test for interface inheritance: D7636: eolian-mono: Add interface registration to inherited classes.
Tue, Jan 15, 7:55 PM · efl
felipealmeida added a child revision for D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces: D7636: eolian-mono: Add interface registration to inherited classes.
Tue, Jan 15, 7:55 PM · efl
felipealmeida requested review of D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces.
Tue, Jan 15, 7:52 PM · efl
felipealmeida requested review of D7634: efl-mono: Add proper test for interface inheritance.
Tue, Jan 15, 7:50 PM · efl
felipealmeida requested review of D7633: eolian-cxx: Fix order of initialization.
Tue, Jan 15, 7:37 PM · efl
cedric added inline comments to D7529: efl_ui : rename model connect and factory connect to bind property and factory..
Tue, Jan 15, 7:19 PM · efl
felipealmeida closed D7613: efl-mono: Remove trailings from template file.
Tue, Jan 15, 7:02 PM · efl
SanghyeonLee added inline comments to D7529: efl_ui : rename model connect and factory connect to bind property and factory..
Tue, Jan 15, 6:46 PM · efl
cedric added inline comments to D7529: efl_ui : rename model connect and factory connect to bind property and factory..
Tue, Jan 15, 6:37 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

well about those thing,
we need more detail explain about @felipealmeida , so I'll request his comment when he come to the office :)
but felipe was on the side of not using dynamic class...
okay I stop to update the patch for now...
and let's get clear conclusion regarding this matter.

Tue, Jan 15, 6:25 PM · efl
jsuya requested review of D7632: Elm_Animation_View : Move some EAPI to EOAPI.
Tue, Jan 15, 6:22 PM · efl
cedric added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

can you check the efl_ui_property.eo?
about the factory,
we all know the purpose of factory bind, so it need to be called always these two API as the pair.
so why not making it one API?
porperty bind will be internally handled.

Tue, Jan 15, 6:21 PM · efl
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

hmm... yeah I agreed with that. so I'll update the patch with making it inherit from layout.

Tue, Jan 15, 6:16 PM · efl
cedric added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

we do this because,
factory.icon.bind_factory(imgf);
is unable with current list item factory design.

factory cannot distinguish Efl.Part depending on each item classes,
so we vote the way and we drop it as I remembered in the Efl.Part task.

Tue, Jan 15, 6:14 PM · efl
cedric added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

Actually I thought that we might need to remove layout factory cause I cannot find any case of using it till now, but still you think it is necessary, I can go with your idea.
but we have to think about maintaining one more class which may not often used.... if you can find any use case, it should be left.

Tue, Jan 15, 6:09 PM · efl
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

Actually I thought that we might need to remove layout factory cause I cannot find any case of using it till now, but still you think it is necessary, I can go with your idea.
but we have to think about maintaining one more class which may not often used.... if you can find any use case, it should be left.

Tue, Jan 15, 5:40 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

we do this because,
factory.icon.bind_factory(imgf);
is unable with current list item factory design.

Tue, Jan 15, 5:33 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

can you check the efl_ui_property.eo?
about the factory,
we all know the purpose of factory bind, so it need to be called always these two API as the pair.
so why not making it one API?
porperty bind will be internally handled.

Tue, Jan 15, 5:30 PM · efl
Hermet closed D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.
Tue, Jan 15, 5:28 PM · efl
Hermet accepted D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.
Tue, Jan 15, 5:28 PM · efl
SanghyeonLee updated the diff for D7529: efl_ui : rename model connect and factory connect to bind property and factory..

proposal interface eo.
the code is not working yet.
If property_bind_part is too ambigiuous, we can go with property_bind_text.

Tue, Jan 15, 5:27 PM · efl
cedric added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

and.. about

efl_ui_bind_property(imgf, "", "path"); //connect to "path" property
efl_ui_bind_factory(factory, "efl.icon", imgf);

we could make it one line calls,
efl_ui_property_bind_factory(factory, "efl.icon", "path", imgf);
the goal is alway bind the property data with given subfactory and sawllow in the content, so I think make it one line is more natural I think.
any opinion?

Tue, Jan 15, 5:15 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

and.. about

efl_ui_bind_property(imgf, "", "path"); //connect to "path" property
efl_ui_bind_factory(factory, "efl.icon", imgf);
Tue, Jan 15, 5:00 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

@cedric I know its same but we can have this specific function for explicit declaring on Efl.Part controls. so this will let user/widget both understand what action will happen by API calls.
if you not a fan of this idea, okay, I can drop it.

Tue, Jan 15, 4:54 PM · efl
SanghyeonLee updated the diff for D7529: efl_ui : rename model connect and factory connect to bind property and factory..

rebase the patch with resolving merge conflict.
this patch need to be fixed yet.

Tue, Jan 15, 4:42 PM · efl
cedric added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

@cedric that's true but I wonder we still need to maintain layout_factory or not. do we need it?

Tue, Jan 15, 4:37 PM · efl
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

and also need to fix few thing in the view... it still using layout terms and class so it need to be changed Efl.Ui.Item as I see.. will be updated soon.

Tue, Jan 15, 4:33 PM · efl
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

@cedric that's true but I wonder we still need to maintain layout_factory or not. do we need it?
and also some style set and size calculation will be different, so I don't know we can solve this with calling efl_super...
layout factory may need to be fixed too then.

Tue, Jan 15, 4:15 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

rebasing patch

Tue, Jan 15, 4:12 PM · efl
raster added a comment to D7351: elm_config: remove profile name reading logic from data dir.

this never should have even passed review. it's obviously wrong - the code path is used. a simple look at the for loop being removed would have shown that

Tue, Jan 15, 12:47 PM · efl
ManMower closed D7622: focus_manager: fix memory leaks.
Tue, Jan 15, 11:48 AM · efl
ManMower closed D7621: edje: Remove _edje_animators list.
Tue, Jan 15, 11:48 AM · efl
ManMower closed D7611: evas_render: Remove some list walks.
Tue, Jan 15, 11:47 AM · efl
ManMower closed D7610: ecore_wl2: Convert frame callbacks to inlist.
Tue, Jan 15, 11:47 AM · efl
ManMower closed D7609: ecore_evas: Don't walk mice list twice.
Tue, Jan 15, 11:47 AM · efl
zmike added a task to D7409: gfx: Add size hint fill (EO): T3912: Box align : does not align if children set max hint.
Tue, Jan 15, 10:48 AM · efl
cedric requested changes to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Tue, Jan 15, 10:24 AM · efl
cedric added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

interface : Efl.Ui.Property
: property_bind; generic function for binding property with input key string.
: property_bind_part : binding property with given Efl.Part.
: property_bind_signal : binding property with given signal string, and emit the signal when model ready.
: property_bind_factory : binding property with given factory and create object by factory and swallow in gvien Efl.part.

go this way?

Tue, Jan 15, 10:18 AM · efl
bu5hm4n requested review of D7630: eolian_gen: void out keys depending on how they are setted.
Tue, Jan 15, 9:16 AM · efl
bu5hm4n closed D7601: evas: make efl_canvas_animation abstract.
Tue, Jan 15, 8:39 AM · efl
Diffusion closed D7600: evas: make efl_canvas_group abstract.
Tue, Jan 15, 8:38 AM · efl
Diffusion closed D7599: ecore: make efl_loop_consumer abstract.
Tue, Jan 15, 8:38 AM · efl
bu5hm4n requested review of D7629: eolian: add free functions for the array and future..
Tue, Jan 15, 8:33 AM · efl
bu5hm4n added a child revision for D7628: eolian: there is no eina_inlist_free: D7629: eolian: add free functions for the array and future..
Tue, Jan 15, 8:32 AM · efl
bu5hm4n requested review of D7628: eolian: there is no eina_inlist_free.
Tue, Jan 15, 8:32 AM · efl