Enlightenment Foundation Libraries Project
Details
Details
Description
Today
Today
bu5hm4n updated the diff for D8456: efl_scroll: do not eat wheel events.
here comes a test
bu5hm4n added a comment to D8455: efl_ui_slider: block scrolling when on slider.
yes.
zmike added a comment to D8455: efl_ui_slider: block scrolling when on slider.
Have you verified that this test fails without the corresponding library changes?
bu5hm4n updated the diff for D8455: efl_ui_slider: block scrolling when on slider.
added testcase
zmike added a comment to D8455: efl_ui_slider: block scrolling when on slider.
Example unit test: copy the elm_test ui, feed mouse position to be over the slider, attempt to trigger wheel motion and then fail if scroller callbacks trigger.
bu5hm4n added reviewers for D8455: efl_ui_slider: block scrolling when on slider: zmike, cedric, segfaultxavi.
bu5hm4n added reviewers for D8456: efl_scroll: do not eat wheel events: zmike, cedric, stefan_schmidt.
segfaultxavi added a comment to T7375: Support widget styles in C# bindings.
I think so! but let's hear @Jaehyun_Cho's opinion, since he created the ticket.
segfaultxavi added a comment to D8456: efl_scroll: do not eat wheel events.
OK, got it. Using the scrollwheel on a scroller full of sliders is still a dangerous business, but it makes a bit more sense this way.
I cannot review the changes, though, you should add some reviewers :)
segfaultxavi added a comment to D8463: efl_mono: move enum Components out of Csharp namespace.
Can we continue this discussion in the original thread? D7495#152500
lauromoura added a comment to T7375: Support widget styles in C# bindings.
As constructors now accept parameters, could this be marked as done?
Hermet added a reviewer for D8465: efl_ui_textpath : enable anti-alising for better quality.: committers.
Hermet requested review of D8465: efl_ui_textpath : enable anti-alising for better quality..
bu5hm4n added a comment to D8455: efl_ui_slider: block scrolling when on slider.
Its hard to impossible to test this commit. It just holds the scrollers while the mouse is over a slider. there is no example to particulary verify this single commit.
Nice catch!
segfaultxavi added a comment to D8455: efl_ui_slider: block scrolling when on slider.
I do not understand what do I need to test here. Can you point me to an example like elementary_test?
YOhoho updated the diff for D8464: elm_win: fix correct rot variable in elm_win_rotation_get.
update commit message
bu5hm4n added a comment to D8456: efl_scroll: do not eat wheel events.
And its actaully a bug fix ... :)
bu5hm4n added a comment to D8456: efl_scroll: do not eat wheel events.
Just take a look into the referenced task
YOhoho requested review of D8464: elm_win: fix correct rot variable in elm_win_rotation_get.
segfaultxavi added a comment to D8456: efl_scroll: do not eat wheel events.
Can you explain how can I verify this patch? What is the problem being fixed?
Looks like an optimization PLUS an event was missing?
bu5hm4n requested changes to D8450: elementary: make sure that the model parent being used is always the fileselector..
Okay, i don't know whatever commit in this stack caused this, but now my testsuite fails with: ../src/tests/elementary/elm_test_fileselector.c:135:F:elm_fileselector:elm_fileselector_selected:0: Assertion 'elm_fileselector_selected_get(fileselector) == exist' failed: elm_fileselector_selected_get(fileselector) == "/tmp/elm_test-bQ9btE", exist == "/tmp/elm_test-bQ9btE/exist"
bu5hm4n added a comment to D8336: elementary: improve lifecycle of model object in the fileselector widget..
Given that we are heading from one *deepshit* issue into the next, i will just closed eye approve this, given that the appearance before the commits is the same just with a lots more errors.
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..
clean up code.
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..
clean up code
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..
clean up code.
Thanks a lot! :)
YOhoho updated the diff for D8461: efl_ui_container_layout: use correct property.
incorrect :(
bu5hm4n removed a child revision for D8365: meson: do not set max log level: D8366: elm_gengrid: rework focus registration.
bu5hm4n removed a parent revision for D8366: elm_gengrid: rework focus registration: D8365: meson: do not set max log level.
bu5hm4n added inline comments to D8461: efl_ui_container_layout: use correct property.
bu5hm4n added a comment to D8427: efl_access: add test cases for reading_info_type_set/get API.
The reason i did not review this earlier was, that there was a open question from you to jsuyu, can you next time clarify that his concerns have been met or they have been invalid, I did not want to land this before this questions have been addressed / clarified. Thank you :)