Page MenuHomePhabricator

efl: renderingProject
ActivePublic

Watchers

  • This project does not have any watchers.

Details

Description

basic canvas operations and rendering mechanisms

Recent Activity

Thu, Aug 8

cedric closed D8841: evas/render: clamp mask surface size to clipper size.
Thu, Aug 8, 6:32 PM · efl: rendering
cedric closed D8887: evas: add 'has_fixed_size' property for canvas objects.
Thu, Aug 8, 6:32 PM · efl: rendering
cedric accepted D8887: evas: add 'has_fixed_size' property for canvas objects.
Thu, Aug 8, 4:13 PM · efl: rendering

Tue, Jul 30

segfaultxavi added a comment to D8887: evas: add 'has_fixed_size' property for canvas objects.

ping?

Tue, Jul 30, 3:05 AM · efl: rendering

Jul 18 2019

segfaultxavi resigned from D8887: evas: add 'has_fixed_size' property for canvas objects.

I have no further complains regarding documentation. Was the code ever reviewed? @Hermet ?

Jul 18 2019, 9:30 AM · efl: rendering
zmike updated the diff for D8887: evas: add 'has_fixed_size' property for canvas objects.

reword

Jul 18 2019, 9:28 AM · efl: rendering
segfaultxavi requested changes to D8887: evas: add 'has_fixed_size' property for canvas objects.
Jul 18 2019, 8:28 AM · efl: rendering
zmike added a child revision for D8841: evas/render: clamp mask surface size to clipper size: D8881: evas/render: size and draw proxy render surface based on proxy clipper.
Jul 18 2019, 6:25 AM · efl: rendering
zmike updated the diff for D8841: evas/render: clamp mask surface size to clipper size.

rename to has_fixed_size

Jul 18 2019, 6:25 AM · efl: rendering
zmike updated the diff for D8887: evas: add 'has_fixed_size' property for canvas objects.

rename to has_fixed_size

Jul 18 2019, 6:25 AM · efl: rendering

Jul 12 2019

zmike added a comment to D8887: evas: add 'has_fixed_size' property for canvas objects.

The requirement is that it does not change size, this is true, but the fully optimized render path requires that it does not change size or move. For some cases moving will not affect the speed, but it requires some deep knowledge of render internals to be able to make that distinction.

Jul 12 2019, 6:53 AM · efl: rendering

Jul 11 2019

cedric closed D9287: evas/render: clear smart render cache when re-adding smart parent in post-render.
Jul 11 2019, 4:51 PM · efl: rendering
cedric accepted D9287: evas/render: clear smart render cache when re-adding smart parent in post-render.
Jul 11 2019, 4:35 PM · efl: rendering
zmike requested review of D9287: evas/render: clear smart render cache when re-adding smart parent in post-render.
Jul 11 2019, 11:23 AM · efl: rendering

Jun 3 2019

zmike closed D8918: gl_generic: directly copy existing image when changing orientation.
Jun 3 2019, 5:57 AM · efl: rendering

Jun 2 2019

Hermet accepted D8918: gl_generic: directly copy existing image when changing orientation.
Jun 2 2019, 11:25 PM · efl: rendering

May 30 2019

cedric accepted D8918: gl_generic: directly copy existing image when changing orientation.

Indeed, I missed that.

May 30 2019, 11:46 AM · efl: rendering
zmike added a comment to D8918: gl_generic: directly copy existing image when changing orientation.
In D8918#166114, @zmike wrote:

This only loads the texture if it has previously been prepared for drawing. In the given scenario, this codepath is triggered during object construction and so no such preparation has occurred.

Hum, I am guessing that in this case, there isn't any texture available, maybe not even a valid width, height and color space. Maybe do a test on the texture and switch between the two possible function for creating image. As @Hermet pointed out, I am also afraid that the new_from_rgbaimage will either leak a texture if one is available or duplicate image.

May 30 2019, 11:17 AM · efl: rendering
cedric added a comment to D8918: gl_generic: directly copy existing image when changing orientation.
In D8918#166114, @zmike wrote:

This only loads the texture if it has previously been prepared for drawing. In the given scenario, this codepath is triggered during object construction and so no such preparation has occurred.

May 30 2019, 9:33 AM · efl: rendering
segfaultxavi requested changes to D8887: evas: add 'has_fixed_size' property for canvas objects.
In D8887#166127, @zmike wrote:

I'm not so sure about dropping clipper from the name; this functionality only exists for objects which are clippers, so shouldn't the naming indicate this?

May 30 2019, 7:44 AM · efl: rendering
zmike added a comment to D8887: evas: add 'has_fixed_size' property for canvas objects.

Thanks for the context!

has_fixed_size looks fine to me as a property name. If it is moved to the clipper object then the clipper_ part of the name needs to be dropped, obviously.

May 30 2019, 5:55 AM · efl: rendering
segfaultxavi added a comment to D8887: evas: add 'has_fixed_size' property for canvas objects.

Thanks for the context!

May 30 2019, 5:51 AM · efl: rendering
zmike added a comment to D8918: gl_generic: directly copy existing image when changing orientation.

This only loads the texture if it has previously been prepared for drawing. In the given scenario, this codepath is triggered during object construction and so no such preparation has occurred.

May 30 2019, 5:36 AM · efl: rendering
zmike added a comment to D8887: evas: add 'has_fixed_size' property for canvas objects.

It seems like there's some confusion about this API, so I'll try to explain the concept a bit better so that we can have a good discussion.

May 30 2019, 5:35 AM · efl: rendering
segfaultxavi added a comment to D8887: evas: add 'has_fixed_size' property for canvas objects.

It is indeed confusing having vars named is_static_clip and clipper_is_static in two different structures (_Evas_Object_Protected_Data and _Evas_Object_Protected_State).

May 30 2019, 1:19 AM · efl: rendering

May 29 2019

cedric updated subscribers of D8887: evas: add 'has_fixed_size' property for canvas objects.

I find the name confusing as it seems it has confused everyone who looked at this patch. What about clipper_static_size? @segfaultxavi an opinion on the subject?

May 29 2019, 2:45 PM · efl: rendering
cedric added a comment to D8918: gl_generic: directly copy existing image when changing orientation.

The weird bit is that I would expect evas_gl_common_image_update to actually load the texture. @zmike do you have an idea why the texture is not loaded in that case?

May 29 2019, 2:40 PM · efl: rendering
devilhorns closed T7230: Clean up evas_inline.x as Resolved.
May 29 2019, 12:40 PM · efl: rendering, efl: canvas, Restricted Project
zmike added a commit to T7230: Clean up evas_inline.x: rEFL343698f7eceb: evas_inline: Clean up evas_object_plane_changed function.
May 29 2019, 12:38 PM · efl: rendering, efl: canvas, Restricted Project
zmike added a commit to T7230: Clean up evas_inline.x: rEFL70ea7ba9daa1: evas_inline: Clean up evas_object_is_opaque function.
May 29 2019, 12:38 PM · efl: rendering, efl: canvas, Restricted Project
zmike added a commit to T7230: Clean up evas_inline.x: rEFL8c5d5ada65cb: evas_inline: Clean up evas_object_is_on_plane function.
May 29 2019, 12:38 PM · efl: rendering, efl: canvas, Restricted Project
zmike added a commit to T7230: Clean up evas_inline.x: rEFL94d1b0f3bf7a: evas_inline: Clean up evas_object_is_visible function.
May 29 2019, 12:37 PM · efl: rendering, efl: canvas, Restricted Project
zmike added a commit to T7230: Clean up evas_inline.x: rEFLc10a4dcd18dd: evas_inline: Clean up evas_object_is_proxy_visible function.
May 29 2019, 12:37 PM · efl: rendering, efl: canvas, Restricted Project
zmike added a commit to T7230: Clean up evas_inline.x: rEFLef23de1ea4bf: evas_inline: Clean up evas_object_was_visible function.
May 29 2019, 12:37 PM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9051: evas_inline: Clean up evas_object_plane_changed function.
May 29 2019, 10:14 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9050: evas_inline: Clean up evas_object_is_on_plane function.
May 29 2019, 10:11 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9049: evas_inline: Clean up evas_object_is_opaque function.
May 29 2019, 10:11 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9048: evas_inline: Clean up evas_object_is_proxy_visible function.
May 29 2019, 10:10 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9047: evas_inline: Clean up evas_object_is_proxy_visible function.
May 29 2019, 10:06 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9046: evas_inline: Clean up evas_object_is_visible function.
May 29 2019, 10:06 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9045: evas_inline: Clean up evas_object_was_visible function.
May 29 2019, 10:06 AM · efl: rendering, efl: canvas, Restricted Project
zmike closed D8916: gl_generic: handle image orientation setting when texture has not been created.
May 29 2019, 9:29 AM · efl: rendering
devilhorns added a revision to T7230: Clean up evas_inline.x: D9040: evas_inline: Clean up evas_inline.x.
May 29 2019, 7:02 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9039: evas_inline: Clean up evas_inline.x.
May 29 2019, 6:47 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9038: evas_inline: Clean up evas_inline.x.
May 29 2019, 6:47 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9037: evas_inline: Clean up evas_inline.x.
May 29 2019, 6:45 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9036: evas_inline: Clean up evas_inline.x.
May 29 2019, 6:45 AM · efl: rendering, efl: canvas, Restricted Project
devilhorns added a revision to T7230: Clean up evas_inline.x: D9035: evas_inline: Clean up evas_inline.x.
May 29 2019, 6:45 AM · efl: rendering, efl: canvas, Restricted Project

May 24 2019

cedric accepted D8916: gl_generic: handle image orientation setting when texture has not been created.
May 24 2019, 10:42 AM · efl: rendering

May 23 2019

zmike removed a child revision for D8918: gl_generic: directly copy existing image when changing orientation: D8947: ecore/timer: fix handling of timer freeze during construction.
May 23 2019, 11:02 AM · efl: rendering