ping?

I have no further complains regarding documentation. Was the code ever reviewed? @Hermet ?

reword

rename to has_fixed_size

rename to has_fixed_size

The requirement is that it does not change size, this is true, but the fully optimized render path requires that it does not change size or move. For some cases moving will not affect the speed, but it requires some deep knowledge of render internals to be able to make that distinction.

Indeed, I missed that.

In D8918#166164, @cedric wrote:

In D8918#166114, @zmike wrote:

This only loads the texture if it has previously been prepared for drawing. In the given scenario, this codepath is triggered during object construction and so no such preparation has occurred.

Hum, I am guessing that in this case, there isn't any texture available, maybe not even a valid width, height and color space. Maybe do a test on the texture and switch between the two possible function for creating image. As @Hermet pointed out, I am also afraid that the new_from_rgbaimage will either leak a texture if one is available or duplicate image.

In D8918#166114, @zmike wrote:

This only loads the texture if it has previously been prepared for drawing. In the given scenario, this codepath is triggered during object construction and so no such preparation has occurred.

In D8887#166127, @zmike wrote:

I'm not so sure about dropping clipper from the name; this functionality only exists for objects which are clippers, so shouldn't the naming indicate this?

In D8887#166125, @segfaultxavi wrote:

Thanks for the context!

has_fixed_size looks fine to me as a property name. If it is moved to the clipper object then the clipper_ part of the name needs to be dropped, obviously.

Thanks for the context!

This only loads the texture if it has previously been prepared for drawing. In the given scenario, this codepath is triggered during object construction and so no such preparation has occurred.

It seems like there's some confusion about this API, so I'll try to explain the concept a bit better so that we can have a good discussion.

It is indeed confusing having vars named is_static_clip and clipper_is_static in two different structures (_Evas_Object_Protected_Data and _Evas_Object_Protected_State).

I find the name confusing as it seems it has confused everyone who looked at this patch. What about clipper_static_size? @segfaultxavi an opinion on the subject?

The weird bit is that I would expect evas_gl_common_image_update to actually load the texture. @zmike do you have an idea why the texture is not loaded in that case?