Page MenuHomePhabricator

DO NOT MERGEProject
ActivePublic

Members

  • This project does not have any members.

Watchers

  • This project does not have any watchers.

Details

Description

For patches which should not yet be merged

Recent Activity

Yesterday

segfaultxavi updated the diff for D7620: efl-api: Mark Efl.Io.Reader as stable.

Remove @beta tag instead of moving includes around Efl.h

Fri, Feb 15, 1:25 AM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7619: efl-api: Mark Efl.Io.Writer as stable.

Remove @beta tag instead of moving includes around Efl.h

Fri, Feb 15, 1:24 AM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7618: efl-api: Mark Efl.Io.Closer as stable.

Remove @beta tag instead of moving includes around Efl.h

Fri, Feb 15, 1:21 AM · DO NOT MERGE, efl

Mon, Feb 11

cedric closed D7745: elm_progressbar test: Add test for custom format strings to show when %% is not escaped correctly..
Mon, Feb 11, 3:41 PM · DO NOT MERGE, efl
cedric accepted D7620: efl-api: Mark Efl.Io.Reader as stable.
Mon, Feb 11, 2:49 PM · DO NOT MERGE, efl
cedric accepted D7619: efl-api: Mark Efl.Io.Writer as stable.
Mon, Feb 11, 2:48 PM · DO NOT MERGE, efl
cedric accepted D7618: efl-api: Mark Efl.Io.Closer as stable.
Mon, Feb 11, 2:48 PM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7618: efl-api: Mark Efl.Io.Closer as stable.

Rebase

Mon, Feb 11, 2:44 AM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7619: efl-api: Mark Efl.Io.Writer as stable.

Rebase

Mon, Feb 11, 2:44 AM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7620: efl-api: Mark Efl.Io.Reader as stable.

Rebase

Mon, Feb 11, 2:43 AM · DO NOT MERGE, efl
segfaultxavi added a parent revision for D7620: efl-api: Mark Efl.Io.Reader as stable: D7619: efl-api: Mark Efl.Io.Writer as stable.
Mon, Feb 11, 2:27 AM · DO NOT MERGE, efl
segfaultxavi added a child revision for D7619: efl-api: Mark Efl.Io.Writer as stable: D7620: efl-api: Mark Efl.Io.Reader as stable.
Mon, Feb 11, 2:27 AM · DO NOT MERGE, efl
segfaultxavi added a parent revision for D7619: efl-api: Mark Efl.Io.Writer as stable: D7618: efl-api: Mark Efl.Io.Closer as stable.
Mon, Feb 11, 2:27 AM · DO NOT MERGE, efl
segfaultxavi added a child revision for D7618: efl-api: Mark Efl.Io.Closer as stable: D7619: efl-api: Mark Efl.Io.Writer as stable.
Mon, Feb 11, 2:27 AM · DO NOT MERGE, efl

Fri, Feb 8

zmike updated the diff for D7899: api: remove efl.ui.cursor interface.

update

Fri, Feb 8, 11:54 AM · efl: api
zmike requested review of D7899: api: remove efl.ui.cursor interface.
Fri, Feb 8, 11:36 AM · efl: api

Thu, Feb 7

segfaultxavi closed D7855: efl: Change non required constructors to @optional..
Thu, Feb 7, 9:05 AM · DO NOT MERGE, efl
cedric accepted D7855: efl: Change non required constructors to @optional..
Thu, Feb 7, 6:07 AM · DO NOT MERGE, efl

Fri, Feb 1

lauromoura added inline comments to D7855: efl: Change non required constructors to @optional..
Fri, Feb 1, 4:55 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

What do you mean ? Does my patch work or not ? :)

Fri, Feb 1, 2:28 AM · DO NOT MERGE, efl
SanghyeonLee requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

oh its wrong patch.

Fri, Feb 1, 2:23 AM · DO NOT MERGE, efl
SanghyeonLee accepted D7857: eo: Fix efl_isa for class checking of recursively inherited types.

I tested and it fix the problem well :) thank you.

Fri, Feb 1, 2:23 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

@SanghyeonLee please check the attached patch :)

Fri, Feb 1, 2:12 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

It appears that we are recursivly skipping interfaces, but not on the direct implementer. I will look later next week into it.

Fri, Feb 1, 2:07 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

It appears that we are recursivly skipping interfaces, but not on the direct implementer. I will look later next week into it.

Fri, Feb 1, 1:56 AM · DO NOT MERGE, efl
SanghyeonLee edited reviewers for D7857: eo: Fix efl_isa for class checking of recursively inherited types, added: q66; removed: QA_Igor.
Fri, Feb 1, 1:50 AM · DO NOT MERGE, efl
SanghyeonLee added a reviewer for D7857: eo: Fix efl_isa for class checking of recursively inherited types: QA_Igor.
Fri, Feb 1, 1:46 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Do you have a old efl_ui_layout.eo.c arround somewhere in your tree ?

Fri, Feb 1, 1:45 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

I think I resolve the problem by recursive calls of efl_isa for mro

Fri, Feb 1, 1:42 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Parts of my output with "EINA_LOG_DOMAINS="eo:10" elementary_test"

Fri, Feb 1, 1:35 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Can you paste you efl_ui_layout.eo.c ? I just checked it and it seems that efl.ui.view is part of efl.ui.layout's MRO here.

Fri, Feb 1, 1:30 AM · DO NOT MERGE, efl
segfaultxavi accepted D7855: efl: Change non required constructors to @optional..

These look OK to me, except the Model and Factory ones which @cedric should review.

Fri, Feb 1, 1:05 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

The issue case is easily found in example of efl_ui_list_view_example_1.c

Fri, Feb 1, 12:46 AM · DO NOT MERGE, efl
YOhoho added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

What do you think to check extensions after checking mro?

kls_itr = lookinto->extensions;
if (!kls_itr) return EINA_FALSE;
return (efl_isa((Eo *)(*kls_itr)->header.id, klass_id));
Fri, Feb 1, 12:38 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Mhmmm MRO should contain all recursive classes.

Fri, Feb 1, 12:19 AM · DO NOT MERGE, efl
bu5hm4n requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Mhmmm MRO should contain all recursive classes.

Fri, Feb 1, 12:10 AM · DO NOT MERGE, efl
SanghyeonLee requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

looks something wrong in the patch.

Fri, Feb 1, 12:09 AM · DO NOT MERGE, efl
SanghyeonLee added a project to D7857: eo: Fix efl_isa for class checking of recursively inherited types: DO NOT MERGE.
Fri, Feb 1, 12:08 AM · DO NOT MERGE, efl

Thu, Jan 31

lauromoura added a project to D7855: efl: Change non required constructors to @optional.: DO NOT MERGE.
Thu, Jan 31, 4:03 PM · DO NOT MERGE, efl

Wed, Jan 30

SanghyeonLee closed D7533: efl_model : rename all efl_model based classes..
Wed, Jan 30, 9:59 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

fix few typo which was generated by conflict resolving

Wed, Jan 30, 9:28 PM · DO NOT MERGE, efl
SanghyeonLee updated the summary of D7533: efl_model : rename all efl_model based classes..
Wed, Jan 30, 9:16 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebasing patch and resolve conflict

Wed, Jan 30, 9:14 PM · DO NOT MERGE, efl
bu5hm4n added a comment to D7745: elm_progressbar test: Add test for custom format strings to show when %% is not escaped correctly..

I added do not merge so it is out of the queue, we can land it once this is fixed.

Wed, Jan 30, 4:31 AM · DO NOT MERGE, efl
bu5hm4n added a project to D7745: elm_progressbar test: Add test for custom format strings to show when %% is not escaped correctly.: DO NOT MERGE.
Wed, Jan 30, 4:31 AM · DO NOT MERGE, efl

Mon, Jan 28

SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebase patch

Mon, Jan 28, 10:51 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

update patch. fix build errors

Mon, Jan 28, 10:13 PM · DO NOT MERGE, efl

Sat, Jan 26

SanghyeonLee added a project to D7533: efl_model : rename all efl_model based classes.: DO NOT MERGE.
Sat, Jan 26, 5:42 AM · DO NOT MERGE, efl

Wed, Jan 23

SanghyeonLee abandoned D7614: efl_ui : add dummy object for verificate factory class..

abandoned

Wed, Jan 23, 2:30 AM · DO NOT MERGE, efl

Jan 16 2019

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Remove resize object again. :(

Jan 16 2019, 12:46 AM · efl