Page MenuHomePhabricator

efl: apiProject
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Today

q66 added a comment to T8514: remove @move from get { } if ownership is not moved by getter.

馃憤

Fri, Dec 6, 4:05 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8436: efl.canvas.animation.

Okay, maybe i was a bit stubborn with all this. I have to admit, i still do not see any reason to support 0 as a duration, but it seems some people use it, so lets go with it. I am fine with it, as logn as the default duration is != 0 (which it is in the revision).

Fri, Dec 6, 4:02 AMefl: api, efl (efl-1.24)
woohyun added a comment to T8501: Efl.Ui.Progressbar.

@segfaultxavi
Thanks for checking first :)

Fri, Dec 6, 3:34 AMefl: api, efl (efl-1.24)
Jaehyun_Cho added a comment to T8436: efl.canvas.animation.

I understand your point that non-zero value would be more useful as default duration than 0.
So I restored the default duration of animation in D10812.

Fri, Dec 6, 2:53 AMefl: api, efl (efl-1.24)

Yesterday

bu5hm4n added a comment to T8436: efl.canvas.animation.

I still do not see why a user creates a bunch of animations, just to get theire final state, that looks like a lot of work for very little results. If you want to have the final state of something where you have the animation objects for, just set the speed to INF.
The duration of an animation beeing 0 makes still little sense to me, and the default value beeing 0 even less. Per default a user wants to see a animation (i guess that is why he creates a animation object), hence the default duration should be > 0.0.

Thu, Dec 5, 11:32 PMefl: api, efl (efl-1.24)
woohyun added a comment to T7864: efl.gfx.arrangement.

I think we can remove beta :)
I'll wait for a day for more feedback.

Thu, Dec 5, 9:42 PMefl (efl-1.24), efl: api, efl: language bindings
Jaehyun_Cho added a revision to T8436: efl.canvas.animation: D10812: efl_canvas_object_animation: support duration 0.
Thu, Dec 5, 9:21 PMefl: api, efl (efl-1.24)
Jaehyun_Cho added a revision to T8513: efl.canvas.object_animation: D10812: efl_canvas_object_animation: support duration 0.
Thu, Dec 5, 9:21 PMefl: api, efl (efl-1.24)
Jaehyun_Cho moved T8514: remove @move from get { } if ownership is not moved by getter from Backlog to Evaluating on the efl: api board.
Thu, Dec 5, 9:20 PMefl: api, efl (efl-1.24)
Jaehyun_Cho created T8514: remove @move from get { } if ownership is not moved by getter.
Thu, Dec 5, 9:19 PMefl: api, efl (efl-1.24)
Jaehyun_Cho added a comment to T8436: efl.canvas.animation.

I don't mind the function setting default duration value :)
It may be useful to someone who wants to set the same duration multiple times~
I simply think that we need to let animation support duration 0 as well.

Thu, Dec 5, 6:52 PMefl: api, efl (efl-1.24)
Jaehyun_Cho moved T8513: efl.canvas.object_animation from Backlog to Evaluating on the efl: api board.
Thu, Dec 5, 6:32 PMefl: api, efl (efl-1.24)
Jaehyun_Cho triaged T8513: efl.canvas.object_animation as Normal priority.
Thu, Dec 5, 6:32 PMefl: api, efl (efl-1.24)
Jaehyun_Cho created T8513: efl.canvas.object_animation.
Thu, Dec 5, 6:31 PMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8436: efl.canvas.animation.

Mhm, i am not so sure about this because:

  • We are talking here about the default case, what is happening with an animation, that just got created
  • i do not believe that someone creates an anmation object just to apply the final state (that might not even enabled on that object)
  • The user can still do that, he can pass 0.0[0]1 to it, and it will happen like this.
Thu, Dec 5, 4:40 AMefl: api, efl (efl-1.24)
Jaehyun_Cho added a comment to T8436: efl.canvas.animation.

I think if duration is 0, then the final state of animation is applied immediately. (It seems that current animation logic does not support duration 0)

Thu, Dec 5, 3:46 AMefl: api, efl (efl-1.24)
ali.alzyod added a comment to T8093: Name conflict between class and property.

@segfaultxavi

By the way, how does your plan relate to @tasn's ? I admit I didn't thoroughly read his RFC.

@tasn plan does not include future widget design, and also it was effected a lot where a composite class in EFL is not working anymore.

Thu, Dec 5, 3:09 AMefl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a comment to T8093: Name conflict between class and property.

Rename Efl.Canvas.Text into Efl.Canvas.Textblock D10808

Thu, Dec 5, 3:07 AMefl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T8093: Name conflict between class and property.

Efl.Ui.Textbox and Efl.Canvas.Textblock both look fine to me.

Thu, Dec 5, 12:56 AMefl (efl-1.24), efl: api, efl: language bindings

Wed, Dec 4

ali.alzyod added a comment to T8093: Name conflict between class and property.

@woohyun @zmike @bu5hm4n @segfaultxavi
If there are no further concerns I will soon update :

Wed, Dec 4, 11:25 PMefl (efl-1.24), efl: api, efl: language bindings
bu5hm4n added a comment to T8439: efl.canvas.animation_group_sequential.

Yes, true :)

Wed, Dec 4, 8:59 AMefl: api, efl (efl-1.24)
segfaultxavi added a comment to T8439: efl.canvas.animation_group_sequential.

Looks like only the elm_test example was broken. Fixed in D10802.

Wed, Dec 4, 8:55 AMefl: api, efl (efl-1.24)
cedric added a comment to T8451: efl.linear_interpolator.

I do prefer explicit behavior to implicit personally.

Wed, Dec 4, 7:59 AMefl: api, efl (efl-1.24)
bu5hm4n closed T8380: efl.ui.relative_layout as Resolved.

This is stable 3ba366498cd73ef4c10caf591e18b6387bcc2a7c

Wed, Dec 4, 7:52 AMefl (efl-1.24), efl: api, efl: language bindings
bu5hm4n added a comment to T8476: efl_ui_animation_view.

I think we had a discussion when this was introduced, that the API in here needs to implement the player interface etc.

Wed, Dec 4, 7:51 AMefl (efl-1.24), efl: api
Diffusion closed T7871: efl.ui.multi_selectable as Resolved by committing rEFL655472d9c9af: efl_ui_mutli_selectable: stabelize interfaces.
Wed, Dec 4, 7:49 AMefl: api, efl: language bindings
Diffusion closed T7871: efl.ui.multi_selectable, a subtask of T7870: efl.ui.grid, as Resolved.
Wed, Dec 4, 7:49 AMefl: api, efl (efl-1.23), efl: language bindings
Diffusion closed T7922: enum Efl.Ui.Select_Mode as Resolved by committing rEFL655472d9c9af: efl_ui_mutli_selectable: stabelize interfaces.
Wed, Dec 4, 7:49 AMefl (efl-1.24), efl: api, efl: language bindings
Diffusion closed T7871: efl.ui.multi_selectable, a subtask of T7881: efl.ui.list, as Resolved.
Wed, Dec 4, 7:49 AMefl: api, efl (efl-1.23), efl: language bindings
Diffusion closed T7922: enum Efl.Ui.Select_Mode, a subtask of T7871: efl.ui.multi_selectable, as Resolved.
Wed, Dec 4, 7:49 AMefl: api, efl: language bindings
Diffusion closed T8265: efl.ui.multi_selectable_async as Resolved by committing rEFL655472d9c9af: efl_ui_mutli_selectable: stabelize interfaces.
Wed, Dec 4, 7:49 AMefl (efl-1.24), efl: api, efl: language bindings
Diffusion closed T8265: efl.ui.multi_selectable_async, a subtask of T7871: efl.ui.multi_selectable, as Resolved.
Wed, Dec 4, 7:49 AMefl: api, efl: language bindings
Diffusion closed T8265: efl.ui.multi_selectable_async, a subtask of T8261: efl.ui.collection_view, as Resolved.
Wed, Dec 4, 7:49 AMefl: api, efl (efl-1.23), efl: language bindings
Diffusion added a commit to T8437: efl.canvas.animation_group: rEFLa6c102df1f1c: efl_canvas_animation_group: remove implicit children behaviour.
Wed, Dec 4, 7:32 AMefl: api, efl (efl-1.24)
Diffusion added a commit to T8437: efl.canvas.animation_group: rEFLfc7d398e07af: efl_canvas_animation: use floating point infinite instead of macro.
Wed, Dec 4, 7:31 AMefl: api, efl (efl-1.24)
Diffusion added a commit to T8436: efl.canvas.animation: rEFLa29be18b5f6f: efl_canvas_animation: add a standard value for duration of animations.
Wed, Dec 4, 7:31 AMefl: api, efl (efl-1.24)
segfaultxavi added a comment to T8447: efl.decelerate_interpolator.

There: e242a05d

Wed, Dec 4, 6:58 AMefl: api, efl (efl-1.24)
bu5hm4n added a revision to T8437: efl.canvas.animation_group: D10799: efl_canvas_animation_group: remove implicit children behaviour.
Wed, Dec 4, 3:44 AMefl: api, efl (efl-1.24)
bu5hm4n added a revision to T8437: efl.canvas.animation_group: D10797: efl_canvas_animation: use floating point infinite instead of macro.
Wed, Dec 4, 1:56 AMefl: api, efl (efl-1.24)
bu5hm4n added a revision to T8436: efl.canvas.animation: D10796: efl_canvas_animation: add a standard value for duration of animations.
Wed, Dec 4, 1:55 AMefl: api, efl (efl-1.24)
bu5hm4n added a revision to T8437: efl.canvas.animation_group: D10795: efl_canvas_animation_group: use @property instead of method.
Wed, Dec 4, 1:55 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8437: efl.canvas.animation_group.

After looking at the code: It seems we are propagating the duration of the group animation to its children. But only if the value is different to EFL_ANIMATION_GROUP_DURATION_NONE, should we document that somewhere, and maybe make this macro a constant, so it is usable from the c# side ?

Wed, Dec 4, 1:31 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8437: efl.canvas.animation_group.

Yeah, totally agreed.

Wed, Dec 4, 1:29 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8436: efl.canvas.animation.

The only problem i see here: the duration is always initialized with 0, which is a bug IMO. As a solution we could have a class function standard_animation_time which sets the standard time for later created animation objects. The standard time would be something like 200ms... Does not sounds like a plan?

Wed, Dec 4, 12:55 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8453: efl.spring_interpolator.

However, the test somehow looks buggy, is there something wrong ? Its not really a smooth spring, its more a random jump in the moving speed :/

Wed, Dec 4, 12:45 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8453: efl.spring_interpolator.

This looks basic, simple & ready to me. (And has really nice docs)

Wed, Dec 4, 12:41 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8452: efl.sinusoidal_interpolator.

This looks basic, simple & ready to me. (And has really nice docs)

Wed, Dec 4, 12:40 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8451: efl.linear_interpolator.

This looks basic, simple & ready to me.
I am just wondering if we need this, its just a pass through, you can get the same behaviour with just setting no Interpolator to the Efl.Canvas.Animation object.

Wed, Dec 4, 12:40 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8449: efl.cubic_bezier_interpolator.

This looks basic, simple & ready to me. (And has really nice docs)

Wed, Dec 4, 12:38 AMefl: api, efl (efl-1.24)
bu5hm4n added a comment to T8448: efl.bounce_interpolator.

This looks basic, simple & ready to me. (And has really nice docs)

Wed, Dec 4, 12:38 AMefl: api, efl (efl-1.24)