Page MenuHomePhabricator

DO NOT MERGEProject
ActivePublic

Members

  • This project does not have any members.

Watchers

  • This project does not have any watchers.

Details

Description

For patches which should not yet be merged

Recent Activity

Today

zmike added a project to D9654: eo/vtable: refactor eo vtable to use SOA instead of AOS data structure.: DO NOT MERGE.

Use DO NOT MERGE for test code to ensure that it does not get landed

Wed, Aug 21, 4:22 AM · DO NOT MERGE, efl

Yesterday

lauromoura added a comment to D9653: csharp: Add bindable factory parts support.

This is a tentative patch with the C# syntax changes for factory binding static parts that are based on Efl.IContent.

Tue, Aug 20, 4:57 PM · DO NOT MERGE, efl
lauromoura added a task to D9653: csharp: Add bindable factory parts support: T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono.
Tue, Aug 20, 4:55 PM · DO NOT MERGE, efl

Sun, Aug 18

bu5hm4n added a child revision for D9587: efl_ui_position_manager_list: make it handle group items: D9607: efl_ui_position_manager_common: fix buffer_id.
Sun, Aug 18, 1:15 AM · efl
bu5hm4n updated the diff for D9587: efl_ui_position_manager_list: make it handle group items.

fix invalid item placement

Sun, Aug 18, 1:15 AM · efl
bu5hm4n updated the diff for D9586: efl_ui_position_manager: pass on information about group ids.

update docs

Sun, Aug 18, 1:14 AM · efl
bu5hm4n updated the diff for D9587: efl_ui_position_manager_list: make it handle group items.
Sun, Aug 18, 1:14 AM · efl

Fri, Aug 16

bu5hm4n added a project to D9587: efl_ui_position_manager_list: make it handle group items: DO NOT MERGE.

This needs rethinking.

Fri, Aug 16, 10:32 PM · efl
bu5hm4n added a project to D9586: efl_ui_position_manager: pass on information about group ids: DO NOT MERGE.

Okay i think we need to overthink this patch. It decreases the cache efficiancy a lot, and makes everything ... slower.

Fri, Aug 16, 10:31 PM · efl

Wed, Aug 14

lauromoura updated the diff for D9564: csharp: MVVM parts support.

Update the test after updates in the C binding process

Wed, Aug 14, 11:48 AM · efl

Tue, Aug 13

lauromoura added a comment to D9564: csharp: MVVM parts support.

Added the DO NOT MERGE tag so we can start reviewing this while we fix an issue regarding getting the part from the binder.

Tue, Aug 13, 7:55 PM · efl
lauromoura added a project to D9564: csharp: MVVM parts support: DO NOT MERGE.
Tue, Aug 13, 7:54 PM · efl
SanghyeonLee abandoned D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM.
Tue, Aug 13, 7:03 PM · DO NOT MERGE, efl

Mon, Aug 5

bu5hm4n added a comment to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text.

Sorry i forgot about this, i ironically redid the same, and just found your ticket, and this revision. I could kick my own ass for that ... :|

Mon, Aug 5, 9:43 AM · DO NOT MERGE, Restricted Project

Tue, Jul 30

bu5hm4n abandoned D8845: efl_ui_grid: refactor into container subclass.

this is irrelevant.

Tue, Jul 30, 10:25 AM · DO NOT MERGE, efl
zmike added a comment to D7986: evas_object: reduce method calls for efl_gfx_entity_geometry_set.

Oh I forgot about this.

Tue, Jul 30, 5:44 AM · DO NOT MERGE, efl

Mon, Jul 29

cedric added a comment to D7986: evas_object: reduce method calls for efl_gfx_entity_geometry_set.

What the state of this one?

Mon, Jul 29, 11:36 AM · DO NOT MERGE, efl

Wed, Jul 24

zmike accepted D9285: Introduce Efl.Ui.Item_Container.
Wed, Jul 24, 10:02 AM · efl
cedric accepted D9285: Introduce Efl.Ui.Item_Container.

I think this is good enough for landing and we can iterate from there.

Wed, Jul 24, 9:50 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • update docs
Wed, Jul 24, 9:27 AM · efl
segfaultxavi resigned from D9285: Introduce Efl.Ui.Item_Container.

I've added a few more comments but this has become unmanageable. I'd rather wait until this lands and then I'll update the docs.

Wed, Jul 24, 7:59 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

rebase + updates to docs

Wed, Jul 24, 6:33 AM · efl
bu5hm4n removed parent revisions for D9285: Introduce Efl.Ui.Item_Container: D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager, D9325: efl_ui_win: optimize shutdown.
Wed, Jul 24, 6:24 AM · efl
bu5hm4n added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Wed, Jul 24, 6:23 AM · efl

Tue, Jul 23

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • update docs
Tue, Jul 23, 8:48 AM · efl

Jul 22 2019

cedric added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 22 2019, 11:20 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • fixup benchmarks, improve output of the binary
Jul 22 2019, 1:06 AM · efl

Jul 21 2019

SanghyeonLee added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 21 2019, 10:35 PM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • fix lookup cache of the accessor
Jul 21 2019, 6:55 AM · efl
bu5hm4n planned changes to D9285: Introduce Efl.Ui.Item_Container.
Jul 21 2019, 5:11 AM · efl
bu5hm4n added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 21 2019, 5:10 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

update docs and all the marked comments.

Jul 21 2019, 5:08 AM · efl
bu5hm4n planned changes to D9285: Introduce Efl.Ui.Item_Container.
Jul 21 2019, 4:44 AM · efl

Jul 19 2019

cedric requested changes to D9285: Introduce Efl.Ui.Item_Container.
Jul 19 2019, 4:21 PM · efl
segfaultxavi added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 19 2019, 8:37 AM · efl
SanghyeonLee added a task to D9285: Introduce Efl.Ui.Item_Container: T8058: Naming our collection container.
Jul 19 2019, 4:48 AM · efl

Jul 18 2019

zmike added a comment to D9285: Introduce Efl.Ui.Item_Container.

Also a number of lines need wrapping because they go off screen even in my 160col editor.

Jul 18 2019, 10:01 AM · efl
zmike requested changes to D9285: Introduce Efl.Ui.Item_Container.

One issue I have with this is the bool: animation param for various methods. Typically we provide some options for this kind of thing like linear, accelerate, decelerate, ...

Jul 18 2019, 9:59 AM · efl
SanghyeonLee added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 18 2019, 5:11 AM · efl
bu5hm4n added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 18 2019, 4:43 AM · efl
segfaultxavi requested changes to D9285: Introduce Efl.Ui.Item_Container.

I've made quite a few comments on the API and the docs... make sure to mark them as done so none is forgotten!

Jul 18 2019, 4:22 AM · efl

Jul 17 2019

bu5hm4n updated subscribers of D9285: Introduce Efl.Ui.Item_Container.

I would like to merge this widget at the latest on the 27.07.

Jul 17 2019, 9:47 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

add multiselect radio

Jul 17 2019, 8:23 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

fix scroller bouncing

Jul 17 2019, 8:01 AM · efl

Jul 16 2019

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

more fixes better tests in elm_test

Jul 16 2019, 2:13 AM · efl

Jul 14 2019

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

forgot a few files

Jul 14 2019, 10:05 AM · efl
bu5hm4n added a comment to D9285: Introduce Efl.Ui.Item_Container.

The widget meanwhile is feature complete, there are tests for the grid position manager and list position manager. The tests for now are only plain copies. Given the complexity of this widget, there will 100% be more bugs to find, and things to clarify, so I would be very happy if people could write examples for that, play with the API, do things that i did not think of. Or simply play around in the tests. Thank you :)

Jul 14 2019, 2:03 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • more tests
Jul 14 2019, 2:00 AM · efl

Jul 12 2019

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

add grid position manager and tests

Jul 12 2019, 2:36 AM · efl
bu5hm4n added a comment to D9285: Introduce Efl.Ui.Item_Container.

On the technical side, I am not sure how I am going to implement the accessor for items as they will be build asynchronously on demand, I wonder how to notify the position manager that they now exist while they didn't before. I am guessing that the best approach for the CollectionView will be to use custom accessor that bind to the data model and the local storage for widget. It seems doable at this point.

Jul 12 2019, 2:08 AM · efl