Page MenuHomePhabricator

efl (efl-1.22)Milestone
ActivePublic

Details

Is Sprint
Yes

Recent Activity

Today

segfaultxavi added a comment to T7383: Efl.Config and Efl.Config_GLobal.

Initially @bu5hm4n stated that Efl.Config should contain all the API and Efl.Config_Global should just be a singleton implementing that API (nothing has been done in this regard yet).
Then @Jaehyun_Cho brought in the discussion from another thread (T7356):

  • The ELM config API has a thousand methods: elm_config_finger_size_get(), elm_config_scroll_thumbscroll_min_friction_set(), etc
  • This was replaced by a generic config API in the new API: Eina_Value *efl_config_get(const char *name) and efl_config_set(const char *name, const Eina_Value *value).
  • While the new API is more flexible, it has two drawbacks:
    • The user does not know which config values are available since they are strings which must be looked up in the docs (previously, the IDE could help you).
    • The user does not know the TYPE of the config values, they must be looked up in the docs (previously this was known).
Thu, Feb 21, 2:52 AM · efl (efl-1.22)
segfaultxavi added a revision to T7564: efl.gfx.map: D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.
Thu, Feb 21, 1:57 AM · efl: api, efl (efl-1.22)

Yesterday

bu5hm4n added a comment to T7514: efl.app / efl.loop.

Which leaves us with 1 thing left.

Wed, Feb 20, 11:58 PM · efl: api, efl (efl-1.22)
bu5hm4n updated the task description for T7514: efl.app / efl.loop.
Wed, Feb 20, 11:58 PM · efl: api, efl (efl-1.22)
Diffusion added a commit to T7597: efl.loop: rEFL08908373f7b3: efl_loop: document and annotate efl_loop_time correctly.
Wed, Feb 20, 11:56 PM · efl: api, efl (efl-1.22)
Diffusion added a commit to T7596: efl.app: rEFL9056275438f3: efl_app: improve docs.
Wed, Feb 20, 11:56 PM · efl: api, efl (efl-1.22)
Diffusion added a commit to T7597: efl.loop: rEFL5ee81f77208f: efl_loop: declare this class function to the object.
Wed, Feb 20, 11:56 PM · efl: api, efl (efl-1.22)

Tue, Feb 19

segfaultxavi added a comment to T7571: efl.ui.focus.object.
  • From the Focus tutorial: "There are 6 commands for Focus navigation: 4 *directional* (Up, Down, Left, Right) and 2 *ordinal* (Previous and Next).". I never liked the word "ordinal", and I am going to change it to "sequential". Therefore, I propose we change the method to sequence_setup or sequence_prepare. The docs should explain that this method is meant to configure the sequence of widgets you get when you navigate through "previous" and "next". The event then could b
  • prepare_logical_none_recursive should be prepare_logical_non_recursive (this is not critical as it is internal).
Tue, Feb 19, 7:40 AM · efl: api, efl (efl-1.22)

Sat, Feb 16

bu5hm4n added a comment to T7557: efl.object.

@lauromoura Afaics this only affects bindings, but not the efl.object definition perse. @segfaultxavi improved the documentation big time. To me the API looks good, except one tiny thing, i don't know if we want to have allow_parent_unref out of beta or not, because to me this seems like a hack that should not be needed in future, opinions @zmike @cedric.

Sat, Feb 16, 1:06 AM · efl: api, efl (efl-1.22)

Fri, Feb 15

woohyun added a comment to T7585: efl.access.window.

@woohyun
As a part of T7653 this interface can be removed completely and moved into efl_access_object. Additionally events can be refactored into regular methods, so instead of "window,created" we will have something like window_created_emit method or just emit with some parameter. Is this acceptable?

Fri, Feb 15, 8:12 PM · efl: api, efl (efl-1.22)
bu5hm4n added a comment to T7571: efl.ui.focus.object.

This function is called before logical movements are performend, this is esp. usefull to set the explict ordering on a node. Hence, prepare logical. Any ideas for a new name ?

Fri, Feb 15, 1:18 PM · efl: api, efl (efl-1.22)
zmike added a comment to T7571: efl.ui.focus.object.

Yea seems fine on the rename. As for method naming, I meant that prepare_logical is not a super informative method name. What does efl_ui_focus_object_prepare_logical even mean at first glance? Nothing, at least to me...

Fri, Feb 15, 12:33 PM · efl: api, efl (efl-1.22)
bu5hm4n added a comment to T7571: efl.ui.focus.object.

@zmike which one do you mean ?

Fri, Feb 15, 12:29 PM · efl: api, efl (efl-1.22)
zmike closed T7572: efl.ui.cursor as Resolved.

Closing this since we're removing the interface.

Fri, Feb 15, 12:04 PM · efl: api, efl (efl-1.22)
zmike closed T7572: efl.ui.cursor, a subtask of T7553: efl.ui.widget, as Resolved.
Fri, Feb 15, 12:04 PM · efl: api, efl (efl-1.22)
zmike added a revision to T7560: efl.gfx.stack: D7968: efl.gfx.stack: restack -> stack,changed.
Fri, Feb 15, 12:04 PM · efl: api, efl (efl-1.22)
zmike added a comment to T7560: efl.gfx.stack.

So I think all we need here is to rename the event? I'm on it.

Fri, Feb 15, 12:03 PM · efl: api, efl (efl-1.22)
zmike moved T7570: efl.part from "easy" to Stabilized on the efl: api board.
Fri, Feb 15, 11:59 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7571: efl.ui.focus.object.

The method naming here seems a bit uninformative?

Fri, Feb 15, 11:46 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7553: efl.ui.widget.

Why does this have a moved event?

Fri, Feb 15, 11:43 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7383: Efl.Config and Efl.Config_GLobal.

What's going on here?

Fri, Feb 15, 11:04 AM · efl (efl-1.22)
zmike added a subtask for T7592: efl.config: T7383: Efl.Config and Efl.Config_GLobal.
Fri, Feb 15, 11:04 AM · efl: api, efl (efl-1.22)
zmike added a parent task for T7383: Efl.Config and Efl.Config_GLobal: T7592: efl.config.
Fri, Feb 15, 11:04 AM · efl (efl-1.22)
zmike added a comment to T7590: efl.screen.

I've created patches for the above, though the new properties lack implementations. This can be solved at a later point.

Fri, Feb 15, 11:01 AM · efl: api, efl (efl-1.22)
zmike added a revision to T7590: efl.screen: D7967: efl.screen: add screen_scale_factor property.
Fri, Feb 15, 11:01 AM · efl: api, efl (efl-1.22)
zmike added a revision to T7590: efl.screen: D7966: efl.screen: add screen_size_in_mm property.
Fri, Feb 15, 11:01 AM · efl: api, efl (efl-1.22)
zmike added a revision to T7590: efl.screen: D7965: efl.screen: screen_size -> screen_size_in_pixels.
Fri, Feb 15, 11:01 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7590: efl.screen.

So maybe something like:

Fri, Feb 15, 10:48 AM · efl: api, efl (efl-1.22)
cedric added a comment to T7376: [MVVM] Model Selection Support.

We could merge the idea of multi selection and selection class model into one class easily, so let's do it that way.

Fri, Feb 15, 10:20 AM · efl (efl-1.22), efl: mvvm
cedric added a comment to T7672: efl.file_save.

For the long term, I would love to have a way to load from an Efl.Io stream as a load function, could be load_from_io then.

Fri, Feb 15, 10:03 AM · efl: api, efl (efl-1.22)
cedric added a comment to T7672: efl.file_save.

I think I agree with @segfaultxavi here on most bit:

Fri, Feb 15, 10:01 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7672: efl.file_save.

I initially listed some concerns, which you addressed with specific proposals:

In T7672#130634, @zmike wrote:

To propose a more concrete change here:

  • move existing efl_file(_save) into efl_gfx (either directly or as efl.gfx.file)
  • keep simple efl.file mixin with only file property
    • remove key
  • keep simple efl.file_save interface
    • remove flags
  • create file_key property to go with the file api which has been moved to efl_gfx
  • create save_flags property to go with file api in efl_gfx

And we all agreed, so you are free to implement those.

Afterwards, I also complained (like the tireless little whiner that I am) about the asymmetry of having save() but no load(), and the fact that the filename you save() to is not the same you will retrieve later when reading the file property.
@cedric agreed that conventional load() and save() methods would be nice, but warned us that some work will then be required to link these methods with a filename property on a Model object. I do not know what this work is, but Cedric thinks it is doable.

And this is the TL;DR, as I understand it.

Fri, Feb 15, 10:00 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7562: efl.input.interface.

Oh, I thought to meant "conceptual" overlap, sorry.

Fri, Feb 15, 8:56 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7574: efl.ui.selection.

Looks like that, yeah.

Fri, Feb 15, 8:44 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7562: efl.input.interface.
(E) focus,in
(E) focus,out
Fri, Feb 15, 8:43 AM · efl: api, efl (efl-1.22)
segfaultxavi updated subscribers of T7563: efl.gfx.size_hint.

I do not like the name of this interface. First off, it not only contains size hints, also position (like hint_align). I'd prefer something like Efl.Gfx.Geometry_Hint.
Secondly, Size_Hint suggests that this is a hint, instead of an object accepting hints, but I cannot come up with a better name for that.

Fri, Feb 15, 8:39 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7555: efl.canvas.object.

I agree is_frame_object() seems internal, as its own docs say.

Fri, Feb 15, 7:56 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7562: efl.input.interface.

Where? I cannot find any overlap.

Fri, Feb 15, 7:41 AM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to T7672: efl.file_save.

I initially listed some concerns, which you addressed with specific proposals:

In T7672#130634, @zmike wrote:

To propose a more concrete change here:

  • move existing efl_file(_save) into efl_gfx (either directly or as efl.gfx.file)
  • keep simple efl.file mixin with only file property
    • remove key
  • keep simple efl.file_save interface
    • remove flags
  • create file_key property to go with the file api which has been moved to efl_gfx
  • create save_flags property to go with file api in efl_gfx

And we all agreed, so you are free to implement those.

Fri, Feb 15, 7:36 AM · efl: api, efl (efl-1.22)
segfaultxavi added a commit to T7584: efl.canvas.scene: rEFL4935202caab9: efl.canvas.scene: improve class docs.
Fri, Feb 15, 7:24 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7574: efl.ui.selection.

I don't think there's any way this makes it for 1.22 given that it goes with T7575 and requires dnd/selection types...

Fri, Feb 15, 6:50 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7563: efl.gfx.size_hint.

Not totally sold on hint_margin naming? Was this hint_padding or similar at some point?

Fri, Feb 15, 6:49 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7555: efl.canvas.object.

is_frame_object seems bad to expose since this should only be used by internals?

Fri, Feb 15, 6:48 AM · efl: api, efl (efl-1.22)
zmike added a comment to T7562: efl.input.interface.

This seems like it has some overlap with T7584?

Fri, Feb 15, 6:47 AM · efl: api, efl (efl-1.22)
zmike moved T7582: efl.layout.signal from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7559: efl.gfx.color from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7567: efl.canvas.pointer from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7576: efl.container from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7589: efl.input.state from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)
zmike moved T7593: efl.ui.widget_focus_manager from needs patch to Stabilized on the efl: api board.
Fri, Feb 15, 6:43 AM · efl: api, efl (efl-1.22)