Page MenuHomePhabricator

efl (efl-1.23)Milestone
ActivePublic

Recent Activity

Today

bu5hm4n updated the task description for T7948: Efl.Ui.Alert_Popup.
Tue, Jun 25, 9:35 AM · efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7847: efl.ui.clickable.
Tue, Jun 25, 9:34 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7847: efl.ui.clickable.
Tue, Jun 25, 9:34 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7847: efl.ui.clickable.
Tue, Jun 25, 9:33 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a revision to T7866: efl.ui.nstate: D9176: efl_ui: remove nstate widget.
Tue, Jun 25, 9:33 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7865: efl.ui.check.

I think this needs some naming changes:

Tue, Jun 25, 9:31 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7947: Efl.Ui.Anchor_Popup.

Well, there is now. Kill. This. With. Fire.

Tue, Jun 25, 9:22 AM · efl (efl-1.23), efl: language bindings
zmike added a comment to T7898: efl.ui.format.

http://i.imgur.com/v7c1kEZ.gif

Tue, Jun 25, 9:04 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7947: Efl.Ui.Anchor_Popup.

Oh so you're imagining that there was a panel assembled to evaluate this API before it landed?

Tue, Jun 25, 8:57 AM · efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7898: efl.ui.format.

I am fine with this.

Tue, Jun 25, 8:24 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7947: Efl.Ui.Anchor_Popup.

Well, if it's a list, it's fugly. Why don't we use an Eina list? or array? or literally ANY other thing before the words first, second, third, ...

Tue, Jun 25, 7:44 AM · efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

This is how I would like this mixin to work:

Tue, Jun 25, 7:40 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7947: Efl.Ui.Anchor_Popup.

It's a priority list. first means the first attempted layout to use, second is the fallback, third is the fallback if second doesn't work, ...

Tue, Jun 25, 7:29 AM · efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7947: Efl.Ui.Anchor_Popup.

I would like to know the meaning of those extraterrestrial first, second, third, ... parameters to align_priority. What is that?

Tue, Jun 25, 7:23 AM · efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7895: efl.ui.range_display.

+1

Tue, Jun 25, 6:30 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated the task description for T7895: efl.ui.range_display.
Tue, Jun 25, 6:30 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7895: efl.ui.range_display.

This seems okay now

Tue, Jun 25, 6:20 AM · efl: api, efl (efl-1.23), efl: language bindings

Yesterday

zmike added a comment to T7902: efl.ui.popup.

I agree that it seems like align could be handled using align_hint.

Mon, Jun 24, 6:07 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7898: efl.ui.format.

I think if we are going with a priority system then the most bespoke one should be the highest priority. This would mean cb > values > string.

Mon, Jun 24, 6:00 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7947: Efl.Ui.Anchor_Popup.

align_priority is (iirc) a way to specify how you prefer the popup to do layout if it is constrained. We may want to copy/research xdg-popup semantics for this (which I also wrote) since they're a bit more robust.

Mon, Jun 24, 5:53 AM · efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7948: Efl.Ui.Alert_Popup.

I just wanted to ensure we have thought about button as part, so this is fine to me :)
So action items for this here are :

  • Change of Event type & Removal of struct type
  • Write Tests. / Verify event emission / Veryfy funcitonal icon / str parts.
Mon, Jun 24, 5:46 AM · efl (efl-1.23), efl: language bindings
Jaehyun_Cho added a comment to T7948: Efl.Ui.Alert_Popup.

Yes, since Efl.Ui.Alert_Popup simply adds its buttons and button clicked event to Efl.Ui.Popup, extending Efl.Ui.Popup is enough for developer who needs a more flexible popup.

Mon, Jun 24, 4:26 AM · efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7948: Efl.Ui.Alert_Popup.

I also think using the enum in the event info is good enough, and that using parts would complicate things too much.
If anybody needs a more flexible popup, he can always extend from Efl.Ui.Popup, no?

Mon, Jun 24, 4:13 AM · efl (efl-1.23), efl: language bindings
Jaehyun_Cho added a comment to T7948: Efl.Ui.Alert_Popup.

Thank you for the opinion.
I agree with you about event info. Regardless of the original intention (why event info is structure), it seems that no new information is required for alert popup's button clicked event.

Mon, Jun 24, 12:16 AM · efl (efl-1.23), efl: language bindings
herb added a comment to T7902: efl.ui.popup.

@bu5hm4n
I think the max_size_hint is different with popup_size.
the max_size in efl_ui_popup means the maximum size that the popup can expand.
If the max_size_hint is used to change the popup size, the popup will not be expandable.
Therefore, I think it's not good to change popup_size to max_size_hint.
In case of the alignment API of popup, It is designed to notify the options to the users.
To use this API makes the code simple and easy.

Mon, Jun 24, 12:08 AM · efl: api, efl (efl-1.23), efl: language bindings

Sat, Jun 22

bu5hm4n added a comment to T7898: efl.ui.format.

The one side is the API, the other side is how we are *using* this API from the widget.

  • Calendar does use efl_ui_format_cb internally, which means, setting the format_string to the object *does* changes the format_cb, which looks super weird to me. Additionally, the format_cb does not handle all the format symbols that others do.
  • efl_ui_spin only works with format_cb, setting the string does not work.
  • efl_ui_tags only works with format_cb, setting the string does not work.
Sat, Jun 22, 7:33 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7947: Efl.Ui.Anchor_Popup.

Why do we need align_priority ?

Sat, Jun 22, 1:38 AM · efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7948: Efl.Ui.Alert_Popup.

The event looks a bit overengeneered to me. Why passing a struct if its just a enum in the struct ? I think passing Efl.Ui.Alert_Popup_Button as event type is totally enough.

Sat, Jun 22, 1:35 AM · efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7902: efl.ui.popup.

I am wondering a little bit about align / popup_size.

Sat, Jun 22, 1:31 AM · efl: api, efl (efl-1.23), efl: language bindings

Fri, Jun 21

bu5hm4n added a revision to T7964: Efl.Input.Key: D9149: efl_input_key: declare stable.
Fri, Jun 21, 7:38 AM · efl (efl-1.23), efl: api
bu5hm4n added a revision to T7965: Efl.Input.Hold: D9148: efl_input_hold: declare stable.
Fri, Jun 21, 7:38 AM · efl (efl-1.23), efl: api
bu5hm4n added a revision to T7970: Efl.Input.Device_Type: D9147: efl_input_device_type: declare stable.
Fri, Jun 21, 7:37 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

Scrollbars can just ignore the inverted flag. We will document it. I think users will understand :)

Fri, Jun 21, 7:09 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n closed T7971: Efl.Input.Lock as Invalid.

Already Stable

Fri, Jun 21, 7:08 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7971: Efl.Input.Lock, a subtask of T7968: Efl.Input.State, as Invalid.
Fri, Jun 21, 7:08 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7972: Efl.Input.Modifier as Invalid.

Already Stable

Fri, Jun 21, 7:08 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7972: Efl.Input.Modifier, a subtask of T7968: Efl.Input.State, as Invalid.
Fri, Jun 21, 7:08 AM · efl (efl-1.23), efl: api
bu5hm4n added a revision to T7971: Efl.Input.Lock: D9146: efl_input_lock: rename to efl_input_key_lock.
Fri, Jun 21, 6:52 AM · efl (efl-1.23), efl: api
bu5hm4n added a revision to T7972: Efl.Input.Modifier: D9145: efl_input_modifiers: rename to efl_input_key_modifiers.
Fri, Jun 21, 6:52 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7971: Efl.Input.Lock.

@segfaultxavi on my dell laptop i can hit shift 5 times which activates the shift-lock. Differentence between those two: Make caps lock on, and press "-". Make shift lock on (or just hold it) and press "-".

Fri, Jun 21, 6:39 AM · efl (efl-1.23), efl: api
woohyun added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

Could you check the idea of @segfaultxavi ?

Fri, Jun 21, 5:03 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

@CHAN Why would you call it formatted_string_set? It's a property, so the _set and _get will be generated automatically for C.

Fri, Jun 21, 4:47 AM · efl: api, efl (efl-1.23), efl: language bindings
CHAN added a comment to T7898: efl.ui.format.

Yes, i do. I think there is nothing wrong with it.

Fri, Jun 21, 4:26 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7967: Efl.Input.Event.

So we agree one of the two sets of flags should be removed?

Fri, Jun 21, 2:52 AM · efl (efl-1.23), efl: api

Thu, Jun 20

zmike added a comment to T7967: Efl.Input.Event.

It does seem weird to have both.

Thu, Jun 20, 10:12 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to T7967: Efl.Input.Event.

OK, but that's weird, we have no such convenience proxies anywhere else.

Thu, Jun 20, 9:01 AM · efl (efl-1.23), efl: api
bu5hm4n triaged T8026: efl.ui.radio_box as TODO priority.
Thu, Jun 20, 8:43 AM · efl (efl-1.23), efl: language bindings
bu5hm4n triaged T8025: efl.ui.radio_group_impl as TODO priority.
Thu, Jun 20, 8:42 AM · efl (efl-1.23), efl: language bindings
bu5hm4n triaged T8024: efl.ui.radio_group as TODO priority.
Thu, Jun 20, 8:42 AM · efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7867: efl.ui.radio.
Thu, Jun 20, 8:40 AM · efl: api, efl (efl-1.23), efl: language bindings