I think this needs some naming changes:
Well, there is now. Kill. This. With. Fire.
Oh so you're imagining that there was a panel assembled to evaluate this API before it landed?
I am fine with this.
Well, if it's a list, it's fugly. Why don't we use an Eina list? or array? or literally ANY other thing before the words first, second, third, ...
This is how I would like this mixin to work:
It's a priority list. first means the first attempted layout to use, second is the fallback, third is the fallback if second doesn't work, ...
I would like to know the meaning of those extraterrestrial first, second, third, ... parameters to align_priority. What is that?
This seems okay now
I agree that it seems like align could be handled using align_hint.
I think if we are going with a priority system then the most bespoke one should be the highest priority. This would mean cb > values > string.
align_priority is (iirc) a way to specify how you prefer the popup to do layout if it is constrained. We may want to copy/research xdg-popup semantics for this (which I also wrote) since they're a bit more robust.
I just wanted to ensure we have thought about button as part, so this is fine to me :)
So action items for this here are :
- Change of Event type & Removal of struct type
- Write Tests. / Verify event emission / Veryfy funcitonal icon / str parts.
Yes, since Efl.Ui.Alert_Popup simply adds its buttons and button clicked event to Efl.Ui.Popup, extending Efl.Ui.Popup is enough for developer who needs a more flexible popup.
I also think using the enum in the event info is good enough, and that using parts would complicate things too much.
If anybody needs a more flexible popup, he can always extend from Efl.Ui.Popup, no?
Thank you for the opinion.
I agree with you about event info. Regardless of the original intention (why event info is structure), it seems that no new information is required for alert popup's button clicked event.
I think the max_size_hint is different with popup_size.
the max_size in efl_ui_popup means the maximum size that the popup can expand.
If the max_size_hint is used to change the popup size, the popup will not be expandable.
Therefore, I think it's not good to change popup_size to max_size_hint.
In case of the alignment API of popup, It is designed to notify the options to the users.
To use this API makes the code simple and easy.
Sat, Jun 22
The one side is the API, the other side is how we are *using* this API from the widget.
- Calendar does use efl_ui_format_cb internally, which means, setting the format_string to the object *does* changes the format_cb, which looks super weird to me. Additionally, the format_cb does not handle all the format symbols that others do.
- efl_ui_spin only works with format_cb, setting the string does not work.
- efl_ui_tags only works with format_cb, setting the string does not work.
Why do we need align_priority ?
The event looks a bit overengeneered to me. Why passing a struct if its just a enum in the struct ? I think passing Efl.Ui.Alert_Popup_Button as event type is totally enough.
I am wondering a little bit about align / popup_size.
Fri, Jun 21
Scrollbars can just ignore the inverted flag. We will document it. I think users will understand :)
@segfaultxavi on my dell laptop i can hit shift 5 times which activates the shift-lock. Differentence between those two: Make caps lock on, and press "-". Make shift lock on (or just hold it) and press "-".
Could you check the idea of @segfaultxavi ?
@CHAN Why would you call it formatted_string_set? It's a property, so the _set and _get will be generated automatically for C.
Yes, i do. I think there is nothing wrong with it.
So we agree one of the two sets of flags should be removed?
Thu, Jun 20
It does seem weird to have both.
OK, but that's weird, we have no such convenience proxies anywhere else.