Page MenuHomePhabricator

efl (efl-1.24)Milestone
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Today

segfaultxavi added a comment to T8455: Efl.Text.Formatter.

OK! T8579

Fri, Jan 17, 11:06 AM · efl (efl-1.24), efl: api
ali.alzyod added a comment to T8455: Efl.Text.Formatter.

@segfaultxavi I suggest we create TASK for future work related to this class, It will need more APIs and design

Fri, Jan 17, 10:09 AM · efl (efl-1.24), efl: api
ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D10968: efl_text_interactive: selection enhancment.
Fri, Jan 17, 10:06 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D11127: efl.ui.textbox: using efl_provider_find.
Fri, Jan 17, 10:05 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a comment to T8522: Efl.Ui.Textbox class.

I am okay with the API side, only one thing impacts the API right now:

  • _efl_ui_textbox_efl_layout_signal_signal_callback_add still has a problem, the object of the function callback will be wrong

what do you suggest? I look at other parts of the toolkit, and they use it the same way as in efl.ui.textbox (like efl_ui_image_zoomable and efl_ui_layout_base)

Fri, Jan 17, 10:05 AM · efl (efl-1.24), efl: api, efl: language bindings
zmike added a comment to T8476: efl_ui_animation_view.

Moving to efl.player is not very difficult, but we do not yet have an agreement about whether it would be useful to do so. We need opinions!

Fri, Jan 17, 6:22 AM · efl (efl-1.24), efl: api
segfaultxavi added a comment to T8455: Efl.Text.Formatter.

While trying to write a Rich Text Editor sample application I have come across a problem with this API.
The user cannot RETRIEVE the attributes of a text range.
This is important to know when the "bold" button should enable or disable bold text, depending on whether the text already contains the bold attribute.

Fri, Jan 17, 4:58 AM · efl (efl-1.24), efl: api
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

I am okay with the API side, only one thing impacts the API right now:

  • _efl_ui_textbox_efl_layout_signal_signal_callback_add still has a problem, the object of the function callback will be wrong
Fri, Jan 17, 4:23 AM · efl (efl-1.24), efl: api, efl: language bindings
woohyun added a comment to T8521: efl_text_interactive interface.

I think this looks ok now :)

Fri, Jan 17, 1:09 AM · efl (efl-1.24), efl: api, efl: language bindings

Yesterday

woohyun added a comment to T8522: Efl.Ui.Textbox class.

I'm also ok with current definition :)

Thu, Jan 16, 11:05 PM · efl (efl-1.24), efl: api, efl: language bindings
jsuya added a comment to T8476: efl_ui_animation_view.

Do we have any plans to move and implement autoplay and looping to Efl.Player?
Is there anything else I need to change in Efl.Ui.Vg_Animation before merging D10870?

Thu, Jan 16, 10:10 PM · efl (efl-1.24), efl: api
ali.alzyod added a comment to T8522: Efl.Ui.Textbox class.

This should be ready for stabilization , any more comments?

Thu, Jan 16, 8:26 AM · efl (efl-1.24), efl: api, efl: language bindings
jsuya added a commit to T8476: efl_ui_animation_view: rEFL2f4ca46544c9: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Thu, Jan 16, 3:14 AM · efl (efl-1.24), efl: api
segfaultxavi added a comment to T8501: Efl.Ui.Progressbar.

API-wise, there's not much more to discuss. Look right.

Thu, Jan 16, 3:00 AM · efl: api, efl (efl-1.24)
ali.alzyod added a comment to T8522: Efl.Ui.Textbox class.

Something else discovered due to reviewing D11107. _part_is_efl_ui_textbox_part returns valid parts for each and every part name. However, _efl_ui_textbox_text_set and _efl_ui_textbox_text_get do only work for "efl.text_guide" or "efl.text". I think we should change _part_is_efl_ui_textbox_part that it only works for "efl.text_guide" and "efl.text", for the rest EINA_FALSE should be returned.

Thu, Jan 16, 2:20 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D11109: efl.ui.textbox: update _part_is_efl_ui_textbox_part.
Thu, Jan 16, 2:20 AM · efl (efl-1.24), efl: api, efl: language bindings
jsuya added a commit to T8476: efl_ui_animation_view: rEFL3a4c5cf6a5f3: tests: Add test cases for Efl.Ui.Vg_Animation.
Thu, Jan 16, 12:51 AM · efl (efl-1.24), efl: api
woohyun added a commit to T8522: Efl.Ui.Textbox class: rEFL0b389a8338eb: efl_ui_textbox: rename efl_ui_text_part to efl_ui_textbox_part.
Thu, Jan 16, 12:51 AM · efl (efl-1.24), efl: api, efl: language bindings
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

Something else discovered due to reviewing D11107. _part_is_efl_ui_textbox_part returns valid parts for each and every part name. However, _efl_ui_textbox_text_set and _efl_ui_textbox_text_get do only work for "efl.text_guide" or "efl.text". I think we should change _part_is_efl_ui_textbox_part that it only works for "efl.text_guide" and "efl.text", for the rest EINA_FALSE should be returned.

Thu, Jan 16, 12:39 AM · efl (efl-1.24), efl: api, efl: language bindings
Diffusion added a commit to T8501: Efl.Ui.Progressbar: rEFL3ee174a5bf04: theme: remove not yet used groups.
Thu, Jan 16, 12:19 AM · efl: api, efl (efl-1.24)
Diffusion added a commit to T8501: Efl.Ui.Progressbar: rEFL3af2b57fd24b: efl_ui_progressbar: fix theming of progressbar.
Thu, Jan 16, 12:19 AM · efl: api, efl (efl-1.24)
Diffusion added a commit to T8501: Efl.Ui.Progressbar: rEFLb57d0aa571fb: efl_ui_progressbar: do not allow parts on unified widgets.
Thu, Jan 16, 12:18 AM · efl: api, efl (efl-1.24)

Wed, Jan 15

woohyun added a revision to T8522: Efl.Ui.Textbox class: D11107: efl_ui_textbox: rename efl_ui_text_part to efl_ui_textbox_part.
Wed, Jan 15, 2:39 PM · efl (efl-1.24), efl: api, efl: language bindings
zmike added a commit to T8476: efl_ui_animation_view: rEFLe71cfba201d9: elementary_test: Apply changed event related to Efl.Ui.Vg_Animation.
Wed, Jan 15, 6:24 AM · efl (efl-1.24), efl: api
zmike added a commit to T8476: efl_ui_animation_view: rEFLa63306a90878: efl/player: merge in and rework events from vg_animation.
Wed, Jan 15, 6:24 AM · efl (efl-1.24), efl: api
segfaultxavi added a commit to T8557: Pending work on gesture event structs: rEFL090df4331b9c: evas_gesture: change getter methods to read-only properties.
Wed, Jan 15, 5:40 AM · efl: api, efl: docs, efl (efl-1.24)
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

what is text_table, and why is it used ?

it is a container for guided text and internal interactive text

Wed, Jan 15, 2:10 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D11103: efl.ui.textbox: theme code cleanup.
Wed, Jan 15, 12:56 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a comment to T8522: Efl.Ui.Textbox class.

what is text_table, and why is it used ?

it is a container for guided text and internal interactive text

Wed, Jan 15, 12:54 AM · efl (efl-1.24), efl: api, efl: language bindings

Tue, Jan 14

ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D11102: efl.ui.textbox: part implementation comments clean up!.
Tue, Jan 14, 11:49 PM · efl (efl-1.24), efl: api, efl: language bindings
bu5hm4n added a comment to T8501: Efl.Ui.Progressbar.

Yeah i think keeping it is better. The API does not look wrong, i would implement it exactly the way it is now when ding the double progressbar. Additionally, removing it, means we have to refactor quite a lot of code, which will be simply duplicated by the time we introduce the double progressbar :)

Tue, Jan 14, 10:34 PM · efl: api, efl (efl-1.24)
jsuya added a revision to T8476: efl_ui_animation_view: D11100: elementary_test: Apply changed event related to Efl.Ui.Vg_Animation.
Tue, Jan 14, 8:49 PM · efl (efl-1.24), efl: api
woohyun added a comment to T8501: Efl.Ui.Progressbar.

Oh sorry - i somehow missed your reply.

True - i would then just guard the part get implementation that we can only use multiple parts when on the legacy widget, does that sounds fine ?

Tue, Jan 14, 8:30 PM · efl: api, efl (efl-1.24)
woohyun added a commit to T8522: Efl.Ui.Textbox class: rEFLd412f73a9974: efl_ui_textbox: mark @beta to cnp_mode and item_factory.
Tue, Jan 14, 8:20 AM · efl (efl-1.24), efl: api, efl: language bindings
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

I agree, lets keep these @beta.

Tue, Jan 14, 6:57 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod assigned T8531: Efl.Ui.Textbox multiline with scroller will make control height = 0 to AbdullehGhujeh.
Tue, Jan 14, 5:00 AM · efl (efl-1.24)
ali.alzyod closed T8549: elm_entry crash when setting text to "" as Resolved.
Tue, Jan 14, 4:10 AM · efl (efl-1.24)
Jaehyun_Cho added a revision to T8557: Pending work on gesture event structs: D11094: evas_gesture: change getter methods to read-only properties.
Tue, Jan 14, 4:08 AM · efl: api, efl: docs, efl (efl-1.24)
Jaehyun_Cho added a comment to T8450: efl.divisor_interpolator.

I agree with your opinion! Power_Interpolator :)

Tue, Jan 14, 4:07 AM · efl: api, efl (efl-1.24)
segfaultxavi added a comment to T8522: Efl.Ui.Textbox class.

I still don't know how factories work, I cannot help much here.
If you say it is not urgent, we can keep it beta, sure.

Tue, Jan 14, 2:36 AM · efl (efl-1.24), efl: api, efl: language bindings
woohyun added a revision to T8522: Efl.Ui.Textbox class: D11093: efl_ui_textbox: mark @beta to cnp_mode and item_factory.
Tue, Jan 14, 12:57 AM · efl (efl-1.24), efl: api, efl: language bindings
woohyun added a comment to T8522: Efl.Ui.Textbox class.

I hope to keep "item_factory" as @beta one.
This is because current definition of Textblock_Factory can be developed with better way (T8568).

Tue, Jan 14, 12:37 AM · efl (efl-1.24), efl: api, efl: language bindings

Mon, Jan 13

ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D11092: efl.ui.textbox: add efl.input text as composite interface.
Mon, Jan 13, 11:40 PM · efl (efl-1.24), efl: api, efl: language bindings
Jaehyun_Cho added a comment to T8557: Pending work on gesture event structs.

Thank you for your reply! Now I understand your point and I agree with you.

  • NOW : radius_get { } for Efl.Canvas.Gesture_Zoom
  • TODO : @property radius { get { } } for Efl.Canvas.Gesture_Zoom
Mon, Jan 13, 6:27 PM · efl: api, efl: docs, efl (efl-1.24)
segfaultxavi added a comment to T8476: efl_ui_animation_view.

I'm OK with stating in the video docs that autorepeat is ignored. Then again, it does not look very hard to implement either...

Mon, Jan 13, 10:05 AM · efl (efl-1.24), efl: api
zmike added a comment to T8476: efl_ui_animation_view.

I've done the work to remove the events from this and put them in efl.player, so this is taken care of. We can independently evaluate the implementation of those events in existing efl.player interface users once we stabilize those events.

Mon, Jan 13, 10:01 AM · efl (efl-1.24), efl: api
zmike added a revision to T8476: efl_ui_animation_view: D11080: efl/player: merge in and rework events from vg_animation.
Mon, Jan 13, 9:53 AM · efl (efl-1.24), efl: api
zmike added a comment to T8476: efl_ui_animation_view.

My point regarding autoplay/autorepeat was that they could potentially be moved to efl.player, not that they could be combined.

Mon, Jan 13, 6:37 AM · efl (efl-1.24), efl: api
bu5hm4n added a revision to T8501: Efl.Ui.Progressbar: D11077: theme: remove not yet used groups.
Mon, Jan 13, 6:11 AM · efl: api, efl (efl-1.24)
bu5hm4n added a revision to T8501: Efl.Ui.Progressbar: D11076: efl_ui_progressbar: fix theming of progressbar.
Mon, Jan 13, 6:11 AM · efl: api, efl (efl-1.24)