HomePhabricator

elm_focus_legacy: Fix resource leaks

Authored by devilhorns on Mar 18 2019, 11:47 AM.

Description

elm_focus_legacy: Fix resource leaks

Summary:
Coverity reports 2 resource leaks here because old_chain & new_chain
are never freed if we fail to return widget data. Use just
ELM_WIDGET_DATA_GET, manually check for valid 'ppd' and if false we
can just break out of the for loop here.

Fixes Coverity CID1399096, CID1399095

@fix

Depends on D8352

Reviewers: raster, cedric, zmike, bu5hm4n, stefan_schmidt

Reviewed By: cedric, bu5hm4n

Subscribers: reviewers, committers

Tags: efl

Differential Revision: https://phab.enlightenment.org/D8353

Details

Committed
devilhornsMar 18 2019, 11:47 AM
Reviewer
cedric
Differential Revision
D8353: elm_focus_legacy: Fix resource leaks
Parents
rEFLcced5487c83c: efl_ui_layout: call efl_del instead of efl_unref when text part does not exist
Branches
Unknown
Tags
Unknown