HomePhabricator

efl-mono: Add extra constructors to Eina.Value

Authored by segfaultxavi on Jan 11 2019, 5:28 AM.

Description

efl-mono: Add extra constructors to Eina.Value

Summary:
new Eina.Value(0) is a special case. The 0 is silently converted
to an enum (Eina.ValueType) and therefore the call is ambiguous
with the 0 being first converted to an Eina.Value via the implicit
conversion operator (calling the Eina.Value deep copy constructor).
Adding constructors for all supported types solves the problem because
they have higher priority. Also, they avoid one deep copy of the
Eina.Value.

Includes test case to catch this problem in the future. This was discovered
in the tutorials, where new Eina.Value(0) is being used.

Test Plan:
The src/efl_reference_core_event.exe example from the examples repo was
not compiling before, and now it is.
make check and make examples still work as expected.

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, reviewers, committers

Tags: efl

Differential Revision: https://phab.enlightenment.org/D7598

Details

Committed
segfaultxaviJan 11 2019, 5:51 AM
Reviewer
lauromoura
Differential Revision
D7598: efl-mono: Add extra constructors to Eina.Value
Parents
rEFL3ddd577fb0c6: efl: refactor all mixins
Branches
Unknown
Tags
Unknown