HomePhabricator

ecore-con/legacy: kill server with DEL event if a dialer error occurs

Authored by zmike on Jul 3 2018, 9:42 AM.

Description

ecore-con/legacy: kill server with DEL event if a dialer error occurs

Summary:
in the course of the efl-net rewrite, the previous relied-upon behavior
sequence of error -> disconnect -> del was broken, and error events no
longer triggered disconnects or server deletion.

the failure was caused by a check for the 'connecting' flag, preventing
DEL events from being triggered

further, the ordering of the events was flipped from ERROR -> DEL to
DEL -> ERROR; this is also fixed now

this caused any failed connection to leak the entire server connection
since existing handlers for the del event were never triggered and the
server was never destroyed

@fix
fix T6330

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, committers

Tags: efl

Maniphest Tasks: T6330

Differential Revision: https://phab.enlightenment.org/D6481