HomePhabricator

elm/genlist: remove calc jobs

Authored by zmike on Oct 21 2019, 1:05 PM.

Description

elm/genlist: remove calc jobs

now that we have a sane and consistent sizing calc mechanism, we no longer
need to be randomly creating jobs to do additional side calcs in addition
to our other multiple bespoke calculation methods

instead, we can now call the calc function directly during the group calc
to perform all the calcs at once and avoid the overhead of constantly triggering
calc jobs

a possible future improvement here could be to remove the _calc_job() call in
the internal pan object's group_calculate, as this is likely a duplicated op
but it will require additional testing to verify

unit test performance (e.g., tree) increases roughly 50-80% after this patch

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10523

Details

Committed
zmikeOct 31 2019, 6:56 AM
Differential Revision
D10523: elm/genlist: remove calc jobs
Parents
rEFL0fce67796b43: elm/genlist: don't process entire item queue on each item add
Branches
Unknown
Tags
Unknown