Page MenuHomePhabricator

Active Work ProposalProject
ArchivedPublic

Members

  • This project does not have any members.

Watchers

  • This project does not have any watchers.

Details

Description

A work proposal which has been voted on and accepted

Recent Activity

Oct 17 2019

zmike edited projects for T8162: C#: .cs file naming with PascalCase, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:04 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
zmike edited projects for T7122: Refactor register API of Efl.Ui.Focus.Manager.Calc, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:04 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, Restricted Project
zmike edited projects for T7123: Refactor manager setting from efl_ui_widget to efl_ui_focus_manager, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:04 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, Restricted Project
zmike edited projects for T7124: Make Efl.Ui.Layout inherit composition, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:04 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, Restricted Project
zmike edited projects for T7125: Move widget registration from efl.ui.widget to efl.ui.focus.composition, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:04 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, Restricted Project
zmike edited projects for T7221: efl_selection_manager: implement full clipboard support, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, efl: widgets, Restricted Project
zmike edited projects for T7171: Rename ecore_wl2, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: display system, enlightenment-git, major change
zmike edited projects for T7183: remove efl.git/src/benchmarks, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, efl: rendering, efl: data types, major change
zmike edited projects for T7182: split legacy examples into examples repo as submodule, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, major change, Restricted Project, efl: docs
zmike edited projects for T7208: elm_code: Make the widget 100% reliable and ready for Eo API implementation, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, efl: widgets: code, Restricted Project
zmike edited projects for T6127: Provide documentation for C#, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, major change, efl: docs
zmike edited projects for T7231: Finish support for multiple outputs in Wayland/Drm2, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, major change, enlightenment-git, efl: display system
zmike edited projects for T7752: C#: Get rid of all lower-cased methods, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
zmike edited projects for T8165: C#: Hide unecessary API, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
zmike edited projects for T7204: Discussion about C# binding syntax, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings

Sep 23 2019

Jaehyun_Cho closed T8167: C#: Fix indentation and blanklines as Resolved.

@lauromoura yes! thank you :)

Sep 23 2019, 6:58 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
Jaehyun_Cho closed T8167: C#: Fix indentation and blanklines, a subtask of T7204: Discussion about C# binding syntax, as Resolved.
Sep 23 2019, 6:58 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a revision to T7752: C#: Get rid of all lower-cased methods: D10102: csharp: Hide internal stuff from editors..
Sep 23 2019, 6:29 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a revision to T8165: C#: Hide unecessary API: D10102: csharp: Hide internal stuff from editors..
Sep 23 2019, 6:29 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8167: C#: Fix indentation and blanklines.

D9712 seems to have resolved this. Can we close this one @Jaehyun_Cho ?

Sep 23 2019, 5:45 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings

Sep 20 2019

lauromoura moved T8165: C#: Hide unecessary API from Backlog to InProgress on the efl: language bindings board.
Sep 20 2019, 3:32 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura moved T8167: C#: Fix indentation and blanklines from Backlog to InProgress on the efl: language bindings board.
Sep 20 2019, 3:32 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8165: C#: Hide unecessary API.

If "inherited generated classes" are eo custom classes that inherited efl classes, internal will occur compiler error.

Sep 20 2019, 8:29 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings

Sep 16 2019

YOhoho added a comment to T8165: C#: Hide unecessary API.

If "inherited generated classes" are eo custom classes that inherited efl classes, internal will occur compiler error.
e.g.

mcs -d:EFL_BETA -target:library -out:src/tests/efl_mono/efl_mono_test.dll -r:src/bindings/mono/efl_mono.dll src/tests/efl_mono/dummy_child.eo.cs src/tests/efl_mono/dummy_numberwrapper.eo.cs src/tests/efl_mono/dummy_test_object.eo.cs src/tests/efl_mono/dummy_test_iface.eo.cs src/tests/efl_mono/dummy_inherit_helper.eo.cs src/tests/efl_mono/dummy_inherit_iface.eo.cs src/tests/efl_mono/dummy_part_holder.eo.cs src/tests/efl_mono/dummy_event_manager.eo.cs src/tests/efl_mono/dummy_constructible_object.eo.cs
src/tests/efl_mono/dummy_part_holder.eo.cs(83,80): error CS0122: `Efl.PartConcrete.NativeMethods.efl_part_get_ptr' is inaccessible due to its protection level

With this patch

diff --git a/src/bin/eolian_mono/eolian/mono/function_definition.hh b/src/bin/eolian_mono/eolian/mono/function_definition.hh
index a0f28df..149272a 100644
--- a/src/bin/eolian_mono/eolian/mono/function_definition.hh
+++ b/src/bin/eolian_mono/eolian/mono/function_definition.hh
@@ -61,7 +61,7 @@ struct native_function_definition_generator
     if(!as_generator
        (
         indent << eolian_mono::marshall_annotation(true) << "\n"
-        << indent << "public delegate "
+        << indent << "internal delegate "
         << eolian_mono::marshall_type(true)
         << " "
         << string << "_api_delegate(" << (f.is_static ? "" : "System.IntPtr obj")
@@ -76,7 +76,7 @@ struct native_function_definition_generator
Sep 16 2019, 5:04 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings

Sep 13 2019

brunobelo closed T8163: C#: Event naming as Resolved.
Sep 13 2019, 6:46 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
brunobelo closed T8163: C#: Event naming, a subtask of T7204: Discussion about C# binding syntax, as Resolved.
Sep 13 2019, 6:46 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
brunobelo closed T8164: C#: Event args suffix as Resolved.
Sep 13 2019, 6:46 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
brunobelo closed T8164: C#: Event args suffix, a subtask of T7204: Discussion about C# binding syntax, as Resolved.
Sep 13 2019, 6:46 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings

Sep 12 2019

brunobelo added a commit to T8166: C#: Remove I prefix from regular classes: rEFLb36e159d313b: eolian-mono: Removing I prefix from classes..
Sep 12 2019, 11:49 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
brunobelo added a commit to T8163: C#: Event naming: rEFL353524e1b89d: eolian-mono: Renaming suffix for event and event args.
Sep 12 2019, 11:47 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
brunobelo added a commit to T8164: C#: Event args suffix: rEFL353524e1b89d: eolian-mono: Renaming suffix for event and event args.
Sep 12 2019, 11:46 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings

Sep 9 2019

lauromoura lowered the priority of T8162: C#: .cs file naming with PascalCase from High to Wishlist.

@lauromoura
It is confirmed that SA1402 is not mandatory but it is recommended.

Since SA1402 is problematic with eo and SA1402 requires additional effort, I think it would be better we do not apply SA1402 for now.

We focus on other mandatory rules and major issues and then we may consider SA1402 later when we are able to do it.

Sep 9 2019, 2:05 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura closed T8166: C#: Remove I prefix from regular classes as Resolved.

Resolved in D9816

Sep 9 2019, 2:04 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura closed T8166: C#: Remove I prefix from regular classes, a subtask of T7204: Discussion about C# binding syntax, as Resolved.
Sep 9 2019, 2:04 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings

Sep 4 2019

Jaehyun_Cho added a comment to T8162: C#: .cs file naming with PascalCase.

@lauromoura
It is confirmed that SA1402 is not mandatory but it is recommended.

Sep 4 2019, 11:32 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
Jaehyun_Cho added a comment to T8162: C#: .cs file naming with PascalCase.

@lauromoura
I will ask the reporter who raised this issue in detail and I will let you know.

Sep 4 2019, 4:24 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings

Sep 3 2019

lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

If actually needed, we could disable this rule for generated code and keep it only for the manual code.

Sep 3 2019, 11:46 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

@Jaehyun_Cho, what would be the reason for these requirements? (We're not questioning them, just trying to understand the issue better. :) )

The main reason is to make class name and cs file name same :)
As you know, efl_ui_layout.eo.cs contains class Layout in the namespace Efl and Ui.
Therefore, it was suggested that efl_ui_layout.eo.cs should be renamed to Layout.cs which is the same name with class Layout. And Layout.cs should be moved to Efl.Ui namespace directory to avoid duplicate cs file names.

Sep 3 2019, 11:44 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
Jaehyun_Cho added a comment to T8162: C#: .cs file naming with PascalCase.

This may be hard with meson. See my first comment on its limitations.

I totally understand. If it is hard on upstream with meson, then I consider that I run some script manually to generate directories and change the cs names only for Tizen.

Sep 3 2019, 12:12 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings

Sep 2 2019

lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

@segfaultxavi
The main issues of this task are as follows.

  1. All C# source files (.cs) should be located in the directory named fully-qualified namespace.
    • e.g. cs file for class Efl.A.cs should be located in directory Efl. This means that Efl/A.cs
Sep 2 2019, 10:52 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
Jaehyun_Cho added a comment to T8162: C#: .cs file naming with PascalCase.

@segfaultxavi
The main issues of this task are as follows.

Sep 2 2019, 10:37 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: language bindings
brunobelo added a revision to T8166: C#: Remove I prefix from regular classes: D9816: eolian-mono: Removing I prefix from classes..
Sep 2 2019, 1:47 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
Jaehyun_Cho added a comment to T8164: C#: Event args suffix.

Sorry I missed D9692, I've reverted ac99e2ac9410d5b2ef6225fa1aaaf9ffcd6578fb

Sep 2 2019, 5:43 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
Jaehyun_Cho added a comment to T8164: C#: Event args suffix.

For now, I've removed the underscore of Evt_Args by ac99e2ac9410d5b2ef6225fa1aaaf9ffcd6578fb

Sep 2 2019, 5:30 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings

Aug 30 2019

brunobelo added a revision to T8163: C#: Event naming: D9692: eolian-mono: Renaming suffix for event and event args.
Aug 30 2019, 7:15 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura renamed T8166: C#: Remove I prefix from regular classes from C#: Remove I prefix from argument structs for class events to C#: Remove I prefix from regular classes.
Aug 30 2019, 5:58 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
Jaehyun_Cho added a comment to T8166: C#: Remove I prefix from regular classes.

Can we change this task name?

Aug 30 2019, 4:58 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings

Aug 28 2019

segfaultxavi added a comment to T8163: C#: Event naming.

.... and there's talk of using C for classes ...

Is there? O_o

Aug 28 2019, 2:31 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings

Aug 27 2019

lauromoura added a comment to T8163: C#: Event naming.

Trying to automatically convert eo event names to verbs in the past tense is going to be an nightmare :)

Aug 27 2019, 11:44 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8166: C#: Remove I prefix from regular classes.

Just to be sure, we're talking about removing the I prefix from the EventArgs classes, no? This makes sense.

Aug 27 2019, 9:26 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings