Page MenuHomePhabricator

DO NOT MERGEProject
ActivePublic

Members

  • This project does not have any members.

Watchers

  • This project does not have any watchers.

Details

Description

For patches which should not yet be merged

Recent Activity

Wed, Jan 16

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Remove resize object again. :(

Wed, Jan 16, 12:46 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

optimize chain_calc

Wed, Jan 16, 12:39 AM · efl

Tue, Jan 15

segfaultxavi added a project to D7620: efl-api: Mark Efl.Io.Reader as stable: DO NOT MERGE.
Tue, Jan 15, 5:45 AM · DO NOT MERGE, efl
segfaultxavi added a project to D7619: efl-api: Mark Efl.Io.Writer as stable: DO NOT MERGE.
Tue, Jan 15, 5:45 AM · DO NOT MERGE, efl
segfaultxavi added a project to D7618: efl-api: Mark Efl.Io.Closer as stable: DO NOT MERGE.
Tue, Jan 15, 5:36 AM · DO NOT MERGE, efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Remove resize object. it is unnecessary.

Tue, Jan 15, 12:47 AM · efl

Mon, Jan 14

SanghyeonLee added a project to D7614: efl_ui : add dummy object for verificate factory class.: DO NOT MERGE.
Mon, Jan 14, 9:38 PM · DO NOT MERGE, efl
segfaultxavi accepted D7524: efl_ui_relative_layout: introduce new relative container.

Nice docs! I am approving, but only documentation-wise :)

Mon, Jan 14, 8:58 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Add documentations.

Mon, Jan 14, 3:50 AM · efl

Sun, Jan 13

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. rebase
  2. refactoring
  3. add more tests
  4. implement chain relation (efl_ui_relative_layout_example_02)
Sun, Jan 13, 10:13 PM · efl

Fri, Jan 11

ManMower added a child revision for D7588: evas: Make clipee list removal O(1): D7609: ecore_evas: Don't walk mice list twice.
Fri, Jan 11, 11:21 AM · DO NOT MERGE, efl

Thu, Jan 10

zmike updated subscribers of D7588: evas: Make clipee list removal O(1).
Thu, Jan 10, 11:42 AM · DO NOT MERGE, efl
zmike added a comment to D7588: evas: Make clipee list removal O(1).

Oh this seems like it could relate to some of the performance improvements speculated on by @raster in D7471. I wonder how this might impact any potential gains which blist could have provided?

Thu, Jan 10, 11:41 AM · DO NOT MERGE, efl
cedric added a comment to D7588: evas: Make clipee list removal O(1).

This is really interesting. I am wondering what the memory impact will really be. We moved clipper into the COW part of Evas_Object as it wasn't used that much. So my guess is that it shouldn't impact memory consumption that much. Still I would be interested to get a memory profile of elementary_test, enlightenment and terminology and see what it says.

Thu, Jan 10, 10:50 AM · DO NOT MERGE, efl
ManMower added reviewers for D7588: evas: Make clipee list removal O(1): cedric, raster.

Ticket D7471 proposes a new list technique with some compelling cache efficiency and memory usage characteristics. However, one of the things it's not great at is removes, as it has no equivalent to eina_list_remove_list, which is an O(1) list removal.

Thu, Jan 10, 8:32 AM · DO NOT MERGE, efl

Wed, Jan 9

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Rebase and remove relation_dir_to_set, relation_dir_relative_set apis.

Wed, Jan 9, 8:24 PM · efl
YOhoho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

@cedric
Agreed.

relation_left_set(Eo *obj, Eo *child, Eo *target, double relative);

Would cover all cases passing NULL.

Wed, Jan 9, 8:21 PM · efl
cedric added a comment to D7524: efl_ui_relative_layout: introduce new relative container.
  1. add elementary_test example.
  2. rename to left, right, top, bottom.
  3. remove register api. (when a child have relation, it is registered)

    I want overload relation_#direction# apis. for example,
  4. relation_left_set(Eo *obj, Eo *child, Eo *target) to set only to.
  5. relation_left_set(Eo *obj, Eo *child, double relative) to set only relative.
  6. relation_left_set(Eo *obj, Eo *child, Eo *target, double relative) to set both to and relative.

    However, EO doesn't support method overloading. so there are xxx_to, xxx_relative apis.
Wed, Jan 9, 12:21 PM · efl
YOhoho updated the test plan for D7524: efl_ui_relative_layout: introduce new relative container.
Wed, Jan 9, 4:33 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

update a meson builf file

Wed, Jan 9, 4:05 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. add elementary_test example.
  2. rename to left, right, top, bottom.
  3. remove register api. (when a child have relation, it is registered)
Wed, Jan 9, 4:03 AM · efl

Mon, Jan 7

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

implement margin

Mon, Jan 7, 5:57 PM · efl
segfaultxavi requested changes to D7524: efl_ui_relative_layout: introduce new relative container.

OK, I'll wait for the new docs before reviewing. I am rejecting this version so we do not forget and this patch gets merged without documentation :)

Mon, Jan 7, 9:32 AM · efl
YOhoho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

I am not to sure of the name of this new class as it doesn't express in the name the fact that it is a container. Also, and it is something that I am sure @segfaultxavi will point out, it is lacking a lot of documentation :-)

Mon, Jan 7, 2:40 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Rename to Efl.Ui.Relative_Layout

Mon, Jan 7, 2:02 AM · efl

Sun, Jan 6

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. Rename Efl_Ui_Relative_Param -> Efl_Ui_Relative_Relation and integrate rel1 and rel2.
  2. (API) Rename rel1 -> left, rel2 -> right for intuitive names.
  3. Add Get method for properies.
  4. Update Class Diagram (check above comment)
Sun, Jan 6, 11:54 PM · efl

Fri, Jan 4

cedric added a reviewer for D7524: efl_ui_relative_layout: introduce new relative container: segfaultxavi.

I am not to sure of the name of this new class as it doesn't express in the name the fact that it is a container. Also, and it is something that I am sure @segfaultxavi will point out, it is lacking a lot of documentation :-)

Fri, Jan 4, 6:09 PM · efl
Jaehyun_Cho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Could you move the definition of struct Efl.Ui.Relative_Params to efl_ui_relative.eo file?

Fri, Jan 4, 3:18 AM · efl

Sun, Dec 30

kimcinoo added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Interesting :D

Sun, Dec 30, 2:05 PM · efl

Fri, Dec 28

YOhoho added a project to D7524: efl_ui_relative_layout: introduce new relative container: DO NOT MERGE.
Fri, Dec 28, 12:27 AM · efl

Dec 4 2018

vitor.sousa accepted D7394: eolian_mono: Add support for C# style properties.
Dec 4 2018, 10:42 AM · efl: language bindings
lauromoura updated the diff for D7394: eolian_mono: Add support for C# style properties.

Update generating documentation for properties.

Dec 4 2018, 9:58 AM · efl: language bindings
segfaultxavi requested changes to D7394: eolian_mono: Add support for C# style properties.

On a second thought... properties should have documentation :)

Dec 4 2018, 4:26 AM · efl: language bindings
lauromoura updated the diff for D7394: eolian_mono: Add support for C# style properties.

Rebase.

Dec 4 2018, 3:53 AM · efl: language bindings
segfaultxavi accepted D7394: eolian_mono: Add support for C# style properties.

Meanwhile, as the patch just adds new functionality, we could merge it, and once these three properties are dealt with a new commit would remove them from the blacklist and turn the Getters/Setters private.

Dec 4 2018, 2:56 AM · efl: language bindings

Dec 3 2018

lauromoura added a comment to D7394: eolian_mono: Add support for C# style properties.

Only renaming the interfaces won't be enough. As per IRC discussion, these three properties have conflicts: Efl.Ui.Text.Text, Efl.Input.Key.Key and Efl.Input.Hold.Hold. I guess the easiest solution is to just rename either the property or the type (whatever is easier) instead of trying to come up with a clever C# trick. I'm working on a proposal.

Dec 3 2018, 1:45 PM · efl: language bindings
segfaultxavi added a comment to D7394: eolian_mono: Add support for C# style properties.

Only renaming the interfaces won't be enough. As per IRC discussion, these three properties have conflicts: Efl.Ui.Text.Text, Efl.Input.Key.Key and Efl.Input.Hold.Hold. I guess the easiest solution is to just rename either the property or the type (whatever is easier) instead of trying to come up with a clever C# trick. I'm working on a proposal.

Dec 3 2018, 10:04 AM · efl: language bindings
segfaultxavi added a comment to D7394: eolian_mono: Add support for C# style properties.

6ec6d93535ebda03e1a4fac28b13d81b9ec79ee7 fixed make check for me.

Dec 3 2018, 3:13 AM · efl: language bindings

Nov 30 2018

lauromoura added a comment to D7394: eolian_mono: Add support for C# style properties.

Well, just renaming the interfaces wouldn't be enough, as implementing classes like Efl.Ui.Text would still conflict when they implement the interface property.

Nov 30 2018, 5:28 PM · efl: language bindings
lauromoura updated the diff for D7394: eolian_mono: Add support for C# style properties.

Updated version supporting interface properties.

Nov 30 2018, 12:49 PM · efl: language bindings
lauromoura edited projects for D7394: eolian_mono: Add support for C# style properties, added: efl: language bindings, DO NOT MERGE; removed efl.
Nov 30 2018, 12:48 PM · efl: language bindings

Nov 28 2018

bu5hm4n abandoned D6578: elm_scroller: mark the scroller as regular focus element.
Nov 28 2018, 1:16 PM · DO NOT MERGE, efl

Nov 5 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

fix conflicts and rebasing commits

Nov 5 2018, 3:12 AM · efl

Nov 1 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

rebasing commit

Nov 1 2018, 10:53 PM · efl

Oct 22 2018

YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

I guess problem is that scroller have focusable dummy element when it doesn't have focusable content. but it is not included in pd->iterator_list in _efl_ui_focus_manager_root_focus_efl_ui_focus_manager_border_elements_get. so, scroller can't find focusable element.

Oct 22 2018, 4:22 AM · DO NOT MERGE, efl
YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

I meant focus move policy when scroller have focusable content.
The interaction problem between scroller and other widget is focus manager side issue.

Oct 22 2018, 1:19 AM · DO NOT MERGE, efl
bu5hm4n updated subscribers of D6578: elm_scroller: mark the scroller as regular focus element.

Yes - you said that @eagleeye will handle it and assigned it to him... https://phab.enlightenment.org/D6587#118371

Oct 22 2018, 12:15 AM · DO NOT MERGE, efl

Oct 21 2018

YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

@bu5hm4n
ping, scroller which have no content still can't get focus

Oct 21 2018, 8:16 PM · DO NOT MERGE, efl

Oct 15 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

Update grid widget and test / examples

  • update wrong grid item position calculation
  • update grid test with scrolls
  • update grid example to test vertical case with text
Oct 15 2018, 5:28 AM · efl

Oct 12 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

update test cases and themes.

Oct 12 2018, 4:33 AM · efl