Page MenuHomePhabricator

DO NOT MERGEProject
ActivePublic

Members

  • This project does not have any members.

Watchers

  • This project does not have any watchers.

Details

Description

For patches which should not yet be merged

Recent Activity

May 27 2020

bu5hm4n updated the diff for D11808: build: time for efl-one.

Final update

May 27 2020, 12:55 AM · efl
bu5hm4n updated the diff for D11806: refactor build.

Final update

May 27 2020, 12:54 AM · efl
bu5hm4n updated the diff for D11805: build: split up building of libs, bins, modules, benchmark.

Final update

May 27 2020, 12:54 AM · efl

May 26 2020

stefan_schmidt requested changes to D11808: build: time for efl-one.

A few last comments. With them fixed I think this one is ready to go.

May 26 2020, 6:58 AM · efl
stefan_schmidt accepted D11806: refactor build.

Besides the subject of the commit message I am happy with this.

May 26 2020, 6:53 AM · efl
stefan_schmidt added a comment to D11806: refactor build.

Mybe change subject to: build: refactor dependency handling ?

May 26 2020, 6:38 AM · efl
stefan_schmidt added a comment to D11805: build: split up building of libs, bins, modules, benchmark.

My two earlier comments still need to be addressed, after that its ready.

May 26 2020, 6:37 AM · efl
stefan_schmidt added a comment to D11808: build: time for efl-one.

The build time concerns have been fixed and a build without the efl-one option set will not have a build time penalty anymore.

May 26 2020, 3:03 AM · efl
bu5hm4n added a child revision for D11808: build: time for efl-one: D11883: build: stop buildsystem from beeing a public dependency.
May 26 2020, 2:41 AM · efl
bu5hm4n updated the diff for D11806: refactor build.

fix evas bug

May 26 2020, 1:48 AM · efl
bu5hm4n updated the diff for D11808: build: time for efl-one.

rebase on master

May 26 2020, 1:28 AM · efl
bu5hm4n updated the diff for D11806: refactor build.

rebase on master

May 26 2020, 1:28 AM · efl
bu5hm4n updated the diff for D11805: build: split up building of libs, bins, modules, benchmark.

rebase on master

May 26 2020, 1:27 AM · efl

May 25 2020

bu5hm4n updated the diff for D11808: build: time for efl-one.

fix wrong package_c_args defines

May 25 2020, 6:53 AM · efl
bu5hm4n updated the diff for D11806: refactor build.

fix comments

May 25 2020, 6:53 AM · efl
bu5hm4n updated the diff for D11805: build: split up building of libs, bins, modules, benchmark.

rebase

May 25 2020, 6:52 AM · efl

May 15 2020

bu5hm4n added a comment to D11806: refactor build.

The files changes are needed as we are building the library now outside the library folder, which means we need a file object instead of a random string, interpreted as a path.

May 15 2020, 3:45 AM · efl
bu5hm4n added a comment to D11808: build: time for efl-one.

Yeah that is expected. We need to build each and every shared object lib again as a static library, which doubles the amount of libraries we are building, that is sadly nothing we can get around right now.

May 15 2020, 3:37 AM · efl
stefan_schmidt added a comment to D11808: build: time for efl-one.

When doing some first build tests with this I saw a jump in ninja build targets from 3600 to 5800 without efl-one set and 5200 with it set. Is this to be expected due to the different ordering?

May 15 2020, 3:09 AM · efl
stefan_schmidt requested changes to D11806: refactor build.
May 15 2020, 2:58 AM · efl
stefan_schmidt added a comment to D11806: refactor build.

I was also wondering about the files() changes all over the place. Is this for better work with newer meson versions or is this related to refactor in a way I do not understand?

May 15 2020, 2:51 AM · efl

May 14 2020

stefan_schmidt requested changes to D11805: build: split up building of libs, bins, modules, benchmark.
May 14 2020, 7:14 AM · efl

May 10 2020

bu5hm4n added a project to D11806: refactor build: DO NOT MERGE.
May 10 2020, 7:03 AM · efl
bu5hm4n added a project to D11808: build: time for efl-one: DO NOT MERGE.
May 10 2020, 7:02 AM · efl
bu5hm4n added a parent revision for D11805: build: split up building of libs, bins, modules, benchmark: D11807: Merge efreet_mime efreet_trash into efreet.
May 10 2020, 6:58 AM · efl
bu5hm4n abandoned D11804: refactor build.
May 10 2020, 6:56 AM · DO NOT MERGE, efl
bu5hm4n added a project to D11805: build: split up building of libs, bins, modules, benchmark: DO NOT MERGE.
May 10 2020, 6:55 AM · efl
bu5hm4n added a project to D11804: refactor build: DO NOT MERGE.
May 10 2020, 6:49 AM · DO NOT MERGE, efl

Mar 20 2020

segfaultxavi added a comment to D11548: eo-files: reorder some functions.

Classes and methods inside classes are already sorted alphabetically in C docs:
https://www.enlightenment.org/develop/api/efl/object
and in C# docs:
https://enlightenment.github.io/www-content/gh-pages/api/csharp/api/Efl.Object.html
so don't worry about me.

Mar 20 2020, 10:27 AM · DO NOT MERGE, efl
zmike updated subscribers of D11548: eo-files: reorder some functions.

This should only affect the C implementation code. We should likely alphabetize any doc generation (cc @segfaultxavi) so that we get consistent docs generated regardless of eo file ordering.

Mar 20 2020, 7:23 AM · DO NOT MERGE, efl
bu5hm4n added a project to D11548: eo-files: reorder some functions: DO NOT MERGE.

Even if this pays off, i dont know if its really worth it doing that, as the reordering of .eo files seems quite a bit random. Do we really want that ? I will just put the revision here so we can discuss it, maybe we need a better way to do this. (This is also a heavy platform specific depending topic)

Mar 20 2020, 7:21 AM · DO NOT MERGE, efl

Mar 8 2020

Diffusion closed D11018: eina: introduce Eina_Abstract_Content.
Mar 8 2020, 3:02 AM · DO NOT MERGE, efl

Mar 3 2020

bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

rebase & update the complete stack to work arround issues

Mar 3 2020, 4:27 AM · DO NOT MERGE, efl

Feb 26 2020

segfaultxavi removed a parent revision for D11018: eina: introduce Eina_Abstract_Content: D11062: eina: introduce eina_iterator_process.
Feb 26 2020, 7:59 AM · DO NOT MERGE, efl

Feb 15 2020

bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

fixes & rebase

Feb 15 2020, 12:52 PM · DO NOT MERGE, efl

Feb 14 2020

bu5hm4n abandoned D10825: eo: do not free these values here.

this is wrong.

Feb 14 2020, 8:23 AM · DO NOT MERGE, efl

Feb 13 2020

segfaultxavi accepted D11018: eina: introduce Eina_Abstract_Content.

No more questions, Your Honor.

Feb 13 2020, 12:23 AM · DO NOT MERGE, efl

Feb 12 2020

bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

naming fixes

Feb 12 2020, 11:41 AM · DO NOT MERGE, efl
segfaultxavi requested changes to D11018: eina: introduce Eina_Abstract_Content.
Feb 12 2020, 7:05 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

More fixes and progress

Feb 12 2020, 5:51 AM · DO NOT MERGE, efl

Feb 7 2020

devilhorns abandoned D7881: wayland: Rename ecore_wl2 to notstable.
Feb 7 2020, 5:27 AM · DO NOT MERGE, efl
devilhorns commandeered D7881: wayland: Rename ecore_wl2 to notstable.
Feb 7 2020, 5:26 AM · DO NOT MERGE, efl

Jan 31 2020

cedric accepted D11018: eina: introduce Eina_Abstract_Content.

Except for the minor cosmetic of the .h file name not matching the function name, I am good with this. You might want to add a _unregister function as some of the register could be done in a module and disappear at any point.

Jan 31 2020, 10:05 AM · DO NOT MERGE, efl

Jan 28 2020

zmike added a comment to D11205: ecore/input: attempt to more accurately handle multi-touch mouse-in events.

Unfortunately we don't have a way to detect it with the current infrastructure because the device will be 0 in the case of pointer events when it should probably be -1.

Jan 28 2020, 10:11 AM · DO NOT MERGE
bu5hm4n added a comment to D11205: ecore/input: attempt to more accurately handle multi-touch mouse-in events.

I somehow still do not like that we sent a MOVE before the DOWN event of the first finger, but not for the second finger, that feels absolutly inconsistant. IMO we either do not have move before multi,down and down, or we have it for both, having a different event flow based on if we are multi or not does not make sense. The normal event flow is: in;move;down for multi it would be in;down; that is weird,.

Jan 28 2020, 9:53 AM · DO NOT MERGE
bu5hm4n added a comment to D11205: ecore/input: attempt to more accurately handle multi-touch mouse-in events.

device is 0 on the eel that has ECORE_INPUT_DOWN...

Jan 28 2020, 9:49 AM · DO NOT MERGE
bu5hm4n added a comment to D11205: ecore/input: attempt to more accurately handle multi-touch mouse-in events.

IGNORE ME

Jan 28 2020, 9:41 AM · DO NOT MERGE
bu5hm4n added inline comments to D11205: ecore/input: attempt to more accurately handle multi-touch mouse-in events.
Jan 28 2020, 9:41 AM · DO NOT MERGE
zmike added a comment to D11205: ecore/input: attempt to more accurately handle multi-touch mouse-in events.

Yea remove L709, idk what I was thinking there.

Jan 28 2020, 9:28 AM · DO NOT MERGE
bu5hm4n added a comment to D11205: ecore/input: attempt to more accurately handle multi-touch mouse-in events.

That does not fix the issue... the move event is still sent when a second point is downed .

Jan 28 2020, 9:18 AM · DO NOT MERGE