Page MenuHomePhabricator

DO NOT MERGEProject
ActivePublic

Members

  • This project does not have any members.

Watchers

  • This project does not have any watchers.

Details

Description

For patches which should not yet be merged

Recent Activity

Today

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

more fixes better tests in elm_test

Tue, Jul 16, 2:13 AM · DO NOT MERGE, efl

Sun, Jul 14

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

forgot a few files

Sun, Jul 14, 10:05 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D9285: Introduce Efl.Ui.Item_Container.

The widget meanwhile is feature complete, there are tests for the grid position manager and list position manager. The tests for now are only plain copies. Given the complexity of this widget, there will 100% be more bugs to find, and things to clarify, so I would be very happy if people could write examples for that, play with the API, do things that i did not think of. Or simply play around in the tests. Thank you :)

Sun, Jul 14, 2:03 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • more tests
Sun, Jul 14, 2:00 AM · DO NOT MERGE, efl

Fri, Jul 12

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

add grid position manager and tests

Fri, Jul 12, 2:36 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D9285: Introduce Efl.Ui.Item_Container.

On the technical side, I am not sure how I am going to implement the accessor for items as they will be build asynchronously on demand, I wonder how to notify the position manager that they now exist while they didn't before. I am guessing that the best approach for the CollectionView will be to use custom accessor that bind to the data model and the local storage for widget. It seems doable at this point.

Fri, Jul 12, 2:08 AM · DO NOT MERGE, efl

Thu, Jul 11

SanghyeonLee added a comment to D9285: Introduce Efl.Ui.Item_Container.

well then we could think about another names,
itemBox, itemWidget, itemScroller(?) itemCollection, itemLayout, itemController...
but most of these are also have same problem...

Thu, Jul 11, 8:22 PM · DO NOT MERGE, efl
cedric added a comment to D9285: Introduce Efl.Ui.Item_Container.

Not to sure of the naming. Efl.Ui.Item_Container seems wrong. What other kind of Efl.Ui.Container would we have that would contain something different? It sounds like a boat for water kind of naming. Not really the most important bit, but that is going to take some time to discuss and find a good name.

Thu, Jul 11, 4:50 PM · DO NOT MERGE, efl
bu5hm4n added a project to D9285: Introduce Efl.Ui.Item_Container: DO NOT MERGE.
Thu, Jul 11, 8:29 AM · DO NOT MERGE, efl

Wed, Jul 10

lauromoura updated the diff for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

Updating after big changes.

Wed, Jul 10, 3:16 PM · efl: language bindings, Restricted Project

Mon, Jul 8

zmike added a project to D9123: ci: move release-ready to default build and enable tests+install on it: DO NOT MERGE.

Alright this is fixed in upstream meson but it'll probably be a while before the changes are available and I don't really want to be patching meson manually on CI

Mon, Jul 8, 9:29 AM · DO NOT MERGE, efl

Fri, Jun 28

lauromoura updated the diff for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

Another round with some fixes.

Fri, Jun 28, 3:18 PM · efl: language bindings, Restricted Project
lauromoura commandeered D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.
Fri, Jun 28, 3:10 PM · efl: language bindings, Restricted Project

Thu, Jun 27

zmike accepted D9171: efl_input_interface: verify check cancel event.
Thu, Jun 27, 7:24 AM · efl
bu5hm4n updated the diff for D9171: efl_input_interface: verify check cancel event.

more test

Thu, Jun 27, 7:22 AM · efl
zmike requested changes to D9171: efl_input_interface: verify check cancel event.

Like I said, this should also verify that the sequence of down -> cancel -> up occurs in the expected order and that the event info in down matches the info in cancel.

Thu, Jun 27, 6:59 AM · efl
bu5hm4n updated the diff for D9171: efl_input_interface: verify check cancel event.

yey there is a event!!!

Thu, Jun 27, 6:22 AM · efl

Wed, Jun 26

zmike requested changes to D9171: efl_input_interface: verify check cancel event.

Check out D9184, I think this test needs to verify that the 'up' event is also emitted after cancel

Wed, Jun 26, 7:32 AM · efl

Tue, Jun 25

bu5hm4n added a project to D9171: efl_input_interface: verify check cancel event: DO NOT MERGE.

This here is a funny one, we are defining the event, but we are not emitting it at all, where or how should we emit this one ? In legacy it seems like we do not have something like this.
Does someone know where or how to emit this ?

Tue, Jun 25, 1:36 AM · efl

May 27 2019

segfaultxavi added a comment to D9027: autotools: REMOVAL!.

May 27 2019, 1:14 AM · efl

May 26 2019

bu5hm4n added a comment to D9027: autotools: REMOVAL!.

According to the mailing thread, this should be merged on the 30.05, if nothing else comes up.

May 26 2019, 9:42 AM · efl
bu5hm4n added a project to D9027: autotools: REMOVAL!: DO NOT MERGE.
May 26 2019, 9:41 AM · efl

May 19 2019

SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

can you update status of this diff?

May 19 2019, 10:56 PM · efl: language bindings, Restricted Project

May 17 2019

bu5hm4n added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Thank you :)

May 17 2019, 4:01 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

I apologize. I've submitted a patch to fix it. 099eb2c315a277bda10f41709d7f936b0ae7fb20

May 17 2019, 3:53 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

@Jaehyun_Cho Can you *please* *please* *please* be more carefull reviewing these meson changes. The eo files here are just plainly not installed anymore. because line 26 was removed. Additionally, its pure luck that this still works in meson, because you actually pass now a array with a array in array element nr. 0 followed by strings. This is not supported by meson and really only works by luck.

May 17 2019, 2:18 AM · DO NOT MERGE, efl

May 14 2019

Jaehyun_Cho closed D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 14 2019, 12:38 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 14 2019, 12:36 AM · DO NOT MERGE, efl
Jaehyun_Cho updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

rebase

May 14 2019, 12:35 AM · DO NOT MERGE, efl

May 9 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

mesong build support

May 9 2019, 10:18 PM · DO NOT MERGE, efl
zmike removed a parent revision for D8852: evas: enable setting any object as a clipper: D8851: edje/calc: correctly handle swallow/group objects as clippers for state clips.
May 9 2019, 5:54 AM · efl
zmike added a child revision for D8852: evas: enable setting any object as a clipper: D8850: elm_test: add smart object mask test to existing masking test.
May 9 2019, 5:54 AM · efl
zmike edited parent revisions for D8850: elm_test: add smart object mask test to existing masking test, added: 1; removed: 1.
May 9 2019, 5:54 AM · efl
zmike removed a child revision for D8850: elm_test: add smart object mask test to existing masking test: D8851: edje/calc: correctly handle swallow/group objects as clippers for state clips.
May 9 2019, 5:54 AM · efl
zmike added a project to D8850: elm_test: add smart object mask test to existing masking test: DO NOT MERGE.
May 9 2019, 5:53 AM · efl
zmike added a project to D8853: edje_cc: remove compile fails when setting a complex object as a clipper: DO NOT MERGE.
May 9 2019, 5:53 AM · efl
zmike added a project to D8852: evas: enable setting any object as a clipper: DO NOT MERGE.

This is a good point. I've done some testing locally and it doesn't work quite right yet.

May 9 2019, 5:52 AM · efl

May 8 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Meson build support

May 8 2019, 11:46 PM · DO NOT MERGE, efl

May 7 2019

bu5hm4n planned changes to D8845: efl_ui_grid: refactor into container subclass.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
bu5hm4n added a project to D8845: efl_ui_grid: refactor into container subclass: DO NOT MERGE.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
bu5hm4n removed a parent revision for D8845: efl_ui_grid: refactor into container subclass: D8830: efl_ui_item: migrate to Efl.Ui.Clickable.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

When I tried to build with meson, build error happens because efl_gesture_events.eo is dependent on efl_canvas_gesture_xxx.eo

May 7 2019, 4:31 AM · DO NOT MERGE, efl

May 2 2019

Jaehyun_Cho requested changes to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

need to check meson build

May 2 2019, 5:37 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 2 2019, 5:33 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Code clean up to following comments.

May 2 2019, 5:19 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Could you check and remove EINA_UNUSED which are not supposed to be used?

May 2 2019, 4:10 AM · DO NOT MERGE, efl

Apr 29 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Fix build warning.

Apr 29 2019, 12:40 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Remove Conflict

Apr 29 2019, 12:33 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Code clean up.

Apr 29 2019, 12:02 AM · DO NOT MERGE, efl

Apr 28 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Update code to supprt c# binding.

Apr 28 2019, 11:09 PM · DO NOT MERGE, efl